@telora/daemon 0.24.25 → 0.24.29

package/dist/queries/focus-review/recorded-concern-ids.d.ts

@@ -1,8 +1,24 @@
 /**
- * The RECORDED CONCERNS of a focus, as pure functions over its review-finding
- * facts (queries/focus-review/review-finding-facts.ts): a concern is a
- * review-filed finding recorded with class `concern`. It is recorded for the
- * human and the next arm and is never the running team's work.
+ * THE review-finding rule, daemon side, and the RECORDED CONCERNS of a focus as
+ * pure functions over its review-finding facts
+ * (queries/focus-review/review-finding-facts.ts).
+ *
+ *   A finding blocks only when a not_met acceptance criterion names it. Every
+ *   other issue a review files is a CONCERN: recorded for the human and the
+ *   next arm, never the running team's work, never holding its delivery.
+ *
+ * findingClassOf is a hand MIRROR of the canonical
+ * supabase/functions/_shared/review-finding-class.ts findingClassOf (the daemon
+ * cannot import the Deno tree at runtime); review-finding-class-parity.test.ts
+ * runs both over one case matrix and fails on the first disagreement. Every
+ * daemon reader classifies through it: the live delivery writers
+ * (delivery/recorded-concerns.ts), the review exit
+ * (completion/review-exit/review-defect-detector.ts isBlockingReviewFinding),
+ * the team prompt's listing and the ended-arm summary.
+ *
+ * A daemon-filed rework Bug (gate or shortfall) is never a review finding,
+ * whatever session it was credited to (isDaemonReworkIssue): it is owed work by
+ * construction.
  *
  * Kept apart from the facts READ so a pure caller (the team prompt's listing,
  * the reconcile writers) does not import the API client.
@@ -10,17 +26,38 @@
  * @module queries/focus-review/recorded-concern-ids
  */
 import type { ReviewFindingClass } from './review-finding-facts.js';
+/**
+ * MIRROR of _shared/review-finding-class.ts findingClassOf. The class of one
+ * issue under the rule: null = not a review finding (ordinary owed work);
+ * 'blocking' = review-filed and recorded blocking (a not_met criterion names
+ * it); 'concern' = review-filed and anything else -- recorded concern, or no
+ * class reached the reader (an older edge's link-less review). Pure.
+ */
+export declare function findingClassOf(issueId: string, reviewFiledIds: ReadonlySet<string>, findingClasses: ReadonlyMap<string, ReviewFindingClass>): ReviewFindingClass | null;
+/** MIRROR of _shared/review-finding-class.ts isBlockingFinding: only a recorded 'blocking' blocks. Pure. */
+export declare function isBlockingFinding(issueId: string, findingClasses: ReadonlyMap<string, ReviewFindingClass>): boolean;
+/**
+ * Whether an issue is a daemon-filed rework Bug -- a failed gate's
+ * (isGateReworkIssue) or a verify shortfall's (isShortfallReworkIssue). Such a
+ * Bug is owed work by construction and is never a review finding, even when an
+ * older edge credited it to a review session that was live when it was filed.
+ * An issue whose title is not known is not one. Pure.
+ */
+export declare function isDaemonReworkIssue(issue: {
+    title?: string | null;
+}): boolean;
 /** The facts as the pure helpers below read them (a FocusReviewFindingFacts, or the review exit's id set + classes). */
 export interface ReviewFindingFactsView {
     issueIds: Iterable<string>;
     findingClasses: ReadonlyMap<string, ReviewFindingClass>;
 }
 /**
- * Pure: the ids of the RECORDED CONCERNS among the facts -- review-filed (in
- * `issueIds`) AND recorded with class `concern`. An issue with no recorded class
- * is NOT a concern: it stays owed work, exactly as before classes were recorded.
- * A concern is recorded for the human and the next arm; it is not the running
- * team's work (prompt-sections/prompt-listing.ts splitRecordedConcerns).
+ * Pure: the ids of the RECORDED CONCERNS among the facts -- every review-filed
+ * id (in `issueIds`) findingClassOf calls a concern: anything no not_met
+ * criterion names, an id with no class included. A concern is recorded for the
+ * human and the next arm; it is not the running team's work
+ * (prompt-sections/prompt-listing.ts splitRecordedConcerns). A caller holding
+ * the issues' titles also drops daemon rework Bugs (isDaemonReworkIssue).
  */
 export declare function recordedConcernIds(facts: ReviewFindingFactsView): Set<string>;
 /** One open recorded concern, as a human-facing summary names it. */
@@ -34,8 +71,8 @@ export interface OpenConcernSummary {
  * Pure: every OPEN recorded concern among `issues`, by key and title -- the
  * "Open concerns (recorded by review, not worked by this arm)" list a human reads
  * when the armed run ends (queries/focuses/ended-arm.ts `openConcerns`). Closed
- * concerns (Done / Verified / In Review / Cancelled ...) are not listed; an issue
- * with no recorded class is not a concern.
+ * concerns (Done / Verified / In Review / Cancelled ...) are not listed, nor is a
+ * daemon rework Bug.
  */
 export declare function openRecordedConcerns(issues: ReadonlyArray<{
     id: string;

package/dist/queries/focus-review/recorded-concern-ids.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"recorded-concern-ids.d.ts","sourceRoot":"","sources":["../../../src/queries/focus-review/recorded-concern-ids.ts"],"names":[],"mappings":"AAIA;;;;;;;;;;GAUG;AAEH,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,2BAA2B,CAAC;AAGpE,wHAAwH;AACxH,MAAM,WAAW,sBAAsB;IACrC,QAAQ,EAAE,QAAQ,CAAC,MAAM,CAAC,CAAC;IAC3B,cAAc,EAAE,WAAW,CAAC,MAAM,EAAE,kBAAkB,CAAC,CAAC;CACzD;AAED;;;;;;GAMG;AACH,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,sBAAsB,GAAG,GAAG,CAAC,MAAM,CAAC,CAM7E;AAED,qEAAqE;AACrE,MAAM,WAAW,kBAAkB;IACjC,EAAE,EAAE,MAAM,CAAC;IACX,GAAG,EAAE,MAAM,CAAC;IACZ,KAAK,EAAE,MAAM,CAAC;IACd,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;CAC3B;AAED;;;;;;GAMG;AACH,wBAAgB,oBAAoB,CAClC,MAAM,EAAE,aAAa,CAAC;IAAE,EAAE,EAAE,MAAM,CAAC;IAAC,GAAG,EAAE,MAAM,CAAC;IAAC,KAAK,EAAE,MAAM,CAAC;IAAC,MAAM,EAAE,MAAM,CAAC;IAAC,UAAU,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;CAAE,CAAC,EAC7G,KAAK,EAAE,sBAAsB,GAC5B,kBAAkB,EAAE,CAKtB"}
+{"version":3,"file":"recorded-concern-ids.d.ts","sourceRoot":"","sources":["../../../src/queries/focus-review/recorded-concern-ids.ts"],"names":[],"mappings":"AAKA;;;;;;;;;;;;;;;;;;;;;;;;;;GA0BG;AAEH,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,2BAA2B,CAAC;AAGpE;;;;;;GAMG;AACH,wBAAgB,cAAc,CAC5B,OAAO,EAAE,MAAM,EACf,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,EACnC,cAAc,EAAE,WAAW,CAAC,MAAM,EAAE,kBAAkB,CAAC,GACtD,kBAAkB,GAAG,IAAI,CAG3B;AAED,4GAA4G;AAC5G,wBAAgB,iBAAiB,CAC/B,OAAO,EAAE,MAAM,EACf,cAAc,EAAE,WAAW,CAAC,MAAM,EAAE,kBAAkB,CAAC,GACtD,OAAO,CAET;AAED;;;;;;GAMG;AACH,wBAAgB,mBAAmB,CAAC,KAAK,EAAE;IAAE,KAAK,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;CAAE,GAAG,OAAO,CAG7E;AAED,wHAAwH;AACxH,MAAM,WAAW,sBAAsB;IACrC,QAAQ,EAAE,QAAQ,CAAC,MAAM,CAAC,CAAC;IAC3B,cAAc,EAAE,WAAW,CAAC,MAAM,EAAE,kBAAkB,CAAC,CAAC;CACzD;AAED;;;;;;;GAOG;AACH,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,sBAAsB,GAAG,GAAG,CAAC,MAAM,CAAC,CAO7E;AAED,qEAAqE;AACrE,MAAM,WAAW,kBAAkB;IACjC,EAAE,EAAE,MAAM,CAAC;IACX,GAAG,EAAE,MAAM,CAAC;IACZ,KAAK,EAAE,MAAM,CAAC;IACd,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;CAC3B;AAED;;;;;;GAMG;AACH,wBAAgB,oBAAoB,CAClC,MAAM,EAAE,aAAa,CAAC;IAAE,EAAE,EAAE,MAAM,CAAC;IAAC,GAAG,EAAE,MAAM,CAAC;IAAC,KAAK,EAAE,MAAM,CAAC;IAAC,MAAM,EAAE,MAAM,CAAC;IAAC,UAAU,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;CAAE,CAAC,EAC7G,KAAK,EAAE,sBAAsB,GAC5B,kBAAkB,EAAE,CAKtB"}

package/dist/queries/focus-review/recorded-concern-ids.js

@@ -1,18 +1,48 @@
 // PINNED-BY-BEGIN (generated by gen:pinned-by -- do not hand-edit; checked by lint:pinned-by)
-// Pinned by: packages/daemon/src/prompt/recorded-concerns-not-owed-work.test.ts
+// Pinned by: packages/daemon/src/prompt/recorded-concerns-not-owed-work.test.ts,
+//   packages/daemon/src/queries/focus-review/review-finding-class-parity.test.ts
 // PINNED-BY-END
-import { OPEN_ISSUE_STATUSES } from '../../types/issue-status.js';
+import { OPEN_ISSUE_STATUSES, isGateReworkIssue, isShortfallReworkIssue } from '../../types/issue-status.js';
 /**
- * Pure: the ids of the RECORDED CONCERNS among the facts -- review-filed (in
- * `issueIds`) AND recorded with class `concern`. An issue with no recorded class
- * is NOT a concern: it stays owed work, exactly as before classes were recorded.
- * A concern is recorded for the human and the next arm; it is not the running
- * team's work (prompt-sections/prompt-listing.ts splitRecordedConcerns).
+ * MIRROR of _shared/review-finding-class.ts findingClassOf. The class of one
+ * issue under the rule: null = not a review finding (ordinary owed work);
+ * 'blocking' = review-filed and recorded blocking (a not_met criterion names
+ * it); 'concern' = review-filed and anything else -- recorded concern, or no
+ * class reached the reader (an older edge's link-less review). Pure.
+ */
+export function findingClassOf(issueId, reviewFiledIds, findingClasses) {
+    if (!reviewFiledIds.has(issueId))
+        return null;
+    return findingClasses.get(issueId) === 'blocking' ? 'blocking' : 'concern';
+}
+/** MIRROR of _shared/review-finding-class.ts isBlockingFinding: only a recorded 'blocking' blocks. Pure. */
+export function isBlockingFinding(issueId, findingClasses) {
+    return findingClasses.get(issueId) === 'blocking';
+}
+/**
+ * Whether an issue is a daemon-filed rework Bug -- a failed gate's
+ * (isGateReworkIssue) or a verify shortfall's (isShortfallReworkIssue). Such a
+ * Bug is owed work by construction and is never a review finding, even when an
+ * older edge credited it to a review session that was live when it was filed.
+ * An issue whose title is not known is not one. Pure.
+ */
+export function isDaemonReworkIssue(issue) {
+    const title = issue.title;
+    return typeof title === 'string' && (isGateReworkIssue({ title }) || isShortfallReworkIssue({ title }));
+}
+/**
+ * Pure: the ids of the RECORDED CONCERNS among the facts -- every review-filed
+ * id (in `issueIds`) findingClassOf calls a concern: anything no not_met
+ * criterion names, an id with no class included. A concern is recorded for the
+ * human and the next arm; it is not the running team's work
+ * (prompt-sections/prompt-listing.ts splitRecordedConcerns). A caller holding
+ * the issues' titles also drops daemon rework Bugs (isDaemonReworkIssue).
  */
 export function recordedConcernIds(facts) {
+    const filed = new Set(facts.issueIds);
     const concerns = new Set();
-    for (const id of facts.issueIds) {
-        if (facts.findingClasses.get(id) === 'concern')
+    for (const id of filed) {
+        if (findingClassOf(id, filed, facts.findingClasses) === 'concern')
             concerns.add(id);
     }
     return concerns;
@@ -21,13 +51,13 @@ export function recordedConcernIds(facts) {
  * Pure: every OPEN recorded concern among `issues`, by key and title -- the
  * "Open concerns (recorded by review, not worked by this arm)" list a human reads
  * when the armed run ends (queries/focuses/ended-arm.ts `openConcerns`). Closed
- * concerns (Done / Verified / In Review / Cancelled ...) are not listed; an issue
- * with no recorded class is not a concern.
+ * concerns (Done / Verified / In Review / Cancelled ...) are not listed, nor is a
+ * daemon rework Bug.
  */
 export function openRecordedConcerns(issues, facts) {
     const concernIds = recordedConcernIds(facts);
     return issues
-        .filter((i) => concernIds.has(i.id) && OPEN_ISSUE_STATUSES.has(i.status))
+        .filter((i) => concernIds.has(i.id) && !isDaemonReworkIssue(i) && OPEN_ISSUE_STATUSES.has(i.status))
         .map((i) => ({ id: i.id, key: i.key, title: i.title, deliveryId: i.deliveryId ?? null }));
 }
 //# sourceMappingURL=recorded-concern-ids.js.map

package/dist/queries/focus-review/recorded-concern-ids.js.map

@@ -1 +1 @@
-{"version":3,"file":"recorded-concern-ids.js","sourceRoot":"","sources":["../../../src/queries/focus-review/recorded-concern-ids.ts"],"names":[],"mappings":"AAAA,8FAA8F;AAC9F,gFAAgF;AAChF,gBAAgB;AAehB,OAAO,EAAE,mBAAmB,EAAE,MAAM,6BAA6B,CAAC;AAQlE;;;;;;GAMG;AACH,MAAM,UAAU,kBAAkB,CAAC,KAA6B;IAC9D,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAC;IACnC,KAAK,MAAM,EAAE,IAAI,KAAK,CAAC,QAAQ,EAAE,CAAC;QAChC,IAAI,KAAK,CAAC,cAAc,CAAC,GAAG,CAAC,EAAE,CAAC,KAAK,SAAS;YAAE,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IACnE,CAAC;IACD,OAAO,QAAQ,CAAC;AAClB,CAAC;AAUD;;;;;;GAMG;AACH,MAAM,UAAU,oBAAoB,CAClC,MAA6G,EAC7G,KAA6B;IAE7B,MAAM,UAAU,GAAG,kBAAkB,CAAC,KAAK,CAAC,CAAC;IAC7C,OAAO,MAAM;SACV,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,IAAI,mBAAmB,CAAC,GAAG,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC;SACxE,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC,EAAE,EAAE,GAAG,EAAE,CAAC,CAAC,GAAG,EAAE,KAAK,EAAE,CAAC,CAAC,KAAK,EAAE,UAAU,EAAE,CAAC,CAAC,UAAU,IAAI,IAAI,EAAE,CAAC,CAAC,CAAC;AAC9F,CAAC"}
+{"version":3,"file":"recorded-concern-ids.js","sourceRoot":"","sources":["../../../src/queries/focus-review/recorded-concern-ids.ts"],"names":[],"mappings":"AAAA,8FAA8F;AAC9F,iFAAiF;AACjF,iFAAiF;AACjF,gBAAgB;AA+BhB,OAAO,EAAE,mBAAmB,EAAE,iBAAiB,EAAE,sBAAsB,EAAE,MAAM,6BAA6B,CAAC;AAE7G;;;;;;GAMG;AACH,MAAM,UAAU,cAAc,CAC5B,OAAe,EACf,cAAmC,EACnC,cAAuD;IAEvD,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,OAAO,CAAC;QAAE,OAAO,IAAI,CAAC;IAC9C,OAAO,cAAc,CAAC,GAAG,CAAC,OAAO,CAAC,KAAK,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,CAAC;AAC7E,CAAC;AAED,4GAA4G;AAC5G,MAAM,UAAU,iBAAiB,CAC/B,OAAe,EACf,cAAuD;IAEvD,OAAO,cAAc,CAAC,GAAG,CAAC,OAAO,CAAC,KAAK,UAAU,CAAC;AACpD,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,mBAAmB,CAAC,KAAgC;IAClE,MAAM,KAAK,GAAG,KAAK,CAAC,KAAK,CAAC;IAC1B,OAAO,OAAO,KAAK,KAAK,QAAQ,IAAI,CAAC,iBAAiB,CAAC,EAAE,KAAK,EAAE,CAAC,IAAI,sBAAsB,CAAC,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC;AAC1G,CAAC;AAQD;;;;;;;GAOG;AACH,MAAM,UAAU,kBAAkB,CAAC,KAA6B;IAC9D,MAAM,KAAK,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;IACtC,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAC;IACnC,KAAK,MAAM,EAAE,IAAI,KAAK,EAAE,CAAC;QACvB,IAAI,cAAc,CAAC,EAAE,EAAE,KAAK,EAAE,KAAK,CAAC,cAAc,CAAC,KAAK,SAAS;YAAE,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IACtF,CAAC;IACD,OAAO,QAAQ,CAAC;AAClB,CAAC;AAUD;;;;;;GAMG;AACH,MAAM,UAAU,oBAAoB,CAClC,MAA6G,EAC7G,KAA6B;IAE7B,MAAM,UAAU,GAAG,kBAAkB,CAAC,KAAK,CAAC,CAAC;IAC7C,OAAO,MAAM;SACV,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,IAAI,CAAC,mBAAmB,CAAC,CAAC,CAAC,IAAI,mBAAmB,CAAC,GAAG,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC;SACnG,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC,EAAE,EAAE,GAAG,EAAE,CAAC,CAAC,GAAG,EAAE,KAAK,EAAE,CAAC,CAAC,KAAK,EAAE,UAAU,EAAE,CAAC,CAAC,UAAU,IAAI,IAAI,EAAE,CAAC,CAAC,CAAC;AAC9F,CAAC"}

package/dist/queries/focus-review/review-criterion-verdicts.d.ts

@@ -0,0 +1,37 @@
+/** The action this module calls. */
+export declare const LIST_REVIEW_CRITERION_VERDICTS_ACTION = "daemon_list_review_criterion_verdicts";
+/** A review's verdict on one criterion (one element of focus_reviews.criterion_verdicts). */
+export interface CriterionVerdictRecord {
+    /** `node:<uuid>` for a tree criterion, `text:<normalized>` for a declared one. */
+    criterionKey: string;
+    nodeId: string | null;
+    source: 'tree' | 'delivery' | 'focus';
+    criterion: string;
+    verdict: 'met' | 'not_met' | 'excused';
+    /** The issues a not_met verdict names. */
+    issueIds: string[];
+}
+/** One completed, verdict-bearing review under the arm. */
+export interface ReviewVerdictRecord {
+    reviewId: string;
+    completedAt: string;
+    outcome: string;
+    criterionVerdicts: CriterionVerdictRecord[];
+    /**
+     * The agreed criteria the review left WITHOUT a verdict, by criterion key (a
+     * gaps_found may leave some). [] when it judged every criterion -- and on an
+     * older edge or a review stored before the edge recorded them, which
+     * therefore read as fully judged.
+     */
+    unjudgedCriterionKeys?: string[];
+    /** The review's stored blocking set; null = its not_met verdicts named no issue (nothing blocks). */
+    blockingIssueIds: string[] | null;
+    createdIssueIds: string[];
+    /** The focus-branch commit the review judged; absent/null when unrecorded or on an older edge. */
+    reviewedSha?: string | null;
+    /** The review's summary markdown (each verdict's reasoning); absent/null when none or on an older edge. */
+    summary?: string | null;
+}
+/** The focus's verdict-bearing reviews since its arm, newest first, at most `limit`. Throws on failure. */
+export declare function listReviewCriterionVerdicts(focusId: string, limit: number): Promise<ReviewVerdictRecord[]>;
+//# sourceMappingURL=review-criterion-verdicts.d.ts.map

package/dist/queries/focus-review/review-criterion-verdicts.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-criterion-verdicts.d.ts","sourceRoot":"","sources":["../../../src/queries/focus-review/review-criterion-verdicts.ts"],"names":[],"mappings":"AA2BA,oCAAoC;AACpC,eAAO,MAAM,qCAAqC,0CAA0C,CAAC;AAE7F,6FAA6F;AAC7F,MAAM,WAAW,sBAAsB;IACrC,kFAAkF;IAClF,YAAY,EAAE,MAAM,CAAC;IACrB,MAAM,EAAE,MAAM,GAAG,IAAI,CAAC;IACtB,MAAM,EAAE,MAAM,GAAG,UAAU,GAAG,OAAO,CAAC;IACtC,SAAS,EAAE,MAAM,CAAC;IAClB,OAAO,EAAE,KAAK,GAAG,SAAS,GAAG,SAAS,CAAC;IACvC,0CAA0C;IAC1C,QAAQ,EAAE,MAAM,EAAE,CAAC;CACpB;AAED,2DAA2D;AAC3D,MAAM,WAAW,mBAAmB;IAClC,QAAQ,EAAE,MAAM,CAAC;IACjB,WAAW,EAAE,MAAM,CAAC;IACpB,OAAO,EAAE,MAAM,CAAC;IAChB,iBAAiB,EAAE,sBAAsB,EAAE,CAAC;IAC5C;;;;;OAKG;IACH,qBAAqB,CAAC,EAAE,MAAM,EAAE,CAAC;IACjC,qGAAqG;IACrG,gBAAgB,EAAE,MAAM,EAAE,GAAG,IAAI,CAAC;IAClC,eAAe,EAAE,MAAM,EAAE,CAAC;IAC1B,kGAAkG;IAClG,WAAW,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IAC5B,2GAA2G;IAC3G,OAAO,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;CACzB;AAyBD,2GAA2G;AAC3G,wBAAsB,2BAA2B,CAAC,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,GAAG,OAAO,CAAC,mBAAmB,EAAE,CAAC,CAiBhH"}

package/dist/queries/focus-review/review-criterion-verdicts.js

@@ -0,0 +1,64 @@
+// PINNED-BY-BEGIN (generated by gen:pinned-by -- do not hand-edit; checked by lint:pinned-by)
+// Pinned by: packages/daemon/src/completion/review-cycle-budget/review-cycle-cap-regression.test.ts,
+//   packages/daemon/src/completion/review-cycle-budget/review-loop-detection.test.ts,
+//   packages/daemon/src/queries/focus-review/review-criterion-verdicts.test.ts,
+//   packages/daemon/src/supervision/review-loop-detector.test.ts,
+//   packages/daemon/src/tower/tower-supervisor.test.ts
+// PINNED-BY-END
+/**
+ * The read of a focus's per-criterion review verdicts: product-api
+ * `daemon_list_review_criterion_verdicts`, which answers the focus's
+ * verdict-bearing reviews completed since the arm instant, NEWEST FIRST, each
+ * with focus_reviews.criterion_verdicts and its stored blocking / created
+ * issue ids. A focus with no arm stamp answers none (the history starts at the
+ * arm, as the criterion-reopening history does).
+ *
+ * The review-loop detector decides on it
+ * (supervision/review-loop-detector.ts). Throws on a failed call or a
+ * malformed answer; the caller (completion/review-cycle-budget/review-loop-detection.ts)
+ * owns swallowing it.
+ *
+ * @module queries/focus-review/review-criterion-verdicts
+ */
+import { z } from 'zod';
+import { callApiValidated } from '../api-client/shared.js';
+/** The action this module calls. */
+export const LIST_REVIEW_CRITERION_VERDICTS_ACTION = 'daemon_list_review_criterion_verdicts';
+const VerdictSchema = z.object({
+    criterionKey: z.string(),
+    nodeId: z.string().nullable(),
+    source: z.enum(['tree', 'delivery', 'focus']),
+    criterion: z.string(),
+    verdict: z.enum(['met', 'not_met', 'excused']),
+    issueIds: z.array(z.string()),
+}).passthrough();
+const ReviewSchema = z.object({
+    reviewId: z.string(),
+    completedAt: z.string(),
+    outcome: z.string(),
+    criterionVerdicts: z.array(VerdictSchema),
+    unjudgedCriterionKeys: z.array(z.string()).optional(),
+    blockingIssueIds: z.array(z.string()).nullable(),
+    createdIssueIds: z.array(z.string()),
+    reviewedSha: z.string().nullable().optional(),
+    summary: z.string().nullable().optional(),
+}).passthrough();
+const ResponseSchema = z.object({ reviews: z.array(ReviewSchema) }).passthrough();
+/** The focus's verdict-bearing reviews since its arm, newest first, at most `limit`. Throws on failure. */
+export async function listReviewCriterionVerdicts(focusId, limit) {
+    const res = await callApiValidated(LIST_REVIEW_CRITERION_VERDICTS_ACTION, ResponseSchema, { focusId, limit });
+    return res.reviews.map((r) => ({
+        reviewId: r.reviewId,
+        completedAt: r.completedAt,
+        outcome: r.outcome,
+        criterionVerdicts: r.criterionVerdicts.map((v) => ({
+            criterionKey: v.criterionKey, nodeId: v.nodeId, source: v.source, criterion: v.criterion, verdict: v.verdict, issueIds: v.issueIds,
+        })),
+        unjudgedCriterionKeys: r.unjudgedCriterionKeys ?? [],
+        blockingIssueIds: r.blockingIssueIds,
+        createdIssueIds: r.createdIssueIds,
+        reviewedSha: r.reviewedSha ?? null,
+        summary: r.summary ?? null,
+    }));
+}
+//# sourceMappingURL=review-criterion-verdicts.js.map

package/dist/queries/focus-review/review-criterion-verdicts.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-criterion-verdicts.js","sourceRoot":"","sources":["../../../src/queries/focus-review/review-criterion-verdicts.ts"],"names":[],"mappings":"AAAA,8FAA8F;AAC9F,qGAAqG;AACrG,sFAAsF;AACtF,gFAAgF;AAChF,kEAAkE;AAClE,uDAAuD;AACvD,gBAAgB;AAEhB;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AACxB,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAE3D,oCAAoC;AACpC,MAAM,CAAC,MAAM,qCAAqC,GAAG,uCAAuC,CAAC;AAoC7F,MAAM,aAAa,GAAG,CAAC,CAAC,MAAM,CAAC;IAC7B,YAAY,EAAE,CAAC,CAAC,MAAM,EAAE;IACxB,MAAM,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE;IAC7B,MAAM,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,UAAU,EAAE,OAAO,CAAC,CAAC;IAC7C,SAAS,EAAE,CAAC,CAAC,MAAM,EAAE;IACrB,OAAO,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,SAAS,EAAE,SAAS,CAAC,CAAC;IAC9C,QAAQ,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC;CAC9B,CAAC,CAAC,WAAW,EAAE,CAAC;AAEjB,MAAM,YAAY,GAAG,CAAC,CAAC,MAAM,CAAC;IAC5B,QAAQ,EAAE,CAAC,CAAC,MAAM,EAAE;IACpB,WAAW,EAAE,CAAC,CAAC,MAAM,EAAE;IACvB,OAAO,EAAE,CAAC,CAAC,MAAM,EAAE;IACnB,iBAAiB,EAAE,CAAC,CAAC,KAAK,CAAC,aAAa,CAAC;IACzC,qBAAqB,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,QAAQ,EAAE;IACrD,gBAAgB,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,QAAQ,EAAE;IAChD,eAAe,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC;IACpC,WAAW,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE,CAAC,QAAQ,EAAE;IAC7C,OAAO,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE,CAAC,QAAQ,EAAE;CAC1C,CAAC,CAAC,WAAW,EAAE,CAAC;AAEjB,MAAM,cAAc,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,OAAO,EAAE,CAAC,CAAC,KAAK,CAAC,YAAY,CAAC,EAAE,CAAC,CAAC,WAAW,EAAE,CAAC;AAElF,2GAA2G;AAC3G,MAAM,CAAC,KAAK,UAAU,2BAA2B,CAAC,OAAe,EAAE,KAAa;IAC9E,MAAM,GAAG,GAAmC,MAAM,gBAAgB,CAChE,qCAAqC,EAAE,cAAc,EAAE,EAAE,OAAO,EAAE,KAAK,EAAE,CAC1E,CAAC;IACF,OAAO,GAAG,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;QAC7B,QAAQ,EAAE,CAAC,CAAC,QAAQ;QACpB,WAAW,EAAE,CAAC,CAAC,WAAW;QAC1B,OAAO,EAAE,CAAC,CAAC,OAAO;QAClB,iBAAiB,EAAE,CAAC,CAAC,iBAAiB,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YACjD,YAAY,EAAE,CAAC,CAAC,YAAY,EAAE,MAAM,EAAE,CAAC,CAAC,MAAM,EAAE,MAAM,EAAE,CAAC,CAAC,MAAM,EAAE,SAAS,EAAE,CAAC,CAAC,SAAS,EAAE,OAAO,EAAE,CAAC,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,CAAC,QAAQ;SACnI,CAAC,CAAC;QACH,qBAAqB,EAAE,CAAC,CAAC,qBAAqB,IAAI,EAAE;QACpD,gBAAgB,EAAE,CAAC,CAAC,gBAAgB;QACpC,eAAe,EAAE,CAAC,CAAC,eAAe;QAClC,WAAW,EAAE,CAAC,CAAC,WAAW,IAAI,IAAI;QAClC,OAAO,EAAE,CAAC,CAAC,OAAO,IAAI,IAAI;KAC3B,CAAC,CAAC,CAAC;AACN,CAAC"}

package/dist/queries/focus-review/review-finding-facts.d.ts

@@ -7,12 +7,17 @@
  * `focus_review_filed_issue_ids` returns `issueIds: string[]` and, from the edge
  * that records finding classes on, `findingClasses: Record<issueId,
  * 'blocking' | 'concern'>`. An OLDER edge omits `findingClasses`; that reads as
- * an empty map, so every finding falls back to the priority rule
- * (completion/review-exit/review-defect-detector.ts isBlockingReviewFinding). An issue
- * absent from the map likewise has no recorded fact.
+ * an empty map, and under the one rule (recorded-concern-ids.ts findingClassOf)
+ * every review-filed issue with no recorded 'blocking' is a concern -- the
+ * absence of a naming is never a naming.
  *
- * The response is validated (zod) -- a malformed class value throws, and the
- * caller's best-effort read degrades exactly as a failed id read does.
+ * The response is validated (zod) -- a malformed class value throws.
+ *
+ * A READ THAT FAILS THROWS. No earlier answer stands in for it: the facts
+ * change whenever a review is recorded, and facts kept from before that review
+ * can call a finding it re-judged blocking a concern. Every reader that cannot
+ * read the classes DEFERS its decision instead (delivery/recorded-concerns.ts;
+ * the review exit's findingFactsUnreadable).
  *
  * @module queries/focus-review/review-finding-facts
  */
@@ -39,6 +44,13 @@ export interface FocusReviewFindingFacts {
 }
 /** Pure: normalize a validated response (missing keys -> empty). Exported for tests. */
 export declare function toReviewFindingFacts(response: z.infer<typeof FocusReviewFindingFactsResponseSchema>): FocusReviewFindingFacts;
-/** Read the focus-wide review-filed issue ids AND their recorded finding classes. */
+/** The wire shape of focus_review_filed_issue_ids. */
+export type FocusReviewFindingFactsResponse = z.infer<typeof FocusReviewFindingFactsResponseSchema>;
+/**
+ * Read the focus-wide review-filed issue ids AND their recorded finding classes
+ * through `read`. Throws when the read fails (module header).
+ */
+export declare function readFocusReviewFindingFactsVia(focusId: string, read: (focusId: string) => Promise<FocusReviewFindingFactsResponse>): Promise<FocusReviewFindingFacts>;
+/** Read the focus-wide review-filed issue ids AND their recorded finding classes over the API. */
 export declare function getFocusReviewFindingFacts(focusId: string): Promise<FocusReviewFindingFacts>;
 //# sourceMappingURL=review-finding-facts.d.ts.map

package/dist/queries/focus-review/review-finding-facts.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"review-finding-facts.d.ts","sourceRoot":"","sources":["../../../src/queries/focus-review/review-finding-facts.ts"],"names":[],"mappings":"AASA;;;;;;;;;;;;;;;;;GAiBG;AAEH,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AAExB;;;;;GAKG;AACH,MAAM,MAAM,kBAAkB,GAAG,UAAU,GAAG,SAAS,CAAC;AAIxD,wGAAwG;AACxG,eAAO,MAAM,qCAAqC;;;;;;iBAGlC,CAAC;AAEjB,sFAAsF;AACtF,MAAM,WAAW,uBAAuB;IACtC,QAAQ,EAAE,MAAM,EAAE,CAAC;IACnB,cAAc,EAAE,GAAG,CAAC,MAAM,EAAE,kBAAkB,CAAC,CAAC;CACjD;AAED,wFAAwF;AACxF,wBAAgB,oBAAoB,CAClC,QAAQ,EAAE,CAAC,CAAC,KAAK,CAAC,OAAO,qCAAqC,CAAC,GAC9D,uBAAuB,CAKzB;AAED,qFAAqF;AACrF,wBAAsB,0BAA0B,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAAC,uBAAuB,CAAC,CAOlG"}
+{"version":3,"file":"review-finding-facts.d.ts","sourceRoot":"","sources":["../../../src/queries/focus-review/review-finding-facts.ts"],"names":[],"mappings":"AAWA;;;;;;;;;;;;;;;;;;;;;;GAsBG;AAEH,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AAGxB;;;;;GAKG;AACH,MAAM,MAAM,kBAAkB,GAAG,UAAU,GAAG,SAAS,CAAC;AAIxD,wGAAwG;AACxG,eAAO,MAAM,qCAAqC;;;;;;iBAGlC,CAAC;AAEjB,sFAAsF;AACtF,MAAM,WAAW,uBAAuB;IACtC,QAAQ,EAAE,MAAM,EAAE,CAAC;IACnB,cAAc,EAAE,GAAG,CAAC,MAAM,EAAE,kBAAkB,CAAC,CAAC;CACjD;AAED,wFAAwF;AACxF,wBAAgB,oBAAoB,CAClC,QAAQ,EAAE,CAAC,CAAC,KAAK,CAAC,OAAO,qCAAqC,CAAC,GAC9D,uBAAuB,CAKzB;AAED,sDAAsD;AACtD,MAAM,MAAM,+BAA+B,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,qCAAqC,CAAC,CAAC;AAEpG;;;GAGG;AACH,wBAAsB,8BAA8B,CAClD,OAAO,EAAE,MAAM,EACf,IAAI,EAAE,CAAC,OAAO,EAAE,MAAM,KAAK,OAAO,CAAC,+BAA+B,CAAC,GAClE,OAAO,CAAC,uBAAuB,CAAC,CAElC;AAED,kGAAkG;AAClG,wBAAsB,0BAA0B,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAAC,uBAAuB,CAAC,CAIlG"}

package/dist/queries/focus-review/review-finding-facts.js

@@ -2,8 +2,10 @@
 // Pinned by: packages/daemon/src/completion/review-exit/review-finding-blocking-predicate.test.ts,
 //   packages/daemon/src/completion/review-exit/review-finding-class-routing.test.ts,
 //   packages/daemon/src/delivery/recorded-concerns.test.ts,
+//   packages/daemon/src/integration/f114-review-concern-never-holds-done-regression.test.ts,
 //   packages/daemon/src/integration/reopening-routing-regression.test.ts,
 //   packages/daemon/src/prompt/recorded-concerns-not-owed-work.test.ts,
+//   packages/daemon/src/queries/focus-review/review-finding-class-parity.test.ts,
 //   packages/daemon/src/spawn/resolve-review-context.test.ts
 // PINNED-BY-END
 /**
@@ -15,12 +17,17 @@
  * `focus_review_filed_issue_ids` returns `issueIds: string[]` and, from the edge
  * that records finding classes on, `findingClasses: Record<issueId,
  * 'blocking' | 'concern'>`. An OLDER edge omits `findingClasses`; that reads as
- * an empty map, so every finding falls back to the priority rule
- * (completion/review-exit/review-defect-detector.ts isBlockingReviewFinding). An issue
- * absent from the map likewise has no recorded fact.
+ * an empty map, and under the one rule (recorded-concern-ids.ts findingClassOf)
+ * every review-filed issue with no recorded 'blocking' is a concern -- the
+ * absence of a naming is never a naming.
  *
- * The response is validated (zod) -- a malformed class value throws, and the
- * caller's best-effort read degrades exactly as a failed id read does.
+ * The response is validated (zod) -- a malformed class value throws.
+ *
+ * A READ THAT FAILS THROWS. No earlier answer stands in for it: the facts
+ * change whenever a review is recorded, and facts kept from before that review
+ * can call a finding it re-judged blocking a concern. Every reader that cannot
+ * read the classes DEFERS its decision instead (delivery/recorded-concerns.ts;
+ * the review exit's findingFactsUnreadable).
  *
  * @module queries/focus-review/review-finding-facts
  */
@@ -39,9 +46,15 @@ export function toReviewFindingFacts(response) {
         findingClasses: new Map(Object.entries(response.findingClasses ?? {})),
     };
 }
-/** Read the focus-wide review-filed issue ids AND their recorded finding classes. */
+/**
+ * Read the focus-wide review-filed issue ids AND their recorded finding classes
+ * through `read`. Throws when the read fails (module header).
+ */
+export async function readFocusReviewFindingFactsVia(focusId, read) {
+    return toReviewFindingFacts(await read(focusId));
+}
+/** Read the focus-wide review-filed issue ids AND their recorded finding classes over the API. */
 export async function getFocusReviewFindingFacts(focusId) {
-    const response = await callApiValidated('focus_review_filed_issue_ids', FocusReviewFindingFactsResponseSchema, { focusId });
-    return toReviewFindingFacts(response);
+    return readFocusReviewFindingFactsVia(focusId, (id) => callApiValidated('focus_review_filed_issue_ids', FocusReviewFindingFactsResponseSchema, { focusId: id }));
 }
 //# sourceMappingURL=review-finding-facts.js.map

package/dist/queries/focus-review/review-finding-facts.js.map

@@ -1 +1 @@
-{"version":3,"file":"review-finding-facts.js","sourceRoot":"","sources":["../../../src/queries/focus-review/review-finding-facts.ts"],"names":[],"mappings":"AAAA,8FAA8F;AAC9F,mGAAmG;AACnG,qFAAqF;AACrF,4DAA4D;AAC5D,0EAA0E;AAC1E,wEAAwE;AACxE,6DAA6D;AAC7D,gBAAgB;AAEhB;;;;;;;;;;;;;;;;;GAiBG;AAEH,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AACxB,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAS3D,MAAM,wBAAwB,GAAG,CAAC,CAAC,IAAI,CAAC,CAAC,UAAU,EAAE,SAAS,CAAC,CAAC,CAAC;AAEjE,wGAAwG;AACxG,MAAM,CAAC,MAAM,qCAAqC,GAAG,CAAC,CAAC,MAAM,CAAC;IAC5D,QAAQ,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,OAAO,EAAE;IACvC,cAAc,EAAE,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM,EAAE,EAAE,wBAAwB,CAAC,CAAC,OAAO,EAAE;CACzE,CAAC,CAAC,WAAW,EAAE,CAAC;AAQjB,wFAAwF;AACxF,MAAM,UAAU,oBAAoB,CAClC,QAA+D;IAE/D,OAAO;QACL,QAAQ,EAAE,QAAQ,CAAC,QAAQ,IAAI,EAAE;QACjC,cAAc,EAAE,IAAI,GAAG,CAAC,MAAM,CAAC,OAAO,CAAC,QAAQ,CAAC,cAAc,IAAI,EAAE,CAAC,CAAC;KACvE,CAAC;AACJ,CAAC;AAED,qFAAqF;AACrF,MAAM,CAAC,KAAK,UAAU,0BAA0B,CAAC,OAAe;IAC9D,MAAM,QAAQ,GAAG,MAAM,gBAAgB,CACrC,8BAA8B,EAC9B,qCAAqC,EACrC,EAAE,OAAO,EAAE,CACZ,CAAC;IACF,OAAO,oBAAoB,CAAC,QAAQ,CAAC,CAAC;AACxC,CAAC"}
+{"version":3,"file":"review-finding-facts.js","sourceRoot":"","sources":["../../../src/queries/focus-review/review-finding-facts.ts"],"names":[],"mappings":"AAAA,8FAA8F;AAC9F,mGAAmG;AACnG,qFAAqF;AACrF,4DAA4D;AAC5D,6FAA6F;AAC7F,0EAA0E;AAC1E,wEAAwE;AACxE,kFAAkF;AAClF,6DAA6D;AAC7D,gBAAgB;AAEhB;;;;;;;;;;;;;;;;;;;;;;GAsBG;AAEH,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AACxB,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAU3D,MAAM,wBAAwB,GAAG,CAAC,CAAC,IAAI,CAAC,CAAC,UAAU,EAAE,SAAS,CAAC,CAAC,CAAC;AAEjE,wGAAwG;AACxG,MAAM,CAAC,MAAM,qCAAqC,GAAG,CAAC,CAAC,MAAM,CAAC;IAC5D,QAAQ,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,OAAO,EAAE;IACvC,cAAc,EAAE,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM,EAAE,EAAE,wBAAwB,CAAC,CAAC,OAAO,EAAE;CACzE,CAAC,CAAC,WAAW,EAAE,CAAC;AAQjB,wFAAwF;AACxF,MAAM,UAAU,oBAAoB,CAClC,QAA+D;IAE/D,OAAO;QACL,QAAQ,EAAE,QAAQ,CAAC,QAAQ,IAAI,EAAE;QACjC,cAAc,EAAE,IAAI,GAAG,CAAC,MAAM,CAAC,OAAO,CAAC,QAAQ,CAAC,cAAc,IAAI,EAAE,CAAC,CAAC;KACvE,CAAC;AACJ,CAAC;AAKD;;;GAGG;AACH,MAAM,CAAC,KAAK,UAAU,8BAA8B,CAClD,OAAe,EACf,IAAmE;IAEnE,OAAO,oBAAoB,CAAC,MAAM,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC;AACnD,CAAC;AAED,kGAAkG;AAClG,MAAM,CAAC,KAAK,UAAU,0BAA0B,CAAC,OAAe;IAC9D,OAAO,8BAA8B,CAAC,OAAO,EAAE,CAAC,EAAE,EAAE,EAAE,CACpD,gBAAgB,CAAC,8BAA8B,EAAE,qCAAqC,EAAE,EAAE,OAAO,EAAE,EAAE,EAAE,CAAC,CACzG,CAAC;AACJ,CAAC"}

package/dist/queries/focuses/ended-arm.d.ts

@@ -16,20 +16,37 @@
  * The ended-arm record that rides a release, stating WHY the daemon ended the
  * arm and what was still outstanding.
  *
- * The DAEMON writes ONE reason: 'review_budget_spent'. It is sent in the SAME
- * call as the release (the edge refuses it otherwise, handlers/focus/arm-ended.ts)
- * so the role-less focus is never readable without its reason, and so the record
- * can never be mistaken for the operator stop (operator_stopped_at, which this
- * path does not write).
+ * EVERY daemon release carries one (releaseFocusArm takes it as a required
+ * argument): no focus is un-armed by the daemon with a null reason. The daemon
+ * writes TWO reasons, 'review_budget_spent' and 'run_finished_unreviewed', each
+ * in the SAME call as the release (the edge refuses it otherwise,
+ * handlers/focus/arm-ended.ts) so the role-less focus is never readable without
+ * its reason, and so the record can never be mistaken for the operator stop
+ * (operator_stopped_at, which these paths do not write).
  *
  * `detail` carries only what the DAEMON counted. The edge adds the acceptance
  * criteria the last verdict-bearing review called not_met -- it owns the shape
  * that record lives in -- so this daemon never parses a review summary.
- *
- * ARM_ENDED_REVIEW_BUDGET_SPENT is a value the DB CHECK constraint on
- * product_focuses.arm_ended_reason allows and the wedge diagnosis reads back.
  */
 export declare const ARM_ENDED_REVIEW_BUDGET_SPENT = "review_budget_spent";
+/**
+ * The UNREVIEWED SETTLE end: every delivery settled while the review window the
+ * focus opened never received a verdict, so the daemon released the stranded
+ * arm and kept the window open (supervision/unreviewed-settle-detector.ts). A
+ * finish -- the covered work is terminal -- but one whose review is still owed,
+ * which a re-arm runs.
+ */
+export declare const ARM_ENDED_RUN_FINISHED_UNREVIEWED = "run_finished_unreviewed";
+/**
+ * The LIFECYCLE end with nothing left over: every delivery the arm covered is
+ * terminal and the clear discounted no recorded work. Written ONLY by SQL -- the
+ * lifecycle arm clear (auto_terminate_focus_team /
+ * clear_focus_team_on_review_window_close, migration 20261020133821) in the same
+ * write that nulls the role, whatever closed the review window (a verdict, a
+ * deadline, the hand-off breaker, the spent-budget path) -- and never by this
+ * daemon.
+ */
+export declare const ARM_ENDED_RUN_FINISHED = "run_finished";
 /**
  * The LIFECYCLE end: the run finished every delivery its arm covered while one
  * or more deliveries recorded as new intent under it still rest at planning.
@@ -45,12 +62,13 @@ export declare const ARM_ENDED_REVIEW_BUDGET_SPENT = "review_budget_spent";
  */
 export declare const ARM_ENDED_RUN_FINISHED_RECORDED_WORK_WAITS = "run_finished_recorded_work_waits";
 /** Every reason product_focuses.arm_ended_reason may hold (the DB CHECK set). */
-export type ArmEndedReason = typeof ARM_ENDED_REVIEW_BUDGET_SPENT | typeof ARM_ENDED_RUN_FINISHED_RECORDED_WORK_WAITS;
+export type ArmEndedReason = typeof ARM_ENDED_REVIEW_BUDGET_SPENT | typeof ARM_ENDED_RUN_FINISHED | typeof ARM_ENDED_RUN_FINISHED_RECORDED_WORK_WAITS | typeof ARM_ENDED_RUN_FINISHED_UNREVIEWED;
 /**
- * True when the recorded reason is the LIFECYCLE end -- the run finished its
- * covered work and the recorded work waits for the next arm. False for a spent
- * budget, for no reason at all, and for any value this daemon does not know
- * (an unknown reason is never read as a finish).
+ * True when the recorded reason says the run FINISHED its covered work: the
+ * lifecycle clear (with or without recorded work waiting for the next arm) or
+ * the unreviewed settle. False for a spent budget, for no reason at all, and
+ * for any value this daemon does not know (an unknown reason is never read as
+ * a finish).
  */
 export declare function isRunFinishedArmEnd(reason: string | null | undefined): boolean;
 /** One delivery recorded as new intent under the arm that ended, as the record names it. */
@@ -76,6 +94,15 @@ export interface RecordedWorkWaitsDetail {
  * unnamed. A missing or non-numeric count falls back to the parsed list length.
  */
 export declare function parseRecordedWorkWaitsDetail(detail: unknown): RecordedWorkWaitsDetail | null;
+/**
+ * How the spent-budget record's findings were arrived at. Absent = measured at
+ * the review exit that spent the budget. 'not_measured' = the release was
+ * re-attempted by the backstop (completion/review-cycle-budget/spent-budget-release.ts)
+ * with no exit measurement in hand, so the empty lists are an ABSENCE, not a
+ * measurement.
+ */
+export type SpentBudgetFindingsBasis = 'not_measured';
+/** The spent-review-budget record (reason 'review_budget_spent'). */
 export interface EndedArmRecord {
     reason: typeof ARM_ENDED_REVIEW_BUDGET_SPENT;
     detail: {
@@ -102,6 +129,22 @@ export interface EndedArmRecord {
             title: string;
             deliveryId: string | null;
         }>;
+        /** See SpentBudgetFindingsBasis; absent when the lists were measured at the exit. */
+        findingsBasis?: SpentBudgetFindingsBasis;
+    };
+}
+/** The unreviewed-settle record (reason 'run_finished_unreviewed'). */
+export interface UnreviewedSettleArmRecord {
+    reason: typeof ARM_ENDED_RUN_FINISHED_UNREVIEWED;
+    detail: {
+        /** The settled deliveries whose review verdict was never rendered. */
+        settledDeliveries: Array<{
+            id: string;
+            name: string;
+            executionStatus: string | null;
+        }>;
     };
 }
+/** Every record a daemon release may carry -- one is REQUIRED (releaseFocusArm). */
+export type DaemonEndedArmRecord = EndedArmRecord | UnreviewedSettleArmRecord;
 //# sourceMappingURL=ended-arm.d.ts.map

package/dist/queries/focuses/ended-arm.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ended-arm.d.ts","sourceRoot":"","sources":["../../../src/queries/focuses/ended-arm.ts"],"names":[],"mappings":"AAMA;;;;;;;;;;;;;GAaG;AAEH;;;;;;;;;;;;;;;;GAgBG;AACH,eAAO,MAAM,6BAA6B,wBAAwB,CAAC;AAEnE;;;;;;;;;;;;GAYG;AACH,eAAO,MAAM,0CAA0C,qCAAqC,CAAC;AAE7F,iFAAiF;AACjF,MAAM,MAAM,cAAc,GACtB,OAAO,6BAA6B,GACpC,OAAO,0CAA0C,CAAC;AAEtD;;;;;GAKG;AACH,wBAAgB,mBAAmB,CAAC,MAAM,EAAE,MAAM,GAAG,IAAI,GAAG,SAAS,GAAG,OAAO,CAE9E;AAED,4FAA4F;AAC5F,MAAM,WAAW,mBAAmB;IAClC,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;CACd;AAED;;;;GAIG;AACH,MAAM,WAAW,uBAAuB;IACtC,kBAAkB,EAAE,mBAAmB,EAAE,CAAC;IAC1C,gGAAgG;IAChG,KAAK,EAAE,MAAM,CAAC;CACf;AAMD;;;;;;GAMG;AACH,wBAAgB,4BAA4B,CAAC,MAAM,EAAE,OAAO,GAAG,uBAAuB,GAAG,IAAI,CAY5F;AAED,MAAM,WAAW,cAAc;IAC7B,MAAM,EAAE,OAAO,6BAA6B,CAAC;IAC7C,MAAM,EAAE;QACN,mEAAmE;QACnE,gBAAgB,EAAE,MAAM,CAAC;QACzB,sDAAsD;QACtD,GAAG,EAAE,MAAM,CAAC;QACZ,yFAAyF;QACzF,oBAAoB,EAAE,KAAK,CAAC;YAAE,EAAE,EAAE,MAAM,CAAC;YAAC,GAAG,EAAE,MAAM,CAAC;YAAC,KAAK,EAAE,MAAM,CAAC;YAAC,UAAU,EAAE,MAAM,GAAG,IAAI,CAAA;SAAE,CAAC,CAAC;QACnG;;;;;WAKG;QACH,YAAY,EAAE,KAAK,CAAC;YAAE,EAAE,EAAE,MAAM,CAAC;YAAC,GAAG,EAAE,MAAM,CAAC;YAAC,KAAK,EAAE,MAAM,CAAC;YAAC,UAAU,EAAE,MAAM,GAAG,IAAI,CAAA;SAAE,CAAC,CAAC;KAC5F,CAAC;CACH"}
+{"version":3,"file":"ended-arm.d.ts","sourceRoot":"","sources":["../../../src/queries/focuses/ended-arm.ts"],"names":[],"mappings":"AAQA;;;;;;;;;;;;;GAaG;AAEH;;;;;;;;;;;;;;;GAeG;AACH,eAAO,MAAM,6BAA6B,wBAAwB,CAAC;AAEnE;;;;;;GAMG;AACH,eAAO,MAAM,iCAAiC,4BAA4B,CAAC;AAE3E;;;;;;;;GAQG;AACH,eAAO,MAAM,sBAAsB,iBAAiB,CAAC;AAErD;;;;;;;;;;;;GAYG;AACH,eAAO,MAAM,0CAA0C,qCAAqC,CAAC;AAE7F,iFAAiF;AACjF,MAAM,MAAM,cAAc,GACtB,OAAO,6BAA6B,GACpC,OAAO,sBAAsB,GAC7B,OAAO,0CAA0C,GACjD,OAAO,iCAAiC,CAAC;AAS7C;;;;;;GAMG;AACH,wBAAgB,mBAAmB,CAAC,MAAM,EAAE,MAAM,GAAG,IAAI,GAAG,SAAS,GAAG,OAAO,CAE9E;AAED,4FAA4F;AAC5F,MAAM,WAAW,mBAAmB;IAClC,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;CACd;AAED;;;;GAIG;AACH,MAAM,WAAW,uBAAuB;IACtC,kBAAkB,EAAE,mBAAmB,EAAE,CAAC;IAC1C,gGAAgG;IAChG,KAAK,EAAE,MAAM,CAAC;CACf;AAMD;;;;;;GAMG;AACH,wBAAgB,4BAA4B,CAAC,MAAM,EAAE,OAAO,GAAG,uBAAuB,GAAG,IAAI,CAY5F;AAED;;;;;;GAMG;AACH,MAAM,MAAM,wBAAwB,GAAG,cAAc,CAAC;AAEtD,qEAAqE;AACrE,MAAM,WAAW,cAAc;IAC7B,MAAM,EAAE,OAAO,6BAA6B,CAAC;IAC7C,MAAM,EAAE;QACN,mEAAmE;QACnE,gBAAgB,EAAE,MAAM,CAAC;QACzB,sDAAsD;QACtD,GAAG,EAAE,MAAM,CAAC;QACZ,yFAAyF;QACzF,oBAAoB,EAAE,KAAK,CAAC;YAAE,EAAE,EAAE,MAAM,CAAC;YAAC,GAAG,EAAE,MAAM,CAAC;YAAC,KAAK,EAAE,MAAM,CAAC;YAAC,UAAU,EAAE,MAAM,GAAG,IAAI,CAAA;SAAE,CAAC,CAAC;QACnG;;;;;WAKG;QACH,YAAY,EAAE,KAAK,CAAC;YAAE,EAAE,EAAE,MAAM,CAAC;YAAC,GAAG,EAAE,MAAM,CAAC;YAAC,KAAK,EAAE,MAAM,CAAC;YAAC,UAAU,EAAE,MAAM,GAAG,IAAI,CAAA;SAAE,CAAC,CAAC;QAC3F,qFAAqF;QACrF,aAAa,CAAC,EAAE,wBAAwB,CAAC;KAC1C,CAAC;CACH;AAED,uEAAuE;AACvE,MAAM,WAAW,yBAAyB;IACxC,MAAM,EAAE,OAAO,iCAAiC,CAAC;IACjD,MAAM,EAAE;QACN,sEAAsE;QACtE,iBAAiB,EAAE,KAAK,CAAC;YAAE,EAAE,EAAE,MAAM,CAAC;YAAC,IAAI,EAAE,MAAM,CAAC;YAAC,eAAe,EAAE,MAAM,GAAG,IAAI,CAAA;SAAE,CAAC,CAAC;KACxF,CAAC;CACH;AAED,oFAAoF;AACpF,MAAM,MAAM,oBAAoB,GAAG,cAAc,GAAG,yBAAyB,CAAC"}

package/dist/queries/focuses/ended-arm.js

@@ -1,7 +1,9 @@
 // PINNED-BY-BEGIN (generated by gen:pinned-by -- do not hand-edit; checked by lint:pinned-by)
 // Pinned by: packages/daemon/src/completion/review-cycle-budget/review-cycle-cap-regression.test.ts,
 //   packages/daemon/src/completion/review-cycle-budget/review-cycle-churn-meter.test.ts,
-//   packages/daemon/src/focus/disarm-reaper.test.ts, packages/daemon/src/queries/focuses/ended-arm.test.ts
+//   packages/daemon/src/completion/review-cycle-budget/spent-budget-release.test.ts,
+//   packages/daemon/src/focus/disarm-reaper.test.ts, packages/daemon/src/queries/focuses/ended-arm.test.ts,
+//   packages/daemon/src/supervision/unreviewed-settle-detector.test.ts
 // PINNED-BY-END
 /**
  * The ENDED-ARM record: the shape the daemon sends with a release to state WHY
@@ -21,20 +23,37 @@
  * The ended-arm record that rides a release, stating WHY the daemon ended the
  * arm and what was still outstanding.
  *
- * The DAEMON writes ONE reason: 'review_budget_spent'. It is sent in the SAME
- * call as the release (the edge refuses it otherwise, handlers/focus/arm-ended.ts)
- * so the role-less focus is never readable without its reason, and so the record
- * can never be mistaken for the operator stop (operator_stopped_at, which this
- * path does not write).
+ * EVERY daemon release carries one (releaseFocusArm takes it as a required
+ * argument): no focus is un-armed by the daemon with a null reason. The daemon
+ * writes TWO reasons, 'review_budget_spent' and 'run_finished_unreviewed', each
+ * in the SAME call as the release (the edge refuses it otherwise,
+ * handlers/focus/arm-ended.ts) so the role-less focus is never readable without
+ * its reason, and so the record can never be mistaken for the operator stop
+ * (operator_stopped_at, which these paths do not write).
  *
  * `detail` carries only what the DAEMON counted. The edge adds the acceptance
  * criteria the last verdict-bearing review called not_met -- it owns the shape
  * that record lives in -- so this daemon never parses a review summary.
- *
- * ARM_ENDED_REVIEW_BUDGET_SPENT is a value the DB CHECK constraint on
- * product_focuses.arm_ended_reason allows and the wedge diagnosis reads back.
  */
 export const ARM_ENDED_REVIEW_BUDGET_SPENT = 'review_budget_spent';
+/**
+ * The UNREVIEWED SETTLE end: every delivery settled while the review window the
+ * focus opened never received a verdict, so the daemon released the stranded
+ * arm and kept the window open (supervision/unreviewed-settle-detector.ts). A
+ * finish -- the covered work is terminal -- but one whose review is still owed,
+ * which a re-arm runs.
+ */
+export const ARM_ENDED_RUN_FINISHED_UNREVIEWED = 'run_finished_unreviewed';
+/**
+ * The LIFECYCLE end with nothing left over: every delivery the arm covered is
+ * terminal and the clear discounted no recorded work. Written ONLY by SQL -- the
+ * lifecycle arm clear (auto_terminate_focus_team /
+ * clear_focus_team_on_review_window_close, migration 20261020133821) in the same
+ * write that nulls the role, whatever closed the review window (a verdict, a
+ * deadline, the hand-off breaker, the spent-budget path) -- and never by this
+ * daemon.
+ */
+export const ARM_ENDED_RUN_FINISHED = 'run_finished';
 /**
  * The LIFECYCLE end: the run finished every delivery its arm covered while one
  * or more deliveries recorded as new intent under it still rest at planning.
@@ -49,14 +68,21 @@ export const ARM_ENDED_REVIEW_BUDGET_SPENT = 'review_budget_spent';
  * constants; never read "any non-null reason" as one meaning.
  */
 export const ARM_ENDED_RUN_FINISHED_RECORDED_WORK_WAITS = 'run_finished_recorded_work_waits';
+/** The reasons that say the run FINISHED its covered work (every covered delivery terminal). */
+const RUN_FINISHED_REASONS = new Set([
+    ARM_ENDED_RUN_FINISHED,
+    ARM_ENDED_RUN_FINISHED_RECORDED_WORK_WAITS,
+    ARM_ENDED_RUN_FINISHED_UNREVIEWED,
+]);
 /**
- * True when the recorded reason is the LIFECYCLE end -- the run finished its
- * covered work and the recorded work waits for the next arm. False for a spent
- * budget, for no reason at all, and for any value this daemon does not know
- * (an unknown reason is never read as a finish).
+ * True when the recorded reason says the run FINISHED its covered work: the
+ * lifecycle clear (with or without recorded work waiting for the next arm) or
+ * the unreviewed settle. False for a spent budget, for no reason at all, and
+ * for any value this daemon does not know (an unknown reason is never read as
+ * a finish).
  */
 export function isRunFinishedArmEnd(reason) {
-    return reason === ARM_ENDED_RUN_FINISHED_RECORDED_WORK_WAITS;
+    return reason != null && RUN_FINISHED_REASONS.has(reason);
 }
 function isRecord(value) {
     return typeof value === 'object' && value !== null && !Array.isArray(value);

package/dist/queries/focuses/ended-arm.js.map

@@ -1 +1 @@
-{"version":3,"file":"ended-arm.js","sourceRoot":"","sources":["../../../src/queries/focuses/ended-arm.ts"],"names":[],"mappings":"AAAA,8FAA8F;AAC9F,qGAAqG;AACrG,yFAAyF;AACzF,2GAA2G;AAC3G,gBAAgB;AAEhB;;;;;;;;;;;;;GAaG;AAEH;;;;;;;;;;;;;;;;GAgBG;AACH,MAAM,CAAC,MAAM,6BAA6B,GAAG,qBAAqB,CAAC;AAEnE;;;;;;;;;;;;GAYG;AACH,MAAM,CAAC,MAAM,0CAA0C,GAAG,kCAAkC,CAAC;AAO7F;;;;;GAKG;AACH,MAAM,UAAU,mBAAmB,CAAC,MAAiC;IACnE,OAAO,MAAM,KAAK,0CAA0C,CAAC;AAC/D,CAAC;AAmBD,SAAS,QAAQ,CAAC,KAAc;IAC9B,OAAO,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,KAAK,IAAI,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;AAC9E,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,4BAA4B,CAAC,MAAe;IAC1D,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,kBAAkB,CAAC;QAAE,OAAO,IAAI,CAAC;IAChF,MAAM,kBAAkB,GAA0B,EAAE,CAAC;IACrD,KAAK,MAAM,KAAK,IAAI,MAAM,CAAC,kBAAkB,EAAE,CAAC;QAC9C,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,OAAO,KAAK,CAAC,EAAE,KAAK,QAAQ,IAAI,KAAK,CAAC,EAAE,KAAK,EAAE;YAAE,SAAS;QAClF,MAAM,IAAI,GAAG,OAAO,KAAK,CAAC,IAAI,KAAK,QAAQ,IAAI,KAAK,CAAC,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,KAAK,CAAC,EAAE,CAAC;QACzF,kBAAkB,CAAC,IAAI,CAAC,EAAE,EAAE,EAAE,KAAK,CAAC,EAAE,EAAE,IAAI,EAAE,CAAC,CAAC;IAClD,CAAC;IACD,MAAM,KAAK,GAAG,OAAO,MAAM,CAAC,KAAK,KAAK,QAAQ,IAAI,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,KAAK,CAAC;QAC7E,CAAC,CAAC,MAAM,CAAC,KAAK;QACd,CAAC,CAAC,kBAAkB,CAAC,MAAM,CAAC;IAC9B,OAAO,EAAE,kBAAkB,EAAE,KAAK,EAAE,CAAC;AACvC,CAAC"}
+{"version":3,"file":"ended-arm.js","sourceRoot":"","sources":["../../../src/queries/focuses/ended-arm.ts"],"names":[],"mappings":"AAAA,8FAA8F;AAC9F,qGAAqG;AACrG,yFAAyF;AACzF,qFAAqF;AACrF,4GAA4G;AAC5G,uEAAuE;AACvE,gBAAgB;AAEhB;;;;;;;;;;;;;GAaG;AAEH;;;;;;;;;;;;;;;GAeG;AACH,MAAM,CAAC,MAAM,6BAA6B,GAAG,qBAAqB,CAAC;AAEnE;;;;;;GAMG;AACH,MAAM,CAAC,MAAM,iCAAiC,GAAG,yBAAyB,CAAC;AAE3E;;;;;;;;GAQG;AACH,MAAM,CAAC,MAAM,sBAAsB,GAAG,cAAc,CAAC;AAErD;;;;;;;;;;;;GAYG;AACH,MAAM,CAAC,MAAM,0CAA0C,GAAG,kCAAkC,CAAC;AAS7F,gGAAgG;AAChG,MAAM,oBAAoB,GAAwB,IAAI,GAAG,CAAC;IACxD,sBAAsB;IACtB,0CAA0C;IAC1C,iCAAiC;CAClC,CAAC,CAAC;AAEH;;;;;;GAMG;AACH,MAAM,UAAU,mBAAmB,CAAC,MAAiC;IACnE,OAAO,MAAM,IAAI,IAAI,IAAI,oBAAoB,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;AAC5D,CAAC;AAmBD,SAAS,QAAQ,CAAC,KAAc;IAC9B,OAAO,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,KAAK,IAAI,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;AAC9E,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,4BAA4B,CAAC,MAAe;IAC1D,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,kBAAkB,CAAC;QAAE,OAAO,IAAI,CAAC;IAChF,MAAM,kBAAkB,GAA0B,EAAE,CAAC;IACrD,KAAK,MAAM,KAAK,IAAI,MAAM,CAAC,kBAAkB,EAAE,CAAC;QAC9C,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,OAAO,KAAK,CAAC,EAAE,KAAK,QAAQ,IAAI,KAAK,CAAC,EAAE,KAAK,EAAE;YAAE,SAAS;QAClF,MAAM,IAAI,GAAG,OAAO,KAAK,CAAC,IAAI,KAAK,QAAQ,IAAI,KAAK,CAAC,IAAI,KAAK,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,KAAK,CAAC,EAAE,CAAC;QACzF,kBAAkB,CAAC,IAAI,CAAC,EAAE,EAAE,EAAE,KAAK,CAAC,EAAE,EAAE,IAAI,EAAE,CAAC,CAAC;IAClD,CAAC;IACD,MAAM,KAAK,GAAG,OAAO,MAAM,CAAC,KAAK,KAAK,QAAQ,IAAI,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,KAAK,CAAC;QAC7E,CAAC,CAAC,MAAM,CAAC,KAAK;QACd,CAAC,CAAC,kBAAkB,CAAC,MAAM,CAAC;IAC9B,OAAO,EAAE,kBAAkB,EAAE,KAAK,EAAE,CAAC;AACvC,CAAC"}