@telora/daemon 0.24.25 → 0.24.26

package/dist/completion/review-cycle-budget/spent-budget-release.js

@@ -0,0 +1,98 @@
+// PINNED-BY-BEGIN (generated by gen:pinned-by -- do not hand-edit; checked by lint:pinned-by)
+// Pinned by: packages/daemon/src/completion/review-cycle-budget/review-cycle-churn-meter.test.ts,
+//   packages/daemon/src/completion/review-cycle-budget/spent-budget-release.test.ts
+// PINNED-BY-END
+/**
+ * The spent-budget release RETRY: a focus whose review_cycle_count stands at
+ * TELORA_REVIEW_CYCLE_CAP while its role is still assigned gets its arm
+ * released, with arm_ended_reason = 'review_budget_spent', on the next cascade
+ * poll -- and on every poll after until the write lands.
+ *
+ * WHY. The budget crossing (review-cycle-cap.ts) writes the count first and
+ * then releases the arm. When the release write fails, the count alone holds
+ * every spawn gate (supervision/review-cycle-cap-hold.ts) -- with the role still
+ * set and no reason recorded, a hold nobody can read. This pass gives the hold a
+ * writer behind it, so the held state is transient by construction. History:
+ * docs/daemon/history-team-lifecycle.md (review-cycle-cap.ts).
+ *
+ * The same condition also arises with no failed write at all -- the cap lowered
+ * below a focus's standing count -- and is the same spent budget, so it is
+ * released the same way.
+ *
+ * WHAT IT SENDS. The record the failed crossing composed (remembered in this
+ * process, together with whether that crossing meant to close the review
+ * window), so the end names the findings the exit counted. With no remembered
+ * record (a daemon restart in between, or a lowered cap) it sends the count and
+ * the cap with `findingsBasis: 'not_measured'` -- the empty finding lists are an
+ * absence, not a reading -- and leaves the review window as it is (nothing
+ * read whether a gate verdict needs it).
+ *
+ * The decision is the stop registry's review_budget_spent row, read through
+ * isReviewCycleCapHeld -- but only on a READ count: an unreadable count holds
+ * every gate (fail closed) and releases nothing, because ending a run needs the
+ * fact, not its absence.
+ *
+ * @module completion/review-cycle-budget/spent-budget-release
+ */
+import { ARM_ENDED_REVIEW_BUDGET_SPENT, } from '../../queries/focuses/ended-arm.js';
+import { isReviewCycleCapHeld } from '../../supervision/review-cycle-cap-hold.js';
+import { createLogger } from '../../log/daemon-log.js';
+const log = createLogger({ module: 'focus-executor' });
+/** Per-process: focus id -> the release its crossing could not land. */
+const pendingReleases = new Map();
+/** Remember a release the crossing could not land, for the next cascade poll to retry. */
+export function rememberPendingSpentBudgetRelease(focusId, pending) {
+    pendingReleases.set(focusId, pending);
+}
+/** Test seam: drop every remembered release. */
+export function __resetPendingSpentBudgetReleases() {
+    pendingReleases.clear();
+}
+/** Test/diagnostic read: the release remembered for a focus, if any. */
+export function pendingSpentBudgetRelease(focusId) {
+    return pendingReleases.get(focusId);
+}
+/** Pure: the record a retry sends when no crossing record was remembered. */
+export function unmeasuredSpentBudgetRecord(reviewCycleCount, cap) {
+    return {
+        reason: ARM_ENDED_REVIEW_BUDGET_SPENT,
+        detail: { reviewCycleCount, cap, openBlockingFindings: [], openConcerns: [], findingsBasis: 'not_measured' },
+    };
+}
+/**
+ * Release a still-armed focus whose review budget is spent. Never throws: a
+ * failed write stays pending and is re-attempted on the next poll.
+ */
+export async function releaseArmUnderSpentBudget(facts, deps) {
+    if (facts.assignedAgentRoleId === null) {
+        // Released (by this path, the crossing, an operator, or the lifecycle clear): nothing owed.
+        pendingReleases.delete(facts.focusId);
+        return 'not_armed';
+    }
+    const cap = deps.resolveReviewCycleCap();
+    if (facts.reviewCycleCount === null || !isReviewCycleCapHeld({ reviewCycleCount: facts.reviewCycleCount, cap })) {
+        // A re-arm reset the count (or it was never spent): a remembered release is stale.
+        if (facts.reviewCycleCount !== null)
+            pendingReleases.delete(facts.focusId);
+        return 'not_spent';
+    }
+    const pending = pendingReleases.get(facts.focusId);
+    const record = pending?.record ?? unmeasuredSpentBudgetRecord(facts.reviewCycleCount, cap);
+    try {
+        await deps.releaseFocusArm(facts.focusId, record, { closeReviewWindow: pending?.closeReviewWindow ?? false });
+    }
+    catch (err) {
+        log.warn(`[spent-budget-release] "${facts.focusName}" is still armed with its review budget spent ` +
+            `(cycles=${facts.reviewCycleCount} >= cap=${cap}) and the release failed again: ${err.message}. ` +
+            `Re-attempting next poll.`);
+        return 'failed';
+    }
+    pendingReleases.delete(facts.focusId);
+    log.warn(`[spent-budget-release] "${facts.focusName}" was still armed with its review budget spent ` +
+        `(cycles=${facts.reviewCycleCount} >= cap=${cap}): the armed run has ENDED -- un-armed with ` +
+        `arm_ended_reason='${ARM_ENDED_REVIEW_BUDGET_SPENT}'` +
+        (pending ? ' (the record the crossing measured).' : " (findings not measured: findingsBasis='not_measured').") +
+        ' Only a new arm grants further cycles.');
+    return 'released';
+}
+//# sourceMappingURL=spent-budget-release.js.map

package/dist/completion/review-cycle-budget/spent-budget-release.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"spent-budget-release.js","sourceRoot":"","sources":["../../../src/completion/review-cycle-budget/spent-budget-release.ts"],"names":[],"mappings":"AAAA,8FAA8F;AAC9F,kGAAkG;AAClG,oFAAoF;AACpF,gBAAgB;AAEhB;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA+BG;AAEH,OAAO,EACL,6BAA6B,GAE9B,MAAM,oCAAoC,CAAC;AAC5C,OAAO,EAAE,oBAAoB,EAAE,MAAM,4CAA4C,CAAC;AAClF,OAAO,EAAE,YAAY,EAAE,MAAM,yBAAyB,CAAC;AAEvD,MAAM,GAAG,GAAG,YAAY,CAAC,EAAE,MAAM,EAAE,gBAAgB,EAAE,CAAC,CAAC;AAevD,wEAAwE;AACxE,MAAM,eAAe,GAAG,IAAI,GAAG,EAAqC,CAAC;AAErE,0FAA0F;AAC1F,MAAM,UAAU,iCAAiC,CAAC,OAAe,EAAE,OAAkC;IACnG,eAAe,CAAC,GAAG,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC;AACxC,CAAC;AAED,gDAAgD;AAChD,MAAM,UAAU,iCAAiC;IAC/C,eAAe,CAAC,KAAK,EAAE,CAAC;AAC1B,CAAC;AAED,wEAAwE;AACxE,MAAM,UAAU,yBAAyB,CAAC,OAAe;IACvD,OAAO,eAAe,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;AACtC,CAAC;AAmBD,6EAA6E;AAC7E,MAAM,UAAU,2BAA2B,CAAC,gBAAwB,EAAE,GAAW;IAC/E,OAAO;QACL,MAAM,EAAE,6BAA6B;QACrC,MAAM,EAAE,EAAE,gBAAgB,EAAE,GAAG,EAAE,oBAAoB,EAAE,EAAE,EAAE,YAAY,EAAE,EAAE,EAAE,aAAa,EAAE,cAAc,EAAE;KAC7G,CAAC;AACJ,CAAC;AAED;;;GAGG;AACH,MAAM,CAAC,KAAK,UAAU,0BAA0B,CAC9C,KAA8B,EAC9B,IAA4B;IAE5B,IAAI,KAAK,CAAC,mBAAmB,KAAK,IAAI,EAAE,CAAC;QACvC,4FAA4F;QAC5F,eAAe,CAAC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;QACtC,OAAO,WAAW,CAAC;IACrB,CAAC;IACD,MAAM,GAAG,GAAG,IAAI,CAAC,qBAAqB,EAAE,CAAC;IACzC,IAAI,KAAK,CAAC,gBAAgB,KAAK,IAAI,IAAI,CAAC,oBAAoB,CAAC,EAAE,gBAAgB,EAAE,KAAK,CAAC,gBAAgB,EAAE,GAAG,EAAE,CAAC,EAAE,CAAC;QAChH,mFAAmF;QACnF,IAAI,KAAK,CAAC,gBAAgB,KAAK,IAAI;YAAE,eAAe,CAAC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;QAC3E,OAAO,WAAW,CAAC;IACrB,CAAC;IACD,MAAM,OAAO,GAAG,eAAe,CAAC,GAAG,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;IACnD,MAAM,MAAM,GAAG,OAAO,EAAE,MAAM,IAAI,2BAA2B,CAAC,KAAK,CAAC,gBAAgB,EAAE,GAAG,CAAC,CAAC;IAC3F,IAAI,CAAC;QACH,MAAM,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC,OAAO,EAAE,MAAM,EAAE,EAAE,iBAAiB,EAAE,OAAO,EAAE,iBAAiB,IAAI,KAAK,EAAE,CAAC,CAAC;IAChH,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,GAAG,CAAC,IAAI,CACN,2BAA2B,KAAK,CAAC,SAAS,gDAAgD;YAC1F,WAAW,KAAK,CAAC,gBAAgB,WAAW,GAAG,mCAAoC,GAAa,CAAC,OAAO,IAAI;YAC5G,0BAA0B,CAC3B,CAAC;QACF,OAAO,QAAQ,CAAC;IAClB,CAAC;IACD,eAAe,CAAC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;IACtC,GAAG,CAAC,IAAI,CACN,2BAA2B,KAAK,CAAC,SAAS,iDAAiD;QAC3F,WAAW,KAAK,CAAC,gBAAgB,WAAW,GAAG,8CAA8C;QAC7F,qBAAqB,6BAA6B,GAAG;QACrD,CAAC,OAAO,CAAC,CAAC,CAAC,sCAAsC,CAAC,CAAC,CAAC,yDAAyD,CAAC;QAC9G,wCAAwC,CACzC,CAAC;IACF,OAAO,UAAU,CAAC;AACpB,CAAC"}

package/dist/completion/review-exit/review-defect-detector.d.ts

@@ -35,8 +35,12 @@ export declare function _resetAllRemediationCyclesForTest(): void;
  *   - It has a non-null created_by_role_id (excludes human/UI creates).
  *   - Its created_at is later than the focus's review_requested_at.
  *   - Its status is open (To Do / In Progress / Blocked).
+ *   - It is not a daemon-filed rework Bug (recorded-concern-ids.ts
+ *     isDaemonReworkIssue), which is owed work whatever filed it.
  */
-export declare function isReviewFiledIssue(issue: Pick<FocusIssueInfo, 'createdByRoleId' | 'createdAt' | 'status'>, reviewRequestedAt: string | null): boolean;
+export declare function isReviewFiledIssue(issue: Pick<FocusIssueInfo, 'createdByRoleId' | 'createdAt' | 'status'> & {
+    title?: string | null;
+}, reviewRequestedAt: string | null): boolean;
 /**
  * Filter a focus's issues to only those that were filed during the most
  * recent review pass and are still open.
@@ -47,57 +51,55 @@ export declare function filterReviewFiledIssues(issues: FocusIssueInfo[], review
  * since the most recent review pass.
  */
 export declare function reviewFiledIssueExists(issues: FocusIssueInfo[], reviewRequestedAt: string | null): boolean;
-/**
- * Whether a priority label is an explicit, low (deferrable) severity. Null,
- * empty, P0, and P1 are all NOT deferrable.
- *
- * This is the FALLBACK of isBlockingReviewFinding only, for a finding with no
- * recorded class. Do not call it to decide whether a review finding blocks --
- * call isBlockingReviewFinding (pinned by review-finding-blocking-predicate.test.ts,
- * which fails on any non-test caller outside this module).
- */
-export declare function isLowPriority(priority: string | null | undefined): boolean;
 /**
  * Recorded finding classes keyed by issue id. An issue ABSENT from the map has
- * no recorded fact (an older edge, or a review that linked no criterion) and is
- * classified by the priority fallback.
+ * no recorded class (an older edge's link-less review, or a failed read); under
+ * the one rule it does not block.
  */
 export type ReviewFindingClasses = ReadonlyMap<string, ReviewFindingClass>;
-/** No recorded finding classes: every finding is classified by its priority alone. */
+/** No recorded finding classes: no review finding blocks. */
 export declare const NO_RECORDED_CLASSES: ReviewFindingClasses;
 /**
- * THE blocking predicate for a review-filed finding -- the ONE place the daemon
- * decides whether a review finding may hold its delivery (route it to
- * verify_failed, target it with a gaps_found verdict, keep the review-cycle
- * count climbing). Every such decision -- the review exit's evidence
- * (review-exit-evidence.ts), the verify routing it tags for the reconciler
- * (delivery-reconciler.ts `deferrable`), the review-cycle cap's "open blocking
- * finding" (review-cycle-cap.ts, fed openBlockingFindings), delivery
- * attribution (review-exit-attribution.ts) and foreign-finding location
- * (review-exit-foreign-findings.ts) -- reads it; none reads priority directly.
+ * THE blocking predicate for a review-filed finding at the review exit -- the
+ * ONE place this path decides whether a review finding may hold its delivery
+ * (route it to verify_failed, target it with a gaps_found verdict, keep the
+ * review-cycle count climbing). Every such decision -- the review exit's
+ * evidence (review-exit-evidence.ts), the verify routing it tags for the
+ * reconciler (delivery-reconciler.ts `deferrable`), the review-cycle cap's
+ * "open blocking finding" (fed openBlockingFindings), delivery attribution
+ * (review-exit-attribution.ts) and foreign-finding location
+ * (review-exit-foreign-findings.ts) -- reads it; none reads priority.
  *
- *   - a RECORDED fact wins, whatever the priority: `blocking` blocks, `concern`
- *     does not. A finding blocks by falsifying an agreed criterion, not by the
- *     severity a reviewer typed.
- *   - NO recorded fact -> today's priority rule: only an explicit P2/P3 is
- *     non-blocking; P0/P1 and unset block (the bar is never lowered by absence).
+ * It is the daemon mirror of the one rule (recorded-concern-ids.ts
+ * isBlockingFinding, pinned to supabase/functions/_shared/review-finding-class.ts):
+ * a finding blocks ONLY when a not_met criterion names it -- its recorded class
+ * is `blocking`. A recorded `concern`, and a finding with no recorded class (an
+ * older edge's link-less review, a review that never stamped, a failed read),
+ * do not block, whatever priority the reviewer typed. Until 2026-10-20 the
+ * no-class case fell back to priority here while the live writers counted it
+ * as owed work (docs/DECISIONS.md 2026-10-20, "A review concern never holds its
+ * delivery out of done").
  *
- * It classifies severity only; whether the issue is review-filed and open is
+ * It classifies the finding only; whether the issue is review-filed and open is
  * the caller's filter (isReviewFiledIssue / isReviewFiledComplete).
  */
-export declare function isBlockingReviewFinding(issue: Pick<FocusIssueInfo, 'id' | 'priority'>, findingClasses: ReviewFindingClasses): boolean;
+export declare function isBlockingReviewFinding(issue: Pick<FocusIssueInfo, 'id'>, findingClasses: ReviewFindingClasses): boolean;
 /**
  * Whether an issue is a DEFERRABLE review note: a review-filed, still-open
- * issue (per isReviewFiledIssue) that is NOT a blocking finding
- * (isBlockingReviewFinding -- a recorded `concern`, or, with no recorded fact,
- * an explicit P2/P3). A deferrable note must NOT route a verify delivery to
+ * issue (per isReviewFiledIssue) that a review RECORDED (it carries a class)
+ * and that is NOT a blocking finding (isBlockingReviewFinding -- no not_met
+ * criterion names it). A deferrable note must NOT route a verify delivery to
  * verify_failed -- the review should converge (approve) and leave the note
  * tracked.
  *
- * Any open work that is NOT review-filed (e.g. pre-existing coding work) is
- * blocking. Deferrability is a property of review findings only.
+ * A filing no review recorded (window-matched, no class) is not a recorded
+ * concern -- nothing records it for the human -- so it is owed work, exactly as
+ * the live writers count it. Any other open work (pre-existing coding work) is
+ * owed too. Deferrability is a property of recorded review findings only.
  */
-export declare function isDeferrableReviewNote(issue: Pick<FocusIssueInfo, 'id' | 'createdByRoleId' | 'createdAt' | 'status' | 'priority'>, reviewRequestedAt: string | null, findingClasses: ReviewFindingClasses): boolean;
+export declare function isDeferrableReviewNote(issue: Pick<FocusIssueInfo, 'id' | 'createdByRoleId' | 'createdAt' | 'status'> & {
+    title?: string | null;
+}, reviewRequestedAt: string | null, findingClasses: ReviewFindingClasses): boolean;
 /**
  * Filter a focus's issues to the open, review-filed notes that are deferrable
  * (not blocking). The caller uses the ids to mark the matching reconciler
@@ -107,33 +109,53 @@ export declare function isDeferrableReviewNote(issue: Pick<FocusIssueInfo, 'id'
 export declare function filterDeferrableReviewNotes(issues: FocusIssueInfo[], reviewRequestedAt: string | null, findingClasses: ReviewFindingClasses): FocusIssueInfo[];
 /**
  * Returns true when there is at least one BLOCKING review-filed issue since the
- * most recent review pass -- a review-filed, still-open issue that is a
- * blocking finding (isBlockingReviewFinding). This is the gate for the
- * review_missing_report notice: a review that filed ONLY deferrable notes
- * converged cleanly and must not raise the "review skipped its outcome"
- * escalation.
+ * most recent review pass -- a review-filed, still-open issue that is not a
+ * deferrable note (a recorded blocking finding, or a filing no review
+ * recorded). This is the gate for the review_missing_report notice: a review
+ * that filed ONLY recorded concerns converged cleanly and must not raise the
+ * "review skipped its outcome" escalation.
  */
 export declare function blockingReviewFiledIssueExists(issues: FocusIssueInfo[], reviewRequestedAt: string | null, findingClasses: ReviewFindingClasses): boolean;
 /**
  * Time-independent review-filed test: the issue is a member of the focus's
- * review-filed id union AND is still open.
+ * review-filed id union AND is still open AND is no daemon rework Bug.
  */
-export declare function isReviewFiledById(issue: Pick<FocusIssueInfo, 'id' | 'status'>, reviewFiledIds: ReadonlySet<string>): boolean;
+export declare function isReviewFiledById(issue: Pick<FocusIssueInfo, 'id' | 'status'> & {
+    title?: string | null;
+}, reviewFiledIds: ReadonlySet<string>): boolean;
 /** Review-filed via the non-lossy id set OR the legacy review-window heuristic. */
-export declare function isReviewFiledComplete(issue: Pick<FocusIssueInfo, 'id' | 'createdByRoleId' | 'createdAt' | 'status'>, reviewFiledIds: ReadonlySet<string>, reviewRequestedAt: string | null): boolean;
+export declare function isReviewFiledComplete(issue: Pick<FocusIssueInfo, 'id' | 'createdByRoleId' | 'createdAt' | 'status'> & {
+    title?: string | null;
+}, reviewFiledIds: ReadonlySet<string>, reviewRequestedAt: string | null): boolean;
 /** Complete-set counterpart of reviewFiledIssueExists. */
 export declare function reviewFiledIssueExistsComplete(issues: FocusIssueInfo[], reviewFiledIds: ReadonlySet<string>, reviewRequestedAt: string | null): boolean;
+/**
+ * THE review-exit classification of one issue against the complete set:
+ *   - a RECORDED finding (in the review-filed id set) blocks only when a not_met
+ *     criterion names it (isBlockingReviewFinding); otherwise it is a concern --
+ *     deferrable;
+ *   - a filing NO review recorded (matched by the review window only) is owed
+ *     work: nothing records it as a concern for the human, so it routes like
+ *     any open work, exactly as the live writers count it;
+ *   - anything else is not review-filed (null).
+ * The membership is the live writers' membership (recorded = in the id set),
+ * so the review exit and the live writers never disagree about one issue.
+ */
+export declare function reviewExitFindingClass(issue: Pick<FocusIssueInfo, 'id' | 'createdByRoleId' | 'createdAt' | 'status'> & {
+    title?: string | null;
+}, reviewFiledIds: ReadonlySet<string>, reviewRequestedAt: string | null, findingClasses: ReviewFindingClasses): 'blocking' | 'concern' | 'unrecorded' | null;
 /** Complete-set counterpart of blockingReviewFiledIssueExists. */
 export declare function blockingReviewFiledIssueExistsComplete(issues: FocusIssueInfo[], reviewFiledIds: ReadonlySet<string>, reviewRequestedAt: string | null, findingClasses: ReviewFindingClasses): boolean;
 /**
  * Complete-set counterpart of blockingReviewFiledIssueExists returning the LIST
- * (not just existence): the OPEN, BLOCKING review-filed issues on the focus. Used
- * by the hand-off breaker to ENUMERATE the outstanding findings in its escalation
- * -- so an operator can tell whether the focus carries outstanding review
- * findings without opening the daemon log, rather than reading the breaker's old
+ * (not just existence): the OPEN review-filed issues on the focus that hold
+ * their delivery (reviewExitFindingClass blocking or unrecorded). Used by the
+ * hand-off breaker to ENUMERATE the outstanding findings in its escalation --
+ * so an operator can tell whether the focus carries outstanding review findings
+ * without opening the daemon log, rather than reading the breaker's old
  * untested "there was no work left to route" assertion.
  */
 export declare function filterBlockingReviewFiledComplete(issues: FocusIssueInfo[], reviewFiledIds: ReadonlySet<string>, reviewRequestedAt: string | null, findingClasses: ReviewFindingClasses): FocusIssueInfo[];
-/** Complete-set counterpart of filterDeferrableReviewNotes. */
+/** Complete-set counterpart of filterDeferrableReviewNotes: the RECORDED concerns. */
 export declare function filterDeferrableReviewNotesComplete(issues: FocusIssueInfo[], reviewFiledIds: ReadonlySet<string>, reviewRequestedAt: string | null, findingClasses: ReviewFindingClasses): FocusIssueInfo[];
 //# sourceMappingURL=review-defect-detector.d.ts.map

package/dist/completion/review-exit/review-defect-detector.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"review-defect-detector.d.ts","sourceRoot":"","sources":["../../../src/completion/review-exit/review-defect-detector.ts"],"names":[],"mappings":"AAQA;;;;;;;;;;;;;;;;;GAiBG;AAEH,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,sBAAsB,CAAC;AAG3D,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,oDAAoD,CAAC;AAI7F;;;GAGG;AACH,eAAO,MAAM,wBAAwB,EAAE,MACU,CAAC;AAYlD,wBAAgB,oBAAoB,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,CAE5D;AAED,wBAAgB,0BAA0B,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,CAIlE;AAED,wBAAgB,sBAAsB,CAAC,OAAO,EAAE,MAAM,GAAG,IAAI,CAE5D;AAED,wCAAwC;AACxC,wBAAgB,iCAAiC,IAAI,IAAI,CAExD;AAID;;;;;;;GAOG;AACH,wBAAgB,kBAAkB,CAChC,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,iBAAiB,GAAG,WAAW,GAAG,QAAQ,CAAC,EACvE,iBAAiB,EAAE,MAAM,GAAG,IAAI,GAC/B,OAAO,CAMT;AAED;;;GAGG;AACH,wBAAgB,uBAAuB,CACrC,MAAM,EAAE,cAAc,EAAE,EACxB,iBAAiB,EAAE,MAAM,GAAG,IAAI,GAC/B,cAAc,EAAE,CAElB;AAED;;;GAGG;AACH,wBAAgB,sBAAsB,CACpC,MAAM,EAAE,cAAc,EAAE,EACxB,iBAAiB,EAAE,MAAM,GAAG,IAAI,GAC/B,OAAO,CAUT;AAeD;;;;;;;;GAQG;AACH,wBAAgB,aAAa,CAAC,QAAQ,EAAE,MAAM,GAAG,IAAI,GAAG,SAAS,GAAG,OAAO,CAG1E;AAED;;;;GAIG;AACH,MAAM,MAAM,oBAAoB,GAAG,WAAW,CAAC,MAAM,EAAE,kBAAkB,CAAC,CAAC;AAE3E,sFAAsF;AACtF,eAAO,MAAM,mBAAmB,EAAE,oBAAgC,CAAC;AAEnE;;;;;;;;;;;;;;;;;;;GAmBG;AACH,wBAAgB,uBAAuB,CACrC,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,IAAI,GAAG,UAAU,CAAC,EAC9C,cAAc,EAAE,oBAAoB,GACnC,OAAO,CAIT;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,sBAAsB,CACpC,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,IAAI,GAAG,iBAAiB,GAAG,WAAW,GAAG,QAAQ,GAAG,UAAU,CAAC,EAC3F,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,OAAO,CAET;AAED;;;;;GAKG;AACH,wBAAgB,2BAA2B,CACzC,MAAM,EAAE,cAAc,EAAE,EACxB,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,cAAc,EAAE,CAElB;AAED;;;;;;;GAOG;AACH,wBAAgB,8BAA8B,CAC5C,MAAM,EAAE,cAAc,EAAE,EACxB,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,OAAO,CAIT;AAmBD;;;GAGG;AACH,wBAAgB,iBAAiB,CAC/B,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,IAAI,GAAG,QAAQ,CAAC,EAC5C,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,GAClC,OAAO,CAET;AAED,mFAAmF;AACnF,wBAAgB,qBAAqB,CACnC,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,IAAI,GAAG,iBAAiB,GAAG,WAAW,GAAG,QAAQ,CAAC,EAC9E,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,EACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,GAC/B,OAAO,CAET;AAED,0DAA0D;AAC1D,wBAAgB,8BAA8B,CAC5C,MAAM,EAAE,cAAc,EAAE,EACxB,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,EACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,GAC/B,OAAO,CAET;AAED,kEAAkE;AAClE,wBAAgB,sCAAsC,CACpD,MAAM,EAAE,cAAc,EAAE,EACxB,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,EACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,OAAO,CAIT;AAED;;;;;;;GAOG;AACH,wBAAgB,iCAAiC,CAC/C,MAAM,EAAE,cAAc,EAAE,EACxB,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,EACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,cAAc,EAAE,CAIlB;AAED,+DAA+D;AAC/D,wBAAgB,mCAAmC,CACjD,MAAM,EAAE,cAAc,EAAE,EACxB,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,EACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,cAAc,EAAE,CAIlB"}
+{"version":3,"file":"review-defect-detector.d.ts","sourceRoot":"","sources":["../../../src/completion/review-exit/review-defect-detector.ts"],"names":[],"mappings":"AAMA;;;;;;;;;;;;;;;;;GAiBG;AAEH,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,sBAAsB,CAAC;AAG3D,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,oDAAoD,CAAC;AAK7F;;;GAGG;AACH,eAAO,MAAM,wBAAwB,EAAE,MACU,CAAC;AAYlD,wBAAgB,oBAAoB,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,CAE5D;AAED,wBAAgB,0BAA0B,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,CAIlE;AAED,wBAAgB,sBAAsB,CAAC,OAAO,EAAE,MAAM,GAAG,IAAI,CAE5D;AAED,wCAAwC;AACxC,wBAAgB,iCAAiC,IAAI,IAAI,CAExD;AAID;;;;;;;;;GASG;AACH,wBAAgB,kBAAkB,CAChC,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,iBAAiB,GAAG,WAAW,GAAG,QAAQ,CAAC,GAAG;IAAE,KAAK,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;CAAE,EACnG,iBAAiB,EAAE,MAAM,GAAG,IAAI,GAC/B,OAAO,CAOT;AAED;;;GAGG;AACH,wBAAgB,uBAAuB,CACrC,MAAM,EAAE,cAAc,EAAE,EACxB,iBAAiB,EAAE,MAAM,GAAG,IAAI,GAC/B,cAAc,EAAE,CAElB;AAED;;;GAGG;AACH,wBAAgB,sBAAsB,CACpC,MAAM,EAAE,cAAc,EAAE,EACxB,iBAAiB,EAAE,MAAM,GAAG,IAAI,GAC/B,OAAO,CAUT;AAID;;;;GAIG;AACH,MAAM,MAAM,oBAAoB,GAAG,WAAW,CAAC,MAAM,EAAE,kBAAkB,CAAC,CAAC;AAE3E,6DAA6D;AAC7D,eAAO,MAAM,mBAAmB,EAAE,oBAAgC,CAAC;AAEnE;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,wBAAgB,uBAAuB,CACrC,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,IAAI,CAAC,EACjC,cAAc,EAAE,oBAAoB,GACnC,OAAO,CAET;AAED;;;;;;;;;;;;GAYG;AACH,wBAAgB,sBAAsB,CACpC,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,IAAI,GAAG,iBAAiB,GAAG,WAAW,GAAG,QAAQ,CAAC,GAAG;IAAE,KAAK,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;CAAE,EAC1G,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,OAAO,CAGT;AAED;;;;;GAKG;AACH,wBAAgB,2BAA2B,CACzC,MAAM,EAAE,cAAc,EAAE,EACxB,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,cAAc,EAAE,CAElB;AAED;;;;;;;GAOG;AACH,wBAAgB,8BAA8B,CAC5C,MAAM,EAAE,cAAc,EAAE,EACxB,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,OAAO,CAIT;AAmBD;;;GAGG;AACH,wBAAgB,iBAAiB,CAC/B,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,IAAI,GAAG,QAAQ,CAAC,GAAG;IAAE,KAAK,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;CAAE,EACxE,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,GAClC,OAAO,CAET;AAED,mFAAmF;AACnF,wBAAgB,qBAAqB,CACnC,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,IAAI,GAAG,iBAAiB,GAAG,WAAW,GAAG,QAAQ,CAAC,GAAG;IAAE,KAAK,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;CAAE,EAC1G,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,EACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,GAC/B,OAAO,CAET;AAED,0DAA0D;AAC1D,wBAAgB,8BAA8B,CAC5C,MAAM,EAAE,cAAc,EAAE,EACxB,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,EACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,GAC/B,OAAO,CAET;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,sBAAsB,CACpC,KAAK,EAAE,IAAI,CAAC,cAAc,EAAE,IAAI,GAAG,iBAAiB,GAAG,WAAW,GAAG,QAAQ,CAAC,GAAG;IAAE,KAAK,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;CAAE,EAC1G,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,EACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,UAAU,GAAG,SAAS,GAAG,YAAY,GAAG,IAAI,CAK9C;AAaD,kEAAkE;AAClE,wBAAgB,sCAAsC,CACpD,MAAM,EAAE,cAAc,EAAE,EACxB,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,EACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,OAAO,CAET;AAED;;;;;;;;GAQG;AACH,wBAAgB,iCAAiC,CAC/C,MAAM,EAAE,cAAc,EAAE,EACxB,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,EACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,cAAc,EAAE,CAElB;AAED,sFAAsF;AACtF,wBAAgB,mCAAmC,CACjD,MAAM,EAAE,cAAc,EAAE,EACxB,cAAc,EAAE,WAAW,CAAC,MAAM,CAAC,EACnC,iBAAiB,EAAE,MAAM,GAAG,IAAI,EAChC,cAAc,EAAE,oBAAoB,GACnC,cAAc,EAAE,CAElB"}

package/dist/completion/review-exit/review-defect-detector.js

@@ -1,12 +1,11 @@
 // PINNED-BY-BEGIN (generated by gen:pinned-by -- do not hand-edit; checked by lint:pinned-by)
 // Pinned by: packages/daemon/src/completion/review-exit/review-defect-loop.test.ts,
 //   packages/daemon/src/completion/review-exit/review-deferrable-classification.test.ts,
-//   packages/daemon/src/completion/review-exit/review-exit-foreign-findings.test.ts,
-//   packages/daemon/src/completion/review-exit/review-exit-foreign-focus-regression.test.ts,
 //   packages/daemon/src/completion/review-exit/review-finding-blocking-predicate.test.ts
 // PINNED-BY-END
 import { OPEN_ISSUE_STATUSES } from '../../types/issue-status.js';
 import { loadEnvConfig } from '@telora/daemon-core';
+import { isBlockingFinding, isDaemonReworkIssue } from '../../queries/focus-review/recorded-concern-ids.js';
 // ── Configuration ────────────────────────────────────────────────────────
 /**
  * Cap on remediation cycles before escalation. Sourced from the typed
@@ -44,10 +43,14 @@ export function _resetAllRemediationCyclesForTest() {
  *   - It has a non-null created_by_role_id (excludes human/UI creates).
  *   - Its created_at is later than the focus's review_requested_at.
  *   - Its status is open (To Do / In Progress / Blocked).
+ *   - It is not a daemon-filed rework Bug (recorded-concern-ids.ts
+ *     isDaemonReworkIssue), which is owed work whatever filed it.
  */
 export function isReviewFiledIssue(issue, reviewRequestedAt) {
     if (!issue.createdByRoleId)
         return false;
+    if (isDaemonReworkIssue(issue))
+        return false;
     if (!OPEN_ISSUE_STATUSES.has(issue.status))
         return false;
     if (!reviewRequestedAt)
@@ -81,72 +84,51 @@ export function reviewFiledIssueExists(issues, reviewRequestedAt) {
     }
     return false;
 }
-// ── Deferrability classification ──────────────────────────────────────────
-/**
- * Priority labels that mark a review-filed note as DEFERRABLE when NO finding
- * class is recorded for it (the fallback inside isBlockingReviewFinding -- a
- * recorded blocking/concern fact always wins). The blocking set is everything
- * else -- P0/P1 AND a null/unset priority. The asymmetry is deliberate: the
- * control loop moves reality toward intent and never lowers the bar, so an
- * unprioritized note is treated as BLOCKING (route to verify_failed), not
- * silently converged. Only an EXPLICIT low priority makes a note deferrable.
- */
-const DEFERRABLE_PRIORITIES = new Set(['P2', 'P3']);
-/**
- * Whether a priority label is an explicit, low (deferrable) severity. Null,
- * empty, P0, and P1 are all NOT deferrable.
- *
- * This is the FALLBACK of isBlockingReviewFinding only, for a finding with no
- * recorded class. Do not call it to decide whether a review finding blocks --
- * call isBlockingReviewFinding (pinned by review-finding-blocking-predicate.test.ts,
- * which fails on any non-test caller outside this module).
- */
-export function isLowPriority(priority) {
-    if (!priority)
-        return false;
-    return DEFERRABLE_PRIORITIES.has(priority.trim().toUpperCase());
-}
-/** No recorded finding classes: every finding is classified by its priority alone. */
+/** No recorded finding classes: no review finding blocks. */
 export const NO_RECORDED_CLASSES = new Map();
 /**
- * THE blocking predicate for a review-filed finding -- the ONE place the daemon
- * decides whether a review finding may hold its delivery (route it to
- * verify_failed, target it with a gaps_found verdict, keep the review-cycle
- * count climbing). Every such decision -- the review exit's evidence
- * (review-exit-evidence.ts), the verify routing it tags for the reconciler
- * (delivery-reconciler.ts `deferrable`), the review-cycle cap's "open blocking
- * finding" (review-cycle-cap.ts, fed openBlockingFindings), delivery
- * attribution (review-exit-attribution.ts) and foreign-finding location
- * (review-exit-foreign-findings.ts) -- reads it; none reads priority directly.
+ * THE blocking predicate for a review-filed finding at the review exit -- the
+ * ONE place this path decides whether a review finding may hold its delivery
+ * (route it to verify_failed, target it with a gaps_found verdict, keep the
+ * review-cycle count climbing). Every such decision -- the review exit's
+ * evidence (review-exit-evidence.ts), the verify routing it tags for the
+ * reconciler (delivery-reconciler.ts `deferrable`), the review-cycle cap's
+ * "open blocking finding" (fed openBlockingFindings), delivery attribution
+ * (review-exit-attribution.ts) and foreign-finding location
+ * (review-exit-foreign-findings.ts) -- reads it; none reads priority.
  *
- *   - a RECORDED fact wins, whatever the priority: `blocking` blocks, `concern`
- *     does not. A finding blocks by falsifying an agreed criterion, not by the
- *     severity a reviewer typed.
- *   - NO recorded fact -> today's priority rule: only an explicit P2/P3 is
- *     non-blocking; P0/P1 and unset block (the bar is never lowered by absence).
+ * It is the daemon mirror of the one rule (recorded-concern-ids.ts
+ * isBlockingFinding, pinned to supabase/functions/_shared/review-finding-class.ts):
+ * a finding blocks ONLY when a not_met criterion names it -- its recorded class
+ * is `blocking`. A recorded `concern`, and a finding with no recorded class (an
+ * older edge's link-less review, a review that never stamped, a failed read),
+ * do not block, whatever priority the reviewer typed. Until 2026-10-20 the
+ * no-class case fell back to priority here while the live writers counted it
+ * as owed work (docs/DECISIONS.md 2026-10-20, "A review concern never holds its
+ * delivery out of done").
  *
- * It classifies severity only; whether the issue is review-filed and open is
+ * It classifies the finding only; whether the issue is review-filed and open is
  * the caller's filter (isReviewFiledIssue / isReviewFiledComplete).
  */
 export function isBlockingReviewFinding(issue, findingClasses) {
-    const recorded = findingClasses.get(issue.id);
-    if (recorded !== undefined)
-        return recorded === 'blocking';
-    return !isLowPriority(issue.priority);
+    return isBlockingFinding(issue.id, findingClasses);
 }
 /**
  * Whether an issue is a DEFERRABLE review note: a review-filed, still-open
- * issue (per isReviewFiledIssue) that is NOT a blocking finding
- * (isBlockingReviewFinding -- a recorded `concern`, or, with no recorded fact,
- * an explicit P2/P3). A deferrable note must NOT route a verify delivery to
+ * issue (per isReviewFiledIssue) that a review RECORDED (it carries a class)
+ * and that is NOT a blocking finding (isBlockingReviewFinding -- no not_met
+ * criterion names it). A deferrable note must NOT route a verify delivery to
  * verify_failed -- the review should converge (approve) and leave the note
  * tracked.
  *
- * Any open work that is NOT review-filed (e.g. pre-existing coding work) is
- * blocking. Deferrability is a property of review findings only.
+ * A filing no review recorded (window-matched, no class) is not a recorded
+ * concern -- nothing records it for the human -- so it is owed work, exactly as
+ * the live writers count it. Any other open work (pre-existing coding work) is
+ * owed too. Deferrability is a property of recorded review findings only.
  */
 export function isDeferrableReviewNote(issue, reviewRequestedAt, findingClasses) {
-    return isReviewFiledIssue(issue, reviewRequestedAt) && !isBlockingReviewFinding(issue, findingClasses);
+    return isReviewFiledIssue(issue, reviewRequestedAt) && findingClasses.has(issue.id)
+        && !isBlockingReviewFinding(issue, findingClasses);
 }
 /**
  * Filter a focus's issues to the open, review-filed notes that are deferrable
@@ -159,14 +141,14 @@ export function filterDeferrableReviewNotes(issues, reviewRequestedAt, findingCl
 }
 /**
  * Returns true when there is at least one BLOCKING review-filed issue since the
- * most recent review pass -- a review-filed, still-open issue that is a
- * blocking finding (isBlockingReviewFinding). This is the gate for the
- * review_missing_report notice: a review that filed ONLY deferrable notes
- * converged cleanly and must not raise the "review skipped its outcome"
- * escalation.
+ * most recent review pass -- a review-filed, still-open issue that is not a
+ * deferrable note (a recorded blocking finding, or a filing no review
+ * recorded). This is the gate for the review_missing_report notice: a review
+ * that filed ONLY recorded concerns converged cleanly and must not raise the
+ * "review skipped its outcome" escalation.
  */
 export function blockingReviewFiledIssueExists(issues, reviewRequestedAt, findingClasses) {
-    return issues.some(i => isReviewFiledIssue(i, reviewRequestedAt) && isBlockingReviewFinding(i, findingClasses));
+    return issues.some(i => isReviewFiledIssue(i, reviewRequestedAt) && !isDeferrableReviewNote(i, reviewRequestedAt, findingClasses));
 }
 // ── Non-lossy (complete-set) classification ───────────────────────────────
 //
@@ -186,10 +168,10 @@ export function blockingReviewFiledIssueExists(issues, reviewRequestedAt, findin
 // stable across passes (the fix for the deferrable-note-re-blocked loop).
 /**
  * Time-independent review-filed test: the issue is a member of the focus's
- * review-filed id union AND is still open.
+ * review-filed id union AND is still open AND is no daemon rework Bug.
  */
 export function isReviewFiledById(issue, reviewFiledIds) {
-    return reviewFiledIds.has(issue.id) && OPEN_ISSUE_STATUSES.has(issue.status);
+    return reviewFiledIds.has(issue.id) && OPEN_ISSUE_STATUSES.has(issue.status) && !isDaemonReworkIssue(issue);
 }
 /** Review-filed via the non-lossy id set OR the legacy review-window heuristic. */
 export function isReviewFiledComplete(issue, reviewFiledIds, reviewRequestedAt) {
@@ -199,23 +181,47 @@ export function isReviewFiledComplete(issue, reviewFiledIds, reviewRequestedAt)
 export function reviewFiledIssueExistsComplete(issues, reviewFiledIds, reviewRequestedAt) {
     return issues.some(i => isReviewFiledComplete(i, reviewFiledIds, reviewRequestedAt));
 }
+/**
+ * THE review-exit classification of one issue against the complete set:
+ *   - a RECORDED finding (in the review-filed id set) blocks only when a not_met
+ *     criterion names it (isBlockingReviewFinding); otherwise it is a concern --
+ *     deferrable;
+ *   - a filing NO review recorded (matched by the review window only) is owed
+ *     work: nothing records it as a concern for the human, so it routes like
+ *     any open work, exactly as the live writers count it;
+ *   - anything else is not review-filed (null).
+ * The membership is the live writers' membership (recorded = in the id set),
+ * so the review exit and the live writers never disagree about one issue.
+ */
+export function reviewExitFindingClass(issue, reviewFiledIds, reviewRequestedAt, findingClasses) {
+    if (isReviewFiledById(issue, reviewFiledIds)) {
+        return isBlockingReviewFinding(issue, findingClasses) ? 'blocking' : 'concern';
+    }
+    return isReviewFiledIssue(issue, reviewRequestedAt) ? 'unrecorded' : null;
+}
+/** Whether an issue is open review-filed work that holds its delivery: a named finding, or an unrecorded filing. */
+function holdsAsReviewFiled(issue, reviewFiledIds, reviewRequestedAt, findingClasses) {
+    const cls = reviewExitFindingClass(issue, reviewFiledIds, reviewRequestedAt, findingClasses);
+    return cls === 'blocking' || cls === 'unrecorded';
+}
 /** Complete-set counterpart of blockingReviewFiledIssueExists. */
 export function blockingReviewFiledIssueExistsComplete(issues, reviewFiledIds, reviewRequestedAt, findingClasses) {
-    return issues.some(i => isReviewFiledComplete(i, reviewFiledIds, reviewRequestedAt) && isBlockingReviewFinding(i, findingClasses));
+    return issues.some(i => holdsAsReviewFiled(i, reviewFiledIds, reviewRequestedAt, findingClasses));
 }
 /**
  * Complete-set counterpart of blockingReviewFiledIssueExists returning the LIST
- * (not just existence): the OPEN, BLOCKING review-filed issues on the focus. Used
- * by the hand-off breaker to ENUMERATE the outstanding findings in its escalation
- * -- so an operator can tell whether the focus carries outstanding review
- * findings without opening the daemon log, rather than reading the breaker's old
+ * (not just existence): the OPEN review-filed issues on the focus that hold
+ * their delivery (reviewExitFindingClass blocking or unrecorded). Used by the
+ * hand-off breaker to ENUMERATE the outstanding findings in its escalation --
+ * so an operator can tell whether the focus carries outstanding review findings
+ * without opening the daemon log, rather than reading the breaker's old
  * untested "there was no work left to route" assertion.
  */
 export function filterBlockingReviewFiledComplete(issues, reviewFiledIds, reviewRequestedAt, findingClasses) {
-    return issues.filter(i => isReviewFiledComplete(i, reviewFiledIds, reviewRequestedAt) && isBlockingReviewFinding(i, findingClasses));
+    return issues.filter(i => holdsAsReviewFiled(i, reviewFiledIds, reviewRequestedAt, findingClasses));
 }
-/** Complete-set counterpart of filterDeferrableReviewNotes. */
+/** Complete-set counterpart of filterDeferrableReviewNotes: the RECORDED concerns. */
 export function filterDeferrableReviewNotesComplete(issues, reviewFiledIds, reviewRequestedAt, findingClasses) {
-    return issues.filter(i => isReviewFiledComplete(i, reviewFiledIds, reviewRequestedAt) && !isBlockingReviewFinding(i, findingClasses));
+    return issues.filter(i => reviewExitFindingClass(i, reviewFiledIds, reviewRequestedAt, findingClasses) === 'concern');
 }
 //# sourceMappingURL=review-defect-detector.js.map

package/dist/completion/review-exit/review-defect-detector.js.map

@@ -1 +1 @@
-{"version":3,"file":"review-defect-detector.js","sourceRoot":"","sources":["../../../src/completion/review-exit/review-defect-detector.ts"],"names":[],"mappings":"AAAA,8FAA8F;AAC9F,oFAAoF;AACpF,yFAAyF;AACzF,qFAAqF;AACrF,6FAA6F;AAC7F,yFAAyF;AACzF,gBAAgB;AAsBhB,OAAO,EAAE,mBAAmB,EAAE,MAAM,6BAA6B,CAAC;AAClE,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AAGpD,4EAA4E;AAE5E;;;GAGG;AACH,MAAM,CAAC,MAAM,wBAAwB,GACnC,aAAa,EAAE,CAAC,+BAA+B,CAAC;AAElD,wEAAwE;AAExE;;;;;GAKG;AACH,MAAM,iBAAiB,GAAG,IAAI,GAAG,EAAkB,CAAC;AAEpD,MAAM,UAAU,oBAAoB,CAAC,OAAe;IAClD,OAAO,iBAAiB,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;AAC7C,CAAC;AAED,MAAM,UAAU,0BAA0B,CAAC,OAAe;IACxD,MAAM,IAAI,GAAG,CAAC,iBAAiB,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC;IACvD,iBAAiB,CAAC,GAAG,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC;IACrC,OAAO,IAAI,CAAC;AACd,CAAC;AAED,MAAM,UAAU,sBAAsB,CAAC,OAAe;IACpD,iBAAiB,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;AACpC,CAAC;AAED,wCAAwC;AACxC,MAAM,UAAU,iCAAiC;IAC/C,iBAAiB,CAAC,KAAK,EAAE,CAAC;AAC5B,CAAC;AAED,2EAA2E;AAE3E;;;;;;;GAOG;AACH,MAAM,UAAU,kBAAkB,CAChC,KAAuE,EACvE,iBAAgC;IAEhC,IAAI,CAAC,KAAK,CAAC,eAAe;QAAE,OAAO,KAAK,CAAC;IACzC,IAAI,CAAC,mBAAmB,CAAC,GAAG,CAAC,KAAK,CAAC,MAAM,CAAC;QAAE,OAAO,KAAK,CAAC;IACzD,IAAI,CAAC,iBAAiB;QAAE,OAAO,KAAK,CAAC;IACrC,IAAI,CAAC,KAAK,CAAC,SAAS;QAAE,OAAO,KAAK,CAAC;IACnC,OAAO,IAAI,IAAI,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,OAAO,EAAE,IAAI,IAAI,IAAI,CAAC,iBAAiB,CAAC,CAAC,OAAO,EAAE,CAAC;AACtF,CAAC;AAED;;;GAGG;AACH,MAAM,UAAU,uBAAuB,CACrC,MAAwB,EACxB,iBAAgC;IAEhC,OAAO,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,kBAAkB,CAAC,CAAC,EAAE,iBAAiB,CAAC,CAAC,CAAC;AACtE,CAAC;AAED;;;GAGG;AACH,MAAM,UAAU,sBAAsB,CACpC,MAAwB,EACxB,iBAAgC;IAEhC,IAAI,CAAC,iBAAiB;QAAE,OAAO,KAAK,CAAC;IACrC,KAAK,MAAM,CAAC,IAAI,MAAM,EAAE,CAAC;QACvB,IAAI,CAAC,CAAC,CAAC,eAAe;YAAE,SAAS;QACjC,IAAI,CAAC,CAAC,CAAC,SAAS;YAAE,SAAS;QAC3B,IAAI,IAAI,IAAI,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,OAAO,EAAE,IAAI,IAAI,IAAI,CAAC,iBAAiB,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC;YAC7E,OAAO,IAAI,CAAC;QACd,CAAC;IACH,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,6EAA6E;AAE7E;;;;;;;;GAQG;AACH,MAAM,qBAAqB,GAAG,IAAI,GAAG,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC;AAEpD;;;;;;;;GAQG;AACH,MAAM,UAAU,aAAa,CAAC,QAAmC;IAC/D,IAAI,CAAC,QAAQ;QAAE,OAAO,KAAK,CAAC;IAC5B,OAAO,qBAAqB,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC,CAAC;AAClE,CAAC;AASD,sFAAsF;AACtF,MAAM,CAAC,MAAM,mBAAmB,GAAyB,IAAI,GAAG,EAAE,CAAC;AAEnE;;;;;;;;;;;;;;;;;;;GAmBG;AACH,MAAM,UAAU,uBAAuB,CACrC,KAA8C,EAC9C,cAAoC;IAEpC,MAAM,QAAQ,GAAG,cAAc,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IAC9C,IAAI,QAAQ,KAAK,SAAS;QAAE,OAAO,QAAQ,KAAK,UAAU,CAAC;IAC3D,OAAO,CAAC,aAAa,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;AACxC,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,UAAU,sBAAsB,CACpC,KAA2F,EAC3F,iBAAgC,EAChC,cAAoC;IAEpC,OAAO,kBAAkB,CAAC,KAAK,EAAE,iBAAiB,CAAC,IAAI,CAAC,uBAAuB,CAAC,KAAK,EAAE,cAAc,CAAC,CAAC;AACzG,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,2BAA2B,CACzC,MAAwB,EACxB,iBAAgC,EAChC,cAAoC;IAEpC,OAAO,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,sBAAsB,CAAC,CAAC,EAAE,iBAAiB,EAAE,cAAc,CAAC,CAAC,CAAC;AAC1F,CAAC;AAED;;;;;;;GAOG;AACH,MAAM,UAAU,8BAA8B,CAC5C,MAAwB,EACxB,iBAAgC,EAChC,cAAoC;IAEpC,OAAO,MAAM,CAAC,IAAI,CAChB,CAAC,CAAC,EAAE,CAAC,kBAAkB,CAAC,CAAC,EAAE,iBAAiB,CAAC,IAAI,uBAAuB,CAAC,CAAC,EAAE,cAAc,CAAC,CAC5F,CAAC;AACJ,CAAC;AAED,6EAA6E;AAC7E,EAAE;AACF,4EAA4E;AAC5E,gFAAgF;AAChF,8EAA8E;AAC9E,+EAA+E;AAC/E,8EAA8E;AAC9E,gFAAgF;AAChF,mDAAmD;AACnD,EAAE;AACF,6EAA6E;AAC7E,6EAA6E;AAC7E,6EAA6E;AAC7E,8EAA8E;AAC9E,0EAA0E;AAC1E,0EAA0E;AAE1E;;;GAGG;AACH,MAAM,UAAU,iBAAiB,CAC/B,KAA4C,EAC5C,cAAmC;IAEnC,OAAO,cAAc,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC,IAAI,mBAAmB,CAAC,GAAG,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC;AAC/E,CAAC;AAED,mFAAmF;AACnF,MAAM,UAAU,qBAAqB,CACnC,KAA8E,EAC9E,cAAmC,EACnC,iBAAgC;IAEhC,OAAO,iBAAiB,CAAC,KAAK,EAAE,cAAc,CAAC,IAAI,kBAAkB,CAAC,KAAK,EAAE,iBAAiB,CAAC,CAAC;AAClG,CAAC;AAED,0DAA0D;AAC1D,MAAM,UAAU,8BAA8B,CAC5C,MAAwB,EACxB,cAAmC,EACnC,iBAAgC;IAEhC,OAAO,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC,EAAE,cAAc,EAAE,iBAAiB,CAAC,CAAC,CAAC;AACvF,CAAC;AAED,kEAAkE;AAClE,MAAM,UAAU,sCAAsC,CACpD,MAAwB,EACxB,cAAmC,EACnC,iBAAgC,EAChC,cAAoC;IAEpC,OAAO,MAAM,CAAC,IAAI,CAChB,CAAC,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC,EAAE,cAAc,EAAE,iBAAiB,CAAC,IAAI,uBAAuB,CAAC,CAAC,EAAE,cAAc,CAAC,CAC/G,CAAC;AACJ,CAAC;AAED;;;;;;;GAOG;AACH,MAAM,UAAU,iCAAiC,CAC/C,MAAwB,EACxB,cAAmC,EACnC,iBAAgC,EAChC,cAAoC;IAEpC,OAAO,MAAM,CAAC,MAAM,CAClB,CAAC,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC,EAAE,cAAc,EAAE,iBAAiB,CAAC,IAAI,uBAAuB,CAAC,CAAC,EAAE,cAAc,CAAC,CAC/G,CAAC;AACJ,CAAC;AAED,+DAA+D;AAC/D,MAAM,UAAU,mCAAmC,CACjD,MAAwB,EACxB,cAAmC,EACnC,iBAAgC,EAChC,cAAoC;IAEpC,OAAO,MAAM,CAAC,MAAM,CAClB,CAAC,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC,EAAE,cAAc,EAAE,iBAAiB,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC,EAAE,cAAc,CAAC,CAChH,CAAC;AACJ,CAAC"}
+{"version":3,"file":"review-defect-detector.js","sourceRoot":"","sources":["../../../src/completion/review-exit/review-defect-detector.ts"],"names":[],"mappings":"AAAA,8FAA8F;AAC9F,oFAAoF;AACpF,yFAAyF;AACzF,yFAAyF;AACzF,gBAAgB;AAsBhB,OAAO,EAAE,mBAAmB,EAAE,MAAM,6BAA6B,CAAC;AAClE,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AAEpD,OAAO,EAAE,iBAAiB,EAAE,mBAAmB,EAAE,MAAM,oDAAoD,CAAC;AAE5G,4EAA4E;AAE5E;;;GAGG;AACH,MAAM,CAAC,MAAM,wBAAwB,GACnC,aAAa,EAAE,CAAC,+BAA+B,CAAC;AAElD,wEAAwE;AAExE;;;;;GAKG;AACH,MAAM,iBAAiB,GAAG,IAAI,GAAG,EAAkB,CAAC;AAEpD,MAAM,UAAU,oBAAoB,CAAC,OAAe;IAClD,OAAO,iBAAiB,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;AAC7C,CAAC;AAED,MAAM,UAAU,0BAA0B,CAAC,OAAe;IACxD,MAAM,IAAI,GAAG,CAAC,iBAAiB,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC;IACvD,iBAAiB,CAAC,GAAG,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC;IACrC,OAAO,IAAI,CAAC;AACd,CAAC;AAED,MAAM,UAAU,sBAAsB,CAAC,OAAe;IACpD,iBAAiB,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;AACpC,CAAC;AAED,wCAAwC;AACxC,MAAM,UAAU,iCAAiC;IAC/C,iBAAiB,CAAC,KAAK,EAAE,CAAC;AAC5B,CAAC;AAED,2EAA2E;AAE3E;;;;;;;;;GASG;AACH,MAAM,UAAU,kBAAkB,CAChC,KAAmG,EACnG,iBAAgC;IAEhC,IAAI,CAAC,KAAK,CAAC,eAAe;QAAE,OAAO,KAAK,CAAC;IACzC,IAAI,mBAAmB,CAAC,KAAK,CAAC;QAAE,OAAO,KAAK,CAAC;IAC7C,IAAI,CAAC,mBAAmB,CAAC,GAAG,CAAC,KAAK,CAAC,MAAM,CAAC;QAAE,OAAO,KAAK,CAAC;IACzD,IAAI,CAAC,iBAAiB;QAAE,OAAO,KAAK,CAAC;IACrC,IAAI,CAAC,KAAK,CAAC,SAAS;QAAE,OAAO,KAAK,CAAC;IACnC,OAAO,IAAI,IAAI,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,OAAO,EAAE,IAAI,IAAI,IAAI,CAAC,iBAAiB,CAAC,CAAC,OAAO,EAAE,CAAC;AACtF,CAAC;AAED;;;GAGG;AACH,MAAM,UAAU,uBAAuB,CACrC,MAAwB,EACxB,iBAAgC;IAEhC,OAAO,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,kBAAkB,CAAC,CAAC,EAAE,iBAAiB,CAAC,CAAC,CAAC;AACtE,CAAC;AAED;;;GAGG;AACH,MAAM,UAAU,sBAAsB,CACpC,MAAwB,EACxB,iBAAgC;IAEhC,IAAI,CAAC,iBAAiB;QAAE,OAAO,KAAK,CAAC;IACrC,KAAK,MAAM,CAAC,IAAI,MAAM,EAAE,CAAC;QACvB,IAAI,CAAC,CAAC,CAAC,eAAe;YAAE,SAAS;QACjC,IAAI,CAAC,CAAC,CAAC,SAAS;YAAE,SAAS;QAC3B,IAAI,IAAI,IAAI,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,OAAO,EAAE,IAAI,IAAI,IAAI,CAAC,iBAAiB,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC;YAC7E,OAAO,IAAI,CAAC;QACd,CAAC;IACH,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAWD,6DAA6D;AAC7D,MAAM,CAAC,MAAM,mBAAmB,GAAyB,IAAI,GAAG,EAAE,CAAC;AAEnE;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,MAAM,UAAU,uBAAuB,CACrC,KAAiC,EACjC,cAAoC;IAEpC,OAAO,iBAAiB,CAAC,KAAK,CAAC,EAAE,EAAE,cAAc,CAAC,CAAC;AACrD,CAAC;AAED;;;;;;;;;;;;GAYG;AACH,MAAM,UAAU,sBAAsB,CACpC,KAA0G,EAC1G,iBAAgC,EAChC,cAAoC;IAEpC,OAAO,kBAAkB,CAAC,KAAK,EAAE,iBAAiB,CAAC,IAAI,cAAc,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC;WAC9E,CAAC,uBAAuB,CAAC,KAAK,EAAE,cAAc,CAAC,CAAC;AACvD,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,2BAA2B,CACzC,MAAwB,EACxB,iBAAgC,EAChC,cAAoC;IAEpC,OAAO,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,sBAAsB,CAAC,CAAC,EAAE,iBAAiB,EAAE,cAAc,CAAC,CAAC,CAAC;AAC1F,CAAC;AAED;;;;;;;GAOG;AACH,MAAM,UAAU,8BAA8B,CAC5C,MAAwB,EACxB,iBAAgC,EAChC,cAAoC;IAEpC,OAAO,MAAM,CAAC,IAAI,CAChB,CAAC,CAAC,EAAE,CAAC,kBAAkB,CAAC,CAAC,EAAE,iBAAiB,CAAC,IAAI,CAAC,sBAAsB,CAAC,CAAC,EAAE,iBAAiB,EAAE,cAAc,CAAC,CAC/G,CAAC;AACJ,CAAC;AAED,6EAA6E;AAC7E,EAAE;AACF,4EAA4E;AAC5E,gFAAgF;AAChF,8EAA8E;AAC9E,+EAA+E;AAC/E,8EAA8E;AAC9E,gFAAgF;AAChF,mDAAmD;AACnD,EAAE;AACF,6EAA6E;AAC7E,6EAA6E;AAC7E,6EAA6E;AAC7E,8EAA8E;AAC9E,0EAA0E;AAC1E,0EAA0E;AAE1E;;;GAGG;AACH,MAAM,UAAU,iBAAiB,CAC/B,KAAwE,EACxE,cAAmC;IAEnC,OAAO,cAAc,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC,IAAI,mBAAmB,CAAC,GAAG,CAAC,KAAK,CAAC,MAAM,CAAC,IAAI,CAAC,mBAAmB,CAAC,KAAK,CAAC,CAAC;AAC9G,CAAC;AAED,mFAAmF;AACnF,MAAM,UAAU,qBAAqB,CACnC,KAA0G,EAC1G,cAAmC,EACnC,iBAAgC;IAEhC,OAAO,iBAAiB,CAAC,KAAK,EAAE,cAAc,CAAC,IAAI,kBAAkB,CAAC,KAAK,EAAE,iBAAiB,CAAC,CAAC;AAClG,CAAC;AAED,0DAA0D;AAC1D,MAAM,UAAU,8BAA8B,CAC5C,MAAwB,EACxB,cAAmC,EACnC,iBAAgC;IAEhC,OAAO,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC,EAAE,cAAc,EAAE,iBAAiB,CAAC,CAAC,CAAC;AACvF,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,sBAAsB,CACpC,KAA0G,EAC1G,cAAmC,EACnC,iBAAgC,EAChC,cAAoC;IAEpC,IAAI,iBAAiB,CAAC,KAAK,EAAE,cAAc,CAAC,EAAE,CAAC;QAC7C,OAAO,uBAAuB,CAAC,KAAK,EAAE,cAAc,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,CAAC;IACjF,CAAC;IACD,OAAO,kBAAkB,CAAC,KAAK,EAAE,iBAAiB,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI,CAAC;AAC5E,CAAC;AAED,oHAAoH;AACpH,SAAS,kBAAkB,CACzB,KAAqB,EACrB,cAAmC,EACnC,iBAAgC,EAChC,cAAoC;IAEpC,MAAM,GAAG,GAAG,sBAAsB,CAAC,KAAK,EAAE,cAAc,EAAE,iBAAiB,EAAE,cAAc,CAAC,CAAC;IAC7F,OAAO,GAAG,KAAK,UAAU,IAAI,GAAG,KAAK,YAAY,CAAC;AACpD,CAAC;AAED,kEAAkE;AAClE,MAAM,UAAU,sCAAsC,CACpD,MAAwB,EACxB,cAAmC,EACnC,iBAAgC,EAChC,cAAoC;IAEpC,OAAO,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,kBAAkB,CAAC,CAAC,EAAE,cAAc,EAAE,iBAAiB,EAAE,cAAc,CAAC,CAAC,CAAC;AACpG,CAAC;AAED;;;;;;;;GAQG;AACH,MAAM,UAAU,iCAAiC,CAC/C,MAAwB,EACxB,cAAmC,EACnC,iBAAgC,EAChC,cAAoC;IAEpC,OAAO,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,kBAAkB,CAAC,CAAC,EAAE,cAAc,EAAE,iBAAiB,EAAE,cAAc,CAAC,CAAC,CAAC;AACtG,CAAC;AAED,sFAAsF;AACtF,MAAM,UAAU,mCAAmC,CACjD,MAAwB,EACxB,cAAmC,EACnC,iBAAgC,EAChC,cAAoC;IAEpC,OAAO,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,sBAAsB,CAAC,CAAC,EAAE,cAAc,EAAE,iBAAiB,EAAE,cAAc,CAAC,KAAK,SAAS,CAAC,CAAC;AACxH,CAAC"}

package/dist/completion/review-exit/review-exit-attribution.d.ts

@@ -23,7 +23,7 @@ export type GapsAttribution = 'targeted' | 'not_targeted' | 'unresolvable';
  * each issue's delivery). A closed or non-blocking note does not target its
  * delivery -- only an actionable open gap does. Blocking is
  * isBlockingReviewFinding over the findings' recorded classes (a recorded
- * concern never targets, a recorded blocking always does; no fact -> priority).
+ * concern never targets, a recorded blocking always does; no class -> concern).
  */
 export declare function resolveAttributedDeliveryIds(focusIssues: FocusIssueInfo[], createdIssueIds: ReadonlySet<string>, findingClasses: ReviewFindingClasses): Set<string>;
 /**

package/dist/completion/review-exit/review-exit-attribution.js

@@ -9,7 +9,7 @@ import { isBlockingReviewFinding } from './review-defect-detector.js';
  * each issue's delivery). A closed or non-blocking note does not target its
  * delivery -- only an actionable open gap does. Blocking is
  * isBlockingReviewFinding over the findings' recorded classes (a recorded
- * concern never targets, a recorded blocking always does; no fact -> priority).
+ * concern never targets, a recorded blocking always does; no class -> concern).
  */
 export function resolveAttributedDeliveryIds(focusIssues, createdIssueIds, findingClasses) {
     const attributed = new Set();

package/dist/completion/review-exit/review-exit-deps.d.ts

@@ -17,7 +17,8 @@ import type { ReviewWindowCommit } from '../../git/review-window-commits.js';
 import type { getActiveFocuses } from '../../queries/focuses/focus-discovery.js';
 import type { hasPendingSpawnDirective } from '../../directive/directive-queue.js';
 import type { emitLoopTrigger } from '../../loops/index.js';
-import type { getFocusDeliveries, getFocusIssues, clearReviewRequestedAt, releaseFocusArm, setReviewCycleCount, setReviewHandoffCount, getFocusReviewReportForSession } from '../../queries/focuses/focuses.js';
+import type { getFocusDeliveries, getFocusIssues, clearReviewRequestedAt, setReviewCycleCount, setReviewHandoffCount, getFocusReviewReportForSession } from '../../queries/focuses/focuses.js';
+import type { SpentBudgetRelease } from '../review-cycle-budget/spent-budget-release.js';
 import type { getFocusReviewFindingFacts } from '../../queries/focus-review/review-finding-facts.js';
 import type { resolveReviewCycleCap, resolveReviewHandoffCap } from '../../supervision/stall-detector-config.js';
 import type { getDeliveryIssues, rehomeIssueToDelivery } from '../../queries/deliveries/issues.js';
@@ -31,6 +32,7 @@ import type { CommitGateSeams } from '../../verify/gate-config/commit-gate-confi
 import type { ReviewAutoApproval } from '../../merge/review-auto-approval-record.js';
 import type { ReviewCensus } from './review-census-record.js';
 import type { ReopeningFalsifierResult } from './review-exit-falsifiers.js';
+import type { ReviewLoopDetectionDeps } from '../review-cycle-budget/review-loop-detection.js';
 /**
  * Dependencies for runReviewExitHandler. Every member is required: production
  * wires them at the composition root, and a test names every collaborator it
@@ -65,8 +67,9 @@ export interface ReviewExitDeps {
     setReviewedThroughSha: (focusId: string, sha: string) => Promise<void>;
     setReviewCycleCount: typeof setReviewCycleCount;
     resolveReviewCycleCap: typeof resolveReviewCycleCap;
-    releaseFocusArm: typeof releaseFocusArm;
+    releaseFocusArm: SpentBudgetRelease;
     isShuttingDown: () => boolean;
+    reviewLoop: ReviewLoopDetectionDeps;
     setReviewHandoffCount: typeof setReviewHandoffCount;
     resolveReviewHandoffCap: typeof resolveReviewHandoffCap;
     resolveHandoffExhaustedHold: (focusId: string, notes: string) => Promise<number>;