@telora/daemon 0.22.104 → 0.22.132

package/dist/completion/review-exit-verdict-gate.d.ts

@@ -0,0 +1,202 @@
+/**
+ * Commit-verdict gate of the review exit: the verdict of the gate run judging a
+ * verify delivery's commit is read by the route the review exit takes for it.
+ *
+ * The observed failure (daemon log 2026-09-14 UTC): review exit routed deliveries
+ * on review evidence alone, so the gate run judging the same commit finished
+ * after its delivery had already left verify -- done 19:07:26 vs verdict
+ * 19:10:07, done 19:40:24 vs verdict 19:44:55, verify_failed 20:10:50 vs verdict
+ * 20:13:31 -- and its verdict routed nothing.
+ *
+ * Shape: the same "left in verify" fail-closed gate as the operator / external /
+ * shortfall holds, evaluated downstream of the reconciler's target. It only ever
+ * WITHHOLDS a route the review evidence already decided -- a verdict alone never
+ * moves anything -- and it withholds the two routes differently.
+ *
+ * DONE, only where the exit would actually write done (a passing report, or a
+ * coverage-complete clean review, with no shortfall), needs a PASSING verdict:
+ *   - no gate configured (verify/commit-gate-configured.ts) -> not held; routing
+ *     is exactly what it was before this gate;
+ *   - a passing verdict recorded for the judged commit (the focus worktree HEAD)
+ *     -> not held;
+ *   - a FAILED verdict recorded for it -> held, and NOTHING is written: the
+ *     verification feedback that recorded the failure routes the delivery to
+ *     verify_failed, and a hold write re-asserting `verify` could land after that
+ *     route and undo it (no double route, no clobber);
+ *   - no verdict yet (or the judged commit unreadable) -> held, and the marker
+ *     (delivery/commit-verdict-hold.ts) records the commit awaited and the review
+ *     exit it held, which the release pass (completion/commit-verdict-release.ts)
+ *     replays once the verdict lands.
+ *
+ * VERIFY_FAILED, for a verify delivery whose work review evidence sent back, waits
+ * only for a verdict that is actually coming: re-work toward intent must never
+ * strand behind a verdict nothing will render. It is held ONLY while a gate run
+ * that may judge the commit is selected or in flight (verify/gate-run-registry.ts)
+ * AND no verdict is recorded for the commit yet; the marker then records route
+ * verify_failed, and the release pass replays the exit once that run renders its
+ * verdict or ends without one. A recorded verdict, no run pending, or no gate
+ * configured routes verify_failed exactly as before. The in-flight read comes
+ * first, so with no run pending the gate is not even consulted. The live
+ * open-work pass (focus/verify-open-issues.ts) applies the same wait
+ * (awaitsInFlightGateRun), so it cannot route around a hold one poll later.
+ *
+ * A verdict is read from the delivery's OWN gate sources only. The per-commit
+ * record is read under the gate that governs the delivery (resolveCommitGate: its
+ * explicit command + timeout, or the default-on gate), so a sibling's verdict
+ * under another gate never governs it, and a delivery whose gate cannot be
+ * resolved matches no record. An explicit-method run's outcome is read
+ * (readDeliveryGateOutcome) only under the gate the resolution names for it
+ * (explicitGateKey), from this process, else from the delivery's gate_state
+ * (verify/explicit-gate-outcome.ts), which carries failures, no-SHA outcomes and
+ * the commit judged, so a daemon restart still reads it -- and which is removed
+ * before a replacement run starts, so a restart while that run is selected or in
+ * flight reads no verdict, never the older one. The pass the delivery row
+ * records carries no commit and approves nothing on its own: where no record of
+ * the run exists, the explicit re-arm scan (verify/explicit-rearm.ts) runs the gate
+ * for the judged commit instead. A delivery can carry a per-commit record beside its explicit outcome (a default-on
+ * run over its commit where the edge sends no method column, once its terminal
+ * explicit row left the pending list). Every source is read, and a FAILED verdict
+ * from any wins -- a pass needs no failure from another: each is a gate the work
+ * was judged by, and converging past a rendered failure is what this gate exists
+ * to prevent. An explicit outcome stands in for the per-commit record its run
+ * never writes, so an explicit delivery never waits on one.
+ *
+ * The route the gate lets through CARRIES what it judged. A verify_failed route
+ * for review-filed work stamps the commit the gate resolved for it -- the value
+ * holdForCommitVerdict returns, never a second HEAD read -- as the delivery's
+ * judged commit, with the verdict read for that commit from the same own-gate
+ * sources persisted beside it (reviewReworkGateState). The coding team resumed on
+ * that work is then shown that commit's outcome, failing stage and exact sha
+ * (spawn/prompt-assembly.ts) -- not whatever HEAD it resumes at, nor a sibling
+ * gate's verdict on the same commit. Before this, the route only carried history
+ * forward, so a resume after a passing gate plus a gaps_found review carried no
+ * gate verdict at all. The live open-work pass, the OTHER verify -> verify_failed
+ * writer for review-filed work, stamps the same judgment (openWorkReworkGateState)
+ * for the commit its in-flight wait read, over the gate_state as it stands: that
+ * route never cleared a verdict or hold, so it still clears none.
+ *
+ * The seams are optional on ReviewExitDeps like every other hold's: production
+ * wires them (review-exit-deps.ts); a partial test deps object omitting
+ * both resolveCommitGate and isCommitGateConfigured does not exercise the done
+ * gate, and one omitting hasPendingGateRun never waits on the verify_failed route.
+ *
+ * @module completion/review-exit-verdict-gate
+ */
+import type { updateDeliveryStatus } from '../queries/deliveries.js';
+import { type DeliveryGateState, type GateVerdictSummary, type HeldReviewExit } from '../queries/delivery-gate-state.js';
+import type { CommitGateSeams, CommitGateSubject } from '../verify/commit-gate-configured.js';
+/** The seams the gate reads (a structural slice of ReviewExitDeps). */
+export interface CommitVerdictGateDeps extends Partial<CommitGateSeams> {
+    updateDeliveryStatus: typeof updateDeliveryStatus;
+}
+/** The verdict reads, without the status writer. */
+export type GateReads = Pick<CommitVerdictGateDeps, 'isCommitGateConfigured' | 'resolveCommitGate' | 'readCommitVerdict' | 'readDeliveryGateOutcome'>;
+/** The review-exit params the gate reads and records (a structural slice of ReviewExitParams). */
+export interface CommitVerdictGateParams {
+    focusId: string;
+    productId: string;
+    sessionId: string;
+    sessionType: 'coding' | 'review';
+    succeeded: boolean;
+    reviewSpawnTip?: string | null;
+    currentBranchTip?: string | null;
+    reviewInspected?: boolean;
+    reviewPriorWatermark?: string | null;
+}
+/** The review-exit routes the gate withholds. */
+export type VerdictGatedRoute = 'done' | 'verify_failed';
+/** What the gate knows about a commit: no gate configured, or the verdict recorded for it (pending = none yet). */
+export type GateVerdictState = 'unconfigured' | 'passed' | 'failed' | 'pending';
+/**
+ * Read the gate's state for one delivery at one judged commit from its own-gate
+ * sources (readOwnGateVerdict): unconfigured when no gate is configured (or no
+ * gate seam is wired), else the verdict, else pending. A resolution that throws
+ * holds (fail closed), and a null sha matches no per-commit record (a verdict
+ * cannot be matched to a commit nobody could name).
+ */
+export declare function readGateVerdictState(deps: GateReads, subject: CommitGateSubject, sha: string | null): Promise<GateVerdictState>;
+/**
+ * Whether a verify_failed route must wait for a gate run: one that may judge
+ * `sha` is selected or in flight on the subject's focus, and the gate configured
+ * for the delivery has no verdict for that commit yet. The in-flight read comes
+ * first and is in memory; with no run pending the gate is never consulted.
+ */
+export declare function awaitsInFlightGateRun(deps: GateReads & Pick<CommitVerdictGateDeps, 'hasPendingGateRun'>, subject: CommitGateSubject, sha: string | null): Promise<boolean>;
+/** The routing inputs of a review exit a later replay needs, JSON-safe (absent stays absent). */
+export declare function heldReviewExitFrom(params: CommitVerdictGateParams): HeldReviewExit;
+/** The commit a focus's deliveries are judged on, or null when it cannot be read. Never throws. */
+export declare function readJudgedCommit(deps: Pick<CommitVerdictGateDeps, 'resolveJudgedCommit'>, focusId: string): string | null;
+/** The commit a review exit judges: the focus worktree HEAD, else the exit's own branch-tip read. Never throws. */
+export declare function reviewJudgedCommit(deps: Pick<CommitVerdictGateDeps, 'resolveJudgedCommit'>, params: Pick<CommitVerdictGateParams, 'focusId' | 'currentBranchTip'>): string | null;
+/** What the gate decided for one route: whether it held, and the commit it judged (undefined where it resolved none). */
+export interface CommitVerdictGateDecision {
+    held: boolean;
+    judgedSha?: string | null;
+}
+/**
+ * Whether the review exit must leave this delivery in verify instead of taking
+ * `route` (see the module header), and the commit the gate judged it on. Call for
+ * `done` ONLY where the exit would otherwise write done, and for `verify_failed`
+ * only for a delivery currently in verify. Writes the hold marker when it holds
+ * on a verdict still to come; writes nothing when done is held on a failed verdict.
+ */
+export declare function holdForCommitVerdict(deps: CommitVerdictGateDeps, params: CommitVerdictGateParams, focus: {
+    read_only?: boolean | null;
+}, delivery: {
+    id: string;
+    name: string;
+    injectionId?: string | null;
+    gateState?: unknown;
+}, route?: VerdictGatedRoute): Promise<CommitVerdictGateDecision>;
+/**
+ * The verdict for exactly `sha` from the same own-gate sources the gate reads
+ * (readOwnGateVerdict): the per-commit record's summary (with its failing stage)
+ * where the record is the deciding verdict, else the outcome alone. The gate is
+ * resolved without asking configured-ness -- a bare predicate carries no gate, and
+ * a resolution that cannot be read matches no record. Null when no source has one.
+ * Also the resume's read for a judged-commit stamp that persisted no verdict
+ * (spawn/prompt-assembly.ts), so that read is never gate-less either.
+ */
+export declare function ownGateVerdictFor(deps: GateReads, subject: CommitGateSubject, sha: string): Promise<GateVerdictSummary | null>;
+/** The verdict reads a re-work stamp takes, and the judged-commit read for a route the gate did not see. */
+type ReworkReads = GateReads & Pick<CommitVerdictGateDeps, 'resolveJudgedCommit'>;
+/**
+ * The gate_state a review exit's verify_failed route writes (see the module
+ * header). The verdict is cleared, since the delivery is routing, and the
+ * verification history carries forward with its judged commit REPLACED by the
+ * commit this review exit judged, the delivery's own-gate verdict for it persisted
+ * beside it. `judgedSha` is the commit the gate resolved for the route
+ * (CommitVerdictGateDecision); only a route the gate did not see (a re-opened
+ * done delivery) resolves it here. A malformed or unreadable commit stamps
+ * nothing. Null when nothing is left to carry.
+ */
+export declare function reviewReworkGateState(deps: ReworkReads, params: Pick<CommitVerdictGateParams, 'productId' | 'focusId' | 'currentBranchTip'>, focus: {
+    read_only?: boolean | null;
+}, delivery: {
+    id: string;
+    injectionId?: string | null;
+    gateState?: unknown;
+}, judgedSha?: string | null, now?: () => string): Promise<DeliveryGateState | null>;
+/**
+ * The gate_state the live open-work pass's verify_failed route writes
+ * (focus/verify-open-issues.ts): the same judged commit and own-gate verdict
+ * reviewReworkGateState stamps (reworkJudgment), over the delivery's gate_state
+ * AS IT STANDS. That route never cleared a verdict or a hold, so every other key
+ * is left exactly as it was and the verification history carries forward; only
+ * its judged commit is replaced. `judgedSha` is the commit the pass's in-flight
+ * wait read (the focus worktree HEAD; null when unreadable, which stamps nothing
+ * and removes an older judgment). Undefined -- leave gate_state unchanged -- when
+ * there is neither a commit to stamp nor an older judgment to remove; null when
+ * the removal leaves an empty clear.
+ */
+export declare function openWorkReworkGateState(deps: ReworkReads, params: Pick<CommitVerdictGateParams, 'productId' | 'focusId'>, focus: {
+    read_only?: boolean | null;
+}, delivery: {
+    id: string;
+    injectionId?: string | null;
+    gateState?: unknown;
+}, judgedSha: string | null, now?: () => string): Promise<DeliveryGateState | null | undefined>;
+/** The review-exit tail line for an exit that held a delivery on its gate verdict. */
+export declare function logCommitVerdictHeldExit(focusName: string): void;
+export {};
+//# sourceMappingURL=review-exit-verdict-gate.d.ts.map

package/dist/completion/review-exit-verdict-gate.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-exit-verdict-gate.d.ts","sourceRoot":"","sources":["../../src/completion/review-exit-verdict-gate.ts"],"names":[],"mappings":"AAKA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAmFG;AAEH,OAAO,KAAK,EAAE,oBAAoB,EAAE,MAAM,0BAA0B,CAAC;AACrE,OAAO,EAKL,KAAK,iBAAiB,EACtB,KAAK,kBAAkB,EACvB,KAAK,cAAc,EACpB,MAAM,mCAAmC,CAAC;AAC3C,OAAO,KAAK,EAAwB,eAAe,EAAE,iBAAiB,EAAE,MAAM,qCAAqC,CAAC;AASpH,uEAAuE;AACvE,MAAM,WAAW,qBAAsB,SAAQ,OAAO,CAAC,eAAe,CAAC;IACrE,oBAAoB,EAAE,OAAO,oBAAoB,CAAC;CACnD;AAED,oDAAoD;AACpD,MAAM,MAAM,SAAS,GAAE,IAAI,CAAC,qBAAqB,EAAE,wBAAwB,GAAG,mBAAmB,GAAG,mBAAmB,GAAG,yBAAyB,CAAC,CAAC;AAErJ,kGAAkG;AAClG,MAAM,WAAW,uBAAuB;IACtC,OAAO,EAAE,MAAM,CAAC;IAChB,SAAS,EAAE,MAAM,CAAC;IAClB,SAAS,EAAE,MAAM,CAAC;IAClB,WAAW,EAAE,QAAQ,GAAG,QAAQ,CAAC;IACjC,SAAS,EAAE,OAAO,CAAC;IACnB,cAAc,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IAC/B,gBAAgB,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACjC,eAAe,CAAC,EAAE,OAAO,CAAC;IAC1B,oBAAoB,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;CACtC;AAED,iDAAiD;AACjD,MAAM,MAAM,iBAAiB,GAAG,MAAM,GAAG,eAAe,CAAC;AAEzD,mHAAmH;AACnH,MAAM,MAAM,gBAAgB,GAAG,cAAc,GAAG,QAAQ,GAAG,QAAQ,GAAG,SAAS,CAAC;AAqDhF;;;;;;GAMG;AACH,wBAAsB,oBAAoB,CACxC,IAAI,EAAE,SAAS,EACf,OAAO,EAAE,iBAAiB,EAC1B,GAAG,EAAE,MAAM,GAAG,IAAI,GACjB,OAAO,CAAC,gBAAgB,CAAC,CAI3B;AAED;;;;;GAKG;AACH,wBAAsB,qBAAqB,CACzC,IAAI,EAAE,SAAS,GAAG,IAAI,CAAC,qBAAqB,EAAE,mBAAmB,CAAC,EAClE,OAAO,EAAE,iBAAiB,EAC1B,GAAG,EAAE,MAAM,GAAG,IAAI,GACjB,OAAO,CAAC,OAAO,CAAC,CAGlB;AAED,iGAAiG;AACjG,wBAAgB,kBAAkB,CAAC,MAAM,EAAE,uBAAuB,GAAG,cAAc,CAUlF;AAED,mGAAmG;AACnG,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,IAAI,CAAC,qBAAqB,EAAE,qBAAqB,CAAC,EAAE,OAAO,EAAE,MAAM,GAAG,MAAM,GAAG,IAAI,CAMzH;AAED,mHAAmH;AACnH,wBAAgB,kBAAkB,CAChC,IAAI,EAAE,IAAI,CAAC,qBAAqB,EAAE,qBAAqB,CAAC,EACxD,MAAM,EAAE,IAAI,CAAC,uBAAuB,EAAE,SAAS,GAAG,kBAAkB,CAAC,GACpE,MAAM,GAAG,IAAI,CAEf;AAmCD,yHAAyH;AACzH,MAAM,WAAW,yBAAyB;IACxC,IAAI,EAAE,OAAO,CAAC;IACd,SAAS,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;CAC3B;AAED;;;;;;GAMG;AACH,wBAAsB,oBAAoB,CACxC,IAAI,EAAE,qBAAqB,EAC3B,MAAM,EAAE,uBAAuB,EAC/B,KAAK,EAAE;IAAE,SAAS,CAAC,EAAE,OAAO,GAAG,IAAI,CAAA;CAAE,EACrC,QAAQ,EAAE;IAAE,EAAE,EAAE,MAAM,CAAC;IAAC,IAAI,EAAE,MAAM,CAAC;IAAC,WAAW,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IAAC,SAAS,CAAC,EAAE,OAAO,CAAA;CAAE,EACxF,KAAK,GAAE,iBAA0B,GAChC,OAAO,CAAC,yBAAyB,CAAC,CAoBpC;AAED;;;;;;;;GAQG;AACH,wBAAsB,iBAAiB,CACrC,IAAI,EAAE,SAAS,EACf,OAAO,EAAE,iBAAiB,EAC1B,GAAG,EAAE,MAAM,GACV,OAAO,CAAC,kBAAkB,GAAG,IAAI,CAAC,CAcpC;AAED,4GAA4G;AAC5G,KAAK,WAAW,GAAG,SAAS,GAAG,IAAI,CAAC,qBAAqB,EAAE,qBAAqB,CAAC,CAAC;AAmBlF;;;;;;;;;GASG;AACH,wBAAsB,qBAAqB,CACzC,IAAI,EAAE,WAAW,EACjB,MAAM,EAAE,IAAI,CAAC,uBAAuB,EAAE,WAAW,GAAG,SAAS,GAAG,kBAAkB,CAAC,EACnF,KAAK,EAAE;IAAE,SAAS,CAAC,EAAE,OAAO,GAAG,IAAI,CAAA;CAAE,EACrC,QAAQ,EAAE;IAAE,EAAE,EAAE,MAAM,CAAC;IAAC,WAAW,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IAAC,SAAS,CAAC,EAAE,OAAO,CAAA;CAAE,EAC1E,SAAS,CAAC,EAAE,MAAM,GAAG,IAAI,EACzB,GAAG,GAAE,MAAM,MAAuC,GACjD,OAAO,CAAC,iBAAiB,GAAG,IAAI,CAAC,CAKnC;AAED;;;;;;;;;;;GAWG;AACH,wBAAsB,uBAAuB,CAC3C,IAAI,EAAE,WAAW,EACjB,MAAM,EAAE,IAAI,CAAC,uBAAuB,EAAE,WAAW,GAAG,SAAS,CAAC,EAC9D,KAAK,EAAE;IAAE,SAAS,CAAC,EAAE,OAAO,GAAG,IAAI,CAAA;CAAE,EACrC,QAAQ,EAAE;IAAE,EAAE,EAAE,MAAM,CAAC;IAAC,WAAW,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IAAC,SAAS,CAAC,EAAE,OAAO,CAAA;CAAE,EAC1E,SAAS,EAAE,MAAM,GAAG,IAAI,EACxB,GAAG,GAAE,MAAM,MAAuC,GACjD,OAAO,CAAC,iBAAiB,GAAG,IAAI,GAAG,SAAS,CAAC,CAW/C;AAED,sFAAsF;AACtF,wBAAgB,wBAAwB,CAAC,SAAS,EAAE,MAAM,GAAG,IAAI,CAKhE"}

package/dist/completion/review-exit-verdict-gate.js

@@ -0,0 +1,228 @@
+// PINNED-BY-BEGIN (generated by gen:pinned-by -- do not hand-edit; checked by lint:pinned-by)
+// Pinned by: packages/daemon/src/completion/review-exit-verdict-gate.test.ts,
+//   packages/daemon/src/verify/verification-commit-sharing.test.ts
+// PINNED-BY-END
+import { carryVerificationHistory, readVerificationHistory, stampJudgedCommit, } from '../queries/delivery-gate-state.js';
+import { gateVerdictFromCommitVerdict, judgedShaOfRun } from '../verify/gate-verdict-source.js';
+import { describeCommitVerdictHold, writeCommitVerdictHoldGateState } from '../delivery/commit-verdict-hold.js';
+import { createLogger } from '../shell/log.js';
+const log = createLogger({ module: 'focus-executor' });
+/** No gate to read a per-commit record under, and nothing configured. */
+const NO_GATE = { configured: false, gate: null };
+/**
+ * The resolution the gate reads take: a bare isCommitGateConfigured predicate,
+ * when supplied (a partial deps object; production wires resolveCommitGate only),
+ * answers configured-ness alone with no gate and wins over a resolver beside it --
+ * so an override is never silently shadowed by spread production seams. Null when
+ * neither seam is wired. A resolution that throws reads as configured with no gate
+ * (fail closed).
+ */
+async function resolveGateReads(deps, subject) {
+    const { isCommitGateConfigured } = deps;
+    const resolveGate = isCommitGateConfigured
+        ? async (s) => ({ configured: await isCommitGateConfigured(s), gate: null })
+        : deps.resolveCommitGate;
+    if (!resolveGate)
+        return null;
+    try {
+        return await resolveGate(subject);
+    }
+    catch (err) {
+        log.warn(`[focus-executor] commit-gate predicate failed for delivery ${subject.deliveryId} -- holding (fail-closed): ${err.message}`);
+        return { configured: true, gate: null };
+    }
+}
+/**
+ * Read every own-gate source for one delivery at one commit (see the module
+ * header): the per-commit record under `resolution.gate`, and the outcome its
+ * explicit-method run recorded for that commit -- failed when either failed, else
+ * passed when either passed, else null. A null sha matches no per-commit record,
+ * only an explicit outcome that judged no commit.
+ */
+function readOwnGateVerdict(deps, subject, sha, resolution) {
+    const record = sha && deps.readCommitVerdict ? deps.readCommitVerdict(subject.productId, subject.focusId, sha, resolution.gate) : null;
+    const explicit = deps.readDeliveryGateOutcome?.(subject.deliveryId, sha, subject.gateState, resolution.explicitGateKey) ?? null;
+    const outcomes = [record?.outcome ?? null, explicit];
+    const outcome = outcomes.includes('failed') ? 'failed' : outcomes.find((o) => o !== null) ?? null;
+    return outcome ? { outcome, record } : null;
+}
+/**
+ * Read the gate's state for one delivery at one judged commit from its own-gate
+ * sources (readOwnGateVerdict): unconfigured when no gate is configured (or no
+ * gate seam is wired), else the verdict, else pending. A resolution that throws
+ * holds (fail closed), and a null sha matches no per-commit record (a verdict
+ * cannot be matched to a commit nobody could name).
+ */
+export async function readGateVerdictState(deps, subject, sha) {
+    const resolution = await resolveGateReads(deps, subject);
+    if (!resolution?.configured)
+        return 'unconfigured';
+    return readOwnGateVerdict(deps, subject, sha, resolution)?.outcome ?? 'pending';
+}
+/**
+ * Whether a verify_failed route must wait for a gate run: one that may judge
+ * `sha` is selected or in flight on the subject's focus, and the gate configured
+ * for the delivery has no verdict for that commit yet. The in-flight read comes
+ * first and is in memory; with no run pending the gate is never consulted.
+ */
+export async function awaitsInFlightGateRun(deps, subject, sha) {
+    if (!deps.hasPendingGateRun?.(subject.focusId, sha))
+        return false;
+    return (await readGateVerdictState(deps, subject, sha)) === 'pending';
+}
+/** The routing inputs of a review exit a later replay needs, JSON-safe (absent stays absent). */
+export function heldReviewExitFrom(params) {
+    return {
+        sessionId: params.sessionId,
+        sessionType: params.sessionType,
+        succeeded: params.succeeded,
+        reviewSpawnTip: params.reviewSpawnTip ?? null,
+        currentBranchTip: params.currentBranchTip ?? null,
+        ...(params.reviewInspected !== undefined ? { reviewInspected: params.reviewInspected } : {}),
+        ...(params.reviewPriorWatermark !== undefined ? { reviewPriorWatermark: params.reviewPriorWatermark } : {}),
+    };
+}
+/** The commit a focus's deliveries are judged on, or null when it cannot be read. Never throws. */
+export function readJudgedCommit(deps, focusId) {
+    try {
+        return deps.resolveJudgedCommit?.(focusId) ?? null;
+    }
+    catch {
+        return null;
+    }
+}
+/** The commit a review exit judges: the focus worktree HEAD, else the exit's own branch-tip read. Never throws. */
+export function reviewJudgedCommit(deps, params) {
+    return readJudgedCommit(deps, params.focusId) ?? params.currentBranchTip ?? null;
+}
+/** Write the hold marker for a held route and log it. */
+async function recordHold(deps, params, delivery, sha, route) {
+    const hold = { sha, heldAt: new Date().toISOString(), route, review: heldReviewExitFrom(params) };
+    await writeCommitVerdictHoldGateState(deps, delivery.id, hold, delivery.gateState);
+    const when = route === 'verify_failed' ? 'when that run renders its verdict or ends without one' : 'when the verdict lands';
+    log.info(`[focus-executor] Delivery "${delivery.name}" NOT moved to ${route} -- ${describeCommitVerdictHold(hold)}. ` +
+        `Left in verify; the release pass routes it ${when}.`);
+}
+/** The delivery a review exit asks the gate about. */
+function gateSubject(params, focus, delivery) {
+    return {
+        productId: params.productId,
+        focusId: params.focusId,
+        focusReadOnly: focus.read_only === true,
+        deliveryId: delivery.id,
+        injectionId: delivery.injectionId ?? null,
+        gateState: delivery.gateState,
+    };
+}
+/**
+ * Whether the review exit must leave this delivery in verify instead of taking
+ * `route` (see the module header), and the commit the gate judged it on. Call for
+ * `done` ONLY where the exit would otherwise write done, and for `verify_failed`
+ * only for a delivery currently in verify. Writes the hold marker when it holds
+ * on a verdict still to come; writes nothing when done is held on a failed verdict.
+ */
+export async function holdForCommitVerdict(deps, params, focus, delivery, route = 'done') {
+    if (route === 'done' && !deps.isCommitGateConfigured && !deps.resolveCommitGate)
+        return { held: false };
+    const sha = reviewJudgedCommit(deps, params);
+    const subject = gateSubject(params, focus, delivery);
+    if (route === 'verify_failed') {
+        if (!(await awaitsInFlightGateRun(deps, subject, sha)))
+            return { held: false, judgedSha: sha };
+        await recordHold(deps, params, delivery, sha, route);
+        return { held: true, judgedSha: sha };
+    }
+    const state = await readGateVerdictState(deps, subject, sha);
+    if (state === 'unconfigured' || state === 'passed')
+        return { held: false, judgedSha: sha };
+    if (state === 'failed') {
+        log.info(`[focus-executor] Delivery "${delivery.name}" NOT moved to done -- the gate FAILED on ${(sha ?? '').slice(0, 12)}; ` +
+            `verification feedback routes it to verify_failed (no hold written).`);
+        return { held: true, judgedSha: sha };
+    }
+    await recordHold(deps, params, delivery, sha, route);
+    return { held: true, judgedSha: sha };
+}
+/**
+ * The verdict for exactly `sha` from the same own-gate sources the gate reads
+ * (readOwnGateVerdict): the per-commit record's summary (with its failing stage)
+ * where the record is the deciding verdict, else the outcome alone. The gate is
+ * resolved without asking configured-ness -- a bare predicate carries no gate, and
+ * a resolution that cannot be read matches no record. Null when no source has one.
+ * Also the resume's read for a judged-commit stamp that persisted no verdict
+ * (spawn/prompt-assembly.ts), so that read is never gate-less either.
+ */
+export async function ownGateVerdictFor(deps, subject, sha) {
+    let resolution = NO_GATE;
+    if (!deps.isCommitGateConfigured && deps.resolveCommitGate) {
+        try {
+            resolution = await deps.resolveCommitGate(subject);
+        }
+        catch {
+            // Unresolvable: no gate, so no per-commit record; the explicit outcome is still read.
+        }
+    }
+    const verdict = readOwnGateVerdict(deps, subject, sha, resolution);
+    if (!verdict)
+        return null;
+    return verdict.record && verdict.record.outcome === verdict.outcome
+        ? gateVerdictFromCommitVerdict(verdict.record)
+        : { outcome: verdict.outcome, sha };
+}
+/**
+ * What a review-filed re-work route stamps: the commit it judged (`judgedSha`,
+ * else resolved as the review exit resolves it; malformed or unreadable is null)
+ * and the delivery's own-gate verdict for exactly that commit (ownGateVerdictFor).
+ */
+async function reworkJudgment(deps, params, focus, delivery, judgedSha) {
+    const resolved = judgedSha === undefined ? reviewJudgedCommit(deps, params) : judgedSha;
+    const sha = judgedShaOfRun({ verifiedSha: resolved ?? undefined });
+    return { sha, verdict: sha ? await ownGateVerdictFor(deps, gateSubject(params, focus, delivery), sha) : null };
+}
+/**
+ * The gate_state a review exit's verify_failed route writes (see the module
+ * header). The verdict is cleared, since the delivery is routing, and the
+ * verification history carries forward with its judged commit REPLACED by the
+ * commit this review exit judged, the delivery's own-gate verdict for it persisted
+ * beside it. `judgedSha` is the commit the gate resolved for the route
+ * (CommitVerdictGateDecision); only a route the gate did not see (a re-opened
+ * done delivery) resolves it here. A malformed or unreadable commit stamps
+ * nothing. Null when nothing is left to carry.
+ */
+export async function reviewReworkGateState(deps, params, focus, delivery, judgedSha, now = () => new Date().toISOString()) {
+    const { sha, verdict } = await reworkJudgment(deps, params, focus, delivery, judgedSha);
+    const judgedAt = now();
+    const carried = carryVerificationHistory(delivery.gateState) ?? { blocking: [], warnings: [], evaluatedAt: judgedAt };
+    return carryVerificationHistory(stampJudgedCommit(carried, sha, judgedAt, verdict));
+}
+/**
+ * The gate_state the live open-work pass's verify_failed route writes
+ * (focus/verify-open-issues.ts): the same judged commit and own-gate verdict
+ * reviewReworkGateState stamps (reworkJudgment), over the delivery's gate_state
+ * AS IT STANDS. That route never cleared a verdict or a hold, so every other key
+ * is left exactly as it was and the verification history carries forward; only
+ * its judged commit is replaced. `judgedSha` is the commit the pass's in-flight
+ * wait read (the focus worktree HEAD; null when unreadable, which stamps nothing
+ * and removes an older judgment). Undefined -- leave gate_state unchanged -- when
+ * there is neither a commit to stamp nor an older judgment to remove; null when
+ * the removal leaves an empty clear.
+ */
+export async function openWorkReworkGateState(deps, params, focus, delivery, judgedSha, now = () => new Date().toISOString()) {
+    const { sha, verdict } = await reworkJudgment(deps, { ...params, currentBranchTip: null }, focus, delivery, judgedSha);
+    const prior = delivery.gateState !== null && typeof delivery.gateState === 'object' && !Array.isArray(delivery.gateState)
+        ? delivery.gateState
+        : null;
+    if (!sha && !readVerificationHistory(prior).judgedCommit)
+        return undefined;
+    const judgedAt = now();
+    const stamped = stampJudgedCommit(prior ?? { blocking: [], warnings: [], evaluatedAt: judgedAt }, sha, judgedAt, verdict);
+    const emptyClear = Object.keys(stamped).every((k) => k === 'blocking' || k === 'warnings' || k === 'evaluatedAt')
+        && (stamped.blocking?.length ?? 0) === 0 && (stamped.warnings?.length ?? 0) === 0;
+    return emptyClear ? null : stamped;
+}
+/** The review-exit tail line for an exit that held a delivery on its gate verdict. */
+export function logCommitVerdictHeldExit(focusName) {
+    log.info(`[focus-executor] "${focusName}" review exit held: a verify delivery awaits the gate verdict for the commit it ` +
+        `judges. review_requested_at left set; the release pass routes it when the verdict lands (re-work: or when the run ends).`);
+}
+//# sourceMappingURL=review-exit-verdict-gate.js.map

package/dist/completion/review-exit-verdict-gate.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-exit-verdict-gate.js","sourceRoot":"","sources":["../../src/completion/review-exit-verdict-gate.ts"],"names":[],"mappings":"AAAA,8FAA8F;AAC9F,8EAA8E;AAC9E,mEAAmE;AACnE,gBAAgB;AAwFhB,OAAO,EACL,wBAAwB,EACxB,uBAAuB,EACvB,iBAAiB,GAKlB,MAAM,mCAAmC,CAAC;AAI3C,OAAO,EAAE,4BAA4B,EAAE,cAAc,EAAE,MAAM,kCAAkC,CAAC;AAChG,OAAO,EAAE,yBAAyB,EAAE,+BAA+B,EAAE,MAAM,oCAAoC,CAAC;AAChH,OAAO,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAC;AAE/C,MAAM,GAAG,GAAG,YAAY,CAAC,EAAE,MAAM,EAAE,gBAAgB,EAAE,CAAC,CAAC;AA6BvD,yEAAyE;AACzE,MAAM,OAAO,GAAyB,EAAE,UAAU,EAAE,KAAK,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;AAExE;;;;;;;GAOG;AACH,KAAK,UAAU,gBAAgB,CAAC,IAAe,EAAE,OAA0B;IACzE,MAAM,EAAE,sBAAsB,EAAE,GAAG,IAAI,CAAC;IACxC,MAAM,WAAW,GAAG,sBAAsB;QACxC,CAAC,CAAC,KAAK,EAAE,CAAoB,EAAiC,EAAE,CAAC,CAAC,EAAE,UAAU,EAAE,MAAM,sBAAsB,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;QAC9H,CAAC,CAAC,IAAI,CAAC,iBAAiB,CAAC;IAC3B,IAAI,CAAC,WAAW;QAAE,OAAO,IAAI,CAAC;IAC9B,IAAI,CAAC;QACH,OAAO,MAAM,WAAW,CAAC,OAAO,CAAC,CAAC;IACpC,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,GAAG,CAAC,IAAI,CAAC,8DAA8D,OAAO,CAAC,UAAU,8BAA+B,GAAa,CAAC,OAAO,EAAE,CAAC,CAAC;QACjJ,OAAO,EAAE,UAAU,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;IAC1C,CAAC;AACH,CAAC;AAQD;;;;;;GAMG;AACH,SAAS,kBAAkB,CACzB,IAAsE,EACtE,OAA0B,EAC1B,GAAkB,EAClB,UAAgC;IAEhC,MAAM,MAAM,GAAG,GAAG,IAAI,IAAI,CAAC,iBAAiB,CAAC,CAAC,CAAC,IAAI,CAAC,iBAAiB,CAAC,OAAO,CAAC,SAAS,EAAE,OAAO,CAAC,OAAO,EAAE,GAAG,EAAE,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IACvI,MAAM,QAAQ,GAAG,IAAI,CAAC,uBAAuB,EAAE,CAAC,OAAO,CAAC,UAAU,EAAE,GAAG,EAAE,OAAO,CAAC,SAAS,EAAE,UAAU,CAAC,eAAe,CAAC,IAAI,IAAI,CAAC;IAChI,MAAM,QAAQ,GAAsC,CAAC,MAAM,EAAE,OAAO,IAAI,IAAI,EAAE,QAAQ,CAAC,CAAC;IACxF,MAAM,OAAO,GAAG,QAAQ,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,KAAK,IAAI,CAAC,IAAI,IAAI,CAAC;IAClG,OAAO,OAAO,CAAC,CAAC,CAAC,EAAE,OAAO,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC;AAC9C,CAAC;AAED;;;;;;GAMG;AACH,MAAM,CAAC,KAAK,UAAU,oBAAoB,CACxC,IAAe,EACf,OAA0B,EAC1B,GAAkB;IAElB,MAAM,UAAU,GAAG,MAAM,gBAAgB,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;IACzD,IAAI,CAAC,UAAU,EAAE,UAAU;QAAE,OAAO,cAAc,CAAC;IACnD,OAAO,kBAAkB,CAAC,IAAI,EAAE,OAAO,EAAE,GAAG,EAAE,UAAU,CAAC,EAAE,OAAO,IAAI,SAAS,CAAC;AAClF,CAAC;AAED;;;;;GAKG;AACH,MAAM,CAAC,KAAK,UAAU,qBAAqB,CACzC,IAAkE,EAClE,OAA0B,EAC1B,GAAkB;IAElB,IAAI,CAAC,IAAI,CAAC,iBAAiB,EAAE,CAAC,OAAO,CAAC,OAAO,EAAE,GAAG,CAAC;QAAE,OAAO,KAAK,CAAC;IAClE,OAAO,CAAC,MAAM,oBAAoB,CAAC,IAAI,EAAE,OAAO,EAAE,GAAG,CAAC,CAAC,KAAK,SAAS,CAAC;AACxE,CAAC;AAED,iGAAiG;AACjG,MAAM,UAAU,kBAAkB,CAAC,MAA+B;IAChE,OAAO;QACL,SAAS,EAAE,MAAM,CAAC,SAAS;QAC3B,WAAW,EAAE,MAAM,CAAC,WAAW;QAC/B,SAAS,EAAE,MAAM,CAAC,SAAS;QAC3B,cAAc,EAAE,MAAM,CAAC,cAAc,IAAI,IAAI;QAC7C,gBAAgB,EAAE,MAAM,CAAC,gBAAgB,IAAI,IAAI;QACjD,GAAG,CAAC,MAAM,CAAC,eAAe,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,eAAe,EAAE,MAAM,CAAC,eAAe,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QAC5F,GAAG,CAAC,MAAM,CAAC,oBAAoB,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,oBAAoB,EAAE,MAAM,CAAC,oBAAoB,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;KAC5G,CAAC;AACJ,CAAC;AAED,mGAAmG;AACnG,MAAM,UAAU,gBAAgB,CAAC,IAAwD,EAAE,OAAe;IACxG,IAAI,CAAC;QACH,OAAO,IAAI,CAAC,mBAAmB,EAAE,CAAC,OAAO,CAAC,IAAI,IAAI,CAAC;IACrD,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,IAAI,CAAC;IACd,CAAC;AACH,CAAC;AAED,mHAAmH;AACnH,MAAM,UAAU,kBAAkB,CAChC,IAAwD,EACxD,MAAqE;IAErE,OAAO,gBAAgB,CAAC,IAAI,EAAE,MAAM,CAAC,OAAO,CAAC,IAAI,MAAM,CAAC,gBAAgB,IAAI,IAAI,CAAC;AACnF,CAAC;AAED,yDAAyD;AACzD,KAAK,UAAU,UAAU,CACvB,IAA2B,EAC3B,MAA+B,EAC/B,QAA2D,EAC3D,GAAkB,EAClB,KAAwB;IAExB,MAAM,IAAI,GAA2B,EAAE,GAAG,EAAE,MAAM,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE,KAAK,EAAE,MAAM,EAAE,kBAAkB,CAAC,MAAM,CAAC,EAAE,CAAC;IAC1H,MAAM,+BAA+B,CAAC,IAAI,EAAE,QAAQ,CAAC,EAAE,EAAE,IAAI,EAAE,QAAQ,CAAC,SAAS,CAAC,CAAC;IACnF,MAAM,IAAI,GAAG,KAAK,KAAK,eAAe,CAAC,CAAC,CAAC,uDAAuD,CAAC,CAAC,CAAC,wBAAwB,CAAC;IAC5H,GAAG,CAAC,IAAI,CACN,8BAA8B,QAAQ,CAAC,IAAI,kBAAkB,KAAK,OAAO,yBAAyB,CAAC,IAAI,CAAC,IAAI;QAC5G,8CAA8C,IAAI,GAAG,CACtD,CAAC;AACJ,CAAC;AAED,sDAAsD;AACtD,SAAS,WAAW,CAClB,MAA8D,EAC9D,KAAqC,EACrC,QAA0E;IAE1E,OAAO;QACL,SAAS,EAAE,MAAM,CAAC,SAAS;QAC3B,OAAO,EAAE,MAAM,CAAC,OAAO;QACvB,aAAa,EAAE,KAAK,CAAC,SAAS,KAAK,IAAI;QACvC,UAAU,EAAE,QAAQ,CAAC,EAAE;QACvB,WAAW,EAAE,QAAQ,CAAC,WAAW,IAAI,IAAI;QACzC,SAAS,EAAE,QAAQ,CAAC,SAAS;KAC9B,CAAC;AACJ,CAAC;AAQD;;;;;;GAMG;AACH,MAAM,CAAC,KAAK,UAAU,oBAAoB,CACxC,IAA2B,EAC3B,MAA+B,EAC/B,KAAqC,EACrC,QAAwF,EACxF,QAA2B,MAAM;IAEjC,IAAI,KAAK,KAAK,MAAM,IAAI,CAAC,IAAI,CAAC,sBAAsB,IAAI,CAAC,IAAI,CAAC,iBAAiB;QAAE,OAAO,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC;IACxG,MAAM,GAAG,GAAG,kBAAkB,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;IAC7C,MAAM,OAAO,GAAG,WAAW,CAAC,MAAM,EAAE,KAAK,EAAE,QAAQ,CAAC,CAAC;IACrD,IAAI,KAAK,KAAK,eAAe,EAAE,CAAC;QAC9B,IAAI,CAAC,CAAC,MAAM,qBAAqB,CAAC,IAAI,EAAE,OAAO,EAAE,GAAG,CAAC,CAAC;YAAE,OAAO,EAAE,IAAI,EAAE,KAAK,EAAE,SAAS,EAAE,GAAG,EAAE,CAAC;QAC/F,MAAM,UAAU,CAAC,IAAI,EAAE,MAAM,EAAE,QAAQ,EAAE,GAAG,EAAE,KAAK,CAAC,CAAC;QACrD,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,SAAS,EAAE,GAAG,EAAE,CAAC;IACxC,CAAC;IACD,MAAM,KAAK,GAAG,MAAM,oBAAoB,CAAC,IAAI,EAAE,OAAO,EAAE,GAAG,CAAC,CAAC;IAC7D,IAAI,KAAK,KAAK,cAAc,IAAI,KAAK,KAAK,QAAQ;QAAE,OAAO,EAAE,IAAI,EAAE,KAAK,EAAE,SAAS,EAAE,GAAG,EAAE,CAAC;IAC3F,IAAI,KAAK,KAAK,QAAQ,EAAE,CAAC;QACvB,GAAG,CAAC,IAAI,CACN,8BAA8B,QAAQ,CAAC,IAAI,6CAA6C,CAAC,GAAG,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI;YACpH,qEAAqE,CACtE,CAAC;QACF,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,SAAS,EAAE,GAAG,EAAE,CAAC;IACxC,CAAC;IACD,MAAM,UAAU,CAAC,IAAI,EAAE,MAAM,EAAE,QAAQ,EAAE,GAAG,EAAE,KAAK,CAAC,CAAC;IACrD,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,SAAS,EAAE,GAAG,EAAE,CAAC;AACxC,CAAC;AAED;;;;;;;;GAQG;AACH,MAAM,CAAC,KAAK,UAAU,iBAAiB,CACrC,IAAe,EACf,OAA0B,EAC1B,GAAW;IAEX,IAAI,UAAU,GAAG,OAAO,CAAC;IACzB,IAAI,CAAC,IAAI,CAAC,sBAAsB,IAAI,IAAI,CAAC,iBAAiB,EAAE,CAAC;QAC3D,IAAI,CAAC;YACH,UAAU,GAAG,MAAM,IAAI,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;QACrD,CAAC;QAAC,MAAM,CAAC;YACP,sFAAsF;QACxF,CAAC;IACH,CAAC;IACD,MAAM,OAAO,GAAG,kBAAkB,CAAC,IAAI,EAAE,OAAO,EAAE,GAAG,EAAE,UAAU,CAAC,CAAC;IACnE,IAAI,CAAC,OAAO;QAAE,OAAO,IAAI,CAAC;IAC1B,OAAO,OAAO,CAAC,MAAM,IAAI,OAAO,CAAC,MAAM,CAAC,OAAO,KAAK,OAAO,CAAC,OAAO;QACjE,CAAC,CAAC,4BAA4B,CAAC,OAAO,CAAC,MAAM,CAAC;QAC9C,CAAC,CAAC,EAAE,OAAO,EAAE,OAAO,CAAC,OAAO,EAAE,GAAG,EAAE,CAAC;AACxC,CAAC;AAKD;;;;GAIG;AACH,KAAK,UAAU,cAAc,CAC3B,IAAiB,EACjB,MAAmF,EACnF,KAAqC,EACrC,QAA0E,EAC1E,SAAoC;IAEpC,MAAM,QAAQ,GAAG,SAAS,KAAK,SAAS,CAAC,CAAC,CAAC,kBAAkB,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IACxF,MAAM,GAAG,GAAG,cAAc,CAAC,EAAE,WAAW,EAAE,QAAQ,IAAI,SAAS,EAAE,CAAC,CAAC;IACnE,OAAO,EAAE,GAAG,EAAE,OAAO,EAAE,GAAG,CAAC,CAAC,CAAC,MAAM,iBAAiB,CAAC,IAAI,EAAE,WAAW,CAAC,MAAM,EAAE,KAAK,EAAE,QAAQ,CAAC,EAAE,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;AACjH,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,CAAC,KAAK,UAAU,qBAAqB,CACzC,IAAiB,EACjB,MAAmF,EACnF,KAAqC,EACrC,QAA0E,EAC1E,SAAyB,EACzB,MAAoB,GAAG,EAAE,CAAC,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;IAElD,MAAM,EAAE,GAAG,EAAE,OAAO,EAAE,GAAG,MAAM,cAAc,CAAC,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,QAAQ,EAAE,SAAS,CAAC,CAAC;IACxF,MAAM,QAAQ,GAAG,GAAG,EAAE,CAAC;IACvB,MAAM,OAAO,GAAG,wBAAwB,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,EAAE,EAAE,QAAQ,EAAE,EAAE,EAAE,WAAW,EAAE,QAAQ,EAAE,CAAC;IACtH,OAAO,wBAAwB,CAAC,iBAAiB,CAAC,OAAO,EAAE,GAAG,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC,CAAC;AACtF,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,CAAC,KAAK,UAAU,uBAAuB,CAC3C,IAAiB,EACjB,MAA8D,EAC9D,KAAqC,EACrC,QAA0E,EAC1E,SAAwB,EACxB,MAAoB,GAAG,EAAE,CAAC,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;IAElD,MAAM,EAAE,GAAG,EAAE,OAAO,EAAE,GAAG,MAAM,cAAc,CAAC,IAAI,EAAE,EAAE,GAAG,MAAM,EAAE,gBAAgB,EAAE,IAAI,EAAE,EAAE,KAAK,EAAE,QAAQ,EAAE,SAAS,CAAC,CAAC;IACvH,MAAM,KAAK,GAAG,QAAQ,CAAC,SAAS,KAAK,IAAI,IAAI,OAAO,QAAQ,CAAC,SAAS,KAAK,QAAQ,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAC;QACvH,CAAC,CAAE,QAAQ,CAAC,SAA+B;QAC3C,CAAC,CAAC,IAAI,CAAC;IACT,IAAI,CAAC,GAAG,IAAI,CAAC,uBAAuB,CAAC,KAAK,CAAC,CAAC,YAAY;QAAE,OAAO,SAAS,CAAC;IAC3E,MAAM,QAAQ,GAAG,GAAG,EAAE,CAAC;IACvB,MAAM,OAAO,GAAG,iBAAiB,CAAC,KAAK,IAAI,EAAE,QAAQ,EAAE,EAAE,EAAE,QAAQ,EAAE,EAAE,EAAE,WAAW,EAAE,QAAQ,EAAE,EAAE,GAAG,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC;IAC1H,MAAM,UAAU,GAAG,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,KAAK,UAAU,IAAI,CAAC,KAAK,UAAU,IAAI,CAAC,KAAK,aAAa,CAAC;WAC5G,CAAC,OAAO,CAAC,QAAQ,EAAE,MAAM,IAAI,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,EAAE,MAAM,IAAI,CAAC,CAAC,KAAK,CAAC,CAAC;IACpF,OAAO,UAAU,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC;AACrC,CAAC;AAED,sFAAsF;AACtF,MAAM,UAAU,wBAAwB,CAAC,SAAiB;IACxD,GAAG,CAAC,IAAI,CACN,qBAAqB,SAAS,kFAAkF;QAChH,0HAA0H,CAC3H,CAAC;AACJ,CAAC"}

package/dist/completion/review-next-step.d.ts

@@ -0,0 +1,62 @@
+import type { PipelineConfig } from '../types/index.js';
+import type { FocusExecutionPhase } from '../focus/focus-phase.js';
+/** The delivery slice the review-next-step question reads (structural). */
+export interface ReviewNextStepDelivery {
+    id: string;
+    executionStatus?: string | null;
+}
+/** The issue slice the review-next-step question reads (structural). */
+export interface ReviewNextStepIssue {
+    deliveryId: string;
+    status: string;
+    issueType: string;
+}
+/**
+ * The complete review-next-step decision.
+ *   - not_converged      -- the focus is not in phase 'verifying' (nothing active,
+ *                           at least one verify): no review window opens here.
+ *   - review_disabled    -- converged, but pipeline_config.review.enabled === false:
+ *                           the verify deliveries reach done with no verdict.
+ *   - open_work          -- converged and review-enabled, but a verify delivery
+ *                           carries an open Task/Bug (To Do / In Progress /
+ *                           Blocked): a coding pass, not a review, is next.
+ *   - issues_unreadable  -- converged and review-enabled, but the issue read
+ *                           failed: the decision is unknown; each site fails open
+ *                           to its own pre-decision behaviour.
+ *   - review             -- converged, review-enabled, no open work: a review pass
+ *                           is the next actionable step.
+ * The issue list is read ONLY past the convergence + enablement checks, so an
+ * unconverged or review-disabled focus costs no issue fetch.
+ */
+export type ReviewNextStep<D extends ReviewNextStepDelivery> = {
+    step: 'not_converged';
+} | {
+    step: 'review_disabled';
+    verifyDeliveries: D[];
+} | {
+    step: 'open_work';
+    verifyDeliveries: D[];
+    openIssueCount: number;
+} | {
+    step: 'issues_unreadable';
+    verifyDeliveries: D[];
+    error: Error;
+} | {
+    step: 'review';
+    verifyDeliveries: D[];
+};
+/**
+ * Resolve the review-next-step decision for a focus.
+ *
+ * `phase` is the caller's derived focus execution phase. The pending-spawn gate
+ * derives it with review_requested_at deliberately null (state, not stamp); the
+ * cascade passes the phase it already derived, whose only difference is that an
+ * already-stamped window reads 'reviewing' (not_converged: the window is open).
+ */
+export declare function resolveReviewNextStep<D extends ReviewNextStepDelivery>(input: {
+    phase: FocusExecutionPhase;
+    deliveries: readonly D[];
+    pipelineConfig: PipelineConfig | null | undefined;
+    readIssues: () => Promise<readonly ReviewNextStepIssue[]>;
+}): Promise<ReviewNextStep<D>>;
+//# sourceMappingURL=review-next-step.d.ts.map

package/dist/completion/review-next-step.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-next-step.d.ts","sourceRoot":"","sources":["../../src/completion/review-next-step.ts"],"names":[],"mappings":"AA8BA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,mBAAmB,CAAC;AACxD,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,yBAAyB,CAAC;AAInE,2EAA2E;AAC3E,MAAM,WAAW,sBAAsB;IACrC,EAAE,EAAE,MAAM,CAAC;IACX,eAAe,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;CACjC;AAED,wEAAwE;AACxE,MAAM,WAAW,mBAAmB;IAClC,UAAU,EAAE,MAAM,CAAC;IACnB,MAAM,EAAE,MAAM,CAAC;IACf,SAAS,EAAE,MAAM,CAAC;CACnB;AAED;;;;;;;;;;;;;;;;GAgBG;AACH,MAAM,MAAM,cAAc,CAAC,CAAC,SAAS,sBAAsB,IACvD;IAAE,IAAI,EAAE,eAAe,CAAA;CAAE,GACzB;IAAE,IAAI,EAAE,iBAAiB,CAAC;IAAC,gBAAgB,EAAE,CAAC,EAAE,CAAA;CAAE,GAClD;IAAE,IAAI,EAAE,WAAW,CAAC;IAAC,gBAAgB,EAAE,CAAC,EAAE,CAAC;IAAC,cAAc,EAAE,MAAM,CAAA;CAAE,GACpE;IAAE,IAAI,EAAE,mBAAmB,CAAC;IAAC,gBAAgB,EAAE,CAAC,EAAE,CAAC;IAAC,KAAK,EAAE,KAAK,CAAA;CAAE,GAClE;IAAE,IAAI,EAAE,QAAQ,CAAC;IAAC,gBAAgB,EAAE,CAAC,EAAE,CAAA;CAAE,CAAC;AAS9C;;;;;;;GAOG;AACH,wBAAsB,qBAAqB,CAAC,CAAC,SAAS,sBAAsB,EAAE,KAAK,EAAE;IACnF,KAAK,EAAE,mBAAmB,CAAC;IAC3B,UAAU,EAAE,SAAS,CAAC,EAAE,CAAC;IACzB,cAAc,EAAE,cAAc,GAAG,IAAI,GAAG,SAAS,CAAC;IAClD,UAAU,EAAE,MAAM,OAAO,CAAC,SAAS,mBAAmB,EAAE,CAAC,CAAC;CAC3D,GAAG,OAAO,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,CAe7B"}

package/dist/completion/review-next-step.js

@@ -0,0 +1,63 @@
+// PINNED-BY-BEGIN (generated by gen:pinned-by -- do not hand-edit; checked by lint:pinned-by)
+// Pinned by: packages/daemon/src/completion/review-next-step.test.ts
+// PINNED-BY-END
+/**
+ * "Is the next actionable step on this focus a review pass?" -- keyed on delivery
+ * and issue STATE, never on review_requested_at.
+ *
+ * Two sites ask the same question and must not drift:
+ *   - the state cascade (completion/state-cascade.ts checkAutoReview), which OPENS
+ *     the review window when the focus converges on verify; and
+ *   - the pending-spawn pass (focus/pending-spawn-review-next-step.ts), which must
+ *     not spawn a CODING lead into that same state -- a coding lead there has no
+ *     work, holds the focus's single team slot, and deadlocks the review.
+ *
+ * Why state and not the stamp: on 2026-09-15 a queued coding directive was
+ * consumed at 03:08:29 while every delivery was already in verify with all issues
+ * Done; the cascade stamped review_requested_at at 03:08:30. The spawn decision
+ * ran BEFORE the stamp, so a check keyed on review_requested_at would have passed.
+ * The delivery aggregate that makes the cascade stamp the window was already true.
+ *
+ * Both sites consume ONE complete decision, resolveReviewNextStep: convergence on
+ * verify, review enablement, AND the open-work issue matrix. Before, the cascade
+ * consumed only the convergence half, so a verify delivery with a freshly opened
+ * Bug made the spawn gate say "coding is next" while the cascade still opened a
+ * review window. Each site maps the outcome onto its own action (and its own
+ * fail-open reading of an unreadable issue list); the decision itself is here.
+ */
+import { DELIVERY_STATUS } from '@telora/daemon-core';
+import { isReviewEnabled } from '../workflow/pipeline-config.js';
+import { CONTEXT_GROUP_TYPE, OPEN_ISSUE_STATUSES } from '../shell/constants.js';
+/** Open work issues (Task/Bug in To Do / In Progress / Blocked) sitting on the given deliveries. */
+function countOpenWorkIssues(verifyIds, issues) {
+    return issues.filter((i) => verifyIds.has(i.deliveryId) && i.issueType !== CONTEXT_GROUP_TYPE && OPEN_ISSUE_STATUSES.has(i.status)).length;
+}
+/**
+ * Resolve the review-next-step decision for a focus.
+ *
+ * `phase` is the caller's derived focus execution phase. The pending-spawn gate
+ * derives it with review_requested_at deliberately null (state, not stamp); the
+ * cascade passes the phase it already derived, whose only difference is that an
+ * already-stamped window reads 'reviewing' (not_converged: the window is open).
+ */
+export async function resolveReviewNextStep(input) {
+    if (input.phase !== 'verifying')
+        return { step: 'not_converged' };
+    const verifyDeliveries = input.deliveries.filter((d) => d.executionStatus === DELIVERY_STATUS.VERIFY);
+    if (verifyDeliveries.length === 0)
+        return { step: 'not_converged' };
+    if (!isReviewEnabled(input.pipelineConfig))
+        return { step: 'review_disabled', verifyDeliveries };
+    let issues;
+    try {
+        issues = await input.readIssues();
+    }
+    catch (err) {
+        return { step: 'issues_unreadable', verifyDeliveries, error: err instanceof Error ? err : new Error(String(err)) };
+    }
+    const openIssueCount = countOpenWorkIssues(new Set(verifyDeliveries.map((d) => d.id)), issues);
+    if (openIssueCount > 0)
+        return { step: 'open_work', verifyDeliveries, openIssueCount };
+    return { step: 'review', verifyDeliveries };
+}
+//# sourceMappingURL=review-next-step.js.map

package/dist/completion/review-next-step.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-next-step.js","sourceRoot":"","sources":["../../src/completion/review-next-step.ts"],"names":[],"mappings":"AAAA,8FAA8F;AAC9F,qEAAqE;AACrE,gBAAgB;AAEhB;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AAEH,OAAO,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAC;AAGtD,OAAO,EAAE,eAAe,EAAE,MAAM,gCAAgC,CAAC;AACjE,OAAO,EAAE,kBAAkB,EAAE,mBAAmB,EAAE,MAAM,uBAAuB,CAAC;AAuChF,oGAAoG;AACpG,SAAS,mBAAmB,CAAC,SAA8B,EAAE,MAAsC;IACjG,OAAO,MAAM,CAAC,MAAM,CAClB,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,SAAS,KAAK,kBAAkB,IAAI,mBAAmB,CAAC,GAAG,CAAC,CAAC,CAAC,MAAM,CAAC,CAC9G,CAAC,MAAM,CAAC;AACX,CAAC;AAED;;;;;;;GAOG;AACH,MAAM,CAAC,KAAK,UAAU,qBAAqB,CAAmC,KAK7E;IACC,IAAI,KAAK,CAAC,KAAK,KAAK,WAAW;QAAE,OAAO,EAAE,IAAI,EAAE,eAAe,EAAE,CAAC;IAClE,MAAM,gBAAgB,GAAG,KAAK,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,eAAe,KAAK,eAAe,CAAC,MAAM,CAAC,CAAC;IACtG,IAAI,gBAAgB,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,EAAE,IAAI,EAAE,eAAe,EAAE,CAAC;IACpE,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC,cAAc,CAAC;QAAE,OAAO,EAAE,IAAI,EAAE,iBAAiB,EAAE,gBAAgB,EAAE,CAAC;IAEjG,IAAI,MAAsC,CAAC;IAC3C,IAAI,CAAC;QACH,MAAM,GAAG,MAAM,KAAK,CAAC,UAAU,EAAE,CAAC;IACpC,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,OAAO,EAAE,IAAI,EAAE,mBAAmB,EAAE,gBAAgB,EAAE,KAAK,EAAE,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,EAAE,CAAC;IACrH,CAAC;IACD,MAAM,cAAc,GAAG,mBAAmB,CAAC,IAAI,GAAG,CAAC,gBAAgB,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC;IAC/F,IAAI,cAAc,GAAG,CAAC;QAAE,OAAO,EAAE,IAAI,EAAE,WAAW,EAAE,gBAAgB,EAAE,cAAc,EAAE,CAAC;IACvF,OAAO,EAAE,IAAI,EAAE,QAAQ,EAAE,gBAAgB,EAAE,CAAC;AAC9C,CAAC"}

package/dist/completion/session-hold-sweep-deps.d.ts

@@ -0,0 +1,17 @@
+import { type CreateEscalationParams } from '../queries/escalations.js';
+import { type ExpiredSessionHold, type SessionHoldSweepDeps } from './session-hold.js';
+/** metadata.cause stamped on a session-hold expiry escalation. */
+export declare const SESSION_HOLD_EXPIRED_CAUSE = "session_hold_expired";
+/**
+ * File the ONE escalation a hold expiry owes: a still-active kept team, or a
+ * teardown that could not signal the lead and ended in a forced registration
+ * reap. Both are agent work (read the log / check for an orphan process) -- no
+ * human act -- so the filing chokepoint sends them to the machine lane as
+ * observations.
+ */
+export declare function fileSessionHoldExpiryEscalation(expired: ExpiredSessionHold, deps?: {
+    createEscalation: (params: CreateEscalationParams) => Promise<unknown>;
+}): Promise<void>;
+/** The production sweep deps; tests override individual collaborators. */
+export declare function buildSessionHoldSweepDeps(overrides?: Partial<SessionHoldSweepDeps>): SessionHoldSweepDeps;
+//# sourceMappingURL=session-hold-sweep-deps.d.ts.map

package/dist/completion/session-hold-sweep-deps.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"session-hold-sweep-deps.d.ts","sourceRoot":"","sources":["../../src/completion/session-hold-sweep-deps.ts"],"names":[],"mappings":"AAkBA,OAAO,EAA+C,KAAK,sBAAsB,EAAE,MAAM,2BAA2B,CAAC;AAGrH,OAAO,EAAsC,KAAK,kBAAkB,EAAE,KAAK,oBAAoB,EAAE,MAAM,mBAAmB,CAAC;AAE3H,kEAAkE;AAClE,eAAO,MAAM,0BAA0B,yBAAyB,CAAC;AAoCjE;;;;;;GAMG;AACH,wBAAsB,+BAA+B,CACnD,OAAO,EAAE,kBAAkB,EAC3B,IAAI,GAAE;IAAE,gBAAgB,EAAE,CAAC,MAAM,EAAE,sBAAsB,KAAK,OAAO,CAAC,OAAO,CAAC,CAAA;CAAkD,GAC/H,OAAO,CAAC,IAAI,CAAC,CAiBf;AAED,0EAA0E;AAC1E,wBAAgB,yBAAyB,CAAC,SAAS,GAAE,OAAO,CAAC,oBAAoB,CAAM,GAAG,oBAAoB,CAc7G"}