@telnyx/react-voice-commons-sdk 1.2.0 → 1.2.1

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # CHANGELOG.md
 
+## [1.2.1] (2026-10-30)
+
+### Bug Fixing
+
+- Fix iOS call waiting. In 1.2.0, answering a second call failed while another call was active or still being answered, so the iOS Hold & Accept and End & Accept options did not connect the new call. Answering the same call twice is still ignored.
+- `Call.answer()` on iOS now rejects when CallKit fails to answer the call, as `hold()` and `resume()` already do. It previously resolved even though the call was not answered, so apps that await `answer()` should handle the rejection.
+
 ## [1.2.0] (2026-10-28)
 
 ### Enhancement

package/lib/callkit/callkit-coordinator.d.ts

@@ -18,8 +18,6 @@ declare class CallKitCoordinator {
   private static instance;
   private callMap;
   private processingCalls;
-  private activeOrAnsweringCallUUID;
-  private claimActiveCall;
   private endedCalls;
   private connectedCalls;
   private isCallFromPush;
@@ -144,7 +142,6 @@ declare class CallKitCoordinator {
   private getSDKClient;
   private normalizeUUID;
   private actionKey;
-  private releaseActiveCall;
   private selectCall;
   private isSelectedCall;
   private recordPendingSwapAction;
@@ -167,10 +164,6 @@ declare class CallKitCoordinator {
    * This helps prevent premature flag resets during CallKit operations
    */
   hasProcessingCalls(): boolean;
-  /** @internal Exposed for deterministic single-active-call regression tests. */
-  claimActiveCallForTesting(callKitUUID: string): boolean;
-  /** @internal Exposed for deterministic single-active-call regression tests. */
-  releaseActiveCallForTesting(callKitUUID: string): void;
   /**
    * Check if there's currently a call from push notification being processed
    * This helps prevent disconnection during push call handling

package/lib/callkit/callkit-coordinator.js

@@ -64,13 +64,6 @@ const voice_pn_bridge_1 = require('../internal/voice-pn-bridge');
  * guidelines for proper CallKit integration.
  */
 class CallKitCoordinator {
-  claimActiveCall(callKitUUID) {
-    if (this.activeOrAnsweringCallUUID !== null && this.activeOrAnsweringCallUUID !== callKitUUID) {
-      return false;
-    }
-    this.activeOrAnsweringCallUUID = callKitUUID;
-    return true;
-  }
   static getInstance() {
     if (!CallKitCoordinator.instance) {
       CallKitCoordinator.instance = new CallKitCoordinator();
@@ -83,7 +76,8 @@ class CallKitCoordinator {
     // Tracks action+UUID pairs so an end action is not dropped merely because
     // an answer or held action for the same call is still completing.
     this.processingCalls = new Set();
-    this.activeOrAnsweringCallUUID = null;
+    // CallKit/the app owns cross-call hold and swap policy. Only serialize
+    // duplicate actions for the same UUID; held calls must not block a new answer.
     // Tracks calls that have already been ended in CallKit to prevent duplicate reports
     this.endedCalls = new Set();
     // Tracks calls that have already been reported as connected to prevent duplicate reports
@@ -195,16 +189,6 @@ class CallKitCoordinator {
         displayName || destinationNumber
       );
       if (success) {
-        if (!this.claimActiveCall(callKitUUID)) {
-          console.warn('CallKitCoordinator: Another call is already active or answering');
-          await callkit_1.default.reportCallEnded(callKitUUID, callkit_1.CallEndReason.Failed);
-          try {
-            await call.hangup();
-          } finally {
-            this.cleanupCall(callKitUUID);
-          }
-          return null;
-        }
         this.callMap.set(callKitUUID, call);
         this.setupWebRTCCallListeners(call, callKitUUID);
         call._callKitUUID = callKitUUID;
@@ -226,10 +210,6 @@ class CallKitCoordinator {
       console.warn('CallKitCoordinator: Cannot answer call - no CallKit UUID found');
       return false;
     }
-    if (!this.claimActiveCall(callKitUUID)) {
-      console.warn('CallKitCoordinator: Another call is already active or answering');
-      return false;
-    }
     console.log(
       'CallKitCoordinator: Answering call from UI using CallKit answer simulation',
       callKitUUID
@@ -258,8 +238,6 @@ class CallKitCoordinator {
         this.isCallFromPush = this.pendingPushCallUUIDs.size > 0;
         await this.clearMatchingPendingVoipPush(callKitUUID);
         console.log('CallKitCoordinator: CallKit answer success');
-      } else {
-        this.releaseActiveCall(callKitUUID);
       }
       return success;
     } catch (error) {
@@ -415,21 +393,6 @@ class CallKitCoordinator {
       console.log('CallKitCoordinator: Answer action already being processed, skipping duplicate');
       return;
     }
-    if (!this.claimActiveCall(callKitUUID)) {
-      console.warn(
-        'CallKitCoordinator: Rejecting answer because another call owns the active slot'
-      );
-      await callkit_1.default.reportCallEnded(callKitUUID, callkit_1.CallEndReason.Failed);
-      const rejectedCall = this.callMap.get(callKitUUID);
-      if (rejectedCall) {
-        try {
-          await rejectedCall.hangup();
-        } finally {
-          this.cleanupCall(callKitUUID);
-        }
-      }
-      return;
-    }
     const call = this.callMap.get(callKitUUID);
     if (!call) {
       console.warn('CallKitCoordinator: No WebRTC call found for CallKit answer action', {
@@ -438,10 +401,7 @@ class CallKitCoordinator {
         availableWebRTCCallIds: Array.from(this.callMap.values()).map((c) => c.callId),
       });
       console.log('CallKitCoordinator: No WebRTC call found, handling as push notification');
-      const queued = await this.handlePushNotificationAnswer(callKitUUID, event);
-      if (!queued) {
-        this.releaseActiveCall(callKitUUID);
-      }
+      await this.handlePushNotificationAnswer(callKitUUID, event);
       return;
     }
     console.log('CallKitCoordinator: Processing CallKit answer action', {
@@ -832,18 +792,6 @@ class CallKitCoordinator {
       });
       switch (state) {
         case 'active':
-          if (!this.claimActiveCall(callKitUUID)) {
-            console.warn(
-              'CallKitCoordinator: Ending active call because another call owns the slot'
-            );
-            await callkit_1.default.reportCallEnded(callKitUUID, callkit_1.CallEndReason.Failed);
-            try {
-              await call.hangup();
-            } finally {
-              this.cleanupCall(callKitUUID);
-            }
-            break;
-          }
           this.selectCall(call);
           this.pendingPushCallUUIDs.delete(callKitUUID);
           this.autoAnswerCallUUIDs.delete(callKitUUID);
@@ -918,9 +866,6 @@ class CallKitCoordinator {
     this.connectedCalls.delete(callKitUUID);
     this.pendingPushCallUUIDs.delete(callKitUUID);
     this.autoAnswerCallUUIDs.delete(callKitUUID);
-    if (this.activeOrAnsweringCallUUID === callKitUUID) {
-      this.activeOrAnsweringCallUUID = null;
-    }
     // Get the call before removing it
     const call = this.callMap.get(callKitUUID);
     // Clean up state listeners
@@ -1050,12 +995,6 @@ class CallKitCoordinator {
   actionKey(action, callKitUUID) {
     return `${action}:${this.normalizeUUID(callKitUUID)}`;
   }
-  releaseActiveCall(callKitUUID) {
-    callKitUUID = this.normalizeUUID(callKitUUID);
-    if (this.activeOrAnsweringCallUUID === callKitUUID) {
-      this.activeOrAnsweringCallUUID = null;
-    }
-  }
   selectCall(call) {
     const callKitUUID = this.getCallKitUUID(call);
     const wrapperCall = this.voipClient?.findCallByTelnyxCall(call);
@@ -1263,9 +1202,6 @@ class CallKitCoordinator {
   resetFlags() {
     console.log('CallKitCoordinator: Resetting coordinator flags');
     this.isCallFromPush = this.pendingPushCallUUIDs.size > 0;
-    if (this.callMap.size === 0) {
-      this.activeOrAnsweringCallUUID = null;
-    }
     console.log('CallKitCoordinator: ✅ Coordinator flags reset');
   }
   /**
@@ -1279,14 +1215,6 @@ class CallKitCoordinator {
     // call arrives during push notification handling.
     return this.processingCalls.size > 0 || this.isCallFromPush;
   }
-  /** @internal Exposed for deterministic single-active-call regression tests. */
-  claimActiveCallForTesting(callKitUUID) {
-    return this.claimActiveCall(callKitUUID);
-  }
-  /** @internal Exposed for deterministic single-active-call regression tests. */
-  releaseActiveCallForTesting(callKitUUID) {
-    this.releaseActiveCall(callKitUUID);
-  }
   /**
    * Check if there's currently a call from push notification being processed
    * This helps prevent disconnection during push call handling

package/lib/models/call.js

@@ -281,7 +281,10 @@ class Call {
         );
         if (callKitCoordinator.isAvailable()) {
           console.log('Call: Using CallKit coordinator to answer call (iOS)');
-          await callKitCoordinator.answerCallFromUI(this._telnyxCall);
+          const answered = await callKitCoordinator.answerCallFromUI(this._telnyxCall);
+          if (!answered) {
+            throw new Error('CallKit failed to answer call');
+          }
           return;
         }
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@telnyx/react-voice-commons-sdk",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "A high-level, state-agnostic, drop-in module for the Telnyx React Native SDK that simplifies WebRTC voice calling integration",
   "main": "lib/index.js",
   "module": "lib/index.js",

package/src/callkit/callkit-coordinator.ts

@@ -45,15 +45,8 @@ class CallKitCoordinator {
   // Tracks action+UUID pairs so an end action is not dropped merely because
   // an answer or held action for the same call is still completing.
   private processingCalls = new Set<string>();
-  private activeOrAnsweringCallUUID: string | null = null;
-
-  private claimActiveCall(callKitUUID: string): boolean {
-    if (this.activeOrAnsweringCallUUID !== null && this.activeOrAnsweringCallUUID !== callKitUUID) {
-      return false;
-    }
-    this.activeOrAnsweringCallUUID = callKitUUID;
-    return true;
-  }
+  // CallKit/the app owns cross-call hold and swap policy. Only serialize
+  // duplicate actions for the same UUID; held calls must not block a new answer.
 
   // Tracks calls that have already been ended in CallKit to prevent duplicate reports
   private endedCalls = new Set<string>();
@@ -201,16 +194,6 @@ class CallKitCoordinator {
       );
 
       if (success) {
-        if (!this.claimActiveCall(callKitUUID)) {
-          console.warn('CallKitCoordinator: Another call is already active or answering');
-          await CallKit.reportCallEnded(callKitUUID, CallEndReason.Failed);
-          try {
-            await call.hangup();
-          } finally {
-            this.cleanupCall(callKitUUID);
-          }
-          return null;
-        }
         this.callMap.set(callKitUUID, call);
         this.setupWebRTCCallListeners(call, callKitUUID);
         (call as any)._callKitUUID = callKitUUID;
@@ -235,11 +218,6 @@ class CallKitCoordinator {
       return false;
     }
 
-    if (!this.claimActiveCall(callKitUUID)) {
-      console.warn('CallKitCoordinator: Another call is already active or answering');
-      return false;
-    }
-
     console.log(
       'CallKitCoordinator: Answering call from UI using CallKit answer simulation',
       callKitUUID
@@ -272,8 +250,6 @@ class CallKitCoordinator {
         this.isCallFromPush = this.pendingPushCallUUIDs.size > 0;
         await this.clearMatchingPendingVoipPush(callKitUUID);
         console.log('CallKitCoordinator: CallKit answer success');
-      } else {
-        this.releaseActiveCall(callKitUUID);
       }
 
       return success;
@@ -452,22 +428,6 @@ class CallKitCoordinator {
       return;
     }
 
-    if (!this.claimActiveCall(callKitUUID)) {
-      console.warn(
-        'CallKitCoordinator: Rejecting answer because another call owns the active slot'
-      );
-      await CallKit.reportCallEnded(callKitUUID, CallEndReason.Failed);
-      const rejectedCall = this.callMap.get(callKitUUID);
-      if (rejectedCall) {
-        try {
-          await rejectedCall.hangup();
-        } finally {
-          this.cleanupCall(callKitUUID);
-        }
-      }
-      return;
-    }
-
     const call = this.callMap.get(callKitUUID);
 
     if (!call) {
@@ -478,10 +438,7 @@ class CallKitCoordinator {
       });
 
       console.log('CallKitCoordinator: No WebRTC call found, handling as push notification');
-      const queued = await this.handlePushNotificationAnswer(callKitUUID, event);
-      if (!queued) {
-        this.releaseActiveCall(callKitUUID);
-      }
+      await this.handlePushNotificationAnswer(callKitUUID, event);
       return;
     }
 
@@ -935,18 +892,6 @@ class CallKitCoordinator {
 
       switch (state) {
         case 'active':
-          if (!this.claimActiveCall(callKitUUID)) {
-            console.warn(
-              'CallKitCoordinator: Ending active call because another call owns the slot'
-            );
-            await CallKit.reportCallEnded(callKitUUID, CallEndReason.Failed);
-            try {
-              await call.hangup();
-            } finally {
-              this.cleanupCall(callKitUUID);
-            }
-            break;
-          }
           this.selectCall(call);
           this.pendingPushCallUUIDs.delete(callKitUUID);
           this.autoAnswerCallUUIDs.delete(callKitUUID);
@@ -1025,9 +970,6 @@ class CallKitCoordinator {
     this.connectedCalls.delete(callKitUUID);
     this.pendingPushCallUUIDs.delete(callKitUUID);
     this.autoAnswerCallUUIDs.delete(callKitUUID);
-    if (this.activeOrAnsweringCallUUID === callKitUUID) {
-      this.activeOrAnsweringCallUUID = null;
-    }
 
     // Get the call before removing it
     const call = this.callMap.get(callKitUUID);
@@ -1185,13 +1127,6 @@ class CallKitCoordinator {
     return `${action}:${this.normalizeUUID(callKitUUID)}`;
   }
 
-  private releaseActiveCall(callKitUUID: string): void {
-    callKitUUID = this.normalizeUUID(callKitUUID);
-    if (this.activeOrAnsweringCallUUID === callKitUUID) {
-      this.activeOrAnsweringCallUUID = null;
-    }
-  }
-
   private selectCall(call: Call): void {
     const callKitUUID = this.getCallKitUUID(call);
     const wrapperCall = this.voipClient?.findCallByTelnyxCall(call);
@@ -1430,10 +1365,6 @@ class CallKitCoordinator {
 
     this.isCallFromPush = this.pendingPushCallUUIDs.size > 0;
 
-    if (this.callMap.size === 0) {
-      this.activeOrAnsweringCallUUID = null;
-    }
-
     console.log('CallKitCoordinator: ✅ Coordinator flags reset');
   }
 
@@ -1449,16 +1380,6 @@ class CallKitCoordinator {
     return this.processingCalls.size > 0 || this.isCallFromPush;
   }
 
-  /** @internal Exposed for deterministic single-active-call regression tests. */
-  claimActiveCallForTesting(callKitUUID: string): boolean {
-    return this.claimActiveCall(callKitUUID);
-  }
-
-  /** @internal Exposed for deterministic single-active-call regression tests. */
-  releaseActiveCallForTesting(callKitUUID: string): void {
-    this.releaseActiveCall(callKitUUID);
-  }
-
   /**
    * Check if there's currently a call from push notification being processed
    * This helps prevent disconnection during push call handling

package/src/models/call.ts

@@ -254,7 +254,10 @@ export class Call {
         const { callKitCoordinator } = await import('../callkit/callkit-coordinator');
         if (callKitCoordinator.isAvailable()) {
           console.log('Call: Using CallKit coordinator to answer call (iOS)');
-          await callKitCoordinator.answerCallFromUI(this._telnyxCall);
+          const answered = await callKitCoordinator.answerCallFromUI(this._telnyxCall);
+          if (!answered) {
+            throw new Error('CallKit failed to answer call');
+          }
           return;
         }
       }