@telnyx/react-voice-commons-sdk 0.4.2 → 0.4.3

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # CHANGELOG.md
 
+## [0.4.3] (2026-04-30)
+
+### Bug Fixing
+
+- **VoIP push always rebuilds the `TelnyxRTC` instance.** `SessionManager.handlePushNotification` now unconditionally disposes any prior client and runs `_connect()` afresh, so the new socket's URL bakes in THIS push's `voice_sdk_id`. Reusing a prior connection would cause the gateway to route this push's INVITE to whichever client announced with the new `voice_sdk_id` (i.e. a different connection), leaving us listening on the wrong socket until CallKit timed out.
+- **Dropped the `loginFromStoredConfig()` fallback inside `TelnyxVoipClient.handlePushNotification`.** When SessionManager's push-driven `_connect()` didn't immediately reach `CONNECTED`, the fallback would create a second TelnyxRTC instance with no `voice_sdk_id` awareness. The gateway then `punt`-ed one of the parallel sessions, dropping the active call. SessionManager already loads stored credentials internally for the cold-launch path; the redundant fallback only created races.
+
+### Dependencies
+
+- Now requires `@telnyx/react-native-voice-sdk >= 0.4.5`, which removes the auto-reconnect on socket error/close that was triggering the multi-instance race. See the [voice-sdk 0.4.5 changelog](../package/CHANGELOG.md#045-2026-04-30) for details.
+
 ## [0.4.2] (2026-04-27)
 
 ### Bug Fixing

package/lib/internal/session/session-manager.js

@@ -202,39 +202,22 @@ class SessionManager {
     );
     // Store the push notification payload for when the client is created
     this._pendingPushPayload = payload;
-    // If we have a TelnyxRTC instance but its socket isn't fresh — either not
-    // connected at all, or connected but with no traffic for longer than the
-    // threshold — dispose it so we go through the full _connect() path below
-    // instead of calling processVoIPNotification on a stale client.
-    //
-    // This handles two cases iOS gives us with the same code path:
-    //   1. Terminated-then-cold-launched: a client exists (constructed at
-    //      app boot) but its connection was never opened (idleMs=Infinity).
-    //   2. Suspended-then-thawed: a client exists with `connected=true`,
-    //      but the kernel killed the TLS session during freeze without
-    //      notifying the JS WebSocket wrapper, so no error event fired.
-    //
-    // 30s threshold matches the server's keep-alive ping cadence (~20s),
-    // so a live session always remains fresh.
-    const STALE_THRESHOLD_MS = 30000;
+    // Each push always rebuilds the TelnyxRTC client. The voice_sdk_id is
+    // baked into the WebSocket URL at socket-open time and can't be mutated
+    // mid-flight; reusing a connection from a previous push means the
+    // gateway routes THIS push's INVITE to a different (correctly-stamped)
+    // client and we sit on the wrong socket forever.
     if (this._telnyxClient) {
-      const client = this._telnyxClient;
-      const isFresh =
-        typeof client.isFresh === 'function'
-          ? client.isFresh(STALE_THRESHOLD_MS)
-          : !!client.connected;
-      if (!isFresh) {
-        try {
-          await this._telnyxClient.disconnect();
-        } catch (err) {
-          console.warn('SessionManager: disconnect of stale client threw:', err);
-        }
-        this._telnyxClient = undefined;
-        if (this.currentState !== connection_state_1.TelnyxConnectionState.DISCONNECTED) {
-          this._connectionState.next(connection_state_1.TelnyxConnectionState.DISCONNECTED);
-        }
+      try {
+        await this._telnyxClient.disconnect();
+      } catch (err) {
+        console.warn('SessionManager: disconnect of prior client threw:', err);
       }
     }
+    this._telnyxClient = undefined;
+    if (this.currentState !== connection_state_1.TelnyxConnectionState.DISCONNECTED) {
+      this._connectionState.next(connection_state_1.TelnyxConnectionState.DISCONNECTED);
+    }
     // If we don't have a config yet but we're processing a push notification,
     // attempt to load stored config first (for terminated app startup)
     if (!this._currentConfig && !this._telnyxClient) {

package/lib/telnyx-voip-client.js

@@ -333,21 +333,14 @@ class TelnyxVoipClient {
       console.log('TelnyxVoipClient: Handling push notification:', payload);
     }
     try {
-      // First, pass the push notification to the session manager for processing
-      // This will set the isCallFromPush flag on the TelnyxRTC client
+      // SessionManager owns the entire push lifecycle: it disposes any prior
+      // client, loads stored credentials if needed, and rebuilds the
+      // TelnyxRTC bound to THIS push's voice_sdk_id. We deliberately do not
+      // fall back to a generic loginFromStoredConfig() here — that would
+      // create a parallel client with no voice_sdk_id awareness, which the
+      // gateway then has to `punt` once the SessionManager-driven session
+      // also registers, dropping the active call.
       await this._sessionManager.handlePushNotification(payload);
-      // Connect if not already connected
-      const currentState = this.currentConnectionState;
-      if (currentState !== connection_state_1.TelnyxConnectionState.CONNECTED) {
-        // Try to login from stored config - now the push flags should be set
-        const loginSuccess = await this.loginFromStoredConfig();
-        if (!loginSuccess) {
-          console.warn(
-            'TelnyxVoipClient: Could not login from stored config for push notification'
-          );
-          return;
-        }
-      }
     } catch (error) {
       console.error('TelnyxVoipClient: Error handling push notification:', error);
       throw error;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@telnyx/react-voice-commons-sdk",
-  "version": "0.4.2",
+  "version": "0.4.3",
   "description": "A high-level, state-agnostic, drop-in module for the Telnyx React Native SDK that simplifies WebRTC voice calling integration",
   "main": "lib/index.js",
   "module": "lib/index.js",
@@ -86,7 +86,7 @@
   },
   "dependencies": {
     "@react-native-community/eslint-config": "^3.2.0",
-    "@telnyx/react-native-voice-sdk": ">=0.4.4",
+    "@telnyx/react-native-voice-sdk": ">=0.4.5",
     "eventemitter3": "^5.0.1",
     "expo": "~53.0.22",
     "react-native-url-polyfill": "^3.0.0",

package/src/internal/session/session-manager.ts

@@ -178,39 +178,22 @@ export class SessionManager {
     // Store the push notification payload for when the client is created
     (this as any)._pendingPushPayload = payload;
 
-    // If we have a TelnyxRTC instance but its socket isn't fresh — either not
-    // connected at all, or connected but with no traffic for longer than the
-    // threshold — dispose it so we go through the full _connect() path below
-    // instead of calling processVoIPNotification on a stale client.
-    //
-    // This handles two cases iOS gives us with the same code path:
-    //   1. Terminated-then-cold-launched: a client exists (constructed at
-    //      app boot) but its connection was never opened (idleMs=Infinity).
-    //   2. Suspended-then-thawed: a client exists with `connected=true`,
-    //      but the kernel killed the TLS session during freeze without
-    //      notifying the JS WebSocket wrapper, so no error event fired.
-    //
-    // 30s threshold matches the server's keep-alive ping cadence (~20s),
-    // so a live session always remains fresh.
-    const STALE_THRESHOLD_MS = 30000;
+    // Each push always rebuilds the TelnyxRTC client. The voice_sdk_id is
+    // baked into the WebSocket URL at socket-open time and can't be mutated
+    // mid-flight; reusing a connection from a previous push means the
+    // gateway routes THIS push's INVITE to a different (correctly-stamped)
+    // client and we sit on the wrong socket forever.
     if (this._telnyxClient) {
-      const client = this._telnyxClient as any;
-      const isFresh =
-        typeof client.isFresh === 'function'
-          ? client.isFresh(STALE_THRESHOLD_MS)
-          : !!client.connected;
-      if (!isFresh) {
-        try {
-          await this._telnyxClient.disconnect();
-        } catch (err) {
-          console.warn('SessionManager: disconnect of stale client threw:', err);
-        }
-        this._telnyxClient = undefined;
-        if (this.currentState !== TelnyxConnectionState.DISCONNECTED) {
-          this._connectionState.next(TelnyxConnectionState.DISCONNECTED);
-        }
+      try {
+        await this._telnyxClient.disconnect();
+      } catch (err) {
+        console.warn('SessionManager: disconnect of prior client threw:', err);
       }
     }
+    this._telnyxClient = undefined;
+    if (this.currentState !== TelnyxConnectionState.DISCONNECTED) {
+      this._connectionState.next(TelnyxConnectionState.DISCONNECTED);
+    }
 
     // If we don't have a config yet but we're processing a push notification,
     // attempt to load stored config first (for terminated app startup)

package/src/telnyx-voip-client.ts

@@ -401,22 +401,14 @@ export class TelnyxVoipClient {
     }
 
     try {
-      // First, pass the push notification to the session manager for processing
-      // This will set the isCallFromPush flag on the TelnyxRTC client
+      // SessionManager owns the entire push lifecycle: it disposes any prior
+      // client, loads stored credentials if needed, and rebuilds the
+      // TelnyxRTC bound to THIS push's voice_sdk_id. We deliberately do not
+      // fall back to a generic loginFromStoredConfig() here — that would
+      // create a parallel client with no voice_sdk_id awareness, which the
+      // gateway then has to `punt` once the SessionManager-driven session
+      // also registers, dropping the active call.
       await this._sessionManager.handlePushNotification(payload);
-
-      // Connect if not already connected
-      const currentState = this.currentConnectionState;
-      if (currentState !== TelnyxConnectionState.CONNECTED) {
-        // Try to login from stored config - now the push flags should be set
-        const loginSuccess = await this.loginFromStoredConfig();
-        if (!loginSuccess) {
-          console.warn(
-            'TelnyxVoipClient: Could not login from stored config for push notification'
-          );
-          return;
-        }
-      }
     } catch (error) {
       console.error('TelnyxVoipClient: Error handling push notification:', error);
       throw error;