@telnyx/react-voice-commons-sdk 0.1.8-beta.0 → 0.1.8-beta.1

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # CHANGELOG.md
 
+## [0.1.8-beta.1](https://github.com/team-telnyx/react-native-voice-commons/releases/tag/0.1.8-beta.1) (2026-03-04)
+
+### Bug Fixing
+
+• Fixed duplicate CXProvider overwrite causing `CXEndCallAction` error 4 (unknownCallUUID) — guard `setupCallKit()` to prevent async `setupAutomatically()` from overwriting the provider created by `setupSynchronously()` during VoIP push handling
+• Fixed intermittent audio loss on push notification calls — defer `CXAnswerCallAction.fulfill()` until `reportCallConnected()` when the WebRTC peer connection is ready
+• Aligned iOS audio session handling with native Telnyx iOS SDK pattern (`RTCAudioSessionConfiguration.webRTC()` with `lockForConfiguration`/`unlockForConfiguration`)
+• Fixed endCall not dismissing CallKit UI — check `endCall()` return value and fallback to `reportCallEnded()` when CXEndCallAction fails
+• Fixed push notification answer crash when voipClient is not yet initialized — defer to `checkForInitialPushNotification()` instead of failing the call
+• Added `voipClient.queueAnswerFromCallKit()` call when handling push notification answer for auto-answer on INVITE arrival
+
 ## [0.1.7](https://github.com/team-telnyx/react-native-voice-commons/releases/tag/0.1.7) (2026-02-20)
 
 ### Enhancement

package/ios/CallKitBridge.swift

@@ -205,6 +205,33 @@ import React
             }
 
             provider.reportOutgoingCall(with: uuid, connectedAt: Date())
+
+            // Fulfill deferred CXAnswerCallAction now that peer connection is ready
+            if let pendingAction = manager.pendingAnswerAction {
+                NSLog("TelnyxVoice: reportCallConnected - fulfilling deferred CXAnswerCallAction")
+                pendingAction.fulfill()
+                manager.pendingAnswerAction = nil
+            } else {
+                // Fallback: ensure audio is enabled for non-push or already-fulfilled cases
+                let rtcAudioSession = RTCAudioSession.sharedInstance()
+                rtcAudioSession.lockForConfiguration()
+                let webRTCConfig = RTCAudioSessionConfiguration.webRTC()
+                webRTCConfig.categoryOptions = [.duckOthers, .allowBluetooth]
+                do {
+                    try rtcAudioSession.setConfiguration(webRTCConfig)
+                } catch {
+                    NSLog("TelnyxVoice: reportCallConnected - setConfiguration error: \(error)")
+                }
+                do {
+                    try rtcAudioSession.setActive(true)
+                } catch {
+                    NSLog("TelnyxVoice: reportCallConnected - setActive error: \(error)")
+                }
+                rtcAudioSession.isAudioEnabled = true
+                rtcAudioSession.unlockForConfiguration()
+                rtcAudioSession.audioSessionDidActivate(AVAudioSession.sharedInstance())
+            }
+
             resolve(["success": true])
         }
 
@@ -276,6 +303,7 @@ import React
         public var callKitProvider: CXProvider?
         public var callKitController: CXCallController?
         public var activeCalls: [UUID: [String: Any]] = [:]
+        public var pendingAnswerAction: CXAnswerCallAction?
 
         private override init() {
             super.init()
@@ -327,12 +355,16 @@ import React
         }
 
         private func setupCallKit() {
-            // CRITICAL: Configure WebRTC for manual audio control BEFORE CallKit setup
+            // ALWAYS configure WebRTC audio, even if provider already exists
             RTCAudioSession.sharedInstance().useManualAudio = true
-            RTCAudioSession.sharedInstance().isAudioEnabled = false  // MUST be false initially!
-            NSLog(
-                "🎧 TelnyxVoice: WebRTC configured for manual audio control (audio DISABLED until CallKit activates)"
-            )
+            RTCAudioSession.sharedInstance().isAudioEnabled = false
+
+            // Guard against duplicate provider creation (async setupAutomatically can overwrite
+            // the provider created by setupSynchronously for VoIP push)
+            guard callKitProvider == nil else {
+                NSLog("TelnyxVoice: setupCallKit() - provider already exists, skipping to prevent overwrite")
+                return
+            }
 
             // Use the localizedName from the app's bundle display name or fallback
             let appName =
@@ -351,11 +383,7 @@ import React
             callKitProvider?.setDelegate(self, queue: nil)
             callKitController = CXCallController()
 
-            NSLog(
-                "📞 TelnyxVoice: CallKit provider instance: \(String(describing: callKitProvider))")
-            NSLog(
-                "📞 TelnyxVoice: CallKit controller instance: \(String(describing: callKitController))"
-            )
+            NSLog("TelnyxVoice: CallKit provider and controller created")
         }
 
      
@@ -519,9 +547,9 @@ import React
                     callData: activeCalls[action.callUUID])
             }
 
-            NSLog("📞 TelnyxVoice: Fulfilling CXAnswerCallAction for call UUID: \(action.callUUID)")
-            action.fulfill()
-            NSLog("📞 TelnyxVoice: ✅ CXAnswerCallAction fulfilled successfully")
+            // Defer action.fulfill() until reportCallConnected when peer connection is ready
+            NSLog("TelnyxVoice: Deferring CXAnswerCallAction.fulfill() until peer connection is ready")
+            self.pendingAnswerAction = action
         }
 
         public func provider(_ provider: CXProvider, perform action: CXEndCallAction) {
@@ -552,58 +580,67 @@ import React
         }
 
         public func provider(_ provider: CXProvider, didActivate audioSession: AVAudioSession) {
-            NSLog(
-                "🎧🎧🎧 TelnyxVoice: AUDIO SESSION ACTIVATED BY CALLKIT - USER ANSWERED THE CALL! 🎧🎧🎧")
-            NSLog("🎧 Provider: \(provider)")
+            NSLog("TelnyxVoice: Audio session activated by CallKit")
 
+            let rtcAudioSession = RTCAudioSession.sharedInstance()
 
-            // CRITICAL: Activate WebRTC audio session 
-            RTCAudioSession.sharedInstance().audioSessionDidActivate(audioSession)
-            RTCAudioSession.sharedInstance().isAudioEnabled = true
-            NSLog("🎧 TelnyxVoice: WebRTC RTCAudioSession activated and audio enabled")
-
+            // Step 1: Configure (matches native iOS SDK setupCorrectAudioConfiguration)
+            rtcAudioSession.lockForConfiguration()
+            let webRTCConfig = RTCAudioSessionConfiguration.webRTC()
+            webRTCConfig.categoryOptions = [.duckOthers, .allowBluetooth]
             do {
-                // Configure audio session for VoIP with proper routing
-                try audioSession.setCategory(
-                    .playAndRecord, mode: .voiceChat,
-                    options: [.allowBluetooth, .allowBluetoothA2DP])
-                try audioSession.setActive(true)
-
-                // Emit audio session activated event to React Native
-                CallKitBridge.shared?.emitAudioSessionEvent(
-                    "AudioSessionActivated",
-                    data: [
-                        "category": audioSession.category.rawValue,
-                        "mode": audioSession.mode.rawValue,
-                        "isActive": true,
-                    ])
-
-                NSLog(
-                    "🎧 SUCCESS: Audio session ACTIVE for VoIP - Category: \(audioSession.category.rawValue), Mode: \(audioSession.mode.rawValue)"
-                )
+                try rtcAudioSession.setConfiguration(webRTCConfig)
             } catch {
-                NSLog("❌ FAILED: Audio session configuration error: \(error)")
+                NSLog("TelnyxVoice: didActivateAudioSession - setConfiguration error: \(error)")
+            }
+            rtcAudioSession.unlockForConfiguration()
 
-                // Emit audio session failed event to React Native
-                CallKitBridge.shared?.emitAudioSessionEvent(
-                    "AudioSessionFailed",
-                    data: [
-                        "error": error.localizedDescription
-                    ])
+            // Step 2: Activate (matches native iOS SDK setAudioSessionActive)
+            rtcAudioSession.lockForConfiguration()
+            do {
+                try rtcAudioSession.setActive(true)
+            } catch {
+                NSLog("TelnyxVoice: didActivateAudioSession - setActive error: \(error)")
             }
+            rtcAudioSession.isAudioEnabled = true
+            rtcAudioSession.unlockForConfiguration()
+
+            rtcAudioSession.audioSessionDidActivate(audioSession)
+
+            // Emit audio session activated event to React Native
+            CallKitBridge.shared?.emitAudioSessionEvent(
+                "AudioSessionActivated",
+                data: [
+                    "category": audioSession.category.rawValue,
+                    "mode": audioSession.mode.rawValue,
+                    "isActive": true,
+                ])
         }
 
         public func provider(_ provider: CXProvider, didDeactivate audioSession: AVAudioSession) {
-            NSLog("🔇🔇🔇 TelnyxVoice: AUDIO SESSION DEACTIVATED BY CALLKIT 🔇🔇🔇")
-            NSLog("🔇 Provider: \(provider)")
-            NSLog(
-                "🔇 Audio session details: active=\(audioSession.isOtherAudioPlaying), category=\(audioSession.category.rawValue), mode=\(audioSession.mode.rawValue)"
-            )
+            NSLog("TelnyxVoice: Audio session deactivated by CallKit")
 
-            // CRITICAL: Deactivate WebRTC audio session (matches Flutter implementation)
-            RTCAudioSession.sharedInstance().audioSessionDidDeactivate(audioSession)
-            RTCAudioSession.sharedInstance().isAudioEnabled = false
-            NSLog("🔇 TelnyxVoice: WebRTC RTCAudioSession deactivated and audio disabled")
+            let rtcAudioSession = RTCAudioSession.sharedInstance()
+
+            // Reset audio config (matches native iOS SDK resetAudioConfiguration)
+            let avAudioSession = AVAudioSession.sharedInstance()
+            do {
+                try avAudioSession.setCategory(.playback, mode: .default, options: [.mixWithOthers])
+            } catch {
+                NSLog("TelnyxVoice: didDeactivateAudioSession - setCategory error: \(error)")
+            }
+
+            // Deactivate (matches native iOS SDK setAudioSessionActive(false))
+            rtcAudioSession.lockForConfiguration()
+            do {
+                try rtcAudioSession.setActive(false)
+            } catch {
+                NSLog("TelnyxVoice: didDeactivateAudioSession - setActive(false) error: \(error)")
+            }
+            rtcAudioSession.isAudioEnabled = false
+            rtcAudioSession.unlockForConfiguration()
+
+            rtcAudioSession.audioSessionDidDeactivate(audioSession)
 
             // Emit audio session deactivated event to React Native
             CallKitBridge.shared?.emitAudioSessionEvent(

package/lib/callkit/callkit-coordinator.js

@@ -228,21 +228,26 @@ class CallKitCoordinator {
       'CallKitCoordinator: Ending call from UI - dismissing CallKit and hanging up WebRTC call',
       callKitUUID
     );
-    // Mark as processing to prevent duplicate actions
-    this.processingCalls.add(callKitUUID);
+    // Track this call as ended to prevent duplicate end actions
+    this.endedCalls.add(callKitUUID);
     try {
-      // End the call in CallKit and hang up the WebRTC call
-      await callkit_1.default.endCall(callKitUUID);
+      // End the call in CallKit - endCall returns false on failure (doesn't throw)
+      const endCallSuccess = await callkit_1.default.endCall(callKitUUID);
+      if (!endCallSuccess) {
+        // Fallback: use reportCallEnded to dismiss CallKit UI when endCall fails
+        // (e.g., unknownCallUUID error from duplicate CXProvider)
+        await callkit_1.default.reportCallEnded(callKitUUID, callkit_1.CallEndReason.RemoteEnded);
+      }
+      this.isCallFromPush = false;
       call.hangup();
-      // Clean up the mappings
       this.cleanupCall(callKitUUID);
       return true;
     } catch (error) {
       console.error('CallKitCoordinator: Error ending call from UI', error);
-      call.hangup(); // Ensure WebRTC call is ended
+      this.isCallFromPush = false;
+      call.hangup();
+      this.cleanupCall(callKitUUID);
       return false;
-    } finally {
-      this.processingCalls.delete(callKitUUID);
     }
   }
   /**
@@ -472,18 +477,22 @@ class CallKitCoordinator {
         // Set auto-answer flag so when the WebRTC call comes in, it will be answered automatically
         this.shouldAutoAnswerNextCall = true;
         console.log('CallKitCoordinator: ✅ Set auto-answer flag for next incoming call');
-        // Get VoIP client and trigger reconnection
+        // Try to get VoIP client - it may not be wired yet if user answered
+        // from CallKit before React Native finished initializing
         const voipClient = this.getSDKClient();
         if (!voipClient) {
-          console.error(
-            'CallKitCoordinator: ❌ No VoIP client available - cannot reconnect for push notification'
-          );
-          await callkit_1.default.reportCallEnded(callKitUUID, callkit_1.CallEndReason.Failed);
-          this.cleanupCall(callKitUUID);
+          // voipClient not ready yet - DON'T fail the call.
+          // shouldAutoAnswerNextCall is already set to true above.
+          // checkForInitialPushNotification() will run after setVoipClient()
+          // and will find the push data still intact, call handleCallKitPushReceived()
+          // which checks shouldAutoAnswerNextCall and queues the auto-answer.
           return;
         }
+        // voipClient is available - queue the answer action on the TelnyxRTC client
+        // so when the INVITE arrives after WebSocket login, processInvite() sees
+        // pendingAnswerAction=true and auto-answers the call.
+        voipClient.queueAnswerFromCallKit();
         // Get the real push data that was stored by the VoIP push handler
-        console.log('CallKitCoordinator: 🔍 Getting real push data from VoicePnBridge...');
         let realPushData = null;
         try {
           const pendingPushJson = await voice_pn_bridge_1.VoicePnBridge.getPendingVoipPush();
@@ -587,16 +596,11 @@ class CallKitCoordinator {
           if (!this.connectedCalls.has(callKitUUID)) {
             console.log('CallKitCoordinator: WebRTC call active - reporting connected to CallKit');
             try {
-              // Report as connected (CallKit call already answered in UI flow)
               await callkit_1.default.reportCallConnected(callKitUUID);
-              console.log(
-                'CallKitCoordinator: Call reported as connected to CallKit ',
-                callKitUUID
-              );
-              this.connectedCalls.add(callKitUUID);
             } catch (error) {
               console.error('CallKitCoordinator: Error reporting call connected:', error);
             }
+            this.connectedCalls.add(callKitUUID);
           }
           break;
         case 'ended':

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@telnyx/react-voice-commons-sdk",
-  "version": "0.1.8-beta.0",
+  "version": "0.1.8-beta.1",
   "description": "A high-level, state-agnostic, drop-in module for the Telnyx React Native SDK that simplifies WebRTC voice calling integration",
   "main": "lib/index.js",
   "module": "lib/index.js",

package/src/callkit/callkit-coordinator.ts

@@ -218,24 +218,30 @@ class CallKitCoordinator {
       callKitUUID
     );
 
-    // Mark as processing to prevent duplicate actions
-    this.processingCalls.add(callKitUUID);
+    // Track this call as ended to prevent duplicate end actions
+    this.endedCalls.add(callKitUUID);
 
     try {
-      // End the call in CallKit and hang up the WebRTC call
-      await CallKit.endCall(callKitUUID);
-      call.hangup();
+      // End the call in CallKit - endCall returns false on failure (doesn't throw)
+      const endCallSuccess = await CallKit.endCall(callKitUUID);
+
+      if (!endCallSuccess) {
+        // Fallback: use reportCallEnded to dismiss CallKit UI when endCall fails
+        // (e.g., unknownCallUUID error from duplicate CXProvider)
+        await CallKit.reportCallEnded(callKitUUID, CallEndReason.RemoteEnded);
+      }
 
-      // Clean up the mappings
+      this.isCallFromPush = false;
+      call.hangup();
       this.cleanupCall(callKitUUID);
 
       return true;
     } catch (error) {
       console.error('CallKitCoordinator: Error ending call from UI', error);
-      call.hangup(); // Ensure WebRTC call is ended
+      this.isCallFromPush = false;
+      call.hangup();
+      this.cleanupCall(callKitUUID);
       return false;
-    } finally {
-      this.processingCalls.delete(callKitUUID);
     }
   }
 
@@ -506,19 +512,24 @@ class CallKitCoordinator {
         this.shouldAutoAnswerNextCall = true;
         console.log('CallKitCoordinator: ✅ Set auto-answer flag for next incoming call');
 
-        // Get VoIP client and trigger reconnection
+        // Try to get VoIP client - it may not be wired yet if user answered
+        // from CallKit before React Native finished initializing
         const voipClient = this.getSDKClient();
         if (!voipClient) {
-          console.error(
-            'CallKitCoordinator: ❌ No VoIP client available - cannot reconnect for push notification'
-          );
-          await CallKit.reportCallEnded(callKitUUID, CallEndReason.Failed);
-          this.cleanupCall(callKitUUID);
+          // voipClient not ready yet - DON'T fail the call.
+          // shouldAutoAnswerNextCall is already set to true above.
+          // checkForInitialPushNotification() will run after setVoipClient()
+          // and will find the push data still intact, call handleCallKitPushReceived()
+          // which checks shouldAutoAnswerNextCall and queues the auto-answer.
           return;
         }
 
+        // voipClient is available - queue the answer action on the TelnyxRTC client
+        // so when the INVITE arrives after WebSocket login, processInvite() sees
+        // pendingAnswerAction=true and auto-answers the call.
+        voipClient.queueAnswerFromCallKit();
+
         // Get the real push data that was stored by the VoIP push handler
-        console.log('CallKitCoordinator: 🔍 Getting real push data from VoicePnBridge...');
         let realPushData = null;
         try {
           const pendingPushJson = await VoicePnBridge.getPendingVoipPush();
@@ -638,17 +649,11 @@ class CallKitCoordinator {
             console.log('CallKitCoordinator: WebRTC call active - reporting connected to CallKit');
 
             try {
-              // Report as connected (CallKit call already answered in UI flow)
               await CallKit.reportCallConnected(callKitUUID);
-              console.log(
-                'CallKitCoordinator: Call reported as connected to CallKit ',
-                callKitUUID
-              );
-
-              this.connectedCalls.add(callKitUUID);
             } catch (error) {
               console.error('CallKitCoordinator: Error reporting call connected:', error);
             }
+            this.connectedCalls.add(callKitUUID);
           }
           break;