@telnyx/react-voice-commons-sdk 0.1.6 → 0.1.7-beta.0

package/README.md

@@ -51,7 +51,7 @@ export default function App() {
 
 ### Core Components
 
-#### 1. VoIP Client Configuration
+### 1. VoIP Client Configuration
 
 ```tsx
 const voipClient = createTelnyxVoipClient({
@@ -65,7 +65,7 @@ const voipClient = createTelnyxVoipClient({
 - **`enableAppStateManagement: true`** - **Optional (default: true)**: Enables automatic background/foreground app state management. When enabled, the library automatically disconnects when the app goes to background (unless there's an active call) and handles reconnection logic. Set to `false` if you want to handle app lifecycle manually.
 - **`debug: true`** - **Optional**: Enables detailed logging for connection states, call transitions, and push notification processing. Useful for development and troubleshooting.
 
-#### 2. TelnyxVoiceApp Wrapper
+### 2. TelnyxVoiceApp Wrapper
 
 The `TelnyxVoiceApp` component handles:
 
@@ -74,7 +74,7 @@ The `TelnyxVoiceApp` component handles:
 - Login state management with automatic reconnection
 - Background client management for push notifications
 
-#### 3. Reactive State Management
+### 3. Reactive State Management
 
 ```tsx
 // Listen to connection state
@@ -93,7 +93,7 @@ call.callState$.subscribe((state) => {
 });
 ```
 
-#### 4. Call Management
+### 4. Call Management
 
 ```tsx
 // Make a call
@@ -112,9 +112,9 @@ await call.hangup();
 
 The library supports both credential-based and token-based authentication with automatic persistence for seamless reconnection.
 
-#### Authentication Methods
+### Authentication Methods
 
-##### 1. Credential-Based Authentication
+### 1. Credential-Based Authentication
 
 ```tsx
 import { createCredentialConfig } from '@telnyx/react-voice-commons-sdk';
@@ -127,7 +127,7 @@ const config = createCredentialConfig('your_sip_username', 'your_sip_password',
 await voipClient.login(config);
 ```
 
-##### 2. Token-Based Authentication
+### 2. Token-Based Authentication
 
 ```tsx
 import { createTokenConfig } from '@telnyx/react-voice-commons-sdk';
@@ -140,11 +140,11 @@ const config = createTokenConfig('your_jwt_token', {
 await voipClient.loginWithToken(config);
 ```
 
-#### Automatic Storage & Reconnection
+### Automatic Storage & Reconnection
 
 The library automatically stores authentication data securely for seamless reconnection. **You don't need to manually manage these storage keys** - the library handles everything internally.
 
-##### Internal Storage (Managed Automatically)
+### Internal Storage (Managed Automatically)
 
 The library uses these AsyncStorage keys internally:
 
@@ -155,7 +155,7 @@ The library uses these AsyncStorage keys internally:
 
 **Note**: These are managed automatically by the library. You only need to call `login()` once, and the library will handle storage and future reconnections.
 
-##### Auto-Reconnection
+### Auto-Reconnection
 
 ```tsx
 // Automatically reconnects using internally stored credentials or token
@@ -176,7 +176,7 @@ if (!success) {
 
 **Demo App Note**: When using the library in a demo application, the `TelnyxLoginForm` component may do additional storage for UI convenience (pre-filling login forms). This is separate from the library's internal authentication storage and is not required for production apps.
 
-##### Manual Storage Management (Advanced Use Only)
+### Manual Storage Management (Advanced Use Only)
 
 If you need to clear stored authentication data manually:
 
@@ -198,9 +198,9 @@ await AsyncStorage.multiRemove([
 
 The library provides complete native integration for both platforms. These integrations are required for production apps using the library.
 
-#### Android Integration
+### Android Integration
 
-##### 1. MainActivity Setup
+### 1. MainActivity Setup
 
 Your app's MainActivity should extend `TelnyxMainActivity` for automatic push notification handling:
 
@@ -225,7 +225,7 @@ The `TelnyxMainActivity` provides:
 - Proper lifecycle management for VoIP functionality
 - Integration with `VoicePnManager` for push notification state
 
-##### 2. Push Notification Setup
+### 2. Push Notification Setup
 
 1. Place `google-services.json` in the project root
 2. Register background message handler:
@@ -239,9 +239,9 @@ messaging().setBackgroundMessageHandler(async (remoteMessage) => {
 });
 ```
 
-#### iOS Integration
+### iOS Integration
 
-##### 1. AppDelegate Setup
+### 1. AppDelegate Setup
 
 Your AppDelegate only needs to implement `PKPushRegistryDelegate` for VoIP push notifications. CallKit integration is automatically handled by CallBridge:
 
@@ -277,13 +277,13 @@ public class AppDelegate: ExpoAppDelegate, PKPushRegistryDelegate {
 
 **Note**: CallKit integration (CXProvider, CXProviderDelegate, audio session management) is automatically handled by the internal CallBridge component. You don't need to implement any CallKit delegate methods manually.
 
-##### 2. VoIP Push Certificate Setup
+### 2. VoIP Push Certificate Setup
 
 - Configure VoIP push certificates in your Apple Developer account
 - The `TelnyxVoipPushHandler` automatically handles token registration and push processing
 - CallKit integration is automatically managed by CallBridge - no manual setup required
 
-#### Key Native Features Integrated
+### Key Native Features Integrated
 
 1. **Push Notification Handling**: Both platforms handle background push notifications properly
 2. **Native Call UI**: CallKit (iOS, managed by CallBridge) and ConnectionService (Android) integration
@@ -416,15 +416,15 @@ npx expo run:ios
 
 ### Common Integration Issues
 
-#### Double Login
+### Double Login
 
 Ensure you're not calling login methods manually when using `TelnyxVoiceApp` with auto-reconnection enabled.
 
-#### Background Disconnection
+### Background Disconnection
 
 Check if `enableAutoReconnect` is set appropriately for your use case in the `TelnyxVoiceApp` configuration.
 
-#### Push Notifications Not Working
+### Push Notifications Not Working
 
 - **Android**:
   - Verify `google-services.json` is in the correct location and Firebase is properly configured
@@ -436,19 +436,19 @@ Check if `enableAutoReconnect` is set appropriately for your use case in the `Te
   - Check that `TelnyxVoipPushHandler.initializeVoipRegistration()` is called in `didFinishLaunchingWithOptions`
 - **Both**: Check that background message handlers are properly registered
 
-#### Native Integration Issues
+### Native Integration Issues
 
 - **Android**: Ensure MainActivity extends `TelnyxMainActivity` for proper intent handling
 - **iOS**: Verify AppDelegate implements `PKPushRegistryDelegate` and delegates to `TelnyxVoipPushHandler`
 - **CallKit**: On iOS, CallKit integration is automatically handled by CallBridge - no manual setup required
 
-#### Audio Issues
+### Audio Issues
 
 - **iOS**: Audio session management is automatically handled by CallBridge
 - **Android**: Verify ConnectionService is properly configured for audio routing
 - **Both**: Ensure proper audio permissions are granted
 
-#### Memory Leaks
+### Memory Leaks
 
 Ensure you're unsubscribing from RxJS observables in your React components:
 

package/ios/CallKitBridge.m

@@ -28,7 +28,7 @@ RCT_EXTERN_METHOD(reportCallConnected:(NSString *)callUUID
                   rejecter:(RCTPromiseRejectBlock)reject)
 
 RCT_EXTERN_METHOD(reportCallEnded:(NSString *)callUUID 
-                  reason:(NSNumber *)reason
+                  reason:(nonnull NSNumber *)reason
                   resolver:(RCTPromiseResolveBlock)resolve 
                   rejecter:(RCTPromiseRejectBlock)reject)
 

package/ios/CallKitBridge.swift

@@ -358,15 +358,7 @@ import React
             )
         }
 
-        func configureAudioSession() {
-            let audioSession = AVAudioSession.sharedInstance()
-            do {
-                try audioSession.setCategory(.playAndRecord, mode: .voiceChat)
-                NSLog("Succeeded to activate audio session")
-            } catch {
-                NSLog("Failed to activate audio session: \(error)")
-            }
-        }
+     
 
         private func observeAppDelegate() {
             // Automatically hook into app lifecycle if needed
@@ -760,8 +752,6 @@ import React
 
             NSLog("[TelnyxVoipPushHandler] ✅ CallKit provider ready, reporting incoming call")
 
-            // Configure audio session before reporting the call
-            //callKitManager.configureAudioSession()
 
             // Store call data manually and report to CallKit
             let isAppRunning = CallKitBridge.shared != nil

package/ios/README.md

@@ -32,7 +32,7 @@ Add the following to your iOS app's `Info.plist`:
 
 ### 2. AppDelegate Integration
 
-#### Option A: Easy Integration (Recommended)
+### Option A: Easy Integration (Recommended)
 
 Import and use the `TelnyxVoiceAppDelegate` protocol:
 
@@ -77,7 +77,7 @@ extension AppDelegate: PKPushRegistryDelegate {}
 extension AppDelegate: CXProviderDelegate {}
 ```
 
-#### Option B: Manual Integration
+### Option B: Manual Integration
 
 If you prefer to implement the delegates manually:
 

package/lib/callkit/callkit-coordinator.js

@@ -320,6 +320,12 @@ class CallKitCoordinator {
       console.log('CallKitCoordinator: End action already being processed, skipping duplicate');
       return;
     }
+    if (this.endedCalls.has(callKitUUID)) {
+      console.log('CallKitCoordinator: Call already ended, skipping duplicate end action');
+      return;
+    }
+    // Mark as ended immediately to prevent any duplicate processing
+    this.endedCalls.add(callKitUUID);
     const call = this.callMap.get(callKitUUID);
     if (!call) {
       console.warn('CallKitCoordinator: No WebRTC call found for CallKit end action', {
@@ -598,9 +604,7 @@ class CallKitCoordinator {
    * Clean up call mappings and listeners
    */
   cleanupCall(callKitUUID) {
-    // Remove from all tracking sets
     this.processingCalls.delete(callKitUUID);
-    this.endedCalls.delete(callKitUUID);
     this.connectedCalls.delete(callKitUUID);
     // Get the call before removing it
     const call = this.callMap.get(callKitUUID);

package/lib/internal/calls/call-state-controller.d.ts

@@ -31,6 +31,15 @@ export declare class CallStateController {
    * Current active call (synchronous access)
    */
   get currentActiveCall(): Call | null;
+  /**
+   * Access any active call tracked by the client.
+   * A call will be accessible until it has ended (transitioned to the ENDED state).
+   * This matches the TelnyxRTC `getCall(callId)` method for multi-call support.
+   *
+   * @param callId The unique identifier of a call.
+   * @returns The Call object that matches the requested callId, or null if not found.
+   */
+  getCall(callId: string): Call | null;
   /**
    * Set a call to connecting state (used for push notification calls when answered via CallKit)
    * @param callId The ID of the call to set to connecting state

package/lib/internal/calls/call-state-controller.js

@@ -18,7 +18,7 @@ class CallStateController {
     this._calls = new rxjs_1.BehaviorSubject([]);
     this._callMap = new Map();
     this._disposed = false;
-    console.log('🔧 CallStateController: Constructor called - instance created');
+    console.log('CallStateController: Constructor called - instance created');
     // Don't set up client listeners here - client doesn't exist yet
     // Will be called when client is available
   }
@@ -69,6 +69,17 @@ class CallStateController {
       ) || null
     );
   }
+  /**
+   * Access any active call tracked by the client.
+   * A call will be accessible until it has ended (transitioned to the ENDED state).
+   * This matches the TelnyxRTC `getCall(callId)` method for multi-call support.
+   *
+   * @param callId The unique identifier of a call.
+   * @returns The Call object that matches the requested callId, or null if not found.
+   */
+  getCall(callId) {
+    return this._callMap.get(callId) || null;
+  }
   /**
    * Set a call to connecting state (used for push notification calls when answered via CallKit)
    * @param callId The ID of the call to set to connecting state
@@ -99,14 +110,11 @@ class CallStateController {
    * This should be called by the session manager after client creation
    */
   initializeClientListeners() {
-    console.log('🔧 CallStateController: initializeClientListeners called');
-    console.log(
-      '🔧 CallStateController: Current client exists:',
-      !!this._sessionManager.telnyxClient
-    );
+    console.log('CallStateController: initializeClientListeners called');
+    console.log('CallStateController: Current client exists:', !!this._sessionManager.telnyxClient);
     this._setupClientListeners();
     // CallKit integration now handled by CallKitCoordinator
-    console.log('🔧 CallStateController: Using CallKitCoordinator for CallKit integration');
+    console.log('CallStateController: Using CallKitCoordinator for CallKit integration');
   }
   /**
    * Initiate a new outgoing call
@@ -170,24 +178,24 @@ class CallStateController {
    * Set up event listeners for the Telnyx client
    */
   _setupClientListeners() {
-    console.log('🔧 CallStateController: Setting up client listeners...');
+    console.log('CallStateController: Setting up client listeners...');
     if (!this._sessionManager.telnyxClient) {
-      console.log('🔧 CallStateController: No telnyxClient available yet, skipping listener setup');
+      console.log('CallStateController: No telnyxClient available yet, skipping listener setup');
       return;
     }
-    console.log('🔧 CallStateController: TelnyxClient found, setting up incoming call listener');
+    console.log('CallStateController: TelnyxClient found, setting up incoming call listener');
     console.log(
-      '🔧 CallStateController: Client instance:',
+      'CallStateController: Client instance:',
       this._sessionManager.telnyxClient.constructor.name
     );
     // Listen for incoming calls
     this._sessionManager.telnyxClient.on('telnyx.call.incoming', (telnyxCall, msg) => {
-      console.log('📞 CallStateController: Incoming call received:', telnyxCall.callId);
+      console.log('CallStateController: Incoming call received:', telnyxCall.callId);
       this._handleIncomingCall(telnyxCall, msg, false);
     });
     // Listen for reattached calls (after network reconnection)
     this._sessionManager.telnyxClient.on('telnyx.call.reattached', (telnyxCall, msg) => {
-      console.log('📞 CallStateController: Reattached call received:', telnyxCall.callId);
+      console.log('CallStateController: Reattached call received:', telnyxCall.callId);
       this._handleIncomingCall(telnyxCall, msg, true);
     });
     // Verify listeners are set up
@@ -196,14 +204,33 @@ class CallStateController {
     const reattachedListeners =
       this._sessionManager.telnyxClient.listenerCount('telnyx.call.reattached');
     console.log(
-      '🔧 CallStateController: Listeners registered - incoming:',
+      'CallStateController: Listeners registered - incoming:',
       incomingListeners,
       'reattached:',
       reattachedListeners
     );
-    // Listen for other call events if needed
-    // this._sessionManager.telnyxClient.on('telnyx.call.stateChange', this._handleCallStateChange.bind(this));
-    console.log('🔧 CallStateController: Client listeners set up successfully');
+    // Listen for call state changes from the TelnyxRTC client (multi-call support)
+    this._sessionManager.telnyxClient.on('telnyx.call.stateChanged', (telnyxCall, state) => {
+      console.log(
+        'CallStateController: Call state changed from TelnyxRTC:',
+        telnyxCall.callId,
+        state
+      );
+      // Find our wrapper call and update if needed
+      const call = this.findCallByTelnyxCall(telnyxCall);
+      if (call) {
+        console.log(
+          'CallStateController: Found wrapper call, state sync handled by Call subscription'
+        );
+      }
+    });
+    // Listen for call removal events from TelnyxRTC (multi-call support)
+    this._sessionManager.telnyxClient.on('telnyx.call.removed', (callId) => {
+      console.log('CallStateController: Call removed from TelnyxRTC:', callId);
+      // The call cleanup is already handled by our call state subscription
+      // This event is informational for logging/debugging
+    });
+    console.log('CallStateController: Client listeners set up successfully');
   }
   /**
    * Handle incoming call or reattached call
@@ -211,20 +238,20 @@ class CallStateController {
   _handleIncomingCall(telnyxCall, inviteMsg, isReattached = false) {
     const callId = telnyxCall.callId || this._generateCallId();
     console.log(
-      '📞 CallStateController: Handling incoming call:',
+      'CallStateController: Handling incoming call:',
       callId,
       'isReattached:',
       isReattached
     );
-    console.log('📞 CallStateController: TelnyxCall object:', telnyxCall);
-    console.log('📞 CallStateController: Invite message:', inviteMsg);
+    console.log('CallStateController: TelnyxCall object:', telnyxCall);
+    console.log('CallStateController: Invite message:', inviteMsg);
     // For reattached calls, remove existing call and create new one
     if (isReattached && this._callMap.has(callId)) {
-      console.log('📞 CallStateController: Removing existing call for reattachment');
+      console.log('CallStateController: Removing existing call for reattachment');
       const existingCall = this._callMap.get(callId);
       if (existingCall) {
         console.log(
-          '📞 CallStateController: Existing call state before removal:',
+          'CallStateController: Existing call state before removal:',
           existingCall.currentState
         );
         this._removeCall(callId);
@@ -242,7 +269,7 @@ class CallStateController {
       callerNumber = inviteMsg.params.caller_id_number || '';
       callerName = inviteMsg.params.caller_id_name || '';
       console.log(
-        '📞 CallStateController: Extracted caller info from invite - Number:',
+        'CallStateController: Extracted caller info from invite - Number:',
         callerNumber,
         'Name:',
         callerName
@@ -252,7 +279,7 @@ class CallStateController {
       callerNumber = telnyxCall.remoteCallerIdNumber || '';
       callerName = telnyxCall.remoteCallerIdName || '';
       console.log(
-        '📞 CallStateController: Extracted caller info from TelnyxCall - Number:',
+        'CallStateController: Extracted caller info from TelnyxCall - Number:',
         callerNumber,
         'Name:',
         callerName