@tellescope/sdk 1.256.4 → 1.256.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tellescope/sdk",
-  "version": "1.256.4",
+  "version": "1.256.6",
   "description": "Code for interacting with the Tellescope API",
   "main": "./lib/cjs/sdk.js",
   "module": "./lib/esm/sdk.js",
@@ -32,14 +32,14 @@
   },
   "homepage": "https://github.com/tellescope-os/tellescope#readme",
   "dependencies": {
-    "@tellescope/constants": "1.256.4",
-    "@tellescope/schema": "1.256.4",
-    "@tellescope/testing": "1.256.4",
-    "@tellescope/types-client": "1.256.4",
-    "@tellescope/types-models": "1.256.4",
-    "@tellescope/types-utilities": "1.256.4",
-    "@tellescope/utilities": "1.256.4",
-    "@tellescope/validation": "1.256.4",
+    "@tellescope/constants": "1.256.6",
+    "@tellescope/schema": "1.256.6",
+    "@tellescope/testing": "1.256.6",
+    "@tellescope/types-client": "1.256.6",
+    "@tellescope/types-models": "1.256.6",
+    "@tellescope/types-utilities": "1.256.6",
+    "@tellescope/utilities": "1.256.6",
+    "@tellescope/validation": "1.256.6",
     "axios": "0.30.3",
     "dotenv": "14.3.2",
     "form-data": "4.0.4",
@@ -55,5 +55,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "f8b3327e5602d5dae690109eb9271aa1c2628c37"
+  "gitHead": "b5672761d4ea6995488faaeb9a0ccc12436f7b30"
 }

package/src/tests/api_tests/beluga_trigger_refill.test.ts

@@ -6,6 +6,7 @@ import {
   log_header,
   passOnAnyResult,
 } from "@tellescope/testing"
+import { BELUGA_TITLE } from "@tellescope/constants"
 import { setup_tests } from "../setup"
 
 const host = process.env.API_URL || 'http://localhost:8080' as const
@@ -24,6 +25,13 @@ export const beluga_trigger_refill_tests = async ({ sdk, sdkNonAdmin }: { sdk: S
   let formId: string | undefined
   const stepIds: string[] = []
 
+  // cross-patient guard setup (created only if we reach that section)
+  let enduserAId: string | undefined
+  let enduserBId: string | undefined
+  let otherPatientFormResponseId: string | undefined
+  let automatedActionId: string | undefined
+  let createdBelugaIntegrationId: string | undefined
+
   try {
     const journey = await sdk.api.journeys.createOne({ title: 'Beluga Trigger Refill Test Journey' })
     journeyId = journey.id
@@ -121,7 +129,80 @@ export const beluga_trigger_refill_tests = async ({ sdk, sdkNonAdmin }: { sdk: S
         },
       },
     )
+
+    // ── Cross-patient guard (pre-deploy review H3) ──────────────────────────────
+    // The process endpoint reads journeyContext.formResponseId; without an ownership check a
+    // switchToRelatedContact step could point it at a DIFFERENT patient's form response and issue a
+    // refill against their visit. This exercises the guard end-to-end: it returns BEFORE any live
+    // Beluga call (no sandbox creds needed), but integration resolution precedes it in the handler,
+    // so a Beluga integration must exist — the test self-skips when one can't be created.
+    const enduserA = await sdk.api.endusers.createOne({ fname: 'Beluga', lname: 'PatientA' })
+    enduserAId = enduserA.id
+    const enduserB = await sdk.api.endusers.createOne({ fname: 'Beluga', lname: 'PatientB' })
+    enduserBId = enduserB.id
+
+    // a form response owned by patient A
+    const otherResponse = await sdk.api.form_responses.createOne({
+      formId: form.id,
+      formTitle: form.title,
+      enduserId: enduserA.id,
+    })
+    otherPatientFormResponseId = otherResponse.id
+
+    let belugaIntegrationAvailable = false
+    try {
+      const existing = await sdk.api.integrations.load_redacted({})
+      belugaIntegrationAvailable = !!existing.integrations.find((i: any) => i.title === BELUGA_TITLE)
+    } catch { /* load not permitted — fall through to create attempt */ }
+
+    if (!belugaIntegrationAvailable) {
+      try {
+        const created = await sdk.api.integrations.createOne({
+          title: BELUGA_TITLE,
+          authentication: {
+            type: 'oauth2',
+            info: { access_token: 'test-access-token', refresh_token: 'test-refresh-token', scope: '', token_type: 'Bearer', expiry_date: new Date().getTime() },
+          },
+        } as any)
+        createdBelugaIntegrationId = created.id
+        belugaIntegrationAvailable = true
+      } catch (e) {
+        console.log("Could not create a Beluga integration; skipping cross-patient guard test:", e)
+      }
+    }
+
+    if (belugaIntegrationAvailable) {
+      // an automated action for patient B whose journeyContext points at patient A's response.
+      // processAfter is set in the future so no background worker picks it up before the explicit call.
+      const automatedAction = await sdk.api.automated_actions.createOne({
+        journeyId: journey.id,
+        automationStepId: stepIds[0],
+        enduserId: enduserB.id,
+        event: { type: 'onJourneyStart', info: {} },
+        action: {
+          type: 'belugaTriggerRefill',
+          info: { formId: form.id, patientPreferences: [{ medId: 'med-123' }] },
+        },
+        status: 'active',
+        processAfter: new Date().getTime() + 60 * 60 * 1000,
+        journeyContext: { formResponseId: otherResponse.id },
+      } as any)
+      automatedActionId = automatedAction.id
+
+      await async_test(
+        "belugaTriggerRefill rejects a form response owned by a different patient",
+        () => sdk.api.automated_actions.process({ automatedActionId: automatedAction.id }),
+        { onResult: (r: any) => r?.success === false && /does not belong to this patient/i.test(r?.error || '') },
+      )
+    } else {
+      console.log("⏭️  Skipping belugaTriggerRefill cross-patient guard test (no Beluga integration available)")
+    }
   } finally {
+    if (automatedActionId) await sdk.api.automated_actions.deleteOne(automatedActionId).catch(console.error)
+    if (otherPatientFormResponseId) await sdk.api.form_responses.deleteOne(otherPatientFormResponseId).catch(console.error)
+    if (enduserAId) await sdk.api.endusers.deleteOne(enduserAId).catch(console.error)
+    if (enduserBId) await sdk.api.endusers.deleteOne(enduserBId).catch(console.error)
+    if (createdBelugaIntegrationId) await sdk.api.integrations.deleteOne(createdBelugaIntegrationId).catch(console.error)
     for (const id of stepIds) {
       await sdk.api.automation_steps.deleteOne(id).catch(console.error)
     }