@tellescope/sdk 1.246.1 → 1.247.0

package/src/tests/api_tests/organization_settings_duplicates.test.ts

@@ -0,0 +1,201 @@
+require('source-map-support').install();
+
+import { Session } from "../../sdk"
+import {
+  async_test,
+  log_header,
+} from "@tellescope/testing"
+import { setup_tests } from "../setup"
+
+const host = process.env.API_URL || 'http://localhost:8080' as const
+
+export const organization_settings_duplicates_tests = async ({ sdk, sdkNonAdmin } : { sdk: Session, sdkNonAdmin: Session }) => {
+  log_header("Organization Settings Duplicate Validation Tests")
+
+  const orgId = sdk.userInfo.businessId
+
+  // === A. replaceObjectFields: false (merge/push behavior) ===
+
+  // A1. Duplicate tags via merge
+  await sdk.api.organizations.updateOne(orgId, {
+    settings: { endusers: { tags: ['tag1', 'tag2'] } }
+  }, { replaceObjectFields: true })
+
+  await async_test(
+    "Merge tags rejects duplicates (tag2 appears in both old and new)",
+    () => sdk.api.organizations.updateOne(orgId, {
+      settings: { endusers: { tags: ['tag2', 'tag3'] } }
+    }),
+    { shouldError: true, onError: (e: { message: string }) => e.message.includes('Duplicate value in settings.endusers.tags') }
+  )
+
+  // A2. Duplicate customFields via merge
+  await sdk.api.organizations.updateOne(orgId, {
+    settings: { endusers: { customFields: [{ type: 'Text' as const, field: 'myField', info: {} }] } }
+  }, { replaceObjectFields: true })
+
+  await async_test(
+    "Merge customFields rejects duplicate field name",
+    () => sdk.api.organizations.updateOne(orgId, {
+      settings: { endusers: { customFields: [{ type: 'Text' as const, field: 'myField', info: {} }] } }
+    }),
+    { shouldError: true, onError: (e: { message: string }) => e.message.includes('Duplicate field in settings.endusers.customFields') }
+  )
+
+  // A3. Duplicate builtinFields via merge
+  await sdk.api.organizations.updateOne(orgId, {
+    settings: { endusers: { builtinFields: [{ field: 'fname', label: 'First Name' }] } }
+  }, { replaceObjectFields: true })
+
+  await async_test(
+    "Merge builtinFields rejects duplicate field name",
+    () => sdk.api.organizations.updateOne(orgId, {
+      settings: { endusers: { builtinFields: [{ field: 'fname', label: 'First Name Copy' }] } }
+    }),
+    { shouldError: true, onError: (e: { message: string }) => e.message.includes('Duplicate field in settings.endusers.builtinFields') }
+  )
+
+  // A4. Duplicate dontRecordCallsToPhone via merge
+  await sdk.api.organizations.updateOne(orgId, {
+    settings: { endusers: { dontRecordCallsToPhone: ['+15551234567'] } }
+  }, { replaceObjectFields: true })
+
+  await async_test(
+    "Merge dontRecordCallsToPhone rejects duplicates",
+    () => sdk.api.organizations.updateOne(orgId, {
+      settings: { endusers: { dontRecordCallsToPhone: ['+15551234567'] } }
+    }),
+    { shouldError: true, onError: (e: { message: string }) => e.message.includes('Duplicate value in settings.endusers.dontRecordCallsToPhone') }
+  )
+
+  // A5. Duplicate cancelReasons via merge
+  await sdk.api.organizations.updateOne(orgId, {
+    settings: { calendar: { cancelReasons: ['No show'] } }
+  }, { replaceObjectFields: true })
+
+  await async_test(
+    "Merge cancelReasons rejects duplicates",
+    () => sdk.api.organizations.updateOne(orgId, {
+      settings: { calendar: { cancelReasons: ['No show'] } }
+    }),
+    { shouldError: true, onError: (e: { message: string }) => e.message.includes('Duplicate value in settings.calendar.cancelReasons') }
+  )
+
+  // === B. replaceObjectFields: true (full replacement) ===
+
+  // B1. Replace that grows the array with dupes should be rejected
+  await sdk.api.organizations.updateOne(orgId, {
+    settings: { endusers: { tags: ['tag1'] } }
+  }, { replaceObjectFields: true })
+
+  await async_test(
+    "Replace tags rejects duplicates when array grows",
+    () => sdk.api.organizations.updateOne(orgId, {
+      settings: { endusers: { tags: ['tag1', 'tag1', 'tag2'] } }
+    }, { replaceObjectFields: true }),
+    { shouldError: true, onError: (e: { message: string }) => e.message.includes('Duplicate value in settings.endusers.tags') }
+  )
+
+  // B2. Replace with dupes that shrinks the array should be allowed
+  await sdk.api.organizations.updateOne(orgId, {
+    settings: { endusers: { tags: ['a', 'b', 'c'] } }
+  }, { replaceObjectFields: true })
+
+  await async_test(
+    "Replace with dupes that shrinks array succeeds",
+    () => sdk.api.organizations.updateOne(orgId, {
+      settings: { endusers: { tags: ['a', 'a'] } }
+    }, { replaceObjectFields: true }),
+    { shouldError: false, onResult: () => true }
+  )
+
+  // B3. Replace with unique values always succeeds
+  await async_test(
+    "Replace tags succeeds with unique values",
+    () => sdk.api.organizations.updateOne(orgId, {
+      settings: { endusers: { tags: ['tag1', 'tag2'] } }
+    }, { replaceObjectFields: true }),
+    { shouldError: false, onResult: () => true }
+  )
+
+  // === C. Non-duplicate updates still succeed ===
+
+  // C1. Set initial tags then add different tags via merge
+  await sdk.api.organizations.updateOne(orgId, {
+    settings: { endusers: { tags: ['tagA', 'tagB'] } }
+  }, { replaceObjectFields: true })
+
+  await async_test(
+    "Merge with unique new tags succeeds",
+    () => sdk.api.organizations.updateOne(orgId, {
+      settings: { endusers: { tags: ['tagC', 'tagD'] } }
+    }),
+    { shouldError: false, onResult: () => true }
+  )
+
+  // C2. Replace with unique values
+  await async_test(
+    "Replace customFields with unique values succeeds",
+    () => sdk.api.organizations.updateOne(orgId, {
+      settings: { endusers: { customFields: [
+        { type: 'Text' as const, field: 'field1', info: {} },
+        { type: 'Text' as const, field: 'field2', info: {} },
+      ] } }
+    }, { replaceObjectFields: true }),
+    { shouldError: false, onResult: () => true }
+  )
+
+  // C3. Updating another settings field preserves pre-existing duplicates
+  // First set tags to a longer array, then shrink to a dupe array (shrinking is allowed)
+  await sdk.api.organizations.updateOne(orgId, {
+    settings: { endusers: { tags: ['dupeTag', 'otherTag', 'anotherTag'] } }
+  }, { replaceObjectFields: true })
+  await sdk.api.organizations.updateOne(orgId, {
+    settings: { endusers: { tags: ['dupeTag', 'dupeTag'] } }
+  }, { replaceObjectFields: true })
+
+  await async_test(
+    "Updating cancelReasons succeeds even when tags has pre-existing duplicates",
+    () => sdk.api.organizations.updateOne(orgId, {
+      settings: { calendar: { cancelReasons: ['new reason'] } }
+    }, { replaceObjectFields: true }),
+    { shouldError: false, onResult: () => true }
+  )
+
+  // Clean up settings to avoid affecting other tests
+  await sdk.api.organizations.updateOne(orgId, {
+    settings: {
+      endusers: {
+        tags: [],
+        customFields: [],
+        builtinFields: [],
+        dontRecordCallsToPhone: [],
+      },
+      calendar: {
+        cancelReasons: [],
+      },
+    }
+  }, { replaceObjectFields: true })
+}
+
+// Allow running this test file independently
+if (require.main === module) {
+  console.log(`Using API URL: ${host}`)
+  const sdk = new Session({ host })
+  const sdkNonAdmin = new Session({ host })
+
+  const runTests = async () => {
+    await setup_tests(sdk, sdkNonAdmin)
+    await organization_settings_duplicates_tests({ sdk, sdkNonAdmin })
+  }
+
+  runTests()
+    .then(() => {
+      console.log("✅ Organization settings duplicate validation tests completed successfully")
+      process.exit(0)
+    })
+    .catch((error) => {
+      console.error("❌ Organization settings duplicate validation tests failed:", error)
+      process.exit(1)
+    })
+}

package/src/tests/tests.ts

@@ -37,6 +37,7 @@ import {
 import { Session, APIQuery, EnduserSession } from "../sdk"
 import { enduser_observations_acknowledge_tests } from "./api_tests/enduser_observations_acknowledge.test"
 import { get_some_projection_tests } from "./api_tests/get_some_projection.test"
+import { mdb_sort_tests } from "./api_tests/mdb_sort.test"
 import { create_user_notifications_trigger_tests } from "./api_tests/create_user_notifications_trigger.test"
 import { inbox_thread_assignment_updates_tests } from "./api_tests/inbox_thread_assignment_updates.test"
 import { inbox_thread_draft_scheduled_tests } from "./api_tests/inbox_thread_draft_scheduled.test"
@@ -88,6 +89,8 @@ import { load_team_chat_tests } from "./api_tests/load_team_chat.test";
 import { form_started_trigger_tests } from "./api_tests/form_started_trigger.test";
 import { medication_added_trigger_tests } from "./api_tests/medication_added_trigger.test";
 import { elation_user_id_tests } from "./api_tests/elation_user_id.test";
+import { organization_settings_duplicates_tests } from "./api_tests/organization_settings_duplicates.test";
+import { calendar_events_bulk_update_tests } from "./api_tests/calendar_events_bulk_update.test";
 import { openloop_webhooks_tests } from "./api_tests/openloop_webhooks.test";
 import { beluga_pharmacy_mappings_tests } from "./api_tests/beluga_pharmacy_mappings.test";
 
@@ -5212,7 +5215,29 @@ const search_tests = async () => {
     `Search by email`,
     () => sdk.api.endusers.getSome({ search: { query: 'search@tellescope'} }),
     { onResult: es => es.length === 2 },
-  )  
+  )
+
+  // minSearchScore parameter tests
+  await async_test(
+    `Search with minSearchScore accepted`,
+    () => sdk.api.endusers.getSome({ search: { query: 'john', minSearchScore: 0.5 } }),
+    { onResult: es => es.length === 1 && es[0].id === e1.id },
+  )
+  await async_test(
+    `Search with minSearchScore 0 accepted`,
+    () => sdk.api.endusers.getSome({ search: { query: 'john', minSearchScore: 0 } }),
+    { onResult: es => es.length === 1 && es[0].id === e1.id },
+  )
+  await async_test(
+    `Search with negative minSearchScore rejected`,
+    () => sdk.api.endusers.getSome({ search: { query: 'john', minSearchScore: -1 } }),
+    handleAnyError,
+  )
+  await async_test(
+    `Search with string minSearchScore rejected`,
+    () => sdk.api.endusers.getSome({ search: { query: 'john', minSearchScore: 'high' as any } }),
+    handleAnyError,
+  )
 
   await Promise.all([
     sdk.api.endusers.deleteOne(e1.id),
@@ -14101,6 +14126,9 @@ const ip_address_form_tests = async () => {
     await replace_enduser_template_values_tests()
     await mfa_tests()
     await setup_tests(sdk, sdkNonAdmin)
+    await mdb_sort_tests({ sdk, sdkNonAdmin })
+    await organization_settings_duplicates_tests({ sdk, sdkNonAdmin })
+    await search_tests()
     await time_tracks_tests({ sdk, sdkNonAdmin })
     await time_tracks_historical_tests({ sdk, sdkNonAdmin })
     await time_tracks_correction_tests({ sdk, sdkNonAdmin })
@@ -14147,6 +14175,7 @@ const ip_address_form_tests = async () => {
     await rate_limit_tests()
     await ip_address_form_tests()
     await bulk_update_tests()
+    await calendar_events_bulk_update_tests({ sdk })
     await cancel_upcoming_appointments_journey_action_test()
     await multi_tenant_tests() // should come right after setup tests
     await sync_tests_with_access_tags() // should come directly after setup to avoid extra sync values
@@ -14185,7 +14214,6 @@ const ip_address_form_tests = async () => {
     await role_based_access_tests()
     await enduser_session_tests()
     await nextReminderInMS_tests()
-    await search_tests()
     await wait_for_trigger_tests()
     await pdf_generation()
     await remove_from_journey_on_incoming_comms_tests().catch(console.error) // timing is unreliable, uncomment if changing logic