@teleporthq/teleport-plugin-next-workflows 0.43.44 → 0.43.46

package/src/workflow-component-plugin.ts

@@ -255,7 +255,20 @@ export const createNextWorkflowPlugin: ComponentPluginFactory<WorkflowPluginConf
         if (elementId) {
           elementTriggers.push({ workflow: wf, elementId, reactProp, triggerConfig })
         } else {
-          lifecycleWorkflows.push(wf)
+          // An element-event trigger (click/change/submit/…) with NO bound
+          // element cannot fire — the author detached it or never wired it.
+          // It used to fall through to lifecycleWorkflows, where the trigger
+          // switch has no case for element events: the workflow never
+          // executed but its full __wfConfig_* blob still shipped in every
+          // page bundle (element scope with no selectedPages matches ALL
+          // pages). Skip it entirely — an unbound workflow stays a draft in
+          // the project without leaking into the generated app.
+          // eslint-disable-next-line no-console
+          console.warn(
+            `[workflow-plugin] Skipping workflow "${wf.name || wf.id}" on "${uidl.name}" — its ${
+              trigger.type
+            } trigger has no bound element.`
+          )
         }
       } else {
         lifecycleWorkflows.push(wf)
@@ -1760,13 +1773,29 @@ const generateElementHandler = (et: ElementTriggerInfo): string => {
 
     case 'event-form-submitted': {
       const preventDefault = config.preventDefault !== false
+      // The submitted fields are spread FLAT onto the trigger context as well as
+      // being available under `formData`.
+      //
+      // WHY: `params[0]` of a top-level custom-js node is the TRIGGER (the
+      // executor writes `context[triggerNodeId]` first), and generated
+      // validators read the form off it directly. Run 4b049fe6's Edit Guild did
+      // `const form = params[0] || {}; … if (!form["name"]) return "Guild Name
+      // is required"` — `params[0].name` was undefined because the fields lived
+      // one level down, so saving a guild whose name was filled in reported the
+      // name as missing. `general-extract-form-data` already returns its fields
+      // flat for exactly this reason; the trigger now matches it, so both
+      // `params[0].name` and `params[0].formData.name` resolve.
+      //
+      // The spread comes FIRST so a field literally named `formData`, `formId`,
+      // `element` or `timestamp` can never shadow the reserved keys the runtime
+      // and the workflow editor depend on.
       return (
         `async function(event) {\n` +
         (preventDefault ? '    event.preventDefault();\n' : '') +
         `    const formData = {};\n` +
         `    const fd = new FormData(event.target);\n` +
         `    fd.forEach(function(v, k) { formData[k] = v; });\n` +
-        `    const triggerContext = { formData: formData, formId: '${elementId}', triggerElement: event.target, element: event.target, timestamp: Date.now() };\n` +
+        `    const triggerContext = Object.assign({}, formData, { fields: formData, formData: formData, formId: '${elementId}', triggerElement: event.target, element: event.target, timestamp: Date.now() });\n` +
         `    return __execWf(__wfConfig_${safeId}, triggerContext, __wfServerUrls_${safeId});\n` +
         `  }`
       )