@teleporthq/teleport-plugin-next-workflows 0.43.38 → 0.43.39

package/__tests__/resolve-handler-entry-name.test.ts

@@ -0,0 +1,130 @@
+import { resolveHandlerEntryName } from '../src/nodes/types'
+import { nodeRegistry } from '../src/nodes'
+
+/**
+ * Regression coverage for resolveHandlerEntryName, which exists because a
+ * handler's declared name at runtime can diverge from the
+ * `nodeType.replace(/-/g, '_')` convention name: when this package is bundled
+ * and minified by a consumer (e.g. teleport-gui's browser packer worker), the
+ * minifier freely renames a `handlerToString(fn)`-embedded function's
+ * declaration, since nothing in the bundle calls it by name — only the
+ * runtime `.toString()` read does, which is invisible to the minifier.
+ *
+ * Two real handlers exposed shapes the resolver initially got wrong:
+ *   - payment-charge-user.ts: entry declared FIRST, its own helpers after
+ *     (`handlerToString(payment_charge_user) + '\n' + chargeWithStripe.toString() + ...`).
+ *   - ai-custom-prompt.ts: shared AI-provider utils declared BEFORE the
+ *     entry, each wrapped in a `wrapWithGuard`-style re-declaration guard
+ *     (`var X = typeof X !== 'undefined' ? X : function Y() {...};` — a
+ *     function EXPRESSION embedded in a ternary, not a statement-level
+ *     declaration) — this crashed a real publish with "Could not resolve the
+ *     entry function for workflow node type "ai-custom-prompt"".
+ * A naive "first" or "last" positional heuristic breaks one of these two.
+ */
+
+function evalEntryWrapper(source: string, entryName: string): unknown {
+  return new Function(`${source}\nreturn ${entryName};`)()
+}
+
+describe('resolveHandlerEntryName', () => {
+  it('returns the convention name when the source declares it directly', () => {
+    const source = `async function my_node_type(config, context) { return {}; }`
+    expect(resolveHandlerEntryName(source, 'my-node-type')).toBe('my_node_type')
+  })
+
+  it('falls back to the actual declared name when the entry was renamed (single function)', () => {
+    const source = `async function e(config, context) { return {}; }`
+    expect(resolveHandlerEntryName(source, 'my-node-type')).toBe('e')
+  })
+
+  it('finds a renamed entry declared FIRST, before its own helpers (payment-charge-user shape)', () => {
+    const source = `
+async function zzz(config, context) {
+  return helper_one(config) + helper_two(context);
+}
+async function helper_one(config) { return config.x; }
+async function helper_two(context) { return context.y; }
+`
+    const resolved = resolveHandlerEntryName(source, 'payment-charge-user')
+    expect(resolved).toBe('zzz')
+    expect(typeof evalEntryWrapper(source, resolved)).toBe('function')
+  })
+
+  it('finds a renamed entry declared LAST, after ternary-guarded shared utils (ai-custom-prompt shape)', () => {
+    const source = `
+var util_one = typeof util_one !== 'undefined' ? util_one : function util_one(val) { return val; };
+var util_two = typeof util_two !== 'undefined' ? util_two : function util_two(val) { return val; };
+
+async function zzz(config, context, streamCallback) {
+  return util_one(config) + util_two(context);
+}
+`
+    const resolved = resolveHandlerEntryName(source, 'ai-custom-prompt')
+    expect(resolved).toBe('zzz')
+    expect(typeof evalEntryWrapper(source, resolved)).toBe('function')
+  })
+
+  it('prefers the entry-point arity (2-3 params) over a same-position helper with a different arity', () => {
+    // A helper positioned BEFORE the (renamed) entry, but with an arity that
+    // could never be a real handler entry point (1 param) — must not win.
+    const source = `
+function one_param_helper(x) { return x; }
+async function zzz(config, context) { return one_param_helper(config); }
+`
+    expect(resolveHandlerEntryName(source, 'my-node-type')).toBe('zzz')
+  })
+
+  it('throws a clear error when no declaration can be found at all', () => {
+    expect(() => resolveHandlerEntryName('var x = 1;', 'my-node-type')).toThrow(
+      /Could not resolve the entry function/
+    )
+  })
+
+  // Full-registry regression: every node type's generateHandler()/
+  // generateServerHandler() output must resolve to a real, callable function
+  // both normally AND after its entry function's declared name is renamed
+  // (simulating what a minifier does) — proves the resolver's fallback logic
+  // holds for every handler shape actually registered, not just hand-picked
+  // examples.
+  describe('every registered node type', () => {
+    const nodeTypes = Object.keys(nodeRegistry)
+
+    it.each(nodeTypes)(
+      '%s: generateHandler resolves normally and after entry rename',
+      (nodeType) => {
+        const gen = nodeRegistry[nodeType]
+        const source = gen.generateHandler().trim()
+        const conventionName = nodeType.replace(/-/g, '_')
+
+        const resolvedNormal = resolveHandlerEntryName(source, nodeType)
+        expect(typeof evalEntryWrapper(source, resolvedNormal)).toBe('function')
+
+        if (source.includes(conventionName)) {
+          const renamed = source.replace(new RegExp(`\\b${conventionName}\\b`, 'g'), 'zzz_renamed')
+          const resolvedRenamed = resolveHandlerEntryName(renamed, nodeType)
+          expect(resolvedRenamed).toBe('zzz_renamed')
+          expect(typeof evalEntryWrapper(renamed, resolvedRenamed)).toBe('function')
+        }
+      }
+    )
+
+    it.each(nodeTypes.filter((t) => nodeRegistry[t].generateServerHandler))(
+      '%s: generateServerHandler resolves normally and after entry rename',
+      (nodeType) => {
+        const gen = nodeRegistry[nodeType]
+        const source = gen.generateServerHandler!().trim()
+        const conventionName = nodeType.replace(/-/g, '_')
+
+        const resolvedNormal = resolveHandlerEntryName(source, nodeType)
+        expect(typeof evalEntryWrapper(source, resolvedNormal)).toBe('function')
+
+        if (source.includes(conventionName)) {
+          const renamed = source.replace(new RegExp(`\\b${conventionName}\\b`, 'g'), 'zzz_renamed')
+          const resolvedRenamed = resolveHandlerEntryName(renamed, nodeType)
+          expect(resolvedRenamed).toBe('zzz_renamed')
+          expect(typeof evalEntryWrapper(renamed, resolvedRenamed)).toBe('function')
+        }
+      }
+    )
+  })
+})

package/dist/cjs/nodes/types.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"types.d.ts","sourceRoot":"","sources":["../../../src/nodes/types.ts"],"names":[],"mappings":"AAAA,MAAM,MAAM,SAAS,GAAG,CAAC,MAAM,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,KAAK,OAAO,CAAC,OAAO,CAAC,CAAA;AAE/F,wBAAgB,eAAe,CAAC,EAAE,EAAE,SAAS,GAAG,MAAM,CAErD;AAoBD,wBAAgB,uBAAuB,CAAC,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,GAAG,MAAM,CAoBhF;AAED,MAAM,WAAW,oBAAoB;IACnC,QAAQ,EAAE,MAAM,CAAA;IAChB,YAAY,EAAE,QAAQ,GAAG,QAAQ,GAAG,WAAW,CAAA;IAC/C,UAAU,CAAC,EAAE,OAAO,CAAA;IACpB,YAAY,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;IACrC,eAAe,IAAI,MAAM,CAAA;IACzB,qBAAqB,CAAC,IAAI,MAAM,CAAA;CACjC;AAED,MAAM,WAAW,2BAA4B,SAAQ,oBAAoB;IACvE,YAAY,EAAE,MAAM,EAAE,CAAA;CACvB"}
+{"version":3,"file":"types.d.ts","sourceRoot":"","sources":["../../../src/nodes/types.ts"],"names":[],"mappings":"AAAA,MAAM,MAAM,SAAS,GAAG,CAAC,MAAM,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,KAAK,OAAO,CAAC,OAAO,CAAC,CAAA;AAE/F,wBAAgB,eAAe,CAAC,EAAE,EAAE,SAAS,GAAG,MAAM,CAErD;AAoBD,wBAAgB,uBAAuB,CAAC,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,GAAG,MAAM,CA+DhF;AAED,MAAM,WAAW,oBAAoB;IACnC,QAAQ,EAAE,MAAM,CAAA;IAChB,YAAY,EAAE,QAAQ,GAAG,QAAQ,GAAG,WAAW,CAAA;IAC/C,UAAU,CAAC,EAAE,OAAO,CAAA;IACpB,YAAY,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;IACrC,eAAe,IAAI,MAAM,CAAA;IACzB,qBAAqB,CAAC,IAAI,MAAM,CAAA;CACjC;AAED,MAAM,WAAW,2BAA4B,SAAQ,oBAAoB;IACvE,YAAY,EAAE,MAAM,EAAE,CAAA;CACvB"}

package/dist/cjs/nodes/types.js

@@ -29,13 +29,57 @@ function resolveHandlerEntryName(source, nodeType) {
     if (conventionNameUsed) {
         return conventionName;
     }
-    // `source` came from `handlerToString(fn)` on a real, possibly-minified
-    // function — its ENTIRE text is that one function's declaration, so
-    // whatever name follows the leading `function`/`async function` keyword is
-    // the name it was actually assigned at runtime.
-    const leadingDeclaration = source.match(/^(?:async\s+)?function\s*([A-Za-z0-9_$]+)\s*\(/);
-    if (leadingDeclaration) {
-        return leadingDeclaration[1];
+    // `source` came from `handlerToString(fn)`/`fn.toString()` on a real,
+    // possibly-minified function, and may be concatenated with OTHER
+    // `.toString()`'d functions:
+    //   - payment-charge-user.ts puts the entry FIRST, its own helpers after
+    //     (`handlerToString(payment_charge_user) + '\n' + chargeWithStripe.toString() + ...`).
+    //   - ai-custom-prompt.ts puts shared AI-provider utils BEFORE the entry
+    //     (`generateAIProviderUtils() + '\n\n' + ai_custom_prompt.toString()`),
+    //     where each util is `wrapWithGuard`-wrapped: `var X = typeof X !==
+    //     'undefined' ? X : function Y() {...};` — a function EXPRESSION
+    //     embedded in a ternary, not a statement-level declaration.
+    // So the entry is not reliably first or last by position across handlers,
+    // and helper functions can outnumber (or precede) the entry. What IS
+    // reliable: every real entry point has exactly the HandlerFn signature —
+    // 2 params (config, context) or 3 (config, context, streamCallback) — by
+    // contract, while a handler's OWN internal helpers only coincidentally
+    // share that arity (e.g. general-rate-limiter's __checkRateLimit takes 3
+    // params too). So: collect every statement-level function declaration
+    // (skipping ternary-embedded expressions like wrapWithGuard's), and prefer
+    // an exactly-2-param candidate, then an exactly-3-param one, falling back
+    // to positional order only if nothing matches the entry-point arity.
+    const declPattern = /(?:async\s+)?function\s+([A-Za-z0-9_$]+)\s*\(([^)]*)\)/g;
+    const candidates = [];
+    let twoParamCandidate;
+    let threeParamCandidate;
+    let declMatch = declPattern.exec(source);
+    while (declMatch !== null) {
+        const precedingNonSpace = source.slice(0, declMatch.index).trimEnd().slice(-1);
+        if (precedingNonSpace === ':' || precedingNonSpace === '?') {
+            declMatch = declPattern.exec(source);
+            continue; // function EXPRESSION embedded in a ternary (e.g. wrapWithGuard's re-declaration guard)
+        }
+        const name = declMatch[1];
+        candidates.push(name);
+        const params = declMatch[2].trim();
+        const paramCount = params === '' ? 0 : params.split(',').length;
+        if (paramCount === 2 && twoParamCandidate === undefined) {
+            twoParamCandidate = name;
+        }
+        else if (paramCount === 3 && threeParamCandidate === undefined) {
+            threeParamCandidate = name;
+        }
+        declMatch = declPattern.exec(source);
+    }
+    if (twoParamCandidate !== undefined) {
+        return twoParamCandidate;
+    }
+    if (threeParamCandidate !== undefined) {
+        return threeParamCandidate;
+    }
+    if (candidates.length > 0) {
+        return candidates[0];
     }
     throw new Error(`Could not resolve the entry function for workflow node type "${nodeType}" — ` +
         `expected a "${conventionName}" declaration or a single toString()'d function, found neither.`);

package/dist/cjs/nodes/types.js.map

@@ -1 +1 @@
-{"version":3,"file":"types.js","sourceRoot":"","sources":["../../../src/nodes/types.ts"],"names":[],"mappings":";;;AAEA,SAAgB,eAAe,CAAC,EAAa;IAC3C,OAAO,EAAE,CAAC,QAAQ,EAAE,CAAA;AACtB,CAAC;AAFD,0CAEC;AAED,4EAA4E;AAC5E,sDAAsD;AACtD,iDAAiD;AACjD,EAAE;AACF,qEAAqE;AACrE,0EAA0E;AAC1E,4EAA4E;AAC5E,8EAA8E;AAC9E,6EAA6E;AAC7E,4EAA4E;AAC5E,wEAAwE;AACxE,gEAAgE;AAChE,yDAAyD;AACzD,EAAE;AACF,4EAA4E;AAC5E,4EAA4E;AAC5E,2EAA2E;AAC3E,4EAA4E;AAC5E,SAAgB,uBAAuB,CAAC,MAAc,EAAE,QAAgB;IACtE,MAAM,cAAc,GAAG,QAAQ,CAAC,OAAO,CAAC,IAAI,EAAE,GAAG,CAAC,CAAA;IAClD,MAAM,kBAAkB,GAAG,IAAI,MAAM,CAAC,gBAAgB,cAAc,SAAS,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAA;IAC3F,IAAI,kBAAkB,EAAE;QACtB,OAAO,cAAc,CAAA;KACtB;IAED,wEAAwE;IACxE,oEAAoE;IACpE,2EAA2E;IAC3E,gDAAgD;IAChD,MAAM,kBAAkB,GAAG,MAAM,CAAC,KAAK,CAAC,gDAAgD,CAAC,CAAA;IACzF,IAAI,kBAAkB,EAAE;QACtB,OAAO,kBAAkB,CAAC,CAAC,CAAC,CAAA;KAC7B;IAED,MAAM,IAAI,KAAK,CACb,gEAAgE,QAAQ,MAAM;QAC5E,eAAe,cAAc,iEAAiE,CACjG,CAAA;AACH,CAAC;AApBD,0DAoBC"}
+{"version":3,"file":"types.js","sourceRoot":"","sources":["../../../src/nodes/types.ts"],"names":[],"mappings":";;;AAEA,SAAgB,eAAe,CAAC,EAAa;IAC3C,OAAO,EAAE,CAAC,QAAQ,EAAE,CAAA;AACtB,CAAC;AAFD,0CAEC;AAED,4EAA4E;AAC5E,sDAAsD;AACtD,iDAAiD;AACjD,EAAE;AACF,qEAAqE;AACrE,0EAA0E;AAC1E,4EAA4E;AAC5E,8EAA8E;AAC9E,6EAA6E;AAC7E,4EAA4E;AAC5E,wEAAwE;AACxE,gEAAgE;AAChE,yDAAyD;AACzD,EAAE;AACF,4EAA4E;AAC5E,4EAA4E;AAC5E,2EAA2E;AAC3E,4EAA4E;AAC5E,SAAgB,uBAAuB,CAAC,MAAc,EAAE,QAAgB;IACtE,MAAM,cAAc,GAAG,QAAQ,CAAC,OAAO,CAAC,IAAI,EAAE,GAAG,CAAC,CAAA;IAClD,MAAM,kBAAkB,GAAG,IAAI,MAAM,CAAC,gBAAgB,cAAc,SAAS,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAA;IAC3F,IAAI,kBAAkB,EAAE;QACtB,OAAO,cAAc,CAAA;KACtB;IAED,sEAAsE;IACtE,iEAAiE;IACjE,6BAA6B;IAC7B,yEAAyE;IACzE,2FAA2F;IAC3F,yEAAyE;IACzE,4EAA4E;IAC5E,wEAAwE;IACxE,qEAAqE;IACrE,gEAAgE;IAChE,0EAA0E;IAC1E,qEAAqE;IACrE,yEAAyE;IACzE,yEAAyE;IACzE,uEAAuE;IACvE,yEAAyE;IACzE,sEAAsE;IACtE,2EAA2E;IAC3E,0EAA0E;IAC1E,qEAAqE;IACrE,MAAM,WAAW,GAAG,yDAAyD,CAAA;IAC7E,MAAM,UAAU,GAAa,EAAE,CAAA;IAC/B,IAAI,iBAAqC,CAAA;IACzC,IAAI,mBAAuC,CAAA;IAC3C,IAAI,SAAS,GAA2B,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,CAAA;IAChE,OAAO,SAAS,KAAK,IAAI,EAAE;QACzB,MAAM,iBAAiB,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC,EAAE,SAAS,CAAC,KAAK,CAAC,CAAC,OAAO,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAA;QAC9E,IAAI,iBAAiB,KAAK,GAAG,IAAI,iBAAiB,KAAK,GAAG,EAAE;YAC1D,SAAS,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,CAAA;YACpC,SAAQ,CAAC,wFAAwF;SAClG;QACD,MAAM,IAAI,GAAG,SAAS,CAAC,CAAC,CAAC,CAAA;QACzB,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QACrB,MAAM,MAAM,GAAG,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAA;QAClC,MAAM,UAAU,GAAG,MAAM,KAAK,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,MAAM,CAAA;QAC/D,IAAI,UAAU,KAAK,CAAC,IAAI,iBAAiB,KAAK,SAAS,EAAE;YACvD,iBAAiB,GAAG,IAAI,CAAA;SACzB;aAAM,IAAI,UAAU,KAAK,CAAC,IAAI,mBAAmB,KAAK,SAAS,EAAE;YAChE,mBAAmB,GAAG,IAAI,CAAA;SAC3B;QACD,SAAS,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,CAAA;KACrC;IACD,IAAI,iBAAiB,KAAK,SAAS,EAAE;QACnC,OAAO,iBAAiB,CAAA;KACzB;IACD,IAAI,mBAAmB,KAAK,SAAS,EAAE;QACrC,OAAO,mBAAmB,CAAA;KAC3B;IACD,IAAI,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE;QACzB,OAAO,UAAU,CAAC,CAAC,CAAC,CAAA;KACrB;IAED,MAAM,IAAI,KAAK,CACb,gEAAgE,QAAQ,MAAM;QAC5E,eAAe,cAAc,iEAAiE,CACjG,CAAA;AACH,CAAC;AA/DD,0DA+DC"}