@telefonica/acceptance-testing 3.0.0-beta8 → 3.0.0

package/jest-puppeteer-config.js

@@ -1,4 +1,3 @@
-// @ts-check
 const path = require('path');
 const fs = require('fs');
 const findRoot = require('find-root');
@@ -18,25 +17,22 @@ const poll = async (url) => {
 };
 
 /**
- * CI => everything runs inside a docker. Executes the chromium installed in the docker.
+ * CI => everything runs inside a docker
  * Local, headless => connects to a dockerized chromium at port 9223 (see docker-compose.yaml)
  * Local, with UI => launches a local chromium installed by puppetteer
- *
- * @returns {Promise<import('jest-environment-puppeteer').JestPuppeteerConfig>}
  */
 const getPuppeteerConfig = async () => {
     const isCi = process.argv.includes('--ci') || process.env.CI;
     const isLocal = !isCi;
-    const isHeadless =
-        !!process.env.HEADLESS && process.env.HEADLESS !== 'false' && process.env.HEADLESS !== '0';
+    const isHeadless = !!process.env.HEADLESS;
 
     const rootDir = findRoot(process.cwd());
-    const packageJson = JSON.parse(fs.readFileSync(path.join(rootDir, 'package.json'), 'utf-8'));
-    const projectConfig = packageJson.acceptanceTests || {};
+    const pkg = JSON.parse(fs.readFileSync(path.join(rootDir, 'package.json'), 'utf-8'));
+    const projectConfig = pkg.acceptanceTests || {};
 
     const server = (isCi ? projectConfig.ciServer : projectConfig.devServer) || projectConfig.server || {};
 
-    const baseConnectOrLaunchConfig = {
+    const baseConfig = {
         ignoreHTTPSErrors: true,
         headless: isHeadless,
         slowMo: isHeadless ? 0 : 50,
@@ -60,15 +56,17 @@ const getPuppeteerConfig = async () => {
                 execSync(`docker compose -f ${dockerComposeFile} stop -t 0`, {stdio: 'ignore'});
             });
 
-            execSync(`docker compose -f ${dockerComposeFile}  up -d`, {stdio: 'inherit'});
+            execSync(`docker compose -f ${dockerComposeFile} up -d`, {stdio: 'inherit'});
             console.log();
 
             await poll(dockerChromiumUrl);
         }
 
+        const {webSocketDebuggerUrl} = await fetch(`${dockerChromiumUrl}/json/version`).then((r) => r.json());
+
         connect = {
-            ...baseConnectOrLaunchConfig,
-            browserURL: dockerChromiumUrl,
+            ...baseConfig,
+            browserWSEndpoint: webSocketDebuggerUrl,
         };
     }
 
@@ -81,16 +79,21 @@ const getPuppeteerConfig = async () => {
         launchTimeout: 60000,
     };
 
-    /** @type import('jest-environment-puppeteer').JestPuppeteerConfig  */
-    const config = {
+    return {
         launch: {
-            ...baseConnectOrLaunchConfig,
-            // launch chromium installed in docker in CI
+            ...baseConfig,
+            // Launch chromium installed in docker in CI
             ...(isCi ? {executablePath: '/usr/bin/chromium'} : {}),
-            dumpio: true,
-            // arguments must be the same as the ones defined in web-builder Dockerfile. Except the remote-debugging settings
+            env: {
+                ...process.env,
+                TZ: 'UTC',
+                LANG: 'es_ES',
+                LANGUAGE: 'es_ES',
+            },
             args: [
-                '--lang=es_ES',
+                // https://peter.sh/experiments/chromium-command-line-switches/
+                '--no-sandbox', // probably not needed in ubuntu
+                '--font-render-hinting=none', // this flag is important because we use it when launching dockerized chromium too
                 '--disable-background-networking',
                 '--disable-background-timer-throttling',
                 '--disable-breakpad',
@@ -104,25 +107,11 @@ const getPuppeteerConfig = async () => {
                 '--disable-prompt-on-repost',
                 '--disable-sync',
                 '--disable-translate',
-                '--disable-gpu',
-                '--metrics-recording-only',
-                '--no-first-run',
-                '--safebrowsing-disable-auto-update',
-                '--enable-automation',
-                '--password-store=basic',
-                '--use-mock-keychain',
-                '--headless=new',
-                '--hide-scrollbars',
-                '--no-sandbox',
-                '--disabled-setupid-sandbox',
-                '--font-render-hinting=none',
-                '--disable-font-subpixel-positioning',
-                '--ignore-certificate-errors',
+                '--disable-smooth-scrolling',
             ],
         },
-        browserContext: 'incognito',
-        browserPerWorker: false,
         connect,
+        browserContext: 'incognito',
         server: server
             ? {
                   ...defaultServerConfig,
@@ -130,8 +119,6 @@ const getPuppeteerConfig = async () => {
               }
             : undefined,
     };
-
-    return config;
 };
 
 module.exports = getPuppeteerConfig();

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@telefonica/acceptance-testing",
-    "version": "3.0.0-beta8",
+    "version": "3.0.0",
     "author": "Telefonica",
     "license": "UNLICENSED",
     "module": "dist/acceptance-testing.esm.js",
@@ -16,7 +16,7 @@
         "jest-puppeteer-config.js"
     ],
     "engines": {
-        "node": ">=20"
+        "node": ">=12"
     },
     "scripts": {
         "start": "tsdx watch",
@@ -27,15 +27,14 @@
         "prepack": "yarn test && yarn build"
     },
     "devDependencies": {
-        "@types/find-root": "^1.1.4",
-        "@types/glob-to-regexp": "^0.4.4",
-        "@typescript-eslint/eslint-plugin": "^7.9.0",
-        "@typescript-eslint/parser": "^7.9.0",
+        "@types/find-root": "^1.1.2",
+        "@types/glob-to-regexp": "^0.4.1",
+        "@typescript-eslint/eslint-plugin": "^6.10.0",
+        "@typescript-eslint/parser": "^6.10.0",
         "babel-jest": "^29.7.0",
-        "jest-environment-puppeteer": "^10.0.1",
         "tsdx": "^0.14.1",
-        "tslib": "^2.6.2",
-        "typescript": "^5.4.5"
+        "tslib": "^2.3.1",
+        "typescript": "^4.4.4"
     },
     "repository": "git@github.com:Telefonica/js-toolbox.git",
     "publishConfig": {
@@ -43,16 +42,16 @@
         "registry": "https://registry.npmjs.org"
     },
     "dependencies": {
-        "@types/jest-image-snapshot": "^6.4.0",
+        "@types/jest-image-snapshot": "^4.3.1",
         "find-root": "^1.1.0",
         "glob-to-regexp": "^0.4.1",
-        "jest-image-snapshot": "^6.4.0",
+        "jest-image-snapshot": "^4.5.1",
         "node-fetch": "^2.6.5",
-        "pptr-testing-library": "^0.8.0",
-        "puppeteer": "^22.8.1"
+        "pptr-testing-library": "^0.6.5",
+        "puppeteer": "^10.4.0"
     },
     "peerDependencies": {
         "jest": ">=26",
-        "jest-environment-puppeteer": ">=10"
+        "jest-environment-puppeteer": ">=4"
     }
 }

package/dist/__tests__/utils.test.d.ts

@@ -1 +0,0 @@
-export {};