@tekyzinc/gsd-t 2.71.19 → 2.71.21

package/CHANGELOG.md

@@ -2,6 +2,21 @@
 
 All notable changes to GSD-T are documented here. Updated with each release.
 
+## [2.71.21] - 2026-04-08
+
+### Fixed (orchestrator — timeout false-pass, review server health, stale cleanup)
+- **Reviewer timeout/kill no longer treated as "pass"** — exit codes 143 (SIGTERM) and 137 (SIGKILL) are now always detected as failures regardless of duration. Previously, a reviewer that timed out at 300s was parsed as "0 issues = pass" because crash detection only checked duration < 10s.
+- **Empty output with non-zero exit also caught** — any reviewer that exits non-zero with no output is treated as a failure, not a clean pass.
+- **Review server health check during human review gate** — every ~30s the polling loop verifies port 3456 is alive. If the review server dies, it auto-restarts. Previously, a dead review server left the orchestrator stuck forever.
+- **Stale auto-review cleanup** — old auto-review files from previous runs are cleared at the start of each phase's review cycle, preventing misleading results from prior orchestrator runs.
+
+## [2.71.20] - 2026-04-08
+
+### Fixed (orchestrator — reviewer crash false-pass + Ctrl+C + build logging)
+- **Reviewer crash no longer treated as "pass"** — if the reviewer exits with non-zero code in under 10s, it's a crash, not a clean review. Retried on next cycle. Previously, empty output from a crashed reviewer was parsed as "0 issues = pass."
+- **Ctrl+C now works** — replaced `Atomics.wait` with `sleep` command for synchronous polling. `Atomics.wait` blocks the event loop completely, preventing SIGINT.
+- **Build output logging** — builder output written to `.gsd-t/design-review/build-logs/{phase}-build.log` for debugging.
+
 ## [2.71.18] - 2026-04-08
 
 ### Fixed (orchestrator — Claude permissions and timeouts)

package/bin/orchestrator.js

@@ -52,10 +52,12 @@ function ensureDir(dir) {
 }
 
 function syncSleep(ms) {
+  // Use sleep command instead of Atomics.wait — Atomics blocks the event loop
+  // completely, preventing SIGINT (Ctrl+C) from being handled
   try {
-    Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, ms);
+    execFileSync("sleep", [String(ms / 1000)], { stdio: "pipe" });
   } catch {
-    try { execFileSync("sleep", [String(ms / 1000)], { stdio: "pipe" }); } catch { /* ignore */ }
+    // sleep interrupted by signal — that's fine
   }
 }
 
@@ -366,6 +368,7 @@ ${BOLD}Phases:${RESET} ${this.wf.phases.join(" → ")}
     openBrowser(`http://localhost:${reviewPort}/review`);
 
     // IRONCLAD GATE — JavaScript polling loop
+    let healthCheckCounter = 0;
     while (true) {
       if (fs.existsSync(signalPath)) {
         try {
@@ -374,6 +377,22 @@ ${BOLD}Phases:${RESET} ${this.wf.phases.join(" → ")}
           return data;
         } catch { /* malformed — wait for rewrite */ }
       }
+
+      // Every 10 polls (~30s), verify review server is still alive
+      healthCheckCounter++;
+      if (healthCheckCounter % 10 === 0) {
+        if (!isPortInUse(reviewPort)) {
+          warn("Review server is down! Restarting...");
+          const devPort = this._activeDevPort || reviewPort - 1283; // fallback heuristic
+          const info = this.startReviewServer(projectDir, devPort, reviewPort);
+          if (info.pid || info.alreadyRunning) {
+            success("Review server restarted");
+          } else {
+            error("Failed to restart review server — please restart the orchestrator");
+          }
+        }
+      }
+
       syncSleep(3000);
     }
   }
@@ -512,6 +531,7 @@ ${BOLD}Phases:${RESET} ${this.wf.phases.join(" → ")}
       const devInfo = this.startDevServer(projectDir, devPort);
       const reviewInfo = this.startReviewServer(projectDir, devPort, reviewPort);
       this.pids = [devInfo.pid, reviewInfo.pid].filter(Boolean);
+      this._activeDevPort = devPort;
     }
 
     // Register cleanup on exit
@@ -593,6 +613,16 @@ ${BOLD}Phases:${RESET} ${this.wf.phases.join(" → ")}
       // If issues found → spawn fixer Claude → re-measure → re-review until clean.
       const maxAutoReviewCycles = this.wf.defaults?.maxAutoReviewCycles || 4;
       if (this.wf.buildReviewPrompt) {
+        // Clear stale auto-review files from previous runs for this phase
+        const arDir = path.join(this.getReviewDir(projectDir), "auto-review");
+        if (fs.existsSync(arDir)) {
+          for (const f of fs.readdirSync(arDir)) {
+            if (f.startsWith(`${phase}-`)) {
+              try { fs.unlinkSync(path.join(arDir, f)); } catch { /* ignore */ }
+            }
+          }
+        }
+
         let autoReviewCycle = 0;
         let autoReviewClean = false;
 
@@ -607,14 +637,30 @@ ${BOLD}Phases:${RESET} ${this.wf.phases.join(" → ")}
           const reviewResult = this.spawnClaude(projectDir, reviewPrompt, reviewTimeout);
 
           // Parse reviewer output for issues
-          const issues = this.wf.parseReviewResult
-            ? this.wf.parseReviewResult(reviewResult.output, phase)
-            : this._parseDefaultReviewResult(reviewResult.output);
-
-          if (reviewResult.exitCode === 0) {
-            success(`Reviewer finished in ${reviewResult.duration}s`);
+          let issues;
+
+          // Treat reviewer failure as a failed review, not a pass:
+          // - crash: non-zero exit + very short duration (< 10s)
+          // - timeout/kill: exit codes 143 (SIGTERM) or 137 (SIGKILL)
+          // - empty output with non-zero exit: reviewer produced nothing useful
+          const isCrash = reviewResult.exitCode !== 0 && reviewResult.duration < 10;
+          const isKilled = [143, 137].includes(reviewResult.exitCode);
+          const isEmptyFail = reviewResult.exitCode !== 0 && !reviewResult.output.trim();
+
+          if (isCrash || isKilled || isEmptyFail) {
+            const reason = isCrash ? "crashed" : isKilled ? "killed/timed out" : "failed with no output";
+            warn(`Reviewer ${reason} (code ${reviewResult.exitCode}, ${reviewResult.duration}s) — treating as review failure, will retry`);
+            issues = [{ component: "ALL", severity: "critical", description: `Reviewer ${reason} with exit code ${reviewResult.exitCode} — review not performed` }];
           } else {
-            warn(`Reviewer exited with code ${reviewResult.exitCode} after ${reviewResult.duration}s`);
+            issues = this.wf.parseReviewResult
+              ? this.wf.parseReviewResult(reviewResult.output, phase)
+              : this._parseDefaultReviewResult(reviewResult.output);
+
+            if (reviewResult.exitCode === 0) {
+              success(`Reviewer finished in ${reviewResult.duration}s`);
+            } else {
+              warn(`Reviewer exited with code ${reviewResult.exitCode} after ${reviewResult.duration}s`);
+            }
           }
 
           // Write review report
@@ -622,7 +668,7 @@ ${BOLD}Phases:${RESET} ${this.wf.phases.join(" → ")}
           ensureDir(reportDir);
           fs.writeFileSync(
             path.join(reportDir, `${phase}-cycle-${autoReviewCycle}.json`),
-            JSON.stringify({ cycle: autoReviewCycle, issues, output: reviewResult.output.slice(0, 5000) }, null, 2)
+            JSON.stringify({ cycle: autoReviewCycle, issues, exitCode: reviewResult.exitCode, duration: reviewResult.duration, output: reviewResult.output.slice(0, 5000) }, null, 2)
           );
 
           if (issues.length === 0) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tekyzinc/gsd-t",
-  "version": "2.71.19",
+  "version": "2.71.21",
   "description": "GSD-T: Contract-Driven Development for Claude Code — 56 slash commands with headless CI/CD mode, graph-powered code analysis, real-time agent dashboard, execution intelligence, task telemetry, doc-ripple enforcement, backlog management, impact analysis, test sync, milestone archival, and PRD generation",
   "author": "Tekyz, Inc.",
   "license": "MIT",