@tekyzinc/gsd-t 2.71.18 → 2.71.20

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to GSD-T are documented here. Updated with each release.
 
+## [2.71.20] - 2026-04-08
+
+### Fixed (orchestrator — reviewer crash false-pass + Ctrl+C + build logging)
+- **Reviewer crash no longer treated as "pass"** — if the reviewer exits with non-zero code in under 10s, it's a crash, not a clean review. Retried on next cycle. Previously, empty output from a crashed reviewer was parsed as "0 issues = pass."
+- **Ctrl+C now works** — replaced `Atomics.wait` with `sleep` command for synchronous polling. `Atomics.wait` blocks the event loop completely, preventing SIGINT.
+- **Build output logging** — builder output written to `.gsd-t/design-review/build-logs/{phase}-build.log` for debugging.
+
 ## [2.71.18] - 2026-04-08
 
 ### Fixed (orchestrator — Claude permissions and timeouts)

package/bin/orchestrator.js

@@ -52,10 +52,12 @@ function ensureDir(dir) {
 }
 
 function syncSleep(ms) {
+  // Use sleep command instead of Atomics.wait — Atomics blocks the event loop
+  // completely, preventing SIGINT (Ctrl+C) from being handled
   try {
-    Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, ms);
+    execFileSync("sleep", [String(ms / 1000)], { stdio: "pipe" });
   } catch {
-    try { execFileSync("sleep", [String(ms / 1000)], { stdio: "pipe" }); } catch { /* ignore */ }
+    // sleep interrupted by signal — that's fine
   }
 }
 
@@ -569,6 +571,14 @@ ${BOLD}Phases:${RESET} ${this.wf.phases.join(" → ")}
         warn(`Claude exited with code ${buildResult.exitCode} after ${buildResult.duration}s`);
       }
 
+      // Log build output for debugging
+      const buildLogDir = path.join(this.getReviewDir(projectDir), "build-logs");
+      ensureDir(buildLogDir);
+      fs.writeFileSync(
+        path.join(buildLogDir, `${phase}-build.log`),
+        `Exit code: ${buildResult.exitCode}\nDuration: ${buildResult.duration}s\nPrompt length: ${prompt.length}\n\n--- OUTPUT ---\n${buildResult.output.slice(0, 20000)}`
+      );
+
       // 6c. Collect built paths
       const builtPaths = items.map(item =>
         item.sourcePath || (this.wf.guessPaths ? this.wf.guessPaths(phase, item) : "")
@@ -599,14 +609,22 @@ ${BOLD}Phases:${RESET} ${this.wf.phases.join(" → ")}
           const reviewResult = this.spawnClaude(projectDir, reviewPrompt, reviewTimeout);
 
           // Parse reviewer output for issues
-          const issues = this.wf.parseReviewResult
-            ? this.wf.parseReviewResult(reviewResult.output, phase)
-            : this._parseDefaultReviewResult(reviewResult.output);
+          let issues;
 
-          if (reviewResult.exitCode === 0) {
-            success(`Reviewer finished in ${reviewResult.duration}s`);
+          // Treat reviewer crash (non-zero exit, very short duration) as a failed review, not a pass
+          if (reviewResult.exitCode !== 0 && reviewResult.duration < 10) {
+            warn(`Reviewer crashed (code ${reviewResult.exitCode}, ${reviewResult.duration}s) — treating as review failure, will retry`);
+            issues = [{ component: "ALL", severity: "critical", description: `Reviewer crashed with exit code ${reviewResult.exitCode} — review not performed` }];
           } else {
-            warn(`Reviewer exited with code ${reviewResult.exitCode} after ${reviewResult.duration}s`);
+            issues = this.wf.parseReviewResult
+              ? this.wf.parseReviewResult(reviewResult.output, phase)
+              : this._parseDefaultReviewResult(reviewResult.output);
+
+            if (reviewResult.exitCode === 0) {
+              success(`Reviewer finished in ${reviewResult.duration}s`);
+            } else {
+              warn(`Reviewer exited with code ${reviewResult.exitCode} after ${reviewResult.duration}s`);
+            }
           }
 
           // Write review report
@@ -614,7 +632,7 @@ ${BOLD}Phases:${RESET} ${this.wf.phases.join(" → ")}
           ensureDir(reportDir);
           fs.writeFileSync(
             path.join(reportDir, `${phase}-cycle-${autoReviewCycle}.json`),
-            JSON.stringify({ cycle: autoReviewCycle, issues, output: reviewResult.output.slice(0, 5000) }, null, 2)
+            JSON.stringify({ cycle: autoReviewCycle, issues, exitCode: reviewResult.exitCode, duration: reviewResult.duration, output: reviewResult.output.slice(0, 5000) }, null, 2)
           );
 
           if (issues.length === 0) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tekyzinc/gsd-t",
-  "version": "2.71.18",
+  "version": "2.71.20",
   "description": "GSD-T: Contract-Driven Development for Claude Code — 56 slash commands with headless CI/CD mode, graph-powered code analysis, real-time agent dashboard, execution intelligence, task telemetry, doc-ripple enforcement, backlog management, impact analysis, test sync, milestone archival, and PRD generation",
   "author": "Tekyz, Inc.",
   "license": "MIT",