@techierathore/techieflow 1.0.4 → 1.1.1

package/.tfcore/utils/tf-triage.py

@@ -8,6 +8,9 @@
     bash .tfcore/utils/tf-triage.sh <App> note <REQ> "<could not reproduce: what was tried>"
     bash .tfcore/utils/tf-triage.sh <App> close [--started <ISO>] [--verify-ran] [--cmd triage-issues|fix-issues]
 
+demote, new and note take --phase N for another phase's checklist; without it demote and note find the
+row in whichever docs/<App>-Checklist.md or docs/<App>-P<N>-Checklist.md holds it.
+
 demote  the row goes to Needs re-verify (% capped at 75) with a dated Remark holding the symptom in the
         reporter's words, the evidence path and the kind.
 new     a defect no row covers: the next free id in the prefix, a Not Started row, a detail entry with the
@@ -20,7 +23,8 @@ close   what triage owes the telemetry, from the actions above (tests/.artifacts
         spec for a new row, which the spec never had) (duplicates collapsed through
         tf-emit.sh --open-miss; the origin run looked up with --origin-of), then the run record. It also
         lists every file under src/, source/ or tests/ changed since the start: a triage that edited code
-        is reported and logged as an instruction-ignored miss (FR-28).
+        is reported and logged as an instruction-ignored miss (FR-28). Only actions logged since the start
+        count, and a close empties the list (TrBlazeUI TF-001).
 Exit 0 · 2 could not run.
 """
 import datetime
@@ -58,12 +62,47 @@ def cfg_phase():
     return 1
 
 
-def checklist(app):
-    ph = cfg_phase()
-    p = os.path.join("docs", f"{app}-Checklist.md" if ph <= 1 else f"{app}-P{ph}-Checklist.md")
-    if not os.path.isfile(p):
-        die(f"{p} does not exist")
-    return p
+def cfg_project_type():
+    """metrics.project_type from core-config.yaml: a library or docs project has no mockups."""
+    p = os.path.join(".tfcore", "core-config.yaml")
+    if os.path.isfile(p):
+        import re
+        m = re.search(r"(?m)^\s+project_type:\s*(\S+)", open(p, encoding="utf-8").read())
+        if m:
+            return m.group(1).strip("'\"").lower()
+    return "app"
+
+
+def phase_checklist(app, ph):
+    return os.path.join("docs", f"{app}-Checklist.md" if ph <= 1 else f"{app}-P{ph}-Checklist.md")
+
+
+def checklist(app, argv, ce, rid=None):
+    """--phase N names the checklist, as tf-verify-list.py takes it. Without it: the appPhase
+    checklist, or, for a row that is not there, the one earlier-phase checklist that holds it —
+    a Phase 3 verify finds Phase 1 rows failing, and demote could not reach them (TF-051)."""
+    if "--phase" in argv:
+        v = opt(argv, "--phase", "")
+        if not v.isdigit():
+            die("--phase needs a number")
+        p = phase_checklist(app, int(v))
+        if not os.path.isfile(p):
+            die(f"{p} does not exist")
+        return p
+    p = phase_checklist(app, cfg_phase())
+    if rid is None or (os.path.isfile(p) and rid in ce.rows(ce.read(p))):
+        if not os.path.isfile(p):
+            die(f"{p} does not exist")
+        return p
+    import glob
+    every = sorted(set(glob.glob(os.path.join("docs", f"{app}-Checklist.md")) + glob.glob(os.path.join("docs", f"{app}-P*-Checklist.md"))))
+    hits = [c for c in every if rid in ce.rows(ce.read(c))]
+    if len(hits) == 1:
+        print(f"note: {rid} is a row of {hits[0]}, not of {p}; written there")
+        return hits[0]
+    if len(hits) > 1:
+        die(f"{rid} is a row of {', '.join(hits)}; name one with --phase N")
+    die(f"{rid} is not a row of {', '.join(every) or p}")
 
 
 def log_load():
@@ -112,7 +151,6 @@ def main(argv):
         return 0 if len(argv) > 1 else 2
     app, verb = argv[1], argv[2]
     ce = mod()
-    cl = checklist(app)
     log = log_load()
     log.setdefault("app", app)
     now = datetime.datetime.now(datetime.timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ")
@@ -121,6 +159,7 @@ def main(argv):
         if len(argv) < 5:
             die("demote needs <REQ> \"<symptom>\"")
         rid, symptom = argv[3].upper(), argv[4]
+        cl = checklist(app, argv, ce, rid)
         kind = opt(argv, "--kind"); ev = opt(argv, "--evidence"); src = opt(argv, "--source", "owner")
         prior = ce.demote(cl, rid, symptom, kind=kind, evidence=ev, source=src, prefix="⚠ prod bug" if src == "production" else "⚠ UAT bug")
         if prior is None:
@@ -136,9 +175,10 @@ def main(argv):
         if len(argv) < 5:
             die("new needs \"<title>\" \"<acceptance>\"")
         title, acc = argv[3], argv[4]
+        cl = checklist(app, argv, ce)
         prefix = opt(argv, "--prefix", "FN").upper(); section = opt(argv, "--section"); ev = opt(argv, "--evidence")
         src = opt(argv, "--source", "owner"); mockup = opt(argv, "--mockup")
-        if prefix == "UI" and not mockup:
+        if prefix == "UI" and not mockup and cfg_project_type() not in ("library", "docs"):   # TrBlazeUI TF-003
             print("note: a UI row needs a mockup link; pass --mockup docs/mockups/<screen>.html or the checker will flag it")
         rid = ce.add_row(cl, prefix, title, acc, section=section, mockup=mockup,
                          remark=f"logged from {'production' if src == 'production' else 'UAT'} {ce.TODAY}" + (f" (evidence: {ev})" if ev else ""))
@@ -152,6 +192,7 @@ def main(argv):
         if len(argv) < 5:
             die("note needs <REQ> \"<text>\"")
         rid = argv[3].upper()
+        cl = checklist(app, argv, ce, rid)
         if ce.note(cl, rid, argv[4]) is None:
             die(f"{rid} is not a row of {cl}")
         log["actions"].append({"verb": "note", "req_id": rid, "symptom": argv[4], "ts": now})
@@ -162,9 +203,11 @@ def main(argv):
     if verb == "close":
         started = opt(argv, "--started") or subprocess.run(["bash", os.path.join(HERE, "tf-phase.sh"), "show"], capture_output=True, text=True).stdout
         if started.startswith("{"):
-            import re
-            m = re.search(r'"started":"([^"]*)"', started)
-            started = m.group(1) if m else ""
+            # the marker's own started, never its "outer" block's (TF-052 follow-up)
+            try:
+                started = (json.loads(started) or {}).get("started") or ""
+            except ValueError:
+                started = ""
         started = started.strip() if started and not started.startswith("none") else ""
         cmd = opt(argv, "--cmd", "triage-issues")
         # code untouched?
@@ -173,16 +216,25 @@ def main(argv):
             t0 = datetime.datetime.strptime(started, "%Y-%m-%dT%H:%M:%SZ").replace(tzinfo=datetime.timezone.utc).timestamp()
             for top in ("src", "source", "tests"):
                 for d, dirs, files in os.walk(top):
-                    dirs[:] = [x for x in dirs if x not in ("bin", "obj", "node_modules", ".artifacts", "TestResults")]
+                    # a running app's own log files are not code (AppManager TF-026)
+                    dirs[:] = [x for x in dirs if x not in ("bin", "obj", "node_modules", ".artifacts", "TestResults")
+                               and x.lower() not in ("logs", "log")]
                     for f in files:
+                        if f.lower().endswith(".log"):
+                            continue
                         p = os.path.join(d, f)
                         try:
                             if os.path.getmtime(p) > t0:
                                 changed.append(p.replace("\\", "/"))
                         except OSError:
                             pass
-        acts = [a for a in log.get("actions", []) if a["verb"] in ("demote", "new")]
+        # only this triage's actions: an earlier run's leftovers were logged again under today's run (TrBlazeUI TF-001)
+        stale = [a for a in log.get("actions", []) if started and (a.get("ts") or "") < started]
+        if stale:
+            print(f"  skipped {len(stale)} action(s) from before {started} — an earlier triage's, already closed or abandoned")
+        acts = [a for a in log.get("actions", []) if a["verb"] in ("demote", "new") and a not in stale]
         gates = misses = 0
+        failed = []
         for a in acts:
             rid = a["req_id"]; cls_req = rid.split("-")[1]
             att = q("--next-attempt", rid) or "1"
@@ -192,7 +244,9 @@ def main(argv):
                    "gate": "escaped", "gates_run": [], "failure_class": fc, "prior_verdict": a.get("prior")}
             if emit("gates", rec):
                 gates += 1
-            mc = ("unspecified-gap" if a["verb"] == "new" else "regression" if (a.get("prior") or "").lower().startswith("verified") else "wrong-behaviour")
+            else:
+                failed.append(a)
+            mc =("unspecified-gap" if a["verb"] == "new" else "regression" if (a.get("prior") or "").lower().startswith("verified") else "wrong-behaviour")
             opened = q("--open-miss", rid)
             if opened and opened.split()[-1] == mc:
                 print(f"  {rid}: already open as {opened.split()[0]} ({mc}); no second miss")
@@ -210,9 +264,11 @@ def main(argv):
             if emit("misses", m):
                 misses += 1
                 a["miss_id"] = mid
-        if changed and cmd == "triage-issues" and not log.get("code_miss_id"):
+            elif a not in failed:
+                failed.append(a)
+        if changed and cmd == "triage-issues" and log.get("code_miss_run") != started:
             mid = q("--next-miss-id")
-            log["code_miss_id"] = mid
+            log["code_miss_id"] = mid; log["code_miss_run"] = started
             emit("misses", {"kind": "miss", "miss_id": mid, "req_id": None, "req_class": None, "miss_class": "other", "artifact": "src",
                             "severity": "major", "why_missed": "instruction-ignored", "origin_phase": "triage-issues", "origin_agent": "flow-master",
                             "found_by": "gate", "found_phase": "triage-issues", "found_gate": None, "found_run_id": started, "failure_class": "other",
@@ -232,6 +288,7 @@ def main(argv):
         else:
             ok = None
         log["closed"] = now
+        log["actions"] = failed          # a closed action is never closed again; one whose record was refused waits for the next close
         log_save(log)
         print(f"triage: {len(acts)} row(s) logged — {gates} gate record(s) (escaped), {misses} miss(es)"
               + (f", run record {'written' if ok else 'not written'}" if ok is not None else "") + f"; code untouched: {'yes' if not changed else 'NO'}")

package/.tfcore/utils/tf-triage.sh

@@ -6,6 +6,8 @@
 #   bash .tfcore/utils/tf-triage.sh <App> note <REQ> "<could not reproduce: what was tried>"
 #   bash .tfcore/utils/tf-triage.sh <App> close [--started <ISO>] [--cmd triage-issues|fix-issues]
 #
+# demote, new and note take --phase N; without it a row of an earlier phase's checklist is found (TF-051).
+#
 # demote: Needs re-verify with a dated Remark in the reporter's words. new: a Not Started row with its
 # acceptance line and BRD-pending. note: a remark, no status change. close: the escaped gate records,
 # one miss per row (found by the owner, the symptom as `what`, duplicates collapsed), the run record,