@teamvibe/poller 0.8.8 → 0.8.9-rc.2

package/dist/slack-client.js

@@ -1,4 +1,4 @@
-import { WebClient } from '@slack/web-api';
+import { LogLevel, WebClient } from '@slack/web-api';
 import { logger } from './logger.js';
 import { emitError } from './event-queue.js';
 import { config } from './config.js';
@@ -6,6 +6,20 @@ import { config } from './config.js';
 const userCache = new Map();
 // Per-token Slack client cache
 const slackClients = new Map();
+const slackStatusClients = new Map();
+// tv#589 review: the SDK's own logger prints raw `response_metadata.messages`,
+// which can echo the status text (agent narration) on an API error. The
+// status client therefore gets a silent logger; application code owns the
+// redacted warnings in requestThreadStatus below.
+const silentSlackLogger = {
+    debug: () => { },
+    info: () => { },
+    warn: () => { },
+    error: () => { },
+    setLevel: () => { },
+    getLevel: () => LogLevel.ERROR,
+    setName: () => { },
+};
 // Slack: "must be less than 51 characters [json-pointer:/loading_messages/0]"
 const SLACK_LOADING_MESSAGE_MAX = 50;
 function getSlackClient(botToken) {
@@ -16,6 +30,21 @@ function getSlackClient(botToken) {
     }
     return client;
 }
+function getSlackStatusClient(botToken) {
+    let client = slackStatusClients.get(botToken);
+    if (!client) {
+        client = new WebClient(botToken, {
+            // The SDK passes timeout to Axios, which aborts the underlying HTTP request.
+            timeout: config.TYPING_STATUS_REQUEST_TIMEOUT_MS,
+            // Let the indicator recover immediately and own the single clear retry.
+            retryConfig: { retries: 0 },
+            rejectRateLimitedCalls: true,
+            logger: silentSlackLogger, // Never let the SDK echo status text; warnings are redacted below.
+        });
+        slackStatusClients.set(botToken, client);
+    }
+    return client;
+}
 export async function getUserInfo(botToken, userId) {
     const cached = userCache.get(userId);
     if (cached)
@@ -111,16 +140,29 @@ export async function addReaction(msg, emoji) {
     }
 }
 export async function setThreadStatus(msg, status) {
+    // Standalone callers retain best-effort delivery; indicators handle retries.
+    await requestThreadStatus(msg, status).catch(() => { });
+}
+async function requestThreadStatus(msg, status, onTimeout = () => logger.warn('Slack thread status request timed out')) {
     if (!msg.response_context.slack)
         return;
     const { channel, thread_ts } = msg.response_context.slack;
-    const slack = getSlackClient(msg.teamvibe.botToken);
+    const slack = getSlackStatusClient(msg.teamvibe.botToken);
     const safeStatus = neutralizeSlackMarkup(status);
     const payload = {
         channel_id: channel,
         thread_ts,
         status: safeStatus,
     };
+    const reportFailure = (error) => {
+        // WebClient wraps Axios errors in a WebAPIRequestError with the original attached.
+        const code = error?.original?.code ?? error?.code;
+        if (code === 'ECONNABORTED' || code === 'ETIMEDOUT')
+            onTimeout();
+        else
+            logger.warn('Failed to set thread status');
+        emitError('slack', 'Failed to set thread status', { severity: 'warn' });
+    };
     try {
         await slack.apiCall('assistant.threads.setStatus', {
             ...payload,
@@ -137,14 +179,14 @@ export async function setThreadStatus(msg, status) {
                 await slack.apiCall('assistant.threads.setStatus', payload);
                 return;
             }
-            catch {
-                emitError('slack', 'Failed to set thread status', { severity: 'warn' });
-                return;
+            catch (retryError) {
+                reportFailure(retryError);
+                throw retryError;
             }
         }
         // API errors may echo request fields; status can contain private narration.
-        logger.warn('Failed to set thread status');
-        emitError('slack', `Failed to set thread status`, { severity: 'warn' });
+        reportFailure(error);
+        throw error;
     }
 }
 function truncateLoadingMessage(text) {
@@ -176,9 +218,36 @@ export function startTypingIndicator(msg, statusText = 'Thinking...') {
         else
             logger.info(`[Typing] status -> ${source} (${status.length} chars)`);
     };
+    // Serialize all writes so an older request cannot land after a newer status.
+    let statusChain = Promise.resolve();
+    let pendingRequests = 0;
+    let timeoutWarned = false;
+    const warnTimeout = () => {
+        if (timeoutWarned)
+            return;
+        timeoutWarned = true;
+        logger.warn('Slack thread status request timed out');
+    };
+    const enqueueStatus = (text, retryClear = false) => {
+        pendingRequests++;
+        const request = statusChain.then(async () => {
+            try {
+                await requestThreadStatus(msg, text, warnTimeout);
+            }
+            catch (error) {
+                if (!retryClear)
+                    throw error;
+                await new Promise(resolve => setTimeout(resolve, 500));
+                await requestThreadStatus(msg, text, warnTimeout);
+            }
+        });
+        // Recover the chain so a failed write never blocks later writes or the clear.
+        statusChain = request.catch(() => { }).finally(() => { pendingRequests--; });
+        return request;
+    };
     // Set initial status
     logStatus(currentStatus, currentSource);
-    setThreadStatus(msg, currentStatus);
+    void enqueueStatus(currentStatus).catch(() => { });
     const cancelHold = () => {
         if (holdTimer !== undefined)
             clearTimeout(holdTimer);
@@ -190,17 +259,19 @@ export function startTypingIndicator(msg, statusText = 'Thinking...') {
         currentStatus = text;
         currentSource = text ? source : 'default';
         if (text && source === 'comment')
-            commentShownAt = Date.now();
+            commentShownAt = Date.now(); // Pre-existing enqueue-time hold, before successful display (#589 review P2-2).
         if (changed) {
             logStatus(text, source);
-            setThreadStatus(msg, text);
+            void enqueueStatus(text).catch(() => { });
         }
     };
     // Keepalive every 3 seconds (Slack clears after ~2 min timeout)
     let failures = 0;
     const interval = setInterval(async () => {
+        if (stopped || pendingRequests > 0)
+            return;
         try {
-            await setThreadStatus(msg, currentStatus);
+            await enqueueStatus(currentStatus);
             failures = 0;
         }
         catch {
@@ -211,6 +282,7 @@ export function startTypingIndicator(msg, statusText = 'Thinking...') {
         }
     }, 3000);
     return {
+        __flushForTest: () => statusChain,
         updateStatus: (newStatus, source = 'comment') => {
             if (stopped)
                 return;
@@ -244,7 +316,7 @@ export function startTypingIndicator(msg, statusText = 'Thinking...') {
             clearInterval(interval);
             if (currentStatus)
                 logStatus('', 'default');
-            setThreadStatus(msg, '');
+            void enqueueStatus('', true).catch(() => { });
         },
     };
 }

package/dist/thread-routing.d.ts

@@ -1,3 +1,4 @@
+import type { TeamVibeQueueMessage } from './types.js';
 export interface ThreadRouting {
     workspaceId: string;
     channelId: string;
@@ -6,6 +7,12 @@ export interface ThreadRouting {
     directory: string;
     threadId?: string;
     processedDropIds?: string[];
+    /** Original queue source; recovery must preserve its worktree isolation policy. */
+    source?: TeamVibeQueueMessage['source'];
+    /** Captured only from trusted queue input, never inbox drops or context files. */
+    responseContext?: {
+        slack: NonNullable<TeamVibeQueueMessage['response_context']['slack']>;
+    };
 }
 /** Poller state survives inbox pruning and process restarts; contains no credentials. */
 export declare function saveThreadRouting(threadId: string, routing: ThreadRouting): void;

package/dist/thread-routing.js

@@ -25,6 +25,13 @@ export function readThreadRouting(threadId) {
             return undefined;
         if (routing.processedDropIds !== undefined && (!Array.isArray(routing.processedDropIds) || !routing.processedDropIds.every((id) => typeof id === 'string')))
             return undefined;
+        if (routing.source !== undefined && !['slack', 'email', 'cron', 'maintenance', 'webhook'].includes(routing.source))
+            return undefined;
+        if (routing.responseContext !== undefined) {
+            const slack = routing.responseContext?.slack;
+            if (!slack || typeof slack.channel !== 'string' || !slack.channel || typeof slack.thread_ts !== 'string' || typeof slack.message_ts !== 'string')
+                return undefined;
+        }
         return routing;
     }
     catch {

package/npm-shrinkwrap.json

@@ -1,12 +1,12 @@
 {
   "name": "@teamvibe/poller",
-  "version": "0.8.8",
+  "version": "0.8.9-rc.2",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@teamvibe/poller",
-      "version": "0.8.8",
+      "version": "0.8.9-rc.2",
       "dependencies": {
         "@aws-sdk/client-dynamodb": "3.1108.0",
         "@aws-sdk/client-sqs": "3.1108.0",
@@ -15,6 +15,7 @@
         "@slack/web-api": "^7.0.0",
         "croner": "^10.0.1",
         "dotenv": "^17.2.3",
+        "yaml": "2.8.1",
         "zod": "^3.22.0"
       },
       "bin": {
@@ -1594,6 +1595,18 @@
       "integrity": "sha512-iwDZqg0QAGrg9Rav5H4n0M64c3mkR59cJ6wQp+7C4nI0gsmExaedaYLNO44eT4AtBBwjbTiGPMlt2Md0T9H9JQ==",
       "license": "MIT"
     },
+    "node_modules/yaml": {
+      "version": "2.8.1",
+      "resolved": "https://registry.npmjs.org/yaml/-/yaml-2.8.1.tgz",
+      "integrity": "sha512-lcYcMxX2PO9XMGvAJkJ3OsNMw+/7FKes7/hgerGUYWIoWu5j/+YQqcZr5JnPZWzOsEBgMbSbiSTn/dv/69Mkpw==",
+      "license": "ISC",
+      "bin": {
+        "yaml": "bin.mjs"
+      },
+      "engines": {
+        "node": ">= 14.6"
+      }
+    },
     "node_modules/zod": {
       "version": "3.25.76",
       "resolved": "https://registry.npmjs.org/zod/-/zod-3.25.76.tgz",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@teamvibe/poller",
-  "version": "0.8.8",
+  "version": "0.8.9-rc.2",
   "type": "module",
   "main": "./dist/index.js",
   "bin": {
@@ -34,6 +34,7 @@
     "@slack/web-api": "^7.0.0",
     "croner": "^10.0.1",
     "dotenv": "^17.2.3",
+    "yaml": "2.8.1",
     "zod": "^3.22.0"
   },
   "devDependencies": {