@teamvibe/poller 0.5.0 → 0.5.2

package/dist/claude-spawner.js

@@ -134,7 +134,7 @@ export async function buildContextHint(p) {
     if (!p.isFirstMessage && p.lastMessageTs && p.slack?.channel && p.slack?.thread_ts) {
         const newMessageCount = await p.countNewSinceTs(p.slack.channel, p.slack.thread_ts, p.lastMessageTs);
         return newMessageCount > 0
-            ? `**Resumed session:** ${newMessageCount} new message(s) in the thread since your last response. Consider using \`read_thread\` to see what was discussed before responding.`
+            ? `**Resumed session:** ${newMessageCount} new message(s) in the thread since your last response.\nCall \`read_thread\` first to load conversation context.`
             : `**Resumed session:** No new messages since your last response.`;
     }
     if (p.isFirstMessage &&
@@ -405,14 +405,22 @@ async function runClaudeCode(msg, sessionLog, cwd, sessionId, isFirstMessage = t
                 // Placed FIRST so subsequent spreads can overwrite. Belt-and-
                 // suspenders: even if the API's reserved-prefix validator fails
                 // (`AWS_`, `TEAMVIBE_`, `SLACK_`, `CLAUDE_CODE_`, `ANTHROPIC_`)
-                // a name collision is silently won by the platform variable.
+                // a name collision is silently won by the platform variable
+                // explicit field below.
+                //
+                // Phase 2 of teamvibe.ai#215 (poller v0.5.1): the explicit
+                // `SLACK_BOT_TOKEN: msg.teamvibe.botToken` injection that used
+                // to live here was removed. `SLACK_BOT_TOKEN` now sources from
+                // the `/secrets/spawn` platform overlay (the spread above) —
+                // backend v0.2.2+ resolves it via the `Channel → SlackBot`
+                // relation. Requires backend on Phase 1; pollers on 0.5.0 still
+                // read the explicit field, so split rollout is safe.
                 ...spawnSecrets.env.unwrap(),
                 ...process.env,
                 CLAUDECODE: undefined,
                 PATH: envPath,
                 CI: 'true',
                 CLAUDE_CONFIG_DIR: getBaseBrainPath(),
-                SLACK_BOT_TOKEN: msg.teamvibe.botToken,
                 ...(config.PERSISTENT_STORAGE_PATH && {
                     PERSISTENT_STORAGE_PATH: config.PERSISTENT_STORAGE_PATH,
                 }),

package/dist/cli/doctor.js

@@ -1,7 +1,7 @@
 import * as fs from 'fs';
 import * as path from 'path';
 import { execSync } from 'child_process';
-import { PLIST_PATH, SERVICE_LABEL, TEAMVIBE_DIR, LOGS_DIR, isContainerRuntime } from './plist.js';
+import { PLIST_PATH, SERVICE_LABEL, TEAMVIBE_DIR, LOGS_DIR, isContainerRuntime, plistHasStaleNodePath } from './plist.js';
 function ok(name, message) {
     return { name, status: 'ok', message };
 }
@@ -78,9 +78,46 @@ function checkLaunchdPlist() {
         if (content.includes('/_npx/')) {
             throw new Error('Plist references stale npx cache path. Run \'poller update\' to fix.');
         }
+        if (plistHasStaleNodePath(content)) {
+            throw new Error('Plist references brew Cellar Node path (e.g. /opt/homebrew/Cellar/node/<version>/bin/node). ' +
+                'This path disappears on `brew upgrade node`, causing launchd exit 78 (EX_CONFIG). ' +
+                'Run \'poller update\' to migrate to /usr/bin/env node.');
+        }
         return 'Installed with KeepAlive';
     });
 }
+/**
+ * Verify the binary referenced as the first ProgramArguments entry actually exists.
+ * Catches cases where launchd cannot spawn the program (manifesting as exit 78
+ * with no logs, since the process never ran).
+ */
+function checkPlistBinary() {
+    if (process.platform !== 'darwin')
+        return skipped('Plist binary', 'not macOS');
+    return check('Plist binary', () => {
+        if (!fs.existsSync(PLIST_PATH)) {
+            throw new Error(`Plist not found at ${PLIST_PATH}`);
+        }
+        const content = fs.readFileSync(PLIST_PATH, 'utf-8');
+        const argsMatch = content.match(/<key>ProgramArguments<\/key>\s*<array>([\s\S]*?)<\/array>/);
+        if (!argsMatch?.[1]) {
+            throw new Error('Plist has no ProgramArguments');
+        }
+        const firstArg = argsMatch[1].match(/<string>([^<]+)<\/string>/)?.[1];
+        if (!firstArg) {
+            throw new Error('Plist ProgramArguments is empty');
+        }
+        if (!path.isAbsolute(firstArg)) {
+            throw new Error(`Plist ProgramArguments[0] is not absolute: ${firstArg}`);
+        }
+        if (!fs.existsSync(firstArg)) {
+            throw new Error(`Plist references non-existent binary: ${firstArg}. ` +
+                'Likely cause: brew upgraded Node and the old Cellar path is gone. ' +
+                'Run \'poller update\' to regenerate plist with /usr/bin/env node.');
+        }
+        return firstArg;
+    });
+}
 function checkServiceRunning() {
     if (process.platform !== 'darwin')
         return skipped('Service status', 'not macOS');
@@ -184,6 +221,7 @@ export async function doctor() {
         checkTeamVibeDir(container),
         checkEnvFile(container),
         checkLaunchdPlist(),
+        checkPlistBinary(),
         checkServiceRunning(),
         checkLogsDir(container),
         checkClaudeCli(),

package/dist/cli/install.js

@@ -160,8 +160,8 @@ export async function install() {
     else {
         console.log(`  Found claude CLI at: ${claudePath}`);
     }
-    // Resolve node and poller paths
-    const nodePath = process.execPath;
+    // Resolve poller path. Node is resolved at runtime via /usr/bin/env from
+    // EnvironmentVariables.PATH below, so we do not pin a specific node binary.
     let pollerPath = path.resolve(process.argv[1] ?? '.');
     // Detect if running via npx (temporary cache path) — need a stable path for launchd
     const isNpx = pollerPath.includes('/_npx/') || pollerPath.includes('\\_npx\\');
@@ -188,8 +188,8 @@ export async function install() {
                 return;
         }
     }
-    console.log(`  Node path: ${nodePath}`);
     console.log(`  Poller path: ${pollerPath}`);
+    console.log(`  Node: resolved at runtime via /usr/bin/env from launchd PATH`);
     // Create directories
     fs.mkdirSync(TEAMVIBE_DIR, { recursive: true });
     fs.mkdirSync(LOGS_DIR, { recursive: true });
@@ -231,7 +231,7 @@ export async function install() {
         PATH: Array.from(pathDirs).join(':'),
     };
     // Write plist
-    const plistContent = generatePlist(nodePath, pollerPath, plistEnvVars);
+    const plistContent = generatePlist(pollerPath, plistEnvVars);
     const launchAgentsDir = path.dirname(PLIST_PATH);
     fs.mkdirSync(launchAgentsDir, { recursive: true });
     fs.writeFileSync(PLIST_PATH, plistContent);

package/dist/cli/plist.d.ts

@@ -7,4 +7,10 @@ export declare const LOGS_DIR: string;
  * In containers, env vars are injected directly — no ~/.teamvibe directory exists.
  */
 export declare function isContainerRuntime(): boolean;
-export declare function generatePlist(nodePath: string, pollerPath: string, envVars?: Record<string, string>): string;
+export declare function generatePlist(pollerPath: string, envVars?: Record<string, string>): string;
+/**
+ * Heuristic: does this plist content reference a Node binary path that can
+ * disappear on `brew upgrade node`? The legacy installer wrote
+ * /opt/homebrew/Cellar/node/<version>/bin/node directly into ProgramArguments.
+ */
+export declare function plistHasStaleNodePath(plistContent: string): boolean;

package/dist/cli/plist.js

@@ -22,7 +22,12 @@ export function isContainerRuntime() {
         return true;
     return false;
 }
-export function generatePlist(nodePath, pollerPath, envVars) {
+// `/usr/bin/env` is part of macOS base install and resolves `node` from
+// EnvironmentVariables.PATH. This avoids hardcoding a Node binary path that
+// can disappear after `brew upgrade node` (e.g. /opt/homebrew/Cellar/node/<version>/bin/node).
+const ENV_BIN = '/usr/bin/env';
+const NODE_BIN = 'node';
+export function generatePlist(pollerPath, envVars) {
     let envSection = '';
     if (envVars && Object.keys(envVars).length > 0) {
         const entries = Object.entries(envVars)
@@ -43,7 +48,8 @@ ${entries}
 
     <key>ProgramArguments</key>
     <array>
-        <string>${escapeXml(nodePath)}</string>
+        <string>${ENV_BIN}</string>
+        <string>${NODE_BIN}</string>
         <string>${escapeXml(pollerPath)}</string>
     </array>
 
@@ -68,6 +74,14 @@ ${entries}
 </plist>
 `;
 }
+/**
+ * Heuristic: does this plist content reference a Node binary path that can
+ * disappear on `brew upgrade node`? The legacy installer wrote
+ * /opt/homebrew/Cellar/node/<version>/bin/node directly into ProgramArguments.
+ */
+export function plistHasStaleNodePath(plistContent) {
+    return /\/Cellar\/node\/[^/<]+\/bin\/node/.test(plistContent);
+}
 function escapeXml(str) {
     return str
         .replace(/&/g, '&amp;')

package/dist/cli/update.js

@@ -1,6 +1,50 @@
 import * as fs from 'fs';
 import { execSync } from 'child_process';
-import { generatePlist, PLIST_PATH, SERVICE_LABEL } from './plist.js';
+import { generatePlist, plistHasStaleNodePath, PLIST_PATH, SERVICE_LABEL } from './plist.js';
+function parseEnvVars(plistContent) {
+    const envVars = {};
+    const envMatch = plistContent.match(/<key>EnvironmentVariables<\/key>\s*<dict>([\s\S]*?)<\/dict>/);
+    if (envMatch?.[1]) {
+        const pairs = envMatch[1].matchAll(/<key>(.*?)<\/key>\s*<string>(.*?)<\/string>/g);
+        for (const pair of pairs) {
+            envVars[pair[1]] = pair[2];
+        }
+    }
+    return envVars;
+}
+function resolveGlobalPollerPath() {
+    try {
+        const binPath = execSync('which poller', { encoding: 'utf-8' }).trim();
+        if (binPath)
+            return fs.realpathSync(binPath);
+    }
+    catch {
+        // Not in PATH
+    }
+    return null;
+}
+function regeneratePlist(reason) {
+    const plistContent = fs.readFileSync(PLIST_PATH, 'utf-8');
+    console.log(`\n${reason}, regenerating plist...`);
+    const globalPollerPath = resolveGlobalPollerPath();
+    if (!globalPollerPath) {
+        console.error('  Could not resolve global poller binary. Run: npm install -g @teamvibe/poller');
+        return false;
+    }
+    const envVars = parseEnvVars(plistContent);
+    // Ensure PATH covers common Node install locations so /usr/bin/env node resolves.
+    if (!envVars['PATH']) {
+        envVars['PATH'] = '/opt/homebrew/bin:/usr/local/bin:/usr/bin:/bin';
+    }
+    const newPlist = generatePlist(globalPollerPath, envVars);
+    try {
+        execSync(`launchctl unload "${PLIST_PATH}" 2>/dev/null`, { stdio: 'ignore' });
+    }
+    catch { /* ignore */ }
+    fs.writeFileSync(PLIST_PATH, newPlist);
+    console.log(`  Updated plist; poller binary: ${globalPollerPath}`);
+    return true;
+}
 export function update() {
     console.log('TeamVibe Poller - Update\n');
     console.log('Updating @teamvibe/poller...');
@@ -11,66 +55,30 @@ export function update() {
         console.error('Failed to update. Try running: npm install -g @teamvibe/poller@latest');
         process.exit(1);
     }
-    // Fix plist if it points to a stale npx cache path
-    if (process.platform === 'darwin' && fs.existsSync(PLIST_PATH)) {
-        const plistContent = fs.readFileSync(PLIST_PATH, 'utf-8');
-        if (plistContent.includes('/_npx/')) {
-            console.log('\nDetected stale npx path in service plist, fixing...');
-            // Resolve the globally installed poller path
-            let globalPollerPath = '';
-            try {
-                const binPath = execSync('which poller', { encoding: 'utf-8' }).trim();
-                if (binPath) {
-                    globalPollerPath = fs.realpathSync(binPath);
-                }
-            }
-            catch {
-                // Fall back to current process
-            }
-            if (globalPollerPath) {
-                // Extract existing env vars from plist
-                const envVars = {};
-                const envMatch = plistContent.match(/<key>EnvironmentVariables<\/key>\s*<dict>([\s\S]*?)<\/dict>/);
-                if (envMatch) {
-                    const pairs = envMatch[1].matchAll(/<key>(.*?)<\/key>\s*<string>(.*?)<\/string>/g);
-                    for (const pair of pairs) {
-                        envVars[pair[1]] = pair[2];
-                    }
-                }
-                const nodePath = process.execPath;
-                const newPlist = generatePlist(nodePath, globalPollerPath, envVars);
-                // Unload, write, reload
-                try {
-                    execSync(`launchctl unload "${PLIST_PATH}" 2>/dev/null`, { stdio: 'ignore' });
-                }
-                catch { /* ignore */ }
-                fs.writeFileSync(PLIST_PATH, newPlist);
-                console.log(`Updated plist to use: ${globalPollerPath}`);
-                try {
-                    execSync(`launchctl load "${PLIST_PATH}"`);
-                    console.log('Service restarted.');
-                }
-                catch (error) {
-                    console.error(`Failed to restart: ${error instanceof Error ? error.message : error}`);
-                }
-                return;
-            }
-        }
-        // Normal restart (no npx fix needed)
-        console.log(`\nRestarting service '${SERVICE_LABEL}'...`);
-        try {
-            execSync(`launchctl unload "${PLIST_PATH}" 2>/dev/null`, { stdio: 'ignore' });
-        }
-        catch { /* ignore */ }
-        try {
-            execSync(`launchctl load "${PLIST_PATH}"`);
-            console.log('Service restarted.');
-        }
-        catch (error) {
-            console.error(`Failed to restart: ${error instanceof Error ? error.message : error}`);
-        }
-    }
-    else {
+    if (process.platform !== 'darwin' || !fs.existsSync(PLIST_PATH)) {
         console.log('\nUpdate complete. Restart the poller to use the new version.');
+        return;
+    }
+    const plistContent = fs.readFileSync(PLIST_PATH, 'utf-8');
+    const hasNpxPath = plistContent.includes('/_npx/');
+    const hasStaleNode = plistHasStaleNodePath(plistContent);
+    if (hasNpxPath || hasStaleNode) {
+        const reason = hasNpxPath
+            ? 'Detected stale npx path in service plist'
+            : 'Detected hardcoded brew Cellar Node path in service plist (will break on `brew upgrade node`)';
+        if (!regeneratePlist(reason))
+            return;
+    }
+    console.log(`\nRestarting service '${SERVICE_LABEL}'...`);
+    try {
+        execSync(`launchctl unload "${PLIST_PATH}" 2>/dev/null`, { stdio: 'ignore' });
+    }
+    catch { /* ignore */ }
+    try {
+        execSync(`launchctl load "${PLIST_PATH}"`);
+        console.log('Service restarted.');
+    }
+    catch (error) {
+        console.error(`Failed to restart: ${error instanceof Error ? error.message : error}`);
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@teamvibe/poller",
-  "version": "0.5.0",
+  "version": "0.5.2",
   "type": "module",
   "main": "./dist/index.js",
   "bin": {