@teamscala/service-boot 0.23.539 → 0.23.541

package/src/ui-service.ts

@@ -6,8 +6,10 @@
 import { recordEventDurable } from "@teamscala/event-log/record-event";
 import { getAppLogger } from "@teamscala/logger/app-loggers";
 import { BootFatalError } from "@teamscala/os/errors/boot-error";
-import { Hono } from "hono";
+import type { Hono } from "hono";
+import { createBootShellApp } from "./boot-shell.ts";
 import type { ServiceInstallConfig } from "./load-service-install-row.ts";
+import { swapApp } from "./mutable-app-ref.ts";
 import { setReady } from "./readiness-gate.ts";
 import { resolveServicePort } from "./resolve-service-port.ts";
 import { buildMinimalApp } from "./two-phase-minimal-app.ts";
@@ -42,14 +44,6 @@ export async function bootUiService(
 	const log = getAppLogger();
 	const startTime = Date.now();
 
-	const minimalAppResult = await buildMinimalApp(
-		config,
-		serviceSlug,
-		databaseUrl,
-		deps.upgradeWebSocket!,
-		deps.getSharedDb,
-	);
-
 	const isRailway = Boolean(process.env.RAILWAY_ENVIRONMENT);
 	const envPort = process.env.PORT ? Number(process.env.PORT) : undefined;
 	const declaredAppPort = config.app_port ?? config.port;
@@ -73,19 +67,44 @@ export async function bootUiService(
 	}
 	const port = requireValidPort(resolution.port, serviceSlug);
 
-	const minimalReadyTime = Date.now();
-	const minimalDuration = minimalReadyTime - startTime;
-	log.info(
-		`[ui-service-boot:${serviceSlug}] Minimal app composed on port ${port} in ${minimalDuration}ms`,
-	);
-
-	setReady();
+	const shell = createBootShellApp(serviceSlug);
 	log.info(
-		`[ui-service-boot:${serviceSlug}] Ready gate flipped - MCP tools can now connect (full app building in background)`,
+		`[ui-service-boot:${serviceSlug}] Bind-first boot shell composed — the port answers before the mount chain runs`,
 	);
 
-	;(async () => {
+	void (async () => {
+		let phase: "phase-1" | "phase-2" = "phase-1";
+		let minimalDuration = 0;
 		try {
+			const PHASE1_TIMEOUT_MS = 120_000;
+			const minimalAppResult = await Promise.race([
+				buildMinimalApp(
+					config,
+					serviceSlug,
+					databaseUrl,
+					deps.upgradeWebSocket!,
+					deps.getSharedDb,
+				),
+				new Promise<never>((_, reject) =>
+					setTimeout(
+						() => reject(new Error(`buildMinimalApp timed out after ${PHASE1_TIMEOUT_MS / 1000}s — phase 1 hung silently, see step logs`)),
+						PHASE1_TIMEOUT_MS,
+					),
+				),
+			]);
+
+			swapApp(minimalAppResult.app, "minimal");
+			minimalDuration = Date.now() - startTime;
+			log.info(
+				`[ui-service-boot:${serviceSlug}] Minimal app composed on port ${port} in ${minimalDuration}ms`,
+			);
+
+			setReady();
+			log.info(
+				`[ui-service-boot:${serviceSlug}] Ready gate flipped - MCP tools can now connect (full app building in background)`,
+			);
+
+			phase = "phase-2";
 			const PHASE2_TIMEOUT_MS = 120_000;
 			const fullAppResult = await Promise.race([
 				buildFullApp(minimalAppResult, deps),
@@ -101,18 +120,31 @@ export async function bootUiService(
 
 			swapToFullApp(fullAppResult.app, serviceSlug);
 
+			if (fullAppResult.clientBuildFailed !== undefined) {
+				log.error(
+					`[ui-service-boot:${serviceSlug}] Full app swapped in after ${fullDuration}ms with NO servable client build — the process stays up serving API, MCP and jobs; pages answer the branded holding page and /health reports degraded. buildFullApp recorded boot.client-build-failed with the reason.`,
+				);
+				return;
+			}
+
 			log.info(
 				`[ui-service-boot:${serviceSlug}] Full app swapped in after ${fullDuration}ms (${fullDuration - minimalDuration}ms after minimal app)`,
 			);
 		} catch (err) {
 			const message = err instanceof Error ? err.message : String(err);
-			log.error(
-				`[ui-service-boot:${serviceSlug}] Phase-2 boot failed — exiting so the supervisor restarts a service that serves a fresh client build: ${message}`,
-			);
+			if (phase === "phase-1") {
+				log.error(
+					`[ui-service-boot:${serviceSlug}] Phase-1 boot failed — exiting so the supervisor restarts a service whose mount chain did not complete: ${message}`,
+				);
+			} else {
+				log.error(
+					`[ui-service-boot:${serviceSlug}] Phase-2 boot failed — exiting so the supervisor restarts a service that serves a fresh client build: ${message}`,
+				);
+			}
 			await recordEventDurable({
 				id: crypto.randomUUID(),
 				kind: "service.boot.failed",
-				payload: { service_slug: serviceSlug, phase: "phase-2", message: message.slice(0, 2000) },
+				payload: { service_slug: serviceSlug, phase, message: message.slice(0, 2000) },
 				occurredAt: new Date(),
 			});
 			process.exit(1);
@@ -124,7 +156,7 @@ export async function bootUiService(
 		blocks: [],
 		routes: [],
 		port,
-		app: minimalAppResult.app,
+		app: shell,
 	};
 }
 

package/src/ws-boot-self-test.test.ts

@@ -1,10 +1,10 @@
 /**
  * @status generated — ts-api-smoke template (scala-test-suites
- * templates/ts_api_smoke.pkl @1.3.0) over the exports map of @teamscala/service-boot.
- * ./ws-boot-self-test declares 1 runtime export(s) and 3 declared behaviour vector(s);
+ * templates/ts_api_smoke.pkl @1.5.0) over the exports map of @teamscala/service-boot.
+ * ./ws-boot-self-test declares 1 runtime export(s) and 4 declared behaviour vector(s);
  * this suite asserts the import resolves, the runtime surface matches
  * exactly, and every export carries its declared kind. Regenerate from
- * inputs/server-service-boot-ts/api_smoke.json (scala-test-suites) — hand edits are
+ * inputs/bun-server-service-boot/api_smoke.json (scala-test-suites) — hand edits are
  * overwritten.
  */
 
@@ -24,20 +24,27 @@ describe("ws-boot-self-test exports-map smoke", () => {
 		expect(typeof mod["runWsBootSelfTest"]).toBe("function");
 	});
 	it("no declared websocket routes resolves without connecting", async () => {
-		const got = await runWsBootSelfTest({ websocket_routes: [] } as never, "svc-ws", 59999);
+		const got = await runWsBootSelfTest({ websocket_routes: [] } as never, "svc-ws", 59999)
 		expect(got).toBeUndefined();
 	});
 	it("a route whose server upgrades resolves 101", async () => {
 		const server = Bun.serve({ port: 0, fetch(req, srv) { if (!srv.upgrade(req)) return new Response("no upgrade", { status: 401 }); }, websocket: { open() {}, message() {} } });
 		const port = server.port as number;
-		const got = await runWsBootSelfTest({ websocket_routes: [{ path: "/ws-boot-self-test" }] } as never, "svc-ws", port);
+		const got = await runWsBootSelfTest({ websocket_routes: [{ path: "/ws-boot-self-test" }] } as never, "svc-ws", port)
+server.stop(true);
 		expect(got).toBeUndefined();
-		server.stop(true);
 	});
-	it("a route nobody listens on fails boot loudly, naming the path", async () => {
+	it("a route nobody listens on fails boot loudly, naming the path [toBeNull]", async () => {
 		let thrown: unknown = null;
 		try { await runWsBootSelfTest({ websocket_routes: [{ path: "/ws-boot-self-test-dead" }] } as never, "svc-ws", 59987); } catch (err) { thrown = err; }
 		expect(thrown).not.toBeNull();
-		expect(String(thrown)).toContain("/ws-boot-self-test-dead");
+		expect(thrown).not.toBeUndefined();
+	});
+	it("a route nobody listens on fails boot loudly, naming the path [toContain]", async () => {
+		let thrown: unknown = null;
+		try { await runWsBootSelfTest({ websocket_routes: [{ path: "/ws-boot-self-test-dead" }] } as never, "svc-ws", 59987); } catch (err) { thrown = err; }
+const got = (String(thrown));
+		const __t0_0 = got;
+		expect(typeof __t0_0 === "string" ? __t0_0 : JSON.stringify(__t0_0)).toContain("/ws-boot-self-test-dead");
 	});
 });