@teamscala/service-boot 0.23.535 → 0.23.537

package/src/build-client-assets.ts

@@ -3,30 +3,13 @@
  * @status handwritten
  */
 
-	// Each build is wrapped in its own catch so a JS bundle failure (e.g. transient cross-package export drift) doesn't take down the service
-	// boot — SSR can still serve HTML; only client interactivity degrades. No fallback path for failed bundle builds — per `no-shims`, never write a
-	// manifest entry that points at a file we don't actually serve. If a build fails, write a TOMBSTONE manifest (no-silent-reverts) and throw.
-	//
-	// The tombstone preserves the LAST-SUCCESSFUL paths so SSR can keep serving the old bundle (better than a 404 hydrate), but marks itself
-	// `buildFailed: true` + the error + `failedAt`, AND — because every boot
-	// now rebuilds unconditionally — the failure is retried by construction;
-	// the tombstone is the on-disk failure signal; ui-service-boot adds the
-	// runtime signal (recordEvent → event-log → GlitchTip) and read-html-template stamps the
-	// served HTML with the failure status. Without the tombstone, a build failure left the OLD manifest untouched and the dashboard served stale
-	// code with NO signal that the published fix never reached the bundle (scala-agents 2026-07-18: ui-foundation@3.4.5 installed but the bundle
-	// kept serving the old bytes across restarts while node_modules was mid-install — invisible until the operator hit the white-on-white
-	// toolbar regression the fix was supposed to close).
-
-import { mkdir } from "node:fs/promises";
+import { mkdir, rm } from "node:fs/promises";
 import { join } from "node:path";
 import { withFileLock } from "@teamscala/file-lock/with-lock";
 import { getAppLogger } from "@teamscala/logger/app-loggers";
 import { CLIENT_BUILD_LOCK, getClientBuildLockTimeoutMs } from "./build-client-assets/build-lock.ts";
 import { buildHydrateBundle } from "./build-client-assets/hydrate-bundle.ts";
-import {
-	readManifest,
-	writeManifest,
-} from "./build-client-assets/manifest.ts";
+import { MANIFEST_FILE, writeManifest } from "./build-client-assets/manifest.ts";
 import { buildTailwindCss } from "./build-client-assets/styles-build.ts";
 
 export async function buildClientAssets(serviceSlug: string): Promise<void> {
@@ -34,12 +17,6 @@ export async function buildClientAssets(serviceSlug: string): Promise<void> {
 	const cwd = process.cwd();
 	const outDir = join(cwd, "dist", "client");
 
-	// Serialise the build across every UI service on this host
-	// (client-asset-builds-serialize-via-lock) so a publish-driven restart storm
-	// becomes a short queue instead of N concurrent host-saturating builds. The
-	// lock FAILS OPEN: a lock-acquisition timeout builds unlocked rather than blocking
-	// boot. A real build failure inside performBuild throws and propagates (the
-	// service refuses to start); only the file-lock timeout falls through.
 	const lockTimeoutMs = await getClientBuildLockTimeoutMs();
 	try {
 		await withFileLock(
@@ -67,31 +44,17 @@ async function performBuild(
 ): Promise<void> {
 	const t0 = Date.now();
 
-	const existingManifest = await readManifest(outDir);
+	await rm(join(outDir, MANIFEST_FILE), { force: true });
+
 	const writeTombstone = async (reason: string): Promise<void> => {
 		try {
 			await mkdir(outDir, { recursive: true });
 			await writeManifest(outDir, {
-				// NO invented paths: when a prior successful build exists its real
-				// paths are preserved (SSR keeps serving the prior bundle — degraded
-				// but coherent); when none exists the tombstone carries NO asset
-				// paths at all. Writing the unhashed build names here was the last
-				// remnant of the deleted fallback class — paths that name files
-				// nothing built must not exist on disk any more than in served HTML.
-				// A path-less tombstone reads as unbuilt everywhere (readManifest →
-				// null → verification refuses → readiness never flips), and its
-				// buildFailedReason below is the operator's diagnostic — the failure
-				// is read via readClientBuildStatus, which never needed the paths.
-				...(existingManifest?.stylesPath && existingManifest?.hydratePath
-					? { stylesPath: existingManifest.stylesPath, hydratePath: existingManifest.hydratePath }
-					: {}),
 				buildFailed: true,
 				buildFailedReason: reason.slice(0, 2000),
 				buildFailedAt: new Date().toISOString(),
 			});
 		} catch (tombstoneErr) {
-			// Best-effort: if even the tombstone write fails (read-only FS,
-			// full disk), the throw below still propagates the build failure.
 			log.warn(
 				`[build-client-assets:${serviceSlug}] failed to write failure tombstone (build error still propagates)`,
 				{ tombstoneError: tombstoneErr instanceof Error ? tombstoneErr.message : String(tombstoneErr) },
@@ -115,8 +78,8 @@ async function performBuild(
 		const reason = hydrateResult.reason instanceof Error ? hydrateResult.reason.message : String(hydrateResult.reason);
 		await writeTombstone(`hydrate build failed: ${reason}`);
 		throw new Error(
-			`[build-client-assets:${serviceSlug}] hydrate bundle build failed — tombstone manifest written (SSR serves the prior bundle; client build will retry next boot). ` +
-				`Fix the underlying import/resolution errors and restart. Original: ${reason}`,
+			`[build-client-assets:${serviceSlug}] hydrate bundle build failed — no servable client build exists. ` +
+				`Fix the underlying import/resolution errors and redeploy. Original: ${reason}`,
 		);
 	}
 	if (stylesResult.status === "rejected") {
@@ -127,8 +90,8 @@ async function performBuild(
 		const reason = stylesResult.reason instanceof Error ? stylesResult.reason.message : String(stylesResult.reason);
 		await writeTombstone(`styles build failed: ${reason}`);
 		throw new Error(
-			`[build-client-assets:${serviceSlug}] styles bundle build failed — tombstone manifest written (SSR serves the prior bundle; client build will retry next boot). ` +
-				`Fix the underlying tailwind/CSS errors and restart. Original: ${reason}`,
+			`[build-client-assets:${serviceSlug}] styles bundle build failed — no servable client build exists. ` +
+				`Fix the underlying tailwind/CSS errors and redeploy. Original: ${reason}`,
 		);
 	}
 
@@ -138,7 +101,7 @@ async function performBuild(
 		const reason = `bundle build returned empty path (hydrate=${hydrate?.hydratePath ?? "<null>"}, styles=${stylesPath})`;
 		await writeTombstone(reason);
 		throw new Error(
-			`[build-client-assets:${serviceSlug}] ${reason} — tombstone manifest written.`,
+			`[build-client-assets:${serviceSlug}] ${reason} — no servable client build exists.`,
 		);
 	}
 

package/src/load-service-install-row.ts

@@ -13,7 +13,7 @@ import {
 	enforceExplicitRenderMode,
 	ServiceInstallConfigSchema,
 	ServiceInstallValidationError,
-} from "@teamscala/db-validation/registry-schemas/service-install";
+} from "@teamscala/registry-schemas/registry-schemas/service-install";
 import * as v from "valibot";
 
 const BOOT_ROW_KEYS = [

package/src/mount-server-packages.ts

@@ -58,10 +58,6 @@ export async function mountServerPackages(
 	const mountRegistry = createMountRegistry();
 	const mountCtx = createMountContext(serviceSlug, config, app, mountRegistry, getSharedDb);
 	const serverPackages = (config.server_packages ?? []) as string[];
-	/** Packages that loaded but whose mount threw — unavailable, not fatal.
-	 *  Named in the summary so a degraded boot is legible without grepping for
-	 *  the per-package error line. */
-	const degraded: string[] = [];
 
 	if (serverPackages.length === 0) {
 		log.info(`[scala-install:${serviceSlug}] No server_packages declared`);
@@ -119,10 +115,11 @@ export async function mountServerPackages(
 			}
 		} catch (err) {
 			if (err instanceof BootFatalError) throw err;
-			degraded.push(pkg);
-			log.error(
-				`[scala-install:${serviceSlug}] server_package "${pkg}" UNAVAILABLE — mount failed; ` +
-					`the service continues without it: ${err instanceof Error ? err.message : err}`,
+			throw new BootFatalError(
+				"mount-server-packages",
+				serviceSlug,
+				`server_package "${pkg}" mount failed: ${err instanceof Error ? err.message : err}`,
+				err,
 			);
 		}
 	}
@@ -130,10 +127,7 @@ export async function mountServerPackages(
 	log.info(
 		`[scala-install:${serviceSlug}] Registered ${mountRegistry.handlers.size} handler(s), ` +
 			`${mountRegistry.wsRoutes.size} ws route(s), ` +
-			`${mountRegistry.bootHooks.size} boot hook(s)` +
-			(degraded.length > 0
-				? `, ${degraded.length} server_package(s) UNAVAILABLE: ${degraded.join(", ")}`
-				: ""),
+			`${mountRegistry.bootHooks.size} boot hook(s)`,
 	);
 
 	return mountRegistry;

package/src/orpc-contract-rows.json

@@ -452,6 +452,7 @@
       "note": "The html text claims (absent Take me home, present no-page-at-this-link) stay hand-written: then-step expects carry structural verbs only.",
       "then": [
         {
+          "args": [],
           "call": "text"
         }
       ],
@@ -480,6 +481,7 @@
       "note": "The html text claims (Take me home, doesn't exist, href, noindex) stay hand-written: the text lives behind the async Response.text() member call, and then-step expects carry the structural verbs only, so no row can read the body. The then step here proves text() resolves.",
       "then": [
         {
+          "args": [],
           "call": "text"
         }
       ],
@@ -509,6 +511,7 @@
       "note": "The html text claims stay hand-written: then-step expects carry structural verbs only (no contains_text), so no row can read the async body.",
       "then": [
         {
+          "args": [],
           "call": "text"
         }
       ],
@@ -537,6 +540,7 @@
       "note": "The html copy claims stay hand-written: async body, structural then-steps only.",
       "then": [
         {
+          "args": [],
           "call": "text"
         }
       ],
@@ -562,6 +566,7 @@
       "note": "The html copy claims stay hand-written: async body, structural then-steps only.",
       "then": [
         {
+          "args": [],
           "call": "text"
         }
       ],
@@ -585,6 +590,7 @@
       "note": "The html copy claims stay hand-written: async body, structural then-steps only.",
       "then": [
         {
+          "args": [],
           "call": "text"
         }
       ],
@@ -627,6 +633,7 @@
           "expect": null
         },
         {
+          "args": [],
           "call": "text"
         }
       ],
@@ -685,6 +692,7 @@
           "expect": "no-store, no-transform"
         },
         {
+          "args": [],
           "call": "text"
         }
       ],
@@ -1522,6 +1530,7 @@
       "slug": "service-boot:extract-org-id-from-callback-path-scala-projects-single-uuid-shape-segment-0"
     },
     {
+      "args": [],
       "note": "The generated router shape is what matters, not mere key presence.",
       "hoist": [
         {
@@ -1554,6 +1563,7 @@
       "slug": "service-boot:get-server-client-capability-fault-a-model-present-without-findfirst-still-counts-as-missing"
     },
     {
+      "args": [],
       "note": "Daemon/portal shells own no DB schema and are healthy with an empty client.",
       "hoist": [
         {
@@ -1580,6 +1590,7 @@
       "slug": "service-boot:get-server-client-capability-fault-a-service-declaring-no-models-is-never-faulted"
     },
     {
+      "args": [],
       "hoist": [
         {
           "args": [
@@ -1609,6 +1620,7 @@
       "slug": "service-boot:get-server-client-capability-fault-an-unregistered-client-is-itself-the-fault"
     },
     {
+      "args": [],
       "note": "THE OUTAGE, AS A HEALTH ANSWER. A client was registered and carried only the platform routers, so every process-existence signal was green while every data-backed page 500d. /health must be able to say this.",
       "hoist": [
         {
@@ -1644,6 +1656,7 @@
       "slug": "service-boot:get-server-client-capability-fault-names-the-models-the-client-cannot-serve"
     },
     {
+      "args": [],
       "hoist": [
         {
           "args": [
@@ -1685,6 +1698,7 @@
       "slug": "service-boot:get-server-client-capability-fault-no-fault-when-every-declared-model-is-servable"
     },
     {
+      "args": [],
       "note": "The band asserts reference identity (toBe) across two calls; the row spells the shape that comes back, since the runner names no cross-call reference. The single module slot is the mechanism that makes them the same object.",
       "hoist": [
         {
@@ -1715,6 +1729,7 @@
       "slug": "service-boot:get-server-client-returns-the-registered-client-once-boot-sets-one"
     },
     {
+      "args": [],
       "note": "The old fallback returned a truthy client, so callers could not tell registration had never happened. Both band spellings (the no-registration message and the registerPageServerClient naming) are declared as the substrings the rejection must carry.",
       "hoist": [
         {
@@ -1895,15 +1910,8 @@
       "slug": "service-boot:is-module-not-found-treats-an-unexported-subpath-as-not-found"
     },
     {
-      "hoist": [
-        {
-          "args": [
-            null
-          ],
-          "export": "setServerClient"
-        }
-      ],
-      "label": "isServerClientRegistered tracks registration state (unregistered)",
+      "args": [],
+      "label": "isServerClientRegistered is false in a process where boot has not registered a client — the module's own initial state, so the row needs no setup",
       "expect": false,
       "export": "isServerClientRegistered",
       "module": "src/page-server-orpc/server-client.ts",
@@ -1912,6 +1920,7 @@
       "slug": "service-boot:is-server-client-registered-is-false-before-boot-registers"
     },
     {
+      "args": [],
       "hoist": [
         {
           "args": [
@@ -2174,7 +2183,7 @@
       "expect": {
         "member_equals": {
           "title": "scala-quiz oRPC procedures",
-          "servers.0.url": "http://localhost/api/rpc"
+          "servers.0.url": "http://localhost/api/openapi"
         }
       },
       "export": "openApiContractOptions",
@@ -2193,7 +2202,7 @@
       "expect": {
         "member_equals": {
           "title": "scala-portal oRPC procedures",
-          "servers.0.url": "http://scala-portal.internal:5200/api/rpc"
+          "servers.0.url": "http://scala-portal.internal:5200/api/openapi"
         }
       },
       "export": "openApiContractOptions",
@@ -2636,8 +2645,7 @@
         "website": {
           "name": "launcha Website",
           "slug": "launcha-website",
-          "header_settings": null,
-          "organisation_id": null
+          "header_settings": null
         },
         "puckData": {
           "root": {
@@ -2658,8 +2666,7 @@
           },
           "brand": {
             "companyName": "GMG APAC",
-            "primaryColor": "#FF4500",
-            "companyFriendlyName": null
+            "primaryColor": "#FF4500"
           },
           "website": {
             "name": "launcha Website",
@@ -3319,7 +3326,12 @@
         3021
       ],
       "label": "an unparseable or out-of-range PORT never displaces a valid row (resolvedPort narrowing: 0)",
-      "expect": 3021,
+      "expect": {
+        "member_equals": {
+          "port": 3021,
+          "source": "service_routing"
+        }
+      },
       "export": "resolveServicePort",
       "module": "src/resolve-service-port.ts",
       "package": "@teamscala/service-boot",
@@ -3348,7 +3360,12 @@
         3021
       ],
       "label": "an unparseable or out-of-range PORT never displaces a valid row (resolvedPort narrowing: 70000)",
-      "expect": 3021,
+      "expect": {
+        "member_equals": {
+          "port": 3021,
+          "source": "service_routing"
+        }
+      },
       "export": "resolveServicePort",
       "module": "src/resolve-service-port.ts",
       "package": "@teamscala/service-boot",