@teamscala/service-boot 0.23.516 → 0.23.518

package/src/handlers/registry-stale-inactive-sweep.ts

@@ -1,82 +0,0 @@
-/**
- * @system server-boot
- * @status handwritten
- * @edit edit directly
- *
- * The `registry-stale-inactive-sweep` pg-boss handler. Surfaces registry
- * rows that have been inactive beyond a threshold with no deliberate-pause
- * metadata — the "deactivated and forgotten" class that caused the
- * fleet_agent_slots miscount (operator directive 2026-07-20).
- *
- * This is a MONITOR (detection), not enforcement: it records an event_log
- * entry so the operator sees stale rows accumulate, but never blocks or
- * auto-reaps. The structural prevention is the `deactivated_at` stamp the
- * registry_edit deactivate path writes; this sweep is the detection
- * backstop that surfaces rows whose `updated_at` (the deactivation
- * timestamp) has aged past the threshold.
- *
- * Excluded from the sweep (deliberate deactivation — NOT stale):
- * - config.pause_owner / config.reactivate_when (progressive-activation paused guards)
- * - config.operator_deactivated = true (operator emergency off)
- *
- * Registered under slug `@teamscala/service-boot:registry-stale-inactive-sweep`.
- */
-import type { ScheduledJobConfig } from "@teamscala/db-validation/registry-schemas/scheduled-job";
-import { getPrisma } from "@teamscala/db/prisma-registry";
-import { recordEvent } from "@teamscala/event-log/record-event";
-import { getAppLogger } from "@teamscala/logger/app-loggers";
-import { pgBossHandlerRegistry } from "../pg-boss-handler-registry.ts";
-
-const STALE_AFTER_DAYS = 30;
-const SAMPLE_LIMIT = 20;
-
-interface StaleRow {
-	type: string;
-	slug: string;
-	updated_at: Date;
-}
-
-async function registryStaleInactiveSweep(): Promise<void> {
-	const log = getAppLogger();
-	const prisma = getPrisma();
-
-	const rows = await prisma.$queryRawUnsafe<StaleRow[]>(`
-		SELECT type, slug, updated_at
-		FROM registry_entries
-		WHERE is_active = false
-			AND updated_at < NOW() - INTERVAL '${STALE_AFTER_DAYS} days'
-			AND NOT (config ? 'pause_owner')
-			AND NOT (config ? 'reactivate_when')
-			AND NOT (config->>'operator_deactivated' = 'true')
-		ORDER BY updated_at ASC
-	`);
-
-	const byType = new Map<string, number>();
-	for (const r of rows) {
-		byType.set(r.type, (byType.get(r.type) ?? 0) + 1);
-	}
-
-	const samples = rows
-		.slice(0, SAMPLE_LIMIT)
-		.map((r) => `${r.type}/${r.slug}(${r.updated_at.toISOString().slice(0, 10)})`);
-
-	recordEvent({
-		kind: "registry.stale-inactive.detected",
-		payload: {
-			totalStale: rows.length,
-			staleAfterDays: STALE_AFTER_DAYS,
-			byType: Object.fromEntries(byType),
-			samples,
-		},
-	});
-
-	log.info(
-		`[registry-stale-inactive-sweep] ${rows.length} stale inactive row(s) (>${STALE_AFTER_DAYS}d, no pause metadata) — recorded to event_log`,
-		{ byType: Object.fromEntries(byType), samples },
-	);
-}
-
-pgBossHandlerRegistry.register(
-	"@teamscala/service-boot:registry-stale-inactive-sweep",
-	registryStaleInactiveSweep as (ctx: { config: ScheduledJobConfig }) => Promise<void>,
-);

package/src/handlers/scala-tools-currency-watch.test.ts

@@ -1,65 +0,0 @@
-// @system codegen
-// @status generated
-// @edit change the suite in the owned-suites band, then re-run codegen. Hand-edits are overwritten.
-//
-// This suite's assertions are OWNED by the codegen band: the band module
-// carries them verbatim, this file is the emission, and hand edits here are
-// overwritten on the next run. The rationale each assertion carries moved
-// with it into the band.
-
-import { describe, expect, test } from "bun:test";
-import { join } from "node:path";
-
-/**
- * Regression lock: this watch must never restart scala-sentinel again.
- *
- * It used to reinstall @teamscala/scala-tools and then `pm2 restart scala-sentinel`
- * "so the fresh scala-tools loads". That premise is false for this package —
- * sentinel SPAWNS `node_modules/.bin/scala-tools` per invocation rather than
- * importing it, so the reinstall alone is what takes effect. The restart's only
- * real consequence was taking enforcement offline: every guard-daemon shutdown
- * logs "152 guard(s) failed to run (fail-open)", so each publish of scala-tools
- * opened a window where tool-check, turn-end and pre-push silently did not run.
- *
- * The assertion is on the SOURCE rather than on a mocked run, and that is
- * deliberate rather than a shortcut: the property being locked is the ABSENCE of
- * a side effect. A behavioural test can only prove the restart did not fire for
- * the paths it happens to drive, whereas the absence of any pm2-restart call in
- * the module proves it cannot fire on any path. It also stays honest if someone
- * reintroduces the restart behind a new condition.
- */
-const SOURCE = await Bun.file(join(import.meta.dir, "scala-tools-currency-watch.ts")).text();
-
-/** Comment prose legitimately discusses the removed restart; code must not do it. */
-const CODE = SOURCE.split("\n")
-	.filter((l) => !l.trimStart().startsWith("//") && !l.trimStart().startsWith("*"))
-	.join("\n");
-
-describe("scala-tools-currency-watch never restarts the guard daemon", () => {
-	test("issues no pm2 restart command", () => {
-		expect(CODE).not.toContain('"restart"');
-	});
-
-	test("never names scala-sentinel as a spawn argument", () => {
-		// The reinstall targets the sentinel DIRECTORY (a path constant); what must
-		// not exist is scala-sentinel as a process argument to a supervisor call.
-		expect(CODE).not.toContain('"scala-sentinel"');
-	});
-
-	test("uses no bare pm2 invocation", () => {
-		// forbid-bare-pm2-restart: a bare `pm2` call bypasses the currency-gated
-		// canonical pipeline, and the guard blocks agents from making this exact
-		// call — the handler was doing what agents are prevented from doing.
-		expect(CODE).not.toContain('"pm2"');
-	});
-
-	test("still performs the reinstall, which is the watch's actual job", () => {
-		// Removing the restart must not turn this into a no-op watch.
-		expect(CODE).toContain("deps");
-		expect(CODE).toContain("install");
-	});
-
-	test("still records the reinstall event for observability", () => {
-		expect(CODE).toContain("scala-tools.currency.reinstalled");
-	});
-});

package/src/handlers/scala-tools-currency-watch.ts

@@ -1,162 +0,0 @@
-/**
- * @system server-boot
- * @status handwritten
- * @edit edit directly
- *
- * The `scala-tools-currency-watch` pg-boss handler — keeps scala-sentinel's
- * INSTALLED @teamscala/scala-tools at registry `latest` (open migration
- * `daemon-scala-tools-currency`). scala-sentinel resolves scala-tools via its
- * own node_modules (the installed copy), which goes STALE on every
- * @teamscala/scala-tools publish until a manual deps install + restart — so the
- * daemon's publish-chain + codegen trio run OLD scala-tools while workspace
- * source is current (incident #58). This watch polls the registry dist-tag and,
- * when scala-sentinel's installed copy lags, REINSTALLS it. It does not restart
- * anything: sentinel spawns `node_modules/.bin/scala-tools` per invocation
- * rather than importing it, so the next spawn picks up the new binary. See the
- * no-restart note at the call site for the evidence and for why the restart that
- * used to live there was disabling enforcement on every publish.
- *
- * Boot-safety (protective-layers-fail-explicitly): every step is wrapped — a
- * dist-tag fetch failure, a version-parse failure, OR an install failure NEVER
- * crashes the job or loga; each records a failure event + returns. Repeated
- * reinstalls are prevented by strict semver-lt (re-installs only when installed
- * is genuinely behind latest) + the idempotent --force-resolve install.
- * Subprocesses go through @teamscala/os spawn (the single spawn surface).
- *
- * Registered under slug `@teamscala/service-boot:scala-tools-currency-watch`.
- */
-		// NO RESTART. The reinstall alone is sufficient, and restarting here was actively harmful.
-		//
-		// The premise this watch was written on — "restart so the fresh scala-tools loads" — does not hold for THIS package. scala-sentinel never
-		// imports `@teamscala/scala-tools`; it SPAWNS `node_modules/.bin/scala-tools` per invocation, so a freshly installed binary is picked up by the next
-		// spawn with no process restart at all. Verified 2026-07-27: the package is declared in scala-sentinel/package.json, yet scala-guard/src contains zero
-		// import statements resolving to it — it is spawned, never linked. dep-sync already encodes the same conclusion — HARNESS_CRITICAL_FAST_PATH
-		// maps this exact pair to install-WITHOUT-restart, while its PM2_CACHED sibling map exists for packages a daemon really does load at boot
-		// (@teamscala/codegen → codegen-daemon). This handler was the odd one out.
-		//
-		// The cost was not theoretical. Restarting the guard daemon takes enforcement offline for its warmup, and every shutdown logs "152 guard(s)
-		// failed to run (fail-open)" — so each unnecessary restart opened a window in which tool-check, turn-end and pre-push silently did not run. Three
-		// scala-tools versions published on 2026-07-26 alone, and this watch polls, so it re-fired for each. That inverts
-		// `infrastructure-outranks-application-durability`: a currency convenience was repeatedly disabling the thing it exists to keep current.
-		//
-		// It also used a bare `pm2 restart`, which is forbidden (`forbid-bare-pm2-restart`) precisely because it bypasses the
-		// currency-gated canonical pipeline — the guard blocks agents from that exact call.
-		//
-		// If a future package genuinely needs a restart to take effect, it does not belong here: add it to dep-sync's PM2_CACHED map, which already owns
-		// install-plus-restart and coalesces them.
-
-import type { ScheduledJobConfig } from "@teamscala/db-validation/registry-schemas/scheduled-job";
-import { recordEvent } from "@teamscala/event-log/record-event";
-import { getAppLogger } from "@teamscala/logger/app-loggers";
-import { workspaceRoot } from "@teamscala/os/host-paths";
-import { spawn } from "@teamscala/os/spawn";
-import { pgBossHandlerRegistry } from "../pg-boss-handler-registry.ts";
-
-const PKG = "@teamscala/scala-tools";
-const SENTINEL_DIR = `${workspaceRoot()}/scala-sentinel`;
-const INSTALLED_PKG_JSON = `${SENTINEL_DIR}/node_modules/@teamscala/scala-tools/package.json`;
-
-interface PkgJson {
-	version: string;
-}
-
-function parseSemver(v: string): [number, number, number] | null {
-	const m = /^(\d+)\.(\d+)\.(\d+)/.exec(v.trim());
-	return m ? [Number(m[1]!), Number(m[2]!), Number(m[3]!)] : null;
-}
-
-/** Strict a < b on major.minor.patch (pre-releases ignored — latest is a stable dist-tag). */
-function semverLt(a: string, b: string): boolean {
-	const pa = parseSemver(a);
-	const pb = parseSemver(b);
-	if (!pa || !pb) return false;
-	for (let i = 0; i < 3; i++) if (pa[i] !== pb[i]) return pa[i]! < pb[i]!;
-	return false;
-}
-
-async function scalaToolsCurrencyWatch(_ctx: { config: ScheduledJobConfig }): Promise<void> {
-	const log = getAppLogger();
-	try {
-		const installedPkg = await Bun.file(INSTALLED_PKG_JSON).json() as PkgJson;
-		const installed = installedPkg.version;
-
-		const distTag = await spawn({
-			name: "scala-tools-currency-watch:dist-tag",
-			command: ["scala-tools", "packages", "dist-tag", "get", PKG, "latest"],
-			timeoutMs: 30_000,
-		});
-		// dist-tag get prints the version (last non-empty line).
-		const latest =
-			(distTag.stdout ?? "")
-				.split("\n")
-				.map((l) => l.trim())
-				.filter(Boolean)
-				.pop() ?? "";
-		if (!latest || !parseSemver(latest)) {
-			log.warn(
-				`[scala-tools-currency-watch] no readable latest (exit=${distTag.exitCode}, stdout=${(distTag.stdout ?? "").slice(0, 80)}) — skip`,
-			);
-			recordEvent({
-				kind: "scala-tools.currency.tick",
-				payload: { installed, latest: null, note: "dist-tag fetch unreadable" },
-			});
-			return;
-		}
-
-		if (!semverLt(installed, latest)) {
-			recordEvent({
-				kind: "scala-tools.currency.tick",
-				payload: { installed, latest, status: "current" },
-			});
-			return;
-		}
-
-		// STALE — reinstall + restart.
-		log.warn(
-			`[scala-tools-currency-watch] scala-sentinel ${PKG} ${installed} < latest ${latest} — reinstalling + restarting`,
-		);
-		const install = await spawn({
-			name: "scala-tools-currency-watch:deps-install",
-			// A plain install fetches the current version, which is the whole point
-			// of this watch. Re-resolving the entire tree is an emergency hatch, not
-			// a currency step (operator ruling 2026-07-31).
-			command: ["scala-tools", "deps", "install"],
-			cwd: SENTINEL_DIR,
-			timeoutMs: 300_000,
-		});
-		if ((install.exitCode ?? -1) !== 0) {
-			log.error(
-				`[scala-tools-currency-watch] deps install failed (exit ${install.exitCode}) — NOT restarting to avoid boot-looping the enforcement daemon: ${(install.stderr ?? "").slice(0, 200)}`,
-			);
-			recordEvent({
-				kind: "scala-tools.currency.install-failed",
-				payload: {
-					installed,
-					latest,
-					exitCode: install.exitCode,
-					stderr: (install.stderr ?? "").slice(0, 300),
-				},
-			});
-			return;
-		}
-		recordEvent({
-			kind: "scala-tools.currency.reinstalled",
-			payload: { from: installed, to: latest },
-		});
-
-		log.info(
-			`[scala-tools-currency-watch] reinstalled ${PKG} ${installed} → ${latest} (no restart: sentinel spawns the binary, it does not import it)`,
-		);
-	} catch (err) {
-		// Boot-safety: never propagate — record + return (a watch error must not crash loga).
-		log.error(
-			`[scala-tools-currency-watch] caught — fail-open (no restart): ${err instanceof Error ? err.message : String(err)}`,
-		);
-		recordEvent({
-			kind: "scala-tools.currency.watch-error",
-			payload: { error: err instanceof Error ? err.message : String(err) },
-		});
-	}
-}
-
-pgBossHandlerRegistry.register("@teamscala/service-boot:scala-tools-currency-watch", scalaToolsCurrencyWatch);

package/src/handlers/singleton-tools-currency-watch.test.ts

@@ -1,51 +0,0 @@
-// @system codegen
-// @status generated
-// @edit change the suite in the owned-suites band, then re-run codegen. Hand-edits are overwritten.
-//
-// This suite's assertions are OWNED by the codegen band: the band module
-// carries them verbatim, this file is the emission, and hand edits here are
-// overwritten on the next run. The rationale each assertion carries moved
-// with it into the band.
-
-import { describe, expect, test } from "bun:test";
-import { join } from "node:path";
-
-const SOURCE = await Bun.file(join(import.meta.dir, "singleton-tools-currency-watch.ts")).text();
-
-const CODE = SOURCE.split("\n")
-	.filter((l) => !l.trimStart().startsWith("//") && !l.trimStart().startsWith("*"))
-	.join("\n");
-
-describe("singleton-tools-currency-watch", () => {
-	test("reads version_source from config/scala-singleton-tools", () => {
-		expect(CODE).toContain("scala-singleton-tools");
-	});
-
-	test("reinstalls stale tools", () => {
-		expect(CODE).toContain("reinstall");
-	});
-
-	test("skips bare tools (bun) with a deferred event", () => {
-		expect(CODE).toContain("deferred-to-bun-stable-watch");
-	});
-
-	test("records tick events for observability", () => {
-		expect(CODE).toContain("singleton-tools.currency.tick");
-	});
-
-	test("records reinstall events", () => {
-		expect(CODE).toContain("singleton-tools.currency.reinstalled");
-	});
-
-	test("records install-failed events", () => {
-		expect(CODE).toContain("singleton-tools.currency.install-failed");
-	});
-
-	test("uses semver comparison (not string comparison)", () => {
-		expect(CODE).toContain("semverLt");
-	});
-
-	test("handles unreadable installed version gracefully", () => {
-		expect(CODE).toContain("unreadable");
-	});
-});