@teamscala/service-boot 0.23.496 → 0.23.498

package/src/build-client-assets/hydrate-bundle.ts

@@ -55,7 +55,7 @@
 	// be silently bypassed; a valid local-export chunk carries a
 	// class/function/const/var/let/import, a valid re-export carries `from`).
 
-import { mkdir, readdir, rename, rm } from "node:fs/promises";
+import { mkdir, readdir, rm } from "node:fs/promises";
 import { join } from "node:path";
 import { getAppLogger } from "@teamscala/logger/app-loggers";
 import { fileHash, removeStaleHashedFiles } from "./hashed-output.ts";
@@ -79,7 +79,6 @@ export async function buildHydrateBundle(
 ): Promise<HydrateBundleResult | null> {
 	const entry = join(cwd, "src", "entry-client.ts");
 	const outDir = join(cwd, "dist", "client");
-	const tmpFile = join(outDir, `${HYDRATE_BASE}.js`);
 
 	if (!(await Bun.file(entry).exists())) {
 		log.warn(
@@ -123,7 +122,26 @@ export async function buildHydrateBundle(
 			entrypoints: [entry],
 			target: "browser",
 			outdir: outDir,
-			naming: `${HYDRATE_BASE}.js`,
+			// THE BUNDLER OWNS THE HASH, because it also writes the references.
+			// Under `splitting: true` + `publicPath`, Bun bakes the entry's
+			// build-time name into every chunk that imports it. Naming the entry
+			// `hydrate.js` here and RENAMING it to `hydrate-<hash>.js` afterwards
+			// moved the file but could not rewrite the specifiers already emitted
+			// into the chunks — so every chunk imported `/assets/hydrate.js`, which
+			// no longer existed. 404 on the module, the importing block dies, and
+			// the page still returns 200 with every guard green.
+			//
+			// MEASURED 2026-09-08 on quiz.scala.business: `AssessmentFlowBlock`
+			// failed with "Failed to fetch dynamically imported module"; crawling
+			// the served graph (142 level-1 + 76 level-2 assets) found exactly one
+			// broken URL — `/assets/hydrate.js` — imported by the entry itself and
+			// by most chunks. Hash applied OUTSIDE the generator is two artefacts
+			// that must agree with nothing making them (`one-generator-pattern`).
+			naming: {
+				entry: `${HYDRATE_BASE}-[hash].[ext]`,
+				chunk: "chunk-[hash].[ext]",
+				asset: "[name]-[hash].[ext]",
+			},
 			minifyWhitespace: process.env.NODE_ENV === "production",
 			minifySyntax: process.env.NODE_ENV === "production",
 			minifyIdentifiers: false,
@@ -232,10 +250,24 @@ export async function buildHydrateBundle(
 		);
 	}
 
-	const hash = await fileHash(tmpFile);
-	const hashedName = `${HYDRATE_BASE}-${hash}.js`;
+	// Bun emitted the hashed entry itself, so the name it wrote into every
+	// chunk IS the name on disk. Read it back from the build's own output
+	// list rather than reconstructing it — a reconstructed name is a second
+	// copy of a fact the bundler already owns, which is the defect this
+	// change removes (`a-mutating-verb-reads-back-what-it-claims`).
+	const entryOutput = result.outputs.find(
+		(o) => o.kind === "entry-point",
+	);
+	if (!entryOutput) {
+		throw new Error(
+			"[build-client-assets] Bun.build reported success but emitted no entry-point output — refusing to ship a bundle with no entry.",
+		);
+	}
+	const hashedName = entryOutput.path.split("/").pop() as string;
 	const hashedPath = join(outDir, hashedName);
-	await rename(tmpFile, hashedPath);
+	const hash =
+		/^hydrate-([A-Za-z0-9]+)\.js$/.exec(hashedName)?.[1] ??
+		(await fileHash(hashedPath));
 	removeStaleHashedFiles(outDir, HYDRATE_BASE, "js", hashedName);
 
 	// Splitting emits one chunk per lazy import() alongside the entry. Keep the