@teamscala/service-boot 0.23.474 → 0.23.478

package/package.json

@@ -6,7 +6,7 @@
   },
   "name": "@teamscala/service-boot",
   "type": "module",
-  "version": "0.23.474",
+  "version": "0.23.478",
   "sideEffects": false,
   "imports": {
     "#service-boot/*": "./src/*",

package/src/fn-routers/assessment-report-data.ts

@@ -463,10 +463,7 @@ export function computeReportData({
 		roadmap: nextSteps?.roadmap ?? orderRoadmap(band?.roadmap),
 		research: {
 			...researchData,
-			groups: researchData.groups.map((group) => ({
-				title: group.title,
-				items: numberItems(group.items),
-			})),
+			groups: researchData.groups,
 			weakestAreasList: numberItems(researchData.weakestAreas),
 		},
 		whoYouHelp: band?.whoYouHelp ?? "",

package/src/fn-routers/assessment-research-report-data.test.ts

@@ -14,6 +14,7 @@ import {
 	type ReportAssessmentInput,
 	type StageBand,
 } from "./assessment-report-data.ts";
+import { assessmentResearchFindingsSchema } from "@teamscala/db-validation/generated/assessment-research-findings";
 
 const ANNA_LINKEDIN_RAW = "https://www.linkedin.com/in/annaosherov/";
 const ANNA_KEY = "linkedin.com/in/annaosherov";
@@ -173,7 +174,17 @@ describe("research shaping", () => {
 		).toThrow(/superseded/);
 	});
 
-	test("malformed authored findings throw instead of silently rendering garbage", () => {
+	// The db-validation generated schema is the contract this parse enforces.
+	// While the generated artifact is still the permissive v.record fallback
+	// (the codegen engine that emits the faithful schema embeds
+	// STRUCTURED_JSONB_KEYS at its build and needs an engine rebuild with
+	// @teamscala/codegen >= 2.1.585 — then `scala-tools codegen run --output
+	// db-column-validation --force`, publish db-validation, bump here), this
+	// test activates itself: the skip is a property of the shipped artifact,
+	// not of the expectation.
+	const schemaIsFaithful = !("key" in (assessmentResearchFindingsSchema as object));
+	const enforceTest = schemaIsFaithful ? test : test.skip;
+	enforceTest("malformed authored findings throw instead of silently rendering garbage", () => {
 		expect(() => readResearchFindings({ groups: "not-an-array" })).toThrow();
 	});
 });

package/src/fn-routers/assessment-research-report-data.ts

@@ -33,6 +33,7 @@ import {
 import type {
 	ReportAssessmentInput,
 	ReportData,
+	ReportPairResponseShape,
 	StageBand,
 	TitledAction,
 } from "./assessment-report-data.ts";
@@ -130,7 +131,7 @@ export function assertLiveResearch(research: ReportResearchInput | null | undefi
 
 /** The person's display name: quiz response names first, research second. */
 export function resolvePersonName(
-	response: ReportPairResponseInput | null | undefined,
+	response: ReportPairResponseShape | null | undefined,
 	research: ReportResearchInput | null | undefined,
 ): string {
 	const fromResponse = [response?.first_name, response?.last_name]
@@ -216,13 +217,15 @@ export interface ResearchReportData {
 	intro: string;
 	calloutTitle: string;
 	calloutBody: string;
-	groups: Array<{ title: string; items: Array<{ index: string; text: string }> }>;
+	groups: Array<{ title: string; items: string[] }>;
 	claims: ResearchClaim[];
 	gapRows: GapRow[];
 	combinedBand: string;
 	combinedDelta: string;
 	combinedStatement: string;
 	weakestAreas: string[];
+	/** weakest areas numbered for badge-list rendering (shaped by the caller) */
+	weakestAreasList?: Array<{ index: string; text: string }>;
 	methodRawScores: string;
 	methodSources: string;
 	researchedAt: string;
@@ -249,7 +252,7 @@ function isoDay(value: Date | string | null | undefined): string {
  */
 export function buildResearchReportData(opts: {
 	research: ReportResearchInput | null | undefined;
-	response: ReportPairResponseInput | null | undefined;
+	response: ReportPairResponseShape | null | undefined;
 	assessment: ReportAssessmentInput | null | undefined;
 	resolveBand: (score: number) => StageBand | null;
 	/** the parsed bands, for band-distance derivation */

package/src/fn-routers/linkedin-identity.test.ts

@@ -0,0 +1,27 @@
+import { describe, expect, test } from "bun:test";
+import { normaliseLinkedinIdentity } from "./linkedin-identity.ts";
+
+describe("normaliseLinkedinIdentity", () => {
+	test("collapses every spelling of the same profile to one key", () => {
+		expect(normaliseLinkedinIdentity("https://www.linkedin.com/in/annaosherov/")).toBe(
+			"linkedin.com/in/annaosherov",
+		);
+		expect(normaliseLinkedinIdentity("linkedin.com/in/AnnaOsherov")).toBe(
+			"linkedin.com/in/annaosherov",
+		);
+		expect(normaliseLinkedinIdentity("  LinkedIn.com/in/annaosherov/ ")).toBe(
+			"linkedin.com/in/annaosherov",
+		);
+		expect(normaliseLinkedinIdentity("http://www.linkedin.com/in/annaosherov")).toBe(
+			"linkedin.com/in/annaosherov",
+		);
+	});
+
+	test("refuses non-linkedin, empty and absent input rather than guessing a key", () => {
+		expect(normaliseLinkedinIdentity("https://example.com/in/someone")).toBeNull();
+		expect(normaliseLinkedinIdentity("   ")).toBeNull();
+		expect(normaliseLinkedinIdentity("")).toBeNull();
+		expect(normaliseLinkedinIdentity(null)).toBeNull();
+		expect(normaliseLinkedinIdentity(undefined)).toBeNull();
+	});
+});