@teamscala/service-boot 0.23.443 → 0.23.444

package/package.json

@@ -6,7 +6,7 @@
   },
   "name": "@teamscala/service-boot",
   "type": "module",
-  "version": "0.23.443",
+  "version": "0.23.444",
   "sideEffects": false,
   "imports": {
     "#service-boot/*": "./src/*",

package/src/build-client-assets/manifest.test.ts

@@ -51,7 +51,7 @@ describe("verifyClientBuildAssets", () => {
 		if (!result.ok) expect(result.reason).toContain("never ran or its output is gone");
 	});
 
-	test("the first-boot tombstone shape (unhashed fallback paths, no files) refuses", async () => {
+	test("the first-boot tombstone shape (unhashed paths, no files) refuses", async () => {
 		await writeManifest(join(dir, "dist", "client"), {
 			stylesPath: "/assets/styles.css",
 			hydratePath: "/assets/hydrate.js",
@@ -61,6 +61,18 @@ describe("verifyClientBuildAssets", () => {
 		if (!result.ok) expect(result.reason).toContain("unbuilt assets");
 	});
 
+	test("a path-less tombstone (the shape build-client-assets now writes) refuses as unbuilt", async () => {
+		await writeManifest(join(dir, "dist", "client"), {
+			inputFingerprint: "failed:2026-09-01T00:00:00.000Z",
+			buildFailed: true,
+			buildFailedReason: "hydrate build failed: something",
+			buildFailedAt: "2026-09-01T00:00:00.000Z",
+		} as never);
+		const result = await verifyClientBuildAssets(dir);
+		expect(result.ok).toBe(false);
+		if (!result.ok) expect(result.reason).toContain("never ran or its output is gone");
+	});
+
 	test("a manifest naming a file that was deleted refuses (stale-bundle shape)", async () => {
 		await writeManifest(join(dir, "dist", "client"), {
 			stylesPath: "/assets/styles-abc.css",

package/src/build-client-assets/manifest.ts

@@ -21,8 +21,13 @@ import type { SourceMapUploadResult } from "./sourcemaps-upload.ts";
 export const MANIFEST_FILE = "asset-manifest.json";
 
 export interface AssetManifest {
-	stylesPath: string;
-	hydratePath: string;
+	// Optional because a TOMBSTONE from a build that failed with no prior
+	// success carries NO paths — there are no real assets to name, and inventing
+	// URLs nothing built is the deleted fallback class (no-shims).
+	// `readManifest` returns null unless both are present, so a path-less
+	// tombstone reads as unbuilt everywhere (verification, readiness, render).
+	stylesPath?: string;
+	hydratePath?: string;
 	// Content fingerprint of the CLIENT-BUNDLE DEPENDENCY CLOSURE (source entrypoints + @teamscala/* JS/CSS in the closure + third-party closure-dep
 	// versions), hashed by CONTENT — never mtime (cache-key-hashes-source- inputs-only). The boot/build freshness check rebuilds iff this differs
 	// from the current closure. mtime comparison is fundamentally broken on Railway: deploy-build bakes the bundle at image-build time, and under the
@@ -53,15 +58,6 @@ export interface AssetManifest {
 	sourceMaps?: SourceMapUploadResult;
 }
 
-// Last-resort paths for a tombstone when no prior successful manifest exists
-// (first-ever boot fails). Points at the unhashed build names so an operator
-// inspecting the manifest sees a real (if 404-ing) target rather than a
-// mystery sentinel.
-export const FALLBACK_MANIFEST: { stylesPath: string; hydratePath: string } = {
-	stylesPath: "/assets/styles.css",
-	hydratePath: "/assets/hydrate.js",
-};
-
 /**
  * Read ONLY the tombstone state of the current manifest — the runtime
  * (read-html-template, ui-service) calls this to decide whether to surface a
@@ -125,10 +121,9 @@ export async function writeManifest(
  * Verify the CURRENT manifest against the files it names — the capability
  * probe the readiness flip gates on (`a-component-may-not-report-a-state-it-
  * has-not-verified`). A manifest is servable only when BOTH referenced assets
- * exist on disk. A manifest whose last build failed with no prior success
- * carries the unhashed last-resort paths (FALLBACK_MANIFEST) — names nothing
- * ever builds — and an absent/unreadable manifest carries nothing; all three
- * must read as NOT built, never as a legitimate bundle. Measured 2026-09-01:
+ * exist on disk. An absent or unreadable manifest, a first-boot tombstone
+ * carrying no paths, and any manifest naming files that do not exist must all
+ * read as NOT built, never as a legitimate bundle. Measured 2026-09-01:
  * proposals.scala.business served a client-facing proposal unstyled while
  * Railway reported the deploy SUCCESS, because "client build never ran" was
  * indistinguishable from "client build fine" at every layer that reports.
@@ -138,7 +133,7 @@ export async function verifyClientBuildAssets(
 ): Promise<{ ok: true } | { ok: false; reason: string }> {
 	const outDir = join(cwd, "dist", "client");
 	const manifest = await readManifest(outDir);
-	if (!manifest) {
+	if (!manifest || !manifest.stylesPath || !manifest.hydratePath) {
 		return {
 			ok: false,
 			reason: `no readable asset manifest at ${join(outDir, MANIFEST_FILE)} — the client build never ran or its output is gone`,

package/src/build-client-assets.ts

@@ -60,7 +60,6 @@ import { CLIENT_BUILD_LOCK, getClientBuildLockTimeoutMs } from "./build-client-a
 import { buildHydrateBundle } from "./build-client-assets/hydrate-bundle.ts";
 import { computeInputFingerprint } from "./build-client-assets/input-fingerprint.ts";
 import {
-	FALLBACK_MANIFEST,
 	readManifest,
 	writeManifest,
 } from "./build-client-assets/manifest.ts";
@@ -85,7 +84,9 @@ export async function buildClientAssets(serviceSlug: string): Promise<void> {
 		// permanently lost the release's maps — client stacks stayed minified
 		// until the next real input change forced a rebuild.
 		const recorded = existingManifest.sourceMaps?.status;
-		const release = releaseFromHydratePath(existingManifest.hydratePath);
+		const release = existingManifest.hydratePath
+			? releaseFromHydratePath(existingManifest.hydratePath)
+			: null;
 		if (recorded !== "uploaded" && release) {
 			log.info(
 				`[build-client-assets:${serviceSlug}] manifest up-to-date (skip); source maps previously ${recorded ?? "unrecorded"} — retrying upload for release ${release}`,
@@ -143,10 +144,19 @@ async function performBuild(
 		try {
 			await mkdir(outDir, { recursive: true });
 			await writeManifest(outDir, {
-				// Preserve last-good paths so SSR serves the prior bundle
-				// rather than a 404 hydrate — degraded but not dead.
-				stylesPath: existingManifest?.stylesPath ?? FALLBACK_MANIFEST.stylesPath,
-				hydratePath: existingManifest?.hydratePath ?? FALLBACK_MANIFEST.hydratePath,
+				// NO invented paths: when a prior successful build exists its real
+				// paths are preserved (SSR keeps serving the prior bundle — degraded
+				// but coherent); when none exists the tombstone carries NO asset
+				// paths at all. Writing the unhashed build names here was the last
+				// remnant of the deleted fallback class — paths that name files
+				// nothing built must not exist on disk any more than in served HTML.
+				// A path-less tombstone reads as unbuilt everywhere (readManifest →
+				// null → verification refuses → readiness never flips), and its
+				// buildFailedReason below is the operator's diagnostic — the failure
+				// is read via readClientBuildStatus, which never needed the paths.
+				...(existingManifest?.stylesPath && existingManifest?.hydratePath
+					? { stylesPath: existingManifest.stylesPath, hydratePath: existingManifest.hydratePath }
+					: {}),
 				// Failure sentinel: the next boot's fingerprint check reads
 				// this and cannot match any real fingerprint → forces a retry.
 				inputFingerprint: `failed:${new Date().toISOString()}`,