@teamscala/service-boot 0.23.379 → 0.23.381

package/package.json

@@ -6,7 +6,7 @@
   },
   "name": "@teamscala/service-boot",
   "type": "module",
-  "version": "0.23.379",
+  "version": "0.23.381",
   "sideEffects": false,
   "imports": {
     "#service-boot/*": "./src/*",

package/src/agreement-gate.ts

@@ -752,17 +752,8 @@ export const agreementGateConfig: ContentGateConfig = {
 			resourceKey: "agreement",
 			agentConfigSlug: "agreement-assistant-agent",
 			organisationId: session.organisationId ?? undefined,
-			title: "Agreement Assistant",
 			launchLabel: "Ask about this agreement",
-			welcomeMessage:
-				"Hi! Ask me anything about this agreement — clauses, fees, the schedules, or how signing works.",
 			placeholder: "Ask about this agreement…",
-			conversationStarters: [
-				"What are the key terms?",
-				"Summarise the fees and payment terms.",
-				"What's in Schedule A and Schedule B?",
-				"How do I sign this?",
-			],
 		});
 
 		// Old-flow only: drop the pre-placed gate block (new flow has none).

package/src/proposal-chat-inject.ts

@@ -18,10 +18,23 @@
 import { getAppLogger } from "@teamscala/logger/app-loggers";
 import { loadRegistryConfig } from "@teamscala/db/registry/load-config";
 import { getServerClient } from "./page-server-orpc/server-client.ts";
+import { loadAgentPresentation } from "./resource-chat-inject.ts";
 import * as v from "valibot";
+import type { BlockSchemaKey } from "@teamscala/db/registry/generated/block-schema";
 
 const AgentConfigSchema = v.object({ agentId: v.string() });
 
+// THE PUSHED BLOCK NAME IS AN IMPORTED IDENTITY, NEVER A SPELLED STRING.
+// discover-blocks keys the Puck registry off block_schema.slug alone
+// (`components[row.slug] = …`), so a type that is not a live slug resolves to
+// nothing — and because injection is fail-soft, the page renders unchanged with
+// no error. That is exactly how the bubble went missing from every gated
+// proposal and agreement: the block was consolidated to ResourceLauncher and
+// these injectors kept pushing their pre-consolidation names. BlockSchemaKey is
+// the generated union of live slugs, so annotating it here makes a stale name a
+// COMPILE error instead of a silent absence (identity-is-imported-never-spelled).
+const LAUNCHER_BLOCK: BlockSchemaKey = "ResourceLauncher";
+
 /** Serialise the entire page content tree as text for the GPT context. */
 async function buildProposalContext(resolved: Record<string, unknown>): Promise<string> {
 	const proposal = resolved.proposal as Record<string, unknown> | undefined;
@@ -118,18 +131,22 @@ export async function injectProposalChatLauncher(
 
 	try {
 		const runtimeContext = await buildProposalContext(resolved);
+		const presentation = await loadAgentPresentation(agentId);
 		(page.content as Array<Record<string, unknown>>).push({
-			type: "ChatLauncherBlock",
+			type: LAUNCHER_BLOCK,
 			props: {
 				id: "proposal-chat-launcher",
 				agentId,
 				organisationId,
 				viewerEmail,
 				runtimeContext,
-				primaryColor: brandPrimaryColor(resolved),
-				title: "Proposal Assistant",
-				welcomeMessage:
-					"Hi! Ask me anything about this proposal — scope, pricing, timeline or next steps.",
+				// Copy comes from the agent row (see loadAgentPresentation): these
+				// three were spelled here while ai_agents held blank columns for
+				// each of them.
+				primaryColor: brandPrimaryColor(resolved) || presentation.primaryColor,
+				title: presentation.title,
+				welcomeMessage: presentation.welcomeMessage,
+				conversationStarters: presentation.conversationStarters,
 				launchLabel: "Ask about this proposal",
 			},
 		});

package/src/resource-chat-inject.test.ts

@@ -0,0 +1,128 @@
+/**
+ * @system service-boot
+ * @status handwritten
+ * @edit edit directly
+ *
+ * Regression test for the block NAME the chat injectors push.
+ *
+ * THE DEFECT THIS PINS (found 2026-08-19): the floating assistant bubble was
+ * silently absent on every gated proposal and agreement. discover-blocks keys
+ * the Puck component registry off `block_schema.slug` and nothing else
+ * (`components[row.slug] = …`), so a pushed block `type` must EQUAL an active
+ * slug. The launcher block was consolidated to the single `ResourceLauncher`
+ * row, but the injectors still pushed the pre-consolidation names —
+ * `ResourceChatLauncher` here and `ChatLauncherBlock` in proposal-chat-inject.
+ * Neither resolves, and because injection is deliberately fail-soft the page
+ * rendered unchanged with no error: the classic shape of
+ * `a-deleted-producer-leaves-its-consumers-executing`.
+ *
+ * Asserting the literal is the WEAK half of the fix — it catches a regression
+ * of this exact string, not a future rename of the block. The strong half is
+ * single-sourcing the name so it cannot be spelled at all
+ * (`identity-is-imported-never-spelled`); until that lands, this test is what
+ * stands between the bubble and another silent disappearance.
+ */
+
+import { describe, expect, mock, test } from "bun:test";
+
+/** The ONE active launcher block_schema slug — the Puck registry key. */
+const REGISTERED_LAUNCHER_SLUG = "ResourceLauncher";
+
+mock.module("@teamscala/db/registry/load-config", () => ({
+	loadRegistryConfig: async () => ({ agentId: "agent-1" }),
+}));
+mock.module("./page-server-orpc/server-client.ts", () => ({
+	getServerClient: () => ({}),
+}));
+mock.module("@teamscala/logger/app-loggers", () => ({
+	getAppLogger: () => ({ error: () => {} }),
+}));
+mock.module("@teamscala/db/prisma-registry", () => ({
+	getPrisma: () => ({
+		ai_agents: {
+			findUnique: async () => ({
+				name: "Agreement Assistant",
+				welcome_message: "Hi! Ask me anything about this agreement.",
+				conversation_starters: ["What are the key terms?", "How do I sign this?"],
+				primary_color: "#6366f1",
+			}),
+		},
+	}),
+}));
+
+const { injectResourceChatLauncher } = await import("./resource-chat-inject.ts");
+const { injectProposalChatLauncher } = await import("./proposal-chat-inject.ts");
+
+function makeResolved(resourceKey: string): Record<string, unknown> {
+	return {
+		[resourceKey]: { organisation_id: "org-1", name: "Demo" },
+		brand: { primaryColor: "#123456" },
+		page: { puck_data: { root: { props: {} }, zones: {}, content: [] } },
+	};
+}
+
+function pushedBlocks(resolved: Record<string, unknown>) {
+	const pd = (resolved.page as { puck_data: { content: Array<{ type: string }> } }).puck_data;
+	return pd.content;
+}
+
+describe("chat injectors — pushed block name resolves to a registered block", () => {
+	test("the generic resource injector pushes the registered launcher slug", async () => {
+		const resolved = makeResolved("agreement");
+		await injectResourceChatLauncher(resolved, "viewer@example.com", {
+			resourceKey: "agreement",
+			agentConfigSlug: "agreement-assistant-agent",
+			launchLabel: "Ask about this agreement",
+		});
+		const blocks = pushedBlocks(resolved);
+		expect(blocks).toHaveLength(1);
+		expect(blocks[0].type).toBe(REGISTERED_LAUNCHER_SLUG);
+	});
+
+	test("the proposal injector pushes the registered launcher slug", async () => {
+		const resolved = makeResolved("proposal");
+		await injectProposalChatLauncher(resolved, "viewer@example.com");
+		const blocks = pushedBlocks(resolved);
+		expect(blocks).toHaveLength(1);
+		expect(blocks[0].type).toBe(REGISTERED_LAUNCHER_SLUG);
+	});
+
+	test("neither injector pushes a pre-consolidation launcher name", async () => {
+		const a = makeResolved("agreement");
+		await injectResourceChatLauncher(a, "viewer@example.com", {
+			resourceKey: "agreement",
+			agentConfigSlug: "agreement-assistant-agent",
+			launchLabel: "Ask about this agreement",
+		});
+		const p = makeResolved("proposal");
+		await injectProposalChatLauncher(p, "viewer@example.com");
+
+		const dead = ["ResourceChatLauncher", "ChatLauncherBlock"];
+		for (const blocks of [pushedBlocks(a), pushedBlocks(p)]) {
+			for (const block of blocks) {
+				expect(dead).not.toContain(block.type);
+			}
+		}
+	});
+
+	test("the assistant's words come from the agent row, not the caller", async () => {
+		// THE REGRESSION THIS PINS: title, welcome message and starters used to
+		// be string literals in the injectors while ai_agents held a blank
+		// column for each. Whoever changed the row saw no change on the page.
+		const resolved = makeResolved("agreement");
+		await injectResourceChatLauncher(resolved, "viewer@example.com", {
+			resourceKey: "agreement",
+			agentConfigSlug: "agreement-assistant-agent",
+			launchLabel: "Ask about this agreement",
+		});
+		const props = (pushedBlocks(resolved)[0] as { props: Record<string, unknown> }).props;
+		expect(props.title).toBe("Agreement Assistant");
+		expect(props.welcomeMessage).toBe("Hi! Ask me anything about this agreement.");
+		expect(props.conversationStarters).toEqual([
+			"What are the key terms?",
+			"How do I sign this?",
+		]);
+		// launchLabel has no column yet, so it is still the caller's.
+		expect(props.launchLabel).toBe("Ask about this agreement");
+	});
+});

package/src/resource-chat-inject.ts

@@ -22,30 +22,95 @@
 
 import { getAppLogger } from "@teamscala/logger/app-loggers";
 import { loadRegistryConfig } from "@teamscala/db/registry/load-config";
+import { getPrisma } from "@teamscala/db/prisma-registry";
 import { getServerClient } from "./page-server-orpc/server-client.ts";
 import * as v from "valibot";
+import type { BlockSchemaKey } from "@teamscala/db/registry/generated/block-schema";
+import type { ConfigKey } from "@teamscala/db/registry/generated/config";
 
 const AgentConfigSchema = v.object({ agentId: v.string() });
 
+// THE PUSHED BLOCK NAME IS AN IMPORTED IDENTITY, NEVER A SPELLED STRING.
+// discover-blocks keys the Puck registry off block_schema.slug alone
+// (`components[row.slug] = …`), so a type that is not a live slug resolves to
+// nothing — and because injection is fail-soft, the page renders unchanged with
+// no error. That is exactly how the bubble went missing from every gated
+// proposal and agreement: the block was consolidated to ResourceLauncher and
+// these injectors kept pushing their pre-consolidation names. BlockSchemaKey is
+// the generated union of live slugs, so annotating it here makes a stale name a
+// COMPILE error instead of a silent absence (identity-is-imported-never-spelled).
+const LAUNCHER_BLOCK: BlockSchemaKey = "ResourceLauncher";
+
 /** Per-resource-type injection config — the only thing that varies. */
 export interface ResourceChatOptions {
 	/** Key in `resolved` holding the record (e.g. "proposal", "agreement"). */
 	resourceKey: string;
 	/** `config` row slug carrying { agentId } (e.g. "agreement-assistant-agent"). */
-	agentConfigSlug: string;
+	agentConfigSlug: ConfigKey;
 	/** Org id to scope the chat. If omitted, read from resolved[resourceKey].organisation_id
 	 *  (proposals); agreements pass it explicitly (org isn't on the resolved record). */
 	organisationId?: string;
-	/** Overlay title-bar label (e.g. "Agreement Assistant"). */
-	title: string;
 	/** Floating button label / speech bubble (e.g. "Ask about this agreement"). */
 	launchLabel: string;
-	/** First assistant message. */
-	welcomeMessage?: string;
 	/** Input placeholder. */
 	placeholder?: string;
-	/** Suggested starter questions. */
+}
+
+/**
+ * THE ASSISTANT'S WORDS BELONG TO THE AGENT ROW, NOT TO THIS FILE.
+ *
+ * `ai_agents` already carries a column for every one of them -- name,
+ * welcome_message, conversation_starters, primary_color -- and on 2026-08-19
+ * both live agents had welcome_message NULL and conversation_starters empty
+ * while the copy sat spelled in TypeScript here and in proposal-chat-inject.
+ * The intended home existed, sat blank, and the hardcoded copy won, so nobody
+ * could change a word the assistant says without a code change and a deploy.
+ * Two copies of one fact with the stale one winning silently is exactly
+ * `information-exists-in-one-location`.
+ *
+ * `launchLabel` and `placeholder` remain caller arguments only because no
+ * column holds them yet.
+ */
+export interface AgentPresentation {
+	title?: string;
+	welcomeMessage?: string;
 	conversationStarters?: string[];
+	primaryColor?: string;
+}
+
+export async function loadAgentPresentation(agentId: string): Promise<AgentPresentation> {
+	try {
+		const agent = await getPrisma().ai_agents.findUnique({
+			where: { id: agentId },
+			select: {
+				name: true,
+				welcome_message: true,
+				conversation_starters: true,
+				primary_color: true,
+			},
+		});
+		if (!agent) return {};
+		const starters = Array.isArray(agent.conversation_starters)
+			? (agent.conversation_starters as unknown[]).filter(
+					(entry): entry is string => typeof entry === "string" && entry.trim().length > 0,
+				)
+			: [];
+		return {
+			title: agent.name ?? undefined,
+			welcomeMessage: agent.welcome_message ?? undefined,
+			conversationStarters: starters.length > 0 ? starters : undefined,
+			primaryColor: agent.primary_color ?? undefined,
+		};
+	} catch (err) {
+		// FAIL SOFT, LIKE THE REST OF THE INJECTION. A presentation read that
+		// fails must not remove the bubble: the launcher carries its own
+		// default for every one of these fields, so an unreadable row costs
+		// wording, never the assistant itself.
+		getAppLogger().error(
+			`[resource-chat] agent presentation read failed (${agentId}): ${err instanceof Error ? err.message : String(err)}`,
+		);
+		return {};
+	}
 }
 
 /** Serialise the resource record + entire page content tree as text for the GPT. */
@@ -144,20 +209,23 @@ export async function injectResourceChatLauncher(
 
 	try {
 		const runtimeContext = await buildResourceContext(resolved, opts.resourceKey);
+		const presentation = await loadAgentPresentation(agentId);
 		(page.content as Array<Record<string, unknown>>).push({
-			type: "ResourceChatLauncher",
+			type: LAUNCHER_BLOCK,
 			props: {
 				id: `${opts.resourceKey}-chat-launcher`,
 				agentId,
 				organisationId,
 				viewerEmail,
 				runtimeContext,
-				primaryColor: brandPrimaryColor(resolved),
-				title: opts.title,
-				welcomeMessage: opts.welcomeMessage,
+				// The page's own brand still wins over the agent's stored colour:
+				// the bubble sits ON this document and must match it.
+				primaryColor: brandPrimaryColor(resolved) || presentation.primaryColor,
+				title: presentation.title,
+				welcomeMessage: presentation.welcomeMessage,
 				launchLabel: opts.launchLabel,
 				placeholder: opts.placeholder,
-				conversationStarters: opts.conversationStarters,
+				conversationStarters: presentation.conversationStarters,
 			},
 		});
 	} catch (err) {