@teamscala/service-boot 0.23.379 → 0.23.380

package/package.json

@@ -6,7 +6,7 @@
   },
   "name": "@teamscala/service-boot",
   "type": "module",
-  "version": "0.23.379",
+  "version": "0.23.380",
   "sideEffects": false,
   "imports": {
     "#service-boot/*": "./src/*",

package/src/proposal-chat-inject.ts

@@ -19,9 +19,21 @@ import { getAppLogger } from "@teamscala/logger/app-loggers";
 import { loadRegistryConfig } from "@teamscala/db/registry/load-config";
 import { getServerClient } from "./page-server-orpc/server-client.ts";
 import * as v from "valibot";
+import type { BlockSchemaKey } from "@teamscala/db/registry/generated/block-schema";
 
 const AgentConfigSchema = v.object({ agentId: v.string() });
 
+// THE PUSHED BLOCK NAME IS AN IMPORTED IDENTITY, NEVER A SPELLED STRING.
+// discover-blocks keys the Puck registry off block_schema.slug alone
+// (`components[row.slug] = …`), so a type that is not a live slug resolves to
+// nothing — and because injection is fail-soft, the page renders unchanged with
+// no error. That is exactly how the bubble went missing from every gated
+// proposal and agreement: the block was consolidated to ResourceLauncher and
+// these injectors kept pushing their pre-consolidation names. BlockSchemaKey is
+// the generated union of live slugs, so annotating it here makes a stale name a
+// COMPILE error instead of a silent absence (identity-is-imported-never-spelled).
+const LAUNCHER_BLOCK: BlockSchemaKey = "ResourceLauncher";
+
 /** Serialise the entire page content tree as text for the GPT context. */
 async function buildProposalContext(resolved: Record<string, unknown>): Promise<string> {
 	const proposal = resolved.proposal as Record<string, unknown> | undefined;
@@ -119,7 +131,7 @@ export async function injectProposalChatLauncher(
 	try {
 		const runtimeContext = await buildProposalContext(resolved);
 		(page.content as Array<Record<string, unknown>>).push({
-			type: "ChatLauncherBlock",
+			type: LAUNCHER_BLOCK,
 			props: {
 				id: "proposal-chat-launcher",
 				agentId,

package/src/resource-chat-inject.test.ts

@@ -0,0 +1,97 @@
+/**
+ * @system service-boot
+ * @status handwritten
+ * @edit edit directly
+ *
+ * Regression test for the block NAME the chat injectors push.
+ *
+ * THE DEFECT THIS PINS (found 2026-08-19): the floating assistant bubble was
+ * silently absent on every gated proposal and agreement. discover-blocks keys
+ * the Puck component registry off `block_schema.slug` and nothing else
+ * (`components[row.slug] = …`), so a pushed block `type` must EQUAL an active
+ * slug. The launcher block was consolidated to the single `ResourceLauncher`
+ * row, but the injectors still pushed the pre-consolidation names —
+ * `ResourceChatLauncher` here and `ChatLauncherBlock` in proposal-chat-inject.
+ * Neither resolves, and because injection is deliberately fail-soft the page
+ * rendered unchanged with no error: the classic shape of
+ * `a-deleted-producer-leaves-its-consumers-executing`.
+ *
+ * Asserting the literal is the WEAK half of the fix — it catches a regression
+ * of this exact string, not a future rename of the block. The strong half is
+ * single-sourcing the name so it cannot be spelled at all
+ * (`identity-is-imported-never-spelled`); until that lands, this test is what
+ * stands between the bubble and another silent disappearance.
+ */
+
+import { describe, expect, mock, test } from "bun:test";
+
+/** The ONE active launcher block_schema slug — the Puck registry key. */
+const REGISTERED_LAUNCHER_SLUG = "ResourceLauncher";
+
+mock.module("@teamscala/db/registry/load-config", () => ({
+	loadRegistryConfig: async () => ({ agentId: "agent-1" }),
+}));
+mock.module("./page-server-orpc/server-client.ts", () => ({
+	getServerClient: () => ({}),
+}));
+mock.module("@teamscala/logger/app-loggers", () => ({
+	getAppLogger: () => ({ error: () => {} }),
+}));
+
+const { injectResourceChatLauncher } = await import("./resource-chat-inject.ts");
+const { injectProposalChatLauncher } = await import("./proposal-chat-inject.ts");
+
+function makeResolved(resourceKey: string): Record<string, unknown> {
+	return {
+		[resourceKey]: { organisation_id: "org-1", name: "Demo" },
+		brand: { primaryColor: "#123456" },
+		page: { puck_data: { root: { props: {} }, zones: {}, content: [] } },
+	};
+}
+
+function pushedBlocks(resolved: Record<string, unknown>) {
+	const pd = (resolved.page as { puck_data: { content: Array<{ type: string }> } }).puck_data;
+	return pd.content;
+}
+
+describe("chat injectors — pushed block name resolves to a registered block", () => {
+	test("the generic resource injector pushes the registered launcher slug", async () => {
+		const resolved = makeResolved("agreement");
+		await injectResourceChatLauncher(resolved, "viewer@example.com", {
+			resourceKey: "agreement",
+			agentConfigSlug: "agreement-assistant-agent",
+			title: "Agreement Assistant",
+			launchLabel: "Ask about this agreement",
+		});
+		const blocks = pushedBlocks(resolved);
+		expect(blocks).toHaveLength(1);
+		expect(blocks[0].type).toBe(REGISTERED_LAUNCHER_SLUG);
+	});
+
+	test("the proposal injector pushes the registered launcher slug", async () => {
+		const resolved = makeResolved("proposal");
+		await injectProposalChatLauncher(resolved, "viewer@example.com");
+		const blocks = pushedBlocks(resolved);
+		expect(blocks).toHaveLength(1);
+		expect(blocks[0].type).toBe(REGISTERED_LAUNCHER_SLUG);
+	});
+
+	test("neither injector pushes a pre-consolidation launcher name", async () => {
+		const a = makeResolved("agreement");
+		await injectResourceChatLauncher(a, "viewer@example.com", {
+			resourceKey: "agreement",
+			agentConfigSlug: "agreement-assistant-agent",
+			title: "Agreement Assistant",
+			launchLabel: "Ask about this agreement",
+		});
+		const p = makeResolved("proposal");
+		await injectProposalChatLauncher(p, "viewer@example.com");
+
+		const dead = ["ResourceChatLauncher", "ChatLauncherBlock"];
+		for (const blocks of [pushedBlocks(a), pushedBlocks(p)]) {
+			for (const block of blocks) {
+				expect(dead).not.toContain(block.type);
+			}
+		}
+	});
+});

package/src/resource-chat-inject.ts

@@ -24,15 +24,28 @@ import { getAppLogger } from "@teamscala/logger/app-loggers";
 import { loadRegistryConfig } from "@teamscala/db/registry/load-config";
 import { getServerClient } from "./page-server-orpc/server-client.ts";
 import * as v from "valibot";
+import type { BlockSchemaKey } from "@teamscala/db/registry/generated/block-schema";
+import type { ConfigKey } from "@teamscala/db/registry/generated/config";
 
 const AgentConfigSchema = v.object({ agentId: v.string() });
 
+// THE PUSHED BLOCK NAME IS AN IMPORTED IDENTITY, NEVER A SPELLED STRING.
+// discover-blocks keys the Puck registry off block_schema.slug alone
+// (`components[row.slug] = …`), so a type that is not a live slug resolves to
+// nothing — and because injection is fail-soft, the page renders unchanged with
+// no error. That is exactly how the bubble went missing from every gated
+// proposal and agreement: the block was consolidated to ResourceLauncher and
+// these injectors kept pushing their pre-consolidation names. BlockSchemaKey is
+// the generated union of live slugs, so annotating it here makes a stale name a
+// COMPILE error instead of a silent absence (identity-is-imported-never-spelled).
+const LAUNCHER_BLOCK: BlockSchemaKey = "ResourceLauncher";
+
 /** Per-resource-type injection config — the only thing that varies. */
 export interface ResourceChatOptions {
 	/** Key in `resolved` holding the record (e.g. "proposal", "agreement"). */
 	resourceKey: string;
 	/** `config` row slug carrying { agentId } (e.g. "agreement-assistant-agent"). */
-	agentConfigSlug: string;
+	agentConfigSlug: ConfigKey;
 	/** Org id to scope the chat. If omitted, read from resolved[resourceKey].organisation_id
 	 *  (proposals); agreements pass it explicitly (org isn't on the resolved record). */
 	organisationId?: string;
@@ -145,7 +158,7 @@ export async function injectResourceChatLauncher(
 	try {
 		const runtimeContext = await buildResourceContext(resolved, opts.resourceKey);
 		(page.content as Array<Record<string, unknown>>).push({
-			type: "ResourceChatLauncher",
+			type: LAUNCHER_BLOCK,
 			props: {
 				id: `${opts.resourceKey}-chat-launcher`,
 				agentId,