@teamscala/service-boot 0.23.361 → 0.23.362

package/package.json

@@ -6,7 +6,7 @@
   },
   "name": "@teamscala/service-boot",
   "type": "module",
-  "version": "0.23.361",
+  "version": "0.23.362",
   "sideEffects": false,
   "imports": {
     "#service-boot/*": "./src/*",

package/src/handlers/platform-fault-escalation-logic.ts

@@ -147,6 +147,27 @@ export function formatSpanMinutes(minutes: number): string {
 	return `${hours >= 10 ? Math.round(hours) : Math.round(hours * 10) / 10} h`;
 }
 
+/**
+ * The WhatsApp message id from a GOWA /send/message result. The canonical
+ * shape (from the spec the api-gowa adapter is generated from,
+ * SendResponse = { code, message, results: { message_id, status } }) is
+ * `results.message_id`; the legacy shape returned the bare id string as
+ * `results`. Delivery is only VERIFIED on a real id — `"true"`, a status
+ * string, or an empty body is not a message id and must not be recorded as
+ * delivered.
+ */
+export function extractGowaMessageId(sendResult: unknown): string | null {
+	const results = (sendResult as { results?: unknown } | undefined)?.results;
+	if (typeof results === "string") {
+		return /^[A-Z0-9]{8,}$/i.test(results) ? results : null;
+	}
+	if (results && typeof results === "object") {
+		const id = (results as { message_id?: unknown }).message_id;
+		if (typeof id === "string" && id.length > 0) return id;
+	}
+	return null;
+}
+
 /**
  * The escalation message — escalation-routing's three-field contract adapted
  * to an automated detector: what was OBSERVED (evidence), what it MEANS

package/src/handlers/platform-fault-escalation.test.ts

@@ -12,6 +12,7 @@ import { describe, expect, test } from "bun:test";
 import {
 	composeEscalationMessage,
 	decideSweep,
+	extractGowaMessageId,
 	type EscalationEpisode,
 	type FaultAggregate,
 	type FaultEscalationPolicy,
@@ -166,6 +167,26 @@ describe("decideSweep — resolution + re-arm", () => {
 	});
 });
 
+describe("extractGowaMessageId — delivery verification", () => {
+	test("the canonical GOWA SendResponse shape yields results.message_id", () => {
+		expect(extractGowaMessageId({ code: "SUCCESS", results: { message_id: "3EB089B9D6ADD58153C561", status: "sent" } })).toBe(
+			"3EB089B9D6ADD58153C561",
+		);
+	});
+
+	test("the legacy bare-string results shape yields the id", () => {
+		expect(extractGowaMessageId({ results: "3EB089B9D6ADD58153C561" })).toBe("3EB089B9D6ADD58153C561");
+	});
+
+	test("a 'true' ack is NOT a message id — delivery stays unverified", () => {
+		// A boolean-ish ack string must never be recorded as a delivered id:
+		// that would mark the episode delivered with an unfollowable handle.
+		expect(extractGowaMessageId({ results: "true" })).toBeNull();
+		expect(extractGowaMessageId({ code: "SUCCESS", message: "sent", results: { status: "sent" } })).toBeNull();
+		expect(extractGowaMessageId({ code: "SUCCESS" })).toBeNull();
+	});
+});
+
 describe("composeEscalationMessage", () => {
 	test("carries the three escalation-routing fields and stays phone-sized", () => {
 		const message = composeEscalationMessage({

package/src/handlers/platform-fault-escalation.ts

@@ -55,6 +55,7 @@ import {
 	composeEscalationDescription,
 	composeEscalationMessage,
 	decideSweep,
+	extractGowaMessageId,
 	type EscalationEpisode,
 	type FaultAggregate,
 	type KindThresholdOverride,
@@ -178,17 +179,6 @@ async function resolvePaDeviceId(paPhoneDigits: string): Promise<string | undefi
 	return match?.id;
 }
 
-function extractMessageId(sendResult: unknown): string | null {
-	const results = (sendResult as { results?: unknown } | undefined)?.results;
-	const id =
-		typeof results === "string"
-			? results
-			: Array.isArray(results)
-				? ((results[0] as { id?: unknown } | undefined)?.id as string | undefined)
-				: ((results as { id?: unknown } | undefined)?.id as string | undefined);
-	return typeof id === "string" && id.length > 0 ? id : null;
-}
-
 async function deliverEscalation(
 	kind: string,
 	aggregate: FaultAggregate,
@@ -246,7 +236,7 @@ async function deliverEscalation(
 
 	// 3. VERIFY delivery before recording it: the send must return a WhatsApp
 	// message id. No id => throw, the claim stays undelivered, next sweep retries.
-	const messageId = extractMessageId(sendResult);
+	const messageId = extractGowaMessageId(sendResult);
 	if (!messageId) {
 		throw new Error(
 			`platform-fault-escalation: WhatsApp send for '${kind}' returned no message id — not recording delivery`,