@teamscala/service-boot 0.23.330 → 0.23.332

package/package.json

@@ -6,7 +6,7 @@
   },
   "name": "@teamscala/service-boot",
   "type": "module",
-  "version": "0.23.330",
+  "version": "0.23.332",
   "sideEffects": false,
   "files": [
     "src"
@@ -38,6 +38,7 @@
     "@teamscala/proc-walker": "*",
     "@teamscala/realtime-utils": "*",
     "@teamscala/resolver-engine": "*",
+    "@teamscala/safe-fallback": "*",
     "@teamscala/timing": "*",
     "@teamscala/tool-executor": "*",
     "@teamscala/watchdog": "*",
@@ -402,6 +403,14 @@
       "types": "./src/fn-routers/task-sync-brief.d.ts",
       "default": "./src/fn-routers/task-sync-brief.ts"
     },
+    "./fn-routers/task-sync-close": {
+      "types": "./src/fn-routers/task-sync-close.d.ts",
+      "default": "./src/fn-routers/task-sync-close.ts"
+    },
+    "./fn-routers/task-sync-close.ts": {
+      "types": "./src/fn-routers/task-sync-close.d.ts",
+      "default": "./src/fn-routers/task-sync-close.ts"
+    },
     "./fn-routers/task-sync-dispatch": {
       "types": "./src/fn-routers/task-sync-dispatch.d.ts",
       "default": "./src/fn-routers/task-sync-dispatch.ts"

package/src/fn-routers/task-sync-close.d.ts

@@ -0,0 +1,41 @@
+/**
+ * @system service-boot
+ * @status handwritten
+ * @edit edit directly
+ *
+ * Lane-close write-through for task-sync. The session-owning fleet runtime
+ * calls this ORPC procedure before releasing an ACP lane, so work_items remains
+ * the durable lifecycle source without a second raw-SQL writer in the host.
+ */
+import * as v from "valibot";
+import { type Context } from "./auth-router.ts";
+import type { WorkItem } from "./task-sync-router.ts";
+export declare const closeLaneInput: v.ObjectSchema<{
+    readonly lane_session: v.SchemaWithPipe<readonly [v.StringSchema<undefined>, v.MinLengthAction<string, 1, "lane_session is required">]>;
+    readonly disposition: v.PicklistSchema<["completed", "needs_retry", "failed", "orchestrator_closed", "orphaned"], undefined>;
+}, undefined>;
+export interface ClosedTaskState {
+    task_id: string;
+    task_status: "done" | "archived";
+    completed: boolean;
+    kind_data: Record<string, unknown>;
+}
+export declare function closedTaskState(task: Pick<WorkItem, "id" | "kind_data">, disposition: v.InferOutput<typeof closeLaneInput>["disposition"]): ClosedTaskState;
+export declare const closeLaneHandler: import("@orpc/server").DecoratedProcedure<import("@orpc/server").MergedInitialContext<Context & Record<never, never>, Context, Context>, import("@orpc/server").MergedCurrentContext<Context, {
+    headers: Headers;
+    resolveUser?: (headers: Headers, prisma: any) => Promise<import("./auth-router.ts").User | null>;
+    prisma: any;
+    user: import("./auth-router.ts").User;
+    orgId: string | null | undefined;
+}>, v.ObjectSchema<{
+    readonly lane_session: v.SchemaWithPipe<readonly [v.StringSchema<undefined>, v.MinLengthAction<string, 1, "lane_session is required">]>;
+    readonly disposition: v.PicklistSchema<["completed", "needs_retry", "failed", "orchestrator_closed", "orphaned"], undefined>;
+}, undefined>, import("@orpc/contract").Schema<{
+    task_id: string;
+    task_status: "archived" | "done";
+    reconciled: boolean;
+}, {
+    task_id: string;
+    task_status: "archived" | "done";
+    reconciled: boolean;
+}>, Record<never, never>, Record<never, never>>;

package/src/fn-routers/task-sync-close.test.ts

@@ -0,0 +1,44 @@
+/**
+ * @system service-boot
+ * @status handwritten
+ * @edit edit directly
+ */
+
+import { describe, expect, it } from "bun:test";
+import { closedTaskState } from "./task-sync-close.ts";
+
+const task = {
+	id: "task-1",
+	kind_data: {
+		lane: { session: "acp-session", cli_kind: "zerostack", live: true },
+		assignee_type: "agent",
+	},
+};
+
+describe("closedTaskState", () => {
+	it("marks completed work done and the lane non-live", () => {
+		expect(closedTaskState(task, "completed")).toEqual({
+			task_id: "task-1",
+			task_status: "done",
+			completed: true,
+			kind_data: {
+				lane: { session: "acp-session", cli_kind: "zerostack", live: false },
+				assignee_type: "agent",
+			},
+		});
+	});
+
+	it("archives every disposition that does not prove completion", () => {
+		for (const disposition of [
+			"needs_retry",
+			"failed",
+			"orchestrator_closed",
+			"orphaned",
+		] as const) {
+			const state = closedTaskState(task, disposition);
+			expect(state.task_status).toBe("archived");
+			expect(state.completed).toBe(false);
+			expect((state.kind_data.lane as { live: boolean }).live).toBe(false);
+		}
+	});
+});

package/src/fn-routers/task-sync-close.ts

@@ -0,0 +1,82 @@
+/**
+ * @system service-boot
+ * @status handwritten
+ * @edit edit directly
+ *
+ * Lane-close write-through for task-sync. The session-owning fleet runtime
+ * calls this ORPC procedure before releasing an ACP lane, so work_items remains
+ * the durable lifecycle source without a second raw-SQL writer in the host.
+ */
+
+import { ORPCError } from "@orpc/server";
+import * as v from "valibot";
+import { authed, type Context } from "./auth-router.ts";
+import type { Prisma, WorkItem } from "./task-sync-router.ts";
+
+export const closeLaneInput = v.object({
+	lane_session: v.pipe(v.string(), v.minLength(1, "lane_session is required")),
+	disposition: v.picklist([
+		"completed",
+		"needs_retry",
+		"failed",
+		"orchestrator_closed",
+		"orphaned",
+	]),
+});
+
+export interface ClosedTaskState {
+	task_id: string;
+	task_status: "done" | "archived";
+	completed: boolean;
+	kind_data: Record<string, unknown>;
+}
+
+export function closedTaskState(
+	task: Pick<WorkItem, "id" | "kind_data">,
+	disposition: v.InferOutput<typeof closeLaneInput>["disposition"],
+): ClosedTaskState {
+	const completed = disposition === "completed";
+	const lane =
+		task.kind_data.lane && typeof task.kind_data.lane === "object"
+			? (task.kind_data.lane as Record<string, unknown>)
+			: {};
+	return {
+		task_id: task.id,
+		task_status: completed ? "done" : "archived",
+		completed,
+		kind_data: { ...task.kind_data, lane: { ...lane, live: false } },
+	};
+}
+
+export const closeLaneHandler = authed
+	.input(closeLaneInput)
+	.handler(async ({ input, context }) => {
+		const prisma = (context as Context).prisma as Prisma;
+		const task = await prisma.work_items.findFirst({
+			where: {
+				kind: "task",
+				kind_data: { path: ["lane", "session"], equals: input.lane_session },
+			},
+			orderBy: { created_at: "desc" },
+		});
+		if (!task) {
+			throw new ORPCError("NOT_FOUND", {
+				message: `No task is bound to ACP lane ${input.lane_session}`,
+			});
+		}
+		const state = closedTaskState(task, input.disposition);
+		await prisma.work_items.update({
+			where: { id: task.id },
+			data: {
+				kind_data: state.kind_data,
+				status: state.task_status,
+				completed: state.completed,
+			},
+			select: { id: true },
+		});
+		return {
+			task_id: state.task_id,
+			task_status: state.task_status,
+			reconciled: true,
+		};
+	});

package/src/fn-routers/task-sync-router.d.ts

@@ -26,6 +26,7 @@
  *
  * These procedures are the ONLY CLI-agnostic surface an adapter calls:
  *   bindLane           — bind (create-or-confirm) a lane's task. SessionStart.
+ *   closeLane          — reconcile a session-owned lane before its runtime releases it.
  *   upsertFromTaskList — write a lane's current task list through to subtasks (AGENT→DB leg, OpenCode whole-list).
  *   upsertFromTaskHook — apply a per-item Claude Code PostToolUse:TaskCreate/Update/Delete (AGENT→DB leg, Claude per-item).
  *   readTaskList       — read a lane's current subtasks as a normalized list (DB→AGENT backstop).
@@ -344,6 +345,25 @@ export declare const taskSyncRouter: {
     }, {
         work_item_id: string;
     }>, Record<never, never>, Record<never, never>>;
+    /** RUNTIME→DB lifecycle close: mark lane.live=false and reconcile task status before the ACP owner releases the session. */
+    closeLane: import("@orpc/server").DecoratedProcedure<import("@orpc/server").MergedInitialContext<Context & Record<never, never>, Context, Context>, import("@orpc/server").MergedCurrentContext<Context, {
+        headers: Headers;
+        resolveUser?: (headers: Headers, prisma: any) => Promise<import("./auth-router.ts").User | null>;
+        prisma: any;
+        user: import("./auth-router.ts").User;
+        orgId: string | null | undefined;
+    }>, v.ObjectSchema<{
+        readonly lane_session: v.SchemaWithPipe<readonly [v.StringSchema<undefined>, v.MinLengthAction<string, 1, "lane_session is required">]>;
+        readonly disposition: v.PicklistSchema<["completed", "needs_retry", "failed", "orchestrator_closed", "orphaned"], undefined>;
+    }, undefined>, import("@orpc/contract").Schema<{
+        task_id: string;
+        task_status: "archived" | "done";
+        reconciled: boolean;
+    }, {
+        task_id: string;
+        task_status: "archived" | "done";
+        reconciled: boolean;
+    }>, Record<never, never>, Record<never, never>>;
     /**
      * TAB→DB rename back-write: the session-picker `/rpc/rename` calls this after
      * renaming a tmux window to update the bound task's title BY SESSION (never

package/src/fn-routers/task-sync-router.ts

@@ -26,6 +26,7 @@
  *
  * These procedures are the ONLY CLI-agnostic surface an adapter calls:
  *   bindLane           — bind (create-or-confirm) a lane's task. SessionStart.
+ *   closeLane          — reconcile a session-owned lane before its runtime releases it.
  *   upsertFromTaskList — write a lane's current task list through to subtasks (AGENT→DB leg, OpenCode whole-list).
  *   upsertFromTaskHook — apply a per-item Claude Code PostToolUse:TaskCreate/Update/Delete (AGENT→DB leg, Claude per-item).
  *   readTaskList       — read a lane's current subtasks as a normalized list (DB→AGENT backstop).
@@ -39,11 +40,13 @@
 import { getAppLogger } from "@teamscala/logger/app-loggers";
 import { recordEvent } from "@teamscala/event-log/record-event";
 import { getPlatformOrgId } from "@teamscala/db/registry/platform";
+import { createSafeFallback } from "@teamscala/safe-fallback/create-safe-fallback";
 import { authed, type Context } from "./auth-router.ts";
 import { notifyLaneOfTaskChange } from "./task-sync-dispatch.ts";
 import { resolveLaneTask, resolveLaneWorkName } from "./task-sync-lane.ts";
 import { readAssignedBriefHandler } from "./task-sync-brief.ts";
 import { renameLaneTaskHandler } from "./task-sync-rename.ts";
+import { closeLaneHandler } from "./task-sync-close.ts";
 import {
 	adoptAssignmentTask,
 	bindLaneInput,
@@ -171,6 +174,12 @@ export function resolveBindOrg(explicit?: string): string {
 	return explicit ?? getPlatformOrgId();
 }
 
+const laneTaskCreateFallback = createSafeFallback<WorkItem | null>({
+	name: "task-sync:lane-task-create-race",
+	onFailure: "fail-open-noisy",
+	degradedResult: null,
+});
+
 /**
  * Record a task-sync hook DISCARD to event_log so it is observable + queryable,
  * not silently swallowed by the hook command's `>/dev/null 2>&1 || true`. The
@@ -286,8 +295,8 @@ async function ensureLaneTask(
 	const name = pane ? await resolveLaneWorkName(prisma, pane) : null;
 	if (!name || name.trim().toLowerCase() === "lane") return null;
 	const lane: LaneIdentity = { pane: pane ?? "", session, cli_kind: "claude-code", role: "agent" };
-	try {
-		return await prisma.work_items.create({
+	const created = await laneTaskCreateFallback.call(() =>
+		prisma.work_items.create({
 			data: {
 				kind: "task",
 				parent_id: null,
@@ -299,10 +308,9 @@ async function ensureLaneTask(
 				assignee_id: session,
 				kind_data: { lane },
 			},
-		});
-	} catch {
-		return resolveLaneTask(prisma, session);
-	}
+		}),
+	);
+	return created ?? resolveLaneTask(prisma, session);
 }
 
 
@@ -773,6 +781,9 @@ export const taskSyncRouter = {
 	/** SPAWNER→DB brief mint: `spawn_agent_tab` turns an initialPrompt into the task row (brief = first comment) the lane self-briefs from; returns the work_item_id that rides the spawn payload. Handler in task-sync-assign.ts. */
 	createBriefTask: createBriefTaskHandler,
 
+	/** RUNTIME→DB lifecycle close: mark lane.live=false and reconcile task status before the ACP owner releases the session. */
+	closeLane: closeLaneHandler,
+
 	/**
 	 * TAB→DB rename back-write: the session-picker `/rpc/rename` calls this after
 	 * renaming a tmux window to update the bound task's title BY SESSION (never