@teamscala/service-boot 0.23.288 → 0.23.290

package/package.json

@@ -6,7 +6,7 @@
   },
   "name": "@teamscala/service-boot",
   "type": "module",
-  "version": "0.23.288",
+  "version": "0.23.290",
   "sideEffects": false,
   "files": [
     "src"
@@ -489,14 +489,6 @@
       "types": "./src/handlers/scala-tools-currency-watch.d.ts",
       "default": "./src/handlers/scala-tools-currency-watch.ts"
     },
-    "./handlers/scheduled-browser-tests": {
-      "types": "./src/handlers/scheduled-browser-tests.d.ts",
-      "default": "./src/handlers/scheduled-browser-tests.ts"
-    },
-    "./handlers/scheduled-browser-tests.ts": {
-      "types": "./src/handlers/scheduled-browser-tests.d.ts",
-      "default": "./src/handlers/scheduled-browser-tests.ts"
-    },
     "./handlers/sweep-event-log": {
       "types": "./src/handlers/sweep-event-log.d.ts",
       "default": "./src/handlers/sweep-event-log.ts"

package/src/pg-boss-mount.d.ts

@@ -17,7 +17,6 @@ import "./handlers/sweep-host-cache.ts";
 import "./handlers/bun-stable-watch.ts";
 import "./handlers/whatsapp-liveness.ts";
 import "./handlers/upstream-issue-sync.ts";
-import "./handlers/scheduled-browser-tests.ts";
 import "./handlers/scala-tools-currency-watch.ts";
 import "./handlers/registry-stale-inactive-sweep.ts";
 import "./handlers/pane-outbox-drain.ts";

package/src/pg-boss-mount.ts

@@ -30,7 +30,6 @@ import "./handlers/sweep-host-cache.ts";
 import "./handlers/bun-stable-watch.ts";
 import "./handlers/whatsapp-liveness.ts";
 import "./handlers/upstream-issue-sync.ts";
-import "./handlers/scheduled-browser-tests.ts";
 import "./handlers/scala-tools-currency-watch.ts";
 import "./handlers/registry-stale-inactive-sweep.ts";
 import "./handlers/pane-outbox-drain.ts";

package/src/two-phase-boot.test.ts

@@ -0,0 +1,84 @@
+/**
+ * @system server-boot
+ * @status handwritten
+ * @edit edit directly
+ *
+ * Phase-2 step isolation: a client-asset build failure must not prevent
+ * scheduled jobs and pg-boss from mounting.
+ *
+ * Asserted against the SOURCE rather than by booting a service, because the
+ * behaviour is an ordering/error-handling property of buildFullApp and booting
+ * it here would need a database, a registry, a Vite build and a live pg-boss.
+ * The property is structural: buildClientAssets must be inside a try/catch that
+ * appears BEFORE the startScheduledJobs and mountPgBoss calls. That is exactly
+ * what regressed, and a source assertion fails the moment someone re-awaits it
+ * unguarded — which is the regression this locks.
+ */
+
+import { describe, expect, test } from "bun:test";
+
+const src = await Bun.file(new URL("./two-phase-boot.ts", import.meta.url)).text();
+
+/** The body of buildFullApp, where phase-2 ordering lives. */
+function buildFullAppBody(): string {
+	const start = src.indexOf("export async function buildFullApp");
+	expect(start).toBeGreaterThan(-1);
+	return src.slice(start);
+}
+
+describe("phase-2 step isolation", () => {
+	/*
+	 * THE MEASURED REGRESSION. buildClientAssets was awaited unguarded, so a
+	 * throw aborted buildFullApp before startScheduledJobs and mountPgBoss ran.
+	 * The caller's catch logged "Failed to build full app, continuing with
+	 * minimal app", which reads as UI-only degradation while every scheduled job
+	 * and pg-boss handler on the service had silently died.
+	 *
+	 * 2026-07-30: a stale portal-ui artifact importing the retired @teamgbg scope
+	 * threw ENOENT on a missing theme CSS file in scala-agents. No
+	 * "scheduledJobs DONE" line appeared for ~20 minutes across repeated boots,
+	 * the pane-outbox drain never mounted, and the operator's WhatsApp assistant
+	 * went silent — because of a stylesheet. The service reported `online` and
+	 * answered /health throughout.
+	 */
+	test("buildClientAssets is wrapped so its failure cannot abort phase-2", () => {
+		const body = buildFullAppBody();
+		const call = body.indexOf("buildClientAssets(serviceSlug)");
+		expect(call).toBeGreaterThan(-1);
+
+		// A try must open before the call and a catch must follow it, so a throw
+		// is contained rather than propagating out of buildFullApp.
+		const tryBefore = body.lastIndexOf("try {", call);
+		expect(tryBefore).toBeGreaterThan(-1);
+		expect(body.slice(call).indexOf("catch")).toBeGreaterThan(-1);
+	});
+
+	/*
+	 * THE LOAD-BEARING ASSERTION. A `catch` must appear BETWEEN the build call and
+	 * the startScheduledJobs call. That is what makes this test fail if the guard
+	 * is removed: unwrap the await and there is no catch in that span, so the
+	 * expectation cannot be satisfied by some unrelated try/catch elsewhere in the
+	 * function. Ordering alone would NOT catch the regression — the original buggy
+	 * code also had jobs after the build; it just had no catch in between.
+	 */
+	test("a catch sits between the build and the jobs, so a throw cannot skip them", () => {
+		const body = buildFullAppBody();
+		const build = body.indexOf("buildClientAssets(serviceSlug)");
+		const jobs = body.indexOf("startScheduledJobs(");
+		const boss = body.indexOf("mountPgBoss(");
+		expect(build).toBeGreaterThan(-1);
+		expect(jobs).toBeGreaterThan(build);
+		expect(boss).toBeGreaterThan(build);
+
+		const between = body.slice(build, jobs);
+		expect(between).toContain("catch");
+	});
+
+	test("the build failure is logged, so a degraded bundle is never silent", () => {
+		const body = buildFullAppBody();
+		const guardCatch = body.indexOf("catch", body.indexOf("buildClientAssets(serviceSlug)"));
+		// The catch must record something; swallowing here would reproduce the
+		// original invisibility from the other direction.
+		expect(body.slice(guardCatch, guardCatch + 400)).toContain("log.error");
+	});
+});

package/src/two-phase-boot.ts

@@ -396,9 +396,37 @@ export async function buildFullApp(
 	const log = getAppLogger();
 	const { config, serviceSlug, mountRegistry, components, loaded, app: minimalApp } = minimalResult;
 
-	// Client asset building (expensive: Vite build)
-	await buildClientAssets(serviceSlug);
-	log.info(`[two-phase-boot:${serviceSlug}] phase-2 step: buildClientAssets DONE`);
+	// Client asset building (expensive: Vite build).
+	//
+	// ISOLATED, because a PRESENTATION failure must not take out BACKGROUND WORK.
+	// This was awaited unguarded, so a throw here aborted buildFullApp before
+	// startScheduledJobs and mountPgBoss ran, and the caller's catch logged
+	// "Failed to build full app, continuing with minimal app" — which reads as a
+	// UI-only degradation while having silently killed every scheduled job and
+	// every pg-boss handler on the service.
+	//
+	// Measured 2026-07-30: a stale @teamscala/portal-ui artifact still importing
+	// the retired @teamgbg scope threw ENOENT on a missing theme CSS file in
+	// scala-agents. Zero "scheduledJobs DONE" lines appeared for ~20 minutes
+	// across repeated boots, the pane-outbox drain never mounted, and the
+	// operator's WhatsApp assistant went silent — because of a stylesheet. The
+	// service stayed `online` and healthy throughout, so nothing surfaced it.
+	//
+	// The steps after this one do not depend on client assets: jobs and pg-boss
+	// need the registry and the DB, not a bundle. Ordering them behind a Vite
+	// build was incidental, so the coupling was never intended.
+	try {
+		await buildClientAssets(serviceSlug);
+		log.info(`[two-phase-boot:${serviceSlug}] phase-2 step: buildClientAssets DONE`);
+	} catch (error) {
+		// Loud but non-fatal: the tombstone manifest written by buildClientAssets
+		// already makes SSR serve the prior bundle, so degrading here costs the
+		// new bundle, never the background work.
+		log.error(
+			`[two-phase-boot:${serviceSlug}] phase-2 step: buildClientAssets FAILED — continuing to scheduled jobs and pg-boss (a client-asset failure must not stop background work)`,
+			{ error: error instanceof Error ? error.message : String(error) },
+		);
+	}
 
 	// Scheduled jobs
 	startScheduledJobs(config, mountRegistry, serviceSlug);

package/src/handlers/scheduled-browser-tests.d.ts

@@ -1 +0,0 @@
-export {};

package/src/handlers/scheduled-browser-tests.ts

@@ -1,85 +0,0 @@
-/**
- * @system server-boot
- * @status handwritten
- * @edit edit directly
- *
- * The `scheduled-browser-tests` pg-boss handler — the single scheduled-test
- * home for the platform's regression suite (open migration
- * `test-execution-consolidation`). Spawns `scala-tools test run --existing`
- * on a cadence so every automated test execution flows through the one
- * registry-driven harness, emitting the queryable `test.run.*` event pair
- * (event-log-is-the-only-durable-event-log) that the deleted quartet of
- * interval `guard_rule` rows never did (2026-06-29: 4 interval guards each
- * autonomously drove headless Chrome against live UI services on 15/30-min
- * timers with no central schedule/run-log).
- *
- * `--existing` runs every ACTIVE `test_vector` row across all services (the
- * registry suite — both auto-generated and hand-authored vectors); `--no-boot`
- * leaves service supervision to PM2 so a DOWN service fails its own health
- * vector (the intended signal) instead of the scheduler booting a duplicate.
- * `--source scheduled:scheduled-browser-tests` stamps the run's invoker block
- * so a scheduled run is distinguishable from a manual agent run in the event
- * log (`SELECT … FROM event_log WHERE kind LIKE 'test.run.%'`).
- *
- * The per-service outcomes land in the `test.run.result` events sharing the
- * spawned run's `run_id`; this handler records only the schedule-level
- * `scheduled.test.run` "did the run fire + finish" event. Spawns via
- * `@teamscala/os` `spawn` (the single spawn surface); `scala-tools` resolves on
- * PATH — on the dev host that is the source-mode link (always current).
- *
- * Registered under slug `@teamscala/service-boot:scheduled-browser-tests`.
- * Mirrors `bun-stable-watch` / `upstream-issue-sync` (dev-host pg-boss
- * handlers on scala-loga).
- */
-import type { ScheduledJobConfig } from "@teamscala/db-validation/registry-schemas/scheduled-job";
-import { recordEvent } from "@teamscala/event-log/record-event";
-import { getAppLogger } from "@teamscala/logger/app-loggers";
-import { spawn } from "@teamscala/os/spawn";
-import { loadRegistryConfig } from "@teamscala/db/registry/load-config";
-import * as v from "valibot";
-import { pgBossHandlerRegistry } from "../pg-boss-handler-registry.ts";
-
-const SOURCE = "scheduled:scheduled-browser-tests";
-
-// A full --existing sweep across all UI services (Chrome-driven hydration +
-// responsive + node-diff vectors, paced 5s apart between browser vectors) runs
-// in the tens of minutes; bound the subprocess so a stuck vector's 90s wall can
-// never hang the pg-boss worker indefinitely. exitCode null (SIGKILL on
-// timeout) is treated as a failure + recorded.
-const DEFAULT_RUN_TIMEOUT_MS = 30 * 60 * 1000;
-let cachedRunTimeoutMs: number | undefined;
-async function getRunTimeoutMs(): Promise<number> {
-	if (cachedRunTimeoutMs !== undefined) return cachedRunTimeoutMs;
-	const row = await loadRegistryConfig("config", "scheduled-browser-tests", v.looseObject({}));
-	cachedRunTimeoutMs = (row?.run_timeout_ms as number | undefined) ?? DEFAULT_RUN_TIMEOUT_MS;
-	return cachedRunTimeoutMs;
-}
-
-async function scheduledBrowserTests(_ctx: { config: ScheduledJobConfig }): Promise<void> {
-	const log = getAppLogger();
-
-	const { stdout, stderr, exitCode } = await spawn({
-		name: "scheduled-browser-tests",
-		command: ["scala-tools", "test", "run", "--existing", "--no-boot", "--source", SOURCE],
-		timeoutMs: await getRunTimeoutMs(),
-	});
-
-	const code = exitCode ?? -1;
-	const ok = exitCode === 0;
-	// Surface the run's own summary line (the CLI prints a final
-	// "N/M vectors pass across K services" footer) so the schedule outcome is
-	// visible in the loga tail without re-querying the event log.
-	const tail = (stdout || stderr || "").trim().split("\n").slice(-2).join(" | ");
-	log.info(
-		`[scheduled-browser-tests] scala-tools test run --existing exited ${code} (${ok ? "pass" : "fail"}) — ${tail}`,
-	);
-	recordEvent({
-		kind: "scheduled.test.run",
-		payload: { source: SOURCE, exit_code: code, ok },
-	});
-}
-
-pgBossHandlerRegistry.register(
-	"@teamscala/service-boot:scheduled-browser-tests",
-	scheduledBrowserTests,
-);