@teamscala/service-boot 0.23.284

package/src/agreement-gate.test.ts

@@ -0,0 +1,118 @@
+/**
+ * @system service-boot
+ * @status handwritten
+ * @edit edit directly
+ *
+ * Regression test for the new-flow agreement gate's body-region targeting.
+ * The body region of the public sign shell IS resolved.page (composed by
+ * register-registry-page-route.ts Branch 2 as extractPuckData(resolved.page)).
+ * A prior version of getBodyContentArray scored every region by top-level
+ * non-shell block count and picked the highest — which misruted to /header when
+ * the body wrapped its clauses inside a Container (body top-level count ~1-2
+ * vs nested clause count ~40). onUnauthorized then cleared the HEADER and
+ * injected the gate there, leaving the entire agreement body visible past the
+ * gate. This test pins the fix: the body is withheld, the header is untouched.
+ */
+
+import { describe, expect, test } from "bun:test";
+import { agreementGateConfig } from "./agreement-gate.ts";
+
+const AGREEMENT_UUID = "019ecae8-518d-7000-8786-7255ca8716eb";
+
+/** A resolved graph shaped like the real sign shell at the failing case:
+ *  body wraps its clauses in a Container (low top-level score), header has more
+ *  top-level blocks (would out-score the body under the old heuristic). */
+function makeResolved(): Record<string, unknown> {
+	return {
+		page: {
+			id: "page-1",
+			meta_title: "Demo Agreement",
+			name: "Demo Agreement",
+			puck_data: {
+				root: { props: {} },
+				zones: {},
+				content: [
+					{
+						type: "Container",
+						props: {
+							id: "body-container",
+							content: [
+								{ type: "Text", props: { id: "t1", text: "1. Parties" } },
+								{ type: "Text", props: { id: "t2", text: "16. Electronic Signature" } },
+								{ type: "Text", props: { id: "t3", text: "Scope of Services & Fees" } },
+							],
+						},
+					},
+				],
+			},
+		},
+		header: {
+			id: "header-page",
+			puck_data: {
+				root: { props: {} },
+				zones: {},
+				// 4 top-level blocks — MORE than the body's single Container. The
+				// old scorer picked this region as the "body" and cleared it.
+				content: [
+					{ type: "OrgLogo", props: { id: "logo" } },
+					{ type: "Text", props: { id: "h1", text: "Brand" } },
+					{ type: "Text", props: { id: "h2", text: "Nav A" } },
+					{ type: "Text", props: { id: "h3", text: "Nav B" } },
+				],
+			},
+		},
+		footer: {
+			id: "footer-page",
+			puck_data: {
+				root: { props: {} },
+				zones: {},
+				content: [{ type: "Text", props: { id: "f1", text: "© 2026" } }],
+			},
+		},
+	};
+}
+
+describe("agreement-gate — body-region targeting", () => {
+	test("onUnauthorized withholds the BODY (resolved.page), not the header", async () => {
+		const resolved = makeResolved();
+		const bodyContent = (
+			(resolved.page as { puck_data: { content: unknown[] } }).puck_data
+				.content
+		);
+		const headerContent = (
+			(resolved.header as { puck_data: { content: unknown[] } }).puck_data
+				.content
+		);
+
+		await agreementGateConfig.onUnauthorized(resolved, AGREEMENT_UUID);
+
+		// Body is reduced to the injected SignIn gate — clauses are NOT leaked.
+		expect(bodyContent).toHaveLength(1);
+		const gate = bodyContent[0] as {
+			type: string;
+			props: { mode?: string; gateContextValue?: string };
+		};
+		expect(gate.type).toBe("SignIn");
+		expect(gate.props.mode).toBe("gate");
+		expect(gate.props.gateContextValue).toBe(AGREEMENT_UUID);
+
+		// Header is untouched — the old bug cleared this region instead.
+		expect(headerContent).toHaveLength(4);
+		expect((headerContent[0] as { type: string }).type).toBe("OrgLogo");
+	});
+
+	test("onUnauthorized leaves no agreement body text reachable past the gate", async () => {
+		const resolved = makeResolved();
+		await agreementGateConfig.onUnauthorized(resolved, AGREEMENT_UUID);
+
+		const bodyContent = (
+			(resolved.page as { puck_data: { content: unknown[] } }).puck_data
+				.content
+		);
+		// The clause text must not survive anywhere in the withheld body tree.
+		const serialized = JSON.stringify(bodyContent);
+		expect(serialized).not.toContain("Parties");
+		expect(serialized).not.toContain("Electronic Signature");
+		expect(serialized).not.toContain("Scope of Services");
+	});
+});