@teamkeel/functions-runtime 0.387.1-next.3 → 0.387.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@teamkeel/functions-runtime",
-  "version": "0.387.1-next.3",
+  "version": "0.387.1",
   "description": "Internal package used by @teamkeel/sdk",
   "main": "src/index.js",
   "scripts": {

package/src/database.js

@@ -4,8 +4,8 @@ const { AuditContextPlugin } = require("./auditing");
 const pg = require("pg");
 const { PROTO_ACTION_TYPES } = require("./consts");
 const { withSpan } = require("./tracing");
-import { NeonDialect } from "kysely-neon";
-import ws from 'ws';
+const { NeonDialect } = require("kysely-neon");
+const ws = require("ws");
 
 // withDatabase is responsible for setting the correct database client in our AsyncLocalStorage
 // so that the the code in a custom function uses the correct client.
@@ -153,12 +153,25 @@ function getDialect() {
       return new PostgresDialect({
         pool: new InstrumentedPool({
           Client: InstrumentedClient,
+          // Increased idle time before closing a connection in the local pool (from 10s default).
+          // Establising a new connection on (almost) every functions query can be expensive, so this
+          // will reduce having to open connections as regularly. https://node-postgres.com/apis/pool
+          //
+          // NOTE: We should consider setting this to 0 (i.e. never pool locally) and open and close
+          // connections with each invocation. This is because the freeze/thaw nature of lambdas can cause problems
+          // with long-lived connections - see https://github.com/brianc/node-postgres/issues/2718
+          // Once we're "fully regional" this should not be a performance problem anymore.
+          //
+          // Although I doubt we will run into these freeze/thaw issues if idleTimeoutMillis is always shorter than the
+          // time is takes for a lambda to freeze (which is not a constant, but could be as short as several minutes,
+          // https://www.pluralsight.com/resources/blog/cloud/how-long-does-aws-lambda-keep-your-idle-functions-around-before-a-cold-start)
+          idleTimeoutMillis: 120000,
           connectionString: mustEnv("KEEL_DB_CONN"),
         }),
       });
     case "neon":
       return new NeonDialect({
-        connectionString: "postgres://keel_runtime:vr3PuGQGb06I1Q0Daj6S9gFFq00zWso8@ep-dry-fog-a21c7eft-pooler.eu-central-1.aws.neon.tech/neondb?sslmode=require",//        mustEnv("KEEL_DB_CONN"),
+        connectionString: mustEnv("KEEL_DB_CONN"),
         webSocketConstructor: ws,
       });
     default:
@@ -179,4 +192,4 @@ getDatabaseClient();
 
 module.exports.getDatabaseClient = getDatabaseClient;
 module.exports.useDatabase = useDatabase;
-module.exports.withDatabase = withDatabase;
+module.exports.withDatabase = withDatabase;