@teamkeel/functions-runtime 0.365.14 → 0.365.15-prerelease18

package/src/tryExecuteFunction.js

@@ -2,9 +2,9 @@ const { withDatabase } = require("./database");
 const {
   withPermissions,
   PERMISSION_STATE,
-  PermissionError,
   checkBuiltInPermissions,
 } = require("./permissions");
+const { PermissionError } = require("./errors");
 const { PROTO_ACTION_TYPES } = require("./consts");
 
 // tryExecuteFunction will create a new database transaction around a function call
@@ -16,7 +16,7 @@ function tryExecuteFunction(
   return withPermissions(permitted, async ({ getPermissionState }) => {
     return withDatabase(db, actionType, async ({ transaction }) => {
       const fnResult = await cb();
-      // api.permissions maintains an internal state of whether the current operation has been *explicitly* permitted/denied by the user in the course of their custom function, or if execution has already been permitted by a role based permission (evaluated in the main runtime).
+      // api.permissions maintains an internal state of whether the current function has been *explicitly* permitted/denied by the user in the course of their custom function, or if execution has already been permitted by a role based permission (evaluated in the main runtime).
       // we need to check that the final state is permitted or unpermitted. if it's not, then it means that the user has taken no explicit action to permit/deny
       // and therefore we default to checking the permissions defined in the schema automatically.
       switch (getPermissionState()) {

package/src/tryExecuteJob.js

@@ -1,9 +1,7 @@
 const { withDatabase } = require("./database");
-const {
-  withPermissions,
-  PERMISSION_STATE,
-  PermissionError,
-} = require("./permissions");
+const { withPermissions, PERMISSION_STATE } = require("./permissions");
+
+const { PermissionError } = require("./errors");
 
 // tryExecuteJob will create a new database transaction around a function call
 // and handle any permissions checks. If a permission check fails, then an Error will be thrown and the catch block will be hit.
@@ -11,8 +9,9 @@ function tryExecuteJob({ db, permitted, actionType, request }, cb) {
   return withPermissions(permitted, async ({ getPermissionState }) => {
     return withDatabase(db, actionType, async ({ transaction }) => {
       await cb();
-
-      // we need to check that the final state is unpermitted. if it's not, then it means that the user has taken no explicit action to permit/deny
+      // api.permissions maintains an internal state of whether the current operation has been *explicitly* permitted/denied by the user in the course of their custom function, or if execution has already been permitted by a role based permission (evaluated in the main runtime).
+      // we need to check that the final state is permitted or unpermitted. if it's not, then it means that the user has taken no explicit action to permit/deny
+      // and therefore we default to checking the permissions defined in the schema automatically.
       if (getPermissionState() === PERMISSION_STATE.UNPERMITTED) {
         throw new PermissionError(`Not permitted to access ${request.method}`);
       }

package/src/tryExecuteSubscriber.js

@@ -0,0 +1,10 @@
+const { withDatabase } = require("./database");
+
+// tryExecuteSubscriber will create a new database connection and execute the function call.
+function tryExecuteSubscriber({ db, actionType }, cb) {
+  return withDatabase(db, actionType, async () => {
+    await cb();
+  });
+}
+
+module.exports.tryExecuteSubscriber = tryExecuteSubscriber;