@teambit/workspace 1.0.218 → 1.0.219

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "@teambit/workspace",
-  "version": "1.0.218",
+  "version": "1.0.219",
   "homepage": "https://bit.cloud/teambit/workspace/workspace",
   "main": "dist/index.js",
   "componentId": {
     "scope": "teambit.workspace",
     "name": "workspace",
-    "version": "1.0.218"
+    "version": "1.0.219"
   },
   "dependencies": {
     "lodash": "4.17.21",
@@ -54,43 +54,43 @@
     "@teambit/explorer.ui.gallery.component-grid": "0.0.496",
     "@teambit/scopes.scope-id": "0.0.7",
     "@teambit/workspace.ui.empty-workspace": "0.0.508",
-    "@teambit/component": "1.0.218",
-    "@teambit/dependency-resolver": "1.0.218",
-    "@teambit/envs": "1.0.218",
+    "@teambit/component": "1.0.219",
+    "@teambit/dependency-resolver": "1.0.219",
+    "@teambit/envs": "1.0.219",
     "@teambit/logger": "0.0.951",
-    "@teambit/scope": "1.0.218",
-    "@teambit/graph": "1.0.218",
+    "@teambit/scope": "1.0.219",
+    "@teambit/graph": "1.0.219",
     "@teambit/cli": "0.0.858",
-    "@teambit/isolator": "1.0.218",
-    "@teambit/component-tree": "1.0.218",
+    "@teambit/isolator": "1.0.219",
+    "@teambit/component-tree": "1.0.219",
     "@teambit/harmony.modules.resolved-component": "0.0.497",
-    "@teambit/watcher": "1.0.218",
-    "@teambit/aspect-loader": "1.0.218",
-    "@teambit/config": "0.0.969",
+    "@teambit/watcher": "1.0.219",
+    "@teambit/aspect-loader": "1.0.219",
+    "@teambit/config": "0.0.970",
     "@teambit/global-config": "0.0.861",
     "@teambit/harmony.modules.requireable-component": "0.0.497",
     "@teambit/toolbox.modules.module-resolver": "0.0.7",
     "@teambit/workspace.modules.node-modules-linker": "0.0.166",
-    "@teambit/graphql": "1.0.218",
-    "@teambit/bundler": "1.0.218",
-    "@teambit/pubsub": "1.0.218",
-    "@teambit/ui": "1.0.218",
-    "@teambit/variants": "0.0.1062",
+    "@teambit/graphql": "1.0.219",
+    "@teambit/bundler": "1.0.219",
+    "@teambit/pubsub": "1.0.219",
+    "@teambit/ui": "1.0.219",
+    "@teambit/variants": "0.0.1063",
     "@teambit/component-issues": "0.0.142",
     "@teambit/workspace.modules.match-pattern": "0.0.505",
     "@teambit/component.ui.component-drawer": "0.0.397",
     "@teambit/lanes.hooks.use-lane-components": "0.0.260",
     "@teambit/lanes.hooks.use-lanes": "0.0.264",
     "@teambit/lanes.ui.models.lanes-model": "0.0.216",
-    "@teambit/command-bar": "1.0.218",
+    "@teambit/command-bar": "1.0.219",
     "@teambit/component.ui.component-filters.component-filter-context": "0.0.222",
     "@teambit/component.ui.component-filters.deprecate-filter": "0.0.220",
     "@teambit/component.ui.component-filters.env-filter": "0.0.228",
     "@teambit/component.ui.component-filters.show-main-filter": "0.0.213",
-    "@teambit/sidebar": "1.0.218",
+    "@teambit/sidebar": "1.0.219",
     "@teambit/ui-foundation.ui.react-router.slot-router": "0.0.508",
     "@teambit/component-descriptor": "0.0.417",
-    "@teambit/deprecation": "1.0.218",
+    "@teambit/deprecation": "1.0.219",
     "@teambit/ui-foundation.ui.buttons.collapser": "0.0.219",
     "@teambit/cloud.hooks.use-cloud-scopes": "0.0.3",
     "@teambit/preview.ui.preview-placeholder": "0.0.516",

package/workspace-component/workspace-component-loader.ts

@@ -134,10 +134,13 @@ export class WorkspaceComponentLoader {
 
     const { components: loadedComponents, invalidComponents } = await this.getAndLoadSlotOrdered(
       loadOrCached.idsToLoad || [],
-      loadOptsWithDefaults,
-      throwOnFailure
+      loadOptsWithDefaults
     );
 
+    invalidComponents.forEach(({ err }) => {
+      if (throwOnFailure) throw err;
+    });
+
     const components = [...loadedComponents, ...loadOrCached.fromCache];
 
     // this.logger.clearStatusLine();
@@ -147,11 +150,7 @@ export class WorkspaceComponentLoader {
     return { components, invalidComponents };
   }
 
-  private async getAndLoadSlotOrdered(
-    ids: ComponentID[],
-    loadOpts: ComponentLoadOptions,
-    throwOnFailure = true
-  ): Promise<GetManyRes> {
+  private async getAndLoadSlotOrdered(ids: ComponentID[], loadOpts: ComponentLoadOptions): Promise<GetManyRes> {
     if (!ids?.length) return { components: [], invalidComponents: [] };
 
     const workspaceScopeIdsMap: WorkspaceScopeIdsMap = await this.groupAndUpdateIds(ids);
@@ -165,12 +164,7 @@ export class WorkspaceComponentLoader {
       await mapSeries(groupsToHandle, async (group) => {
         const { scopeIds, workspaceIds, aspects, core, seeders } = group;
         if (!workspaceIds.length && !scopeIds.length) return undefined;
-        const res = await this.getAndLoadSlot(
-          workspaceIds,
-          scopeIds,
-          { ...loadOpts, core, seeders, aspects },
-          throwOnFailure
-        );
+        const res = await this.getAndLoadSlot(workspaceIds, scopeIds, { ...loadOpts, core, seeders, aspects });
         // We don't want to return components that were not asked originally (we do want to load them)
         if (!group.seeders) return undefined;
         return res;
@@ -270,14 +264,12 @@ export class WorkspaceComponentLoader {
   private async getAndLoadSlot(
     workspaceIds: ComponentID[],
     scopeIds: ComponentID[],
-    loadOpts: GetAndLoadSlotOpts,
-    throwOnFailure = true
+    loadOpts: GetAndLoadSlotOpts
   ): Promise<GetManyRes> {
     const { workspaceComponents, scopeComponents, invalidComponents } = await this.getComponentsWithoutLoadExtensions(
       workspaceIds,
       scopeIds,
-      loadOpts,
-      throwOnFailure
+      loadOpts
     );
 
     const components = workspaceComponents.concat(scopeComponents);
@@ -428,8 +420,7 @@ export class WorkspaceComponentLoader {
   private async getComponentsWithoutLoadExtensions(
     workspaceIds: ComponentID[],
     scopeIds: ComponentID[],
-    loadOpts: GetAndLoadSlotOpts,
-    throwOnFailure = true
+    loadOpts: GetAndLoadSlotOpts
   ) {
     const invalidComponents: InvalidComponent[] = [];
     const errors: { id: ComponentID; err: Error }[] = [];
@@ -462,8 +453,8 @@ export class WorkspaceComponentLoader {
     legacyInvalidComponents.forEach((invalidComponent) => {
       const entry = { id: idsIndex[invalidComponent.id.toString()], err: invalidComponent.error };
       if (ConsumerComponent.isComponentInvalidByErrorType(invalidComponent.error)) {
-        if (throwOnFailure) throw invalidComponent.error;
         invalidComponents.push(entry);
+        return;
       }
       if (
         this.isComponentNotExistsError(invalidComponent.error) ||
@@ -475,7 +466,7 @@ export class WorkspaceComponentLoader {
 
     const getWithCatch = (id, legacyComponent) => {
       return this.get(id, legacyComponent, undefined, undefined, loadOptsWithDefaults).catch((err) => {
-        if (ConsumerComponent.isComponentInvalidByErrorType(err) && !throwOnFailure) {
+        if (ConsumerComponent.isComponentInvalidByErrorType(err)) {
           invalidComponents.push({
             id,
             err,