@teambit/workspace 1.0.1226 → 1.0.1228

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "@teambit/workspace",
-  "version": "1.0.1226",
+  "version": "1.0.1228",
   "homepage": "https://bit.cloud/teambit/workspace/workspace",
   "main": "dist/index.js",
   "componentId": {
     "scope": "teambit.workspace",
     "name": "workspace",
-    "version": "1.0.1226"
+    "version": "1.0.1228"
   },
   "dependencies": {
     "lodash": "4.18.1",
@@ -29,9 +29,9 @@
     "pluralize": "8.0.0",
     "reset-css": "5.0.1",
     "@teambit/component-id": "1.2.5",
-    "@teambit/component": "1.0.1222",
-    "@teambit/dependency-resolver": "1.0.1222",
-    "@teambit/envs": "1.0.1222",
+    "@teambit/component": "1.0.1223",
+    "@teambit/dependency-resolver": "1.0.1223",
+    "@teambit/envs": "1.0.1223",
     "@teambit/harmony": "0.4.12",
     "@teambit/legacy.extension-data": "0.0.185",
     "@teambit/legacy.scope": "0.0.183",
@@ -50,18 +50,20 @@
     "@teambit/cli": "0.0.1414",
     "@teambit/config-store": "0.0.295",
     "@teambit/legacy.constants": "0.0.49",
-    "@teambit/component-tree": "1.0.1222",
+    "@teambit/component-tree": "1.0.1223",
     "@teambit/component.ui.component-status-resolver": "0.0.510",
     "@teambit/harmony.modules.load-trace": "0.0.17",
     "@teambit/harmony.modules.resolved-component": "0.0.530",
     "@teambit/legacy.utils": "0.0.56",
     "@teambit/scope.remotes": "0.0.183",
-    "@teambit/aspect-loader": "1.0.1222",
+    "@teambit/aspect-loader": "1.0.1223",
+    "@teambit/component-package-version": "0.0.466",
     "@teambit/config": "0.0.1589",
     "@teambit/harmony.modules.requireable-component": "0.0.530",
     "@teambit/harmony.modules.runtimes": "0.0.4",
     "@teambit/toolbox.modules.module-resolver": "0.0.29",
     "@teambit/workspace.modules.node-modules-linker": "0.0.416",
+    "@teambit/workspace.root-components": "1.0.1",
     "@teambit/graphql": "1.0.1206",
     "@teambit/global-config": "0.0.1418",
     "@teambit/legacy.consumer-config": "0.0.183",
@@ -86,7 +88,7 @@
     "@teambit/component.ui.component-filters.env-filter": "0.0.296",
     "@teambit/component.ui.component-filters.show-main-filter": "0.0.243",
     "@teambit/design.ui.surfaces.menu.link-item": "1.0.13",
-    "@teambit/sidebar": "1.0.1222",
+    "@teambit/sidebar": "1.0.1223",
     "@teambit/ui-foundation.ui.main-dropdown": "0.0.505",
     "@teambit/ui-foundation.ui.menu": "0.0.503",
     "@teambit/ui-foundation.ui.react-router.slot-router": "0.0.533",
@@ -111,12 +113,12 @@
     "@teambit/workspace.hooks.use-url-change-broadcaster": "0.0.7",
     "@teambit/workspace.ui.preserve-workspace-mode": "0.0.8",
     "@teambit/evangelist.elements.icon": "1.0.5",
-    "@teambit/scope": "1.0.1226",
-    "@teambit/graph": "1.0.1226",
-    "@teambit/isolator": "1.0.1226",
-    "@teambit/bundler": "1.0.1226",
-    "@teambit/ui": "1.0.1226",
-    "@teambit/command-bar": "1.0.1226"
+    "@teambit/scope": "1.0.1228",
+    "@teambit/graph": "1.0.1228",
+    "@teambit/isolator": "1.0.1228",
+    "@teambit/bundler": "1.0.1228",
+    "@teambit/ui": "1.0.1228",
+    "@teambit/command-bar": "1.0.1228"
   },
   "devDependencies": {
     "@types/lodash": "4.14.165",

package/workspace-component/workspace-component-loader.ts

@@ -574,20 +574,33 @@ export class WorkspaceComponentLoader {
     });
     if (!aspectIds.length) return;
 
+    const loadAsAspects = (ids: string[]) =>
+      this.workspace.loadAspects(ids, true, 'self loading aspects', { useScopeAspectsCapsule: true });
     try {
-      await this.workspace.loadAspects(aspectIds, true, 'self loading aspects', { useScopeAspectsCapsule: true });
+      await loadAsAspects(aspectIds);
     } catch (err: any) {
       this.logger.warn(`failed loading components as aspects for components ${aspectIds.join(', ')}`, err);
+      // one failing aspect fails the entire batch. load them one by one, so the aspects that are fine get loaded,
+      // and only the failing ones (and the components using them) are reported.
+      const failures: Array<{ aspectId: string; errMsg: string }> = [];
+      await mapSeries(aspectIds, async (aspectId) => {
+        let singleErr: any;
+        await loadAsAspects([aspectId]).catch((loadErr) => {
+          singleErr = loadErr;
+        });
+        // a load that doesn't throw is not enough. the loader hides errors it already reported in the batch.
+        if (!this.aspectLoader.hasAspectInstance(aspectId)) {
+          const failure = singleErr || err;
+          failures.push({ aspectId, errMsg: failure.message || String(failure) });
+        }
+      });
       // the error is not thrown (best-effort loading), but it's surfaced as a component issue
       // so it shows up in "bit status" instead of disappearing.
       if (!this.workspace.inInstallContext) {
-        const errMsg = err.message || String(err);
-        aspectIds.forEach((aspectId) => {
+        failures.forEach(({ aspectId, errMsg }) => {
           reportLoadFailure({ failedId: aspectId, phase: 'load-comps-as-aspects', error: errMsg });
-        });
-        components.forEach((component) => {
-          if (!aspectIds.includes(component.id.toString())) return;
-          this.addLoadFailureIssue(component, component.id.toString(), 'load-comps-as-aspects', errMsg);
+          const component = components.find((comp) => comp.id.toString() === aspectId);
+          if (component) this.addLoadFailureIssue(component, aspectId, 'load-comps-as-aspects', errMsg);
         });
       }
     }