@teambit/workspace 0.0.646 → 0.0.650

package/dist/workspace.js

@@ -606,9 +606,10 @@ class Workspace {
   }
 
   validateConfig() {
-    const defaultScope = this.config.defaultScope;
     if (this.consumer.isLegacy) return;
-    if (!defaultScope) throw new Error('defaultScope is missing');
+    if ((0, _lodash().isEmpty)(this.config)) throw new (_bitError().BitError)(`fatal: workspace config is empty. probably one of bit files is missing. consider running "bit init"`);
+    const defaultScope = this.config.defaultScope;
+    if (!defaultScope) throw new (_bitError().BitError)('defaultScope is missing');
     if (!(0, _legacyBitId().isValidScopeName)(defaultScope)) throw new (_legacyBitId().InvalidScopeName)(defaultScope);
   }
   /**
@@ -852,12 +853,14 @@ class Workspace {
   }
 
   async createAspectList(extensionDataList) {
-    const entiresP = extensionDataList.map(async entry => {
-      return new (_component().AspectEntry)(await this.resolveComponentId(entry.id), entry);
-    });
+    const entiresP = extensionDataList.map(entry => this.extensionDataEntryToAspectEntry(entry));
     const entries = await Promise.all(entiresP);
     return this.componentAspect.createAspectListFromEntries(entries);
   }
+
+  async extensionDataEntryToAspectEntry(dataEntry) {
+    return new (_component().AspectEntry)(await this.resolveComponentId(dataEntry.id), dataEntry);
+  }
   /**
    * get a component from workspace
    * @param id component ID
@@ -879,7 +882,7 @@ class Workspace {
       try {
         this.componentLoadedSelfAsAspects.set(component.id.toString(), true);
         this.logger.debug(`trying to load self as aspect with id ${component.id.toString()}`);
-        await this.loadAspects([component.id.toString()]); // In most cases if the load self as aspect failed we don't care about it.
+        await this.loadAspects([component.id.toString()], undefined, component.id); // In most cases if the load self as aspect failed we don't care about it.
         // we only need it in specific cases to work, but this workspace.get runs on different
         // cases where it might fail (like when importing aspect, after the import objects
         // when we write the package.json we run the applyTransformers which get to pkg which call
@@ -1067,14 +1070,18 @@ class Workspace {
     const componentDir = this.componentDir(id, {
       ignoreVersion: true
     });
-    const componentConfigFile = new (_componentConfigFile().ComponentConfigFile)(componentId, aspects, options.propagate);
-    await componentConfigFile.write(componentDir, {
+    const componentConfigFile = new (_componentConfigFile().ComponentConfigFile)(componentId, aspects, componentDir, options.propagate);
+    await componentConfigFile.write({
       override: options.override
     });
     return {
       configPath: _componentConfigFile().ComponentConfigFile.composePath(componentDir)
     };
   }
+  /**
+   * see component-aspect, createAspectListFromLegacy() method for a context why this is needed.
+   */
+
 
   async resolveScopeAspectListIds(aspectListFromScope) {
     const resolvedList = await aspectListFromScope.pmap(async entry => {
@@ -1111,11 +1118,13 @@ class Workspace {
    */
 
 
-  async idsByPattern(pattern) {
+  async idsByPattern(pattern, throwForNoMatch = true) {
     if (!pattern.includes('*') && !pattern.includes(',')) {
       // if it's not a pattern but just id, resolve it without multimatch to support specifying id without scope-name
       const id = await this.resolveComponentId(pattern);
-      return [id];
+      if (this.exists(id)) return [id];
+      if (throwForNoMatch) throw new (_bitError().BitError)(`unable to find "${pattern}" in the workspace`);
+      return [];
     }
 
     const ids = await this.listIds();
@@ -1123,7 +1132,13 @@ class Workspace {
 
     const idsToCheck = id => [id.toStringWithoutVersion(), id._legacy.toStringWithoutVersion()];
 
-    return ids.filter(id => (0, _multimatch().default)(idsToCheck(id), patterns).length);
+    const idsFiltered = ids.filter(id => (0, _multimatch().default)(idsToCheck(id), patterns).length);
+
+    if (throwForNoMatch && !idsFiltered.length) {
+      throw new (_bitError().BitError)(`unable to find any matching for "${pattern}" pattern`);
+    }
+
+    return idsFiltered;
   }
   /**
    * useful for workspace commands, such as `bit build`, `bit compile`.
@@ -1155,6 +1170,20 @@ class Workspace {
     return newAndModified;
   }
 
+  async getComponentsUsingEnv(env, throwIfNotFound = false) {
+    const allComps = await this.list();
+    const allEnvs = await this.envs.createEnvironment(allComps);
+    const foundEnv = allEnvs.runtimeEnvs.find(runtimeEnv => runtimeEnv.id === env);
+
+    if (!foundEnv && throwIfNotFound) {
+      const availableEnvs = allEnvs.runtimeEnvs.map(runtimeEnv => runtimeEnv.id);
+      throw new (_bitError().BitError)(`unable to find components that using "${env}" env.
+the following envs are used in this workspace: ${availableEnvs.join(', ')}`);
+    }
+
+    return (foundEnv === null || foundEnv === void 0 ? void 0 : foundEnv.components) || [];
+  }
+
   async getMany(ids, forCapsule = false) {
     return this.componentLoader.getMany(ids, forCapsule);
   }
@@ -1446,7 +1475,7 @@ class Workspace {
       const extsWithoutRemoved = extensions.filterRemovedExtensions();
       const selfInMergedExtensions = extsWithoutRemoved.findExtension(componentId._legacy.toStringWithoutScopeAndVersion(), true, true);
       const extsWithoutSelf = selfInMergedExtensions !== null && selfInMergedExtensions !== void 0 && selfInMergedExtensions.extensionId ? extsWithoutRemoved.remove(selfInMergedExtensions.extensionId) : extsWithoutRemoved;
-      await this.loadExtensions(extsWithoutSelf);
+      await this.loadExtensions(extsWithoutSelf, componentId);
       const {
         extensionDataListFiltered,
         envIsCurrentlySet
@@ -1556,6 +1585,46 @@ class Workspace {
       await func(components, watchOpts);
     });
   }
+
+  async addSpecificComponentConfig(id, aspectId, config = {}) {
+    const componentConfigFile = await this.componentConfigFile(id);
+
+    if (componentConfigFile) {
+      await componentConfigFile.addAspect(aspectId, config, this.resolveComponentId.bind(this));
+      await componentConfigFile.write({
+        override: true
+      });
+    } else {
+      this.bitMap.addComponentConfig(id, aspectId, config);
+    }
+  }
+
+  async removeSpecificComponentConfig(id, aspectId, markWithMinusIfNotExist) {
+    const componentConfigFile = await this.componentConfigFile(id);
+
+    if (componentConfigFile) {
+      await componentConfigFile.removeAspect(aspectId, markWithMinusIfNotExist, this.resolveComponentId.bind(this));
+      await componentConfigFile.write({
+        override: true
+      });
+    } else {
+      this.bitMap.removeComponentConfig(id, aspectId, markWithMinusIfNotExist);
+    }
+  }
+
+  async getSpecificComponentConfig(id, aspectId) {
+    var _this$bitMap$getBitma;
+
+    const componentConfigFile = await this.componentConfigFile(id);
+
+    if (componentConfigFile) {
+      var _componentConfigFile$2;
+
+      return (_componentConfigFile$2 = componentConfigFile.aspects.get(aspectId)) === null || _componentConfigFile$2 === void 0 ? void 0 : _componentConfigFile$2.config;
+    }
+
+    return (_this$bitMap$getBitma = this.bitMap.getBitmapEntry(id).config) === null || _this$bitMap$getBitma === void 0 ? void 0 : _this$bitMap$getBitma[aspectId];
+  }
   /**
    * This will mutate the entries with extensionId prop to have resolved legacy id
    * This should be worked on the extension data list not the new aspect list
@@ -1647,8 +1716,10 @@ class Workspace {
    */
 
 
-  async loadAspects(ids = [], throwOnError = false) {
-    this.logger.debug(`loading ${ids.length} aspects`);
+  async loadAspects(ids = [], throwOnError = false, neededFor) {
+    this.logger.info(`loadAspects, loading ${ids.length} aspects.
+ids: ${ids.join(', ')}
+needed-for: ${(neededFor === null || neededFor === void 0 ? void 0 : neededFor.toString()) || '<unknown>'}`);
     const notLoadedIds = ids.filter(id => !this.aspectLoader.isAspectLoaded(id));
     if (!notLoadedIds.length) return [];
     const coreAspectsStringIds = this.aspectLoader.getCoreAspectIds();
@@ -1808,7 +1879,7 @@ class Workspace {
    */
 
 
-  async loadExtensions(extensions, throwOnError = false) {
+  async loadExtensions(extensions, originatedFrom, throwOnError = false) {
     const extensionsIdsP = extensions.map(async extensionEntry => {
       // Core extension
       if (!extensionEntry.extensionId) {
@@ -1823,7 +1894,7 @@ class Workspace {
     const loadedExtensions = this.harmony.extensionsIds;
     const extensionsToLoad = (0, _lodash().difference)(extensionsIds, loadedExtensions);
     if (!extensionsToLoad.length) return;
-    await this.loadAspects(extensionsToLoad, throwOnError);
+    await this.loadAspects(extensionsToLoad, throwOnError, originatedFrom);
   }
   /**
    * Provides a cache folder, unique per key.
@@ -2068,10 +2139,7 @@ class Workspace {
 
   async _saveManyComponentConfigFiles(componentConfigFiles) {
     await Promise.all(Array.from(componentConfigFiles).map(async componentConfigFile => {
-      const componentDir = this.componentDir(componentConfigFile.componentId, {
-        ignoreVersion: true
-      });
-      await componentConfigFile.write(componentDir, {
+      await componentConfigFile.write({
         override: true
       });
     }));
@@ -2461,12 +2529,12 @@ your workspace.jsonc has this component-id set. you might want to remove/change
     const existsOnWorkspace = await this.hasId(envId);
     const envIdStrNoVersion = envId.toStringWithoutVersion();
     await this.unsetEnvFromComponents(componentIds);
-    componentIds.forEach(componentId => {
-      this.bitMap.addComponentConfig(componentId, existsOnWorkspace ? envIdStrNoVersion : envIdStr);
-      this.bitMap.addComponentConfig(componentId, _envs().EnvsAspect.id, {
+    await Promise.all(componentIds.map(async componentId => {
+      await this.addSpecificComponentConfig(componentId, existsOnWorkspace ? envIdStrNoVersion : envIdStr);
+      await this.addSpecificComponentConfig(componentId, _envs().EnvsAspect.id, {
         env: envIdStrNoVersion
       });
-    });
+    }));
     await this.bitMap.write();
   }
   /**
@@ -2477,11 +2545,8 @@ your workspace.jsonc has this component-id set. you might want to remove/change
   async unsetEnvFromComponents(ids) {
     const changed = [];
     const unchanged = [];
-    ids.forEach(id => {
-      var _bitMapEntry$config;
-
-      const bitMapEntry = this.bitMap.getBitmapEntry(id);
-      const envsAspect = (_bitMapEntry$config = bitMapEntry.config) === null || _bitMapEntry$config === void 0 ? void 0 : _bitMapEntry$config[_envs().EnvsAspect.id];
+    await Promise.all(ids.map(async id => {
+      const envsAspect = await this.getSpecificComponentConfig(id, _envs().EnvsAspect.id);
       const currentEnv = envsAspect && envsAspect !== _config().REMOVE_EXTENSION_SPECIAL_SIGN ? envsAspect.env : null;
 
       if (!currentEnv) {
@@ -2489,10 +2554,10 @@ your workspace.jsonc has this component-id set. you might want to remove/change
         return;
       }
 
-      this.bitMap.removeComponentConfig(id, currentEnv, false);
-      this.bitMap.removeComponentConfig(id, _envs().EnvsAspect.id, false);
+      await this.removeSpecificComponentConfig(id, currentEnv, false);
+      await this.removeSpecificComponentConfig(id, _envs().EnvsAspect.id, false);
       changed.push(id);
-    });
+    }));
     await this.bitMap.write();
     return {
       changed,