@teambit/snapping 1.0.1234 → 1.0.1236

package/dist/version-maker.d.ts

@@ -126,10 +126,16 @@ export declare class VersionMaker {
     private getVersionByEnteredId;
     private addBuildStatus;
     /**
-     * otherwise, tagging without build will have the old build data of the previous snap/tag.
-     * in case we currently build, it's ok to leave the data as is, because it'll be overridden anyway.
+     * when not building, replace the builder data, otherwise, it has the old build data of the previous snap/tag.
+     * (when building, the build overrides it anyway).
+     * the new data has only the tasks that are going to run once the component is built (e.g. by the CI), so they can
+     * be shown before the build starts.
      */
-    private emptyBuilderData;
+    private setUnbuiltBuilderData;
+    /**
+     * the harmony components that were already loaded. (the auto-tagged ones are available only in a workspace).
+     */
+    private getHarmonyComps;
     private updateDependenciesVersions;
     private getDependentsWithPinnedDeps;
     /**

package/dist/version-maker.js

@@ -131,6 +131,13 @@ function _objects() {
   };
   return data;
 }
+function _legacy4() {
+  const data = require("@teambit/legacy.extension-data");
+  _legacy4 = function () {
+    return data;
+  };
+  return data;
+}
 function _messagePerComponent() {
   const data = require("./message-per-component");
   _messagePerComponent = function () {
@@ -215,10 +222,10 @@ class VersionMaker {
     this.allWorkspaceComps = this.workspace ? await this.workspace.list() : undefined;
     const componentsToTag = this.getUniqCompsToTag();
     const idsToTag = _componentId().ComponentIdList.fromArray(componentsToTag.map(c => c.id));
-    const autoTagData = await this.getAutoTagData(idsToTag);
+    // a component that is tagged explicitly is not auto-tagged too (the scope flow may find it as both)
+    const autoTagData = (await this.getAutoTagData(idsToTag)).filter(autoTagItem => !idsToTag.has(autoTagItem.component.id));
     const autoTagComponents = autoTagData.map(autoTagItem => autoTagItem.component);
-    const autoTagComponentsFiltered = autoTagComponents.filter(c => !idsToTag.has(c.id));
-    const autoTagIds = _componentId().ComponentIdList.fromArray(autoTagComponentsFiltered.map(autoTag => autoTag.id));
+    const autoTagIds = _componentId().ComponentIdList.fromArray(autoTagComponents.map(autoTag => autoTag.id));
 
     // Validate component issues for auto-tag components
     if (this.allWorkspaceComps && autoTagIds.length) {
@@ -226,7 +233,7 @@ class VersionMaker {
       await this.builder.throwForComponentIssues(autoTagHarmonyComponents, this.params.ignoreIssues);
     }
     await this.triggerOnPreSnap(autoTagIds);
-    this.allComponentsToTag = [...componentsToTag, ...autoTagComponentsFiltered];
+    this.allComponentsToTag = [...componentsToTag, ...autoTagComponents];
     await this.parseVersionsFile(idsToTag, autoTagIds);
     const messagePerId = await this.getMessagePerId(idsToTag, autoTagIds);
     await this.checkForNewerVersions();
@@ -270,7 +277,7 @@ class VersionMaker {
       await this._addDependenciesGraphToComponents();
     }
     await this.snapping.throwForDepsFromAnotherLane(this.allComponentsToTag);
-    if (!build) this.emptyBuilderData();
+    if (!build) this.setUnbuiltBuilderData();
     this.addBuildStatus(this.allComponentsToTag, _legacy().BuildStatus.Pending);
     const currentLane = this.consumer?.getCurrentLaneId();
     await (0, _pMapSeries().default)(this.allComponentsToTag, async component => {
@@ -576,7 +583,9 @@ class VersionMaker {
     if (Object.keys(dependentsMap).length === 0) return [];
     const allDependentsIds = _componentId().ComponentIdList.uniqFromArray(Object.values(dependentsMap).flat());
     const allDependents = await this.legacyScope.getManyConsumerComponents(allDependentsIds);
-    return allDependents.map(dependent => {
+    // a component that was removed from the lane is not snapped again, same as in a workspace, where it's not loaded
+    const notRemovedDependents = allDependents.filter(dependent => !dependent.isRemoved());
+    return notRemovedDependents.map(dependent => {
       const triggeredByIds = Object.keys(dependentsMap).filter(id => dependentsMap[id].has(dependent.id));
       const triggeredBy = _componentId().ComponentIdList.fromStringArray(triggeredByIds);
       return {
@@ -743,16 +752,31 @@ class VersionMaker {
   }
 
   /**
-   * otherwise, tagging without build will have the old build data of the previous snap/tag.
-   * in case we currently build, it's ok to leave the data as is, because it'll be overridden anyway.
+   * when not building, replace the builder data, otherwise, it has the old build data of the previous snap/tag.
+   * (when building, the build overrides it anyway).
+   * the new data has only the tasks that are going to run once the component is built (e.g. by the CI), so they can
+   * be shown before the build starts.
    */
-  emptyBuilderData() {
+  setUnbuiltBuilderData() {
+    const plannedTasksPerComp = this.builder.getPlannedTasks(this.getHarmonyComps(this.allComponentsToTag.filter(c => !c.isRemoved())), this.params.isSnap ? 'snap' : 'tag');
     this.allComponentsToTag.forEach(component => {
       component.extensions = component.extensions.clone();
+      const plannedTasks = plannedTasksPerComp.get(component.id.toStringWithoutVersion());
+      const data = plannedTasks ? {
+        plannedTasks
+      } : {};
       const existingBuilder = component.extensions.findCoreExtension(_legacy().Extensions.builder);
-      if (existingBuilder) existingBuilder.data = {};
+      if (existingBuilder) existingBuilder.data = data;else if (plannedTasks) component.extensions.push(new (_legacy4().ExtensionDataEntry)(undefined, undefined, _legacy().Extensions.builder, {}, data));
     });
   }
+
+  /**
+   * the harmony components that were already loaded. (the auto-tagged ones are available only in a workspace).
+   */
+  getHarmonyComps(consumerComponents) {
+    const loadedComps = [...this.components, ...(this.allWorkspaceComps || [])];
+    return (0, _lodash().compact)(consumerComponents.map(consumerComp => loadedComps.find(comp => comp.id.isEqualWithoutVersion(consumerComp.id))));
+  }
   updateDependenciesVersions() {
     // filter out removed components.
     // if a component has a deleted-component as a dependency, it was probably running "bit install <dep>" with a version