@teambit/react 0.0.689 → 0.0.692

package/apps/web/react-app-options.ts

@@ -51,4 +51,9 @@ export type ReactAppOptions = {
    * ranges of ports to use to run the app server.
    */
   portRange?: number[];
+
+  /**
+   * favicon for the app. You can pass an abs path (using require.resolve()) or a url.
+   */
+  favicon?: string;
 };

package/apps/web/react.app-type.ts

@@ -16,7 +16,8 @@ export class ReactAppType implements ApplicationType<ReactAppOptions> {
       options.bundler,
       options.devServer,
       options.webpackTransformers,
-      options.deploy
+      options.deploy,
+      options.favicon
     );
   }
 }

package/apps/web/react.application.ts

@@ -19,9 +19,9 @@ export class ReactApp implements Application {
     readonly bundler?: Bundler,
     readonly devServer?: DevServer,
     readonly transformers?: WebpackConfigTransformer[],
-    readonly deploy?: (context: ReactDeployContext) => Promise<void>
+    readonly deploy?: (context: ReactDeployContext) => Promise<void>,
+    readonly favicon?: string
   ) {}
-
   readonly applicationType = 'react-common-js';
   readonly dir = 'public';
   async run(context: AppContext): Promise<number> {
@@ -57,6 +57,7 @@ export class ReactApp implements Application {
         title: context.name,
         templateContent: html(context.name),
         minify: false,
+        favicon: this.favicon,
         // filename: ''.html`,
       },
     ];
@@ -117,6 +118,7 @@ export class ReactApp implements Application {
       rootPath: '',
       publicPath: `public/${this.name}`,
       title: this.name,
+      favicon: this.favicon,
     });
   }
 }