@teambit/pnpm 1.0.1294 → 1.0.1296

package/dist/lockfile-deps-graph-converter.spec.js

@@ -663,6 +663,441 @@ describe('convertLockfileToGraph with directory packages missing from componentI
     }) => id.includes('@file:'))).to.equal(undefined);
   });
 });
+describe('convertLockfileToGraph when the root importer or snapshot lacks the component', () => {
+  it('should fall back to the component importer when the root importer is missing the component entry', () => {
+    const lockfile = {
+      bit: {
+        depsRequiringBuild: []
+      },
+      importers: {
+        '.': {},
+        'node_modules/.bit_roots/env': {
+          // dependencies is undefined (or missing comp1)
+        },
+        'comps/comp1': {
+          dependencies: {
+            foo: {
+              version: '1.0.0',
+              specifier: '^1.0.0'
+            }
+          }
+        }
+      },
+      lockfileVersion: '9.0',
+      snapshots: {
+        'foo@1.0.0': {}
+      },
+      packages: {
+        'foo@1.0.0': {
+          resolution: {
+            integrity: 'sha512-aaa'
+          }
+        }
+      }
+    };
+    const graph = (0, _lockfileDepsGraphConverter().convertLockfileToGraph)(lockfile, {
+      pkgName: 'comp1',
+      componentRelativeDir: 'comps/comp1',
+      componentRootDir: 'node_modules/.bit_roots/env',
+      componentIdByPkgName: new Map([['comp1', _component().ComponentID.fromString('my-scope/comp1@1.0.0')]])
+    });
+    const rootEdge = graph.findRootEdge();
+    (0, _chai().expect)(rootEdge?.neighbours).to.eql([{
+      name: 'foo',
+      specifier: '^1.0.0',
+      id: 'foo@1.0.0',
+      lifecycle: 'runtime',
+      optional: false
+    }]);
+  });
+  it('should fall back to the component importer when the locked snapshot is missing from snapshots', () => {
+    const lockfile = {
+      bit: {
+        depsRequiringBuild: []
+      },
+      importers: {
+        '.': {},
+        'node_modules/.bit_roots/env': {
+          dependencies: {
+            comp1: {
+              version: 'file:comps/comp1',
+              specifier: '*'
+            }
+          }
+        },
+        'comps/comp1': {
+          dependencies: {
+            foo: {
+              version: '1.0.0',
+              specifier: '^1.0.0'
+            }
+          }
+        }
+      },
+      lockfileVersion: '9.0',
+      snapshots: {
+        'foo@1.0.0': {}
+      },
+      packages: {
+        'foo@1.0.0': {
+          resolution: {
+            integrity: 'sha512-aaa'
+          }
+        }
+      }
+    };
+    const graph = (0, _lockfileDepsGraphConverter().convertLockfileToGraph)(lockfile, {
+      pkgName: 'comp1',
+      componentRelativeDir: 'comps/comp1',
+      componentRootDir: 'node_modules/.bit_roots/env',
+      componentIdByPkgName: new Map([['comp1', _component().ComponentID.fromString('my-scope/comp1@1.0.0')]])
+    });
+    const rootEdge = graph.findRootEdge();
+    (0, _chai().expect)(rootEdge?.neighbours).to.eql([{
+      name: 'foo',
+      specifier: '^1.0.0',
+      id: 'foo@1.0.0',
+      lifecycle: 'runtime',
+      optional: false
+    }]);
+  });
+  it('should scrub the component itself and circular back-edges when falling back to the component importer', () => {
+    const lockfile = {
+      bit: {
+        depsRequiringBuild: []
+      },
+      importers: {
+        '.': {},
+        'node_modules/.bit_roots/env': {},
+        'comps/comp1': {
+          dependencies: {
+            comp2: {
+              version: 'file:comps/comp2',
+              specifier: '*'
+            }
+          }
+        },
+        'comps/comp2': {
+          dependencies: {
+            comp1: {
+              version: 'file:comps/comp1',
+              specifier: '*'
+            }
+          }
+        }
+      },
+      lockfileVersion: '9.0',
+      snapshots: {
+        'comp1@file:comps/comp1': {
+          dependencies: {
+            comp2: 'file:comps/comp2'
+          }
+        },
+        'comp2@file:comps/comp2': {
+          dependencies: {
+            comp1: 'file:comps/comp1'
+          }
+        }
+      },
+      packages: {
+        'comp1@file:comps/comp1': {
+          resolution: {
+            directory: 'comps/comp1',
+            type: 'directory'
+          }
+        },
+        'comp2@file:comps/comp2': {
+          resolution: {
+            directory: 'comps/comp2',
+            type: 'directory'
+          }
+        }
+      }
+    };
+    const graph = (0, _lockfileDepsGraphConverter().convertLockfileToGraph)(lockfile, {
+      pkgName: 'comp1',
+      componentRelativeDir: 'comps/comp1',
+      componentRootDir: 'node_modules/.bit_roots/env',
+      componentIdByPkgName: new Map([['comp1', _component().ComponentID.fromString('my-scope/comp1@1.0.0')], ['comp2', _component().ComponentID.fromString('my-scope/comp2@1.0.0')]])
+    });
+    const referencingComp1 = graph.edges.filter(edge => edge.neighbours.some(n => n.id === 'comp1@1.0.0'));
+    (0, _chai().expect)(referencingComp1).to.eql([]);
+    (0, _chai().expect)(Array.from(graph.packages.keys())).to.not.include('comp1@1.0.0');
+  });
+  it('should scrub circular back-edges even when the component snapshot itself is missing', () => {
+    const lockfile = {
+      bit: {
+        depsRequiringBuild: []
+      },
+      importers: {
+        '.': {},
+        'node_modules/.bit_roots/env': {
+          dependencies: {
+            comp1: {
+              version: 'file:comps/comp1',
+              specifier: '*'
+            }
+          }
+        },
+        'comps/comp1': {
+          dependencies: {
+            comp2: {
+              version: 'file:comps/comp2',
+              specifier: '*'
+            }
+          }
+        }
+      },
+      lockfileVersion: '9.0',
+      snapshots: {
+        'comp2@file:comps/comp2': {
+          dependencies: {
+            comp1: 'file:comps/comp1'
+          }
+        }
+      },
+      packages: {
+        'comp2@file:comps/comp2': {
+          resolution: {
+            directory: 'comps/comp2',
+            type: 'directory'
+          }
+        }
+      }
+    };
+    const graph = (0, _lockfileDepsGraphConverter().convertLockfileToGraph)(lockfile, {
+      pkgName: 'comp1',
+      componentRelativeDir: 'comps/comp1',
+      componentRootDir: 'node_modules/.bit_roots/env',
+      componentIdByPkgName: new Map([['comp1', _component().ComponentID.fromString('my-scope/comp1@1.0.0')], ['comp2', _component().ComponentID.fromString('my-scope/comp2@1.0.0')]])
+    });
+    const referencingComp1 = graph.edges.filter(edge => edge.neighbours.some(n => n.id === 'comp1@1.0.0'));
+    (0, _chai().expect)(referencingComp1).to.eql([]);
+    (0, _chai().expect)(Array.from(graph.packages.keys())).to.not.include('comp1@1.0.0');
+  });
+  it('should not include packages reachable only from the root importer when falling back to the component importer', () => {
+    const lockfile = {
+      bit: {
+        depsRequiringBuild: []
+      },
+      importers: {
+        'node_modules/.bit_roots/env': {
+          dependencies: {
+            'root-only-pkg': {
+              version: '2.0.0',
+              specifier: '^2.0.0'
+            }
+          }
+        },
+        'comps/comp1': {
+          dependencies: {
+            foo: {
+              version: '1.0.0',
+              specifier: '^1.0.0'
+            }
+          }
+        }
+      },
+      lockfileVersion: '9.0',
+      snapshots: {
+        'foo@1.0.0': {},
+        'root-only-pkg@2.0.0': {}
+      },
+      packages: {
+        'foo@1.0.0': {
+          resolution: {
+            integrity: 'sha512-aaa'
+          }
+        },
+        'root-only-pkg@2.0.0': {
+          resolution: {
+            integrity: 'sha512-bbb'
+          }
+        }
+      }
+    };
+    const graph = (0, _lockfileDepsGraphConverter().convertLockfileToGraph)(lockfile, {
+      pkgName: 'comp1',
+      componentRelativeDir: 'comps/comp1',
+      componentRootDir: 'node_modules/.bit_roots/env',
+      componentIdByPkgName: new Map([['comp1', _component().ComponentID.fromString('my-scope/comp1@1.0.0')]])
+    });
+    (0, _chai().expect)(Array.from(graph.packages.keys())).to.eql(['foo@1.0.0']);
+  });
+  it('should not mutate the caller lockfile when converting without a root importer', () => {
+    const lockfile = {
+      bit: {
+        depsRequiringBuild: []
+      },
+      importers: {
+        'comps/comp1': {
+          dependencies: {
+            comp2: {
+              version: 'file:comps/comp2',
+              specifier: '*'
+            }
+          }
+        },
+        'comps/comp2': {
+          dependencies: {
+            comp1: {
+              version: 'file:comps/comp1',
+              specifier: '*'
+            }
+          }
+        }
+      },
+      lockfileVersion: '9.0',
+      snapshots: {
+        'comp1@file:comps/comp1': {
+          dependencies: {
+            comp2: 'file:comps/comp2'
+          }
+        },
+        'comp2@file:comps/comp2': {
+          dependencies: {
+            comp1: 'file:comps/comp1'
+          }
+        }
+      },
+      packages: {
+        'comp1@file:comps/comp1': {
+          resolution: {
+            directory: 'comps/comp1',
+            type: 'directory'
+          }
+        },
+        'comp2@file:comps/comp2': {
+          resolution: {
+            directory: 'comps/comp2',
+            type: 'directory'
+          }
+        }
+      }
+    };
+    const componentIdByPkgName = new Map([['comp1', _component().ComponentID.fromString('my-scope/comp1@1.0.0')], ['comp2', _component().ComponentID.fromString('my-scope/comp2@1.0.0')]]);
+    (0, _lockfileDepsGraphConverter().convertLockfileToGraph)(lockfile, {
+      pkgName: 'comp1',
+      componentRelativeDir: 'comps/comp1',
+      componentIdByPkgName
+    });
+    const graph2 = (0, _lockfileDepsGraphConverter().convertLockfileToGraph)(lockfile, {
+      pkgName: 'comp2',
+      componentRelativeDir: 'comps/comp2',
+      componentIdByPkgName
+    });
+    (0, _chai().expect)(Array.from(graph2.packages.keys())).to.eql(['comp1@1.0.0']);
+  });
+});
+describe('filterLockfileByImporters', () => {
+  it('should narrow packages and snapshots to the transitive closure of the requested importers without mutating the source lockfile', () => {
+    const lockfile = {
+      lockfileVersion: '9.0',
+      importers: {
+        'comps/comp1': {
+          dependencies: {
+            foo: {
+              version: '1.0.0(bar@1.0.0)',
+              specifier: '^1.0.0'
+            }
+          }
+        },
+        'comps/comp2': {
+          dependencies: {
+            unreached: {
+              version: '1.0.0',
+              specifier: '^1.0.0'
+            }
+          }
+        }
+      },
+      packages: {
+        'foo@1.0.0': {
+          resolution: {
+            integrity: 'sha512-foo'
+          }
+        },
+        'bar@1.0.0': {
+          resolution: {
+            integrity: 'sha512-bar'
+          }
+        },
+        'baz@1.0.0': {
+          resolution: {
+            integrity: 'sha512-baz'
+          }
+        },
+        'unreached@1.0.0': {
+          resolution: {
+            integrity: 'sha512-unreached'
+          }
+        }
+      },
+      snapshots: {
+        'foo@1.0.0(bar@1.0.0)': {
+          dependencies: {
+            bar: '1.0.0'
+          },
+          optionalDependencies: {
+            baz: '1.0.0'
+          }
+        },
+        'bar@1.0.0': {},
+        'baz@1.0.0': {},
+        'unreached@1.0.0': {}
+      }
+    };
+    const filtered = (0, _lockfileDepsGraphConverter().filterLockfileByImporters)(lockfile, ['comps/comp1']);
+    (0, _chai().expect)(Object.keys(filtered.packages).sort()).to.eql(['bar@1.0.0', 'baz@1.0.0', 'foo@1.0.0']);
+    (0, _chai().expect)(Object.keys(filtered.snapshots).sort()).to.eql(['bar@1.0.0', 'baz@1.0.0', 'foo@1.0.0(bar@1.0.0)']);
+    (0, _chai().expect)(Object.keys(filtered.importers)).to.eql(['comps/comp1']);
+
+    // Mutating filtered snapshots/packages must not mutate the original lockfile
+    delete filtered.snapshots['foo@1.0.0(bar@1.0.0)'].dependencies.bar;
+    (0, _chai().expect)(lockfile.snapshots['foo@1.0.0(bar@1.0.0)'].dependencies.bar).to.equal('1.0.0');
+  });
+  it('should retain package metadata for a reached dependency even when its snapshot is absent', () => {
+    const lockfile = {
+      lockfileVersion: '9.0',
+      importers: {
+        'comps/comp1': {
+          dependencies: {
+            foo: {
+              version: '1.0.0',
+              specifier: '^1.0.0'
+            }
+          }
+        }
+      },
+      packages: {
+        'foo@1.0.0': {
+          resolution: {
+            integrity: 'sha512-foo'
+          }
+        }
+      },
+      snapshots: {}
+    };
+    const filtered = (0, _lockfileDepsGraphConverter().filterLockfileByImporters)(lockfile, ['comps/comp1']);
+    (0, _chai().expect)(filtered.packages).to.eql({
+      'foo@1.0.0': {
+        resolution: {
+          integrity: 'sha512-foo'
+        }
+      }
+    });
+    const graph = (0, _lockfileDepsGraphConverter().convertLockfileToGraph)(filtered, {
+      pkgName: 'comp1',
+      componentRelativeDir: 'comps/comp1',
+      componentIdByPkgName: new Map([['comp1', _component().ComponentID.fromString('my-scope/comp1@1.0.0')]])
+    });
+    (0, _chai().expect)(graph.packages.get('foo@1.0.0')).to.eql({
+      resolution: {
+        integrity: 'sha512-foo'
+      }
+    });
+  });
+});
 describe('convertLockfileToGraph benchmark', () => {
   function generateLargeLockfile(numPackages, numComponents) {
     const snapshots = {};