@teambit/objects 0.0.727 → 0.0.728

package/models/model-component.ts

@@ -85,9 +85,9 @@ export type ComponentProps = {
   name: string;
   versions?: Versions;
   orphanedVersions?: Versions;
-  lang: string;
-  deprecated: boolean;
-  bindingPrefix: string;
+  lang?: string;
+  deprecated?: boolean;
+  bindingPrefix?: string;
   state?: State; // get deleted after export
   scopesList?: ScopeListItem[];
   head?: Ref;
@@ -546,13 +546,11 @@ export default class Component extends BitObject {
   latestExisting(repository: Repository): string {
     if (isEmpty(this.versions)) return VERSION_ZERO;
     const versions = this.listVersions('ASC');
-    let version = null;
-    let versionStr = null;
+    let version: Version | undefined;
+    let versionStr: string | undefined;
     while (!version && versions && versions.length) {
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
       versionStr = versions.pop();
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-      version = this.loadVersionSync(versionStr, repository, false);
+      version = this.loadVersionSync(versionStr!, repository, false);
     }
     return versionStr || VERSION_ZERO;
   }
@@ -893,7 +891,19 @@ Error from "semver": ${err.message}`);
       return obj;
     }
 
-    const componentObject = {
+    const componentObject: {
+      name: string;
+      scope: string;
+      versions: Record<string, string>;
+      lang: string;
+      deprecated: boolean;
+      bindingPrefix: string;
+      remotes: ScopeListItem[];
+      schema: string | undefined;
+      detachedHeads: ReturnType<DetachedHeads['toObject']>;
+      local?: boolean;
+      state?: State;
+    } = {
       name: this.name,
       scope: this.scope,
       versions: versions(this.versions),
@@ -904,9 +914,7 @@ Error from "semver": ${err.message}`);
       schema: this.schema,
       detachedHeads: this.detachedHeads.toObject(),
     };
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
     if (this.local) componentObject.local = this.local;
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
     if (!isEmpty(this.state)) componentObject.state = this.state;
     // @ts-ignore
     if (!isEmpty(this.orphanedVersions)) componentObject.orphanedVersions = versions(this.orphanedVersions);
@@ -928,8 +936,7 @@ Error from "semver": ${err.message}`);
   loadVersionSync(version: string, repository: Repository, throws = true): Version {
     const versionRef = this.getRef(version);
     if (!versionRef) throw new VersionNotFound(version, this.id());
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-    return versionRef.loadSync(repository, throws);
+    return versionRef.loadSync(repository, throws) as Version;
   }
 
   async collectVersionsObjects(
@@ -1300,10 +1307,8 @@ bit import ${this.id()}@${resolvedVersion} --objects --all-history`
 
   markVersionAsLocal(version: string) {
     if (!this.state.versions) this.state = { versions: {} };
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-    if (!this.state.versions[version]) this.state.versions[version] = {};
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-    this.state.versions[version].local = true;
+    if (!this.state.versions![version]) this.state.versions![version] = {};
+    this.state.versions![version].local = true;
   }
 
   /**
@@ -1312,8 +1317,7 @@ bit import ${this.id()}@${resolvedVersion} --objects --all-history`
    */
   getLocalVersions(): string[] {
     if (isEmpty(this.state) || isEmpty(this.state.versions)) return [];
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-    return Object.keys(this.state.versions).filter((version) => this.state.versions[version].local);
+    return Object.keys(this.state.versions!).filter((version) => this.state.versions![version].local);
   }
 
   hasLocalTag(tag: string): boolean {
@@ -1523,7 +1527,6 @@ bit import ${this.id()}@${resolvedVersion} --objects --all-history`
   }
 
   static fromBitId(bitId: ComponentID): Component {
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
     return new Component({
       name: bitId.fullName,
       scope: bitId.scope,

package/models/scopeMeta.ts

@@ -4,7 +4,7 @@ import type Ref from '../objects/ref';
 
 type ScopeMetaProps = {
   name: string;
-  license: string;
+  license?: string | null;
 };
 
 // TODO: fix parse
@@ -39,13 +39,11 @@ export default class ScopeMeta extends BitObject {
   }
 
   static fromScopeName(name: string): Ref {
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
     return ScopeMeta.fromObject({ name }).hash();
   }
 
   static parse(propsStr: string | Buffer): ScopeMeta {
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-    return this.fromObject(JSON.parse(propsStr));
+    return this.fromObject(JSON.parse(propsStr.toString()));
   }
 
   static fromObject(props: ScopeMetaProps): ScopeMeta {

package/models/version.ts

@@ -4,7 +4,7 @@ import { ComponentID, ComponentIdList } from '@teambit/component-id';
 import { LaneId } from '@teambit/lane-id';
 import { v4 } from 'uuid';
 import type { BuildStatus } from '@teambit/legacy.constants';
-import { DEFAULT_BUNDLE_FILENAME, Extensions } from '@teambit/legacy.constants';
+import { Extensions } from '@teambit/legacy.constants';
 import type { ConsumerComponent } from '@teambit/legacy.consumer-component';
 import {
   isSchemaSupport,
@@ -903,16 +903,6 @@ export default class Version extends BitObject {
       : undefined;
   }
 
-  setDist(dist: Source | undefined) {
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-    this.dist = dist
-      ? {
-          file: dist.hash(),
-          name: DEFAULT_BUNDLE_FILENAME,
-        }
-      : null;
-  }
-
   hasParent(ref: Ref) {
     return this.parents.find((p) => p.toString() === ref.toString());
   }

package/objects/object.ts

@@ -46,7 +46,7 @@ export default class BitObject {
   }
 
   async collectRefs(repo: Repository): Promise<Ref[]> {
-    const refsCollection = [];
+    const refsCollection: Ref[] = [];
     const objectType = this.getType();
     const objectId = objectType === 'Component' ? `Component ${this.id()}` : objectType;
 
@@ -63,7 +63,6 @@ path: ${err.path}`);
         throw err;
       }
 
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
       refsCollection.push(...refs);
       await Promise.all(objs.map((obj) => addRefs(obj)));
     }

package/objects/raw-object.ts

@@ -1,7 +1,6 @@
 import { NULL_BYTE, SPACE_DELIMITER } from '@teambit/legacy.constants';
 import { getStringifyArgs, inflate } from '@teambit/legacy.utils';
 import { typesObj as types } from '@teambit/legacy.scope';
-import type BitObject from './object';
 import { clone } from 'lodash';
 
 export default class BitRawObject {
@@ -12,11 +11,11 @@ export default class BitRawObject {
   _ref: string;
 
   constructor(
-    buffer: Buffer,
-    ref: string | null | undefined,
-    type: string | null | undefined,
-    content: Buffer | null | undefined,
-    parsedContent: any | null | undefined
+    buffer?: Buffer,
+    ref?: string | null,
+    type?: string | null,
+    content?: Buffer | null,
+    parsedContent?: any | null
   ) {
     let headers;
     let contentFromBuffer;
@@ -28,10 +27,8 @@ export default class BitRawObject {
     this.content = content || contentFromBuffer;
     this.headers = headers ? headers.split(SPACE_DELIMITER) : undefined;
     const typeFromHeader = this.headers ? this.headers[0] : undefined;
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-    this.type = type || typeFromHeader;
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-    this._ref = ref;
+    this.type = (type || typeFromHeader)!;
+    this._ref = ref!;
     this.parsedContent = parsedContent || this.getParsedContent();
   }
 
@@ -109,8 +106,7 @@ export default class BitRawObject {
     return [];
   }
 
-  static async fromDeflatedBuffer(fileContents: Buffer, ref: string | null | undefined): Promise<BitObject> {
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
+  static async fromDeflatedBuffer(fileContents: Buffer, ref: string | null | undefined): Promise<BitRawObject> {
     return inflate(fileContents).then((buffer) => new BitRawObject(buffer, ref));
   }
 
@@ -126,7 +122,6 @@ export default class BitRawObject {
   clone() {
     const parsedContent = this.parsedContent ? clone(this.parsedContent) : undefined;
     // TODO: Should also clone the buffers (content)
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
     return new BitRawObject(undefined, this._ref, this.type, this.content, parsedContent);
   }
 }

package/objects/repository.ts

@@ -180,8 +180,7 @@ export default class Repository {
     return path.join(this.scopePath, TRASH_DIR);
   }
 
-  getLicense(): Promise<string> {
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
+  getLicense(): Promise<string | null | undefined> {
     return this.scopeJson.getPopulatedLicense();
   }
 
@@ -564,7 +563,7 @@ export default class Repository {
       if (throws) {
         throw new HashNotFound(ref.toString());
       }
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
+      // @ts-expect-error @todo: it should return BitObject | null (same as `load()`)
       return null;
     }
   }

package/objects/scope-index.spec.ts

@@ -11,7 +11,6 @@ describe('ComponentsIndex', () => {
       scopeIndex = new ScopeIndex('scope-path');
     });
     it('should add to the index array', () => {
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
       const modelComponent = new ModelComponent({ scope: 'my-scope', name: 'is-string' });
       scopeIndex.addOne(modelComponent);
       const allItems = scopeIndex.getAll();
@@ -19,7 +18,6 @@ describe('ComponentsIndex', () => {
       expect(allItems[0].id).to.deep.equal({ scope: 'my-scope', name: 'is-string' });
     });
     it('should not add the same component multiple times', () => {
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
       const modelComponent = new ModelComponent({ scope: 'my-scope', name: 'is-string' });
       scopeIndex.addOne(modelComponent);
       scopeIndex.addOne(modelComponent);
@@ -27,8 +25,7 @@ describe('ComponentsIndex', () => {
       expect(scopeIndex.getAll()).to.have.lengthOf(1);
     });
     it('should not add BitObjects that are not Symlink nor ModelComponent', () => {
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-      const bitObject = new BitObject({ scope: 'my-scope', name: 'is-string' });
+      const bitObject = new BitObject();
       const result = scopeIndex.addOne(bitObject);
       expect(scopeIndex.getAll()).to.have.lengthOf(0);
       expect(result).to.be.false;
@@ -40,7 +37,6 @@ describe('ComponentsIndex', () => {
       scopeIndex = new ScopeIndex('scope-path');
     });
     it('should remove from the index array', () => {
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
       const modelComponent = new ModelComponent({ scope: 'my-scope', name: 'is-string' });
       scopeIndex.addOne(modelComponent);
       expect(scopeIndex.getAll()).to.have.lengthOf(1);
@@ -48,9 +44,7 @@ describe('ComponentsIndex', () => {
       expect(scopeIndex.getAll()).to.have.lengthOf(0);
     });
     it('should remove the correct one when there are multiple', () => {
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
       const isStringComponent = new ModelComponent({ scope: 'my-scope', name: 'is-string' });
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
       const isTypeComponent = new ModelComponent({ scope: 'my-scope', name: 'is-type' });
       scopeIndex.addOne(isStringComponent);
       scopeIndex.addOne(isTypeComponent);
@@ -68,9 +62,7 @@ describe('ComponentsIndex', () => {
     let isTypeComponent;
     beforeEach(() => {
       scopeIndex = new ScopeIndex('scope-path');
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
       isStringComponent = new ModelComponent({ scope: 'my-scope', name: 'is-string' });
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
       isTypeComponent = new ModelComponent({ scope: 'my-scope', name: 'is-type' });
       scopeIndex.addMany([isStringComponent, isTypeComponent]);
       expect(scopeIndex.getAll()).to.have.lengthOf(2);

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "@teambit/objects",
-  "version": "0.0.727",
+  "version": "0.0.728",
   "homepage": "https://bit.cloud/teambit/scope/objects",
   "main": "dist/index.js",
   "componentId": {
     "scope": "teambit.scope",
     "name": "objects",
-    "version": "0.0.727"
+    "version": "0.0.728"
   },
   "dependencies": {
     "@pnpm/lockfile.types": "1100.0.19",
@@ -22,16 +22,13 @@
     "@teambit/harmony.modules.runtimes": "0.0.4",
     "@teambit/component-id": "1.2.5",
     "@teambit/legacy.utils": "0.0.56",
-    "@teambit/harmony.modules.get-basic-log": "0.0.193",
     "@teambit/bit-error": "0.0.404",
     "@teambit/component-version": "1.0.4",
     "@teambit/component.snap-distance": "0.0.191",
-    "@teambit/config-store": "0.0.304",
     "@teambit/lane-id": "0.0.312",
     "@teambit/legacy.cli.error": "0.0.71",
     "@teambit/legacy.constants": "0.0.50",
     "@teambit/legacy.logger": "0.0.70",
-    "@teambit/legacy.scope": "0.0.192",
     "@teambit/toolbox.crypto.sha1": "0.0.24",
     "@teambit/component.sources": "0.0.243",
     "@teambit/harmony.modules.concurrency": "0.0.51",
@@ -47,7 +44,10 @@
     "@teambit/bit.get-bit-version": "0.0.31",
     "@teambit/semantics.doc-parser": "0.0.199",
     "@teambit/harmony.modules.in-memory-cache": "0.0.55",
-    "@teambit/toolbox.fs.remove-empty-dir": "0.0.22"
+    "@teambit/toolbox.fs.remove-empty-dir": "0.0.22",
+    "@teambit/harmony.modules.get-basic-log": "0.0.194",
+    "@teambit/config-store": "0.0.305",
+    "@teambit/legacy.scope": "0.0.193"
   },
   "devDependencies": {
     "@types/semver": "7.5.8",