@teambit/install 1.0.380 → 1.0.381

package/dist/install.main.runtime.d.ts

@@ -5,7 +5,7 @@ import { GenerateResult, GeneratorMain } from '@teambit/generator';
 import { ApplicationMain } from '@teambit/application';
 import { VariantsMain } from '@teambit/variants';
 import { Component, ComponentMap } from '@teambit/component';
-import { SlotRegistry } from '@teambit/harmony';
+import { Harmony, SlotRegistry } from '@teambit/harmony';
 import { CodemodResult, NodeModulesLinksResult } from '@teambit/workspace.modules.node-modules-linker';
 import { EnvsMain } from '@teambit/envs';
 import { IpcEventsMain } from '@teambit/ipc-events';
@@ -13,6 +13,7 @@ import { WorkspaceDependencyLifecycleType, DependencyResolverMain, LinkingOption
 import { WorkspaceConfigFilesMain } from '@teambit/workspace-config-files';
 import { Logger, LoggerMain } from '@teambit/logger';
 import { IssuesMain } from '@teambit/issues';
+import { AspectLoaderMain } from '@teambit/aspect-loader';
 export type WorkspaceLinkOptions = LinkingOptions & {
     rootPolicy?: WorkspacePolicy;
     linkToBitRoots?: boolean;
@@ -57,14 +58,16 @@ export declare class InstallMain {
     private compiler;
     private envs;
     private wsConfigFiles;
+    private aspectLoader;
     private app;
     private generator;
     private preLinkSlot;
     private preInstallSlot;
     private postInstallSlot;
     private ipcEvents;
+    private harmony;
     private visitedAspects;
-    constructor(dependencyResolver: DependencyResolverMain, logger: Logger, workspace: Workspace, variants: VariantsMain, compiler: CompilerMain, envs: EnvsMain, wsConfigFiles: WorkspaceConfigFilesMain, app: ApplicationMain, generator: GeneratorMain, preLinkSlot: PreLinkSlot, preInstallSlot: PreInstallSlot, postInstallSlot: PostInstallSlot, ipcEvents: IpcEventsMain);
+    constructor(dependencyResolver: DependencyResolverMain, logger: Logger, workspace: Workspace, variants: VariantsMain, compiler: CompilerMain, envs: EnvsMain, wsConfigFiles: WorkspaceConfigFilesMain, aspectLoader: AspectLoaderMain, app: ApplicationMain, generator: GeneratorMain, preLinkSlot: PreLinkSlot, preInstallSlot: PreInstallSlot, postInstallSlot: PostInstallSlot, ipcEvents: IpcEventsMain, harmony: Harmony);
     /**
      * Install dependencies for all components in the workspace
      *
@@ -79,6 +82,34 @@ export declare class InstallMain {
     private _addPackages;
     private _installModules;
     private shouldClearCacheOnInstall;
+    /**
+     * This function is very important to fix some issues that might happen during the installation process.
+     * The case is the following:
+     * during/before the installation process we load some envs from their bit.env files
+     * this contains code like:
+     * protected tsconfigPath = require.resolve('./config/tsconfig.json');
+     * protected eslintConfigPath = require.resolve('./config/eslintrc.cjs');
+     * When we load that file, we calculated the resolved path, and it's stored in the env
+     * object instance.
+     * then later on during the install we move the env to another location (like bit roots)
+     * which points to a .pnpm folder with some peers, that changed during the install
+     * then when we take this env object and call write ws config for example
+     * or compile
+     * we use that resolved path to calculate the final tsconfig
+     * however that file is no longer exists which result in an error
+     * This function will check if an env folder doesn't exist anymore, and will re-load it
+     * from its new location.
+     * This usually happen when we have install running in the middle of the process followed
+     * by other bit ops.
+     * examples:
+     * bit new - which might run few installs then other ops.
+     * bit switch - which might run few installs then other ops, and potentially change the
+     * peer deps during the install.
+     * bit server (vscode plugin) - which keep the process always live, so any install ops
+     * that change the location, will cause the vscode plugin/bit server to crash later.
+     * @returns
+     */
+    private reloadMovedEnvs;
     private _getComponentsManifestsAndRootPolicy;
     /**
      * The function `tryWriteConfigFiles` attempts to write workspace config files, and if it fails, it logs an error
@@ -166,7 +197,7 @@ export declare class InstallMain {
     static slots: (((registerFn: () => string) => SlotRegistry<PreLinkSlot>) | ((registerFn: () => string) => SlotRegistry<PreInstallSlot>))[];
     static dependencies: import("@teambit/harmony").Aspect[];
     static runtime: import("@teambit/harmony").RuntimeDefinition;
-    static provider([dependencyResolver, workspace, loggerExt, variants, cli, compiler, issues, envs, app, ipcEvents, generator, wsConfigFiles,]: [
+    static provider([dependencyResolver, workspace, loggerExt, variants, cli, compiler, issues, envs, app, ipcEvents, generator, wsConfigFiles, aspectLoader,]: [
         DependencyResolverMain,
         Workspace,
         LoggerMain,
@@ -178,7 +209,8 @@ export declare class InstallMain {
         ApplicationMain,
         IpcEventsMain,
         GeneratorMain,
-        WorkspaceConfigFilesMain
-    ], _: any, [preLinkSlot, preInstallSlot, postInstallSlot]: [PreLinkSlot, PreInstallSlot, PostInstallSlot]): Promise<InstallMain>;
+        WorkspaceConfigFilesMain,
+        AspectLoaderMain
+    ], _: any, [preLinkSlot, preInstallSlot, postInstallSlot]: [PreLinkSlot, PreInstallSlot, PostInstallSlot], harmony: Harmony): Promise<InstallMain>;
 }
 export default InstallMain;

package/dist/install.main.runtime.js

@@ -4,6 +4,13 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = exports.InstallMain = void 0;
+function _pFilter() {
+  const data = _interopRequireDefault(require("p-filter"));
+  _pFilter = function () {
+    return data;
+  };
+  return data;
+}
 function _fsExtra() {
   const data = _interopRequireWildcard(require("fs-extra"));
   _fsExtra = function () {
@@ -235,16 +242,23 @@ function _update() {
   };
   return data;
 }
-function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
+function _aspectLoader() {
+  const data = require("@teambit/aspect-loader");
+  _aspectLoader = function () {
+    return data;
+  };
+  return data;
+}
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function (e) { return e ? t : r; })(e); }
 function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
+function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 function _defineProperty(e, r, t) { return (r = _toPropertyKey(r)) in e ? Object.defineProperty(e, r, { value: t, enumerable: !0, configurable: !0, writable: !0 }) : e[r] = t, e; }
 function _toPropertyKey(t) { var i = _toPrimitive(t, "string"); return "symbol" == typeof i ? i : i + ""; }
 function _toPrimitive(t, r) { if ("object" != typeof t || !t) return t; var e = t[Symbol.toPrimitive]; if (void 0 !== e) { var i = e.call(t, r || "default"); if ("object" != typeof i) return i; throw new TypeError("@@toPrimitive must return a primitive value."); } return ("string" === r ? String : Number)(t); }
 class InstallMain {
-  constructor(dependencyResolver, logger, workspace, variants, compiler, envs, wsConfigFiles, app, generator, preLinkSlot, preInstallSlot, postInstallSlot, ipcEvents) {
+  constructor(dependencyResolver, logger, workspace, variants, compiler, envs, wsConfigFiles, aspectLoader, app, generator, preLinkSlot, preInstallSlot, postInstallSlot, ipcEvents, harmony) {
     this.dependencyResolver = dependencyResolver;
     this.logger = logger;
     this.workspace = workspace;
@@ -252,12 +266,14 @@ class InstallMain {
     this.compiler = compiler;
     this.envs = envs;
     this.wsConfigFiles = wsConfigFiles;
+    this.aspectLoader = aspectLoader;
     this.app = app;
     this.generator = generator;
     this.preLinkSlot = preLinkSlot;
     this.preInstallSlot = preInstallSlot;
     this.postInstallSlot = postInstallSlot;
     this.ipcEvents = ipcEvents;
+    this.harmony = harmony;
     _defineProperty(this, "visitedAspects", new Set());
   }
   /**
@@ -352,8 +368,8 @@ class InstallMain {
     await this.install(packages, {
       addMissingDeps: installMissing,
       skipIfExisting: true,
-      writeConfigFiles: false,
-      skipPrune: true
+      writeConfigFiles: false
+      // skipPrune: true,
     });
   }
   async _addPackages(packages, options) {
@@ -460,6 +476,7 @@ class InstallMain {
       }, pmInstallOptions);
       let cacheCleared = false;
       await this.linkCodemods(compDirMap);
+      await this.reloadMovedEnvs();
       const shouldClearCacheOnInstall = this.shouldClearCacheOnInstall();
       if (options?.compile ?? true) {
         const compileStartTime = process.hrtime();
@@ -477,6 +494,7 @@ class InstallMain {
         await this.compiler.compileOnWorkspace([], {
           initiator: _compiler().CompilationInitiator.Install
         });
+
         // Right now we don't need to load extensions/execute load slot at this point
         // await this.compiler.compileOnWorkspace([], { initiator: CompilationInitiator.Install }, undefined, {
         //   executeLoadSlot: true,
@@ -522,6 +540,72 @@ class InstallMain {
     const nonLoadedEnvs = this.envs.getFailedToLoadEnvs();
     return nonLoadedEnvs.length > 0;
   }
+
+  /**
+   * This function is very important to fix some issues that might happen during the installation process.
+   * The case is the following:
+   * during/before the installation process we load some envs from their bit.env files
+   * this contains code like:
+   * protected tsconfigPath = require.resolve('./config/tsconfig.json');
+   * protected eslintConfigPath = require.resolve('./config/eslintrc.cjs');
+   * When we load that file, we calculated the resolved path, and it's stored in the env
+   * object instance.
+   * then later on during the install we move the env to another location (like bit roots)
+   * which points to a .pnpm folder with some peers, that changed during the install
+   * then when we take this env object and call write ws config for example
+   * or compile
+   * we use that resolved path to calculate the final tsconfig
+   * however that file is no longer exists which result in an error
+   * This function will check if an env folder doesn't exist anymore, and will re-load it
+   * from its new location.
+   * This usually happen when we have install running in the middle of the process followed
+   * by other bit ops.
+   * examples:
+   * bit new - which might run few installs then other ops.
+   * bit switch - which might run few installs then other ops, and potentially change the
+   * peer deps during the install.
+   * bit server (vscode plugin) - which keep the process always live, so any install ops
+   * that change the location, will cause the vscode plugin/bit server to crash later.
+   * @returns
+   */
+  async reloadMovedEnvs() {
+    const allEnvs = this.envs.getAllRegisteredEnvs();
+    const movedEnvs = await (0, _pFilter().default)(allEnvs, async env => {
+      if (!env.__path) return false;
+      const regularPathExists = await (0, _fsExtra().pathExists)(env.__path);
+      const resolvedPathExists = await (0, _fsExtra().pathExists)(env.__resolvedPath);
+      return !regularPathExists || !resolvedPathExists;
+    });
+    const idsToLoad = movedEnvs.map(env => env.id);
+    // const envPlugin = this.envs.getEnvPlugin();
+
+    if (idsToLoad.length && this.workspace) {
+      const componentIdsToLoad = idsToLoad.map(id => _component().ComponentID.fromString(id));
+      const aspects = await this.workspace.resolveAspects(undefined, componentIdsToLoad, {
+        requestedOnly: true,
+        excludeCore: true,
+        throwOnError: false
+        // Theoretically we should use skipDeps here, but according to implementation at the moment
+        // it will lead to plugins not load, and we need them to be loaded.
+        // This is a bug in the flow and should be fixed.
+        // skipDeps: true,
+      });
+      const loadedPlugins = (0, _lodash().compact)(await Promise.all(aspects.map(aspectDef => {
+        const localPath = aspectDef.aspectPath;
+        const component = aspectDef.component;
+        if (!component) return undefined;
+        const plugins = this.aspectLoader.getPlugins(component, localPath);
+        if (plugins.has()) {
+          return plugins.load(_cli().MainRuntime.name);
+        }
+      })));
+      await Promise.all(loadedPlugins.map(plugin => {
+        const runtime = plugin.getRuntime(_cli().MainRuntime);
+        return runtime?.provider(undefined, undefined, undefined, this.harmony);
+      }));
+    }
+    return movedEnvs;
+  }
   async _getComponentsManifestsAndRootPolicy(installer, options) {
     const mergedRootPolicy = await this.addConfiguredAspectsToWorkspacePolicy();
     await this.addConfiguredGeneratorEnvsToWorkspacePolicy(mergedRootPolicy);
@@ -1032,7 +1116,7 @@ class InstallMain {
       await this.link();
     }
   }
-  static async provider([dependencyResolver, workspace, loggerExt, variants, cli, compiler, issues, envs, app, ipcEvents, generator, wsConfigFiles], _, [preLinkSlot, preInstallSlot, postInstallSlot]) {
+  static async provider([dependencyResolver, workspace, loggerExt, variants, cli, compiler, issues, envs, app, ipcEvents, generator, wsConfigFiles, aspectLoader], _, [preLinkSlot, preInstallSlot, postInstallSlot], harmony) {
     const logger = loggerExt.createLogger(_install().InstallAspect.id);
     ipcEvents.registerGotEventSlot(async eventName => {
       if (eventName !== 'onPostInstall') return;
@@ -1041,7 +1125,7 @@ class InstallMain {
       workspace.clearAllComponentsCache();
       await (0, _pMapSeries().default)(postInstallSlot.values(), fn => fn());
     });
-    const installExt = new InstallMain(dependencyResolver, logger, workspace, variants, compiler, envs, wsConfigFiles, app, generator, preLinkSlot, preInstallSlot, postInstallSlot, ipcEvents);
+    const installExt = new InstallMain(dependencyResolver, logger, workspace, variants, compiler, envs, wsConfigFiles, aspectLoader, app, generator, preLinkSlot, preInstallSlot, postInstallSlot, ipcEvents, harmony);
     if (issues) {
       issues.registerAddComponentsIssues(installExt.addDuplicateComponentAndPackageIssue.bind(installExt));
     }
@@ -1058,7 +1142,7 @@ class InstallMain {
 }
 exports.InstallMain = InstallMain;
 _defineProperty(InstallMain, "slots", [_harmony().Slot.withType(), _harmony().Slot.withType(), _harmony().Slot.withType()]);
-_defineProperty(InstallMain, "dependencies", [_dependencyResolver().DependencyResolverAspect, _workspace2().WorkspaceAspect, _logger().LoggerAspect, _variants().VariantsAspect, _cli().CLIAspect, _compiler().CompilerAspect, _issues().IssuesAspect, _envs().EnvsAspect, _application().ApplicationAspect, _ipcEvents().IpcEventsAspect, _generator().GeneratorAspect, _workspaceConfigFiles().WorkspaceConfigFilesAspect]);
+_defineProperty(InstallMain, "dependencies", [_dependencyResolver().DependencyResolverAspect, _workspace2().WorkspaceAspect, _logger().LoggerAspect, _variants().VariantsAspect, _cli().CLIAspect, _compiler().CompilerAspect, _issues().IssuesAspect, _envs().EnvsAspect, _application().ApplicationAspect, _ipcEvents().IpcEventsAspect, _generator().GeneratorAspect, _workspaceConfigFiles().WorkspaceConfigFilesAspect, _aspectLoader().AspectLoaderAspect]);
 _defineProperty(InstallMain, "runtime", _cli().MainRuntime);
 function hasComponentsFromWorkspaceInMissingDeps({
   componentDirectoryMap,