@teambit/install 1.0.106 → 1.0.108

package/dist/install.cmd.d.ts

@@ -3,7 +3,7 @@ import { WorkspaceDependencyLifecycleType } from '@teambit/dependency-resolver';
 import { Logger } from '@teambit/logger';
 import { Workspace } from '@teambit/workspace';
 import { InstallMain } from './install.main.runtime';
-declare type InstallCmdOptions = {
+type InstallCmdOptions = {
     type: WorkspaceDependencyLifecycleType;
     skipDedupe: boolean;
     skipImport: boolean;

package/dist/install.main.runtime.d.ts

@@ -14,16 +14,16 @@ import { WorkspaceConfigFilesMain } from '@teambit/workspace-config-files';
 import { Logger, LoggerMain } from '@teambit/logger';
 import { IssuesMain } from '@teambit/issues';
 import { CodemodResult } from '@teambit/legacy/dist/consumer/component-ops/codemod-components';
-export declare type WorkspaceLinkOptions = LinkingOptions & {
+export type WorkspaceLinkOptions = LinkingOptions & {
     rootPolicy?: WorkspacePolicy;
     linkToBitRoots?: boolean;
     includePeers?: boolean;
 };
-export declare type WorkspaceLinkResults = {
+export type WorkspaceLinkResults = {
     legacyLinkResults?: NodeModulesLinksResult[];
     legacyLinkCodemodResults?: CodemodResult[];
 } & LinkResults;
-export declare type WorkspaceInstallOptions = {
+export type WorkspaceInstallOptions = {
     addMissingDeps?: boolean;
     addMissingPeers?: boolean;
     lifecycleType?: WorkspaceDependencyLifecycleType;
@@ -42,13 +42,13 @@ export declare type WorkspaceInstallOptions = {
     lockfileOnly?: boolean;
     writeConfigFiles?: boolean;
 };
-export declare type ModulesInstallOptions = Omit<WorkspaceInstallOptions, 'updateExisting' | 'lifecycleType' | 'import'>;
-declare type PreLink = (linkOpts?: WorkspaceLinkOptions) => Promise<void>;
-declare type PreInstall = (installOpts?: WorkspaceInstallOptions) => Promise<void>;
-declare type PostInstall = () => Promise<void>;
-declare type PreLinkSlot = SlotRegistry<PreLink>;
-declare type PreInstallSlot = SlotRegistry<PreInstall>;
-declare type PostInstallSlot = SlotRegistry<PostInstall>;
+export type ModulesInstallOptions = Omit<WorkspaceInstallOptions, 'updateExisting' | 'lifecycleType' | 'import'>;
+type PreLink = (linkOpts?: WorkspaceLinkOptions) => Promise<void>;
+type PreInstall = (installOpts?: WorkspaceInstallOptions) => Promise<void>;
+type PostInstall = () => Promise<void>;
+type PreLinkSlot = SlotRegistry<PreLink>;
+type PreInstallSlot = SlotRegistry<PreInstall>;
+type PostInstallSlot = SlotRegistry<PostInstall>;
 export declare class InstallMain {
     private dependencyResolver;
     private logger;

package/dist/install.main.runtime.js

@@ -272,14 +272,14 @@ class InstallMain {
     if (packages && packages.length) {
       await this._addPackages(packages, options);
     }
-    if (options !== null && options !== void 0 && options.addMissingPeers) {
+    if (options?.addMissingPeers) {
       const compDirMap = await this.getComponentsDirectory([]);
       const mergedRootPolicy = this.dependencyResolver.getWorkspacePolicy();
       const depsFilterFn = await this.generateFilterFnForDepsFromLocalRemote();
       const pmInstallOptions = {
-        dedupe: options === null || options === void 0 ? void 0 : options.dedupe,
-        copyPeerToRuntimeOnRoot: (options === null || options === void 0 ? void 0 : options.copyPeerToRuntimeOnRoot) ?? true,
-        copyPeerToRuntimeOnComponents: (options === null || options === void 0 ? void 0 : options.copyPeerToRuntimeOnComponents) ?? false,
+        dedupe: options?.dedupe,
+        copyPeerToRuntimeOnRoot: options?.copyPeerToRuntimeOnRoot ?? true,
+        copyPeerToRuntimeOnComponents: options?.copyPeerToRuntimeOnComponents ?? false,
         dependencyFilterFn: depsFilterFn,
         overrides: this.dependencyResolver.config.overrides,
         packageImportMethod: this.dependencyResolver.config.packageImportMethod
@@ -354,8 +354,8 @@ class InstallMain {
     });
   }
   async _addPackages(packages, options) {
-    if ((options === null || options === void 0 ? void 0 : options.lifecycleType) === 'dev') {
-      throw new (_exceptions().DependencyTypeNotSupportedInPolicy)(options === null || options === void 0 ? void 0 : options.lifecycleType);
+    if (options?.lifecycleType === 'dev') {
+      throw new (_exceptions().DependencyTypeNotSupportedInPolicy)(options?.lifecycleType);
     }
     this.logger.debug(`installing the following packages: ${packages.join()}`);
     const resolver = await this.dependencyResolver.getVersionResolver();
@@ -368,7 +368,7 @@ class InstallMain {
       if (resolvedPackage.version) {
         const versionWithPrefix = this.dependencyResolver.getVersionWithSavePrefix({
           version: resolvedPackage.version,
-          overridePrefix: options === null || options === void 0 ? void 0 : options.savePrefix,
+          overridePrefix: options?.savePrefix,
           wantedRange: resolvedPackage.wantedRange
         });
         newWorkspacePolicyEntries.push({
@@ -376,28 +376,28 @@ class InstallMain {
           value: {
             version: versionWithPrefix
           },
-          lifecycleType: (options === null || options === void 0 ? void 0 : options.lifecycleType) || 'runtime'
+          lifecycleType: options?.lifecycleType || 'runtime'
         });
       }
     });
     this.dependencyResolver.addToRootPolicy(newWorkspacePolicyEntries, {
-      updateExisting: (options === null || options === void 0 ? void 0 : options.updateExisting) ?? false,
-      skipIfExisting: (options === null || options === void 0 ? void 0 : options.skipIfExisting) ?? false
+      updateExisting: options?.updateExisting ?? false,
+      skipIfExisting: options?.skipIfExisting ?? false
     });
     await this.dependencyResolver.persistConfig(this.workspace.path);
   }
   async _installModules(options) {
     const pm = this.dependencyResolver.getPackageManager();
-    this.logger.console(`installing dependencies in workspace using ${pm === null || pm === void 0 ? void 0 : pm.name} (${_chalk().default.cyan(this.dependencyResolver.getPackageManagerName())})`);
+    this.logger.console(`installing dependencies in workspace using ${pm?.name} (${_chalk().default.cyan(this.dependencyResolver.getPackageManagerName())})`);
     this.logger.debug(`installing dependencies in workspace with options`, options);
     const depsFilterFn = await this.generateFilterFnForDepsFromLocalRemote();
     const hasRootComponents = this.dependencyResolver.hasRootComponents();
     // TODO: pass get install options
     const installer = this.dependencyResolver.getInstaller({});
     const calcManifestsOpts = {
-      copyPeerToRuntimeOnComponents: (options === null || options === void 0 ? void 0 : options.copyPeerToRuntimeOnComponents) ?? false,
-      copyPeerToRuntimeOnRoot: (options === null || options === void 0 ? void 0 : options.copyPeerToRuntimeOnRoot) ?? true,
-      dedupe: !hasRootComponents && (options === null || options === void 0 ? void 0 : options.dedupe),
+      copyPeerToRuntimeOnComponents: options?.copyPeerToRuntimeOnComponents ?? false,
+      copyPeerToRuntimeOnRoot: options?.copyPeerToRuntimeOnRoot ?? true,
+      dedupe: !hasRootComponents && options?.dedupe,
       dependencyFilterFn: depsFilterFn,
       nodeLinker: this.dependencyResolver.nodeLinker()
     };
@@ -415,18 +415,18 @@ class InstallMain {
       mergedRootPolicy,
       componentsAndManifests: current
     } = await this._getComponentsManifestsAndRootPolicy(installer, _objectSpread(_objectSpread({}, calcManifestsOpts), {}, {
-      addMissingDeps: options === null || options === void 0 ? void 0 : options.addMissingDeps,
+      addMissingDeps: options?.addMissingDeps,
       linkedRootDeps
     }));
     const pmInstallOptions = _objectSpread(_objectSpread({}, calcManifestsOpts), {}, {
-      includeOptionalDeps: options === null || options === void 0 ? void 0 : options.includeOptionalDeps,
+      includeOptionalDeps: options?.includeOptionalDeps,
       neverBuiltDependencies: this.dependencyResolver.config.neverBuiltDependencies,
       overrides: this.dependencyResolver.config.overrides,
       packageImportMethod: this.dependencyResolver.config.packageImportMethod,
       rootComponents: hasRootComponents,
-      updateAll: options === null || options === void 0 ? void 0 : options.updateAll,
-      optimizeReportForNonTerminal: options === null || options === void 0 ? void 0 : options.optimizeReportForNonTerminal,
-      lockfileOnly: options === null || options === void 0 ? void 0 : options.lockfileOnly
+      updateAll: options?.updateAll,
+      optimizeReportForNonTerminal: options?.optimizeReportForNonTerminal,
+      lockfileOnly: options?.lockfileOnly
     });
     const prevManifests = new Set();
     // TODO: this make duplicate
@@ -454,7 +454,7 @@ class InstallMain {
       }, pmInstallOptions);
       let cacheCleared = false;
       await this.linkCodemods(compDirMap);
-      if ((options === null || options === void 0 ? void 0 : options.compile) ?? true) {
+      if (options?.compile ?? true) {
         const compileStartTime = process.hrtime();
         const compileOutputMessage = `compiling components`;
         this.logger.setStatusLine(compileOutputMessage);
@@ -471,11 +471,11 @@ class InstallMain {
         });
         this.logger.consoleSuccess(compileOutputMessage, compileStartTime);
       }
-      if ((options === null || options === void 0 ? void 0 : options.writeConfigFiles) ?? true) {
+      if (options?.writeConfigFiles ?? true) {
         await this.tryWriteConfigFiles(!cacheCleared);
       }
       if (!dependenciesChanged) break;
-      if (!(options !== null && options !== void 0 && options.recurringInstall)) break;
+      if (!options?.recurringInstall) break;
       const oldNonLoadedEnvs = this.getOldNonLoadedEnvs();
       if (!oldNonLoadedEnvs.length) break;
       prevManifests.add(manifestsHash(current.manifests));
@@ -492,7 +492,7 @@ class InstallMain {
       current = await this._getComponentsManifests(installer, mergedRootPolicy, calcManifestsOpts);
       installCycle += 1;
     } while ((!prevManifests.has(manifestsHash(current.manifests)) || hasMissingLocalComponents) && installCycle < 5);
-    if (!(options !== null && options !== void 0 && options.lockfileOnly)) {
+    if (!options?.lockfileOnly) {
       // We clean node_modules only after the last install.
       // Otherwise, we might load an env from a location that we later remove.
       await installer.pruneModules(this.workspace.path);
@@ -505,7 +505,7 @@ class InstallMain {
     const mergedRootPolicy = await this.addConfiguredAspectsToWorkspacePolicy();
     await this.addConfiguredGeneratorEnvsToWorkspacePolicy(mergedRootPolicy);
     const componentsAndManifests = await this._getComponentsManifests(installer, mergedRootPolicy, options);
-    if (!(options !== null && options !== void 0 && options.addMissingDeps)) {
+    if (!options?.addMissingDeps) {
       return {
         componentsAndManifests,
         mergedRootPolicy
@@ -627,8 +627,7 @@ class InstallMain {
   async _getAllMissingPackages() {
     const comps = await this.workspace.list();
     return (0, _lodash().uniq)(comps.map(comp => {
-      var _comp$state$issues$ge;
-      const data = ((_comp$state$issues$ge = comp.state.issues.getIssue(_componentIssues().IssuesClasses.MissingPackagesDependenciesOnFs)) === null || _comp$state$issues$ge === void 0 ? void 0 : _comp$state$issues$ge.data) || [];
+      const data = comp.state.issues.getIssue(_componentIssues().IssuesClasses.MissingPackagesDependenciesOnFs)?.data || [];
       return data.map(d => d.missingPackages).flat();
     }).flat());
   }
@@ -845,10 +844,8 @@ class InstallMain {
   _variantPatternsToDepPolicesDict(variantPatterns) {
     const variantPoliciesByPatterns = {};
     for (const [variantPattern, extensions] of Object.entries(variantPatterns)) {
-      var _extensions$Dependenc;
-      if ((_extensions$Dependenc = extensions[_dependencyResolver().DependencyResolverAspect.id]) !== null && _extensions$Dependenc !== void 0 && _extensions$Dependenc.policy) {
-        var _extensions$Dependenc2;
-        variantPoliciesByPatterns[variantPattern] = (_extensions$Dependenc2 = extensions[_dependencyResolver().DependencyResolverAspect.id]) === null || _extensions$Dependenc2 === void 0 ? void 0 : _extensions$Dependenc2.policy;
+      if (extensions[_dependencyResolver().DependencyResolverAspect.id]?.policy) {
+        variantPoliciesByPatterns[variantPattern] = extensions[_dependencyResolver().DependencyResolverAspect.id]?.policy;
       }
     }
     return variantPoliciesByPatterns;
@@ -917,7 +914,7 @@ class InstallMain {
   }
   async linkCodemods(compDirMap, options) {
     const bitIds = compDirMap.toArray().map(([component]) => component.id);
-    return (0, _workspaceModules().linkToNodeModulesWithCodemod)(this.workspace, bitIds, (options === null || options === void 0 ? void 0 : options.rewire) ?? false);
+    return (0, _workspaceModules().linkToNodeModulesWithCodemod)(this.workspace, bitIds, options?.rewire ?? false);
   }
   async link(options = {}) {
     const {