@teambit/component-issues 0.0.142 → 0.0.144

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -76,11 +76,6 @@ export declare class IssuesList {
76
76
  }[];
77
77
  add(issue: ComponentIssue): void;
78
78
  delete(IssueClass: typeof ComponentIssue): void;
79
- /**
80
- * Use getIssueByName to prevent issues when getting different instances while using both bit from bvm and from the repo
81
- * @param IssueClass
82
- * @returns
83
- */
84
79
  getIssue<T extends ComponentIssue>(IssueClass: {
85
80
  new (): T;
86
81
  }): T | undefined;
@@ -79,13 +79,11 @@ class IssuesList {
79
79
  delete(IssueClass) {
80
80
  this._issues = this._issues.filter((issue) => issue.constructor.name !== IssueClass.name);
81
81
  }
82
- /**
83
- * Use getIssueByName to prevent issues when getting different instances while using both bit from bvm and from the repo
84
- * @param IssueClass
85
- * @returns
86
- */
87
82
  getIssue(IssueClass) {
88
- return this._issues.find((issue) => issue instanceof IssueClass);
83
+ // don't use instanceof, e.g. `this._issues.find((issue) => issue instanceof IssueClass)`
84
+ // the "component-issues" package can come from different sources, so the "instanceof" won't work.
85
+ // use only getIssueByName for this.
86
+ return this.getIssueByName(IssueClass.name);
89
87
  }
90
88
  getIssueByName(issueType) {
91
89
  return this._issues.find((issue) => issue.constructor.name === issueType);
@@ -1 +1 @@
1
- {"version":3,"file":"issues-list.js","sourceRoot":"","sources":["../issues-list.ts"],"names":[],"mappings":";;;AACA,mEAA6D;AAC7D,6EAAuE;AACvE,mDAA+C;AAC/C,+FAAwF;AACxF,iGAA2F;AAC3F,iDAA6C;AAC7C,+DAA2D;AAC3D,iFAA4E;AAC5E,qDAAiD;AACjD,qEAAiE;AACjE,mEAA8D;AAC9D,mDAA+C;AAC/C,iFAAkF;AAClF,mEAA+D;AAC/D,uFAAiF;AACjF,2EAAqE;AACrE,qDAAgD;AAChD,iFAA2E;AAC3E,iEAA6D;AAC7D,qDAAiD;AAEpC,QAAA,aAAa,GAAG;IAC3B,+BAA+B,EAA/B,qEAA+B;IAC/B,iCAAiC,EAAjC,wEAAiC;IACjC,qBAAqB,EAArB,8CAAqB;IACrB,aAAa,EAAb,8BAAa;IACb,kBAAkB,EAAlB,wCAAkB;IAClB,0BAA0B,EAA1B,yDAA0B;IAC1B,WAAW,EAAX,0BAAW;IACX,YAAY,EAAZ,4BAAY;IACZ,mBAAmB,EAAnB,2CAAmB;IACnB,uBAAuB,EAAvB,oDAAuB;IACvB,kBAAkB,EAAlB,0CAAkB;IAClB,YAAY,EAAZ,4BAAY;IACZ,gCAAgC,EAAhC,+DAAgC;IAChC,oBAAoB,EAApB,4CAAoB;IACpB,4BAA4B,EAA5B,8DAA4B;IAC5B,sBAAsB,EAAtB,kDAAsB;IACtB,YAAY,EAAZ,6BAAY;IACZ,yBAAyB,EAAzB,wDAAyB;IACzB,mBAAmB,EAAnB,0CAAmB;IACnB,aAAa,EAAb,8BAAa;CACd,CAAC;AAGF,MAAa,UAAU;IACrB;IACE;;;;OAIG;IACI,UAA4B,EAAE;QAA9B,YAAO,GAAP,OAAO,CAAuB;IACpC,CAAC;IAEJ,IAAI,KAAK;QACP,OAAO,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC;IAC7B,CAAC;IAED,OAAO;QACL,OAAO,IAAI,CAAC,OAAO,CAAC,MAAM,KAAK,CAAC,CAAC;IACnC,CAAC;IAED,YAAY;QACV,OAAO,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,YAAY,EAAE,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACpE,CAAC;IAED,QAAQ;QACN,OAAO,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,CAAC,CAAC;IACvD,CAAC;IAED;;;;OAIG;IACH,wBAAwB;QACtB,OAAO,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,iCAC9B,KAAK,CAAC,QAAQ,EAAE,KACnB,IAAI,EAAE,KAAK,CAAC,YAAY,EAAE,CAAC,IAAI,EAAE,IACjC,CAAC,CAAC;IACN,CAAC;IAED,GAAG,CAAC,KAAqB;QACvB,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAC3B,CAAC;IAED,MAAM,CAAC,UAAiC;QACtC,IAAI,CAAC,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,KAAK,UAAU,CAAC,IAAI,CAAC,CAAC;IAC5F,CAAC;IAED;;;;OAIG;IACH,QAAQ,CAA2B,UAAyB;QAC1D,OAAO,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,YAAY,UAAU,CAAkB,CAAC;IACpF,CAAC;IAED,cAAc,CAA2B,SAAsB;QAC7D,OAAO,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,KAAK,SAAS,CAAkB,CAAC;IAC7F,CAAC;IAED,YAAY;QACV,OAAO,IAAI,CAAC,OAAO,CAAC;IACtB,CAAC;IAED,gBAAgB;QACd,OAAO,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;IAC7D,CAAC;IAED,WAAW,CAA2B,UAAyB;QAC7D,MAAM,QAAQ,GAAG,IAAI,UAAU,EAAE,CAAC;QAClC,IAAI,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC;QACnB,OAAO,QAAQ,CAAC;IAClB,CAAC;IAED,WAAW,CAA2B,UAAyB;QAC7D,OAAO,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,IAAI,CAAC,WAAW,CAAC,UAAU,CAAC,CAAC;IACnE,CAAC;IAED,wBAAwB;QACtB,OAAO,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,cAAc,CAAC,CAAC;IAC5D,CAAC;IAED,kBAAkB;QAChB,OAAO,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC;IAC1D,CAAC;IAED,oBAAoB;QAClB,OAAO,IAAI,UAAU,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC,CAAC;IAC5E,CAAC;IAED,2BAA2B;QACzB,OAAO,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,iCAC9B,KAAK,CAAC,QAAQ,EAAE,KACnB,YAAY,EAAE,KAAK,CAAC,YAAY,EAAE,IAClC,CAAC,CAAC;IACN,CAAC;IAED,SAAS;QACP,OAAO,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,KAAK,CAAC,WAAW,CAAC,IAAI,EAAE,IAAI,EAAE,KAAK,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC,CAAC;IAClG,CAAC;IAED,MAAM,CAAC,WAAW,CAAC,IAAyB;QAC1C,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;YACzB,gEAAgE;YAChE,OAAO,IAAI,UAAU,EAAE,CAAC;QAC1B,CAAC;QACD,MAAM,MAAM,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE;YAChC,MAAM,SAAS,GAAG,KAAK,CAAC,IAAI,CAAC;YAC7B,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,qBAAa,CAAC,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,CAAC;gBACpD,MAAM,IAAI,KAAK,CAAC,eAAe,SAAS;8BAClB,MAAM,CAAC,IAAI,CAAC,qBAAa,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;YACjE,CAAC;YACD,MAAM,aAAa,GAAmB,IAAI,qBAAa,CAAC,SAAS,CAAC,EAAE,CAAC;YACrE,aAAa,CAAC,IAAI,GAAG,aAAa,CAAC,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;YAC3D,OAAO,aAAa,CAAC;QACvB,CAAC,CAAC,CAAC;QACH,OAAO,IAAI,UAAU,CAAC,MAAM,CAAC,CAAC;IAChC,CAAC;CACF;AArHD,gCAqHC"}
1
+ {"version":3,"file":"issues-list.js","sourceRoot":"","sources":["../issues-list.ts"],"names":[],"mappings":";;;AACA,mEAA6D;AAC7D,6EAAuE;AACvE,mDAA+C;AAC/C,+FAAwF;AACxF,iGAA2F;AAC3F,iDAA6C;AAC7C,+DAA2D;AAC3D,iFAA4E;AAC5E,qDAAiD;AACjD,qEAAiE;AACjE,mEAA8D;AAC9D,mDAA+C;AAC/C,iFAAkF;AAClF,mEAA+D;AAC/D,uFAAiF;AACjF,2EAAqE;AACrE,qDAAgD;AAChD,iFAA2E;AAC3E,iEAA6D;AAC7D,qDAAiD;AAEpC,QAAA,aAAa,GAAG;IAC3B,+BAA+B,EAA/B,qEAA+B;IAC/B,iCAAiC,EAAjC,wEAAiC;IACjC,qBAAqB,EAArB,8CAAqB;IACrB,aAAa,EAAb,8BAAa;IACb,kBAAkB,EAAlB,wCAAkB;IAClB,0BAA0B,EAA1B,yDAA0B;IAC1B,WAAW,EAAX,0BAAW;IACX,YAAY,EAAZ,4BAAY;IACZ,mBAAmB,EAAnB,2CAAmB;IACnB,uBAAuB,EAAvB,oDAAuB;IACvB,kBAAkB,EAAlB,0CAAkB;IAClB,YAAY,EAAZ,4BAAY;IACZ,gCAAgC,EAAhC,+DAAgC;IAChC,oBAAoB,EAApB,4CAAoB;IACpB,4BAA4B,EAA5B,8DAA4B;IAC5B,sBAAsB,EAAtB,kDAAsB;IACtB,YAAY,EAAZ,6BAAY;IACZ,yBAAyB,EAAzB,wDAAyB;IACzB,mBAAmB,EAAnB,0CAAmB;IACnB,aAAa,EAAb,8BAAa;CACd,CAAC;AAGF,MAAa,UAAU;IACrB;IACE;;;;OAIG;IACI,UAA4B,EAAE;QAA9B,YAAO,GAAP,OAAO,CAAuB;IACpC,CAAC;IAEJ,IAAI,KAAK;QACP,OAAO,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC;IAC7B,CAAC;IAED,OAAO;QACL,OAAO,IAAI,CAAC,OAAO,CAAC,MAAM,KAAK,CAAC,CAAC;IACnC,CAAC;IAED,YAAY;QACV,OAAO,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,YAAY,EAAE,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACpE,CAAC;IAED,QAAQ;QACN,OAAO,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,CAAC,CAAC;IACvD,CAAC;IAED;;;;OAIG;IACH,wBAAwB;QACtB,OAAO,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,iCAC9B,KAAK,CAAC,QAAQ,EAAE,KACnB,IAAI,EAAE,KAAK,CAAC,YAAY,EAAE,CAAC,IAAI,EAAE,IACjC,CAAC,CAAC;IACN,CAAC;IAED,GAAG,CAAC,KAAqB;QACvB,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAC3B,CAAC;IAED,MAAM,CAAC,UAAiC;QACtC,IAAI,CAAC,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,KAAK,UAAU,CAAC,IAAI,CAAC,CAAC;IAC5F,CAAC;IAED,QAAQ,CAA2B,UAAyB;QAC1D,yFAAyF;QACzF,kGAAkG;QAClG,oCAAoC;QACpC,OAAO,IAAI,CAAC,cAAc,CAAC,UAAU,CAAC,IAAmB,CAAC,CAAC;IAC7D,CAAC;IAED,cAAc,CAA2B,SAAsB;QAC7D,OAAO,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,KAAK,SAAS,CAAkB,CAAC;IAC7F,CAAC;IAED,YAAY;QACV,OAAO,IAAI,CAAC,OAAO,CAAC;IACtB,CAAC;IAED,gBAAgB;QACd,OAAO,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;IAC7D,CAAC;IAED,WAAW,CAA2B,UAAyB;QAC7D,MAAM,QAAQ,GAAG,IAAI,UAAU,EAAE,CAAC;QAClC,IAAI,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC;QACnB,OAAO,QAAQ,CAAC;IAClB,CAAC;IAED,WAAW,CAA2B,UAAyB;QAC7D,OAAO,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,IAAI,CAAC,WAAW,CAAC,UAAU,CAAC,CAAC;IACnE,CAAC;IAED,wBAAwB;QACtB,OAAO,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,cAAc,CAAC,CAAC;IAC5D,CAAC;IAED,kBAAkB;QAChB,OAAO,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC;IAC1D,CAAC;IAED,oBAAoB;QAClB,OAAO,IAAI,UAAU,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC,CAAC;IAC5E,CAAC;IAED,2BAA2B;QACzB,OAAO,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,iCAC9B,KAAK,CAAC,QAAQ,EAAE,KACnB,YAAY,EAAE,KAAK,CAAC,YAAY,EAAE,IAClC,CAAC,CAAC;IACN,CAAC;IAED,SAAS;QACP,OAAO,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,KAAK,CAAC,WAAW,CAAC,IAAI,EAAE,IAAI,EAAE,KAAK,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC,CAAC;IAClG,CAAC;IAED,MAAM,CAAC,WAAW,CAAC,IAAyB;QAC1C,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;YACzB,gEAAgE;YAChE,OAAO,IAAI,UAAU,EAAE,CAAC;QAC1B,CAAC;QACD,MAAM,MAAM,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE;YAChC,MAAM,SAAS,GAAG,KAAK,CAAC,IAAI,CAAC;YAC7B,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,qBAAa,CAAC,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,CAAC;gBACpD,MAAM,IAAI,KAAK,CAAC,eAAe,SAAS;8BAClB,MAAM,CAAC,IAAI,CAAC,qBAAa,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;YACjE,CAAC;YACD,MAAM,aAAa,GAAmB,IAAI,qBAAa,CAAC,SAAS,CAAC,EAAE,CAAC;YACrE,aAAa,CAAC,IAAI,GAAG,aAAa,CAAC,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;YAC3D,OAAO,aAAa,CAAC;QACvB,CAAC,CAAC,CAAC;QACH,OAAO,IAAI,UAAU,CAAC,MAAM,CAAC,CAAC;IAChC,CAAC;CACF;AAnHD,gCAmHC"}
@@ -8,7 +8,7 @@ class SelfReference extends component_issue_1.ComponentIssue {
8
8
  this.description = 'a component has an import statement that points to itself';
9
9
  this.solution = 'edit the file and change the import statement to a relative path';
10
10
  this.data = {};
11
- this.isTagBlocker = false;
11
+ this.isTagBlocker = true;
12
12
  }
13
13
  }
14
14
  exports.SelfReference = SelfReference;
@@ -1 +1 @@
1
- {"version":3,"file":"self-reference.js","sourceRoot":"","sources":["../self-reference.ts"],"names":[],"mappings":";;;AAAA,uDAAmD;AAEnD,MAAa,aAAc,SAAQ,gCAAc;IAAjD;;QACE,gBAAW,GAAG,2DAA2D,CAAC;QAC1E,aAAQ,GAAG,kEAAkE,CAAC;QAC9E,SAAI,GAAmC,EAAE,CAAC;QAC1C,iBAAY,GAAG,KAAK,CAAC;IACvB,CAAC;CAAA;AALD,sCAKC"}
1
+ {"version":3,"file":"self-reference.js","sourceRoot":"","sources":["../self-reference.ts"],"names":[],"mappings":";;;AAAA,uDAAmD;AAEnD,MAAa,aAAc,SAAQ,gCAAc;IAAjD;;QACE,gBAAW,GAAG,2DAA2D,CAAC;QAC1E,aAAQ,GAAG,kEAAkE,CAAC;QAC9E,SAAI,GAAmC,EAAE,CAAC;QAC1C,iBAAY,GAAG,IAAI,CAAC;IACtB,CAAC;CAAA;AALD,sCAKC"}
@@ -22,8 +22,12 @@
22
22
  "resolveJsonModule": true
23
23
  },
24
24
  "exclude": [
25
+ "artifacts",
26
+ "public",
25
27
  "dist",
26
- "package.json"
28
+ "node_modules",
29
+ "package.json",
30
+ "**/*.cjs"
27
31
  ],
28
32
  "include": [
29
33
  "**/*",
package/issues-list.ts CHANGED
@@ -90,13 +90,11 @@ export class IssuesList {
90
90
  this._issues = this._issues.filter((issue) => issue.constructor.name !== IssueClass.name);
91
91
  }
92
92
 
93
- /**
94
- * Use getIssueByName to prevent issues when getting different instances while using both bit from bvm and from the repo
95
- * @param IssueClass
96
- * @returns
97
- */
98
93
  getIssue<T extends ComponentIssue>(IssueClass: { new (): T }): T | undefined {
99
- return this._issues.find((issue) => issue instanceof IssueClass) as T | undefined;
94
+ // don't use instanceof, e.g. `this._issues.find((issue) => issue instanceof IssueClass)`
95
+ // the "component-issues" package can come from different sources, so the "instanceof" won't work.
96
+ // use only getIssueByName for this.
97
+ return this.getIssueByName(IssueClass.name as IssuesNames);
100
98
  }
101
99
 
102
100
  getIssueByName<T extends ComponentIssue>(issueType: IssuesNames): T | undefined {
package/package.json CHANGED
@@ -1,12 +1,12 @@
1
1
  {
2
2
  "name": "@teambit/component-issues",
3
- "version": "0.0.142",
3
+ "version": "0.0.144",
4
4
  "homepage": "https://bit.cloud/teambit/component/component-issues",
5
5
  "main": "dist/index.js",
6
6
  "componentId": {
7
7
  "scope": "teambit.component",
8
8
  "name": "component-issues",
9
- "version": "0.0.142"
9
+ "version": "0.0.144"
10
10
  },
11
11
  "dependencies": {
12
12
  "chalk": "2.4.2",
package/self-reference.ts CHANGED
@@ -4,5 +4,5 @@ export class SelfReference extends ComponentIssue {
4
4
  description = 'a component has an import statement that points to itself';
5
5
  solution = 'edit the file and change the import statement to a relative path';
6
6
  data: { [filePath: string]: string } = {};
7
- isTagBlocker = false;
7
+ isTagBlocker = true;
8
8
  }
package/tsconfig.json CHANGED
@@ -22,8 +22,12 @@
22
22
  "resolveJsonModule": true
23
23
  },
24
24
  "exclude": [
25
+ "artifacts",
26
+ "public",
25
27
  "dist",
26
- "package.json"
28
+ "node_modules",
29
+ "package.json",
30
+ "**/*.cjs"
27
31
  ],
28
32
  "include": [
29
33
  "**/*",