@team-semicolon/semicolony-cli 4.18.126 → 4.18.128

package/migrations/224_mcp_catalog_compatibility.sql

@@ -0,0 +1,19 @@
+-- Compatibility marker for the Gateway/Dashboard MCP catalog rollout.
+-- The canonical schema is owned and applied by the SEMO Ops operator runner.
+DO $block$
+BEGIN
+  IF NOT EXISTS (
+    SELECT 1 FROM semo_ops.schema_migrations
+     WHERE version = '222_mcp_catalog_control_plane'
+  ) OR NOT EXISTS (
+    SELECT 1 FROM semo_ops.schema_migrations
+     WHERE version = '223_mcp_cohort_releases'
+  ) THEN
+    RAISE EXCEPTION 'SEMO Ops MCP catalog migrations 222 and 223 must be applied first';
+  END IF;
+  IF to_regprocedure('semo_ops.mcp_catalog_for_installation(uuid)') IS NULL
+     OR to_regprocedure('semo_ops.mcp_report_runtime_status(uuid,text,uuid,text,text,text,text,timestamptz)') IS NULL THEN
+    RAISE EXCEPTION 'SEMO Ops MCP Gateway function contract is missing';
+  END IF;
+END;
+$block$;

package/migrations/225_meeting_action_history_preservation.sql

@@ -0,0 +1,388 @@
+-- 225_meeting_action_history_preservation.sql
+-- Source baseline: Semicolony 58771bc9b75a0ed473c1c838199b48e075192c13.
+-- 2026-09-14 audit reproduced migration 204 deleting completed follow-ups and
+-- their ON DELETE CASCADE event histories when a meeting was re-recorded.
+-- Preserve existing tasks and append only new descriptions. Retain proposed
+-- changes in meetings.metadata.meeting_import.preserved_action_items for review.
+-- Signature and ACL stay unchanged; the runner owns the transaction.
+-- Validation: scripts/verify-meeting-action-preservation.sql on disposable PG.
+-- Rollback: restore the 15-argument function from migration 204 (no data DDL).
+
+CREATE OR REPLACE FUNCTION semicolony.record_meeting(
+  p_title text,
+  p_meeting_date date,
+  p_meeting_type text,
+  p_adhoc_subtype text,
+  p_visibility text,
+  p_target_domain text,
+  p_attendees jsonb,
+  p_record_body text,
+  p_transcript text,
+  p_action_items jsonb,
+  p_record_source text,
+  p_worker_id text,
+  p_device_id text,
+  p_discussion_url text DEFAULT NULL,
+  p_discussion_number integer DEFAULT NULL
+)
+RETURNS TABLE(meeting_id uuid, kb_id bigint, action_item_ids uuid[], duplicate boolean)
+LANGUAGE plpgsql
+SECURITY DEFINER
+SET search_path = pg_catalog
+AS $function$
+DECLARE
+  v_meeting_id uuid;
+  v_kb_id bigint;
+  v_existing uuid;
+  v_norm text;
+  v_sensitivity text;
+  v_sub_key text;
+  v_item jsonb;
+  v_item_id uuid;
+  v_preserved jsonb;
+  v_description text;
+  v_priority text;
+  v_project text;
+  v_candidate text;
+  v_assignee_kind text;
+  v_assignee_member text;
+  v_assignee_agent text;
+  v_external_contact text;
+  v_deadline date;
+  -- Y1: fallbacks are recorded as data, not only as a log line. v_fallbacks
+  -- accumulates per item and lands in that item's own metadata; v_skipped
+  -- accumulates items that produced no row at all and lands on the meeting.
+  v_fallbacks jsonb;
+  v_skipped jsonb;
+BEGIN
+  IF p_title IS NULL OR length(btrim(p_title)) < 3 THEN
+    RAISE EXCEPTION 'title must be at least 3 characters';
+  END IF;
+  IF p_meeting_date IS NULL THEN
+    RAISE EXCEPTION 'meeting_date is required';
+  END IF;
+  IF p_visibility IS NULL OR p_visibility NOT IN ('team', 'restricted') THEN
+    RAISE EXCEPTION 'visibility must be team or restricted, got %', p_visibility;
+  END IF;
+  IF p_record_source IS NULL
+     OR p_record_source NOT IN ('slack-worker', 'operator', 'backfill-discussion') THEN
+    RAISE EXCEPTION 'invalid record_source %', p_record_source;
+  END IF;
+  IF p_record_body IS NULL OR length(btrim(p_record_body)) = 0 THEN
+    RAISE EXCEPTION 'record_body is required';
+  END IF;
+
+  v_norm := lower(regexp_replace(btrim(p_title), '\s+', ' ', 'g'));
+  v_sensitivity := CASE WHEN p_visibility = 'restricted' THEN 'restricted' ELSE 'internal' END;
+
+  -- Serialize all writers for one normalized meeting, including first insert.
+  PERFORM pg_advisory_xact_lock(hashtextextended(
+    'meeting:' || p_meeting_date::text || ':' || v_norm, 0));
+
+  SELECT m.meeting_id INTO v_existing
+    FROM semicolony.meetings m
+   WHERE m.meeting_date = p_meeting_date
+     AND lower(regexp_replace(m.title, '\s+', ' ', 'g')) = v_norm;
+
+  -- Discussion provenance from 202_meeting_record_discussion_provenance,
+  -- unchanged: COALESCE on update so a re-record that omits the link does not
+  -- erase one an earlier submission established, and both columns written on
+  -- insert.
+  IF v_existing IS NOT NULL THEN
+    UPDATE semicolony.meetings m
+       SET record_body = COALESCE(p_record_body, m.record_body),
+           mapped_transcript = COALESCE(p_transcript, m.mapped_transcript),
+           visibility = p_visibility,
+           record_source = p_record_source,
+           target_domain = COALESCE(p_target_domain, m.target_domain),
+           attendees = COALESCE(p_attendees, m.attendees),
+           discussion_url = COALESCE(p_discussion_url, m.discussion_url),
+           discussion_number = COALESCE(p_discussion_number, m.discussion_number),
+           updated_at = now()
+     WHERE m.meeting_id = v_existing;
+    v_meeting_id := v_existing;
+  ELSE
+    INSERT INTO semicolony.meetings (
+      meeting_id, title, meeting_type, adhoc_subtype, meeting_date, attendees,
+      visibility, record_body, mapped_transcript, record_source, target_domain,
+      transcription_status, speaker_map, discussion_url, discussion_number,
+      created_at, updated_at
+    ) VALUES (
+      gen_random_uuid(), btrim(p_title), p_meeting_type, p_adhoc_subtype, p_meeting_date,
+      COALESCE(p_attendees, '[]'::jsonb), p_visibility, p_record_body,
+      p_transcript, p_record_source, p_target_domain,
+      'completed', '{}'::jsonb, p_discussion_url, p_discussion_number, now(), now()
+    ) RETURNING meetings.meeting_id INTO v_meeting_id;
+  END IF;
+
+  v_sub_key := to_char(p_meeting_date, 'YYYY-MM-DD') || '-' || left(v_norm, 60);
+
+  INSERT INTO semicolony.knowledge_base (
+    domain, key, sub_key, content, metadata, created_by, created_at, updated_at
+  ) VALUES (
+    COALESCE(p_target_domain, 'semicolon'),
+    'meeting',
+    v_sub_key,
+    p_record_body,
+    jsonb_build_object(
+      'classification', jsonb_build_object('sensitivity', v_sensitivity),
+      'meeting_id', v_meeting_id,
+      'meeting_date', to_char(p_meeting_date, 'YYYY-MM-DD'),
+      'record_source', p_record_source
+    ),
+    COALESCE(p_worker_id, 'meeting-worker'),
+    now(), now()
+  )
+  ON CONFLICT (domain, key, sub_key) DO UPDATE
+    SET content = EXCLUDED.content,
+        metadata = semicolony.knowledge_base.metadata || EXCLUDED.metadata,
+        updated_at = now()
+  RETURNING semicolony.knowledge_base.kb_id INTO v_kb_id;
+
+  -- Re-extraction is additive. The action ledger owns execution state, manual
+  -- corrections and audit history; a transcript refresh cannot replace it.
+  -- A matching description is conservative identity within one meeting.
+  -- Preserve changed proposals for review instead of overwriting assignments,
+  -- deadlines or completion. Deliberate edits use the action-item API.
+  IF p_action_items IS NOT NULL AND jsonb_typeof(p_action_items) = 'array'
+     AND jsonb_array_length(p_action_items) > 0 THEN
+    v_skipped := '[]'::jsonb;
+    v_preserved := '[]'::jsonb;
+
+    FOR v_item IN
+      SELECT item FROM jsonb_array_elements(p_action_items) AS item
+    LOOP
+      v_description := btrim(COALESCE(v_item ->> 'description', ''));
+      IF char_length(v_description) < 5 THEN
+        RAISE WARNING 'record_meeting: skipping meeting % action item, description shorter than 5 characters (%)',
+          v_meeting_id, v_description;
+        -- Y1: the RAISE alone is not evidence. Neither meeting-service.ts nor
+        -- meetings.ts subscribes to pg's `notice` event, so a WARNING is
+        -- visible only to someone attached with psql by hand. This item
+        -- produces no row to carry its own record, so the whole submitted
+        -- item is preserved on the meeting instead — an operator can then see
+        -- that the meeting's follow-up list is incomplete, and what was lost.
+        v_skipped := v_skipped || jsonb_build_array(jsonb_build_object(
+          'reason', 'description_shorter_than_5_characters',
+          'description', v_item ->> 'description',
+          'owner', v_item ->> 'owner',
+          'target', v_item ->> 'target',
+          'assignee', v_item ->> 'assignee',
+          'deadline', v_item ->> 'deadline',
+          'priority', v_item ->> 'priority'
+        ));
+        CONTINUE;
+      END IF;
+
+      -- Y1: reset per item. Anything appended here lands in the created row's
+      -- metadata under meeting_import.fallbacks, so the row itself answers
+      -- "why is this filed under semo-ops / due then / unassigned?".
+      v_fallbacks := '[]'::jsonb;
+
+      v_item_id := NULL;
+      SELECT a.action_item_id INTO v_item_id
+        FROM semicolony.action_items a
+       WHERE a.meeting_id = v_meeting_id
+         AND lower(regexp_replace(btrim(a.description), '\s+', ' ', 'g')) =
+             lower(regexp_replace(v_description, '\s+', ' ', 'g'))
+       ORDER BY a.created_at, a.action_item_id
+       LIMIT 1;
+      IF v_item_id IS NOT NULL THEN
+        v_preserved := v_preserved || jsonb_build_array(jsonb_build_object(
+          'action_item_id', v_item_id, 'submitted', v_item,
+          'reason', 'existing_followup_preserved'));
+        CONTINUE;
+      END IF;
+
+      v_priority := COALESCE(NULLIF(btrim(v_item ->> 'priority'), ''), 'normal');
+      IF v_priority NOT IN ('low', 'normal', 'high', 'urgent') THEN
+        RAISE WARNING 'record_meeting: meeting % action item priority % is not one of low/normal/high/urgent, recording as normal',
+          v_meeting_id, v_priority;
+        v_fallbacks := v_fallbacks || jsonb_build_array(jsonb_build_object(
+          'field', 'priority',
+          'reason', 'not_in_low_normal_high_urgent',
+          'substituted', 'normal',
+          'original', v_priority
+        ));
+        v_priority := 'normal';
+      END IF;
+
+      v_project := NULL;
+      FOREACH v_candidate IN ARRAY ARRAY[
+        NULLIF(btrim(v_item ->> 'target'), ''),
+        NULLIF(btrim(v_item ->> 'owner'), ''),
+        NULLIF(btrim(p_target_domain), '')
+      ]
+      LOOP
+        CONTINUE WHEN v_candidate IS NULL;
+        IF EXISTS (SELECT 1 FROM semicolony.ontology o
+                    WHERE o.domain = v_candidate AND o.entity_type = 'service') THEN
+          v_project := v_candidate;
+          EXIT;
+        END IF;
+      END LOOP;
+      -- Y1: record the substitution before it is applied, while the rejected
+      -- candidates are still distinguishable from a deliberate 'semo-ops'.
+      IF v_project IS NULL THEN
+        RAISE WARNING 'record_meeting: meeting % action item names no entity_type=service domain (target %, owner %, meeting target %), filing under semo-ops',
+          v_meeting_id, v_item ->> 'target', v_item ->> 'owner', p_target_domain;
+        v_fallbacks := v_fallbacks || jsonb_build_array(jsonb_build_object(
+          'field', 'project_domain',
+          'reason', 'no_service_domain_among_candidates',
+          'substituted', 'semo-ops',
+          'original', jsonb_build_object(
+            'target', v_item ->> 'target',
+            'owner', v_item ->> 'owner',
+            'meeting_target_domain', p_target_domain
+          )
+        ));
+      END IF;
+      v_project := COALESCE(v_project, 'semo-ops');
+
+      v_assignee_kind   := 'unassigned';
+      v_assignee_member := NULL;
+      v_assignee_agent  := NULL;
+      FOREACH v_candidate IN ARRAY ARRAY[
+        NULLIF(btrim(v_item ->> 'assignee'), ''),
+        NULLIF(btrim(v_item ->> 'owner'), '')
+      ]
+      LOOP
+        CONTINUE WHEN v_candidate IS NULL;
+        IF EXISTS (SELECT 1 FROM semicolony.team_members tm WHERE tm.domain = v_candidate) THEN
+          v_assignee_kind   := 'team-member';
+          v_assignee_member := v_candidate;
+          EXIT;
+        ELSIF EXISTS (SELECT 1 FROM semicolony.bot_status bs WHERE bs.bot_id = v_candidate) THEN
+          v_assignee_kind  := 'agent';
+          v_assignee_agent := v_candidate;
+          EXIT;
+        END IF;
+      END LOOP;
+
+      v_external_contact := CASE WHEN v_assignee_kind = 'unassigned'
+                                 THEN NULLIF(btrim(v_item ->> 'assignee'), '')
+                                 ELSE NULL END;
+
+      -- Y1: only a *supplied* name that failed to resolve is a fallback. An
+      -- item that named nobody is simply unassigned, not a substitution, and
+      -- recording it as one would bury the real cases in noise.
+      IF v_assignee_kind = 'unassigned'
+         AND (NULLIF(btrim(v_item ->> 'assignee'), '') IS NOT NULL
+              OR NULLIF(btrim(v_item ->> 'owner'), '') IS NOT NULL) THEN
+        RAISE WARNING 'record_meeting: meeting % action item assignee (assignee %, owner %) is neither a team member nor an agent, leaving it unassigned',
+          v_meeting_id, v_item ->> 'assignee', v_item ->> 'owner';
+        v_fallbacks := v_fallbacks || jsonb_build_array(jsonb_build_object(
+          'field', 'assignee',
+          'reason', 'not_a_team_member_or_agent',
+          'substituted', 'unassigned',
+          'original', jsonb_build_object(
+            'assignee', v_item ->> 'assignee',
+            'owner', v_item ->> 'owner'
+          ),
+          'external_contact', v_external_contact
+        ));
+      END IF;
+
+      v_deadline := COALESCE(
+        NULLIF(btrim(v_item ->> 'deadline'), '')::date,
+        semicolony.action_item_default_deadline(v_priority)
+      );
+
+      -- Y1: the COALESCE above is deliberately left byte-identical (its shape
+      -- is pinned by the migration test); the fallback is detected separately
+      -- on the same condition rather than by restructuring it.
+      IF NULLIF(btrim(v_item ->> 'deadline'), '') IS NULL THEN
+        RAISE WARNING 'record_meeting: meeting % action item has no deadline, defaulting to % for priority %',
+          v_meeting_id, v_deadline, v_priority;
+        v_fallbacks := v_fallbacks || jsonb_build_array(jsonb_build_object(
+          'field', 'deadline',
+          'reason', 'absent',
+          'substituted', to_char(v_deadline, 'YYYY-MM-DD'),
+          'original', v_item ->> 'deadline',
+          'derived_from_priority', v_priority
+        ));
+      END IF;
+
+      v_item_id := semicolony.create_action_item(
+        p_description        => v_description,
+        p_project_domain     => v_project,
+        p_deadline           => v_deadline,
+        p_assignee_kind      => v_assignee_kind,
+        p_assignee_member    => v_assignee_member,
+        p_assignee_agent     => v_assignee_agent,
+        p_assignee_device    => NULL,
+        p_priority           => v_priority,
+        p_source_kind        => 'meeting',
+        p_source_ref         => v_meeting_id::text,
+        p_related_url        => NULL,
+        p_external_contact   => v_external_contact,
+        p_metadata           => jsonb_build_object(
+                                  'meeting_id', v_meeting_id,
+                                  'meeting_date', to_char(p_meeting_date, 'YYYY-MM-DD'),
+                                  'record_source', p_record_source,
+                                  'worker_id', p_worker_id,
+                                  'device_id', p_device_id,
+                                  'raw_owner', v_item ->> 'owner',
+                                  'raw_target', v_item ->> 'target',
+                                  'raw_assignee', v_item ->> 'assignee',
+                                  -- Y1: always present, empty array when the
+                                  -- item mapped cleanly, so a consumer can
+                                  -- filter on jsonb_array_length() without
+                                  -- having to distinguish absent from empty.
+                                  'meeting_import', jsonb_build_object(
+                                    'fallbacks', v_fallbacks
+                                  )
+                                ),
+        p_origin_surface     => 'system',
+        p_origin_actor_kind  => NULL,
+        p_origin_member      => NULL,
+        p_origin_agent       => NULL,
+        p_origin_device      => NULL,
+        p_origin_harness     => NULL,
+        p_origin_session_key => NULL
+      );
+
+      -- The typed relation 198 added. create_action_item deliberately has no
+      -- meeting_id parameter: meetings are one source among nine and the
+      -- function's parameter list is already twenty wide, so the linkage is
+      -- stamped here, in the same transaction, rather than widening every
+      -- caller's signature for one of them.
+      UPDATE semicolony.action_items
+         SET meeting_id = v_meeting_id
+       WHERE action_item_id = v_item_id;
+    END LOOP;
+
+    -- Y1: publish the skip list on the meeting, inside the same IF that owns
+    -- the delete-and-recreate. `||` replaces the whole meeting_import key
+    -- rather than merging into it, so a re-record with the descriptions fixed
+    -- writes back an empty array instead of leaving a stale accusation on a
+    -- meeting whose follow-up list is now complete — the evidence follows the
+    -- same idempotency rule as the items it describes. Keeping it inside the
+    -- IF also means an empty submission leaves both the items and their
+    -- evidence untouched, which is the behaviour 199 defined and verification
+    -- confirmed.
+    UPDATE semicolony.meetings m
+       SET metadata = COALESCE(m.metadata, '{}'::jsonb)
+                      || jsonb_build_object('meeting_import', jsonb_build_object(
+                           'preserved_action_items', v_preserved,
+                           'preserved_count', jsonb_array_length(v_preserved),
+                           'skipped_action_items', v_skipped,
+                           'skipped_count', jsonb_array_length(v_skipped),
+                           'submitted_count', jsonb_array_length(p_action_items),
+                           'recorded_at', now(),
+                           'record_source', p_record_source
+                         )),
+           updated_at = now()
+     WHERE m.meeting_id = v_meeting_id;
+  END IF;
+
+  RETURN QUERY
+  SELECT v_meeting_id,
+         v_kb_id,
+         COALESCE(ARRAY(SELECT a.action_item_id
+                          FROM semicolony.action_items a
+                         WHERE a.meeting_id = v_meeting_id
+                         ORDER BY a.created_at), '{}'::uuid[]),
+         (v_existing IS NOT NULL);
+END;
+$function$;