@team-agent/installer 0.5.92 → 0.5.97

package/crates/team-agent/src/cli/diagnose.rs

@@ -161,6 +161,19 @@ pub(crate) fn diagnose_runtime(state: &Value, backend: &dyn Transport) -> (Value
             }
             issues.push(issue);
         }
+        // Preserve distinct worker failures even when the shared session probe
+        // short-circuits pane enumeration.  This keeps scope evidence without
+        // issuing another transport probe per worker.
+        if let Some(agents) = state.get("agents").and_then(Value::as_object) {
+            for agent_id in agents.keys() {
+                let issue = format!("worker_window_missing:{agent_id}");
+                issues.push(json!(issue.clone()));
+                repairs.push(json!({
+                    "issue": issue,
+                    "action": "team-agent restart",
+                }));
+            }
+        }
         return (Value::Array(issues), Value::Array(repairs));
     }
 
@@ -289,6 +302,7 @@ pub(crate) fn diagnose_runtime_for_workspace(
     state: &Value,
     backend: &dyn Transport,
     selected_team_key: Option<&str>,
+    coordinator_health: &crate::coordinator::HealthReport,
 ) -> (Value, Value) {
     let (mut issues, mut repairs) = diagnose_runtime(state, backend);
     append_live_leader_workspace_mismatch_issue(
@@ -306,7 +320,7 @@ pub(crate) fn diagnose_runtime_for_workspace(
         &mut repairs,
     );
     append_legacy_snapshot_issue(workspace, state, &mut issues);
-    append_coordinator_health_issue(workspace, state, &mut issues, &mut repairs);
+    append_coordinator_health_issue(workspace, state, coordinator_health, &mut issues, &mut repairs);
     append_runtime_bindings_stale_after_boot_issue(workspace, state, &mut issues, &mut repairs);
     (issues, repairs)
 }
@@ -322,8 +336,27 @@ pub(crate) fn workspace_has_existing_team_runtime(
     workspace: &std::path::Path,
     team_key: &str,
 ) -> bool {
-    workspace.join("team.spec.yaml").is_file()
-        || crate::model::paths::runtime_spec_path(workspace, team_key).is_file()
+    // A source TEAM.md/team.spec.yaml is install/configuration context, not a
+    // live runtime.  Only persisted runtime state/specs make topology checks
+    // applicable; an empty workspace therefore remains a healthy no-runtime
+    // report instead of a fabricated missing-session issue.
+    if let Ok(state) = crate::state::persist::load_runtime_state_without_migrations(workspace) {
+        // The workspace's top-level view may describe a stopped sibling.
+        // Preserve the top-level fallback for legacy single-team state only
+        // when there is no selected team entry.
+        let team_state = state
+            .get("teams")
+            .and_then(|teams| teams.get(team_key))
+            .unwrap_or(&state);
+        let terminal = team_state
+            .get("status")
+            .and_then(Value::as_str)
+            .is_some_and(|status| matches!(status, "stopped" | "shutdown" | "archived" | "terminal"));
+        if terminal {
+            return false;
+        }
+    }
+    crate::model::paths::runtime_spec_path(workspace, team_key).is_file()
         || crate::state::persist::runtime_state_path(workspace).is_file()
 }
 
@@ -790,21 +823,18 @@ fn append_legacy_snapshot_issue(workspace: &std::path::Path, state: &Value, issu
 fn append_coordinator_health_issue(
     workspace: &std::path::Path,
     state: &Value,
+    health: &crate::coordinator::HealthReport,
     issues: &mut Value,
     repairs: &mut Value,
 ) {
-    // Diagnose must observe coordinator state without initializing or rewriting
-    // `.team/runtime/team.db`, including when the file is missing or empty.
-    let workspace = crate::coordinator::WorkspacePath::new(workspace.to_path_buf());
-    let health = crate::coordinator::coordinator_health_read_only(&workspace);
-    let Some(id) = coordinator_issue_id(state, &health) else {
+    let Some(id) = coordinator_issue_id(state, health) else {
         return;
     };
     if let Some(items) = issues.as_array_mut() {
-        items.push(coordinator_issue_value(id, &health, workspace.as_path()));
+        items.push(coordinator_issue_value(id, health, workspace));
     }
     if let Some(items) = repairs.as_array_mut() {
-        items.push(coordinator_repair_hint(id, &health));
+        items.push(coordinator_repair_hint(id, health));
     }
 }
 

package/crates/team-agent/src/cli/emit.rs

@@ -225,7 +225,8 @@ fn dispatch(command: &str, args: &[String], cwd: &Path) -> Result<ExitCode, CliE
         "profile" => cmd_profile(&profile_args(args, cwd)?).map(emit_result),
         "results" => cmd_results(&results_args(args, cwd)?).map(emit_result),
         "wait" => cmd_wait(&wait_args(args, cwd)?).map(emit_result),
-        "diagnose" => cmd_diagnose(&diagnose_args(args, cwd)).map(emit_result),
+        // Compatibility spelling: parse and execute the exact doctor contract.
+        "diagnose" => cmd_doctor(&doctor_args(args, cwd)).map(emit_result),
         "preflight" => cmd_preflight(&preflight_args(args, cwd)).map(emit_result),
         "wait-ready" => cmd_wait_ready(&wait_ready_args(args, cwd)).map(emit_result),
         "e2e" => cmd_e2e(&e2e_args(args, cwd)).map(emit_result),
@@ -340,7 +341,7 @@ pub(crate) fn default_help() -> String {
             "reset-agent",
         ],
     );
-    append_help_section(&mut out, "Diagnose", &["diagnose"]);
+    append_help_section(&mut out, "Diagnose", &["doctor"]);
     append_help_section(
         &mut out,
         "Guided recovery",
@@ -444,7 +445,7 @@ fn command_help(command: Option<&str>) -> String {
         Some("profile") => "usage: team-agent profile COMMAND NAME [--workspace WORKSPACE] [--team TEAM] [--auth-mode MODE] [--proxy-mode direct|inherit] [--json]".to_string(),
         Some("results") => "usage: team-agent results --case CASE_ID [--workspace WORKSPACE] [--team TEAM] [--json]".to_string(),
         Some("wait") => "usage: team-agent wait --task TASK [--workspace WORKSPACE] [--json]".to_string(),
-        Some("diagnose") => "usage: team-agent diagnose [--workspace WORKSPACE] [--team TEAM] [--json]".to_string(),
+        Some("diagnose") => "usage: team-agent doctor [SPEC] [--workspace WORKSPACE] [--team TEAM] [--gate orphans|comms] [--comms] [--fix] [--fix-schema] [--cleanup-orphans] [--confirm] [--json]".to_string(),
         Some("preflight") => "usage: team-agent preflight [TEAMDIR] [--json]".to_string(),
         Some("wait-ready") => "usage: team-agent wait-ready [--workspace WORKSPACE] [--team TEAM] [--timeout SECONDS] [--json]".to_string(),
         Some("e2e") => "usage: team-agent e2e [--workspace WORKSPACE] [--providers LIST] [--real] [--json]".to_string(),
@@ -2172,7 +2173,8 @@ mod tests {
     fn hidden_commands_not_in_default_help() {
         let top_help = command_help(None);
         let visible = visible_help_commands(&top_help);
-        for command in ["leaders", "doctor", "e2e", "peek", "coordinator"] {
+        assert!(visible.iter().any(|command| command == "doctor"));
+        for command in ["leaders", "diagnose", "e2e", "peek", "coordinator"] {
             assert!(
                 !visible.iter().any(|visible| visible == command),
                 "`{command}` must stay hidden from default help"