@team-agent/installer 0.5.61 → 0.5.63

package/crates/team-agent/src/model/permissions.rs

@@ -1,3 +1,4 @@
+//!
 //! §19/§3 移植 `permissions.py`:role/provider/alias → 规范化权限矩阵。
 //!
 //! Python 全程裸 `str` + `dict[str, Any]`(`expand_tools`/`resolve_permissions`/
@@ -56,7 +57,7 @@ impl Tool {
 ///
 /// 注:返回**声明序集合**;Python 返回的是 role 字面顺序的 list,但下游 `resolve_*`
 /// 立即过 `expand_tools`(去重+排序),顺序不参与对拍,故此处用 `BTreeSet` 即可。
-pub fn default_tools_for_role(role: &str) -> BTreeSet<Tool> {
+fn default_tools_for_role(role: &str) -> BTreeSet<Tool> {
     use Tool::*;
     let tools: &[Tool] = match role {
         "leader" | "supervisor" => &[FsRead, FsList, McpTeam, ProviderBuiltin],
@@ -175,7 +176,7 @@ pub fn is_canonical_tool(name: &str) -> bool {
 ///
 /// 表里没有的 provider(如 `claude`)= Python 的 `.get(provider, {})` → 空表 →
 /// 每个 tool 再 `.get(tool, "prompt_only")` → 全 `prompt_only`(对拍 `R-unknownprov`)。
-pub fn provider_enforcement(provider: Provider, tool: Tool) -> Enforcement {
+fn provider_enforcement(provider: Provider, tool: Tool) -> Enforcement {
     use Enforcement::{Hard, PromptOnly};
     use Tool::*;
     match provider {

package/crates/team-agent/src/model/routing.rs

@@ -1,3 +1,4 @@
+//!
 //! 移植 `team_agent/routing.py` 的纯函数 `route_task`(真相源 v0.2.11)。
 //!
 //! 操作 spec/task 的 [`yaml::Value`]。返回 [`RouteResult`]{agent_id, reason}。

package/crates/team-agent/src/model/spec.rs

@@ -1,3 +1,4 @@
+//!
 //! spec / result-envelope 校验(`spec.py`)。
 //!
 //! 本 module **操作解析后的 Value**(非 typed struct)——与 Python 一样校验 dict,

package/crates/team-agent/src/model/task_graph.rs

@@ -1,3 +1,4 @@
+//!
 //! 移植 `team_agent/task_graph.py` 的三个纯函数:`find_dependency_cycle` /
 //! `ready_tasks` / `update_task_status`(真相源 v0.2.11)。
 //!

package/crates/team-agent/src/model/yaml/tests.rs

@@ -1,3 +1,4 @@
+//!
 #![allow(clippy::unwrap_used)]
 use super::*;
 

package/crates/team-agent/src/model/yaml.rs

@@ -1,3 +1,4 @@
+//!
 //! step 2 · model — `simple_yaml` 方言移植(真相源 `src/team_agent/simple_yaml.py`)。
 //!
 //! Team Agent **不**用标准 YAML:它有一份零依赖、字节级特判的子集 `loads`/`dumps`,

package/crates/team-agent/src/packaging/install.rs

@@ -1,14 +1,15 @@
-//! installer 行为入口:`install` / `update` / `uninstall` / `install_skill` / `diagnose_path`
-//! + 文件系统副作用 helper(原子替换 / copytree / stale diff / team-running 判定)。
+//!
+//! installer 行为入口:`install` / `install_skill` / `diagnose_path`
+//! + 文件系统副作用 helper(copytree / stale diff)。
 
 use std::path::{Path, PathBuf};
 
 use super::types::{
-    AtomicReplaceOutcome, BinDir, DoctorStatus, InstallOptions, InstallReport, PackagingError,
-    PathDiagnostic, PathHint, Prefix, SkillDestDir, SkillInstallOptions, SkillInstallOutcome,
-    SkillTarget, UninstallOptions, UninstallOutcome, Version,
+    BinDir, DoctorStatus, InstallOptions, InstallReport, PackagingError, PathDiagnostic, PathHint,
+    Prefix, SkillDestDir, SkillInstallOptions, SkillInstallOutcome, SkillTarget, Version,
 };
 
+///
 /// installer `install`(首装,`install.mjs:48`)。写 bin/wrapper + 装 skill(`--target all`)+ 跑 doctor。
 /// **首装无二进制替换**(`InstallReport.replace == None`)。
 /// // REAL-MACHINE-E2E:全副作用(写 bin / 拷 skill / 探 PATH / 跑 doctor)只能真机/容器 clean-install 验。
@@ -41,66 +42,7 @@ pub fn install(opts: &InstallOptions) -> Result<InstallReport, PackagingError> {
     })
 }
 
-/// installer `update`(`install.mjs:48` 同 install 入口 + 二进制原子替换 + rollback)。
-/// **有二进制替换**(`InstallReport.replace == Some(..)`);失败回滚到 `.previous`(bug-084 同源)。
-/// // REAL-MACHINE-E2E:原子替换 / 跨卷 fallback / rollback 只能真机/容器验。
-pub fn update(opts: &InstallOptions) -> Result<InstallReport, PackagingError> {
-    let mut report = install(opts)?;
-    report.replace = Some(atomic_replace_binary(
-        &opts.self_binary,
-        &report.installed_bin,
-    )?);
-    Ok(report)
-}
-
-/// installer `uninstall`(`install.mjs:109`)。删 bin/wrapper + skill;默认保留 runtime/workspace。
-/// `purge_runtime=true` 且检测无 team 在跑才真 purge,否则 `purge_refused_team_running=true`。
-/// // REAL-MACHINE-E2E:真删 + team-running 判定(经 state 投影)需真机/容器验。
-pub fn uninstall(opts: &UninstallOptions) -> Result<UninstallOutcome, PackagingError> {
-    let mut removed_bins = Vec::new();
-    for name in ["team-agent", "codex-team-agent", "claude-team-agent"] {
-        let path = opts.prefix.0.join("bin").join(name);
-        if path.exists() {
-            std::fs::remove_file(&path)?;
-            removed_bins.push(path);
-        }
-    }
-
-    let home = home_dir();
-    let mut removed_skill_dirs = Vec::new();
-    for target in SkillTarget::SINGLE_TARGETS {
-        if let Some(dest) = target.dest_dir(&home) {
-            if dest.0.exists() {
-                std::fs::remove_dir_all(&dest.0)?;
-                removed_skill_dirs.push(dest);
-            }
-        }
-    }
-
-    let mut purged_runtime = false;
-    let mut purge_refused_team_running = false;
-    if opts.purge_runtime {
-        if let Some(workspace) = &opts.workspace {
-            if workspace_has_running_team(workspace)? {
-                purge_refused_team_running = true;
-            } else {
-                let team_dir = workspace.join(".team");
-                if team_dir.exists() {
-                    std::fs::remove_dir_all(&team_dir)?;
-                }
-                purged_runtime = true;
-            }
-        }
-    }
-
-    Ok(UninstallOutcome {
-        removed_bins,
-        removed_skill_dirs,
-        purged_runtime,
-        purge_refused_team_running,
-    })
-}
-
+///
 /// `team-agent install-skill`(`commands.py:451`)。repo `skills/team-agent/` → `~/.codex|.claude`。
 /// `--target all` fan-out 两者;`--dest` 不能与 `--target all` 组合(`commands.py:453` → Err)。
 /// 拷前清陈旧残留(修 `dirs_exist_ok` 残留);`--dry-run` 只报告不落地。
@@ -161,9 +103,10 @@ pub fn install_skill(
     Ok(out)
 }
 
+///
 /// 「bin 不在 PATH」诊断(`bincheck.mjs` 等价;下载即跑也要提示 PATH/可执行位)。
 /// 纯诊断(无副作用,可单测除真探 PATH 外的逻辑)。
-pub fn diagnose_path(bin_dir: &BinDir) -> Result<PathHint, PackagingError> {
+fn diagnose_path(bin_dir: &BinDir) -> Result<PathHint, PackagingError> {
     let path_var = std::env::var("PATH").unwrap_or_default();
     let entries: Vec<PathBuf> = path_var
         .split(':')
@@ -212,69 +155,6 @@ fn default_skill_source() -> PathBuf {
         .join("team-agent")
 }
 
-fn atomic_replace_binary(
-    source: &Path,
-    dest: &Path,
-) -> Result<AtomicReplaceOutcome, PackagingError> {
-    if !source.exists() {
-        return Err(PackagingError::Io(std::io::Error::new(
-            std::io::ErrorKind::NotFound,
-            format!("self binary not found: {}", source.display()),
-        )));
-    }
-    let Some(parent) = dest.parent() else {
-        return Err(PackagingError::InvalidOptions(format!(
-            "binary destination has no parent: {}",
-            dest.display()
-        )));
-    };
-    std::fs::create_dir_all(parent)?;
-
-    let backup = dest.with_extension("previous");
-    let tmp = dest.with_extension(format!("tmp-{}", std::process::id()));
-    if tmp.exists() {
-        remove_path(&tmp)?;
-    }
-    std::fs::copy(source, &tmp)?;
-
-    if backup.exists() {
-        remove_path(&backup)?;
-    }
-    if dest.exists() {
-        std::fs::rename(dest, &backup)?;
-    }
-
-    match std::fs::rename(&tmp, dest) {
-        Ok(()) => Ok(AtomicReplaceOutcome::Replaced { backup }),
-        Err(err) => {
-            let rollback = if backup.exists() {
-                std::fs::rename(&backup, dest)
-            } else {
-                Ok(())
-            };
-            let _ = remove_path(&tmp);
-            match rollback {
-                Ok(()) => Ok(AtomicReplaceOutcome::RolledBack {
-                    restored_from: backup,
-                    error: err.to_string(),
-                }),
-                Err(rollback_err) => Err(PackagingError::ReplaceFailed(format!(
-                    "replace failed: {err}; rollback failed: {rollback_err}"
-                ))),
-            }
-        }
-    }
-}
-
-fn remove_path(path: &Path) -> Result<(), PackagingError> {
-    if path.is_dir() {
-        std::fs::remove_dir_all(path)?;
-    } else if path.exists() {
-        std::fs::remove_file(path)?;
-    }
-    Ok(())
-}
-
 fn collect_files(path: &Path) -> Result<Vec<PathBuf>, PackagingError> {
     let mut out = Vec::new();
     if !path.exists() {
@@ -337,21 +217,3 @@ fn copy_tree_inner(source: &Path, dest: &Path) -> Result<(), PackagingError> {
     }
     Ok(())
 }
-
-fn workspace_has_running_team(workspace: &Path) -> Result<bool, PackagingError> {
-    let path = workspace.join(".team").join("state.json");
-    if !path.exists() {
-        return Ok(false);
-    }
-    let text = std::fs::read_to_string(path)?;
-    let value: serde_json::Value = serde_json::from_str(&text)
-        .map_err(|e| PackagingError::State(format!("state parse failed: {e}")))?;
-    let Some(teams) = value.get("teams").and_then(serde_json::Value::as_object) else {
-        return Ok(false);
-    };
-    Ok(teams.values().any(|team| {
-        team.get("status")
-            .and_then(serde_json::Value::as_str)
-            .is_some_and(|s| s.eq_ignore_ascii_case("running"))
-    }))
-}

package/crates/team-agent/src/packaging/migrate.rs

@@ -1,3 +1,4 @@
+//!
 //! `doctor` 自检入口:把 step 3 schema_diagnosis +(placeholder)step 11/12 gate 结论归一成
 //! typed [`DoctorStatus`]。
 
@@ -6,6 +7,7 @@ use super::types::{
 };
 use crate::db::migration::schema_diagnosis_workspace;
 
+///
 /// `team-agent doctor`(`commands.py:218`)。packaging 的自检入口:把 step 3 schema_diagnosis +
 /// (placeholder)step 11 comms / step 12 orphan gate 结论归一成 typed [`DoctorStatus`]。
 /// **§84**:只调 step 3/11/12 的 trait 入口,注入 mock 时 provider 调用计数 = 0;绝不触发 prompt/token。

package/crates/team-agent/src/packaging/mod.rs

@@ -1,3 +1,4 @@
+//!
 //! step 15 · packaging — release 产物布局 / 薄 self-install / migration·repair SKELETON (ROUND-0).
 //!
 //! Card: `docs/phase0/subsystems/15-packaging.md`.

package/crates/team-agent/src/packaging/repair.rs

@@ -1,3 +1,4 @@
+//!
 //! schema migration / repair 转调:`doctor --fix-schema` → step 3 `fix_schema_layout`,包成
 //! [`MigrationOutcome`]。
 
@@ -7,6 +8,7 @@ use super::types::{MigrationOutcome, PackagingError};
 use crate::db::migration::{fix_schema_layout, FixResult};
 use crate::db::schema::SCHEMA_VERSION;
 
+///
 /// `team-agent doctor --fix-schema`(`commands.py:239`)→ 转调 step 3 [`fix_schema_layout`]。
 /// migration·repair 实体在 step 3;packaging 仅转调 + 包成 [`MigrationOutcome`]。
 /// // REAL-MACHINE-E2E:破坏性 rebuild(撞锁/备份/rollback)的真路径需真机验;转调逻辑可单测。

package/crates/team-agent/src/packaging/tests.rs

@@ -1,3 +1,4 @@
+//!
 #![allow(clippy::unwrap_used, clippy::expect_used, clippy::panic)]
 #![allow(non_snake_case)]
 use super::*;
@@ -505,17 +506,21 @@ fn repair_schema_active_lock_is_blocked_no_backup() {
 
 #[test]
 fn diagnose_path_when_bin_on_path_reports_on_path() {
-    // bin_dir 在当前 PATH → OnPath{bin_dir}。构造:把 bin_dir 临时塞进 PATH。
-    // 取 PATH 首个真实条目作为 bin_dir,保证「在 PATH 上」。
+    // bin_dir 在当前 PATH → install report 的 path_hint 是 OnPath{bin_dir}。
     let path_var = std::env::var("PATH").unwrap_or_default();
-    let first = path_var
+    let bin = path_var
         .split(':')
-        .find(|p| !p.is_empty())
-        .expect("PATH has at least one entry");
-    let bin = BinDir(PathBuf::from(first));
-    let hint = diagnose_path(&bin).expect("diagnose on-path bin");
+        .filter(|p| !p.is_empty())
+        .map(PathBuf::from)
+        .find(|p| p.ends_with("bin"))
+        .expect("PATH has at least one .../bin entry");
+    let mut opts = install_opts(SkillTarget::Codex);
+    opts.prefix = Prefix(bin.parent().expect("bin dir has parent").to_path_buf());
+    let hint = install(&opts)
+        .expect("install reports on-path bin")
+        .path_hint;
     match hint {
-        PathHint::OnPath { bin_dir } => assert_eq!(bin_dir, PathBuf::from(first)),
+        PathHint::OnPath { bin_dir } => assert_eq!(bin_dir, bin),
         PathHint::NotOnPath { .. } => panic!("PATH entry should report OnPath"),
     }
 }
@@ -523,15 +528,20 @@ fn diagnose_path_when_bin_on_path_reports_on_path() {
 #[test]
 fn diagnose_path_not_on_path_npmrc_prefix_is_none_no_npm() {
     // Rust 版无 npm 路径 → npmrc_prefix == None (skeleton:257).
-    // 用一个绝不在 PATH 的目录。
-    let bin = BinDir(PathBuf::from("/zzz-definitely-not-on-path-9f3a"));
-    let hint = diagnose_path(&bin).expect("diagnose off-path bin");
+    // 用一个绝不在 PATH 的安装前缀,经当前公开 install 路径取得诊断。
+    let prefix = PathBuf::from("/zzz-definitely-not-on-path-9f3a");
+    let bin = prefix.join("bin");
+    let mut opts = install_opts(SkillTarget::Codex);
+    opts.prefix = Prefix(prefix);
+    let hint = install(&opts)
+        .expect("install reports off-path bin")
+        .path_hint;
     match hint {
         PathHint::NotOnPath {
             bin_dir,
             diagnostic,
         } => {
-            assert_eq!(bin_dir, PathBuf::from("/zzz-definitely-not-on-path-9f3a"));
+            assert_eq!(bin_dir, bin);
             // Rust 无 npm → 绝不重新引入 .npmrc 解析.
             assert_eq!(diagnostic.npmrc_prefix, None);
             // path_entries == 当前 PATH 条目数 (bincheck.mjs:43).
@@ -649,136 +659,8 @@ fn install_skill_real_copy_removes_stale_files() {
 }
 
 // ───────────────────────────────────────────────────────────────────────
-// uninstall — install.mjs:109-130。安全护栏:
-//   - 默认 purge_runtime=false → purged_runtime=false,不删 workspace/.team.
-//   - purge_runtime=true 且检测有 team 在跑 → 拒绝:purge_refused_team_running=true
-//     (或返 PurgeRefusedTeamRunning err — 取实现纪律,这里钉「不真删」)。
-// 真删 / team-running 判定 #[ignore]。
-// ───────────────────────────────────────────────────────────────────────
-
-/// TEST-SUPPORT seed helper: build a workspace whose state.json projects a RUNNING team
-/// (status "running" + a live coordinator pid). The team-running guard reads this projection.
-/// Real impl (pure scaffolding, not a production fn) so the NEW-CONTRACT guard test has a
-/// concrete fixture instead of a bare nonexistent path.
-fn seed_workspace_with_running_team(tag: &str) -> PathBuf {
-    let ws = std::env::temp_dir().join(format!("ta-ws-running-{}-{}", std::process::id(), tag));
-    let team_dir = ws.join(".team");
-    std::fs::create_dir_all(&team_dir).expect("seed .team dir");
-    // state.json shape mirrors step-5 state projection: a team marked running.
-    let state = serde_json::json!({
-        "teams": {
-            "demo": { "status": "running", "coordinator_pid": std::process::id() }
-        }
-    });
-    std::fs::write(
-        team_dir.join("state.json"),
-        serde_json::to_vec_pretty(&state).unwrap(),
-    )
-    .expect("seed state.json");
-    ws
-}
-
-/// TEST-SUPPORT seed helper: an idle workspace (state.json present, no running team).
-fn seed_workspace_idle(tag: &str) -> PathBuf {
-    let ws = std::env::temp_dir().join(format!("ta-ws-idle-{}-{}", std::process::id(), tag));
-    let team_dir = ws.join(".team");
-    std::fs::create_dir_all(&team_dir).expect("seed .team dir");
-    std::fs::write(
-        team_dir.join("state.json"),
-        serde_json::to_vec_pretty(&serde_json::json!({ "teams": {} })).unwrap(),
-    )
-    .expect("seed state.json");
-    ws
-}
-
-#[test]
-#[serial_test::serial(env)]
-fn uninstall_default_does_not_purge_runtime() {
-    // PORT-GOLDEN (install.mjs:127-129): default (no --purge-runtime) leaves runtime; the
-    // "runtime directories are left ... for rollback" branch. Default must NOT purge
-    // workspace/.team. With workspace seeded, default must STILL leave it untouched on disk.
-    // Isolate HOME: uninstall() now removes ~/.codex|.claude skill dirs (reads HOME). Without an
-    // isolated empty HOME this test would (a) delete the real user's skill dir and (b) race
-    // p2_uninstall_removes_both_skill_dirs' HOME mutation → remove_dir_all NotFound flake under
-    // parallel cargo. Shared ENV_LOCK_PKG serializes the two HOME-touching uninstall tests.
-    let _g = ENV_LOCK_PKG.lock().unwrap_or_else(|p| p.into_inner());
-    let home = std::env::temp_dir().join(format!("ta-uninst-default-home-{}", std::process::id()));
-    std::fs::create_dir_all(&home).unwrap();
-    let _h = HomeGuard::set(&home);
-    let ws = seed_workspace_idle("default-nopurge");
-    let opts = UninstallOptions {
-        prefix: Prefix(std::env::temp_dir().join(format!("ta-uninst-{}", std::process::id()))),
-        purge_runtime: false,
-        workspace: Some(ws.clone()),
-    };
-    let outcome = uninstall(&opts).expect("default uninstall");
-    assert!(!outcome.purged_runtime, "default must NOT purge runtime");
-    assert!(
-        !outcome.purge_refused_team_running,
-        "no purge requested → no refusal"
-    );
-    // SAFETY INVARIANT (card §uninstall 绝不默认删 workspace/.team): the seeded workspace
-    // .team must still exist after a default uninstall.
-    assert!(
-        ws.join(".team").join("state.json").exists(),
-        "default uninstall must NEVER delete workspace/.team"
-    );
-}
-
-#[test]
-#[ignore = "NEW-CONTRACT (Rust hardening, NOT a Python port-golden): real team-running guard \
-            needs live state projection (step 5). Python install.mjs:123-128 has NO such guard \
-            — it purges unconditionally on --purge-runtime. Confirmed with gate w59ds828k: this \
-            is intentional hardening backed by card §uninstall prose 'pass --purge-runtime only \
-            when no teams are running.' Marked NEW-CONTRACT, not PORT."]
-fn uninstall_purge_refused_when_team_running_NEW_CONTRACT() {
-    // NEW-CONTRACT safety guard: purge_runtime=true but workspace projects a RUNNING team →
-    // REFUSE purge (purge_refused_team_running=true OR PurgeRefusedTeamRunning err). The
-    // seeded workspace .team MUST survive regardless. This behavior is NOT in install.mjs.
-    let ws = seed_workspace_with_running_team("guard");
-    let opts = UninstallOptions {
-        prefix: Prefix(std::env::temp_dir().join("ta-uninst-guard")),
-        purge_runtime: true,
-        workspace: Some(ws.clone()),
-    };
-    match uninstall(&opts) {
-        Ok(o) => {
-            assert!(!o.purged_runtime, "must not purge while team running");
-            assert!(o.purge_refused_team_running, "must set refusal flag");
-        }
-        Err(PackagingError::PurgeRefusedTeamRunning(refused_ws)) => {
-            assert_eq!(refused_ws, ws, "refusal must name the running workspace");
-        }
-        Err(other) => panic!("expected refusal, got {other:?}"),
-    }
-    // Hard invariant: refused purge must leave the workspace fully intact.
-    assert!(
-        ws.join(".team").join("state.json").exists(),
-        "refused purge must NEVER delete workspace/.team"
-    );
-}
-
-#[test]
-#[ignore = "REAL-MACHINE-E2E: PORT-GOLDEN — --purge-runtime with NO running team really removes \
-            the runtime root (install.mjs:123-126 unconditional rmSync). File-system side effect."]
-fn uninstall_purge_runtime_idle_workspace_purges_PORT_GOLDEN() {
-    // PORT-GOLDEN (install.mjs:123-126): --purge-runtime DOES purge when no team is running.
-    // This is the faithful Python behavior (the guard above is the only Rust addition).
-    let ws = seed_workspace_idle("port-purge");
-    let opts = UninstallOptions {
-        prefix: Prefix(std::env::temp_dir().join("ta-uninst-port-purge")),
-        purge_runtime: true,
-        workspace: Some(ws.clone()),
-    };
-    let outcome = uninstall(&opts).expect("purge on idle workspace");
-    assert!(outcome.purged_runtime, "idle + --purge-runtime → purged");
-    assert!(!outcome.purge_refused_team_running, "no team → no refusal");
-}
-
-// ───────────────────────────────────────────────────────────────────────
-// install / update — install.mjs:48-95。
+// install — install.mjs:48-95。
 //   - install 首装:InstallReport.replace == None (无二进制替换).
-//   - update:replace == Some(..) (有原子替换;失败回滚到 .previous,bug-084 同源).
 //   - installer 默认 skill_target = All (install.mjs:74 `--target all`).
 // 全副作用 #[ignore] (写 bin / 拷 skill / 探 PATH / 跑 doctor) — clean-install E2E.
 // ───────────────────────────────────────────────────────────────────────
@@ -804,19 +686,6 @@ fn install_first_time_has_no_binary_replace() {
     assert_eq!(report.version, Version::current());
 }
 
-#[test]
-#[ignore = "REAL-MACHINE-E2E: atomic binary replace + .previous backup + rollback (bug-084 同源)"]
-fn update_performs_atomic_binary_replace() {
-    // install.mjs:60-66 — update 有 dest→backup + tmp→dest 原子替换.
-    let opts = install_opts(SkillTarget::All);
-    let report = update(&opts).expect("update");
-    match report.replace {
-        Some(AtomicReplaceOutcome::Replaced { .. })
-        | Some(AtomicReplaceOutcome::ReplacedCrossDevice { .. }) => {}
-        other => panic!("update must replace binary, got {other:?}"),
-    }
-}
-
 #[test]
 fn atomic_replace_outcome_serde_tag_outcome() {
     // #[serde(tag = "outcome")] — RolledBack carries restored_from + error.
@@ -846,7 +715,7 @@ fn install_skill_dry_run_is_pure_no_provider_state() {
     // hold the same `ENV_LOCK_PKG` + `HomeGuard::set` guards; without
     // matching guards here, two dry-run runs can observe HOME after
     // a real-copy test swapped it, producing spurious diffs. Same
-    // env critical section as install/uninstall.
+    // env critical section as the other HOME-mutating install tests.
     let _g = ENV_LOCK_PKG.lock().unwrap_or_else(|p| p.into_inner());
     let home = std::env::temp_dir().join(format!(
         "ta-0543-pkg-dry-{}-{}",
@@ -877,8 +746,11 @@ fn install_skill_dry_run_is_pure_no_provider_state() {
 fn diagnose_path_empty_path_has_zero_entries() {
     // bincheck.mjs:43 — searchPath ? split.length : 0;空 PATH → 0 entries.
     // (真改 process env PATH 影响并行测试,故 ignore;实现层应支持注入 PATH.)
-    let bin = BinDir(PathBuf::from("/anything"));
-    let hint = diagnose_path(&bin).expect("diagnose empty path");
+    let mut opts = install_opts(SkillTarget::Codex);
+    opts.prefix = Prefix(PathBuf::from("/anything"));
+    let hint = install(&opts)
+        .expect("install reports empty PATH")
+        .path_hint;
     if let PathHint::NotOnPath { diagnostic, .. } = hint {
         assert_eq!(diagnostic.path_entries, 0);
     } else {
@@ -948,64 +820,3 @@ fn install_skill_all_real_copies_to_three_provider_locations() {
         );
     }
 }
-
-// P1 — update() must perform a REAL atomic replace (rename dest→.previous), not fabricate
-// a Replaced outcome whose backup file never exists (install.mjs:60-66; bug-084).
-#[test]
-fn p2_update_creates_real_atomic_replace_backup() {
-    let base = std::env::temp_dir().join(format!("ta-p2-update-{}", std::process::id()));
-    let prefix = base.join("prefix");
-    std::fs::create_dir_all(prefix.join("bin")).unwrap();
-    let dest = prefix.join("bin").join("team-agent");
-    std::fs::write(&dest, b"OLD BINARY").unwrap(); // pre-existing bin to back up
-    let self_bin = base.join("team-agent-new");
-    std::fs::write(&self_bin, b"NEW BINARY").unwrap();
-
-    let opts = InstallOptions {
-        prefix: Prefix(prefix.clone()),
-        self_binary: self_bin,
-        skill_target: SkillTarget::All,
-    };
-    let report = update(&opts).unwrap();
-    let backup = match report.replace {
-        Some(AtomicReplaceOutcome::Replaced { backup }) => backup,
-        other => panic!("update must report a Replaced atomic replace, got {other:?}"),
-    };
-    assert!(
-        backup.exists(),
-        "update() must actually rename dest→.previous; the claimed backup file must exist on disk"
-    );
-}
-
-// P1 — uninstall() must remove ALL provider skill dirs (~/.codex|.claude|.copilot/skills/team-agent)
-// and record them (install.mjs:115-122 + E9 copilot). Table-driven over SkillTarget::SINGLE_TARGETS.
-#[test]
-#[serial_test::serial(env)]
-fn p2_uninstall_removes_all_provider_skill_dirs() {
-    let _g = ENV_LOCK_PKG.lock().unwrap_or_else(|p| p.into_inner());
-    let base = std::env::temp_dir().join(format!("ta-p2-uninst-{}", std::process::id()));
-    let home = base.join("home");
-    let codex = home.join(".codex").join("skills").join("team-agent");
-    let claude = home.join(".claude").join("skills").join("team-agent");
-    let copilot = home.join(".copilot").join("skills").join("team-agent");
-    for d in [&codex, &claude, &copilot] {
-        std::fs::create_dir_all(d).unwrap();
-        std::fs::write(d.join("SKILL.md"), b"x").unwrap();
-    }
-    let _h = HomeGuard::set(&home);
-
-    let opts = UninstallOptions {
-        prefix: Prefix(base.join("prefix")),
-        purge_runtime: false,
-        workspace: None,
-    };
-    let out = uninstall(&opts).unwrap();
-    assert_eq!(
-        out.removed_skill_dirs.len(),
-        3,
-        "uninstall must remove ~/.codex, ~/.claude AND ~/.copilot skill dirs"
-    );
-    assert!(!codex.exists(), "~/.codex skill dir must be removed");
-    assert!(!claude.exists(), "~/.claude skill dir must be removed");
-    assert!(!copilot.exists(), "~/.copilot skill dir must be removed");
-}

package/crates/team-agent/src/packaging/types.rs

@@ -1,3 +1,4 @@
+//!
 //! packaging 共享类型 —— §19 散字符串 → enum / §3 路径·版本 newtype / typed Outcome·Report /
 //! entry fn 入参 / PackagingError / 平台能力声明(纯函数 `platform_support`)。
 
@@ -21,18 +22,6 @@ use crate::db::DbError;
 // §19 散字符串态 → 穷尽 enum
 // ===========================================================================
 
-/// installer 子命令(`install.mjs:20-30` argv 散字符串 `install/update/doctor/uninstall/help`)。
-/// `unknown command` 走 exit 2 —— Rust 侧由 clap(step 14)在解析层挡掉,此 enum 是穷尽 match 无 fallthrough。
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
-#[serde(rename_all = "snake_case")]
-pub enum InstallerCommand {
-    Install,
-    Update,
-    Doctor,
-    Uninstall,
-    Help,
-}
-
 /// skill 安装目标(`cli/parser.py:443` choices `codex/claude/all`)。`_skill_dest_dir` 据此选
 /// `~/.codex` vs `~/.claude`(`commands.py:467-472`)。**散字符串必须 enum**,与 step 8 Provider 对齐。
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
@@ -57,6 +46,7 @@ impl SkillTarget {
         SkillTarget::Copilot,
     ];
 
+    ///
     /// 单目标 → 对应 provider(`All` 无单一 provider → `None`)。与 [`Provider`] 对齐,防散字符串再生。
     pub fn provider(self) -> Option<Provider> {
         match self {
@@ -67,6 +57,7 @@ impl SkillTarget {
         }
     }
 
+    ///
     /// `_skill_dest_dir`:`~/.codex|.claude|.copilot/skills/team-agent`(`All` fan-out 全集,非单 dir → None)。
     pub fn dest_dir(self, home: &Path) -> Option<SkillDestDir> {
         match self {
@@ -128,6 +119,7 @@ pub enum BlockerSource {
 pub struct Version(pub String);
 
 impl Version {
+    ///
     /// 编译期注入的唯一版本(`env!("CARGO_PKG_VERSION")`)。
     pub fn current() -> Self {
         Self(env!("CARGO_PKG_VERSION").to_string())
@@ -161,7 +153,7 @@ pub struct SkillDestDir(pub PathBuf);
 /// 此 enum 只用于「release 矩阵覆盖面」声明。
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
 #[serde(rename_all = "snake_case")]
-pub enum ReleaseTarget {
+pub(super) enum ReleaseTarget {
     MacosAarch64,
     MacosX8664,
     LinuxX8664,
@@ -181,7 +173,7 @@ pub enum ReleaseTarget {
 /// Truth source: `.team/artifacts/0.5.x-windows-portability-cr-verdict.md` §C-1。
 #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
 #[serde(rename_all = "snake_case", tag = "level")]
-pub enum PlatformSupport {
+pub(super) enum PlatformSupport {
     /// 原生一等(macOS/Linux tmux)。
     Native,
     /// 需 WSL + tmux backend(显式标要求,不假装原生)。
@@ -196,8 +188,9 @@ pub enum PlatformSupport {
     Unsupported { reason: String },
 }
 
+///
 /// release 矩阵中某目标平台的支持等级(§8 如实声明;能力门归 step 9)。纯函数。
-pub fn platform_support(target: ReleaseTarget) -> PlatformSupport {
+pub(super) fn platform_support(target: ReleaseTarget) -> PlatformSupport {
     match target {
         ReleaseTarget::MacosAarch64
         | ReleaseTarget::MacosX8664