@team-agent/installer 0.5.60 → 0.5.62

package/skills/team-agent/command-coverage.json

@@ -0,0 +1,379 @@
+{
+  "schema_version": "team-agent-skill-command-coverage-v3",
+  "commands": [
+    {
+      "command": "team-agent add-agent <agent> --role-file <file>",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:lifecycle",
+      "plan": "Execute the documented argv in an isolated add-agent fixture and bind assertions to the CLI result and created roster/window."
+    },
+    {
+      "command": "team-agent add-agent reviewer --role-file .team/current/agents/reviewer.md --workspace .",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:lifecycle",
+      "plan": "Execute the exact reviewer argv in an isolated fixture and assert the reviewer state, role provenance, and worker window."
+    },
+    {
+      "command": "team-agent approvals",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:approvals",
+      "plan": "Execute the default approvals view and bind assertions to its exit and approval-list output."
+    },
+    {
+      "command": "team-agent approvals <agent_id>",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:approvals",
+      "plan": "Execute a representative agent_id filter and assert the bound CLI result contains only that agent's approvals."
+    },
+    {
+      "command": "team-agent approvals [coder]",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:approvals",
+      "plan": "Execute the literal coder representative and assert the bound CLI result's target-filter behavior."
+    },
+    {
+      "command": "team-agent attach-leader",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:leader-channel",
+      "plan": "Execute in a hermetic caller-pane fixture and bind assertions to either the persisted receiver binding or the precise zero-write refusal."
+    },
+    {
+      "command": "team-agent claim-leader",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:leader-channel",
+      "plan": "Execute in a hermetic leader fixture and bind assertions to owner/receiver persistence or a precise zero-write refusal."
+    },
+    {
+      "command": "team-agent claude",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:provider-launcher",
+      "plan": "Use a per-call hermetic PATH shim for claude, then assert the shim's exact provider argv log and the bound CLI exit/output."
+    },
+    {
+      "command": "team-agent clone-agent <source> --as <new>",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:provider-lifecycle",
+      "plan": "Use an isolated provider/session fixture or authorized subscription gate and bind assertions to clone success or its exact rollback refusal."
+    },
+    {
+      "command": "team-agent codex",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:provider-launcher",
+      "plan": "Use a per-call hermetic PATH shim for codex, then assert the shim's exact provider argv log and the bound CLI exit/output."
+    },
+    {
+      "command": "team-agent codex --dangerously-bypass-approvals-and-sandbox",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:provider-launcher",
+      "plan": "Use a per-call hermetic codex PATH shim and assert the exact dangerous flag argv log plus the bound CLI exit/output without invoking a real provider."
+    },
+    {
+      "command": "team-agent collect",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:results",
+      "plan": "Execute the exact human collect argv after a worker result and bind assertions to presentation and consumption of that same result."
+    },
+    {
+      "command": "team-agent doctor",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:diagnostics",
+      "plan": "Execute the exact human doctor argv and bind assertions to its exit and key diagnostic checks."
+    },
+    {
+      "command": "team-agent fork-agent <source> --as <new>",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:provider-lifecycle",
+      "plan": "Use an isolated provider/session fixture or authorized subscription gate and bind assertions to fork success or its exact rollback refusal."
+    },
+    {
+      "command": "team-agent inbox",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:messaging",
+      "plan": "Execute the exact default inbox argv and bind assertions to its selected recipient and message or empty-state output."
+    },
+    {
+      "command": "team-agent inbox coder",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:messaging",
+      "plan": "Execute the exact coder inbox argv and bind assertions to recipient filtering and delivery fields."
+    },
+    {
+      "command": "team-agent profile doctor <name> --workspace . --json",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:profiles",
+      "plan": "Execute a representative local profile doctor argv and bind assertions to its JSON validation result and write isolation."
+    },
+    {
+      "command": "team-agent profile init <name> --auth-mode subscription --workspace .",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:profiles",
+      "plan": "Execute a representative local profile init and assert the bound result plus persisted profile identity and subscription auth mode."
+    },
+    {
+      "command": "team-agent profile init claude-default --auth-mode subscription --workspace .",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:profiles",
+      "plan": "Execute the exact local init argv and assert the bound result plus claude-default subscription profile fields without launching Claude."
+    },
+    {
+      "command": "team-agent profile init codex-default --auth-mode subscription --workspace .",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:profiles",
+      "plan": "Execute the exact local init argv and assert the bound result plus codex-default subscription profile fields without launching Codex."
+    },
+    {
+      "command": "team-agent profile init deepseek --auth-mode compatible_api --workspace .",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:profiles",
+      "plan": "Execute the exact local init argv and assert the bound result plus compatible_api profile schema without network access."
+    },
+    {
+      "command": "team-agent profile show <name> --workspace . --json",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:profiles",
+      "plan": "Show a profile created in the same fixture and bind field-by-field round-trip assertions to the CLI result."
+    },
+    {
+      "command": "team-agent profile show deepseek --workspace . --json",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:profiles",
+      "plan": "Show the isolated deepseek profile and bind exact identity/auth-mode assertions to the CLI result."
+    },
+    {
+      "command": "team-agent quick-start",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:lifecycle",
+      "plan": "Execute the exact argv from a hermetic project root and bind assertions to canonical runtime, team, and session identity."
+    },
+    {
+      "command": "team-agent quick-start ./roles --team-id alpha",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:lifecycle",
+      "plan": "Execute against an isolated legacy roles fixture and bind assertions to the alpha team identity and unique runtime."
+    },
+    {
+      "command": "team-agent quick-start .team/alpha",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:lifecycle",
+      "plan": "Execute against an isolated team directory and bind assertions proving the directory literal cannot split canonical team identity."
+    },
+    {
+      "command": "team-agent quick-start .team/current",
+      "bucket": "covered",
+      "cases": ["lnch_001_quick_start_basic"],
+      "evidence": {
+        "case": "lnch_001_quick_start_basic",
+        "source_file": "crates/team-agent/tests/e2e/cases/lnch_001_quick_start_basic.rs",
+        "invocation": {
+          "runner": "run_ta",
+          "line": 30,
+          "documented_argv": ["team-agent", "quick-start", ".team/current"],
+          "literal_argv": ["quick-start", ".team/current"]
+        },
+        "binding": {
+          "name": "out",
+          "line": 30
+        },
+        "assertion": {
+          "macro_name": "assert",
+          "line": 41,
+          "operand": "condition",
+          "behavior_fact": "stdout",
+          "failure_marker": "quick-start did not launch the team"
+        },
+        "negative_twin": {
+          "env_key": "TEAM_AGENT_COVERAGE_NEGATIVE_TWIN",
+          "env_value": "quick-start-status",
+          "operation": "remove_text_literal",
+          "remove_literal": "status: leader_receiver_unbound",
+          "replacement": "negative_twin_removed"
+        }
+      }
+    },
+    {
+      "command": "team-agent quick-start <dir>",
+      "bucket": "covered",
+      "cases": ["lnch_001_quick_start_basic"],
+      "evidence": {
+        "case": "lnch_001_quick_start_basic",
+        "source_file": "crates/team-agent/tests/e2e/cases/lnch_001_quick_start_basic.rs",
+        "invocation": {
+          "runner": "run_ta",
+          "line": 30,
+          "documented_argv": ["team-agent", "quick-start", "<dir>"],
+          "literal_argv": ["quick-start", ".team/current"]
+        },
+        "binding": {
+          "name": "out",
+          "line": 30
+        },
+        "assertion": {
+          "macro_name": "assert",
+          "line": 69,
+          "operand": "condition",
+          "behavior_fact": "stdout",
+          "failure_marker": "public output must expose the canonical session name"
+        },
+        "negative_twin": {
+          "env_key": "TEAM_AGENT_COVERAGE_NEGATIVE_TWIN",
+          "env_value": "quick-start-session-name",
+          "operation": "remove_text_literal",
+          "remove_literal": "session_name: ",
+          "replacement": "negative_twin_removed"
+        }
+      }
+    },
+    {
+      "command": "team-agent remove-agent <agent> --workspace . --confirm",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:lifecycle",
+      "plan": "Execute the exact argv in a dedicated hermetic lifecycle fixture and bind assertions to roster/window removal and sibling preservation."
+    },
+    {
+      "command": "team-agent reset-agent <agent> --discard-session",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:lifecycle",
+      "plan": "Execute the exact argv in a dedicated hermetic fixture and bind assertions to session discard and worker state."
+    },
+    {
+      "command": "team-agent restart",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:restart",
+      "plan": "Execute from an isolated single-team cwd and bind assertions to the restarted session and roster."
+    },
+    {
+      "command": "team-agent restart .",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:restart",
+      "plan": "Execute the exact argv including final dot and bind assertions to canonical team selection and restart outcome."
+    },
+    {
+      "command": "team-agent restart . --allow-fresh",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:restart",
+      "plan": "Execute in a dedicated hermetic rebuild fixture and bind assertions to the new session, agent state, and allow-fresh audit."
+    },
+    {
+      "command": "team-agent restart . --team <session_name_or_team_name>",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:restart",
+      "plan": "Execute a representative team selector and bind assertions to selected-team restart and sibling preservation."
+    },
+    {
+      "command": "team-agent send --task task_initial \"Start\"",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:messaging",
+      "plan": "Execute the exact task argv in an isolated task fixture and bind assertions to task/message attribution and durable row state."
+    },
+    {
+      "command": "team-agent send --watch-result",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:messaging",
+      "plan": "Execute the exact incomplete argv and bind assertions to its nonzero usage error and zero message/result writes."
+    },
+    {
+      "command": "team-agent send --watch-result coder \"Do the bounded task\"",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:messaging",
+      "plan": "Execute the exact argv in an isolated coder fixture and bind assertions to blocked-before-watch or the same-message result closure."
+    },
+    {
+      "command": "team-agent send reviewer \"Review this change\"",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:messaging",
+      "plan": "Execute the exact argv against a fake reviewer and bind recipient, delivered, original result, and collect assertions."
+    },
+    {
+      "command": "team-agent shutdown --workspace . --keep-logs",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:shutdown",
+      "plan": "Execute the exact argv only in a dedicated hermetic fixture and bind assertions to scoped session removal, kept logs, and sibling preservation."
+    },
+    {
+      "command": "team-agent start-agent <agent>",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:lifecycle",
+      "plan": "Execute a representative exact argv for a stopped fake agent and bind assertions to status, pane, and window creation."
+    },
+    {
+      "command": "team-agent start-agent <agent_id> --workspace .",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:lifecycle",
+      "plan": "Execute a representative exact workspace-dot argv and bind assertions to the same agent's lifecycle result."
+    },
+    {
+      "command": "team-agent start-agent coder --workspace .",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:lifecycle",
+      "plan": "Execute in an isolated coder fixture and bind assertions that the selected coder, not a sibling namesake, starts."
+    },
+    {
+      "command": "team-agent status",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:status",
+      "plan": "Execute the exact human status argv and bind assertions to selected team and agent output."
+    },
+    {
+      "command": "team-agent status --detail --json",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:status",
+      "plan": "Execute the exact argv and bind assertions to detail-only coordinator, readiness, and tmux fields."
+    },
+    {
+      "command": "team-agent status --json",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:status",
+      "plan": "Execute the exact argv and bind assertions to the compact status schema and absence of detail-only fields."
+    },
+    {
+      "command": "team-agent status coder",
+      "bucket": "declared_gap",
+      "covered": false,
+      "owner": "runtime-owner:status",
+      "plan": "Execute the exact coder status argv and bind assertions to coder-only presentation without sibling leakage."
+    }
+  ]
+}

package/crates/team-agent/src/leader/inject.rs

@@ -1,33 +0,0 @@
-//! leader::inject — `push_idle_reminder` no-op shim.
-//!
-//! #236 nag_removal (N35): the framework no longer auto-pings the leader pane based on
-//! idle-classification inferences. `push_idle_reminder` used to emit the
-//! `idle_takeover.reminder` event AND route a "leader takeover may be appropriate"
-//! message through the N31/N32 funnel; both were nag outputs synthesized from
-//! time/state, not from a real delivery obligation. They are deleted by design —
-//! ownership / handover changes only via explicit `claim-leader` / `takeover` commands.
-//!
-//! The function signature is preserved (callers in coordinator/tick.rs and lifecycle
-//! tests still resolve) but the body is a strict no-op: no event, no primitive call,
-//! no state mutation. The `_` discards keep clippy quiet and document that the
-//! arguments are intentionally ignored under N35.
-
-use std::path::Path;
-
-use serde_json::Value;
-
-use super::{LeaderError, TakeoverReminderResult};
-
-/// #236 nag_removal: was the take-over reminder injector; now a true no-op. Delivery
-/// primitives (`report_result` / `send_to_leader` / N31/N32 funnel / `request_human` /
-/// broadcast-leader) continue to flow through their own callsites — only the
-/// time/state-inferred nag output that lived in this helper is gone.
-pub fn push_idle_reminder(
-    workspace: &Path,
-    state: &Value,
-    event_log: &crate::event_log::EventLog,
-    result: &TakeoverReminderResult,
-) -> Result<(), LeaderError> {
-    let _ = (workspace, state, event_log, result);
-    Ok(())
-}

package/crates/team-agent/src/provider/command.rs

@@ -1,80 +0,0 @@
-//! unit-7 (Stage 3) — provider command-assembly boundary.
-//!
-//! The provider/adapter.rs monolith mixes three concerns:
-//!   1. The `ProviderAdapter` TRAIT and facade dispatch (the public API).
-//!   2. Per-provider COMMAND ASSEMBLY (argv plan, base/resume flags,
-//!      --session-id injection — adapter.rs:409-508 region).
-//!   3. SESSION SCANNING (capture polling + transcript scanning —
-//!      adapter.rs:511-546, 969-1078).
-//!
-//! This module CREATES the dedicated home for #2 so future work can
-//! migrate command-assembly fns here in small, behavior-neutral commits.
-//! Today it only carries the documented intent and a small typed helper —
-//! the bulk of the assembly fns are still in adapter.rs and reachable
-//! through the existing pub(crate) surface.
-//!
-//! Why incremental: every command-assembly fn touches multiple internal
-//! constants (`--session-id`, `--resume`, MCP-config-path conventions) and
-//! per-provider quirks. Moving them blindly is high-risk. The boundary
-//! exists so the next commit (or any contributor) has a documented target
-//! for relocations.
-
-use crate::provider::Provider;
-
-/// Lightweight tag for command-plan branches in the existing adapter
-/// (`Base` vs `Resume`). Distinct type so command-assembly code reads
-/// clearly even when it lives next to adapter dispatch.
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
-pub enum CommandPlanKind {
-    /// Initial spawn — `--session-id <uuid>` predetermined.
-    Base,
-    /// Resume an existing session — `--resume <sid>`, no fresh
-    /// `--session-id` injected.
-    Resume,
-}
-
-/// Returns true when the provider's command plan honors `--session-id`
-/// for fresh spawns. Mirrors the existing adapter logic but lives next to
-/// where future command-assembly fns will land.
-pub fn honors_session_id_for_base_spawn(provider: Provider) -> bool {
-    matches!(
-        provider,
-        Provider::Claude | Provider::ClaudeCode | Provider::Copilot
-    )
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn fake_provider_does_not_honor_session_id() {
-        assert!(!honors_session_id_for_base_spawn(Provider::Fake));
-    }
-
-    #[test]
-    fn provider_matrix_for_base_spawn_session_id_support() {
-        let cases = [
-            (Provider::Claude, true),
-            (Provider::ClaudeCode, true),
-            (Provider::Copilot, true),
-            (Provider::Codex, false),
-            (Provider::GeminiCli, false),
-            (Provider::Fake, false),
-        ];
-        for (provider, expected) in cases {
-            assert_eq!(
-                honors_session_id_for_base_spawn(provider),
-                expected,
-                "{provider:?}"
-            );
-        }
-    }
-
-    #[test]
-    fn command_plan_kind_is_copy() {
-        let a = CommandPlanKind::Base;
-        let b = a;
-        assert_eq!(a, b);
-    }
-}