@team-agent/installer 0.5.41 → 0.5.43

package/crates/team-agent/src/cli/tests/base.rs

@@ -1,463 +1,534 @@
 use super::*;
 
-    // RED 契约 lane:argv→run 端到端、五行 summary 字节锁(Gap 18a)、
-    // classify_agent_bucket(unknown≠idle)、cli-error 信封字节锁、leader_launcher_args 解析、
-    // consume_leader_inbox_summary 游标+预算截断、send_target fanout 解析。
-    // Python golden 来源:cli/{parser,commands,helpers}.py @ v0.2.11(439bef8)。
-    // 所有期望值用 `PYTHONPATH=.../src python3` 实跑 Python 实现抓取的字节级 golden。
-    use super::*;
-    use serde_json::json;
-
-    // =========================================================================
-    // provider_args(helpers.py:190-193):values[0]=='--' ? values[1..] : values
-    // =========================================================================
-
-    #[test]
-    fn provider_args_strips_leading_dashdash() {
-        // golden: _provider_args(["--","-x"]) == ["-x"]
-        assert_eq!(provider_args(&["--".into(), "-x".into()]), vec!["-x".to_string()]);
-    }
-
-    #[test]
-    fn provider_args_keeps_when_no_leading_dashdash() {
-        // golden: _provider_args(["-x","-y"]) == ["-x","-y"]
-        assert_eq!(
-            provider_args(&["-x".into(), "-y".into()]),
-            vec!["-x".to_string(), "-y".to_string()]
-        );
-    }
-
-    #[test]
-    fn provider_args_empty_is_empty() {
-        // golden: _provider_args([]) == []
-        assert_eq!(provider_args(&[]), Vec::<String>::new());
-    }
-
-    #[test]
-    fn provider_args_lone_dashdash_yields_empty() {
-        // golden: _provider_args(["--"]) == []  (values[1:] of single-elem list)
-        assert_eq!(provider_args(&["--".into()]), Vec::<String>::new());
-    }
-
-    // =========================================================================
-    // leader_launcher_args(helpers.py:196-226):attach 旗标解析 + 缺值 Err
-    // =========================================================================
-
-    #[test]
-    fn leader_launcher_args_empty_all_default() {
-        // golden: {'provider_args': [], 'attach_existing': False, 'confirm_attach': False, 'attach_session': None}
-        let got = leader_launcher_args(&[]).expect("empty should parse");
-        assert_eq!(got, LeaderLauncherArgs::default());
-        assert!(got.provider_args.is_empty());
-        assert!(!got.attach_existing);
-        assert!(!got.confirm_attach);
-        assert_eq!(got.attach_session, None);
-        assert!(!got.external_leader);
-    }
-
-    #[test]
-    fn leader_launcher_args_attach_and_confirm() {
-        // golden: ["--attach","--confirm"] -> attach_existing=True, confirm_attach=True
-        let got = leader_launcher_args(&["--attach".into(), "--confirm".into()]).unwrap();
-        assert!(got.attach_existing);
-        assert!(got.confirm_attach);
-        assert!(got.provider_args.is_empty());
-        assert_eq!(got.attach_session, None);
-    }
-
-    #[test]
-    fn leader_launcher_args_attach_existing_alias() {
-        // golden: ["--attach-existing"] -> attach_existing=True (alias of --attach)
-        let got = leader_launcher_args(&["--attach-existing".into()]).unwrap();
-        assert!(got.attach_existing);
-        assert!(!got.confirm_attach);
-    }
-
-    #[test]
-    fn leader_launcher_args_external_leader_opt_out() {
-        let got = leader_launcher_args(&[
-            "--external-leader".into(),
-            "--".into(),
-            "--model".into(),
-            "opus".into(),
-        ])
-        .unwrap();
-        assert!(got.external_leader);
-        assert!(!got.attach_existing);
-        assert_eq!(
-            got.provider_args,
-            vec!["--model".to_string(), "opus".to_string()]
-        );
-    }
-
-    #[test]
-    fn leader_launcher_args_external_leader_after_dashdash_errors() {
-        let err = leader_launcher_args(&["--".into(), "--external-leader".into()])
-            .expect_err("Team Agent flags after -- must not be silently passed to provider");
-        assert!(
-            err.to_string()
-                .contains("Team Agent launcher flag --external-leader must appear before --"),
-            "unexpected error: {err}"
-        );
-    }
-
-    #[test]
-    fn leader_launcher_args_attach_session_spaced() {
-        // golden: ["--attach-session","mysess"] -> attach_session="mysess"
-        let got = leader_launcher_args(&["--attach-session".into(), "mysess".into()]).unwrap();
-        assert_eq!(got.attach_session, Some("mysess".to_string()));
-        assert!(!got.attach_existing);
-    }
-
-    #[test]
-    fn leader_launcher_args_attach_session_equals() {
-        // golden: ["--attach-session=mysess"] -> attach_session="mysess"
-        let got = leader_launcher_args(&["--attach-session=mysess".into()]).unwrap();
-        assert_eq!(got.attach_session, Some("mysess".to_string()));
-    }
-
-    #[test]
-    fn leader_launcher_args_dashdash_passthrough_strips_separator() {
-        // ["--attach","--","-x","--provider-confirm"] ->
-        //   provider_args=["-x","--provider-confirm"], attach_existing=True, confirm_attach=False
-        // Known Team Agent launcher flags after `--` are rejected by a separate guard.
-        let got = leader_launcher_args(&[
-            "--attach".into(),
-            "--".into(),
-            "-x".into(),
-            "--provider-confirm".into(),
-        ])
-        .unwrap();
-        assert!(got.attach_existing);
-        assert!(!got.confirm_attach);
-        assert_eq!(
-            got.provider_args,
-            vec!["-x".to_string(), "--provider-confirm".to_string()]
-        );
-    }
-
-    #[test]
-    fn leader_launcher_args_unknown_tokens_collect_as_provider_args() {
-        // golden: ["foo","--attach","bar"] -> provider_args=["foo","bar"], attach_existing=True
-        let got = leader_launcher_args(&["foo".into(), "--attach".into(), "bar".into()]).unwrap();
-        assert_eq!(got.provider_args, vec!["foo".to_string(), "bar".to_string()]);
-        assert!(got.attach_existing);
-    }
-
-    #[test]
-    fn leader_launcher_args_attach_session_missing_value_errors() {
-        // golden: ["--attach-session"] raises RuntimeError("--attach-session requires a tmux session name")
-        let err = leader_launcher_args(&["--attach-session".into()]).unwrap_err();
-        let msg = err.to_string();
-        assert!(
-            msg.contains("--attach-session requires a tmux session name"),
-            "expected exact missing-value message, got: {msg}"
-        );
-    }
-
-    // =========================================================================
-    // send_target(commands.py:181-184):--to split / target / None
-    // =========================================================================
-
-    #[test]
-    fn send_target_fanout_strips_and_filters_empty() {
-        // golden: _send_target(targets="a, b ,,c") == ["a","b","c"]
-        let got = send_target(Some("a, b ,,c"), None);
-        assert_eq!(
-            got,
-            MessageTarget::Fanout(vec!["a".to_string(), "b".to_string(), "c".to_string()])
-        );
-    }
-
-    #[test]
-    fn send_target_single_target() {
-        // golden: _send_target(target="agent_x") == "agent_x"
-        assert_eq!(send_target(None, Some("agent_x")), MessageTarget::Single("agent_x".to_string()));
-    }
-
-    #[test]
-    fn send_target_broadcast_star() {
-        // skeleton contract: bare "*" target -> Broadcast (send.py interprets "*" as全队广播)
-        assert_eq!(send_target(None, Some("*")), MessageTarget::Broadcast);
-    }
-
-    #[test]
-    fn send_target_empty_targets_falls_through_to_target() {
-        // golden: targets="" is falsy in Python -> returns args.target ("fallback")
-        assert_eq!(send_target(Some(""), Some("fallback")), MessageTarget::Single("fallback".to_string()));
-    }
-
-    // =========================================================================
-    // classify_agent_bucket / agent_summary_counts(commands.py:309-330)
-    // bug-071/077/085 铁律:unknown ≠ idle,无匹配态显式落 Unknown
-    // =========================================================================
-
-    #[test]
-    fn classify_failed_takes_priority() {
-        // raw in {failed,error} OR hstatus in {failed,error} -> Failed
-        assert_eq!(classify_agent_bucket("failed", ""), SummaryBucket::Failed);
-        assert_eq!(classify_agent_bucket("error", ""), SummaryBucket::Failed);
-        assert_eq!(classify_agent_bucket("running", "error"), SummaryBucket::Failed);
-    }
-
-    #[test]
-    fn classify_stopped() {
-        // raw in {stopped,done} OR hstatus==done -> Stopped
-        assert_eq!(classify_agent_bucket("stopped", ""), SummaryBucket::Stopped);
-        assert_eq!(classify_agent_bucket("done", ""), SummaryBucket::Stopped);
-        assert_eq!(classify_agent_bucket("running", "done"), SummaryBucket::Stopped);
-    }
-
-    #[test]
-    fn classify_busy() {
-        // raw==busy OR hstatus in {running,working} -> Busy
-        assert_eq!(classify_agent_bucket("busy", ""), SummaryBucket::Busy);
-        assert_eq!(classify_agent_bucket("", "running"), SummaryBucket::Busy);
-        assert_eq!(classify_agent_bucket("", "working"), SummaryBucket::Busy);
-    }
-
-    #[test]
-    fn classify_hstatus_idle_beats_raw_running() {
-        // golden: raw=running, h=idle -> idle  (hstatus==idle branch precedes raw==running branch)
-        assert_eq!(classify_agent_bucket("running", "idle"), SummaryBucket::Idle);
-    }
-
-    #[test]
-    fn classify_pure_running() {
-        // raw==running, no overriding hstatus -> Running
-        assert_eq!(classify_agent_bucket("running", ""), SummaryBucket::Running);
-    }
-
-    #[test]
-    fn classify_blocked_and_unmatched_are_unknown_never_idle() {
-        // bug-071/077/085: blocked/stuck/missing AND any unmatched value -> Unknown, NOT idle.
-        assert_eq!(classify_agent_bucket("blocked", ""), SummaryBucket::Unknown);
-        assert_eq!(classify_agent_bucket("stuck", ""), SummaryBucket::Unknown);
-        assert_eq!(classify_agent_bucket("", "missing"), SummaryBucket::Unknown);
-        assert_eq!(classify_agent_bucket("weird_value", ""), SummaryBucket::Unknown);
-        assert_eq!(classify_agent_bucket("", ""), SummaryBucket::Unknown);
-    }
-
-    #[test]
-    fn agent_summary_counts_mixed_golden() {
-        // golden (empty health): a1 running->Running; a2 busy->Busy; a3 failed->Failed;
-        //   a4 stopped->Stopped; a5 blocked->Unknown; a6 ""->Unknown; a7 weird->Unknown.
-        //   => running=1 busy=1 idle=0 stopped=1 failed=1 unknown=3
-        let agents = json!({
-            "a1": {"status": "running"},
-            "a2": {"status": "busy"},
-            "a3": {"status": "failed"},
-            "a4": {"status": "stopped"},
-            "a5": {"status": "blocked"},
-            "a6": {"status": ""},
-            "a7": {"status": "weird_value"},
-        });
-        let got = agent_summary_counts(&agents, &json!({}));
-        assert_eq!(
-            got,
-            SummaryCounts { running: 1, busy: 1, idle: 0, stopped: 1, failed: 1, unknown: 3 }
-        );
-        assert_eq!(got.total(), 7);
-    }
-
-    #[test]
-    fn agent_summary_counts_none_agent_is_unknown() {
-        // golden: {"x": None} -> unknown=1
-        let got = agent_summary_counts(&json!({"x": Value::Null}), &json!({}));
-        assert_eq!(got, SummaryCounts { unknown: 1, ..Default::default() });
-    }
-
-    #[test]
-    fn agent_summary_counts_uppercase_status_lowercased() {
-        // golden: {"x":{"status":"RUNNING"}} -> running=1 (str(...).lower())
-        let got = agent_summary_counts(&json!({"x": {"status": "RUNNING"}}), &json!({}));
-        assert_eq!(got, SummaryCounts { running: 1, ..Default::default() });
-    }
-
-    // =========================================================================
-    // interaction_counts(commands.py:292-306):interacted 非空且≠"never"
-    // =========================================================================
-
-    #[test]
-    fn interaction_counts_mixed_golden() {
-        // golden: a:"5m ago"->interacted; b:"never"->never; c:""->never; d:{}->never; e:None->never
-        // result (1, 4)
-        let agents = json!({
-            "a": {"interacted": "5m ago"},
-            "b": {"interacted": "never"},
-            "c": {"interacted": ""},
-            "d": {},
-            "e": Value::Null,
-        });
-        let got = interaction_counts(&agents);
-        assert_eq!(got, InteractionCounts { interacted: 1, never: 4 });
-    }
-
-    // =========================================================================
-    // format_status_summary(commands.py:263-289):五行 triage 字节锁(Gap 18a)
-    // =========================================================================
-
-    #[test]
-    fn format_status_summary_full_byte_lock() {
-        // golden:
-        // coordinator: running schema_ok=True tmux=True
-        // receiver: %3 cmd=codex topology=external
-        // agents: 2 — running=1 busy=1 idle=0 stopped=0 failed=0 unknown=0
-        // queued: 2 mailbox messages awaiting delivery
-        // latest result: a1 -> did the thing @ -
-        let data = json!({
-            "coordinator": {"status": "running", "schema_ok": true},
-            "leader_receiver": {"pane_id": "%3", "pane_current_command": "codex"},
-            "agents": {"a1": {"status": "running"}, "a2": {"status": "busy"}},
-            "agent_health": {},
-            "tmux_session_present": true,
-            "queued_messages": [1, 2],
-            "latest_results": [{"agent_id": "a1", "summary": "did the thing", "created_at": Value::Null}],
-        });
-        let got = format_status_summary(&data);
-        let expected = "coordinator: running schema_ok=true tmux=true\n\
+// RED 契约 lane:argv→run 端到端、五行 summary 字节锁(Gap 18a)、
+// classify_agent_bucket(unknown≠idle)、cli-error 信封字节锁、leader_launcher_args 解析、
+// consume_leader_inbox_summary 游标+预算截断、send_target fanout 解析。
+// Python golden 来源:cli/{parser,commands,helpers}.py @ v0.2.11(439bef8)。
+// 所有期望值用 `PYTHONPATH=.../src python3` 实跑 Python 实现抓取的字节级 golden。
+use super::*;
+use serde_json::json;
+
+// =========================================================================
+// provider_args(helpers.py:190-193):values[0]=='--' ? values[1..] : values
+// =========================================================================
+
+#[test]
+fn provider_args_strips_leading_dashdash() {
+    // golden: _provider_args(["--","-x"]) == ["-x"]
+    assert_eq!(
+        provider_args(&["--".into(), "-x".into()]),
+        vec!["-x".to_string()]
+    );
+}
+
+#[test]
+fn provider_args_keeps_when_no_leading_dashdash() {
+    // golden: _provider_args(["-x","-y"]) == ["-x","-y"]
+    assert_eq!(
+        provider_args(&["-x".into(), "-y".into()]),
+        vec!["-x".to_string(), "-y".to_string()]
+    );
+}
+
+#[test]
+fn provider_args_empty_is_empty() {
+    // golden: _provider_args([]) == []
+    assert_eq!(provider_args(&[]), Vec::<String>::new());
+}
+
+#[test]
+fn provider_args_lone_dashdash_yields_empty() {
+    // golden: _provider_args(["--"]) == []  (values[1:] of single-elem list)
+    assert_eq!(provider_args(&["--".into()]), Vec::<String>::new());
+}
+
+// =========================================================================
+// leader_launcher_args(helpers.py:196-226):attach 旗标解析 + 缺值 Err
+// =========================================================================
+
+#[test]
+fn leader_launcher_args_empty_all_default() {
+    // golden: {'provider_args': [], 'attach_existing': False, 'confirm_attach': False, 'attach_session': None}
+    let got = leader_launcher_args(&[]).expect("empty should parse");
+    assert_eq!(got, LeaderLauncherArgs::default());
+    assert!(got.provider_args.is_empty());
+    assert!(!got.attach_existing);
+    assert!(!got.confirm_attach);
+    assert_eq!(got.attach_session, None);
+    assert!(!got.external_leader);
+}
+
+#[test]
+fn leader_launcher_args_attach_and_confirm() {
+    // golden: ["--attach","--confirm"] -> attach_existing=True, confirm_attach=True
+    let got = leader_launcher_args(&["--attach".into(), "--confirm".into()]).unwrap();
+    assert!(got.attach_existing);
+    assert!(got.confirm_attach);
+    assert!(got.provider_args.is_empty());
+    assert_eq!(got.attach_session, None);
+}
+
+#[test]
+fn leader_launcher_args_attach_existing_alias() {
+    // golden: ["--attach-existing"] -> attach_existing=True (alias of --attach)
+    let got = leader_launcher_args(&["--attach-existing".into()]).unwrap();
+    assert!(got.attach_existing);
+    assert!(!got.confirm_attach);
+}
+
+#[test]
+fn leader_launcher_args_external_leader_opt_out() {
+    let got = leader_launcher_args(&[
+        "--external-leader".into(),
+        "--".into(),
+        "--model".into(),
+        "opus".into(),
+    ])
+    .unwrap();
+    assert!(got.external_leader);
+    assert!(!got.attach_existing);
+    assert_eq!(
+        got.provider_args,
+        vec!["--model".to_string(), "opus".to_string()]
+    );
+}
+
+#[test]
+fn leader_launcher_args_external_leader_after_dashdash_errors() {
+    let err = leader_launcher_args(&["--".into(), "--external-leader".into()])
+        .expect_err("Team Agent flags after -- must not be silently passed to provider");
+    assert!(
+        err.to_string()
+            .contains("Team Agent launcher flag --external-leader must appear before --"),
+        "unexpected error: {err}"
+    );
+}
+
+#[test]
+fn leader_launcher_args_attach_session_spaced() {
+    // golden: ["--attach-session","mysess"] -> attach_session="mysess"
+    let got = leader_launcher_args(&["--attach-session".into(), "mysess".into()]).unwrap();
+    assert_eq!(got.attach_session, Some("mysess".to_string()));
+    assert!(!got.attach_existing);
+}
+
+#[test]
+fn leader_launcher_args_attach_session_equals() {
+    // golden: ["--attach-session=mysess"] -> attach_session="mysess"
+    let got = leader_launcher_args(&["--attach-session=mysess".into()]).unwrap();
+    assert_eq!(got.attach_session, Some("mysess".to_string()));
+}
+
+#[test]
+fn leader_launcher_args_dashdash_passthrough_strips_separator() {
+    // ["--attach","--","-x","--provider-confirm"] ->
+    //   provider_args=["-x","--provider-confirm"], attach_existing=True, confirm_attach=False
+    // Known Team Agent launcher flags after `--` are rejected by a separate guard.
+    let got = leader_launcher_args(&[
+        "--attach".into(),
+        "--".into(),
+        "-x".into(),
+        "--provider-confirm".into(),
+    ])
+    .unwrap();
+    assert!(got.attach_existing);
+    assert!(!got.confirm_attach);
+    assert_eq!(
+        got.provider_args,
+        vec!["-x".to_string(), "--provider-confirm".to_string()]
+    );
+}
+
+#[test]
+fn leader_launcher_args_unknown_tokens_collect_as_provider_args() {
+    // golden: ["foo","--attach","bar"] -> provider_args=["foo","bar"], attach_existing=True
+    let got = leader_launcher_args(&["foo".into(), "--attach".into(), "bar".into()]).unwrap();
+    assert_eq!(
+        got.provider_args,
+        vec!["foo".to_string(), "bar".to_string()]
+    );
+    assert!(got.attach_existing);
+}
+
+#[test]
+fn leader_launcher_args_attach_session_missing_value_errors() {
+    // golden: ["--attach-session"] raises RuntimeError("--attach-session requires a tmux session name")
+    let err = leader_launcher_args(&["--attach-session".into()]).unwrap_err();
+    let msg = err.to_string();
+    assert!(
+        msg.contains("--attach-session requires a tmux session name"),
+        "expected exact missing-value message, got: {msg}"
+    );
+}
+
+// =========================================================================
+// send_target(commands.py:181-184):--to split / target / None
+// =========================================================================
+
+#[test]
+fn send_target_fanout_strips_and_filters_empty() {
+    // golden: _send_target(targets="a, b ,,c") == ["a","b","c"]
+    let got = send_target(Some("a, b ,,c"), None);
+    assert_eq!(
+        got,
+        MessageTarget::Fanout(vec!["a".to_string(), "b".to_string(), "c".to_string()])
+    );
+}
+
+#[test]
+fn send_target_single_target() {
+    // golden: _send_target(target="agent_x") == "agent_x"
+    assert_eq!(
+        send_target(None, Some("agent_x")),
+        MessageTarget::Single("agent_x".to_string())
+    );
+}
+
+#[test]
+fn send_target_broadcast_star() {
+    // skeleton contract: bare "*" target -> Broadcast (send.py interprets "*" as全队广播)
+    assert_eq!(send_target(None, Some("*")), MessageTarget::Broadcast);
+}
+
+#[test]
+fn send_target_empty_targets_falls_through_to_target() {
+    // golden: targets="" is falsy in Python -> returns args.target ("fallback")
+    assert_eq!(
+        send_target(Some(""), Some("fallback")),
+        MessageTarget::Single("fallback".to_string())
+    );
+}
+
+// =========================================================================
+// classify_agent_bucket / agent_summary_counts(commands.py:309-330)
+// bug-071/077/085 铁律:unknown ≠ idle,无匹配态显式落 Unknown
+// =========================================================================
+
+#[test]
+fn classify_failed_takes_priority() {
+    // raw in {failed,error} OR hstatus in {failed,error} -> Failed
+    assert_eq!(classify_agent_bucket("failed", ""), SummaryBucket::Failed);
+    assert_eq!(classify_agent_bucket("error", ""), SummaryBucket::Failed);
+    assert_eq!(
+        classify_agent_bucket("running", "error"),
+        SummaryBucket::Failed
+    );
+}
+
+#[test]
+fn classify_stopped() {
+    // raw in {stopped,done} OR hstatus==done -> Stopped
+    assert_eq!(classify_agent_bucket("stopped", ""), SummaryBucket::Stopped);
+    assert_eq!(classify_agent_bucket("done", ""), SummaryBucket::Stopped);
+    assert_eq!(
+        classify_agent_bucket("running", "done"),
+        SummaryBucket::Stopped
+    );
+}
+
+#[test]
+fn classify_busy() {
+    // raw==busy OR hstatus in {running,working} -> Busy
+    assert_eq!(classify_agent_bucket("busy", ""), SummaryBucket::Busy);
+    assert_eq!(classify_agent_bucket("", "running"), SummaryBucket::Busy);
+    assert_eq!(classify_agent_bucket("", "working"), SummaryBucket::Busy);
+}
+
+#[test]
+fn classify_hstatus_idle_beats_raw_running() {
+    // golden: raw=running, h=idle -> idle  (hstatus==idle branch precedes raw==running branch)
+    assert_eq!(
+        classify_agent_bucket("running", "idle"),
+        SummaryBucket::Idle
+    );
+}
+
+#[test]
+fn classify_pure_running() {
+    // raw==running, no overriding hstatus -> Running
+    assert_eq!(classify_agent_bucket("running", ""), SummaryBucket::Running);
+}
+
+#[test]
+fn classify_blocked_and_unmatched_are_unknown_never_idle() {
+    // bug-071/077/085: blocked/stuck/missing AND any unmatched value -> Unknown, NOT idle.
+    assert_eq!(classify_agent_bucket("blocked", ""), SummaryBucket::Unknown);
+    assert_eq!(classify_agent_bucket("stuck", ""), SummaryBucket::Unknown);
+    assert_eq!(classify_agent_bucket("", "missing"), SummaryBucket::Unknown);
+    assert_eq!(
+        classify_agent_bucket("weird_value", ""),
+        SummaryBucket::Unknown
+    );
+    assert_eq!(classify_agent_bucket("", ""), SummaryBucket::Unknown);
+}
+
+#[test]
+fn agent_summary_counts_mixed_golden() {
+    // golden (empty health): a1 running->Running; a2 busy->Busy; a3 failed->Failed;
+    //   a4 stopped->Stopped; a5 blocked->Unknown; a6 ""->Unknown; a7 weird->Unknown.
+    //   => running=1 busy=1 idle=0 stopped=1 failed=1 unknown=3
+    let agents = json!({
+        "a1": {"status": "running"},
+        "a2": {"status": "busy"},
+        "a3": {"status": "failed"},
+        "a4": {"status": "stopped"},
+        "a5": {"status": "blocked"},
+        "a6": {"status": ""},
+        "a7": {"status": "weird_value"},
+    });
+    let got = agent_summary_counts(&agents, &json!({}));
+    assert_eq!(
+        got,
+        SummaryCounts {
+            running: 1,
+            busy: 1,
+            idle: 0,
+            stopped: 1,
+            failed: 1,
+            unknown: 3
+        }
+    );
+    assert_eq!(got.total(), 7);
+}
+
+#[test]
+fn agent_summary_counts_none_agent_is_unknown() {
+    // golden: {"x": None} -> unknown=1
+    let got = agent_summary_counts(&json!({"x": Value::Null}), &json!({}));
+    assert_eq!(
+        got,
+        SummaryCounts {
+            unknown: 1,
+            ..Default::default()
+        }
+    );
+}
+
+#[test]
+fn agent_summary_counts_uppercase_status_lowercased() {
+    // golden: {"x":{"status":"RUNNING"}} -> running=1 (str(...).lower())
+    let got = agent_summary_counts(&json!({"x": {"status": "RUNNING"}}), &json!({}));
+    assert_eq!(
+        got,
+        SummaryCounts {
+            running: 1,
+            ..Default::default()
+        }
+    );
+}
+
+// =========================================================================
+// interaction_counts(commands.py:292-306):interacted 非空且≠"never"
+// =========================================================================
+
+#[test]
+fn interaction_counts_mixed_golden() {
+    // golden: a:"5m ago"->interacted; b:"never"->never; c:""->never; d:{}->never; e:None->never
+    // result (1, 4)
+    let agents = json!({
+        "a": {"interacted": "5m ago"},
+        "b": {"interacted": "never"},
+        "c": {"interacted": ""},
+        "d": {},
+        "e": Value::Null,
+    });
+    let got = interaction_counts(&agents);
+    assert_eq!(
+        got,
+        InteractionCounts {
+            interacted: 1,
+            never: 4
+        }
+    );
+}
+
+// =========================================================================
+// format_status_summary(commands.py:263-289):五行 triage 字节锁(Gap 18a)
+// =========================================================================
+
+#[test]
+fn format_status_summary_full_byte_lock() {
+    // golden:
+    // coordinator: running schema_ok=True tmux=True
+    // receiver: %3 cmd=codex topology=external
+    // agents: 2 — running=1 busy=1 idle=0 stopped=0 failed=0 unknown=0
+    // queued: 2 mailbox messages awaiting delivery
+    // latest result: a1 -> did the thing @ -
+    let data = json!({
+        "coordinator": {"status": "running", "schema_ok": true},
+        "leader_receiver": {"pane_id": "%3", "pane_current_command": "codex"},
+        "agents": {"a1": {"status": "running"}, "a2": {"status": "busy"}},
+        "agent_health": {},
+        "tmux_session_present": true,
+        "queued_messages": [1, 2],
+        "latest_results": [{"agent_id": "a1", "summary": "did the thing", "created_at": Value::Null}],
+    });
+    let got = format_status_summary(&data);
+    let expected = "coordinator: running schema_ok=true tmux=true\n\
 receiver: %3 cmd=codex topology=external\n\
 agents: 2 — running=1 busy=1 idle=0 stopped=0 failed=0 unknown=0\n\
 queued: 2 mailbox messages awaiting delivery\n\
 latest result: a1 -> did the thing @ -";
-        assert_eq!(got, expected);
-    }
-
-    #[test]
-    fn format_status_summary_empty_byte_lock() {
-        // golden empty data: stopped/false/false, dashes, 0 counts, none latest.
-        let got = format_status_summary(&json!({}));
-        let expected = "coordinator: stopped schema_ok=false tmux=false\n\
+    assert_eq!(got, expected);
+}
+
+#[test]
+fn format_status_summary_empty_byte_lock() {
+    // golden empty data: stopped/false/false, dashes, 0 counts, none latest.
+    let got = format_status_summary(&json!({}));
+    let expected = "coordinator: stopped schema_ok=false tmux=false\n\
 receiver: - cmd=- topology=external\n\
 agents: 0 — running=0 busy=0 idle=0 stopped=0 failed=0 unknown=0\n\
 queued: 0 mailbox messages awaiting delivery\n\
 latest result: none";
-        assert_eq!(got, expected);
-    }
-
-    #[test]
-    fn format_status_summary_interacted_marker_appended() {
-        // golden: when interacted>0, agents line gets " (1 interacted, 1 never)" suffix.
-        let data = json!({
-            "coordinator": {},
-            "agents": {"a1": {"status": "running", "interacted": "3m"}, "a2": {"status": "idle"}},
-            "agent_health": {"a2": {"status": "idle"}},
-        });
-        let got = format_status_summary(&data);
-        let line2 = got.lines().nth(2).unwrap();
-        assert_eq!(
-            line2,
-            "agents: 2 — running=1 busy=0 idle=1 stopped=0 failed=0 unknown=0 (1 interacted, 1 never)"
-        );
-    }
-
-    #[test]
-    fn format_status_summary_no_interacted_marker_when_zero() {
-        // Gap 18a contract: interacted==0 -> line[2] stays byte-identical with NO marker suffix.
-        let data = json!({
-            "agents": {"a1": {"status": "running"}},
-            "agent_health": {},
-        });
-        let line2 = format_status_summary(&data).lines().nth(2).unwrap().to_string();
-        assert_eq!(line2, "agents: 1 — running=1 busy=0 idle=0 stopped=0 failed=0 unknown=0");
-        assert!(!line2.contains("interacted"), "no marker when interacted==0");
-    }
-
-    #[test]
-    fn format_status_csv_preserves_agent_order_and_collapses_errors() {
-        let data = json!({
-            "agents": {
-                "zeta": {"status": "idle", "pane_id": "%1"},
-                "alpha": {"status": "running", "pane_id": "%2"},
-                "err_failed": {"status": "failed", "pane_id": "%3"},
-                "err_missing_pane": {"status": "running"},
-                "err_unknown": {"status": "mystery", "pane_id": "%4"},
-                "err_stopped": {"status": "stopped", "pane_id": "%5"}
-            },
-            "agent_health": {
-                "alpha": {"status": "working"}
-            }
-        });
-        assert_eq!(
+    assert_eq!(got, expected);
+}
+
+#[test]
+fn format_status_summary_interacted_marker_appended() {
+    // golden: when interacted>0, agents line gets " (1 interacted, 1 never)" suffix.
+    let data = json!({
+        "coordinator": {},
+        "agents": {"a1": {"status": "running", "interacted": "3m"}, "a2": {"status": "idle"}},
+        "agent_health": {"a2": {"status": "idle"}},
+    });
+    let got = format_status_summary(&data);
+    let line2 = got.lines().nth(2).unwrap();
+    assert_eq!(
+        line2,
+        "agents: 2 — running=1 busy=0 idle=1 stopped=0 failed=0 unknown=0 (1 interacted, 1 never)"
+    );
+}
+
+#[test]
+fn format_status_summary_no_interacted_marker_when_zero() {
+    // Gap 18a contract: interacted==0 -> line[2] stays byte-identical with NO marker suffix.
+    let data = json!({
+        "agents": {"a1": {"status": "running"}},
+        "agent_health": {},
+    });
+    let line2 = format_status_summary(&data)
+        .lines()
+        .nth(2)
+        .unwrap()
+        .to_string();
+    assert_eq!(
+        line2,
+        "agents: 1 — running=1 busy=0 idle=0 stopped=0 failed=0 unknown=0"
+    );
+    assert!(
+        !line2.contains("interacted"),
+        "no marker when interacted==0"
+    );
+}
+
+#[test]
+fn format_status_csv_preserves_agent_order_and_collapses_errors() {
+    let data = json!({
+        "agents": {
+            "zeta": {"status": "idle", "pane_id": "%1"},
+            "alpha": {"status": "running", "pane_id": "%2"},
+            "err_failed": {"status": "failed", "pane_id": "%3"},
+            "err_missing_pane": {"status": "running"},
+            "err_unknown": {"status": "mystery", "pane_id": "%4"},
+            "err_stopped": {"status": "stopped", "pane_id": "%5"}
+        },
+        "agent_health": {
+            "alpha": {"status": "working"}
+        }
+    });
+    assert_eq!(
             format_status_csv(&data),
             "zeta,空闲\nalpha,工作\nerr_failed,错误\nerr_missing_pane,错误\nerr_unknown,错误\nerr_stopped,错误"
         );
-    }
-
-    #[test]
-    fn format_status_csv_zero_workers_is_empty() {
-        assert_eq!(format_status_csv(&json!({"agents": {}, "agent_health": {}})), "");
-    }
-
-    // =========================================================================
-    // emit(helpers.py:12-23):--json sort_keys+indent=2 | dict 逐键 | 非 dict
-    // =========================================================================
-
-    #[test]
-    fn emit_json_sorted_indented() {
-        // golden json.dumps(indent=2, sort_keys=True): keys sorted a,b,nested; nested list expanded.
-        let out = emit(&CmdOutput::Json(json!({"b": 2, "a": 1, "nested": {"x": [1, 2]}})), true)
-            .expect("json emit returns Some");
-        let expected = "{\n  \"a\": 1,\n  \"b\": 2,\n  \"nested\": {\n    \"x\": [\n      1,\n      2\n    ]\n  }\n}";
-        assert_eq!(out, expected);
-    }
-
-    #[test]
-    fn emit_dict_human_per_key() {
-        // golden human dict: scalar -> "key: value"; dict/list -> compact json value.
-        // KEY INSERTION ORDER preserved (NOT sorted) in non-json path.
-        let out = emit(
-            &CmdOutput::Json(json!({"key1": "val1", "nested": {"a": 1}, "lst": [1, 2]})),
-            false,
-        )
-        .expect("dict human emit returns Some");
-        let expected = "key1: val1\nnested: {\"a\": 1}\nlst: [1, 2]";
-        assert_eq!(out, expected);
-    }
-
-    #[test]
-    fn emit_human_non_dict_passthrough() {
-        // golden: non-dict (Human string) printed raw.
-        let out = emit(&CmdOutput::Human("just a string".into()), false)
-            .expect("human emit returns Some");
-        assert_eq!(out, "just a string");
-    }
-
-    #[test]
-    fn emit_none_output_produces_nothing() {
-        // passthrough/watch: CmdOutput::None never reaches emit -> None (no stdout line).
-        assert_eq!(emit(&CmdOutput::None, false), None);
-        assert_eq!(emit(&CmdOutput::None, true), None);
-    }
-
-    // =========================================================================
-    // CliError::to_payload(helpers.py:137-187):稳定信封 + tmux 冲突富化
-    // =========================================================================
-
-    #[test]
-    fn cli_error_payload_plain_runtime() {
-        // golden plain: ok=false, error=str(exc), action=generic, log=path, NO reason/session/next.
-        let err = CliError::Runtime("some other error".into());
-        let payload = err.to_payload(Path::new("/tmp/y.log"), "status");
-        assert!(!payload.ok);
-        assert_eq!(payload.error, "some other error");
-        assert_eq!(payload.action, "run `team-agent doctor` or inspect the log path shown here");
-        assert_eq!(payload.log, "/tmp/y.log");
-        assert_eq!(payload.reason, None);
-        assert_eq!(payload.session_name, None);
-        assert_eq!(payload.next_actions, None);
-    }
-
-    #[test]
-    fn cli_error_payload_tmux_conflict_quick_start_enrichment() {
-        // golden quick-start enrichment (exact bytes):
-        let err = CliError::Runtime("tmux session already exists: my-team. Startup aborted".into());
-        let payload = err.to_payload(Path::new("/tmp/cli-error-123.log"), "quick-start");
-        assert_eq!(payload.reason.as_deref(), Some("tmux_session_name_conflict"));
-        assert_eq!(payload.session_name.as_deref(), Some("my-team"));
-        // E8 (N38): quick-start 撞已有 runtime 引导到 restart(resume);
-        // context reset is only through restart --allow-fresh with explicit consent.
-        assert_eq!(
+}
+
+#[test]
+fn format_status_csv_zero_workers_is_empty() {
+    assert_eq!(
+        format_status_csv(&json!({"agents": {}, "agent_health": {}})),
+        ""
+    );
+}
+
+// =========================================================================
+// emit(helpers.py:12-23):--json sort_keys+indent=2 | dict 逐键 | 非 dict
+// =========================================================================
+
+#[test]
+fn emit_json_sorted_indented() {
+    // golden json.dumps(indent=2, sort_keys=True): keys sorted a,b,nested; nested list expanded.
+    let out = emit(
+        &CmdOutput::Json(json!({"b": 2, "a": 1, "nested": {"x": [1, 2]}})),
+        true,
+    )
+    .expect("json emit returns Some");
+    let expected = "{\n  \"a\": 1,\n  \"b\": 2,\n  \"nested\": {\n    \"x\": [\n      1,\n      2\n    ]\n  }\n}";
+    assert_eq!(out, expected);
+}
+
+#[test]
+fn emit_dict_human_per_key() {
+    // golden human dict: scalar -> "key: value"; dict/list -> compact json value.
+    // KEY INSERTION ORDER preserved (NOT sorted) in non-json path.
+    let out = emit(
+        &CmdOutput::Json(json!({"key1": "val1", "nested": {"a": 1}, "lst": [1, 2]})),
+        false,
+    )
+    .expect("dict human emit returns Some");
+    let expected = "key1: val1\nnested: {\"a\": 1}\nlst: [1, 2]";
+    assert_eq!(out, expected);
+}
+
+#[test]
+fn emit_human_non_dict_passthrough() {
+    // golden: non-dict (Human string) printed raw.
+    let out =
+        emit(&CmdOutput::Human("just a string".into()), false).expect("human emit returns Some");
+    assert_eq!(out, "just a string");
+}
+
+#[test]
+fn emit_none_output_produces_nothing() {
+    // passthrough/watch: CmdOutput::None never reaches emit -> None (no stdout line).
+    assert_eq!(emit(&CmdOutput::None, false), None);
+    assert_eq!(emit(&CmdOutput::None, true), None);
+}
+
+// =========================================================================
+// CliError::to_payload(helpers.py:137-187):稳定信封 + tmux 冲突富化
+// =========================================================================
+
+#[test]
+fn cli_error_payload_plain_runtime() {
+    // golden plain: ok=false, error=str(exc), action=generic, log=path, NO reason/session/next.
+    let err = CliError::Runtime("some other error".into());
+    let payload = err.to_payload(Path::new("/tmp/y.log"), "status");
+    assert!(!payload.ok);
+    assert_eq!(payload.error, "some other error");
+    assert_eq!(
+        payload.action,
+        "run `team-agent doctor` or inspect the log path shown here"
+    );
+    assert_eq!(payload.log, "/tmp/y.log");
+    assert_eq!(payload.reason, None);
+    assert_eq!(payload.session_name, None);
+    assert_eq!(payload.next_actions, None);
+}
+
+#[test]
+fn cli_error_payload_tmux_conflict_quick_start_enrichment() {
+    // golden quick-start enrichment (exact bytes):
+    let err = CliError::Runtime("tmux session already exists: my-team. Startup aborted".into());
+    let payload = err.to_payload(Path::new("/tmp/cli-error-123.log"), "quick-start");
+    assert_eq!(
+        payload.reason.as_deref(),
+        Some("tmux_session_name_conflict")
+    );
+    assert_eq!(payload.session_name.as_deref(), Some("my-team"));
+    // E8 (N38): quick-start 撞已有 runtime 引导到 restart(resume);
+    // context reset is only through restart --allow-fresh with explicit consent.
+    assert_eq!(
             payload.action,
             "tmux session `my-team` already exists. It may be your own existing team. \
 To resume it use `team-agent restart`. \
@@ -465,230 +536,237 @@ If recovery is impossible, use `team-agent restart --allow-fresh` only after exp
 Only if you want a separate team, change `name:` in TEAM.md and run quick-start again. \
 Never terminate existing tmux sessions from quick-start."
         );
-        assert_eq!(
+    assert_eq!(
             payload.next_actions,
             Some(vec![
                 "If this is your existing team, resume it with `team-agent restart`.".to_string(),
                 "If you want a separate team, change `name:` in TEAM.md and run `team-agent quick-start` again.".to_string(),
             ])
         );
-    }
-
-    #[test]
-    fn cli_error_payload_tmux_conflict_non_quick_start_enrichment() {
-        // golden non-quick-start (command="restart") enrichment uses generic startup wording.
-        let err = CliError::Runtime("tmux session already exists: my-team. Startup aborted".into());
-        let payload = err.to_payload(Path::new("/tmp/x.log"), "restart");
-        assert_eq!(payload.session_name.as_deref(), Some("my-team"));
-        assert_eq!(
-            payload.action,
-            "tmux session `my-team` already exists. It may be an active team. \
+}
+
+#[test]
+fn cli_error_payload_tmux_conflict_non_quick_start_enrichment() {
+    // golden non-quick-start (command="restart") enrichment uses generic startup wording.
+    let err = CliError::Runtime("tmux session already exists: my-team. Startup aborted".into());
+    let payload = err.to_payload(Path::new("/tmp/x.log"), "restart");
+    assert_eq!(payload.session_name.as_deref(), Some("my-team"));
+    assert_eq!(
+        payload.action,
+        "tmux session `my-team` already exists. It may be an active team. \
 Do not terminate existing tmux sessions from startup; \
 use a different team name or runtime.session_name and start again."
-        );
-        assert_eq!(
-            payload.next_actions,
-            Some(vec!["Use a different team name or runtime.session_name before starting again.".to_string()])
-        );
-    }
-
-    #[test]
-    fn cli_error_payload_json_shape_serializes_optional_fields_skipped() {
-        // skip_serializing_if for reason/session_name/next_actions: plain payload omits them.
-        let err = CliError::Runtime("boom".into());
-        let payload = err.to_payload(Path::new("/tmp/z.log"), "status");
-        let v = serde_json::to_value(&payload).unwrap();
-        let obj = v.as_object().unwrap();
-        assert!(!obj.contains_key("reason"), "reason omitted on plain error");
-        assert!(!obj.contains_key("session_name"));
-        assert!(!obj.contains_key("next_actions"));
-        assert_eq!(obj.get("ok"), Some(&json!(false)));
-    }
-
-    #[test]
-    fn consume_inbox_missing_file_returns_none() {
-        // helpers.py:30-31: inbox_path absent -> None (no crash).
-        let ws = tmp_workspace();
-        assert_eq!(consume_leader_inbox_summary(&ws, 500), None);
-        let _ = std::fs::remove_dir_all(&ws);
-    }
-
-    #[test]
-    fn consume_inbox_single_entry_summary_and_cursor_advance() {
-        // golden _leader_inbox_summary single entry:
-        //   "Leader inbox: 1 new fallback entry\n- Hello world message\nHint: team-agent inbox leader"
-        let ws = tmp_workspace();
-        let inbox = ws.join(".team").join("runtime").join("leader-inbox.log");
-        std::fs::write(&inbox, "[x fallback]\nHello world message").unwrap();
-        let summary = consume_leader_inbox_summary(&ws, 500).expect("new entry -> Some");
-        assert_eq!(
-            summary,
-            "Leader inbox: 1 new fallback entry\n- Hello world message\nHint: team-agent inbox leader"
-        );
-        // cursor advanced: a second call with no new bytes -> None (offset==size).
-        assert_eq!(consume_leader_inbox_summary(&ws, 500), None);
-        let _ = std::fs::remove_dir_all(&ws);
-    }
-
-    #[test]
-    fn consume_inbox_two_entries_plural() {
-        // golden two-entry summary uses plural "entries".
-        let ws = tmp_workspace();
-        let inbox = ws.join(".team").join("runtime").join("leader-inbox.log");
-        std::fs::write(&inbox, "[a fallback]\nFirst msg\n[b fallback]\nSecond msg").unwrap();
-        let summary = consume_leader_inbox_summary(&ws, 500).expect("Some");
-        assert_eq!(
+    );
+    assert_eq!(
+        payload.next_actions,
+        Some(vec![
+            "Use a different team name or runtime.session_name before starting again.".to_string()
+        ])
+    );
+}
+
+#[test]
+fn cli_error_payload_json_shape_serializes_optional_fields_skipped() {
+    // skip_serializing_if for reason/session_name/next_actions: plain payload omits them.
+    let err = CliError::Runtime("boom".into());
+    let payload = err.to_payload(Path::new("/tmp/z.log"), "status");
+    let v = serde_json::to_value(&payload).unwrap();
+    let obj = v.as_object().unwrap();
+    assert!(!obj.contains_key("reason"), "reason omitted on plain error");
+    assert!(!obj.contains_key("session_name"));
+    assert!(!obj.contains_key("next_actions"));
+    assert_eq!(obj.get("ok"), Some(&json!(false)));
+}
+
+#[test]
+fn consume_inbox_missing_file_returns_none() {
+    // helpers.py:30-31: inbox_path absent -> None (no crash).
+    let ws = tmp_workspace();
+    assert_eq!(consume_leader_inbox_summary(&ws, 500), None);
+    let _ = std::fs::remove_dir_all(&ws);
+}
+
+#[test]
+fn consume_inbox_single_entry_summary_and_cursor_advance() {
+    // golden _leader_inbox_summary single entry:
+    //   "Leader inbox: 1 new fallback entry\n- Hello world message\nHint: team-agent inbox leader"
+    let ws = tmp_workspace();
+    let inbox = ws.join(".team").join("runtime").join("leader-inbox.log");
+    std::fs::write(&inbox, "[x fallback]\nHello world message").unwrap();
+    let summary = consume_leader_inbox_summary(&ws, 500).expect("new entry -> Some");
+    assert_eq!(
+        summary,
+        "Leader inbox: 1 new fallback entry\n- Hello world message\nHint: team-agent inbox leader"
+    );
+    // cursor advanced: a second call with no new bytes -> None (offset==size).
+    assert_eq!(consume_leader_inbox_summary(&ws, 500), None);
+    let _ = std::fs::remove_dir_all(&ws);
+}
+
+#[test]
+fn consume_inbox_two_entries_plural() {
+    // golden two-entry summary uses plural "entries".
+    let ws = tmp_workspace();
+    let inbox = ws.join(".team").join("runtime").join("leader-inbox.log");
+    std::fs::write(&inbox, "[a fallback]\nFirst msg\n[b fallback]\nSecond msg").unwrap();
+    let summary = consume_leader_inbox_summary(&ws, 500).expect("Some");
+    assert_eq!(
             summary,
             "Leader inbox: 2 new fallback entries\n- First msg\n- Second msg\nHint: team-agent inbox leader"
         );
-        let _ = std::fs::remove_dir_all(&ws);
-    }
-
-    #[test]
-    fn consume_inbox_budget_truncation_footer() {
-        // golden budget=200: header + 2 lines then truncation footer (exact bytes from Python).
-        let ws = tmp_workspace();
-        let inbox = ws.join(".team").join("runtime").join("leader-inbox.log");
-        let many: String = (0..20)
-            .map(|i| format!("[e{i} fallback]\nMessage number {i} with some text padding here"))
-            .collect::<Vec<_>>()
-            .join("\n");
-        std::fs::write(&inbox, &many).unwrap();
-        let summary = consume_leader_inbox_summary(&ws, 200).expect("Some");
-        let expected = "Leader inbox: 20 new fallback entries\n\
+    let _ = std::fs::remove_dir_all(&ws);
+}
+
+#[test]
+fn consume_inbox_budget_truncation_footer() {
+    // golden budget=200: header + 2 lines then truncation footer (exact bytes from Python).
+    let ws = tmp_workspace();
+    let inbox = ws.join(".team").join("runtime").join("leader-inbox.log");
+    let many: String = (0..20)
+        .map(|i| format!("[e{i} fallback]\nMessage number {i} with some text padding here"))
+        .collect::<Vec<_>>()
+        .join("\n");
+    std::fs::write(&inbox, &many).unwrap();
+    let summary = consume_leader_inbox_summary(&ws, 200).expect("Some");
+    let expected = "Leader inbox: 20 new fallback entries\n\
 - Message number 0 with some text padding here\n\
 - Message number 1 with some text padd ...\n\
 Truncated: more fallback entries available; run team-agent inbox leader";
-        assert_eq!(summary, expected);
-        let _ = std::fs::remove_dir_all(&ws);
-    }
-
-    // =========================================================================
-    // CmdResult::from_json(parser.py:507-508):ok is False -> ExitCode::Error
-    // =========================================================================
-
-    #[test]
-    fn cmd_result_from_json_ok_true_exits_ok() {
-        let r = CmdResult::from_json(json!({"ok": true, "x": 1}), true);
-        assert_eq!(r.exit, ExitCode::Ok);
-        assert!(r.as_json);
-        assert_eq!(r.output, CmdOutput::Json(json!({"ok": true, "x": 1})));
-    }
-
-    #[test]
-    fn cmd_result_from_json_ok_false_exits_error() {
-        // parser.py:507: result.get("ok") is False -> SystemExit(1)
-        let r = CmdResult::from_json(json!({"ok": false, "error": "x"}), false);
-        assert_eq!(r.exit, ExitCode::Error);
-        assert!(!r.as_json);
-    }
-
-    #[test]
-    fn cmd_result_from_json_missing_ok_exits_ok() {
-        // result with NO "ok" key: `result.get("ok") is False` is False -> NOT an error (exit Ok).
-        // None-vs-missing: absence of ok != ok:false.
-        let r = CmdResult::from_json(json!({"summary": "fine"}), false);
-        assert_eq!(r.exit, ExitCode::Ok);
-    }
-
-    #[test]
-    fn exit_code_numeric() {
-        assert_eq!(ExitCode::Ok.code(), 0);
-        assert_eq!(ExitCode::Error.code(), 1);
-    }
-
-    // =========================================================================
-    // cmd_doctor 分派(commands.py:218-260):--fix 缺 gate -> Usage err
-    // =========================================================================
-
-    #[test]
-    fn cmd_doctor_fix_without_gate_is_usage_error() {
-        // commands.py:220-221: --fix and not gate -> TeamAgentError("--fix requires --gate")
-        let args = DoctorArgs {
-            spec: None,
-            workspace: PathBuf::from("."),
-            gate: None,
-            comms: false,
-            team: None,
-            fix: true,
-            fix_schema: false,
-            cleanup_orphans: false,
-            confirm: false,
-            json: false,
-        };
-        let err = cmd_doctor(&args).unwrap_err();
-        let msg = err.to_string();
-        assert!(
-            msg.contains("--fix requires --gate"),
-            "expected '--fix requires --gate', got: {msg}"
-        );
-    }
-
-    // =========================================================================
-    // cmd_status 三态互斥(commands.py:90-100)
-    // =========================================================================
-
-    #[test]
-    fn cmd_status_summary_with_json_is_mutually_exclusive() {
-        // commands.py:92-93: --summary and --json -> TeamAgentError(mutually exclusive)
-        let args = StatusArgs {
-            agent: None,
-            workspace: PathBuf::from("."),
-            detail: false,
-            summary: true,
-            json: true,
-            team: None,
-        };
-        let err = cmd_status(&args).unwrap_err();
-        assert!(
-            err.to_string().contains("--summary and --json are mutually exclusive"),
-            "got: {err}"
-        );
-    }
-
-    #[test]
-    fn cmd_status_summary_with_agent_rejected() {
-        // commands.py:94-95: --summary + agent -> TeamAgentError(does not accept an agent argument)
-        let args = StatusArgs {
-            agent: Some("a1".into()),
-            workspace: PathBuf::from("."),
-            detail: false,
-            summary: true,
-            json: false,
-            team: None,
-        };
-        let err = cmd_status(&args).unwrap_err();
-        assert!(
-            err.to_string().contains("status --summary does not accept an agent argument"),
-            "got: {err}"
-        );
-    }
-
-    // =========================================================================
-    // cmd_leader_passthrough(parser.py:515-522):-h/--help 早返回 CmdResult::none
-    // =========================================================================
-
-    #[test]
-    fn cmd_leader_passthrough_help_returns_none() {
-        // parser.py:516: provider_args in (["-h"],["--help"]) -> print usage, return (no emit).
-        let r = cmd_leader_passthrough("codex", &["-h".into()], Path::new(".")).unwrap();
-        assert_eq!(r.output, CmdOutput::None);
-        assert_eq!(r.exit, ExitCode::Ok);
-        let r2 = cmd_leader_passthrough("claude", &["--help".into()], Path::new(".")).unwrap();
-        assert_eq!(r2.output, CmdOutput::None);
-        let r3 = cmd_leader_passthrough("copilot", &["--help".into()], Path::new(".")).unwrap();
-        assert_eq!(r3.output, CmdOutput::None);
-    }
-
-    #[test]
-    fn cmd_leader_passthrough_maps_copilot_provider() {
-        assert_eq!(leader_passthrough_provider("codex"), crate::model::enums::Provider::Codex);
-        assert_eq!(
-            leader_passthrough_provider("claude"),
-            crate::model::enums::Provider::ClaudeCode
-        );
-        assert_eq!(
-            leader_passthrough_provider("copilot"),
-            crate::model::enums::Provider::Copilot
-        );
-    }
+    assert_eq!(summary, expected);
+    let _ = std::fs::remove_dir_all(&ws);
+}
+
+// =========================================================================
+// CmdResult::from_json(parser.py:507-508):ok is False -> ExitCode::Error
+// =========================================================================
+
+#[test]
+fn cmd_result_from_json_ok_true_exits_ok() {
+    let r = CmdResult::from_json(json!({"ok": true, "x": 1}), true);
+    assert_eq!(r.exit, ExitCode::Ok);
+    assert!(r.as_json);
+    assert_eq!(r.output, CmdOutput::Json(json!({"ok": true, "x": 1})));
+}
+
+#[test]
+fn cmd_result_from_json_ok_false_exits_error() {
+    // parser.py:507: result.get("ok") is False -> SystemExit(1)
+    let r = CmdResult::from_json(json!({"ok": false, "error": "x"}), false);
+    assert_eq!(r.exit, ExitCode::Error);
+    assert!(!r.as_json);
+}
+
+#[test]
+fn cmd_result_from_json_missing_ok_exits_ok() {
+    // result with NO "ok" key: `result.get("ok") is False` is False -> NOT an error (exit Ok).
+    // None-vs-missing: absence of ok != ok:false.
+    let r = CmdResult::from_json(json!({"summary": "fine"}), false);
+    assert_eq!(r.exit, ExitCode::Ok);
+}
+
+#[test]
+fn exit_code_numeric() {
+    assert_eq!(ExitCode::Ok.code(), 0);
+    assert_eq!(ExitCode::Error.code(), 1);
+}
+
+// =========================================================================
+// cmd_doctor 分派(commands.py:218-260):--fix 缺 gate -> Usage err
+// =========================================================================
+
+#[test]
+fn cmd_doctor_fix_without_gate_is_usage_error() {
+    // commands.py:220-221: --fix and not gate -> TeamAgentError("--fix requires --gate")
+    let args = DoctorArgs {
+        spec: None,
+        workspace: PathBuf::from("."),
+        gate: None,
+        comms: false,
+        team: None,
+        fix: true,
+        fix_schema: false,
+        cleanup_orphans: false,
+        confirm: false,
+        json: false,
+    };
+    let err = cmd_doctor(&args).unwrap_err();
+    let msg = err.to_string();
+    assert!(
+        msg.contains("--fix requires --gate"),
+        "expected '--fix requires --gate', got: {msg}"
+    );
+}
+
+// =========================================================================
+// cmd_status 三态互斥(commands.py:90-100)
+// =========================================================================
+
+#[test]
+fn cmd_status_summary_with_json_is_mutually_exclusive() {
+    // commands.py:92-93: --summary and --json -> TeamAgentError(mutually exclusive)
+    let args = StatusArgs {
+        agent: None,
+        workspace: PathBuf::from("."),
+        detail: false,
+        summary: true,
+        json: true,
+        team: None,
+    };
+    let err = cmd_status(&args).unwrap_err();
+    assert!(
+        err.to_string()
+            .contains("--summary and --json are mutually exclusive"),
+        "got: {err}"
+    );
+}
+
+#[test]
+fn cmd_status_summary_with_agent_rejected() {
+    // commands.py:94-95: --summary + agent -> TeamAgentError(does not accept an agent argument)
+    let args = StatusArgs {
+        agent: Some("a1".into()),
+        workspace: PathBuf::from("."),
+        detail: false,
+        summary: true,
+        json: false,
+        team: None,
+    };
+    let err = cmd_status(&args).unwrap_err();
+    assert!(
+        err.to_string()
+            .contains("status --summary does not accept an agent argument"),
+        "got: {err}"
+    );
+}
+
+// =========================================================================
+// cmd_leader_passthrough(parser.py:515-522):-h/--help 早返回 CmdResult::none
+// =========================================================================
+
+#[test]
+fn cmd_leader_passthrough_help_returns_none() {
+    // parser.py:516: provider_args in (["-h"],["--help"]) -> print usage, return (no emit).
+    let r = cmd_leader_passthrough("codex", &["-h".into()], Path::new(".")).unwrap();
+    assert_eq!(r.output, CmdOutput::None);
+    assert_eq!(r.exit, ExitCode::Ok);
+    let r2 = cmd_leader_passthrough("claude", &["--help".into()], Path::new(".")).unwrap();
+    assert_eq!(r2.output, CmdOutput::None);
+    let r3 = cmd_leader_passthrough("copilot", &["--help".into()], Path::new(".")).unwrap();
+    assert_eq!(r3.output, CmdOutput::None);
+}
+
+#[test]
+fn cmd_leader_passthrough_maps_copilot_provider() {
+    assert_eq!(
+        leader_passthrough_provider("codex"),
+        crate::model::enums::Provider::Codex
+    );
+    assert_eq!(
+        leader_passthrough_provider("claude"),
+        crate::model::enums::Provider::ClaudeCode
+    );
+    assert_eq!(
+        leader_passthrough_provider("copilot"),
+        crate::model::enums::Provider::Copilot
+    );
+}