@team-agent/installer 0.5.128 → 0.6.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (436) hide show
  1. package/README.md +4 -4
  2. package/README.zh.md +1 -1
  3. package/package.json +4 -8
  4. package/skills/team-agent/SKILL.md +37 -20
  5. package/skills/team-agent/command-coverage.json +169 -183
  6. package/skills/team-agent/docs/reference/team-agent-operator.md +64 -30
  7. package/skills/team-agent/references/recovery-runbook.md +1 -1
  8. package/skills/team-agent/references/team-agent-operator.md +64 -30
  9. package/templates/team_state.md +1 -1
  10. package/Cargo.lock +0 -1063
  11. package/Cargo.toml +0 -36
  12. package/crates/team-agent/Cargo.toml +0 -69
  13. package/crates/team-agent/src/app_server_test_support.rs +0 -258
  14. package/crates/team-agent/src/cli/adapters.rs +0 -1288
  15. package/crates/team-agent/src/cli/arguments.rs +0 -405
  16. package/crates/team-agent/src/cli/attach_app_server_leader.rs +0 -98
  17. package/crates/team-agent/src/cli/diagnose.rs +0 -1721
  18. package/crates/team-agent/src/cli/emit.rs +0 -2930
  19. package/crates/team-agent/src/cli/grok_slot.rs +0 -384
  20. package/crates/team-agent/src/cli/helpers.rs +0 -91
  21. package/crates/team-agent/src/cli/intent/runtime.rs +0 -1216
  22. package/crates/team-agent/src/cli/intent/runtime_tests.rs +0 -912
  23. package/crates/team-agent/src/cli/intent/tests.rs +0 -689
  24. package/crates/team-agent/src/cli/intent.rs +0 -664
  25. package/crates/team-agent/src/cli/leader.rs +0 -300
  26. package/crates/team-agent/src/cli/leader_prompt.rs +0 -261
  27. package/crates/team-agent/src/cli/leaders.rs +0 -418
  28. package/crates/team-agent/src/cli/mod.rs +0 -6545
  29. package/crates/team-agent/src/cli/models.rs +0 -1206
  30. package/crates/team-agent/src/cli/named_address.rs +0 -1651
  31. package/crates/team-agent/src/cli/profile.rs +0 -342
  32. package/crates/team-agent/src/cli/route.rs +0 -212
  33. package/crates/team-agent/src/cli/schedule.rs +0 -175
  34. package/crates/team-agent/src/cli/send/coordinator.rs +0 -164
  35. package/crates/team-agent/src/cli/send/mailbox.rs +0 -145
  36. package/crates/team-agent/src/cli/send/persist.rs +0 -156
  37. package/crates/team-agent/src/cli/send/presentation.rs +0 -370
  38. package/crates/team-agent/src/cli/send/resolve.rs +0 -573
  39. package/crates/team-agent/src/cli/send.rs +0 -199
  40. package/crates/team-agent/src/cli/shutdown_socket.rs +0 -288
  41. package/crates/team-agent/src/cli/spec.rs +0 -165
  42. package/crates/team-agent/src/cli/status.rs +0 -280
  43. package/crates/team-agent/src/cli/status_port/agents.rs +0 -358
  44. package/crates/team-agent/src/cli/status_port/approvals.rs +0 -79
  45. package/crates/team-agent/src/cli/status_port/brief.rs +0 -1981
  46. package/crates/team-agent/src/cli/status_port/compact.rs +0 -240
  47. package/crates/team-agent/src/cli/status_port/format.rs +0 -146
  48. package/crates/team-agent/src/cli/status_port/inbox.rs +0 -62
  49. package/crates/team-agent/src/cli/status_port/runtime.rs +0 -197
  50. package/crates/team-agent/src/cli/status_port/snapshot.rs +0 -208
  51. package/crates/team-agent/src/cli/status_port/store.rs +0 -416
  52. package/crates/team-agent/src/cli/status_port/tests.rs +0 -90
  53. package/crates/team-agent/src/cli/status_port.rs +0 -92
  54. package/crates/team-agent/src/cli/tests/base.rs +0 -885
  55. package/crates/team-agent/src/cli/tests/divergence.rs +0 -518
  56. package/crates/team-agent/src/cli/tests/lane_c.rs +0 -453
  57. package/crates/team-agent/src/cli/tests/leader_watch.rs +0 -322
  58. package/crates/team-agent/src/cli/tests/main_preserved.rs +0 -430
  59. package/crates/team-agent/src/cli/tests/missing_subcommands.rs +0 -336
  60. package/crates/team-agent/src/cli/tests/mod.rs +0 -137
  61. package/crates/team-agent/src/cli/tests/named_address.rs +0 -761
  62. package/crates/team-agent/src/cli/tests/parser_safety.rs +0 -383
  63. package/crates/team-agent/src/cli/tests/run_delegation.rs +0 -484
  64. package/crates/team-agent/src/cli/tests/shutdown_kill_plan.rs +0 -2179
  65. package/crates/team-agent/src/cli/tests/status_brief.rs +0 -1514
  66. package/crates/team-agent/src/cli/tests/status_send.rs +0 -888
  67. package/crates/team-agent/src/cli/tests/verb_install_skill.rs +0 -93
  68. package/crates/team-agent/src/cli/tests/verb_profile.rs +0 -392
  69. package/crates/team-agent/src/cli/triage.rs +0 -234
  70. package/crates/team-agent/src/cli/types.rs +0 -591
  71. package/crates/team-agent/src/codex_app_server.rs +0 -546
  72. package/crates/team-agent/src/communication_mode/mod.rs +0 -56
  73. package/crates/team-agent/src/compiler/tests.rs +0 -827
  74. package/crates/team-agent/src/compiler.rs +0 -890
  75. package/crates/team-agent/src/conpty/backend.rs +0 -829
  76. package/crates/team-agent/src/conpty/mod.rs +0 -33
  77. package/crates/team-agent/src/contract_runtime/backend.rs +0 -1744
  78. package/crates/team-agent/src/contract_runtime/commands.rs +0 -671
  79. package/crates/team-agent/src/contract_runtime/config.rs +0 -364
  80. package/crates/team-agent/src/contract_runtime/config_tests.rs +0 -76
  81. package/crates/team-agent/src/contract_runtime/discovery.rs +0 -449
  82. package/crates/team-agent/src/contract_runtime/fork.rs +0 -361
  83. package/crates/team-agent/src/contract_runtime/forward.rs +0 -288
  84. package/crates/team-agent/src/contract_runtime/framework.rs +0 -367
  85. package/crates/team-agent/src/contract_runtime/mcp.rs +0 -394
  86. package/crates/team-agent/src/contract_runtime/mod.rs +0 -17
  87. package/crates/team-agent/src/contract_runtime/prompt.rs +0 -216
  88. package/crates/team-agent/src/contract_runtime/pump.rs +0 -271
  89. package/crates/team-agent/src/contract_runtime/registry.rs +0 -553
  90. package/crates/team-agent/src/contract_runtime/workspace.rs +0 -228
  91. package/crates/team-agent/src/coordinator/backoff.rs +0 -741
  92. package/crates/team-agent/src/coordinator/conpty_shim.rs +0 -805
  93. package/crates/team-agent/src/coordinator/health.rs +0 -1185
  94. package/crates/team-agent/src/coordinator/mod.rs +0 -119
  95. package/crates/team-agent/src/coordinator/orphan.rs +0 -110
  96. package/crates/team-agent/src/coordinator/runtime_detectors.rs +0 -798
  97. package/crates/team-agent/src/coordinator/runtime_observation.rs +0 -84
  98. package/crates/team-agent/src/coordinator/steps/abnormal.rs +0 -2309
  99. package/crates/team-agent/src/coordinator/steps/delivery.rs +0 -15
  100. package/crates/team-agent/src/coordinator/steps/health_sync.rs +0 -15
  101. package/crates/team-agent/src/coordinator/steps/mod.rs +0 -126
  102. package/crates/team-agent/src/coordinator/steps/persist.rs +0 -15
  103. package/crates/team-agent/src/coordinator/steps/runtime_prompts.rs +0 -15
  104. package/crates/team-agent/src/coordinator/steps/session_gate.rs +0 -16
  105. package/crates/team-agent/src/coordinator/tests/a0_lostupdate.rs +0 -158
  106. package/crates/team-agent/src/coordinator/tests/abnormal.rs +0 -312
  107. package/crates/team-agent/src/coordinator/tests/api_error_recovery.rs +0 -300
  108. package/crates/team-agent/src/coordinator/tests/basics.rs +0 -211
  109. package/crates/team-agent/src/coordinator/tests/daemon.rs +0 -514
  110. package/crates/team-agent/src/coordinator/tests/energy.rs +0 -549
  111. package/crates/team-agent/src/coordinator/tests/health_sync.rs +0 -503
  112. package/crates/team-agent/src/coordinator/tests/main_preserved.rs +0 -186
  113. package/crates/team-agent/src/coordinator/tests/mod.rs +0 -295
  114. package/crates/team-agent/src/coordinator/tests/s3_bounded.rs +0 -207
  115. package/crates/team-agent/src/coordinator/tests/spine.rs +0 -308
  116. package/crates/team-agent/src/coordinator/tests/takeover.rs +0 -286
  117. package/crates/team-agent/src/coordinator/tests/tick_core.rs +0 -237
  118. package/crates/team-agent/src/coordinator/tick.rs +0 -3024
  119. package/crates/team-agent/src/coordinator/types.rs +0 -540
  120. package/crates/team-agent/src/db/agent_health_capture.rs +0 -126
  121. package/crates/team-agent/src/db/message_store.rs +0 -1527
  122. package/crates/team-agent/src/db/migration.rs +0 -984
  123. package/crates/team-agent/src/db/mod.rs +0 -26
  124. package/crates/team-agent/src/db/schema.rs +0 -663
  125. package/crates/team-agent/src/diagnose/comms.rs +0 -242
  126. package/crates/team-agent/src/diagnose/mod.rs +0 -44
  127. package/crates/team-agent/src/diagnose/orphans.rs +0 -889
  128. package/crates/team-agent/src/direct_delivery.rs +0 -368
  129. package/crates/team-agent/src/event_log.rs +0 -502
  130. package/crates/team-agent/src/fake_worker.rs +0 -303
  131. package/crates/team-agent/src/inbox_store.rs +0 -169
  132. package/crates/team-agent/src/kill_audit.rs +0 -106
  133. package/crates/team-agent/src/layout/manager.rs +0 -248
  134. package/crates/team-agent/src/layout/mod.rs +0 -36
  135. package/crates/team-agent/src/layout/overlay.rs +0 -134
  136. package/crates/team-agent/src/layout/placement.rs +0 -52
  137. package/crates/team-agent/src/layout/recovery.rs +0 -106
  138. package/crates/team-agent/src/layout/runtime_sessions.rs +0 -317
  139. package/crates/team-agent/src/layout/sessions.rs +0 -294
  140. package/crates/team-agent/src/layout/tmux_endpoint.rs +0 -165
  141. package/crates/team-agent/src/layout/worker_env.rs +0 -721
  142. package/crates/team-agent/src/layout/worker_window_helpers.rs +0 -37
  143. package/crates/team-agent/src/leader/helpers.rs +0 -178
  144. package/crates/team-agent/src/leader/incident.rs +0 -6
  145. package/crates/team-agent/src/leader/lease.rs +0 -3356
  146. package/crates/team-agent/src/leader/mod.rs +0 -104
  147. package/crates/team-agent/src/leader/owner_bind.rs +0 -400
  148. package/crates/team-agent/src/leader/prompt.rs +0 -905
  149. package/crates/team-agent/src/leader/provider_attribution.rs +0 -247
  150. package/crates/team-agent/src/leader/rediscover/tests.rs +0 -689
  151. package/crates/team-agent/src/leader/rediscover.rs +0 -1192
  152. package/crates/team-agent/src/leader/registry.rs +0 -888
  153. package/crates/team-agent/src/leader/start.rs +0 -4501
  154. package/crates/team-agent/src/leader/takeover.rs +0 -65
  155. package/crates/team-agent/src/leader/tests/basics.rs +0 -337
  156. package/crates/team-agent/src/leader/tests/byte_findings.rs +0 -355
  157. package/crates/team-agent/src/leader/tests/claim_leader_mailbox_flush_contract.rs +0 -544
  158. package/crates/team-agent/src/leader/tests/historical_inventory_upgrade_gate_red.rs +0 -624
  159. package/crates/team-agent/src/leader/tests/identity.rs +0 -465
  160. package/crates/team-agent/src/leader/tests/identity_session_names.rs +0 -42
  161. package/crates/team-agent/src/leader/tests/idle.rs +0 -113
  162. package/crates/team-agent/src/leader/tests/lease_api.rs +0 -520
  163. package/crates/team-agent/src/leader/tests/lease_claim.rs +0 -629
  164. package/crates/team-agent/src/leader/tests/mod.rs +0 -106
  165. package/crates/team-agent/src/leader/tests/prompt_contract.rs +0 -268
  166. package/crates/team-agent/src/leader/tests/rediscover.rs +0 -403
  167. package/crates/team-agent/src/leader/tests/rehomed_env.rs +0 -83
  168. package/crates/team-agent/src/leader/tests/team_in_team_state_scope_red.rs +0 -1273
  169. package/crates/team-agent/src/leader/tests/terminal_and_replay_vs_rerender_invariants_red.rs +0 -417
  170. package/crates/team-agent/src/leader/tests/wake_start_owner.rs +0 -168
  171. package/crates/team-agent/src/leader/types.rs +0 -534
  172. package/crates/team-agent/src/lib.rs +0 -147
  173. package/crates/team-agent/src/lifecycle/helpers.rs +0 -212
  174. package/crates/team-agent/src/lifecycle/launch/add_agent.rs +0 -881
  175. package/crates/team-agent/src/lifecycle/launch/add_agent_state.rs +0 -598
  176. package/crates/team-agent/src/lifecycle/launch/agent_state.rs +0 -332
  177. package/crates/team-agent/src/lifecycle/launch/clone_agent.rs +0 -204
  178. package/crates/team-agent/src/lifecycle/launch/fork_agent.rs +0 -107
  179. package/crates/team-agent/src/lifecycle/launch/fork_entry.rs +0 -144
  180. package/crates/team-agent/src/lifecycle/launch/identity.rs +0 -674
  181. package/crates/team-agent/src/lifecycle/launch/layout.rs +0 -350
  182. package/crates/team-agent/src/lifecycle/launch/leader_context.rs +0 -589
  183. package/crates/team-agent/src/lifecycle/launch/mcp_config.rs +0 -160
  184. package/crates/team-agent/src/lifecycle/launch/ownership.rs +0 -105
  185. package/crates/team-agent/src/lifecycle/launch/pi_mcp.rs +0 -899
  186. package/crates/team-agent/src/lifecycle/launch/pi_mcp_extension.js +0 -225
  187. package/crates/team-agent/src/lifecycle/launch/plan.rs +0 -269
  188. package/crates/team-agent/src/lifecycle/launch/quick_start.rs +0 -5200
  189. package/crates/team-agent/src/lifecycle/launch/quick_start_transport.rs +0 -368
  190. package/crates/team-agent/src/lifecycle/launch/readiness.rs +0 -519
  191. package/crates/team-agent/src/lifecycle/launch/role_source.rs +0 -287
  192. package/crates/team-agent/src/lifecycle/launch/spawn.rs +0 -473
  193. package/crates/team-agent/src/lifecycle/launch/spec_state.rs +0 -801
  194. package/crates/team-agent/src/lifecycle/launch/state_projection.rs +0 -624
  195. package/crates/team-agent/src/lifecycle/launch/worker_env.rs +0 -558
  196. package/crates/team-agent/src/lifecycle/launch.rs +0 -557
  197. package/crates/team-agent/src/lifecycle/lock.rs +0 -350
  198. package/crates/team-agent/src/lifecycle/mod.rs +0 -79
  199. package/crates/team-agent/src/lifecycle/pane_input_lock.rs +0 -239
  200. package/crates/team-agent/src/lifecycle/profile_launch.rs +0 -1067
  201. package/crates/team-agent/src/lifecycle/profile_smoke.rs +0 -557
  202. package/crates/team-agent/src/lifecycle/restart/agent.rs +0 -2199
  203. package/crates/team-agent/src/lifecycle/restart/avatar.rs +0 -1798
  204. package/crates/team-agent/src/lifecycle/restart/claude_fork.rs +0 -163
  205. package/crates/team-agent/src/lifecycle/restart/common.rs +0 -2362
  206. package/crates/team-agent/src/lifecycle/restart/orchestrator.rs +0 -65
  207. package/crates/team-agent/src/lifecycle/restart/preflight.rs +0 -113
  208. package/crates/team-agent/src/lifecycle/restart/rebuild.rs +0 -5135
  209. package/crates/team-agent/src/lifecycle/restart/remove.rs +0 -1504
  210. package/crates/team-agent/src/lifecycle/restart/selection.rs +0 -559
  211. package/crates/team-agent/src/lifecycle/restart/team_state.rs +0 -329
  212. package/crates/team-agent/src/lifecycle/restart.rs +0 -227
  213. package/crates/team-agent/src/lifecycle/role_config.rs +0 -1230
  214. package/crates/team-agent/src/lifecycle/tests/acceptance_b_batch_red.rs +0 -1021
  215. package/crates/team-agent/src/lifecycle/tests/agent_ops.rs +0 -1205
  216. package/crates/team-agent/src/lifecycle/tests/b0_legacy_snapshot_nonauthority_contract.rs +0 -265
  217. package/crates/team-agent/src/lifecycle/tests/b0_reader_hideone_audit_contract.rs +0 -490
  218. package/crates/team-agent/src/lifecycle/tests/behavioral_diff_264_red.rs +0 -656
  219. package/crates/team-agent/src/lifecycle/tests/claude_compatible_config_red.rs +0 -325
  220. package/crates/team-agent/src/lifecycle/tests/claude_profile_launch_red.rs +0 -447
  221. package/crates/team-agent/src/lifecycle/tests/cli_argv_routing_red.rs +0 -1638
  222. package/crates/team-agent/src/lifecycle/tests/clone_agent_preserves_source_tools.rs +0 -427
  223. package/crates/team-agent/src/lifecycle/tests/clone_fork_copilot_perms_red.rs +0 -770
  224. package/crates/team-agent/src/lifecycle/tests/communication_mode_runtime_contract_red.rs +0 -419
  225. package/crates/team-agent/src/lifecycle/tests/copilot_provider_red.rs +0 -2035
  226. package/crates/team-agent/src/lifecycle/tests/core.rs +0 -1327
  227. package/crates/team-agent/src/lifecycle/tests/f032_startup_prompt_best_effort_red.rs +0 -315
  228. package/crates/team-agent/src/lifecycle/tests/fixtures/pi_list_models_g0.stdout.txt +0 -222
  229. package/crates/team-agent/src/lifecycle/tests/fixtures/pi_list_models_spaced_ids.stdout.txt +0 -9
  230. package/crates/team-agent/src/lifecycle/tests/fixtures/pi_native_mcp_host.mjs +0 -72
  231. package/crates/team-agent/src/lifecycle/tests/gate_fixtures.rs +0 -562
  232. package/crates/team-agent/src/lifecycle/tests/grok_require_explicit_model_red.rs +0 -110
  233. package/crates/team-agent/src/lifecycle/tests/harvest2_a_batch_red.rs +0 -512
  234. package/crates/team-agent/src/lifecycle/tests/host_cotenant_death_p0_contract.rs +0 -921
  235. package/crates/team-agent/src/lifecycle/tests/issue238_codex_effort_contract.rs +0 -68
  236. package/crates/team-agent/src/lifecycle/tests/lane_ops.rs +0 -1851
  237. package/crates/team-agent/src/lifecycle/tests/launch_spawn.rs +0 -3983
  238. package/crates/team-agent/src/lifecycle/tests/lifecycle_lock.rs +0 -339
  239. package/crates/team-agent/src/lifecycle/tests/lifecycle_rollback_red.rs +0 -596
  240. package/crates/team-agent/src/lifecycle/tests/main_preserved.rs +0 -513
  241. package/crates/team-agent/src/lifecycle/tests/mcp_tool_name_format_red.rs +0 -69
  242. package/crates/team-agent/src/lifecycle/tests/phase_b_contracts.rs +0 -824
  243. package/crates/team-agent/src/lifecycle/tests/phase_golden.rs +0 -723
  244. package/crates/team-agent/src/lifecycle/tests/pi_catalog_red.rs +0 -164
  245. package/crates/team-agent/src/lifecycle/tests/pi_command_red.rs +0 -200
  246. package/crates/team-agent/src/lifecycle/tests/pi_compiler_red.rs +0 -210
  247. package/crates/team-agent/src/lifecycle/tests/pi_dual_entry_red.rs +0 -527
  248. package/crates/team-agent/src/lifecycle/tests/pi_executable_mcp_red.rs +0 -1062
  249. package/crates/team-agent/src/lifecycle/tests/pi_fork_session_inheritance_red.rs +0 -1419
  250. package/crates/team-agent/src/lifecycle/tests/pi_lifecycle_doctor_red.rs +0 -98
  251. package/crates/team-agent/src/lifecycle/tests/pi_native_mcp_capability_red.rs +0 -550
  252. package/crates/team-agent/src/lifecycle/tests/pi_session_delivery_red.rs +0 -226
  253. package/crates/team-agent/src/lifecycle/tests/quick_start_worker_readiness_red.rs +0 -332
  254. package/crates/team-agent/src/lifecycle/tests/realmachine_clusters_1_6_red.rs +0 -786
  255. package/crates/team-agent/src/lifecycle/tests/realmachine_residual_g1_g4_red.rs +0 -648
  256. package/crates/team-agent/src/lifecycle/tests/restart.rs +0 -185
  257. package/crates/team-agent/src/lifecycle/tests/restart_build_before_destroy_0540_contract.rs +0 -1053
  258. package/crates/team-agent/src/lifecycle/tests/restart_liveness_red.rs +0 -679
  259. package/crates/team-agent/src/lifecycle/tests/restart_rebind_hotfix_252_red.rs +0 -1126
  260. package/crates/team-agent/src/lifecycle/tests/restart_session_capture_red.rs +0 -153
  261. package/crates/team-agent/src/lifecycle/tests/resume_recover_red.rs +0 -427
  262. package/crates/team-agent/src/lifecycle/tests/stale_team_saveconflict_contract.rs +0 -431
  263. package/crates/team-agent/src/lifecycle/tests/startup_latency_contract.rs +0 -1066
  264. package/crates/team-agent/src/lifecycle/tests/status_credential_redaction_contract.rs +0 -876
  265. package/crates/team-agent/src/lifecycle/tests/subprep_codex_trust_roundtrip_red.rs +0 -1026
  266. package/crates/team-agent/src/lifecycle/tests/swallow_batch4_semantics_red.rs +0 -342
  267. package/crates/team-agent/src/lifecycle/tests/team_in_team_identity_scope_red.rs +0 -543
  268. package/crates/team-agent/src/lifecycle/tests/team_in_team_sibling_quick_start_red.rs +0 -1103
  269. package/crates/team-agent/src/lifecycle/tests/team_in_team_state_scope_red.rs +0 -1276
  270. package/crates/team-agent/src/lifecycle/tests/team_key_retirement_roster_red.rs +0 -145
  271. package/crates/team-agent/src/lifecycle/tests/team_key_retirement_txn_red.rs +0 -603
  272. package/crates/team-agent/src/lifecycle/tests/test_isolation_escape_contract.rs +0 -936
  273. package/crates/team-agent/src/lifecycle/tests/upgrade_compat_0211_red.rs +0 -970
  274. package/crates/team-agent/src/lifecycle/tests/verify_rs031_window_consistency_red.rs +0 -995
  275. package/crates/team-agent/src/lifecycle/tests/worker_spawn_env_red.rs +0 -836
  276. package/crates/team-agent/src/lifecycle/tests.rs +0 -105
  277. package/crates/team-agent/src/lifecycle/types.rs +0 -877
  278. package/crates/team-agent/src/lifecycle/worker_command_context.rs +0 -363
  279. package/crates/team-agent/src/main.rs +0 -52
  280. package/crates/team-agent/src/mcp_server/helpers.rs +0 -510
  281. package/crates/team-agent/src/mcp_server/lifecycle_tools/mod.rs +0 -6
  282. package/crates/team-agent/src/mcp_server/lifecycle_tools/state_status.rs +0 -43
  283. package/crates/team-agent/src/mcp_server/mod.rs +0 -119
  284. package/crates/team-agent/src/mcp_server/normalize.rs +0 -485
  285. package/crates/team-agent/src/mcp_server/readiness.rs +0 -527
  286. package/crates/team-agent/src/mcp_server/readiness_tests.rs +0 -348
  287. package/crates/team-agent/src/mcp_server/tests/golden.rs +0 -285
  288. package/crates/team-agent/src/mcp_server/tests/normalize.rs +0 -247
  289. package/crates/team-agent/src/mcp_server/tests/scoped.rs +0 -158
  290. package/crates/team-agent/src/mcp_server/tests/send.rs +0 -353
  291. package/crates/team-agent/src/mcp_server/tests/tools.rs +0 -341
  292. package/crates/team-agent/src/mcp_server/tests/wire.rs +0 -254
  293. package/crates/team-agent/src/mcp_server/tests.rs +0 -43
  294. package/crates/team-agent/src/mcp_server/tools.rs +0 -889
  295. package/crates/team-agent/src/mcp_server/types.rs +0 -396
  296. package/crates/team-agent/src/mcp_server/wire.rs +0 -867
  297. package/crates/team-agent/src/messaging/activity.rs +0 -461
  298. package/crates/team-agent/src/messaging/address.rs +0 -87
  299. package/crates/team-agent/src/messaging/delivery.rs +0 -3727
  300. package/crates/team-agent/src/messaging/delivery_consumption_tests.rs +0 -234
  301. package/crates/team-agent/src/messaging/enter_rescue.rs +0 -362
  302. package/crates/team-agent/src/messaging/enter_rescue_tests.rs +0 -633
  303. package/crates/team-agent/src/messaging/helpers.rs +0 -336
  304. package/crates/team-agent/src/messaging/leader_channel.rs +0 -287
  305. package/crates/team-agent/src/messaging/leader_receiver.rs +0 -786
  306. package/crates/team-agent/src/messaging/mod.rs +0 -167
  307. package/crates/team-agent/src/messaging/persist.rs +0 -377
  308. package/crates/team-agent/src/messaging/presentation.rs +0 -417
  309. package/crates/team-agent/src/messaging/reminders.rs +0 -316
  310. package/crates/team-agent/src/messaging/results/collection_tests.rs +0 -719
  311. package/crates/team-agent/src/messaging/results.rs +0 -1415
  312. package/crates/team-agent/src/messaging/scheduler.rs +0 -223
  313. package/crates/team-agent/src/messaging/selftest.rs +0 -315
  314. package/crates/team-agent/src/messaging/send.rs +0 -981
  315. package/crates/team-agent/src/messaging/tests/basic.rs +0 -346
  316. package/crates/team-agent/src/messaging/tests/dup_inject.rs +0 -657
  317. package/crates/team-agent/src/messaging/tests/e23.rs +0 -49
  318. package/crates/team-agent/src/messaging/tests/leader_channel.rs +0 -169
  319. package/crates/team-agent/src/messaging/tests/leader_inject_acceptance.rs +0 -817
  320. package/crates/team-agent/src/messaging/tests/main_preserved.rs +0 -85
  321. package/crates/team-agent/src/messaging/tests/mod.rs +0 -306
  322. package/crates/team-agent/src/messaging/tests/runtime.rs +0 -3549
  323. package/crates/team-agent/src/messaging/tests/spine.rs +0 -853
  324. package/crates/team-agent/src/messaging/tests/wave2.rs +0 -381
  325. package/crates/team-agent/src/messaging/trust.rs +0 -215
  326. package/crates/team-agent/src/messaging/types.rs +0 -472
  327. package/crates/team-agent/src/messaging/wait.rs +0 -366
  328. package/crates/team-agent/src/messaging/watchers.rs +0 -916
  329. package/crates/team-agent/src/model/enums.rs +0 -356
  330. package/crates/team-agent/src/model/errors.rs +0 -18
  331. package/crates/team-agent/src/model/ids.rs +0 -165
  332. package/crates/team-agent/src/model/mod.rs +0 -29
  333. package/crates/team-agent/src/model/name_similarity.rs +0 -252
  334. package/crates/team-agent/src/model/pane_authority_refusal.rs +0 -359
  335. package/crates/team-agent/src/model/paths.rs +0 -257
  336. package/crates/team-agent/src/model/routing.rs +0 -387
  337. package/crates/team-agent/src/model/spec.rs +0 -1184
  338. package/crates/team-agent/src/model/task_graph.rs +0 -321
  339. package/crates/team-agent/src/model/testdata/fuzz.golden.yaml +0 -43
  340. package/crates/team-agent/src/model/testdata/fuzz.yaml +0 -43
  341. package/crates/team-agent/src/model/testdata/spec_invalid_a.yaml +0 -209
  342. package/crates/team-agent/src/model/testdata/team.spec.golden.yaml +0 -208
  343. package/crates/team-agent/src/model/testdata/team.spec.yaml +0 -208
  344. package/crates/team-agent/src/model/yaml/tests.rs +0 -188
  345. package/crates/team-agent/src/model/yaml.rs +0 -802
  346. package/crates/team-agent/src/os_probe.rs +0 -280
  347. package/crates/team-agent/src/packaging/install.rs +0 -219
  348. package/crates/team-agent/src/packaging/migrate.rs +0 -38
  349. package/crates/team-agent/src/packaging/mod.rs +0 -91
  350. package/crates/team-agent/src/packaging/repair.rs +0 -33
  351. package/crates/team-agent/src/packaging/tests.rs +0 -822
  352. package/crates/team-agent/src/packaging/types.rs +0 -417
  353. package/crates/team-agent/src/platform/argv.rs +0 -331
  354. package/crates/team-agent/src/platform/errors.rs +0 -104
  355. package/crates/team-agent/src/platform/file_lock.rs +0 -279
  356. package/crates/team-agent/src/platform/mod.rs +0 -5
  357. package/crates/team-agent/src/platform/process.rs +0 -545
  358. package/crates/team-agent/src/provider/adapter.rs +0 -1150
  359. package/crates/team-agent/src/provider/adapters/claude.rs +0 -78
  360. package/crates/team-agent/src/provider/adapters/claude_fork.rs +0 -131
  361. package/crates/team-agent/src/provider/adapters/copilot.rs +0 -75
  362. package/crates/team-agent/src/provider/adapters/copilot_fork.rs +0 -307
  363. package/crates/team-agent/src/provider/adapters/fake.rs +0 -18
  364. package/crates/team-agent/src/provider/adapters/mod.rs +0 -30
  365. package/crates/team-agent/src/provider/adapters/pi.rs +0 -106
  366. package/crates/team-agent/src/provider/approvals/mod.rs +0 -3
  367. package/crates/team-agent/src/provider/approvals/parsing.rs +0 -586
  368. package/crates/team-agent/src/provider/approvals/runtime_prompts.rs +0 -205
  369. package/crates/team-agent/src/provider/argv_route.rs +0 -405
  370. package/crates/team-agent/src/provider/bypass_flags.rs +0 -116
  371. package/crates/team-agent/src/provider/classify.rs +0 -708
  372. package/crates/team-agent/src/provider/command_helpers.rs +0 -45
  373. package/crates/team-agent/src/provider/faults.rs +0 -165
  374. package/crates/team-agent/src/provider/helpers.rs +0 -52
  375. package/crates/team-agent/src/provider/mod.rs +0 -78
  376. package/crates/team-agent/src/provider/model_catalog.rs +0 -910
  377. package/crates/team-agent/src/provider/session/capture.rs +0 -2731
  378. package/crates/team-agent/src/provider/session/context_fork/claude.rs +0 -123
  379. package/crates/team-agent/src/provider/session/context_fork/outcome.rs +0 -172
  380. package/crates/team-agent/src/provider/session/context_fork.rs +0 -396
  381. package/crates/team-agent/src/provider/session/mod.rs +0 -36
  382. package/crates/team-agent/src/provider/session/resume.rs +0 -269
  383. package/crates/team-agent/src/provider/session_scan/claude.rs +0 -523
  384. package/crates/team-agent/src/provider/session_scan/common/tests.rs +0 -316
  385. package/crates/team-agent/src/provider/session_scan/common.rs +0 -654
  386. package/crates/team-agent/src/provider/session_scan/copilot.rs +0 -280
  387. package/crates/team-agent/src/provider/session_scan/pi.rs +0 -185
  388. package/crates/team-agent/src/provider/session_scan.rs +0 -71
  389. package/crates/team-agent/src/provider/startup_prompt.rs +0 -757
  390. package/crates/team-agent/src/provider/submit_now.rs +0 -71
  391. package/crates/team-agent/src/provider/testdata/copilot-ready-marker.txt +0 -5
  392. package/crates/team-agent/src/provider/testdata/copilot-trust-prompt.txt +0 -19
  393. package/crates/team-agent/src/provider/testdata/grok-models-authenticated.stdout +0 -9
  394. package/crates/team-agent/src/provider/testdata/grok-models-unauthenticated.stdout +0 -7
  395. package/crates/team-agent/src/provider/tests/adapter.rs +0 -441
  396. package/crates/team-agent/src/provider/tests/classify.rs +0 -148
  397. package/crates/team-agent/src/provider/tests/command_helpers.rs +0 -35
  398. package/crates/team-agent/src/provider/tests/copilot_fork.rs +0 -191
  399. package/crates/team-agent/src/provider/tests/faults.rs +0 -200
  400. package/crates/team-agent/src/provider/tests/idle.rs +0 -177
  401. package/crates/team-agent/src/provider/tests/wire.rs +0 -213
  402. package/crates/team-agent/src/provider/tests.rs +0 -32
  403. package/crates/team-agent/src/provider/types.rs +0 -529
  404. package/crates/team-agent/src/provider/wire.rs +0 -394
  405. package/crates/team-agent/src/redaction.rs +0 -259
  406. package/crates/team-agent/src/state/abnormal_watch/tests/mod.rs +0 -248
  407. package/crates/team-agent/src/state/abnormal_watch.rs +0 -144
  408. package/crates/team-agent/src/state/identity.rs +0 -914
  409. package/crates/team-agent/src/state/identity_keys.rs +0 -132
  410. package/crates/team-agent/src/state/mod.rs +0 -74
  411. package/crates/team-agent/src/state/owner_gate.rs +0 -482
  412. package/crates/team-agent/src/state/ownership.rs +0 -563
  413. package/crates/team-agent/src/state/paths.rs +0 -395
  414. package/crates/team-agent/src/state/persist.rs +0 -3811
  415. package/crates/team-agent/src/state/projection.rs +0 -1508
  416. package/crates/team-agent/src/state/repository/intent.rs +0 -14
  417. package/crates/team-agent/src/state/repository/tests.rs +0 -184
  418. package/crates/team-agent/src/state/repository.rs +0 -866
  419. package/crates/team-agent/src/state/selector.rs +0 -160
  420. package/crates/team-agent/src/state/testdata/state-rich.canonical.json +0 -133
  421. package/crates/team-agent/src/test_support/models_timeout_fixture.rs +0 -144
  422. package/crates/team-agent/src/tmux_backend/enter_rescue.rs +0 -325
  423. package/crates/team-agent/src/tmux_backend/enter_rescue_tests.rs +0 -432
  424. package/crates/team-agent/src/tmux_backend/native_input.rs +0 -513
  425. package/crates/team-agent/src/tmux_backend/native_input_tests.rs +0 -742
  426. package/crates/team-agent/src/tmux_backend/tests.rs +0 -4103
  427. package/crates/team-agent/src/tmux_backend.rs +0 -4492
  428. package/crates/team-agent/src/topology.rs +0 -537
  429. package/crates/team-agent/src/transport/enter_rescue.rs +0 -166
  430. package/crates/team-agent/src/transport/native_input.rs +0 -491
  431. package/crates/team-agent/src/transport/test_support.rs +0 -743
  432. package/crates/team-agent/src/transport/tests/behavior.rs +0 -326
  433. package/crates/team-agent/src/transport/tests/mod.rs +0 -194
  434. package/crates/team-agent/src/transport/tests/wire.rs +0 -574
  435. package/crates/team-agent/src/transport.rs +0 -1655
  436. package/crates/team-agent/src/transport_factory.rs +0 -819
@@ -1,3549 +0,0 @@
1
- use super::*;
2
- use crate::transport::test_support::OfflineTransport;
3
- use crate::transport::{PaneId, Target};
4
-
5
- fn pane_info(pane_id: &str, session: &str, window: &str) -> PaneInfo {
6
- PaneInfo {
7
- pane_id: PaneId::new(pane_id),
8
- session: SessionName::new(session),
9
- window_index: None,
10
- window_name: Some(WindowName::new(window)),
11
- pane_index: None,
12
- tty: None,
13
- current_command: None,
14
- current_path: None,
15
- active: true,
16
- pane_pid: None,
17
- leader_env: BTreeMap::new(),
18
- }
19
- }
20
-
21
- // ════════════════════════════════════════════════════════════════════════
22
- // GROUP E — legacy diagnostics may only advance an existing durable row.
23
- // ════════════════════════════════════════════════════════════════════════
24
-
25
- #[test]
26
- fn fail_leader_delivery_without_message_id_does_not_invent_a_row() {
27
- let ws = tmp_ws("faillead");
28
- let payload = json(serde_json::json!({
29
- "to": "leader", "content": "hi", "sender": "coordinator"
30
- }));
31
- let out = fail_leader_delivery(
32
- &ws,
33
- &payload,
34
- DeliveryRefusal::LeaderNotAttached,
35
- Some("No direct leader tmux pane is attached. Run team-agent attach-leader."),
36
- )
37
- .unwrap();
38
- assert!(!out.ok);
39
- assert_eq!(out.status, DeliveryStatus::FallbackLog);
40
- assert_eq!(out.reason, Some(DeliveryRefusal::LeaderNotAttached));
41
- assert_eq!(out.message_id, None);
42
- assert_ne!(out.status, DeliveryStatus::Delivered);
43
- let store = MessageStore::open(&ws).unwrap();
44
- let connection = crate::db::schema::open_db(store.db_path()).unwrap();
45
- let rows: i64 = connection
46
- .query_row("select count(*) from messages", [], |row| row.get(0))
47
- .unwrap();
48
- assert_eq!(rows, 0, "diagnostics cannot create a fallback message row");
49
- }
50
-
51
- // ════════════════════════════════════════════════════════════════════════
52
- // GROUP F — session_drift_refusal: None-vs-refused fallthrough chain.
53
- // session_drift.py:69-91.
54
- // ════════════════════════════════════════════════════════════════════════
55
-
56
- #[test]
57
- fn session_drift_refusal_none_for_no_target_leader_or_broadcast() {
58
- let ws = tmp_ws("driftnone");
59
- let log = EventLog::new(&ws);
60
- let state = json(serde_json::json!({"agents": {}}));
61
- // target == leader_id → None (no refusal).
62
- assert!(
63
- session_drift_refusal(&state, "leader", "leader", "s", None, &log)
64
- .unwrap()
65
- .is_none()
66
- );
67
- // target == "*" (broadcast) → None.
68
- assert!(
69
- session_drift_refusal(&state, "*", "leader", "s", None, &log)
70
- .unwrap()
71
- .is_none()
72
- );
73
- }
74
-
75
- #[test]
76
- fn session_drift_refusal_none_when_status_not_drift() {
77
- let ws = tmp_ws("driftok");
78
- let log = EventLog::new(&ws);
79
- let state = json(serde_json::json!({"agents": {"w1": {"status": "idle"}}}));
80
- assert!(
81
- session_drift_refusal(&state, "w1", "leader", "s", None, &log)
82
- .unwrap()
83
- .is_none()
84
- );
85
- }
86
-
87
- #[test]
88
- fn session_drift_refusal_refuses_when_agent_in_drift() {
89
- // session_drift.py:84-91 → ok False, reason session_drift, action reset-agent.
90
- let ws = tmp_ws("driftrefuse");
91
- let log = EventLog::new(&ws);
92
- let state = json(serde_json::json!({
93
- "agents": {"w1": {"status": "session_drift",
94
- "session_drift": {"stored_session_id": "S", "actual_thread_id": "A"}}}
95
- }));
96
- let out = session_drift_refusal(&state, "w1", "leader", "leader", None, &log)
97
- .unwrap()
98
- .expect("drift agent must be refused");
99
- assert!(!out.ok);
100
- assert_eq!(out.status, DeliveryStatus::Refused);
101
- assert_eq!(out.reason, Some(DeliveryRefusal::SessionDrift));
102
- }
103
-
104
- // ════════════════════════════════════════════════════════════════════════
105
- // GROUP G — classify_agent_activity: every branch incl. the uncertain
106
- // fallthrough iron law. activity_detector.py:90-146 (golden probed).
107
- // ════════════════════════════════════════════════════════════════════════
108
-
109
- #[test]
110
- fn classify_pane_in_mode_is_uncertain_high_confidence() {
111
- let state = json(serde_json::json!({}));
112
- let a = classify_agent_activity(&state, "", true, None, None);
113
- assert_eq!(a.status, ActivityStatus::Uncertain);
114
- assert_eq!(a.confidence, 0.9);
115
- }
116
-
117
- #[test]
118
- fn classify_idle_prompt_is_idle() {
119
- // "❯ \n" matches the Claude idle prompt → idle 0.9.
120
- let state = json(serde_json::json!({}));
121
- let a = classify_agent_activity(&state, "❯ \n", false, None, None);
122
- assert_eq!(a.status, ActivityStatus::Idle);
123
- assert_eq!(a.confidence, 0.9);
124
- }
125
-
126
- #[test]
127
- fn classify_working_indicator_is_working() {
128
- let state = json(serde_json::json!({}));
129
- let a = classify_agent_activity(&state, "Working (5s)", false, None, None);
130
- assert_eq!(a.status, ActivityStatus::Working);
131
- assert_eq!(a.confidence, 0.9);
132
- }
133
-
134
- #[test]
135
- fn classify_stale_working_is_stuck() {
136
- // elapsed >= stuck_timeout (300) → stuck 0.85.
137
- let state = json(serde_json::json!({}));
138
- let a = classify_agent_activity(&state, "Working (400s)", false, None, None);
139
- assert_eq!(a.status, ActivityStatus::Stuck);
140
- assert_eq!(a.confidence, 0.85);
141
- }
142
-
143
- #[test]
144
- fn classify_no_signal_is_uncertain_never_idle() {
145
- // THE IRON LAW: no decisive prompt/working signal → uncertain 0.5, NOT idle.
146
- let state = json(serde_json::json!({}));
147
- let a = classify_agent_activity(&state, "random prose nothing", false, None, None);
148
- assert_eq!(a.status, ActivityStatus::Uncertain);
149
- assert_eq!(a.confidence, 0.5);
150
- assert_ne!(a.status, ActivityStatus::Idle);
151
- }
152
-
153
- #[test]
154
- fn classify_recent_provider_output_is_working_low_confidence() {
155
- // age <= 120 with provider/no command → working 0.7.
156
- let state = json(serde_json::json!({}));
157
- let now = chrono::Utc::now();
158
- let recent = (now - chrono::Duration::seconds(30)).to_rfc3339();
159
- let a = classify_agent_activity(&state, "prose", false, None, Some(&recent));
160
- assert_eq!(a.status, ActivityStatus::Working);
161
- assert_eq!(a.confidence, 0.7);
162
- }
163
-
164
- // STAGE-B REGRESSION RED (dispatch-to-just-launched-agent → deferred_busy never closes the round-trip).
165
- // golden activity_detector.py (classify_agent_activity): the provider IDLE PROMPT is checked FIRST as a
166
- // scrollback-position signal (C14, "provider idle prompt is the latest scrollback signal" → idle 0.9),
167
- // BEFORE the `age<=120 → working 0.7` recent-output branch (:56). Rust (activity.rs:192) fires
168
- // `recent_rfc3339(last_output_at,120) → Working` BEFORE `latest_prompt_signal` (:200), so a just-launched
169
- // agent (startup banner = recent output, but pane shows the idle prompt awaiting input) mis-classifies
170
- // WORKING → sync_agent_health writes agent_health=WORKING → recipient_is_busy → send.deferred_busy.
171
- // Golden evidence (probe): classify(idle-prompt scrollback, recent last_output_at) = idle 0.9 regardless
172
- // of active_task. FIX = reorder: latest_prompt_signal (idle/working scrollback-position) BEFORE the
173
- // last_output_at age block.
174
- #[test]
175
- fn classify_idle_prompt_beats_recent_output_for_just_launched_agent() {
176
- let state = json(serde_json::json!({}));
177
- let recent = chrono::Utc::now().to_rfc3339();
178
- let a = classify_agent_activity(
179
- &state,
180
- "codex ready\n❯ \n",
181
- false,
182
- Some("codex"),
183
- Some(&recent),
184
- );
185
- assert_eq!(
186
- a.status,
187
- ActivityStatus::Idle,
188
- "just-launched agent showing the idle prompt must classify IDLE (golden idle-prompt-position is the \
189
- latest scrollback signal, checked before the age<=120 recent-output branch), not WORKING because \
190
- the startup banner is recent (activity.rs:192 recent-output fires before latest_prompt_signal:200) \
191
- — the Stage B dispatch deferred_busy regression. got {a:?}"
192
- );
193
- assert_eq!(
194
- a.confidence, 0.9,
195
- "golden idle-prompt confidence is 0.9; got {a:?}"
196
- );
197
- }
198
-
199
- #[test]
200
- fn classify_copilot_idle_prompt_is_not_masked_by_current_command() {
201
- let state = json(serde_json::json!({}));
202
- let a = classify_agent_activity(
203
- &state,
204
- " / commands · ? help\n❯ \n",
205
- false,
206
- Some("copilot"),
207
- None,
208
- );
209
- assert_eq!(a.status, ActivityStatus::Idle);
210
- assert_eq!(a.confidence, 0.9);
211
- }
212
-
213
- // ════════════════════════════════════════════════════════════════════════
214
- // GROUP H — attempt_trust_auto_answer: own-vs-foreign realpath + fail-safe
215
- // pane-width + opt-in gate + reason byte-locks. leader_panes.py:383-470.
216
- // ════════════════════════════════════════════════════════════════════════
217
-
218
- #[test]
219
- fn trust_auto_answer_pane_id_missing_reason() {
220
- // leader_panes.py:417-424 — pane_id None → pane_id_missing (after opt-in).
221
- let ws = tmp_ws("trustpane");
222
- let log = EventLog::new(&ws);
223
- let t = NoopTransport;
224
- let out = attempt_trust_auto_answer(
225
- &ws,
226
- &t,
227
- None,
228
- "some prompt",
229
- &PaneWidthQuery::Ok { pane_width: 120 },
230
- &log,
231
- )
232
- .unwrap();
233
- assert!(!out.ok);
234
- assert!(!out.answered);
235
- assert_eq!(out.reason, "pane_id_missing");
236
- }
237
-
238
- #[test]
239
- fn trust_auto_answer_foreign_workspace_refused() {
240
- // leader_panes.py:430-444 — prompt names a FOREIGN dir → workspace_dir_mismatch,
241
- // action prompt_leader. (own-vs-foreign realpath gate.)
242
- let ws = tmp_ws("trustforeign");
243
- let log = EventLog::new(&ws);
244
- let t = NoopTransport;
245
- let pane = PaneId::new("%7");
246
- let foreign_tail = "Allow Codex to access /some/other/foreign/dir ?";
247
- let out = attempt_trust_auto_answer(
248
- &ws,
249
- &t,
250
- Some(&pane),
251
- foreign_tail,
252
- &PaneWidthQuery::Ok { pane_width: 120 },
253
- &log,
254
- )
255
- .unwrap();
256
- assert!(!out.answered);
257
- assert_eq!(out.reason, "workspace_dir_mismatch");
258
- assert_eq!(out.action.as_deref(), Some("prompt_leader"));
259
- }
260
-
261
- #[test]
262
- fn trust_auto_answer_own_workspace_realpath_equal_answers() {
263
- // Exact canonical equality of the prompt path with the workspace → answered.
264
- let ws = tmp_ws("trustown");
265
- let canonical = std::fs::canonicalize(&ws).unwrap();
266
- let log = EventLog::new(&ws);
267
- let t = NoopTransport;
268
- let pane = PaneId::new("%7");
269
- let tail = format!("Allow Codex to write to {} ?", canonical.display());
270
- let out = attempt_trust_auto_answer(
271
- &canonical,
272
- &t,
273
- Some(&pane),
274
- &tail,
275
- &PaneWidthQuery::Ok { pane_width: 240 },
276
- &log,
277
- )
278
- .unwrap();
279
- assert!(
280
- out.answered,
281
- "own-workspace realpath-equal prompt must auto-answer"
282
- );
283
- assert_eq!(out.reason, "trust_auto_answered");
284
- }
285
-
286
- // ════════════════════════════════════════════════════════════════════════
287
- // GROUP I — PaneWidthQuery fail-safe (bug-064/082): Failed NEVER carries a
288
- // default width; tmux_pane_width returns Failed on any query failure.
289
- // delivery.py:20-51.
290
- // ════════════════════════════════════════════════════════════════════════
291
-
292
- #[test]
293
- fn pane_width_failed_forces_exact_match_never_default() {
294
- // GROUP-I fail-safe (bug-064/082, folded from the old structural placeholder):
295
- // calls the REAL attempt_trust_auto_answer. A FOREIGN path that is merely a
296
- // truncated PREFIX of this workspace would only match with a width signal that
297
- // proves right-edge truncation (leader_panes.py:_token_reaches_right_edge). With
298
- // PaneWidthQuery::Failed there is NO width signal and NO default width to leak,
299
- // so the matcher MUST fall back to exact canonical equality → the prefix does
300
- // NOT match → workspace_dir_mismatch / prompt_leader. Probed golden:
301
- // leader_panes.py:430-444 with pane_width=None (Failed) → workspace_dir_mismatch.
302
- let ws = tmp_ws("panewidthfailsafe");
303
- let canonical = std::fs::canonicalize(&ws).unwrap();
304
- let log = EventLog::new(&ws);
305
- let t = NoopTransport;
306
- let pane = PaneId::new("%7");
307
- // A right-edge-truncated prefix of the real workspace path (drop the last char):
308
- // would auto-answer IF a width signal proved truncation — but Failed forbids that.
309
- let canon_str = canonical.to_string_lossy();
310
- let truncated_prefix = &canon_str[..canon_str.len().saturating_sub(1)];
311
- let tail = format!("Allow Codex to write to {truncated_prefix}");
312
- let out = attempt_trust_auto_answer(
313
- &canonical,
314
- &t,
315
- Some(&pane),
316
- &tail,
317
- &PaneWidthQuery::Failed {
318
- error: "tmux_query_failed:CalledProcessError".to_string(),
319
- },
320
- &log,
321
- )
322
- .unwrap();
323
- // fail-safe: no width → exact-equality only → truncated prefix refused.
324
- assert!(
325
- !out.answered,
326
- "Failed pane-width must NOT enable prefix/truncation matching"
327
- );
328
- assert_eq!(out.reason, "workspace_dir_mismatch");
329
- assert_eq!(out.action.as_deref(), Some("prompt_leader"));
330
- }
331
-
332
- #[test]
333
- fn tmux_pane_width_failure_yields_failed_not_default() {
334
- // delivery.py:37-50 — any failure path returns Failed (never a guessed width).
335
- let t = NoopTransport;
336
- let target = Target::Pane(PaneId::new("%nonexistent"));
337
- let q = tmux_pane_width(&t, &target);
338
- assert!(
339
- matches!(q, PaneWidthQuery::Failed { .. }),
340
- "query failure must be fail-safe Failed, never a default width"
341
- );
342
- }
343
-
344
- // ════════════════════════════════════════════════════════════════════════
345
- // GROUP J — trust retry status machine: bounded attempt → exhausted terminal.
346
- // delivery.py:221-319 (_handle_trust_retry_needed).
347
- // ════════════════════════════════════════════════════════════════════════
348
-
349
- #[test]
350
- fn handle_trust_retry_below_max_schedules_retry() {
351
- // attempt 1 (< 4) → next_attempt 2 scheduled, status retry_scheduled,
352
- // stage trust_auto_answer_dismissal_wait. NOT marked terminal-failed.
353
- let ws = tmp_ws("trustretry1");
354
- let store = store_for(&ws);
355
- let log = EventLog::new(&ws);
356
- let payload = TrustRetryPayload {
357
- message_id: "m1".to_string(),
358
- attempt: 1,
359
- max_attempts: TRUST_RETRY_MAX_ATTEMPTS,
360
- first_target: PaneId::new("%7"),
361
- };
362
- let out = handle_trust_retry_needed(&store, &payload, &log).unwrap();
363
- assert_eq!(out.status, DeliveryStatus::RetryScheduled);
364
- assert_eq!(out.stage, Some(DeliveryStage::TrustAutoAnswerDismissalWait));
365
- assert!(!out.ok);
366
- }
367
-
368
- #[test]
369
- fn handle_trust_retry_at_max_is_exhausted_terminal() {
370
- // attempt == 4 (== MAX) → next_attempt 5 > MAX → terminal exhausted, marks
371
- // message failed, emits trust_auto_answer_exhausted. delivery.py:246-266.
372
- let ws = tmp_ws("trustretry4");
373
- let store = store_for(&ws);
374
- let log = EventLog::new(&ws);
375
- let payload = TrustRetryPayload {
376
- message_id: "m1".to_string(),
377
- attempt: TRUST_RETRY_MAX_ATTEMPTS,
378
- max_attempts: TRUST_RETRY_MAX_ATTEMPTS,
379
- first_target: PaneId::new("%7"),
380
- };
381
- let out = handle_trust_retry_needed(&store, &payload, &log).unwrap();
382
- // delivery.py:257-259 — terminal exhausted: ok False, status the dedicated
383
- // trust_auto_answer_exhausted (a bounded-loop termination guarantee, NOT a
384
- // refusal reason — `reason` stays None at the typed boundary).
385
- assert_eq!(out.status, DeliveryStatus::TrustAutoAnswerExhausted);
386
- assert!(!out.ok);
387
- }
388
-
389
- // ════════════════════════════════════════════════════════════════════════
390
- // GROUP K — send_message target resolution / fallback chain (send.py:36-372).
391
- // RED via unimplemented!(); golden status/reason encoded in assertions.
392
- // ════════════════════════════════════════════════════════════════════════
393
-
394
- #[test]
395
- fn send_message_target_not_in_team_is_refused() {
396
- // send.py:259-261 — non-leader, non-team target → refused/target_not_in_team.
397
- let ws = tmp_ws("sendrefuse");
398
- let opts = SendOptions::default();
399
- let out = send_message(
400
- &ws,
401
- &MessageTarget::Single("ghost".to_string()),
402
- "hi",
403
- &opts,
404
- )
405
- .unwrap();
406
- assert_eq!(out.status, DeliveryStatus::Refused);
407
- assert_eq!(out.reason, Some(DeliveryRefusal::TargetNotInTeam));
408
- }
409
-
410
- #[test]
411
- fn message_not_silently_stuck_accepted_when_coordinator_dead() {
412
- let ws = tmp_ws("sendcoorddead");
413
- crate::state::persist::save_runtime_state(
414
- &ws,
415
- &serde_json::json!({
416
- "session_name": "team-x",
417
- "agents": {
418
- "worker-1": {"status": "running", "agent_id": "worker-1", "window": "worker-1"},
419
- },
420
- }),
421
- )
422
- .unwrap();
423
- let coordinator_ws = crate::coordinator::WorkspacePath::new(ws.clone());
424
- std::fs::create_dir_all(crate::model::paths::runtime_dir(&ws)).unwrap();
425
- let _ = MessageStore::open(&ws).unwrap();
426
- let stale_pid = crate::coordinator::Pid::new(99_999_999);
427
- crate::coordinator::write_coordinator_metadata(
428
- &coordinator_ws,
429
- stale_pid,
430
- crate::coordinator::MetadataSource::Boot,
431
- )
432
- .unwrap();
433
- std::fs::write(
434
- crate::coordinator::coordinator_pid_path(&coordinator_ws),
435
- stale_pid.to_string(),
436
- )
437
- .unwrap();
438
-
439
- let out = send_message(
440
- &ws,
441
- &MessageTarget::Single("worker-1".to_string()),
442
- "hi",
443
- &SendOptions::default(),
444
- )
445
- .unwrap();
446
-
447
- assert!(out.ok, "durable persistence is the send success boundary");
448
- assert_eq!(out.status, DeliveryStatus::Blocked);
449
- assert_eq!(out.message_status.0, "queued_coordinator_unavailable");
450
- assert!(out
451
- .message_id
452
- .as_deref()
453
- .is_some_and(|id| id.starts_with("msg_")));
454
- assert_eq!(out.reason, Some(DeliveryRefusal::CoordinatorUnavailable));
455
- assert!(
456
- out.verification
457
- .as_deref()
458
- .is_some_and(|warning| warning.contains("coordinator is not running")),
459
- "N38 warning must explain the durable retry blocker; out={out:?}"
460
- );
461
- let store = MessageStore::open(&ws).unwrap();
462
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
463
- let blocked: i64 = conn
464
- .query_row(
465
- "select count(*) from messages where status = 'queued_coordinator_unavailable' \
466
- and error = 'coordinator_unavailable' and delivered_at is null",
467
- [],
468
- |row| row.get(0),
469
- )
470
- .unwrap();
471
- assert_eq!(
472
- blocked, 1,
473
- "dead coordinator send must park exactly one durable, non-delivered row"
474
- );
475
- let events = EventLog::new(&ws).tail(20).unwrap();
476
- assert!(
477
- events.iter().any(|event| {
478
- event.get("event").and_then(serde_json::Value::as_str)
479
- == Some("send.coordinator_unavailable")
480
- && event
481
- .get("message_queued")
482
- .and_then(serde_json::Value::as_bool)
483
- == Some(true)
484
- }),
485
- "send.coordinator_unavailable event must be durable; events={events:?}"
486
- );
487
- }
488
-
489
- #[test]
490
- fn send_message_broadcast_empty_team_skips_no_recipients() {
491
- // send.py:391-393 — "*" with no team recipients →
492
- // {"ok": False, "status": "failed", "reason": "no_team_recipients", "to": "*"}.
493
- // Post-#230 N31/N32 funnel implementation (cr-approved): broadcast now expands the
494
- // recipient set via `broadcast_recipients(state, sender, team)` and routes each
495
- // recipient through the SAME primitives as a single send (leader → primitive,
496
- // peer → send_message). The assertions stay the same: with no agents seeded and
497
- // sender="leader" (default opts.sender), `broadcast_recipients` returns an empty
498
- // list — outcome is Failed/no-recipients with channel="*". The "*" channel label
499
- // is preserved through the new `fanout_send(..., channel_label="*")` parameter so
500
- // legacy consumers can still tell broadcast (`*`) apart from explicit fanout list.
501
- let ws = tmp_ws("sendbcast");
502
- let opts = SendOptions::default();
503
- let out = send_message(&ws, &MessageTarget::Broadcast, "hi", &opts).unwrap();
504
- assert!(!out.ok);
505
- assert_eq!(out.status, DeliveryStatus::Failed);
506
- assert_eq!(
507
- out.reason, None,
508
- "no_team_recipients is a failed-status terminal, not a typed refusal reason"
509
- );
510
- assert_eq!(
511
- out.channel.as_deref(),
512
- Some("*"),
513
- "broadcast outcome must carry the '*' channel (send.py to='*'); fanout_send(channel_label=\"*\") preserves this"
514
- );
515
- }
516
-
517
- #[test]
518
- fn send_message_fanout_empty_recipients_fails() {
519
- // send.py:456-457 — fanout with no usable recipients → ok False,
520
- // no_fanout_recipients. (Dedup-then-deliver happy path needs team fixtures.)
521
- let ws = tmp_ws("sendfanout");
522
- let opts = SendOptions::default();
523
- let out = send_message(&ws, &MessageTarget::Fanout(vec![]), "hi", &opts).unwrap();
524
- assert!(!out.ok);
525
- assert_eq!(out.status, DeliveryStatus::Failed);
526
- }
527
-
528
- // ════════════════════════════════════════════════════════════════════════
529
- // GROUP L — apply_worker_sender_bypass: owner-gate first-door bypass event.
530
- // owner_bypass.py:9-26.
531
- // ════════════════════════════════════════════════════════════════════════
532
-
533
- #[test]
534
- fn worker_sender_bypass_false_for_leader_sender() {
535
- // owner_bypass.py — leader sender never bypasses (worker_sender_bypasses=None).
536
- let ws = tmp_ws("bypassleader");
537
- let log = EventLog::new(&ws);
538
- let state = json(serde_json::json!({"agents": {"w1": {}}}));
539
- let bypassed = apply_worker_sender_bypass(
540
- &state,
541
- Some("leader"),
542
- &MessageTarget::Single("w1".to_string()),
543
- None,
544
- &log,
545
- )
546
- .unwrap();
547
- assert!(!bypassed);
548
- }
549
-
550
- #[test]
551
- #[serial_test::serial(env)]
552
- fn worker_sender_bypass_true_for_known_worker_sender() {
553
- // owner_bypass.py:18-26 — worker in agents bypasses, writes
554
- // send.bypassed_owner_gate_worker_sender.
555
- // Isolate from ambient TEAM_AGENT_ID: the env identity gate only activates when
556
- // TEAM_AGENT_ID is SET (and != sender → deny, see p2_owner_bypass_denies_*). Unset
557
- // here so the agents-membership bypass is tested deterministically regardless of the
558
- // process env (workers run with TEAM_AGENT_ID set; the leader does not).
559
- let _g = ENV_LOCK_MSG.lock().unwrap_or_else(|p| p.into_inner());
560
- let _e = EnvGuardMsg::set("TEAM_AGENT_ID", None);
561
- let ws = tmp_ws("bypassworker");
562
- let log = EventLog::new(&ws);
563
- let state = json(serde_json::json!({"agents": {"w1": {}}}));
564
- let bypassed = apply_worker_sender_bypass(
565
- &state,
566
- Some("w1"),
567
- &MessageTarget::Single("w2".to_string()),
568
- None,
569
- &log,
570
- )
571
- .unwrap();
572
- assert!(bypassed);
573
- }
574
-
575
- // ════════════════════════════════════════════════════════════════════════
576
- // GROUP M — report_result intake (results.py:191-227): validate envelope,
577
- // queue leader notify (channel coordinator), return ok shape.
578
- // ════════════════════════════════════════════════════════════════════════
579
-
580
- #[test]
581
- fn report_result_valid_envelope_returns_ok_with_result_id() {
582
- let ws = tmp_ws("report");
583
- let envelope = json(serde_json::json!({
584
- "schema_version": "result_envelope_v1",
585
- "task_id": "t1", "agent_id": "alice", "status": "success",
586
- "summary": "done", "changes": [], "tests": [], "risks": [],
587
- "artifacts": [], "next_actions": []
588
- }));
589
- let out = report_result(&ws, &envelope).unwrap();
590
- // results.py:216-227 — ok True with result_id/task_id/agent_id echoed.
591
- assert_eq!(out.get("ok").and_then(|v| v.as_bool()), Some(true));
592
- assert_eq!(out.get("task_id").and_then(|v| v.as_str()), Some("t1"));
593
- assert_eq!(out.get("agent_id").and_then(|v| v.as_str()), Some("alice"));
594
- assert!(out.get("result_id").and_then(|v| v.as_str()).is_some());
595
- }
596
-
597
- #[test]
598
- fn report_result_auto_finalizes_and_queues_compact_leader_notification() {
599
- let ws = tmp_ws("reportauto");
600
- crate::state::persist::save_runtime_state(
601
- &ws,
602
- &serde_json::json!({
603
- "agents": {"worker": {"status": "running"}},
604
- "tasks": [{"id": "task_1", "status": "running", "assignee": "worker"}]
605
- }),
606
- )
607
- .unwrap();
608
- let envelope = json(serde_json::json!({
609
- "schema_version": "result_envelope_v1",
610
- "task_id": "task_1",
611
- "agent_id": "worker",
612
- "status": "success",
613
- "summary": "done",
614
- "changes": [],
615
- "tests": [{"command": "cargo test", "status": "passed"}],
616
- "risks": [],
617
- "artifacts": [],
618
- "next_actions": []
619
- }));
620
-
621
- let out = report_result(&ws, &envelope).unwrap();
622
- assert_eq!(out["finalization_status"], "auto_finalized");
623
- assert_eq!(out["notification_status"], "queued");
624
- assert_eq!(out["leader_notified"], false);
625
-
626
- let store = store_for(&ws);
627
- let conn = seed_conn(&store);
628
- let result_status: String = conn
629
- .query_row("select status from results", [], |row| row.get(0))
630
- .unwrap();
631
- let message_count: i64 = conn
632
- .query_row("select count(*) from messages", [], |row| row.get(0))
633
- .unwrap();
634
- assert_eq!(result_status, "collected");
635
- assert_eq!(message_count, 1);
636
- let (presentation, content): (String, String) = conn
637
- .query_row(
638
- "select presentation, content from messages",
639
- [],
640
- |row| Ok((row.get(0)?, row.get(1)?)),
641
- )
642
- .unwrap();
643
- assert_eq!(
644
- serde_json::from_str::<serde_json::Value>(&presentation).unwrap()["class"],
645
- "stage_result"
646
- );
647
- assert!(content.len() < 320, "leader notification must stay compact");
648
- let state = crate::state::persist::load_runtime_state(&ws).unwrap();
649
- assert_eq!(state["tasks"][0]["status"], "done");
650
- assert_eq!(
651
- state["tasks"][0]["accepted_result_id"].as_str().is_some(),
652
- true
653
- );
654
- assert!(
655
- std::fs::read_to_string(ws.join(".team/logs/events.jsonl"))
656
- .unwrap()
657
- .contains("\"collect.result\"")
658
- );
659
- }
660
-
661
- #[test]
662
- fn report_result_message_scope_finalizes_latest_assigned_task() {
663
- let ws = tmp_ws("reportauto-message");
664
- crate::state::persist::save_runtime_state(
665
- &ws,
666
- &serde_json::json!({
667
- "active_team_key": "team-a",
668
- "teams": {
669
- "team-a": {
670
- "agents": {"worker": {"status": "running"}},
671
- "tasks": [{"id": "task_initial", "status": "pending", "assignee": "worker"}]
672
- }
673
- }
674
- }),
675
- )
676
- .unwrap();
677
- let store = store_for(&ws);
678
- let conn = seed_conn(&store);
679
- conn.execute(
680
- "insert into messages(message_id, owner_team_id, sender, recipient, status, content, created_at) values (?1, ?2, ?3, ?4, ?5, ?6, ?7)",
681
- rusqlite::params![
682
- "msg_turn",
683
- "team-a",
684
- "leader",
685
- "worker",
686
- "delivered",
687
- "complete the task",
688
- "2026-09-19T00:00:00Z",
689
- ],
690
- )
691
- .unwrap();
692
- let envelope = json(serde_json::json!({
693
- "schema_version": "result_envelope_v1",
694
- "task_id": "msg_turn",
695
- "agent_id": "worker",
696
- "status": "success",
697
- "summary": "done",
698
- "changes": [],
699
- "tests": [],
700
- "risks": [],
701
- "artifacts": [],
702
- "next_actions": []
703
- }));
704
-
705
- let out = report_result(&ws, &envelope).unwrap();
706
- assert_eq!(out["finalization_status"], "auto_finalized");
707
- assert_eq!(out["notification_status"], "queued");
708
- let state = crate::state::persist::load_runtime_state(&ws).unwrap();
709
- assert_eq!(state["teams"]["team-a"]["tasks"][0]["status"], "done");
710
- assert!(state["teams"]["team-a"]["tasks"][0]["accepted_result_id"]
711
- .as_str()
712
- .is_some());
713
- }
714
-
715
- #[test]
716
- fn report_result_invalid_envelope_errors_validation() {
717
- // validate_result_envelope raises ValidationError → MessagingError::Validation.
718
- let ws = tmp_ws("reportbad");
719
- let envelope = json(serde_json::json!({"schema_version": "result_envelope_v1"}));
720
- let err = report_result(&ws, &envelope).unwrap_err();
721
- assert!(
722
- matches!(err, MessagingError::Validation(_)),
723
- "missing required fields must surface as Validation, got {err:?}"
724
- );
725
- }
726
-
727
- #[test]
728
- fn leader_receiver_reports_requires_ack_forced_off() {
729
- let ws = tmp_ws("ack-forced-off");
730
- let log = EventLog::new(&ws);
731
- let state = json(serde_json::json!({
732
- "active_team_key": "team-a",
733
- "teams": {"team-a": {}}
734
- }));
735
-
736
- let outcome = send_to_leader_receiver(
737
- &ws,
738
- &state,
739
- "leader",
740
- "ack contract probe",
741
- None,
742
- "worker",
743
- true,
744
- None,
745
- &log,
746
- )
747
- .unwrap();
748
-
749
- let value = crate::mcp_server::helpers::delivery_outcome_value(&outcome);
750
- assert_eq!(
751
- value
752
- .get("ack_forced_off")
753
- .and_then(serde_json::Value::as_bool),
754
- Some(true),
755
- "requires_ack=true must report that the unavailable ack guarantee was forced off"
756
- );
757
- }
758
-
759
- // ════════════════════════════════════════════════════════════════════════
760
- // GROUP N — notify_result_watchers dedupe (exactly-once, Gap 32/38).
761
- // result_delivery.py:38-132. superseded for duplicate watchers same result.
762
- // ════════════════════════════════════════════════════════════════════════
763
-
764
- #[test]
765
- fn notify_result_watchers_no_match_returns_empty() {
766
- // result_delivery.py:51-52 — no candidate watcher matches → empty list.
767
- let ws = tmp_ws("notifyempty");
768
- let log = EventLog::new(&ws);
769
- let result = json(serde_json::json!({
770
- "result_id": "r1", "task_id": "t1", "agent_id": "alice"
771
- }));
772
- let watchers = vec![json(serde_json::json!({
773
- "watcher_id": "w-x", "task_id": "OTHER", "agent_id": "alice"
774
- }))];
775
- let notices = notify_result_watchers(&ws, &result, &log, Some(&watchers), None).unwrap();
776
- assert!(notices.is_empty());
777
- }
778
-
779
- #[test]
780
- fn notify_result_watchers_supersedes_duplicate_watchers() {
781
- // result_delivery.py:53-78 — two watchers same (task,agent,result): earliest is
782
- // primary, the other gets superseded (ok False, notice records superseded).
783
- let ws = tmp_ws("notifysup");
784
- let log = EventLog::new(&ws);
785
- let result = json(serde_json::json!({
786
- "result_id": "r1", "task_id": "t1", "agent_id": "alice"
787
- }));
788
- let watchers = vec![
789
- json(serde_json::json!({
790
- "watcher_id": "w-early", "task_id": "t1", "agent_id": "alice",
791
- "created_at": "2026-06-02T10:00:00+00:00"
792
- })),
793
- json(serde_json::json!({
794
- "watcher_id": "w-late", "task_id": "t1", "agent_id": "alice",
795
- "created_at": "2026-06-02T11:00:00+00:00"
796
- })),
797
- ];
798
- let notices = notify_result_watchers(&ws, &result, &log, Some(&watchers), None).unwrap();
799
- // The late watcher must appear as a superseded (not-ok) notice — exactly-once.
800
- let superseded = notices
801
- .iter()
802
- .find(|n| n.watcher_id == "w-late")
803
- .expect("late watcher must be reported");
804
- assert!(
805
- !superseded.ok,
806
- "duplicate watcher must be superseded, not re-delivered"
807
- );
808
- }
809
-
810
- // ════════════════════════════════════════════════════════════════════════
811
- // GROUP O — requeue_after_claim_leader: notified_message_id must SURVIVE (Gap
812
- // 32) — already-notified watchers are NOT requeued. result_delivery.py:428-506.
813
- // ════════════════════════════════════════════════════════════════════════
814
-
815
- #[test]
816
- fn requeue_after_claim_leader_skips_already_notified() {
817
- // Gap 32 (result_delivery.py:467-471) — SEEDED dedupe gate: two same-team
818
- // watchers, one already notified (notified_message_id set), one un-notified.
819
- // requeue must return ONLY the un-notified watcher; the notified one is NOT
820
- // requeued and its notified_message_id SURVIVES (clearing it would cause a
821
- // second injection). Probed golden: requeued == [w_un] (result_id present,
822
- // prior_state "pending"); notified watcher keeps notified_message_id.
823
- let ws = tmp_ws("requeue");
824
- let store = store_for(&ws);
825
- let log = EventLog::new(&ws);
826
- let team = TeamKey::new("team-a");
827
- let pane = PaneId::new("%new-leader");
828
-
829
- let w_un = seed_watcher(
830
- &store,
831
- "w-unnotified",
832
- "team-a",
833
- "t1",
834
- "alice",
835
- "pending",
836
- Some("res_retryable"),
837
- None,
838
- );
839
- let w_notified = seed_watcher(
840
- &store,
841
- "w-notified",
842
- "team-a",
843
- "t2",
844
- "bob",
845
- "pending",
846
- None,
847
- Some("msg_already"),
848
- );
849
-
850
- let requeued = requeue_after_claim_leader(&ws, &store, &log, &team, &pane, None).unwrap();
851
-
852
- // ONLY the un-notified watcher requeues (the notified one is the dedupe gate).
853
- let ids: Vec<&str> = requeued.iter().map(|n| n.watcher_id.as_str()).collect();
854
- assert_eq!(
855
- ids,
856
- vec![w_un.as_str()],
857
- "exactly the un-notified watcher requeues"
858
- );
859
- assert!(
860
- !requeued.iter().any(|n| n.watcher_id == w_notified),
861
- "already-notified watcher must NOT be requeued (Gap 32)"
862
- );
863
-
864
- // Gap 32 survival: notified_message_id is preserved on the skipped watcher.
865
- let (_status, notified) = watcher_state(&store, &w_notified);
866
- assert_eq!(
867
- notified.as_deref(),
868
- Some("msg_already"),
869
- "notified_message_id MUST survive requeue — clearing it re-injects (Gap 32)"
870
- );
871
- }
872
-
873
- #[test]
874
- fn requeue_delivery_exhausted_watchers_reopens_only_exhausted() {
875
- let ws = tmp_ws("requeueexhausted");
876
- let store = store_for(&ws);
877
- let log = EventLog::new(&ws);
878
- let team = TeamKey::new("team-a");
879
- let pane = PaneId::new("%leader");
880
-
881
- let rid = seed_result(&store, "res_exhausted", "t1", "alice", "success");
882
- let exhausted = seed_watcher(
883
- &store,
884
- "w-exhausted",
885
- "team-a",
886
- "t1",
887
- "alice",
888
- "delivery_exhausted",
889
- Some(&rid),
890
- None,
891
- );
892
- let notified = seed_watcher(
893
- &store,
894
- "w-exhausted-notified",
895
- "team-a",
896
- "t2",
897
- "bob",
898
- "delivery_exhausted",
899
- Some("res_skip"),
900
- Some("msg_done"),
901
- );
902
- let failed = seed_watcher(
903
- &store,
904
- "w-failed",
905
- "team-a",
906
- "t3",
907
- "carol",
908
- "notify_failed",
909
- Some("res_failed"),
910
- None,
911
- );
912
-
913
- let requeued = requeue_delivery_exhausted_watchers(&ws, &store, &log, &team, &pane).unwrap();
914
-
915
- assert_eq!(
916
- requeued.len(),
917
- 1,
918
- "only delivery_exhausted unnotified watchers requeue"
919
- );
920
- let notice = &requeued[0];
921
- assert_eq!(notice.watcher_id, exhausted);
922
- assert_eq!(notice.result_id.as_deref(), Some(rid.as_str()));
923
- assert_eq!(notice.prior_state.as_deref(), Some("delivery_exhausted"));
924
- // R8 (golden result_watchers.py:95): attach requeue flips delivery_exhausted -> notify_failed (NOT pending).
925
- assert_eq!(notice.status.as_deref(), Some("notify_failed"));
926
-
927
- let (status, _notified_id) = watcher_state(&store, &exhausted);
928
- // R8 (golden): attach requeue leaves the watcher at notify_failed and DEFERS retry to the coordinator
929
- // tick — it does NOT immediately re-deliver (only the claim path retries). So the persisted status is
930
- // notify_failed, not 'notified'.
931
- assert_eq!(
932
- status, "notify_failed",
933
- "attach requeue flips to notify_failed and defers retry (golden)"
934
- );
935
- let (status, notified_id) = watcher_state(&store, &notified);
936
- assert_eq!(status, "delivery_exhausted");
937
- assert_eq!(notified_id.as_deref(), Some("msg_done"));
938
- let (status, _notified_id) = watcher_state(&store, &failed);
939
- assert_eq!(
940
- status, "notify_failed",
941
- "non-exhausted watcher is not selected"
942
- );
943
-
944
- // R8 (golden leader/__init__.py:46-50): result_watcher.requeued is the ATTACH form
945
- // {watcher_id, trigger:"attach_leader", new_pane_id} — NOT the claim-style {prior_state,claimed_pane_id,team_id}.
946
- let events = log.tail(0).unwrap();
947
- let ev = events
948
- .iter()
949
- .rev()
950
- .find(|event| {
951
- event.get("event").and_then(|v| v.as_str()) == Some("result_watcher.requeued")
952
- })
953
- .expect("result_watcher.requeued event");
954
- let keys: std::collections::BTreeSet<&str> = ev
955
- .as_object()
956
- .unwrap()
957
- .keys()
958
- .map(String::as_str)
959
- .filter(|k| *k != "ts" && *k != "event")
960
- .collect();
961
- let expected: std::collections::BTreeSet<&str> = ["watcher_id", "trigger", "new_pane_id"]
962
- .into_iter()
963
- .collect();
964
- assert_eq!(
965
- keys, expected,
966
- "result_watcher.requeued must be golden attach form {{watcher_id, trigger, new_pane_id}}"
967
- );
968
- assert_eq!(
969
- ev.get("watcher_id").and_then(|v| v.as_str()),
970
- Some("w-exhausted")
971
- );
972
- assert_eq!(
973
- ev.get("trigger").and_then(|v| v.as_str()),
974
- Some("attach_leader")
975
- );
976
- assert_eq!(
977
- ev.get("new_pane_id").and_then(|v| v.as_str()),
978
- Some("%leader")
979
- );
980
- }
981
-
982
- // ════════════════════════════════════════════════════════════════════════
983
- // GROUP Q — collect intake (results.py:45-167): valid result advances task,
984
- // returns collected_results + delivered_messages + results counts shape.
985
- // ════════════════════════════════════════════════════════════════════════
986
-
987
- #[test]
988
- fn collect_without_spec_surfaces_validation_error() {
989
- // results.py:46-48 — collect() reads spec_path then load_spec(); against a
990
- // workspace with NO team.spec.yaml, load_spec RAISES ValidationError
991
- // ("Cannot read <path>: ...", spec.py:18-20) BEFORE any collection. The
992
- // previous `.unwrap()` (expecting an Ok dict with present-only keys) was wrong:
993
- // the real Python collect on a bare workspace does not return a dict, it raises.
994
- // At the typed boundary that surfaces as MessagingError::Validation.
995
- //
996
- // The full collected_results-count golden (seed an uncollected result, assert it
997
- // collects and the task advances) is DEFERRED: it requires a valid on-disk
998
- // team.spec.yaml + runtime state, whose formats are owned by the spec/state lanes
999
- // (this file may not edit them). seed_result() exists for the retry path that
1000
- // does NOT need a spec; the collect happy-path needs an integration fixture.
1001
- let ws = tmp_ws("collect");
1002
- let err = collect(&ws, None, false).unwrap_err();
1003
- assert!(
1004
- matches!(err, MessagingError::Validation(_)),
1005
- "collect without a team spec must surface Validation, got {err:?}"
1006
- );
1007
- }
1008
-
1009
- #[test]
1010
- fn collect_accepts_message_scoped_result_for_matching_recipient() {
1011
- let ws = tmp_ws("collectmsgok");
1012
- std::fs::write(ws.join("team.spec.yaml"), "version: 1\n").unwrap();
1013
- let store = store_for(&ws);
1014
- let message_id = store
1015
- .create_message(None, "leader", "w1", "please reply", None, false, None)
1016
- .unwrap();
1017
- seed_result(&store, "res_msg_ok", &message_id, "w1", "success");
1018
-
1019
- let out = collect(&ws, None, false).unwrap();
1020
- assert_eq!(out.get("ok").and_then(|v| v.as_bool()), Some(true));
1021
- let collected = out
1022
- .get("collected_results")
1023
- .and_then(|v| v.as_array())
1024
- .expect("collected_results");
1025
- assert_eq!(collected.len(), 1);
1026
- assert_eq!(
1027
- collected[0].get("task_id").and_then(|v| v.as_str()),
1028
- Some(message_id.as_str())
1029
- );
1030
- assert_eq!(
1031
- collected[0].get("agent_id").and_then(|v| v.as_str()),
1032
- Some("w1")
1033
- );
1034
- assert_eq!(
1035
- collected[0].get("scope").and_then(|v| v.as_str()),
1036
- Some("message")
1037
- );
1038
- // D3 (leader-adjudicated): golden collected_results entry is EXACTLY the 8-key summary for BOTH
1039
- // scopes; golden's task_status feeds only the `collect.result` EVENT, never the entry. So a
1040
- // message-scope entry carries NO task_status key (the prior `Some("message_scoped")` lock encoded a
1041
- // port divergence — dropped per ruling).
1042
- assert!(
1043
- collected[0].get("task_status").is_none(),
1044
- "collected_results entry must NOT carry task_status (golden 8-key summary; event-only); got {:?}",
1045
- collected[0]
1046
- );
1047
- let keys: Vec<&str> = collected[0]
1048
- .as_object()
1049
- .expect("entry is an object")
1050
- .keys()
1051
- .map(String::as_str)
1052
- .collect();
1053
- assert_eq!(
1054
- keys,
1055
- vec!["result_id", "task_id", "agent_id", "status", "summary", "tests", "created_at", "scope"],
1056
- "message-scope collected_results entry must be EXACTLY the golden 8 keys in order; got {keys:?}"
1057
- );
1058
- }
1059
-
1060
- #[test]
1061
- fn collect_rejects_message_scoped_result_without_matching_recipient() {
1062
- let ws = tmp_ws("collectmsgbad");
1063
- std::fs::write(ws.join("team.spec.yaml"), "version: 1\n").unwrap();
1064
- let store = store_for(&ws);
1065
- let message_id = store
1066
- .create_message(None, "leader", "w1", "please reply", None, false, None)
1067
- .unwrap();
1068
- seed_result(&store, "res_msg_bad", &message_id, "w2", "success");
1069
-
1070
- let out = collect(&ws, None, false).unwrap();
1071
- assert_eq!(out.get("ok").and_then(|v| v.as_bool()), Some(false));
1072
- assert!(
1073
- out.get("collected_results")
1074
- .and_then(|v| v.as_array())
1075
- .is_some_and(Vec::is_empty),
1076
- "recipient mismatch must not collect as message-scoped"
1077
- );
1078
- let invalid = out
1079
- .get("invalid_results")
1080
- .and_then(|v| v.as_array())
1081
- .expect("invalid_results");
1082
- assert_eq!(invalid.len(), 1);
1083
- assert_eq!(
1084
- invalid[0].get("task_id").and_then(|v| v.as_str()),
1085
- Some(message_id.as_str())
1086
- );
1087
- assert_eq!(
1088
- invalid[0].get("error").and_then(|v| v.as_str()),
1089
- Some(format!("unknown task id: {message_id}").as_str())
1090
- );
1091
- }
1092
-
1093
- // ════════════════════════════════════════════════════════════════════════
1094
- // GROUP R — run_comms_selftest: §84 / MUST-NOT-13 zero-provider-SDK gate.
1095
- // diagnose/comms.py:21-47. The whole point: assert zero provider client calls.
1096
- // ════════════════════════════════════════════════════════════════════════
1097
-
1098
- #[test]
1099
- fn run_comms_selftest_zero_provider_sdk_passes_and_locks_scope() {
1100
- let ws = tmp_ws("selftestok");
1101
- let driver = ZeroSdkDriver {
1102
- run_id: Some("fixedrunid01".to_string()),
1103
- calls: ProviderSdkCalls::default(),
1104
- };
1105
- let report = run_comms_selftest(&ws, None, &driver).unwrap();
1106
- // diagnose/comms.py:44 scope == "binding_consistency".
1107
- assert_eq!(report.scope, "binding_consistency");
1108
- assert_eq!(report.run_id, "fixedrunid01");
1109
- // The mechanical gate: provider_sdk_calls check is a Pass with all-zero evidence.
1110
- assert_eq!(report.provider_sdk_calls.status, CheckStatus::Pass);
1111
- match &report.provider_sdk_calls.evidence {
1112
- CheckEvidence::ProviderSdkCalls(calls) => assert!(calls.is_zero()),
1113
- other => panic!("expected ProviderSdkCalls evidence, got {other:?}"),
1114
- }
1115
- assert!(report.ok);
1116
- }
1117
-
1118
- #[test]
1119
- fn run_comms_selftest_nonzero_provider_sdk_fails_gate() {
1120
- // Any non-zero SDK call count → provider_sdk_calls check FAILS, report not ok.
1121
- let ws = tmp_ws("selftestbad");
1122
- let driver = ZeroSdkDriver {
1123
- run_id: Some("r2".to_string()),
1124
- calls: ProviderSdkCalls {
1125
- anthropic: 1,
1126
- openai: 0,
1127
- httpx: 0,
1128
- },
1129
- };
1130
- let report = run_comms_selftest(&ws, None, &driver).unwrap();
1131
- assert_eq!(report.provider_sdk_calls.status, CheckStatus::Fail);
1132
- assert!(!report.ok);
1133
- }
1134
-
1135
- #[test]
1136
- fn run_comms_selftest_contract_suite_is_executable_zero_token() {
1137
- let ws = tmp_ws("selftestdefer");
1138
- let driver = ZeroSdkDriver {
1139
- run_id: Some("r3".to_string()),
1140
- calls: ProviderSdkCalls::default(),
1141
- };
1142
- let report = run_comms_selftest(&ws, None, &driver).unwrap();
1143
- assert_eq!(report.contract_suite.status, CheckStatus::Pass);
1144
- match &report.contract_suite.evidence {
1145
- CheckEvidence::ContractSuite { checks } => {
1146
- assert!(
1147
- checks.iter().all(|check| check.status == CheckStatus::Pass),
1148
- "contract suite subchecks must all pass: {checks:?}"
1149
- );
1150
- let names: Vec<&str> = checks.iter().map(|check| check.name.as_str()).collect();
1151
- assert!(
1152
- names.contains(&"message_store_schema")
1153
- && names.contains(&"message_token_shape")
1154
- && names.contains(&"result_notification_render")
1155
- && names.contains(&"leader_projection_owner_team"),
1156
- "contract suite must cover schema, token, result notification, and leader projection: {names:?}"
1157
- );
1158
- }
1159
- other => panic!("expected ContractSuite evidence, got {other:?}"),
1160
- }
1161
- }
1162
-
1163
- // ════════════════════════════════════════════════════════════════════════
1164
- // GROUP S — evaluate_idle_behavior: claimed_status normalization
1165
- // (IDLE/WORKING/RUNNING → not_challenged). diagnose/comms.py:50-94.
1166
- // ════════════════════════════════════════════════════════════════════════
1167
-
1168
- #[test]
1169
- fn evaluate_idle_behavior_recognized_status_is_not_challenged() {
1170
- // diagnose/comms.py:86-94 — claimed_status in {IDLE,WORKING,RUNNING} (case-
1171
- // insensitive) and no driver result → status not_challenged, ok True.
1172
- let ws = tmp_ws("idleeval");
1173
- let driver = ZeroSdkDriver {
1174
- run_id: None,
1175
- calls: ProviderSdkCalls::default(),
1176
- };
1177
- let out = evaluate_idle_behavior(&ws, "w1", "IDLE", None, &driver).unwrap();
1178
- assert_eq!(out.status, CheckStatus::NotChallenged);
1179
- assert!(out.ok);
1180
- assert_eq!(out.agent_id, "w1");
1181
- }
1182
-
1183
- // ════════════════════════════════════════════════════════════════════════
1184
- // GROUP T — deliver_pending_message claim atomicity + status machine.
1185
- // delivery.py:63-218. missing message / unknown recipient / already-claimed.
1186
- // ════════════════════════════════════════════════════════════════════════
1187
-
1188
- #[test]
1189
- fn deliver_pending_message_missing_message_fails() {
1190
- // delivery.py:73-75 — no such message row → ok False, status failed,
1191
- // reason message_missing.
1192
- let ws = tmp_ws("delivermissing");
1193
- let store = store_for(&ws);
1194
- let log = EventLog::new(&ws);
1195
- let t = NoopTransport;
1196
- let out =
1197
- deliver_pending_message(&ws, &store, &t, "nope", &log, &serde_json::json!({})).unwrap();
1198
- assert!(!out.ok);
1199
- assert_eq!(out.status, DeliveryStatus::Failed);
1200
- }
1201
-
1202
- // ════════════════════════════════════════════════════════════════════════
1203
- // GROUP U — fire_due_scheduled_events: exhaustive ScheduledKind dispatch +
1204
- // send dedupe. scheduler.py:41-121. Returns fired event-id list.
1205
- // ════════════════════════════════════════════════════════════════════════
1206
-
1207
- #[test]
1208
- fn fire_due_scheduled_events_fires_each_scheduled_kind() {
1209
- // SEEDED exhaustive-dispatch contract (scheduler.py:41-121): seed one due row
1210
- // of EACH ScheduledKind (send / health_ping / trust_retry). The dispatch loop
1211
- // must fire all three (one match arm per kind, no runtime fallback) and return
1212
- // each fired event id. Probed golden: a due health_ping fires → marked 'done'
1213
- // with {"ok":true,"status":"logged"} and its id appears in the fired list;
1214
- // every due row's id is appended regardless of kind (scheduler.py:118).
1215
- let ws = tmp_ws("scheduler");
1216
- let store = store_for(&ws);
1217
- let log = EventLog::new(&ws);
1218
- let t = NoopTransport;
1219
-
1220
- let send_id = seed_scheduled_event(
1221
- &store,
1222
- ScheduledKind::Send,
1223
- "%w1",
1224
- &serde_json::json!({"content": "ping", "attempt": 1, "max_attempts": 1}),
1225
- );
1226
- let ping_id = seed_scheduled_event(
1227
- &store,
1228
- ScheduledKind::HealthPing,
1229
- "%w1",
1230
- &serde_json::json!({}),
1231
- );
1232
- let trust_id = seed_scheduled_event(
1233
- &store,
1234
- ScheduledKind::TrustRetry,
1235
- "%w1",
1236
- &serde_json::json!({"message_id": "m1", "attempt": 1, "max_attempts": 4}),
1237
- );
1238
-
1239
- let fired = fire_due_scheduled_events(&ws, &store, &t, &log).unwrap();
1240
-
1241
- // Every seeded due kind must be dispatched and its id returned (exhaustive,
1242
- // no kind silently dropped via a fallthrough).
1243
- for id in [send_id, ping_id, trust_id] {
1244
- assert!(
1245
- fired.contains(&id),
1246
- "scheduled event id {id} (each ScheduledKind) must fire; got {fired:?}"
1247
- );
1248
- }
1249
- assert_eq!(
1250
- fired.len(),
1251
- 3,
1252
- "exactly the three seeded due events fire, no extras"
1253
- );
1254
- }
1255
-
1256
- struct UnverifiedInjectTransport {
1257
- readback_visible: bool,
1258
- }
1259
- impl Transport for UnverifiedInjectTransport {
1260
- fn kind(&self) -> BackendKind {
1261
- BackendKind::Tmux
1262
- }
1263
- fn spawn_first(
1264
- &self,
1265
- _s: &SessionName,
1266
- _w: &WindowName,
1267
- _a: &[String],
1268
- _c: &Path,
1269
- _e: &BTreeMap<String, String>,
1270
- ) -> Result<SpawnResult, TransportError> {
1271
- unimplemented!("not reached in delivery")
1272
- }
1273
- fn spawn_into(
1274
- &self,
1275
- _s: &SessionName,
1276
- _w: &WindowName,
1277
- _a: &[String],
1278
- _c: &Path,
1279
- _e: &BTreeMap<String, String>,
1280
- ) -> Result<SpawnResult, TransportError> {
1281
- unimplemented!("not reached in delivery")
1282
- }
1283
- fn inject(
1284
- &self,
1285
- _t: &Target,
1286
- _p: &InjectPayload,
1287
- _s: Key,
1288
- _b: bool,
1289
- ) -> Result<InjectReport, TransportError> {
1290
- Ok(InjectReport {
1291
- stage_reached: crate::transport::InjectStage::Submit,
1292
- inject_verification: if self.readback_visible {
1293
- crate::transport::InjectVerification::CaptureContainsToken
1294
- } else {
1295
- crate::transport::InjectVerification::CaptureMissingToken
1296
- },
1297
- submit_verification:
1298
- crate::transport::SubmitVerification::PastedContentPromptStillPresentAfterSubmit,
1299
- turn_verification: crate::transport::TurnVerification::NotYetObserved,
1300
- attempts: u32::from(SEND_RETRY_MAX_ATTEMPTS),
1301
- submit_diagnostics: None,
1302
- })
1303
- }
1304
- fn send_keys(&self, _t: &Target, _k: &[Key]) -> Result<(), TransportError> {
1305
- Ok(())
1306
- }
1307
- fn capture(&self, _t: &Target, range: CaptureRange) -> Result<CapturedText, TransportError> {
1308
- Ok(CapturedText {
1309
- text: String::new(),
1310
- range,
1311
- })
1312
- }
1313
- fn query(&self, _t: &Target, _f: PaneField) -> Result<Option<String>, TransportError> {
1314
- Ok(None)
1315
- }
1316
- fn liveness(&self, _p: &PaneId) -> Result<PaneLiveness, TransportError> {
1317
- Ok(PaneLiveness::Unknown)
1318
- }
1319
- fn list_targets(&self) -> Result<Vec<PaneInfo>, TransportError> {
1320
- Ok(Vec::new())
1321
- }
1322
- fn has_session(&self, _s: &SessionName) -> Result<bool, TransportError> {
1323
- Ok(true)
1324
- }
1325
- fn list_windows(&self, _s: &SessionName) -> Result<Vec<WindowName>, TransportError> {
1326
- Ok(Vec::new())
1327
- }
1328
- fn set_session_env(
1329
- &self,
1330
- _s: &SessionName,
1331
- _k: &str,
1332
- _v: &str,
1333
- ) -> Result<SetEnvOutcome, TransportError> {
1334
- Ok(SetEnvOutcome::Applied)
1335
- }
1336
- fn kill_session(&self, _s: &SessionName) -> Result<(), TransportError> {
1337
- Ok(())
1338
- }
1339
- fn kill_window(&self, _t: &Target) -> Result<(), TransportError> {
1340
- Ok(())
1341
- }
1342
- fn attach_session(&self, _s: &SessionName) -> Result<AttachOutcome, TransportError> {
1343
- Ok(AttachOutcome::Attached)
1344
- }
1345
- }
1346
-
1347
- struct FailingInjectTransport {
1348
- attempts: std::sync::Arc<std::sync::atomic::AtomicUsize>,
1349
- }
1350
-
1351
- impl Transport for FailingInjectTransport {
1352
- fn kind(&self) -> BackendKind {
1353
- BackendKind::Tmux
1354
- }
1355
- fn spawn_first(
1356
- &self,
1357
- _s: &SessionName,
1358
- _w: &WindowName,
1359
- _a: &[String],
1360
- _c: &Path,
1361
- _e: &BTreeMap<String, String>,
1362
- ) -> Result<SpawnResult, TransportError> {
1363
- unimplemented!("not reached in delivery")
1364
- }
1365
- fn spawn_into(
1366
- &self,
1367
- _s: &SessionName,
1368
- _w: &WindowName,
1369
- _a: &[String],
1370
- _c: &Path,
1371
- _e: &BTreeMap<String, String>,
1372
- ) -> Result<SpawnResult, TransportError> {
1373
- unimplemented!("not reached in delivery")
1374
- }
1375
- fn inject(
1376
- &self,
1377
- t: &Target,
1378
- _p: &InjectPayload,
1379
- _s: Key,
1380
- _b: bool,
1381
- ) -> Result<InjectReport, TransportError> {
1382
- if matches!(t, Target::Pane(pane) if pane.as_str() == "%1") {
1383
- self.attempts
1384
- .fetch_add(1, std::sync::atomic::Ordering::Relaxed);
1385
- }
1386
- Err(TransportError::Inject {
1387
- stage: crate::transport::InjectStage::PasteBuffer,
1388
- source: std::io::Error::other("paste-buffer failed"),
1389
- })
1390
- }
1391
- fn send_keys(&self, _t: &Target, _k: &[Key]) -> Result<(), TransportError> {
1392
- Ok(())
1393
- }
1394
- fn capture(&self, _t: &Target, range: CaptureRange) -> Result<CapturedText, TransportError> {
1395
- Ok(CapturedText {
1396
- text: String::new(),
1397
- range,
1398
- })
1399
- }
1400
- fn query(&self, _t: &Target, _f: PaneField) -> Result<Option<String>, TransportError> {
1401
- Ok(None)
1402
- }
1403
- fn liveness(&self, _p: &PaneId) -> Result<PaneLiveness, TransportError> {
1404
- Ok(PaneLiveness::Unknown)
1405
- }
1406
- fn list_targets(&self) -> Result<Vec<PaneInfo>, TransportError> {
1407
- Ok(Vec::new())
1408
- }
1409
- fn has_session(&self, _s: &SessionName) -> Result<bool, TransportError> {
1410
- Ok(true)
1411
- }
1412
- fn list_windows(&self, _s: &SessionName) -> Result<Vec<WindowName>, TransportError> {
1413
- Ok(Vec::new())
1414
- }
1415
- fn set_session_env(
1416
- &self,
1417
- _s: &SessionName,
1418
- _k: &str,
1419
- _v: &str,
1420
- ) -> Result<SetEnvOutcome, TransportError> {
1421
- Ok(SetEnvOutcome::Applied)
1422
- }
1423
- fn kill_session(&self, _s: &SessionName) -> Result<(), TransportError> {
1424
- Ok(())
1425
- }
1426
- fn kill_window(&self, _t: &Target) -> Result<(), TransportError> {
1427
- Ok(())
1428
- }
1429
- fn attach_session(&self, _s: &SessionName) -> Result<AttachOutcome, TransportError> {
1430
- Ok(AttachOutcome::Attached)
1431
- }
1432
- }
1433
-
1434
- // 0.3.30: submit evidence supersedes stale readback. This transport returns a
1435
- // verified submit but a missing-token readback.
1436
- struct ReadbackMissingTransport;
1437
- impl Transport for ReadbackMissingTransport {
1438
- fn kind(&self) -> BackendKind {
1439
- BackendKind::Tmux
1440
- }
1441
- fn spawn_first(
1442
- &self,
1443
- _: &SessionName,
1444
- _: &WindowName,
1445
- _: &[String],
1446
- _: &Path,
1447
- _: &BTreeMap<String, String>,
1448
- ) -> Result<SpawnResult, TransportError> {
1449
- unimplemented!("not reached in delivery")
1450
- }
1451
- fn spawn_into(
1452
- &self,
1453
- _: &SessionName,
1454
- _: &WindowName,
1455
- _: &[String],
1456
- _: &Path,
1457
- _: &BTreeMap<String, String>,
1458
- ) -> Result<SpawnResult, TransportError> {
1459
- unimplemented!("not reached in delivery")
1460
- }
1461
- fn inject(
1462
- &self,
1463
- _: &Target,
1464
- _: &InjectPayload,
1465
- _: Key,
1466
- _: bool,
1467
- ) -> Result<InjectReport, TransportError> {
1468
- Ok(InjectReport {
1469
- stage_reached: crate::transport::InjectStage::Submit,
1470
- // submit verified, but the token never appeared in the pane → readback missing.
1471
- inject_verification: crate::transport::InjectVerification::CaptureMissingToken,
1472
- submit_verification: crate::transport::SubmitVerification::KeySentAfterVisibleToken {
1473
- key: Key::Enter,
1474
- },
1475
- turn_verification: crate::transport::TurnVerification::NotYetObserved,
1476
- attempts: 1,
1477
- submit_diagnostics: None,
1478
- })
1479
- }
1480
- fn send_keys(&self, _: &Target, _: &[Key]) -> Result<(), TransportError> {
1481
- Ok(())
1482
- }
1483
- fn capture(&self, _: &Target, range: CaptureRange) -> Result<CapturedText, TransportError> {
1484
- Ok(CapturedText {
1485
- text: String::new(),
1486
- range,
1487
- })
1488
- }
1489
- fn query(&self, _: &Target, _: PaneField) -> Result<Option<String>, TransportError> {
1490
- Ok(None)
1491
- }
1492
- fn liveness(&self, _: &PaneId) -> Result<PaneLiveness, TransportError> {
1493
- Ok(PaneLiveness::Unknown)
1494
- }
1495
- fn list_targets(&self) -> Result<Vec<PaneInfo>, TransportError> {
1496
- Ok(Vec::new())
1497
- }
1498
- fn has_session(&self, _: &SessionName) -> Result<bool, TransportError> {
1499
- Ok(true)
1500
- }
1501
- fn list_windows(&self, _: &SessionName) -> Result<Vec<WindowName>, TransportError> {
1502
- Ok(Vec::new())
1503
- }
1504
- fn set_session_env(
1505
- &self,
1506
- _: &SessionName,
1507
- _: &str,
1508
- _: &str,
1509
- ) -> Result<SetEnvOutcome, TransportError> {
1510
- Ok(SetEnvOutcome::Applied)
1511
- }
1512
- fn kill_session(&self, _: &SessionName) -> Result<(), TransportError> {
1513
- Ok(())
1514
- }
1515
- fn kill_window(&self, _: &Target) -> Result<(), TransportError> {
1516
- Ok(())
1517
- }
1518
- fn attach_session(&self, _: &SessionName) -> Result<AttachOutcome, TransportError> {
1519
- Ok(AttachOutcome::Attached)
1520
- }
1521
- }
1522
-
1523
- #[test]
1524
- fn deliver_pending_submit_verified_overrides_missing_readback() {
1525
- let ws = tmp_ws("readbackmiss");
1526
- let store = store_for(&ws);
1527
- let log = EventLog::new(&ws);
1528
- let state = serde_json::json!({
1529
- "session_name": "team-readbackmiss",
1530
- "leader_receiver": {"pane_id": "%leader"},
1531
- "agents": {"w1": {"provider": "fake", "pane_id": "%1"}}
1532
- });
1533
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1534
- let message_id = store
1535
- .create_message(None, "leader", "w1", "ping", None, false, None)
1536
- .unwrap();
1537
-
1538
- let out = deliver_pending_message(
1539
- &ws,
1540
- &store,
1541
- &ReadbackMissingTransport,
1542
- &message_id,
1543
- &log,
1544
- &state,
1545
- )
1546
- .unwrap();
1547
-
1548
- assert!(
1549
- out.ok,
1550
- "0.3.30: submit-verified delivery must not be vetoed by stale CaptureMissingToken readback"
1551
- );
1552
- assert_eq!(
1553
- out.message_status.0, "delivered",
1554
- "0.3.30: submit evidence is stronger than readback"
1555
- );
1556
- }
1557
-
1558
- #[test]
1559
- fn deliver_pending_submit_unverified_is_not_saved_by_readback() {
1560
- let ws = tmp_ws("readbacksaves");
1561
- let store = store_for(&ws);
1562
- let log = EventLog::new(&ws);
1563
- let state = serde_json::json!({
1564
- "session_name": "team-readbacksaves",
1565
- "leader_receiver": {"pane_id": "%leader"},
1566
- "agents": {"w1": {"provider": "fake", "pane_id": "%1"}}
1567
- });
1568
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1569
- let message_id = store
1570
- .create_message(None, "leader", "w1", "ping", None, false, None)
1571
- .unwrap();
1572
-
1573
- let out = deliver_pending_message(
1574
- &ws,
1575
- &store,
1576
- &UnverifiedInjectTransport {
1577
- readback_visible: true,
1578
- },
1579
- &message_id,
1580
- &log,
1581
- &state,
1582
- )
1583
- .unwrap();
1584
-
1585
- assert!(
1586
- !out.ok,
1587
- "0.3.30: positive readback alone must not mark delivered when submit is unverified"
1588
- );
1589
- assert_ne!(out.message_status.0, "delivered");
1590
- let updated = crate::state::persist::load_runtime_state(&ws).unwrap();
1591
- assert_eq!(
1592
- updated.pointer("/coordinator/turn_open/turn_id"),
1593
- Some(&serde_json::json!(message_id)),
1594
- "current-turn fact is armed immediately after physical inject succeeds"
1595
- );
1596
- // Phase-DX E2 rename: the leader→worker turn message id lives under
1597
- // `current_turn_message_id` (the previous name misleadingly implied a task
1598
- // FSM id — that is A1 territory). Same value written by
1599
- // `delivery::arm_turn_open`; the invariant of arming-without-delivered is
1600
- // unchanged.
1601
- assert_eq!(
1602
- updated.pointer("/agents/w1/current_turn_message_id"),
1603
- Some(&serde_json::json!(message_id)),
1604
- "agent current-turn message id is armed without marking the message delivered"
1605
- );
1606
- }
1607
-
1608
- #[test]
1609
- fn deliver_pending_exhausted_unverified_send_emits_failed_event() {
1610
- let ws = tmp_ws("sendfailed");
1611
- let store = store_for(&ws);
1612
- let log = EventLog::new(&ws);
1613
- let state = serde_json::json!({
1614
- "session_name": "team-sendfailed",
1615
- "leader_receiver": {"pane_id": "%leader"},
1616
- "agents": {"w1": {"provider": "fake", "pane_id": "%1"}}
1617
- });
1618
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1619
- let message_id = store
1620
- .create_message(None, "leader", "w1", "ping", None, false, None)
1621
- .unwrap();
1622
-
1623
- let out = deliver_pending_message(
1624
- &ws,
1625
- &store,
1626
- &UnverifiedInjectTransport {
1627
- readback_visible: false,
1628
- },
1629
- &message_id,
1630
- &log,
1631
- &state,
1632
- )
1633
- .unwrap();
1634
-
1635
- assert!(!out.ok);
1636
- assert_eq!(out.message_status.0, "failed");
1637
- let events = log.tail(0).unwrap();
1638
- assert!(
1639
- events.iter().any(
1640
- |event| event.get("event").and_then(serde_json::Value::as_str) == Some("send.failed")
1641
- ),
1642
- "exhausted unverified send must emit send.failed; got {events:?}"
1643
- );
1644
- assert!(
1645
- events.iter().any(
1646
- |event| event.get("event").and_then(serde_json::Value::as_str)
1647
- == Some("send.failed_notification")
1648
- ),
1649
- "exhausted unverified send must queue a leader-visible notification; got {events:?}"
1650
- );
1651
- }
1652
-
1653
- #[test]
1654
- fn slice1_inject_failures_are_bounded_and_stop_retrying_same_message() {
1655
- let ws = tmp_ws("injectstorm");
1656
- let store = store_for(&ws);
1657
- let log = EventLog::new(&ws);
1658
- let state = serde_json::json!({
1659
- "session_name": "team-injectstorm",
1660
- "leader_receiver": {"pane_id": "%leader"},
1661
- "agents": {"w1": {"provider": "fake", "pane_id": "%1"}}
1662
- });
1663
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1664
- let message_id = store
1665
- .create_message(None, "leader", "w1", "ping", None, false, None)
1666
- .unwrap();
1667
- let attempts = std::sync::Arc::new(std::sync::atomic::AtomicUsize::new(0));
1668
- let transport = FailingInjectTransport {
1669
- attempts: std::sync::Arc::clone(&attempts),
1670
- };
1671
-
1672
- for _ in 0..(usize::from(SEND_RETRY_MAX_ATTEMPTS) + 2) {
1673
- let _ = deliver_pending_messages(&ws, &state, &transport, &log).unwrap();
1674
- }
1675
-
1676
- assert_eq!(
1677
- attempts.load(std::sync::atomic::Ordering::Relaxed),
1678
- usize::from(SEND_RETRY_MAX_ATTEMPTS),
1679
- "same message/target must stop retrying after the bounded inject-failure threshold"
1680
- );
1681
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
1682
- let (status, delivery_attempts, error): (String, i64, Option<String>) = conn
1683
- .query_row(
1684
- "select status, delivery_attempts, error from messages where message_id = ?1",
1685
- [&message_id],
1686
- |row| Ok((row.get(0)?, row.get(1)?, row.get(2)?)),
1687
- )
1688
- .unwrap();
1689
- assert_eq!(status, "failed");
1690
- assert_eq!(delivery_attempts, i64::from(SEND_RETRY_MAX_ATTEMPTS));
1691
- assert_eq!(error.as_deref(), Some("send_inject_exhausted"));
1692
- let events = log.tail(0).unwrap();
1693
- let inject_failures = events
1694
- .iter()
1695
- .filter(|event| {
1696
- event.get("event").and_then(serde_json::Value::as_str) == Some("send.inject_failed")
1697
- })
1698
- .count();
1699
- assert_eq!(
1700
- inject_failures,
1701
- usize::from(SEND_RETRY_MAX_ATTEMPTS),
1702
- "failed physical injects should be audited only until the bounded threshold; events={events:?}"
1703
- );
1704
- assert!(
1705
- events.iter().any(|event| {
1706
- event.get("event").and_then(serde_json::Value::as_str) == Some("send.failed")
1707
- && event.get("reason").and_then(serde_json::Value::as_str)
1708
- == Some("send_inject_exhausted")
1709
- }),
1710
- "terminal inject exhaustion must emit send.failed; events={events:?}"
1711
- );
1712
- }
1713
-
1714
- #[test]
1715
- fn target_missing_session_window_blocks_without_generic_inject_exhaustion() {
1716
- let ws = tmp_ws("targetmissing");
1717
- let store = store_for(&ws);
1718
- let log = EventLog::new(&ws);
1719
- let state = serde_json::json!({
1720
- "session_name": "team-targetmissing",
1721
- "leader_receiver": {"pane_id": "%leader"},
1722
- "agents": {"w1": {"provider": "fake", "window": "w1"}}
1723
- });
1724
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1725
- let message_id = store
1726
- .create_message(None, "leader", "w1", "ping", None, false, None)
1727
- .unwrap();
1728
- let transport = OfflineTransport::new()
1729
- .with_session_present(true)
1730
- .with_targets(vec![pane_info("%2", "team-targetmissing", "other")]);
1731
-
1732
- let out = deliver_pending_message(&ws, &store, &transport, &message_id, &log, &state)
1733
- .expect("target-missing classification should be a delivery outcome");
1734
-
1735
- assert!(!out.ok);
1736
- assert_eq!(out.status, DeliveryStatus::Blocked);
1737
- assert_eq!(out.message_status.0, "queued_pane_missing");
1738
- assert_eq!(out.reason, Some(DeliveryRefusal::TmuxTargetMissing));
1739
- assert!(
1740
- transport.inject_targets().is_empty(),
1741
- "target-missing must block before physical inject; targets={:?}",
1742
- transport.inject_targets()
1743
- );
1744
-
1745
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
1746
- let (status, error): (String, Option<String>) = conn
1747
- .query_row(
1748
- "select status, error from messages where message_id = ?1",
1749
- [&message_id],
1750
- |row| Ok((row.get(0)?, row.get(1)?)),
1751
- )
1752
- .unwrap();
1753
- assert_eq!(status, "queued_pane_missing");
1754
- assert_eq!(error.as_deref(), Some("tmux_target_missing"));
1755
- let events = log.tail(0).unwrap();
1756
- assert!(
1757
- events.iter().any(|event| {
1758
- event.get("event").and_then(serde_json::Value::as_str) == Some("send.inject_blocked")
1759
- && event.get("reason").and_then(serde_json::Value::as_str)
1760
- == Some("tmux_target_missing")
1761
- }),
1762
- "target-missing block must be explicit in events; events={events:?}"
1763
- );
1764
- }
1765
-
1766
- #[test]
1767
- fn u1_projection_refused_emits_delivery_event() {
1768
- let ws = tmp_ws("u1projref");
1769
- let store = store_for(&ws);
1770
- let log = EventLog::new(&ws);
1771
- let state = serde_json::json!({
1772
- "session_name": "team-a",
1773
- "active_team_key": "team-a",
1774
- "teams": {
1775
- "team-a": {
1776
- "session_name": "team-a",
1777
- "agents": {"w1": {"provider": "fake", "window": "w1"}}
1778
- }
1779
- },
1780
- "agents": {"w1": {"provider": "fake", "window": "w1"}}
1781
- });
1782
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1783
- let message_id = store
1784
- .create_message(
1785
- None,
1786
- "leader",
1787
- "w1",
1788
- "wrong team",
1789
- None,
1790
- false,
1791
- Some("missing-team"),
1792
- )
1793
- .unwrap();
1794
-
1795
- let delivered = deliver_pending_messages(&ws, &state, &OfflineTransport::new(), &log)
1796
- .expect("projection refusal must not abort the delivery batch");
1797
-
1798
- assert!(
1799
- delivered.is_empty(),
1800
- "the refused owner-team row must not be delivered"
1801
- );
1802
- let events = log.tail(0).unwrap();
1803
- assert!(
1804
- events.iter().any(|event| {
1805
- event.get("event").and_then(serde_json::Value::as_str)
1806
- == Some("delivery.projection_refused")
1807
- && event.get("message_id").and_then(serde_json::Value::as_str)
1808
- == Some(message_id.as_str())
1809
- && event
1810
- .get("owner_team_id")
1811
- .and_then(serde_json::Value::as_str)
1812
- == Some("missing-team")
1813
- }),
1814
- "OwnerTeamProjection::Refused must leave a delivery.projection_refused audit event; events={events:?}"
1815
- );
1816
- }
1817
-
1818
- #[test]
1819
- fn u1_deliver_item_error_does_not_halt_remaining_batch() {
1820
- let ws = tmp_ws("u1itemblock");
1821
- let store = store_for(&ws);
1822
- let log = EventLog::new(&ws);
1823
- let state = serde_json::json!({
1824
- "session_name": "team-u1itemblock",
1825
- "agents": {
1826
- "w1": {"provider": "fake", "window": "w1"},
1827
- "w2": {"provider": "fake", "window": "w2"}
1828
- }
1829
- });
1830
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1831
- let blocked = store
1832
- .create_message(None, "leader", "w1", "poison", None, false, None)
1833
- .unwrap();
1834
- let delivered_id = store
1835
- .create_message(None, "peer", "w2", "still deliver", None, false, None)
1836
- .unwrap();
1837
-
1838
- let state_path = crate::state::persist::runtime_state_path(&ws);
1839
- std::fs::remove_file(&state_path).unwrap();
1840
- std::fs::create_dir(&state_path).unwrap();
1841
- let transport = OfflineTransport::new();
1842
-
1843
- let delivered = deliver_pending_messages(&ws, &state, &transport, &log)
1844
- .expect("one item error must not halt the whole pending batch");
1845
-
1846
- assert_eq!(
1847
- delivered,
1848
- vec![delivered_id.clone()],
1849
- "a poison item must be isolated while later pending rows still deliver"
1850
- );
1851
- let events = log.tail(0).unwrap();
1852
- assert!(
1853
- events.iter().any(|event| {
1854
- event.get("event").and_then(serde_json::Value::as_str) == Some("delivery.item_blocked")
1855
- && event.get("message_id").and_then(serde_json::Value::as_str)
1856
- == Some(blocked.as_str())
1857
- }),
1858
- "the isolated poison item must emit delivery.item_blocked; events={events:?}"
1859
- );
1860
- }
1861
-
1862
- #[test]
1863
- fn u1_resolve_inject_target_uses_live_pane_when_cached_pane_drifted() {
1864
- let ws = tmp_ws("u1drift");
1865
- let store = store_for(&ws);
1866
- let log = EventLog::new(&ws);
1867
- let state = serde_json::json!({
1868
- "session_name": "team-u1drift",
1869
- "agents": {
1870
- "w1": {
1871
- "provider": "fake",
1872
- "pane_id": "%stale",
1873
- "window": "w1"
1874
- }
1875
- }
1876
- });
1877
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1878
- let _ = store
1879
- .create_message(None, "peer", "w1", "drift-safe", None, false, None)
1880
- .unwrap();
1881
- let transport =
1882
- OfflineTransport::new().with_targets(vec![pane_info("%live", "team-u1drift", "w1")]);
1883
-
1884
- let delivered = deliver_pending_messages(&ws, &state, &transport, &log)
1885
- .expect("live target re-resolution must not fail");
1886
-
1887
- assert_eq!(delivered.len(), 1);
1888
- assert_eq!(
1889
- transport.inject_targets(),
1890
- vec![Target::Pane(PaneId::new("%live"))],
1891
- "delivery must validate the cached pane against live targets and re-resolve by session/window when it drifted"
1892
- );
1893
- }
1894
-
1895
- #[test]
1896
- fn e51_delivery_allows_same_pane_id_on_different_tmux_sockets() {
1897
- let ws = tmp_ws("e51diffsocket");
1898
- let store = store_for(&ws);
1899
- let log = EventLog::new(&ws);
1900
- let state = serde_json::json!({
1901
- "session_name": "team-e51",
1902
- "tmux_endpoint": "/private/tmp/tmux-501/ta-worker",
1903
- "leader_receiver": {
1904
- "pane_id": "%0",
1905
- "tmux_socket": "/private/tmp/tmux-501/default"
1906
- },
1907
- "agents": {
1908
- "architect": {
1909
- "provider": "fake",
1910
- "pane_id": "%0",
1911
- "window": "architect"
1912
- }
1913
- }
1914
- });
1915
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1916
- let _ = store
1917
- .create_message(None, "peer", "architect", "socket-aware", None, false, None)
1918
- .unwrap();
1919
- let transport = OfflineTransport::new()
1920
- .with_tmux_endpoint("/private/tmp/tmux-501/ta-worker")
1921
- .with_targets(vec![pane_info("%0", "team-e51", "architect")]);
1922
-
1923
- let delivered = deliver_pending_messages(&ws, &state, &transport, &log)
1924
- .expect("same pane id on different sockets must not poison delivery");
1925
-
1926
- assert_eq!(delivered.len(), 1);
1927
- assert_eq!(
1928
- transport.inject_targets(),
1929
- vec![Target::Pane(PaneId::new("%0"))],
1930
- "E51 must compare pane_id with tmux_socket; different sockets are not a leader conflict"
1931
- );
1932
- }
1933
-
1934
- #[test]
1935
- fn e51_delivery_keeps_same_socket_pane_conflict_guard() {
1936
- let ws = tmp_ws("e51samesocket");
1937
- let store = store_for(&ws);
1938
- let log = EventLog::new(&ws);
1939
- let socket = "/private/tmp/tmux-501/default";
1940
- let state = serde_json::json!({
1941
- "session_name": "team-e51",
1942
- "tmux_endpoint": socket,
1943
- "leader_receiver": {
1944
- "pane_id": "%0",
1945
- "tmux_socket": socket
1946
- },
1947
- "agents": {
1948
- "architect": {
1949
- "provider": "fake",
1950
- "pane_id": "%0",
1951
- "window": "architect"
1952
- }
1953
- }
1954
- });
1955
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1956
- let _ = store
1957
- .create_message(None, "peer", "architect", "same-socket", None, false, None)
1958
- .unwrap();
1959
- let transport = OfflineTransport::new()
1960
- .with_tmux_endpoint(socket)
1961
- .with_targets(vec![pane_info("%0", "team-e51", "architect")]);
1962
-
1963
- let delivered = deliver_pending_messages(&ws, &state, &transport, &log)
1964
- .expect("same-socket E51 guard should still resolve to a structured target");
1965
-
1966
- assert_eq!(delivered.len(), 1);
1967
- assert_eq!(
1968
- transport.inject_targets(),
1969
- vec![Target::SessionWindow {
1970
- session: SessionName::new("team-e51"),
1971
- window: WindowName::new("architect_pane_conflicts_with_leader"),
1972
- }],
1973
- "same pane id on the same socket must keep the E51 loop guard"
1974
- );
1975
- }
1976
-
1977
- fn app_server_state(
1978
- ws: &Path,
1979
- endpoint: &str,
1980
- thread_id: &str,
1981
- session_id: &str,
1982
- ) -> serde_json::Value {
1983
- serde_json::json!({
1984
- "active_team_key": "team-a",
1985
- "teams": {
1986
- "team-a": {
1987
- "team_key": "team-a",
1988
- "agents": {},
1989
- "leader_receiver": {
1990
- "mode": "codex_app_server",
1991
- "transport_kind": "codex_app_server",
1992
- "status": "attached",
1993
- "provider": "codex",
1994
- "owner_epoch": 7,
1995
- "app_server": {
1996
- "socket": endpoint,
1997
- "thread_id": thread_id,
1998
- "session_id": session_id,
1999
- "cwd": ws.to_string_lossy(),
2000
- "cli_version": "codex-appserver-team-agent-test/0.139.0",
2001
- "bound_at": "2026-07-05T00:00:00Z"
2002
- }
2003
- },
2004
- "team_owner": {
2005
- "provider": "codex",
2006
- "transport_kind": "codex_app_server",
2007
- "owner_epoch": 7
2008
- },
2009
- "owner_epoch": 7
2010
- }
2011
- }
2012
- })
2013
- }
2014
-
2015
- // 0.5.x Windows portability Batch 5: FakeAppServer uses Unix domain
2016
- // sockets — Unix-only.
2017
- #[cfg(unix)]
2018
- #[test]
2019
- fn app_server_leader_delivery_marks_delivered_without_tmux_transport() {
2020
- let ws = tmp_ws("appdeliver");
2021
- let fake = crate::app_server_test_support::FakeAppServer::start(
2022
- "deliver-ok",
2023
- crate::app_server_test_support::FakeAppServerScript::happy(
2024
- "thread-live",
2025
- "session-live",
2026
- ws.to_str().unwrap(),
2027
- ),
2028
- );
2029
- let state = app_server_state(&ws, fake.endpoint(), "thread-live", "session-live");
2030
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2031
- let store = store_for(&ws);
2032
- let log = EventLog::new(&ws);
2033
- let message_id = store
2034
- .create_message(
2035
- None,
2036
- "worker_a",
2037
- "leader",
2038
- "app server hello",
2039
- None,
2040
- false,
2041
- Some("team-a"),
2042
- )
2043
- .unwrap();
2044
-
2045
- let out = deliver_pending_message(&ws, &store, &NoopTransport, &message_id, &log, &state)
2046
- .expect("app-server delivery should not require tmux transport");
2047
-
2048
- assert!(
2049
- out.ok,
2050
- "app-server turn/start acceptance is delivery proof: {out:?}"
2051
- );
2052
- assert_eq!(out.message_status.0, "delivered");
2053
- assert_eq!(out.channel.as_deref(), Some("codex_app_server"));
2054
- let turns = fake.received_turns();
2055
- assert_eq!(turns.len(), 1);
2056
- assert_eq!(
2057
- turns[0]["params"]["clientUserMessageId"],
2058
- serde_json::json!(message_id)
2059
- );
2060
- let events = log.tail(0).unwrap();
2061
- assert!(
2062
- events.iter().any(|event| {
2063
- event.get("event").and_then(serde_json::Value::as_str)
2064
- == Some("leader_receiver.app_server_submitted")
2065
- }),
2066
- "delivery must emit app-server submission event; events={events:?}"
2067
- );
2068
- }
2069
-
2070
- #[cfg(unix)]
2071
- #[test]
2072
- fn app_server_leader_delivery_stale_tuple_fails_closed_with_event() {
2073
- let ws = tmp_ws("appstale");
2074
- let fake = crate::app_server_test_support::FakeAppServer::start(
2075
- "deliver-stale",
2076
- crate::app_server_test_support::FakeAppServerScript::happy(
2077
- "thread-live",
2078
- "session-new",
2079
- ws.to_str().unwrap(),
2080
- ),
2081
- );
2082
- let state = app_server_state(&ws, fake.endpoint(), "thread-live", "session-old");
2083
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2084
- let store = store_for(&ws);
2085
- let log = EventLog::new(&ws);
2086
- let message_id = store
2087
- .create_message(
2088
- None,
2089
- "worker_a",
2090
- "leader",
2091
- "stale",
2092
- None,
2093
- false,
2094
- Some("team-a"),
2095
- )
2096
- .unwrap();
2097
-
2098
- let out = deliver_pending_message(&ws, &store, &NoopTransport, &message_id, &log, &state)
2099
- .expect("stale app-server binding should be a business failure, not panic");
2100
-
2101
- assert!(!out.ok);
2102
- assert_eq!(out.channel.as_deref(), Some("rebind_required"));
2103
- assert_eq!(out.message_status.0, "failed");
2104
- let events = log.tail(0).unwrap();
2105
- assert!(
2106
- events.iter().any(|event| {
2107
- event.get("event").and_then(serde_json::Value::as_str)
2108
- == Some("leader_receiver.app_server_thread_stale")
2109
- && event.get("message_id").and_then(serde_json::Value::as_str)
2110
- == Some(message_id.as_str())
2111
- }),
2112
- "stale app-server tuple must emit app_server_thread_stale; events={events:?}"
2113
- );
2114
- }
2115
-
2116
- #[test]
2117
- fn app_server_leader_delivery_fails_closed_on_mode_transport_conflict() {
2118
- let ws = tmp_ws("appconflict");
2119
- let mut state = app_server_state(
2120
- &ws,
2121
- "unix:///tmp/team-agent-should-not-connect.sock",
2122
- "thread-live",
2123
- "session-live",
2124
- );
2125
- state["teams"]["team-a"]["leader_receiver"]["mode"] = serde_json::json!("direct_tmux");
2126
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2127
- let store = store_for(&ws);
2128
- let log = EventLog::new(&ws);
2129
- let message_id = store
2130
- .create_message(
2131
- None,
2132
- "worker_a",
2133
- "leader",
2134
- "conflict",
2135
- None,
2136
- false,
2137
- Some("team-a"),
2138
- )
2139
- .unwrap();
2140
-
2141
- let out = deliver_pending_message(&ws, &store, &NoopTransport, &message_id, &log, &state)
2142
- .expect("transport conflict should be a business failure");
2143
-
2144
- assert!(!out.ok);
2145
- assert_eq!(out.channel.as_deref(), Some("rebind_required"));
2146
- assert_eq!(out.message_status.0, "failed");
2147
- assert_eq!(
2148
- out.verification.as_deref(),
2149
- Some("run team-agent claim-leader, takeover, or attach-app-server-leader")
2150
- );
2151
- let events = log.tail(0).unwrap();
2152
- assert!(
2153
- events.iter().any(|event| {
2154
- event.get("event").and_then(serde_json::Value::as_str)
2155
- == Some("leader_receiver.delivery_blocked")
2156
- && event.get("reason").and_then(serde_json::Value::as_str)
2157
- == Some("leader_receiver_transport_conflict")
2158
- }),
2159
- "transport conflict must emit explicit fail-closed event; events={events:?}"
2160
- );
2161
- }
2162
-
2163
- #[cfg(unix)]
2164
- #[test]
2165
- fn app_server_leader_busy_is_retryable_and_does_not_steer() {
2166
- let ws = tmp_ws("appbusy");
2167
- let mut script = crate::app_server_test_support::FakeAppServerScript::happy(
2168
- "thread-live",
2169
- "session-live",
2170
- ws.to_str().unwrap(),
2171
- );
2172
- script.turn_error = Some("thread already has an active turn".to_string());
2173
- let fake = crate::app_server_test_support::FakeAppServer::start("deliver-busy", script);
2174
- let state = app_server_state(&ws, fake.endpoint(), "thread-live", "session-live");
2175
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2176
- let store = store_for(&ws);
2177
- let log = EventLog::new(&ws);
2178
- let message_id = store
2179
- .create_message(
2180
- None,
2181
- "worker_a",
2182
- "leader",
2183
- "busy",
2184
- None,
2185
- false,
2186
- Some("team-a"),
2187
- )
2188
- .unwrap();
2189
-
2190
- let out = deliver_pending_message(&ws, &store, &NoopTransport, &message_id, &log, &state)
2191
- .expect("leader busy should be retryable");
2192
-
2193
- assert!(!out.ok);
2194
- assert_eq!(out.status, DeliveryStatus::RetryScheduled);
2195
- assert_eq!(out.channel.as_deref(), Some("leader_busy"));
2196
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
2197
- let status: String = conn
2198
- .query_row(
2199
- "select status from messages where message_id = ?1",
2200
- [&message_id],
2201
- |row| row.get(0),
2202
- )
2203
- .unwrap();
2204
- assert_eq!(status, "target_resolved", "busy leader remains retryable");
2205
- let turns = fake.received_turns();
2206
- assert_eq!(
2207
- turns.len(),
2208
- 1,
2209
- "must only call turn/start, never turn/steer"
2210
- );
2211
- assert_eq!(turns[0]["method"], serde_json::json!("turn/start"));
2212
- }
2213
-
2214
- #[test]
2215
- fn u1_multi_team_send_does_not_backfill_top_level_leader_binding() {
2216
- let ws = tmp_ws("u1backfill");
2217
- crate::state::persist::save_runtime_state(
2218
- &ws,
2219
- &serde_json::json!({
2220
- "session_name": "team-a",
2221
- "active_team_key": "team-a",
2222
- "leader_receiver": {"status": "unbound", "pane_id": "__team_agent_unbound__"},
2223
- "team_owner": {"pane_id": "__team_agent_unbound__"},
2224
- "teams": {
2225
- "team-a": {
2226
- "session_name": "team-a",
2227
- "leader_receiver": {"status": "unbound", "pane_id": "__team_agent_unbound__"},
2228
- "agents": {}
2229
- },
2230
- "team-b": {
2231
- "session_name": "team-b",
2232
- "agents": {}
2233
- }
2234
- },
2235
- "agents": {}
2236
- }),
2237
- )
2238
- .unwrap();
2239
- let opts = SendOptions {
2240
- team: Some(TeamKey::new("team-b")),
2241
- requires_ack: false,
2242
- ..SendOptions::default()
2243
- };
2244
-
2245
- let out = send_message(
2246
- &ws,
2247
- &MessageTarget::Single("leader".to_string()),
2248
- "hello team-b",
2249
- &opts,
2250
- )
2251
- .unwrap();
2252
-
2253
- assert_eq!(
2254
- out.status,
2255
- DeliveryStatus::Queued,
2256
- "team-b leader send must not inherit team-a/top-level unbound leader binding"
2257
- );
2258
- let message_id = out.message_id.expect("queued leader message id");
2259
- let store = store_for(&ws);
2260
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
2261
- let owner_team_id: Option<String> = conn
2262
- .query_row(
2263
- "select owner_team_id from messages where message_id = ?1",
2264
- [&message_id],
2265
- |row| row.get(0),
2266
- )
2267
- .unwrap();
2268
- assert_eq!(owner_team_id.as_deref(), Some("team-b"));
2269
- }
2270
-
2271
- #[test]
2272
- fn casefile_leader_send_is_durable_without_entering_leader_funnel() {
2273
- let ws = tmp_ws("casefile-send");
2274
- crate::state::persist::save_runtime_state(
2275
- &ws,
2276
- &serde_json::json!({
2277
- "session_name": "team-a",
2278
- "active_team_key": "team-a",
2279
- "agents": {}
2280
- }),
2281
- )
2282
- .unwrap();
2283
- let opts = SendOptions {
2284
- team: Some(TeamKey::new("team-a")),
2285
- requires_ack: false,
2286
- presentation: crate::messaging::presentation::PresentationRequest {
2287
- sink: crate::messaging::presentation::PresentationSink::Casefile,
2288
- class: crate::messaging::presentation::PresentationClass::Progress,
2289
- case_id: Some("case-1".to_string()),
2290
- },
2291
- ..SendOptions::default()
2292
- };
2293
- let out = send_message(
2294
- &ws,
2295
- &MessageTarget::Single("leader".to_string()),
2296
- "internal progress",
2297
- &opts,
2298
- )
2299
- .unwrap();
2300
- assert_eq!(out.status, DeliveryStatus::StoredOnly);
2301
- assert_eq!(out.message_status.0, "stored_only");
2302
- let store = store_for(&ws);
2303
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
2304
- let (status, presentation): (String, String) = conn
2305
- .query_row(
2306
- "select status, presentation from messages where message_id = ?1",
2307
- [out.message_id.as_deref().unwrap()],
2308
- |row| Ok((row.get(0)?, row.get(1)?)),
2309
- )
2310
- .unwrap();
2311
- assert_eq!(status, "stored_only");
2312
- assert_eq!(
2313
- serde_json::from_str::<serde_json::Value>(&presentation).unwrap()["effective_sink"],
2314
- "casefile"
2315
- );
2316
- }
2317
-
2318
- // ════════════════════════════════════════════════════════════════════════
2319
- // GROUP V — retry_result_deliveries: re-route notify_failed watchers with
2320
- // dedupe_reason rebind_retry. result_delivery.py:19-35.
2321
- // ════════════════════════════════════════════════════════════════════════
2322
-
2323
- #[test]
2324
- fn retry_result_deliveries_retries_notify_failed_watcher() {
2325
- // SEEDED contract (result_delivery.py:18-34): retry_result_deliveries scans
2326
- // retryable_result_watchers (status in pending/notify_failed), resolves each
2327
- // watcher's result via result_by_id, and re-routes through notify_result_watchers
2328
- // with dedupe_reason="rebind_retry". Seed a notify_failed watcher + its matching
2329
- // result row → the watcher IS retried and a WatcherNotice for it is returned.
2330
- // Probed golden: notices == [{watcher_id, result_id, ok, ...}] for the seeded
2331
- // watcher (delivery ok depends on full team state; the retry-was-attempted
2332
- // contract is the invariant — an empty store would NOT exercise it).
2333
- let ws = tmp_ws("retrydeliv");
2334
- let store = store_for(&ws);
2335
- let log = EventLog::new(&ws);
2336
-
2337
- let rid = seed_result(&store, "res_r1", "t1", "alice", "success");
2338
- let w = seed_watcher(
2339
- &store,
2340
- "w-failed",
2341
- "team-a",
2342
- "t1",
2343
- "alice",
2344
- "notify_failed",
2345
- Some(&rid),
2346
- None,
2347
- );
2348
-
2349
- let notices = retry_result_deliveries(&ws, &log).unwrap();
2350
-
2351
- assert_eq!(
2352
- notices.len(),
2353
- 1,
2354
- "the single notify_failed watcher must be retried"
2355
- );
2356
- let notice = &notices[0];
2357
- assert_eq!(
2358
- notice.watcher_id, w,
2359
- "the retried notice names the seeded watcher"
2360
- );
2361
- assert_eq!(
2362
- notice.result_id.as_deref(),
2363
- Some(rid.as_str()),
2364
- "retry resolves and carries the watcher's result_id (rebind_retry path)"
2365
- );
2366
- }
2367
-
2368
- // ════════════════════════════════════════════════════════════════════════
2369
- // GROUP X — delivered_result_message content-level dedupe lookup +
2370
- // result_id_from_text dual (scheduler send dedupe path). result_delivery.py:394.
2371
- // ════════════════════════════════════════════════════════════════════════
2372
-
2373
- #[test]
2374
- fn delivered_result_message_none_in_fresh_store() {
2375
- let ws = tmp_ws("delivdedupe");
2376
- let store = store_for(&ws);
2377
- let found = delivered_result_message(&store, "r1", None, None).unwrap();
2378
- assert!(found.is_none());
2379
- }
2380
-
2381
- #[test]
2382
- fn delivered_result_message_empty_result_id_is_none() {
2383
- // result_delivery.py:401-402 — empty result_id short-circuits to None.
2384
- let ws = tmp_ws("delivdedupe2");
2385
- let store = store_for(&ws);
2386
- let found = delivered_result_message(&store, "", None, None).unwrap();
2387
- assert!(found.is_none());
2388
- }
2389
-
2390
- // ═══════════════════════════════════════════════════════════════════════════
2391
- // collect #223 — task-scoped collect + send --task validation (RED).
2392
- // ═══════════════════════════════════════════════════════════════════════════
2393
-
2394
- // (c) a result whose task_id ∈ state.tasks collects as scope:"task"; the task row advances to
2395
- // "done" (success → done, runtime.py:1066); results.collected ≥ 1. Proves the collect-READ works
2396
- // once state.tasks is seeded — so the #223 fix target is the upstream seeding, not collect.
2397
- #[test]
2398
- fn collect_task_scoped_result_collects_and_marks_task_done() {
2399
- let ws = tmp_ws("collecttask223");
2400
- std::fs::write(ws.join("team.spec.yaml"), "version: 1\n").unwrap();
2401
- crate::state::persist::save_runtime_state(
2402
- &ws,
2403
- &serde_json::json!({
2404
- "session_name": "team-x",
2405
- "agents": { "w1": { "provider": "copilot" } },
2406
- "tasks": [ { "id": "t2", "assignee": "w1", "title": "t2", "status": "pending" } ]
2407
- }),
2408
- )
2409
- .unwrap();
2410
- let store = store_for(&ws);
2411
- seed_result(&store, "res_t2", "t2", "w1", "success");
2412
-
2413
- let out = collect(&ws, None, false).unwrap();
2414
- assert_eq!(
2415
- out.get("ok").and_then(|v| v.as_bool()),
2416
- Some(true),
2417
- "no invalid → ok:true"
2418
- );
2419
- let cr = out
2420
- .get("collected_results")
2421
- .and_then(|v| v.as_array())
2422
- .expect("collected_results");
2423
- assert_eq!(cr.len(), 1, "the seeded t2 result must collect");
2424
- assert_eq!(
2425
- cr[0].get("scope").and_then(|v| v.as_str()),
2426
- Some("task"),
2427
- "t2 ∈ state.tasks → scope:task"
2428
- );
2429
- assert_eq!(cr[0].get("task_id").and_then(|v| v.as_str()), Some("t2"));
2430
- assert_eq!(cr[0].get("agent_id").and_then(|v| v.as_str()), Some("w1"));
2431
- assert!(
2432
- out.get("results")
2433
- .and_then(|r| r.get("collected"))
2434
- .and_then(|v| v.as_i64())
2435
- .unwrap_or(0)
2436
- >= 1,
2437
- "results.collected must be ≥ 1"
2438
- );
2439
- let st = crate::state::persist::load_runtime_state(&ws).unwrap();
2440
- let t2_status = st
2441
- .get("tasks")
2442
- .and_then(|v| v.as_array())
2443
- .and_then(|ts| {
2444
- ts.iter()
2445
- .find(|t| t.get("id").and_then(|v| v.as_str()) == Some("t2"))
2446
- })
2447
- .and_then(|t| t.get("status"))
2448
- .and_then(|v| v.as_str());
2449
- assert_eq!(
2450
- t2_status,
2451
- Some("done"),
2452
- "success result → task row status 'done' (runtime.py:1066)"
2453
- );
2454
- }
2455
-
2456
- // (c-C1) collect OUTPUT shape: collected_results entries are the 8-KEY SUMMARY (NO inlined
2457
- // envelope; carry summary+tests) and the full envelopes live in a SEPARATE top-level `collected`
2458
- // list (golden results.py:86/131). Rust inlines `envelope`+`owner_team_id` and emits no
2459
- // `collected` list → RED.
2460
- #[test]
2461
- fn collect_output_matches_golden_collected_shape() {
2462
- let ws = tmp_ws("collectshape223");
2463
- std::fs::write(ws.join("team.spec.yaml"), "version: 1\n").unwrap();
2464
- crate::state::persist::save_runtime_state(
2465
- &ws,
2466
- &serde_json::json!({
2467
- "session_name": "team-x",
2468
- "agents": { "w1": { "provider": "copilot" } },
2469
- "tasks": [ { "id": "t2", "assignee": "w1", "title": "t2", "status": "pending" } ]
2470
- }),
2471
- )
2472
- .unwrap();
2473
- let store = store_for(&ws);
2474
- seed_result(&store, "res_t2s", "t2", "w1", "success");
2475
-
2476
- let out = collect(&ws, None, false).unwrap();
2477
- let cr = out
2478
- .get("collected_results")
2479
- .and_then(|v| v.as_array())
2480
- .expect("collected_results");
2481
- let e = &cr[0];
2482
- // C1: collected_results entry is the 8-key SUMMARY — NO envelope inlined; carries summary+tests.
2483
- assert!(e.get("envelope").is_none(),
2484
- "collected_results entry must NOT inline `envelope` (golden 8-key summary); the full envelope belongs in `collected`. got {e:?}");
2485
- assert!(
2486
- e.get("summary").is_some() && e.get("tests").is_some(),
2487
- "collected_results summary entry must carry `summary`+`tests` (golden results.py:131)"
2488
- );
2489
- // C1: the full envelopes live in a separate top-level `collected` list.
2490
- let collected = out
2491
- .get("collected")
2492
- .and_then(|v| v.as_array())
2493
- .expect("golden collect returns a top-level `collected` list of full envelopes");
2494
- assert!(
2495
- collected
2496
- .first()
2497
- .and_then(|env| env.get("schema_version"))
2498
- .and_then(|v| v.as_str())
2499
- == Some("result_envelope_v1"),
2500
- "collected[0] must be the full result_envelope_v1 envelope; got {collected:?}"
2501
- );
2502
-
2503
- // ── STRENGTHENED (option-B byte-parity, leader-adjudicated 0700cff review) ──
2504
- // D3 — task-scope collected_results entry must be EXACTLY the golden 8 keys, in order, NO task_status.
2505
- let keys: Vec<&str> = e
2506
- .as_object()
2507
- .expect("entry is an object")
2508
- .keys()
2509
- .map(String::as_str)
2510
- .collect();
2511
- assert_eq!(
2512
- keys,
2513
- vec!["result_id", "task_id", "agent_id", "status", "summary", "tests", "created_at", "scope"],
2514
- "collected_results entry must be EXACTLY the golden 8 keys in order (results.py:131; no task_status/envelope/owner_team_id); got {keys:?}"
2515
- );
2516
- // D1+D2 — collect RETURN top-level key order must match golden EXACTLY: delivered_messages BEFORE
2517
- // invalid_results, AND a `coordinator` key (mirroring golden _ensure_coordinator_after_collect).
2518
- let top: Vec<&str> = out
2519
- .as_object()
2520
- .expect("collect result is an object")
2521
- .keys()
2522
- .map(String::as_str)
2523
- .collect();
2524
- assert_eq!(
2525
- top,
2526
- vec![
2527
- "ok",
2528
- "collected",
2529
- "collected_results",
2530
- "delivered_messages",
2531
- "invalid_results",
2532
- "results",
2533
- "state_file",
2534
- "coordinator"
2535
- ],
2536
- "collect return top-level key order must match golden return shape; got {top:?}"
2537
- );
2538
- }
2539
-
2540
- // (d) send --task <unknown id> must RAISE golden "unknown task id" (runtime.py:1032 _find_task),
2541
- // not silently create a message. Rust send_message attaches task_id without validating → Ok. RED.
2542
- // block_until_delivered=false isolates the task-validation from any delivery side-effect.
2543
- #[test]
2544
- fn send_with_unknown_task_id_raises_unknown_task() {
2545
- let ws = tmp_ws("sendunknowntask223");
2546
- crate::state::persist::save_runtime_state(
2547
- &ws,
2548
- &serde_json::json!({
2549
- "session_name": "team-x",
2550
- "agents": { "w1": { "provider": "copilot" } },
2551
- "tasks": []
2552
- }),
2553
- )
2554
- .unwrap();
2555
- let _ = store_for(&ws);
2556
- let opts = SendOptions {
2557
- task_id: Some(crate::model::ids::TaskId::new("t2-unknown")),
2558
- block_until_delivered: false,
2559
- ..SendOptions::default()
2560
- };
2561
- let out = send_message(&ws, &MessageTarget::Single("w1".to_string()), "go", &opts);
2562
- match out {
2563
- Err(e) => {
2564
- // SURFACED error = the CLI `error` field = CliError::from(MessagingError).to_string()
2565
- // (to_payload uses self.to_string(), types.rs:59). Must EQUAL golden's bare message —
2566
- // NO "validation:" variant prefix (golden runtime.py:1032 surfaces str(exc)).
2567
- let surfaced = crate::cli::CliError::from(e).to_string();
2568
- assert_eq!(
2569
- surfaced, "unknown task id: t2-unknown",
2570
- "surfaced CLI error must EQUAL golden's message with NO variant prefix; got {surfaced:?}"
2571
- );
2572
- }
2573
- Ok(o) => panic!(
2574
- "send --task <unknown id> must RAISE 'unknown task id' (golden runtime.py:1032 _find_task), \
2575
- not silently create a message; got Ok({o:?})"
2576
- ),
2577
- }
2578
- }
2579
-
2580
- // ════════════════════════════════════════════════════════════════════════
2581
- // P0 REGRESSION (0700cff "send 0 bytes, nothing queued" / coordinator never delivers).
2582
- // golden gates the unknown-task RAISE on route_task_id (send.py:204 `if task_id and route_task_id`);
2583
- // delivery/fanout/internal sends pass route_task_id=False (internal_delivery.py:44, send.py:412/481)
2584
- // → the task is a label, NOT validated. 0700cff's UNCONDITIONAL task_exists gate broke every
2585
- // task-tagged delivery/internal send at CREATION time. The gate the OfflineTransport tests missed.
2586
- // ════════════════════════════════════════════════════════════════════════
2587
-
2588
- // (a) [REGRESSION GATE] route_task_id=false + task_id NOT in state.tasks → send SUCCEEDS and the
2589
- // message is QUEUED (real create path; no transport). Must NOT raise "unknown task id".
2590
- #[test]
2591
- fn send_route_task_id_false_skips_task_validation_and_queues() {
2592
- let ws = tmp_ws("sendroutefalse");
2593
- crate::state::persist::save_runtime_state(
2594
- &ws,
2595
- &serde_json::json!({ "session_name": "team-x", "agents": { "w1": { "provider": "copilot" } }, "tasks": [] }),
2596
- ).unwrap();
2597
- let _ = store_for(&ws);
2598
- let opts = SendOptions {
2599
- task_id: Some(crate::model::ids::TaskId::new("t-not-seeded")),
2600
- route_task_id: false,
2601
- block_until_delivered: false,
2602
- ..SendOptions::default()
2603
- };
2604
- let out = send_message(&ws, &MessageTarget::Single("w1".to_string()), "deliver me", &opts)
2605
- .expect("route_task_id=false must NOT validate the task — golden delivery/internal path queues regardless of state.tasks");
2606
- assert!(
2607
- out.message_id.is_some(),
2608
- "the message must be CREATED (message_id present) on the route_task_id=false path; got {out:?}"
2609
- );
2610
- // real queue verification (not an Ok shell): the message landed in w1's inbox.
2611
- let inbox = store_for(&ws).inbox("w1", 10, None).expect("inbox");
2612
- assert!(
2613
- !inbox.is_empty(),
2614
- "the task-tagged message must be QUEUED for w1 on the delivery/internal path; inbox empty (0 bytes queued = the P0)"
2615
- );
2616
- }
2617
-
2618
- // (c) [LOCK] route_task_id=true + task_id IN state.tasks → send SUCCEEDS (routing happy-path).
2619
- #[test]
2620
- fn send_route_task_id_true_known_task_succeeds() {
2621
- let ws = tmp_ws("sendrouteknown");
2622
- crate::state::persist::save_runtime_state(
2623
- &ws,
2624
- &serde_json::json!({
2625
- "session_name": "team-x",
2626
- "agents": { "w1": { "provider": "copilot" } },
2627
- "tasks": [ { "id": "t-known", "assignee": "w1", "title": "t", "status": "pending" } ]
2628
- }),
2629
- )
2630
- .unwrap();
2631
- let _ = store_for(&ws);
2632
- let opts = SendOptions {
2633
- task_id: Some(crate::model::ids::TaskId::new("t-known")),
2634
- route_task_id: true,
2635
- block_until_delivered: false,
2636
- ..SendOptions::default()
2637
- };
2638
- let out = send_message(&ws, &MessageTarget::Single("w1".to_string()), "go", &opts)
2639
- .expect("route_task_id=true with a KNOWN task must succeed");
2640
- assert!(
2641
- out.message_id.is_some(),
2642
- "known-task routing send must create the message; got {out:?}"
2643
- );
2644
- }
2645
-
2646
- // ════════════════════════════════════════════════════════════════════════
2647
- // R8 byte-parity (leader attach requeue, advisor-ruled + e3eac28-reconciled):
2648
- // drive a watcher to delivery_exhausted via notify_result_watchers (attempts>=MAX) — proving the
2649
- // requeue input is REAL (non-空过) — then attach-requeue and assert the golden observable contract:
2650
- // D2 status: delivery_exhausted -> notify_failed (golden result_watchers.py:95), NOT 'pending'.
2651
- // D1 ✦ team-scoped + unnotified SELECTION (anti cross-team pollution / CP-1) — KEEP.
2652
- // D3 result_watcher.requeued payload == golden attach form {watcher_id, trigger:"attach_leader", new_pane_id}.
2653
- // (D4 leader_receiver.requeued_exhausted_watchers + D6 string return are the attach-wrapper/CLI layer —
2654
- // lease.rs:140 + cli/mod.rs:1088 — flagged for the porter; D5 event-layer is internal/optional.)
2655
- // ════════════════════════════════════════════════════════════════════════
2656
- #[test]
2657
- fn r8_attach_requeue_exhausted_to_notify_failed_golden_attach_event() {
2658
- let ws = tmp_ws("r8requeue");
2659
- let store = store_for(&ws);
2660
- let log = EventLog::new(&ws);
2661
- let team = TeamKey::new("team-a");
2662
- let pane = PaneId::new("%leader-new");
2663
-
2664
- // --- Sub-A: DRIVE w-r8 (team-a) to delivery_exhausted via notify_result_watchers (attempts>=MAX) ---
2665
- let rid = seed_result(&store, "res_r8", "t1", "alice", "success");
2666
- seed_watcher(
2667
- &store,
2668
- "w-r8",
2669
- "team-a",
2670
- "t1",
2671
- "alice",
2672
- "pending",
2673
- Some(&rid),
2674
- None,
2675
- );
2676
- // attempts are EVENT-counted (result_watcher.notify_failed/retry_notified) — seed MAX prior failures.
2677
- for n in 0..u64::from(RESULT_DELIVERY_MAX_ATTEMPTS) {
2678
- log.write(
2679
- "result_watcher.notify_failed",
2680
- json(serde_json::json!({"watcher_id": "w-r8", "result_id": rid.as_str(), "status": "notify_failed", "error": "x", "n": n})),
2681
- ).unwrap();
2682
- }
2683
- let result_env =
2684
- json(serde_json::json!({"result_id": rid.as_str(), "task_id": "t1", "agent_id": "alice"}));
2685
- let watcher_view = json(serde_json::json!({
2686
- "watcher_id": "w-r8", "task_id": "t1", "agent_id": "alice",
2687
- "created_at": "2026-01-01T00:00:00Z", "owner_team_id": "team-a",
2688
- "leader_id": "leader", "result_id": rid.as_str()
2689
- }));
2690
- notify_result_watchers(&ws, &result_env, &log, Some(&[watcher_view]), None).unwrap();
2691
- let (driven, _) = watcher_state(&store, "w-r8");
2692
- assert_eq!(driven, "delivery_exhausted",
2693
- "PRECONDITION: notify_result_watchers at attempts>=MAX must persist delivery_exhausted (watchers.rs:161-168) — \
2694
- proves the attach-requeue input is real, not 空过");
2695
-
2696
- // selection-lock fixtures: cross-team exhausted + notified exhausted (Gap-32) + pending.
2697
- let team_b = seed_watcher(
2698
- &store,
2699
- "w-teamb",
2700
- "team-b",
2701
- "t2",
2702
- "bob",
2703
- "delivery_exhausted",
2704
- Some("res_b"),
2705
- None,
2706
- );
2707
- let notif = seed_watcher(
2708
- &store,
2709
- "w-notified",
2710
- "team-a",
2711
- "t3",
2712
- "carol",
2713
- "delivery_exhausted",
2714
- Some("res_c"),
2715
- Some("msg_done"),
2716
- );
2717
- seed_watcher(
2718
- &store,
2719
- "w-pending",
2720
- "team-a",
2721
- "t4",
2722
- "dave",
2723
- "pending",
2724
- Some("res_d"),
2725
- None,
2726
- );
2727
-
2728
- // --- Sub-B: attach requeue (golden contract) ---
2729
- let requeued = requeue_delivery_exhausted_watchers(&ws, &store, &log, &team, &pane).unwrap();
2730
-
2731
- // D2: team-a exhausted -> notify_failed (NOT pending).
2732
- let (st_a, _) = watcher_state(&store, "w-r8");
2733
- assert_eq!(st_a, "notify_failed",
2734
- "D2: attach requeue must flip delivery_exhausted -> 'notify_failed' (golden result_watchers.py:95), not 'pending'");
2735
- // D1 ✦ team-scoped: cross-team exhausted watcher must NOT requeue onto team-a's pane.
2736
- let (st_b, _) = watcher_state(&store, &team_b);
2737
- assert_eq!(st_b, "delivery_exhausted",
2738
- "D1 ✦: team-scoped selection — a team-b exhausted watcher must NOT be requeued by a team-a attach (anti cross-team pollution / CP-1)");
2739
- // Gap-32: a notified watcher is never requeued; its notified_message_id survives.
2740
- let (st_n, nid) = watcher_state(&store, &notif);
2741
- assert_eq!(
2742
- st_n, "delivery_exhausted",
2743
- "Gap-32: notified watcher not requeued"
2744
- );
2745
- assert_eq!(
2746
- nid.as_deref(),
2747
- Some("msg_done"),
2748
- "Gap-32: notified_message_id preserved"
2749
- );
2750
- // only the team-a unnotified exhausted watcher requeues.
2751
- let ids: Vec<&str> = requeued.iter().map(|n| n.watcher_id.as_str()).collect();
2752
- assert_eq!(
2753
- ids,
2754
- vec!["w-r8"],
2755
- "only team-a unnotified delivery_exhausted watcher requeues"
2756
- );
2757
-
2758
- // D3: result_watcher.requeued payload == golden ATTACH form {watcher_id, trigger, new_pane_id}.
2759
- let events = log.tail(0).unwrap();
2760
- let ev = events
2761
- .iter()
2762
- .rev()
2763
- .find(|e| e.get("event").and_then(|v| v.as_str()) == Some("result_watcher.requeued"))
2764
- .expect("result_watcher.requeued event");
2765
- let keys: std::collections::BTreeSet<&str> = ev
2766
- .as_object()
2767
- .unwrap()
2768
- .keys()
2769
- .map(String::as_str)
2770
- .filter(|k| *k != "ts" && *k != "event")
2771
- .collect();
2772
- let expected: std::collections::BTreeSet<&str> = ["watcher_id", "trigger", "new_pane_id"]
2773
- .into_iter()
2774
- .collect();
2775
- assert_eq!(keys, expected,
2776
- "D3: result_watcher.requeued must be golden ATTACH form {{watcher_id, trigger, new_pane_id}} (leader/__init__.py:46-50), not claim-style; got {keys:?}");
2777
- assert_eq!(
2778
- ev.get("trigger").and_then(|v| v.as_str()),
2779
- Some("attach_leader")
2780
- );
2781
- assert_eq!(
2782
- ev.get("new_pane_id").and_then(|v| v.as_str()),
2783
- Some("%leader-new")
2784
- );
2785
- }
2786
-
2787
- // E15/E23 single-funnel guard: report_result presents a compact result through
2788
- // the shared leader receiver and does not carry a private direct-inject retry.
2789
- #[test]
2790
- fn e15_report_result_uses_shared_leader_receiver_without_private_retry() {
2791
- let src = include_str!("../results.rs");
2792
- assert!(
2793
- src.contains("send_to_leader_receiver_with_presentation"),
2794
- "E15/E23: report_result must use the shared leader receiver presentation funnel"
2795
- );
2796
- assert!(
2797
- !src.contains("inject_leader_notification_direct")
2798
- && !src.contains("deliver_to_leader_fallback_pane"),
2799
- "E23: private direct and removed fallback inject paths must stay deleted"
2800
- );
2801
- }
2802
-
2803
- // ════════════════════════════════════════════════════════════════════════
2804
- // 0.5.4 gate054 — cross-team notify boundary.
2805
- //
2806
- // Triage: .team/artifacts/0.5.4-gate-crossteam-notify-triage.md
2807
- //
2808
- // Shape (regression):
2809
- // - Gate team's `leader_receiver` records `pane_id=%1`, `tmux_socket=/tmp/gate`,
2810
- // `status="rebind_required"` (disposable leader was killed post-restart).
2811
- // - The main tmux server has a live `%1` on the workspace-canonical socket.
2812
- // - `deliver_pending_message` MUST refuse with `channel=rebind_required` and
2813
- // MUST NOT probe the main/default tmux server for the same pane id.
2814
- // ════════════════════════════════════════════════════════════════════════
2815
-
2816
- #[test]
2817
- fn gate054_rebind_required_status_refuses_leader_delivery_without_cross_server_probe() {
2818
- let ws = tmp_ws("gate054status");
2819
- let store = store_for(&ws);
2820
- let log = EventLog::new(&ws);
2821
- // Explicit endpoint socket (non-canonical for this workspace) with a
2822
- // stale receiver demoted to `rebind_required` after the gate's leader
2823
- // window was killed.
2824
- let state = serde_json::json!({
2825
- "session_name": "team-gate054",
2826
- "tmux_endpoint": "/tmp/gate-socket-does-not-exist",
2827
- "leader_receiver": {
2828
- "pane_id": "%1",
2829
- "tmux_socket": "/tmp/gate-socket-does-not-exist",
2830
- "status": "rebind_required"
2831
- },
2832
- "agents": {
2833
- "probe": {"provider": "fake", "pane_id": "%0", "window": "probe"}
2834
- }
2835
- });
2836
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2837
- let message_id = store
2838
- .create_message(
2839
- None,
2840
- "probe",
2841
- "leader",
2842
- "gate054 must not leak",
2843
- None,
2844
- false,
2845
- None,
2846
- )
2847
- .unwrap();
2848
-
2849
- // The transport we pass is the "main"/default server backend which does
2850
- // have a live `%1`. If the fix regresses and delivery falls back cross-
2851
- // server by pane id, it would inject here.
2852
- let default_backend =
2853
- OfflineTransport::new().with_targets(vec![pane_info("%1", "team-main", "leader")]);
2854
-
2855
- let out = deliver_pending_message(&ws, &store, &default_backend, &message_id, &log, &state)
2856
- .expect("status guard must be a business refusal, not panic");
2857
-
2858
- assert!(
2859
- !out.ok,
2860
- "0.5.4 gate054: leader_receiver.status='rebind_required' must refuse delivery"
2861
- );
2862
- assert_eq!(out.channel.as_deref(), Some("rebind_required"));
2863
- assert_eq!(out.message_status.0, "failed");
2864
- assert_eq!(out.reason, Some(DeliveryRefusal::LeaderNotAttached));
2865
- // Cross-server invariant: even though the default backend has a live `%1`
2866
- // matching the recorded receiver pane id, delivery MUST NOT inject there.
2867
- assert!(
2868
- default_backend.inject_targets().is_empty(),
2869
- "0.5.4 gate054: leader delivery must not cross to a different tmux server by pane id; \
2870
- inject_targets={:?}",
2871
- default_backend.inject_targets()
2872
- );
2873
- let events = log.tail(0).unwrap();
2874
- assert!(
2875
- events.iter().any(|event| {
2876
- event.get("event").and_then(serde_json::Value::as_str)
2877
- == Some("leader_receiver.delivery_blocked")
2878
- && event.get("reason").and_then(serde_json::Value::as_str)
2879
- == Some("leader_receiver_not_attached")
2880
- && event.get("channel").and_then(serde_json::Value::as_str)
2881
- == Some("rebind_required")
2882
- && event.get("status").and_then(serde_json::Value::as_str)
2883
- == Some("rebind_required")
2884
- }),
2885
- "0.5.4 gate054: refused status must audit as leader_receiver_not_attached / rebind_required; events={events:?}"
2886
- );
2887
- }
2888
-
2889
- #[test]
2890
- fn gate054_attached_status_still_accepts_when_pane_is_live() {
2891
- // Companion negative: prove the new status gate does NOT over-refuse when
2892
- // `status="attached"` and the workspace-canonical socket has the pane.
2893
- // Injection-case revision: transport submit success is NOT a provider
2894
- // receipt, so the old `delivered` pin was a false-positive lock
2895
- // (MUST-10: physical submit is the framework's fact; acceptance is the
2896
- // provider's). The un-refused path now records the SAME row in the typed
2897
- // post-injection fact state until a provider receipt advances it.
2898
- let ws = tmp_ws("gate054ok");
2899
- let store = store_for(&ws);
2900
- let log = EventLog::new(&ws);
2901
- let state = serde_json::json!({
2902
- "session_name": "team-gate054ok",
2903
- "leader_receiver": {
2904
- "pane_id": "%leader",
2905
- "status": "attached"
2906
- },
2907
- "agents": {"w1": {"provider": "fake", "pane_id": "%1"}}
2908
- });
2909
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2910
- let message_id = store
2911
- .create_message(None, "w1", "leader", "hi", None, false, None)
2912
- .unwrap();
2913
- let transport = OfflineTransport::new().with_targets(vec![pane_info(
2914
- "%leader",
2915
- "team-gate054ok",
2916
- "leader",
2917
- )]);
2918
-
2919
- let out = deliver_pending_message(&ws, &store, &transport, &message_id, &log, &state)
2920
- .expect("attached leader must still deliver");
2921
-
2922
- assert!(
2923
- out.ok,
2924
- "0.5.4 gate054: status='attached' with a live pane must not be over-refused: {out:?}"
2925
- );
2926
- assert_eq!(
2927
- transport.inject_targets().len(),
2928
- 1,
2929
- "gate054: exactly one physical inject must have happened (MUST-10 anchor)"
2930
- );
2931
- let injected_awaiting_receipt = crate::db::message_store::MessageRowStatus::ALL
2932
- .iter()
2933
- .map(|status| status.as_str())
2934
- .find(|status| *status == "injected_awaiting_receipt")
2935
- .expect(
2936
- "gate054 signed reanchor: typed status directory must expose \
2937
- injected_awaiting_receipt",
2938
- );
2939
- assert_eq!(
2940
- out.message_status.0, injected_awaiting_receipt,
2941
- "gate054 signed reanchor: a successful physical inject without a provider receipt \
2942
- must remain non-delivered as injected_awaiting_receipt, never claim delivered: {out:?}"
2943
- );
2944
- }
2945
-
2946
- // ════════════════════════════════════════════════════════════════════════
2947
- // 0.5.5 gate054 B-arm — deliver_to_leader_fallback_pane must not cross to
2948
- // another tmux server by pane id when a socket is recorded.
2949
- //
2950
- // Triage: real-machine acceptance B-fail — primary path (delivery.rs) refused
2951
- // with rebind_required, but report_result's fallback_pane bailout selected a
2952
- // same-numbered pane (%1) on the default tmux server (the main team's leader)
2953
- // and returned leader_notified:true / delivered_via=fallback_pane.
2954
- // ════════════════════════════════════════════════════════════════════════
2955
-
2956
- #[test]
2957
- fn gate054_fallback_pane_socket_recorded_does_not_cross_to_default_server() {
2958
- use crate::messaging::deliver_to_leader_fallback_pane;
2959
- let ws = tmp_ws("gate054fallback");
2960
- let store = store_for(&ws);
2961
- let log = EventLog::new(&ws);
2962
- // Recorded socket points at a non-existent endpoint (mimics the gate
2963
- // team's private socket after its leader session was killed). The main
2964
- // team's default tmux server MAY have a same-numbered `%1` — the fix
2965
- // must refuse to inject there.
2966
- let bogus_socket = format!("/tmp/team-agent-gate054-nonexistent-{}", std::process::id());
2967
- let state = serde_json::json!({
2968
- "session_name": "team-gate054",
2969
- "leader_receiver": {
2970
- "pane_id": "%1",
2971
- "tmux_socket": bogus_socket,
2972
- "status": "rebind_required"
2973
- }
2974
- });
2975
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2976
- let message_id = store
2977
- .create_message(
2978
- None,
2979
- "coordinator",
2980
- "leader",
2981
- "fallback payload",
2982
- None,
2983
- false,
2984
- None,
2985
- )
2986
- .unwrap();
2987
-
2988
- let outcome = deliver_to_leader_fallback_pane(
2989
- &ws,
2990
- &state,
2991
- &message_id,
2992
- Some("res_gate054_fallback"),
2993
- "S3 restart complete",
2994
- false, // primary was NOT ok (report_result path)
2995
- Some("primary_delivery_error:leader_not_attached"),
2996
- &log,
2997
- )
2998
- .expect("fallback pane primitive must not panic");
2999
-
3000
- // Must NOT succeed by crossing to another server.
3001
- assert!(
3002
- !outcome.ok,
3003
- "0.5.5 gate054: fallback_pane must not cross a recorded socket boundary: outcome={outcome:?}"
3004
- );
3005
- // Loud-not-silent: caller wire status resolves to rebind_required
3006
- // (results.rs matches channel or Blocked → 'rebind_required').
3007
- assert!(
3008
- outcome.channel.as_deref() == Some("rebind_required")
3009
- || matches!(outcome.status, DeliveryStatus::Blocked),
3010
- "0.5.5 gate054: cross-boundary refusal must surface as rebind_required, got outcome={outcome:?}"
3011
- );
3012
- // Audit noise: fallback_pane_attempt + fallback_pane_failed with the
3013
- // recorded socket_bound=true forensic field.
3014
- let events = log.tail(0).unwrap();
3015
- let attempt = events.iter().find(|e| {
3016
- e.get("event").and_then(serde_json::Value::as_str)
3017
- == Some("leader_receiver.fallback_pane_attempt")
3018
- });
3019
- assert!(
3020
- attempt.is_some(),
3021
- "fallback_pane_attempt audit must fire even on socket-bounded refusal; events={events:?}"
3022
- );
3023
- let failed = events.iter().find(|e| {
3024
- e.get("event").and_then(serde_json::Value::as_str)
3025
- == Some("leader_receiver.fallback_pane_failed")
3026
- });
3027
- assert!(
3028
- failed.is_some(),
3029
- "fallback_pane_failed audit must fire when the recorded socket rejects inject; events={events:?}"
3030
- );
3031
- assert_eq!(
3032
- failed
3033
- .and_then(|e| e.get("socket_bound"))
3034
- .and_then(serde_json::Value::as_bool),
3035
- Some(true),
3036
- "socket_bound forensic field must record the boundary state"
3037
- );
3038
- }
3039
-
3040
- #[test]
3041
- fn gate054_rebind_replay_requeues_failed_leader_message_on_attach() {
3042
- // Round-2 real-machine shape: direct report_result → primary refused with
3043
- // rebind_required → row is `status=failed, error=leader_not_attached`.
3044
- // `attach-leader` must requeue it back to `status=accepted` so the
3045
- // coordinator tick's `deliver_pending_messages` replays it to the new
3046
- // leader pane. Same message_id — no second replay mechanism, no new
3047
- // watcher, exactly-once via leader_notification_log PK.
3048
- use crate::model::ids::TeamKey;
3049
- let ws = tmp_ws("gate054replay");
3050
- let store = store_for(&ws);
3051
- let log = EventLog::new(&ws);
3052
- let team_id = "gate055r2b";
3053
-
3054
- // Seed the same shape the primary-path refusal leaves behind.
3055
- let message_id = store
3056
- .create_message(
3057
- None,
3058
- "probe-worker",
3059
- "leader",
3060
- "B2_NOTIFY report_result payload",
3061
- None,
3062
- false,
3063
- Some(team_id),
3064
- )
3065
- .unwrap();
3066
- store
3067
- .mark(&message_id, "failed", Some("leader_not_attached"))
3068
- .unwrap();
3069
- // Sanity: precondition matches acceptance evidence.
3070
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
3071
- let (status_before, error_before): (String, Option<String>) = conn
3072
- .query_row(
3073
- "select status, error from messages where message_id = ?1",
3074
- [&message_id],
3075
- |r| Ok((r.get(0)?, r.get(1)?)),
3076
- )
3077
- .unwrap();
3078
- assert_eq!(status_before, "failed");
3079
- assert_eq!(error_before.as_deref(), Some("leader_not_attached"));
3080
-
3081
- // The attach-leader path calls requeue_delivery_exhausted_watchers with
3082
- // the newly-claimed pane. Even with NO exhausted watchers to requeue,
3083
- // it must flip the blocked leader row back to accepted.
3084
- let team = TeamKey::new(team_id);
3085
- let new_pane = PaneId::new("%1"); // new leader window on the private socket
3086
- let notices =
3087
- crate::messaging::requeue_delivery_exhausted_watchers(&ws, &store, &log, &team, &new_pane)
3088
- .unwrap();
3089
- assert!(
3090
- notices.is_empty(),
3091
- "no exhausted watchers seeded → no watcher notices; only the message row should have been requeued"
3092
- );
3093
-
3094
- let (status_after, error_after): (String, Option<String>) = conn
3095
- .query_row(
3096
- "select status, error from messages where message_id = ?1",
3097
- [&message_id],
3098
- |r| Ok((r.get(0)?, r.get(1)?)),
3099
- )
3100
- .unwrap();
3101
- assert_eq!(
3102
- status_after, "accepted",
3103
- "gate054 round-2: rebind_required leader row must flip back to 'accepted' on attach-leader"
3104
- );
3105
- assert!(
3106
- error_after.is_none(),
3107
- "gate054 round-2: error must be cleared on requeue so deliver_pending_message replays cleanly"
3108
- );
3109
-
3110
- // Audit noise: leader_receiver.blocked_messages_requeued fired with the
3111
- // exact team + claimed pane + count for status/monitor observability.
3112
- let events = log.tail(0).unwrap();
3113
- let requeued = events.iter().find(|e| {
3114
- e.get("event").and_then(serde_json::Value::as_str)
3115
- == Some("leader_receiver.blocked_messages_requeued")
3116
- });
3117
- assert!(
3118
- requeued.is_some(),
3119
- "attach-leader requeue of blocked leader messages must audit; events={events:?}"
3120
- );
3121
- assert_eq!(
3122
- requeued
3123
- .and_then(|e| e.get("count"))
3124
- .and_then(serde_json::Value::as_u64),
3125
- Some(1)
3126
- );
3127
- assert_eq!(
3128
- requeued
3129
- .and_then(|e| e.get("team_id"))
3130
- .and_then(serde_json::Value::as_str),
3131
- Some(team_id)
3132
- );
3133
- }
3134
-
3135
- #[test]
3136
- fn claim_preserves_pending_acceptance_for_all_recipients() {
3137
- let ws = tmp_ws("claim-pending-acceptance");
3138
- let store = store_for(&ws);
3139
- let log = EventLog::new(&ws);
3140
- let team_id = "mailbox-team";
3141
- let leader_message = store
3142
- .create_message(
3143
- None,
3144
- "worker",
3145
- "leader",
3146
- "leader canary",
3147
- None,
3148
- false,
3149
- Some(team_id),
3150
- )
3151
- .unwrap();
3152
- let worker_message = store
3153
- .create_message(
3154
- None,
3155
- "worker",
3156
- "worker-b",
3157
- "worker canary",
3158
- None,
3159
- false,
3160
- Some(team_id),
3161
- )
3162
- .unwrap();
3163
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
3164
- for message_id in [&leader_message, &worker_message] {
3165
- conn.execute(
3166
- "update messages set status = 'submitted_pending_acceptance' where message_id = ?1",
3167
- [message_id],
3168
- )
3169
- .unwrap();
3170
- }
3171
-
3172
- let team = TeamKey::new(team_id);
3173
- let pane = PaneId::new("%leader");
3174
- requeue_after_claim_leader(&ws, &store, &log, &team, &pane, None).unwrap();
3175
-
3176
- let row = |message_id: &str| {
3177
- conn.query_row(
3178
- "select status, delivered_at, error from messages where message_id = ?1",
3179
- [message_id],
3180
- |row| {
3181
- Ok((
3182
- row.get::<_, String>(0)?,
3183
- row.get::<_, Option<String>>(1)?,
3184
- row.get::<_, Option<String>>(2)?,
3185
- ))
3186
- },
3187
- )
3188
- .unwrap()
3189
- };
3190
- assert_eq!(
3191
- row(&leader_message),
3192
- (
3193
- "submitted_pending_acceptance".to_string(),
3194
- None,
3195
- None
3196
- )
3197
- );
3198
- assert_eq!(
3199
- row(&worker_message),
3200
- (
3201
- "submitted_pending_acceptance".to_string(),
3202
- None,
3203
- None
3204
- )
3205
- );
3206
- }
3207
-
3208
- #[test]
3209
- fn gate054_status_surfaces_pending_leader_notifications() {
3210
- // Round-2: user-facing visibility — status must show the blocked leader
3211
- // notification as pending, not just as `messages.failed=1`.
3212
- use crate::cli::status_port::status_scoped;
3213
- let ws = tmp_ws("gate054status");
3214
- let store = store_for(&ws);
3215
- let team_id = "gate055r2b";
3216
-
3217
- let message_id = store
3218
- .create_message(
3219
- None,
3220
- "probe-worker",
3221
- "leader",
3222
- "B2_NOTIFY report_result payload",
3223
- None,
3224
- false,
3225
- Some(team_id),
3226
- )
3227
- .unwrap();
3228
- store
3229
- .mark(&message_id, "failed", Some("leader_not_attached"))
3230
- .unwrap();
3231
-
3232
- // Minimal runtime state so status can render.
3233
- let state = serde_json::json!({
3234
- "session_name": format!("team-{team_id}"),
3235
- "active_team_key": team_id,
3236
- "teams": {team_id: {"team_key": team_id}},
3237
- "leader_receiver": {
3238
- "pane_id": "%1",
3239
- "status": "rebind_required",
3240
- }
3241
- });
3242
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
3243
-
3244
- let payload = status_scoped(&ws, &state, Some(team_id), false, false).unwrap();
3245
- let pending = payload
3246
- .get("pending_leader_notifications")
3247
- .and_then(serde_json::Value::as_array)
3248
- .expect("status must expose pending_leader_notifications as an array");
3249
- assert_eq!(
3250
- pending.len(),
3251
- 1,
3252
- "the blocked leader message must appear in pending_leader_notifications"
3253
- );
3254
- let entry = &pending[0];
3255
- assert_eq!(
3256
- entry.get("message_id").and_then(serde_json::Value::as_str),
3257
- Some(message_id.as_str())
3258
- );
3259
- assert_eq!(
3260
- entry.get("channel").and_then(serde_json::Value::as_str),
3261
- Some("rebind_required")
3262
- );
3263
- let action = entry
3264
- .get("action")
3265
- .and_then(serde_json::Value::as_str)
3266
- .unwrap_or("");
3267
- assert!(
3268
- action.contains("historical leader mailbox debt"),
3269
- "historical debt action must stay debt-scoped; action={action}"
3270
- );
3271
- assert!(
3272
- !action.contains("attach-leader") && !action.contains("takeover") && !action.contains("claim-leader"),
3273
- "historical debt must not authorize bind commands; action={action}"
3274
- );
3275
- }
3276
-
3277
- #[test]
3278
- fn gate054_fallback_pane_grep_guard_no_cross_server_chain_when_socket_recorded() {
3279
- // Structural grep: the recorded-socket transport set must contain only
3280
- // the endpoint backend, while workspace/default transports remain in the
3281
- // no-socket arm. Physical injection must consume the pane returned by the
3282
- // shared resolver rather than rebuilding a target from state.
3283
- let src = include_str!("../leader_receiver.rs");
3284
- let transports_start = src
3285
- .find("let transports: Vec<Box<dyn Transport>>")
3286
- .expect("fallback transport set must remain explicit");
3287
- let transports_end = src[transports_start..]
3288
- .find("let mut resolved")
3289
- .map(|off| transports_start + off)
3290
- .expect("transport selection must precede shared resolution");
3291
- let transports = &src[transports_start..transports_end];
3292
- let socket_arm_start = transports
3293
- .find("Some(socket) =>")
3294
- .expect("recorded-socket arm");
3295
- let socket_arm_end = transports[socket_arm_start..]
3296
- .find("None =>")
3297
- .map(|off| socket_arm_start + off)
3298
- .expect("no-socket arm must follow");
3299
- let socket_arm = &transports[socket_arm_start..socket_arm_end];
3300
- assert!(
3301
- socket_arm.contains("tmux_endpoint_transport")
3302
- && !socket_arm.contains("tmux_workspace_transport")
3303
- && !socket_arm.contains("tmux_default_transport"),
3304
- "0.5.5 gate054: socket-recorded fallback arm must remain endpoint-only; arm={socket_arm}"
3305
- );
3306
- let no_socket_arm = &transports[socket_arm_end..];
3307
- assert!(
3308
- no_socket_arm.contains("tmux_workspace_transport")
3309
- && no_socket_arm.contains("tmux_default_transport"),
3310
- "0.5.5 gate054: workspace/default transports belong only to the no-socket arm; arm={no_socket_arm}"
3311
- );
3312
- assert!(
3313
- src.contains("let target = Target::Pane(PaneId::new(channel.pane_id));"),
3314
- "fallback injection must consume the shared resolver's typed channel"
3315
- );
3316
- }
3317
-
3318
- fn delivery_blocked_channel_reasons(ws: &std::path::Path) -> Vec<String> {
3319
- EventLog::new(ws)
3320
- .tail(80)
3321
- .unwrap()
3322
- .into_iter()
3323
- .filter(|event| event.get("event") == Some(&serde_json::json!("leader_receiver.delivery_blocked")))
3324
- .filter_map(|event| {
3325
- event
3326
- .get("channel_reason")
3327
- .and_then(serde_json::Value::as_str)
3328
- .map(str::to_string)
3329
- })
3330
- .collect()
3331
- }
3332
-
3333
- fn live_leader_pane(ws: &std::path::Path, pane_id: &str) -> PaneInfo {
3334
- let mut pane = pane_info(pane_id, "team-current", "leader");
3335
- pane.current_path = Some(ws.to_path_buf());
3336
- pane
3337
- }
3338
-
3339
- #[test]
3340
- fn owner_projection_null_fallback_projects_nested_current_receiver() {
3341
- let ws = tmp_ws("proj-null-current");
3342
- let state = serde_json::json!({
3343
- "active_team_key": "current",
3344
- "team_key": "current",
3345
- "teams": {
3346
- "current": {
3347
- "team_key": "current",
3348
- "leader_receiver": {
3349
- "status": "attached",
3350
- "mode": "direct_tmux",
3351
- "pane_id": "%9"
3352
- },
3353
- "agents": {}
3354
- }
3355
- },
3356
- "agents": {}
3357
- });
3358
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
3359
- let store = store_for(&ws);
3360
- let log = EventLog::new(&ws);
3361
- let message_id = store
3362
- .create_message(None, "w1", "leader", "nested current", None, false, Some("current"))
3363
- .unwrap();
3364
- let transport = OfflineTransport::new().with_targets(vec![live_leader_pane(&ws, "%9")]);
3365
-
3366
- let out = deliver_pending_message(&ws, &store, &transport, &message_id, &log, &serde_json::json!({}))
3367
- .unwrap();
3368
-
3369
- assert!(
3370
- !delivery_blocked_channel_reasons(&ws)
3371
- .iter()
3372
- .any(|reason| reason == "receiver_missing"),
3373
- "fresh Null fallback must project teams.current, not return Null; out={out:?} reasons={:?}",
3374
- delivery_blocked_channel_reasons(&ws)
3375
- );
3376
- assert_eq!(
3377
- transport.inject_targets(),
3378
- vec![Target::Pane(PaneId::new("%9"))],
3379
- "nested current receiver must select pane %9; out={out:?}"
3380
- );
3381
- }
3382
-
3383
- #[test]
3384
- fn owner_projection_non_object_does_not_match_current() {
3385
- assert!(
3386
- !crate::messaging::delivery::top_level_state_matches_owner_team(
3387
- &serde_json::Value::Null,
3388
- "current"
3389
- ),
3390
- "Null must not match current through team_state_key default"
3391
- );
3392
- assert!(
3393
- !crate::messaging::delivery::top_level_state_matches_owner_team(
3394
- &serde_json::json!([]),
3395
- "current"
3396
- ),
3397
- "non-object must not match current"
3398
- );
3399
- }
3400
-
3401
- #[test]
3402
- fn owner_projection_legacy_top_level_receiver_survives_null_fallback() {
3403
- let ws = tmp_ws("proj-legacy-top");
3404
- let state = serde_json::json!({
3405
- "active_team_key": "current",
3406
- "leader_receiver": {
3407
- "status": "attached",
3408
- "mode": "direct_tmux",
3409
- "pane_id": "%3"
3410
- },
3411
- "agents": {}
3412
- });
3413
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
3414
- let store = store_for(&ws);
3415
- let log = EventLog::new(&ws);
3416
- let message_id = store
3417
- .create_message(None, "w1", "leader", "legacy top", None, false, Some("current"))
3418
- .unwrap();
3419
- let transport = OfflineTransport::new().with_targets(vec![live_leader_pane(&ws, "%3")]);
3420
-
3421
- let out = deliver_pending_message(&ws, &store, &transport, &message_id, &log, &serde_json::json!({}))
3422
- .unwrap();
3423
-
3424
- assert!(
3425
- !delivery_blocked_channel_reasons(&ws)
3426
- .iter()
3427
- .any(|reason| reason == "receiver_missing"),
3428
- "legacy top-level receiver must remain usable; out={out:?}"
3429
- );
3430
- assert_eq!(
3431
- transport.inject_targets(),
3432
- vec![Target::Pane(PaneId::new("%3"))],
3433
- "legacy top-level receiver must select pane %3; out={out:?}"
3434
- );
3435
- }
3436
-
3437
- #[test]
3438
- fn owner_projection_missing_selected_does_not_borrow_sibling() {
3439
- let ws = tmp_ws("proj-no-sibling");
3440
- let state = serde_json::json!({
3441
- "active_team_key": "alpha",
3442
- "team_key": "alpha",
3443
- "teams": {
3444
- "alpha": {
3445
- "team_key": "alpha",
3446
- "agents": {}
3447
- },
3448
- "beta": {
3449
- "team_key": "beta",
3450
- "leader_receiver": {
3451
- "status": "attached",
3452
- "mode": "direct_tmux",
3453
- "pane_id": "%beta"
3454
- },
3455
- "agents": {}
3456
- }
3457
- },
3458
- "agents": {}
3459
- });
3460
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
3461
- let store = store_for(&ws);
3462
- let log = EventLog::new(&ws);
3463
- let message_id = store
3464
- .create_message(None, "w1", "leader", "alpha has no receiver", None, false, Some("alpha"))
3465
- .unwrap();
3466
- let transport = OfflineTransport::new().with_targets(vec![live_leader_pane(&ws, "%beta")]);
3467
-
3468
- let out = deliver_pending_message(&ws, &store, &transport, &message_id, &log, &serde_json::json!({}))
3469
- .unwrap();
3470
-
3471
- assert!(
3472
- delivery_blocked_channel_reasons(&ws)
3473
- .iter()
3474
- .any(|reason| reason == "receiver_missing"),
3475
- "alpha must not borrow beta's receiver; out={out:?} reasons={:?}",
3476
- delivery_blocked_channel_reasons(&ws)
3477
- );
3478
- assert_eq!(transport.inject_targets().len(), 0, "must not inject into the sibling pane");
3479
- }
3480
-
3481
- #[test]
3482
- fn owner_projection_peer_inject_uses_nested_worker_pane_not_top_level() {
3483
- let ws = tmp_ws("proj-peer-nested");
3484
- let state = serde_json::json!({
3485
- "active_team_key": "teamA",
3486
- "session_name": "team-top",
3487
- "agents": {
3488
- "worker_b": {
3489
- "provider": "fake",
3490
- "status": "running",
3491
- "window": "worker_b",
3492
- "pane_id": "%top-b"
3493
- }
3494
- },
3495
- "teams": {
3496
- "teamA": {
3497
- "session_name": "team-nested",
3498
- "agents": {
3499
- "worker_b": {
3500
- "provider": "fake",
3501
- "status": "running",
3502
- "window": "worker_b",
3503
- "pane_id": "%nested-b"
3504
- }
3505
- }
3506
- }
3507
- }
3508
- });
3509
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
3510
- let store = store_for(&ws);
3511
- let log = EventLog::new(&ws);
3512
- let message_id = store
3513
- .create_message(
3514
- None,
3515
- "worker_a",
3516
- "worker_b",
3517
- "MCP_SIM_BROADCAST_CANARY",
3518
- None,
3519
- false,
3520
- Some("teamA"),
3521
- )
3522
- .unwrap();
3523
- let transport = OfflineTransport::new().with_targets(vec![
3524
- pane_info("%top-b", "team-top", "worker_b"),
3525
- pane_info("%nested-b", "team-nested", "worker_b"),
3526
- ]);
3527
-
3528
- let out = deliver_pending_message(
3529
- &ws,
3530
- &store,
3531
- &transport,
3532
- &message_id,
3533
- &log,
3534
- &serde_json::json!({}),
3535
- )
3536
- .unwrap();
3537
-
3538
- let targets = transport.inject_targets();
3539
- assert!(
3540
- !targets.is_empty(),
3541
- "owner teamA peer inject must attempt the nested worker pane; out={out:?}"
3542
- );
3543
- assert!(
3544
- targets
3545
- .iter()
3546
- .all(|target| target == &Target::Pane(PaneId::new("%nested-b"))),
3547
- "owner teamA peer inject must select nested worker pane %nested-b, not top-level %top-b; out={out:?} targets={targets:?}"
3548
- );
3549
- }