@team-agent/installer 0.5.127 → 0.6.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (421) hide show
  1. package/README.md +15 -4
  2. package/README.zh.md +1 -1
  3. package/package.json +4 -8
  4. package/skills/team-agent/SKILL.md +41 -26
  5. package/skills/team-agent/command-coverage.json +170 -184
  6. package/skills/team-agent/docs/reference/team-agent-operator.md +66 -32
  7. package/skills/team-agent/references/recovery-runbook.md +1 -1
  8. package/skills/team-agent/references/team-agent-operator.md +66 -32
  9. package/templates/team_state.md +1 -1
  10. package/Cargo.lock +0 -1063
  11. package/Cargo.toml +0 -36
  12. package/crates/team-agent/Cargo.toml +0 -69
  13. package/crates/team-agent/src/app_server_test_support.rs +0 -258
  14. package/crates/team-agent/src/cli/adapters.rs +0 -1298
  15. package/crates/team-agent/src/cli/arguments.rs +0 -401
  16. package/crates/team-agent/src/cli/attach_app_server_leader.rs +0 -98
  17. package/crates/team-agent/src/cli/diagnose.rs +0 -1675
  18. package/crates/team-agent/src/cli/emit.rs +0 -2898
  19. package/crates/team-agent/src/cli/grok_slot.rs +0 -384
  20. package/crates/team-agent/src/cli/helpers.rs +0 -91
  21. package/crates/team-agent/src/cli/intent/runtime.rs +0 -1189
  22. package/crates/team-agent/src/cli/intent/runtime_tests.rs +0 -821
  23. package/crates/team-agent/src/cli/intent/tests.rs +0 -691
  24. package/crates/team-agent/src/cli/intent.rs +0 -664
  25. package/crates/team-agent/src/cli/leader.rs +0 -300
  26. package/crates/team-agent/src/cli/leader_prompt.rs +0 -261
  27. package/crates/team-agent/src/cli/leaders.rs +0 -418
  28. package/crates/team-agent/src/cli/mod.rs +0 -6528
  29. package/crates/team-agent/src/cli/models.rs +0 -449
  30. package/crates/team-agent/src/cli/named_address.rs +0 -1651
  31. package/crates/team-agent/src/cli/profile.rs +0 -342
  32. package/crates/team-agent/src/cli/route.rs +0 -212
  33. package/crates/team-agent/src/cli/send/coordinator.rs +0 -164
  34. package/crates/team-agent/src/cli/send/mailbox.rs +0 -145
  35. package/crates/team-agent/src/cli/send/persist.rs +0 -192
  36. package/crates/team-agent/src/cli/send/presentation.rs +0 -370
  37. package/crates/team-agent/src/cli/send/resolve.rs +0 -573
  38. package/crates/team-agent/src/cli/send.rs +0 -201
  39. package/crates/team-agent/src/cli/shutdown_socket.rs +0 -288
  40. package/crates/team-agent/src/cli/spec.rs +0 -159
  41. package/crates/team-agent/src/cli/status.rs +0 -280
  42. package/crates/team-agent/src/cli/status_port/agents.rs +0 -358
  43. package/crates/team-agent/src/cli/status_port/approvals.rs +0 -79
  44. package/crates/team-agent/src/cli/status_port/brief.rs +0 -2043
  45. package/crates/team-agent/src/cli/status_port/compact.rs +0 -240
  46. package/crates/team-agent/src/cli/status_port/format.rs +0 -146
  47. package/crates/team-agent/src/cli/status_port/inbox.rs +0 -62
  48. package/crates/team-agent/src/cli/status_port/runtime.rs +0 -197
  49. package/crates/team-agent/src/cli/status_port/snapshot.rs +0 -208
  50. package/crates/team-agent/src/cli/status_port/store.rs +0 -416
  51. package/crates/team-agent/src/cli/status_port/tests.rs +0 -90
  52. package/crates/team-agent/src/cli/status_port.rs +0 -92
  53. package/crates/team-agent/src/cli/tests/base.rs +0 -885
  54. package/crates/team-agent/src/cli/tests/divergence.rs +0 -518
  55. package/crates/team-agent/src/cli/tests/lane_c.rs +0 -453
  56. package/crates/team-agent/src/cli/tests/leader_watch.rs +0 -372
  57. package/crates/team-agent/src/cli/tests/main_preserved.rs +0 -430
  58. package/crates/team-agent/src/cli/tests/missing_subcommands.rs +0 -336
  59. package/crates/team-agent/src/cli/tests/mod.rs +0 -137
  60. package/crates/team-agent/src/cli/tests/named_address.rs +0 -760
  61. package/crates/team-agent/src/cli/tests/parser_safety.rs +0 -383
  62. package/crates/team-agent/src/cli/tests/run_delegation.rs +0 -481
  63. package/crates/team-agent/src/cli/tests/shutdown_kill_plan.rs +0 -2179
  64. package/crates/team-agent/src/cli/tests/status_brief.rs +0 -1514
  65. package/crates/team-agent/src/cli/tests/status_send.rs +0 -1091
  66. package/crates/team-agent/src/cli/tests/verb_install_skill.rs +0 -93
  67. package/crates/team-agent/src/cli/tests/verb_profile.rs +0 -392
  68. package/crates/team-agent/src/cli/triage.rs +0 -234
  69. package/crates/team-agent/src/cli/types.rs +0 -591
  70. package/crates/team-agent/src/codex_app_server.rs +0 -546
  71. package/crates/team-agent/src/communication_mode/mod.rs +0 -56
  72. package/crates/team-agent/src/compiler/tests.rs +0 -842
  73. package/crates/team-agent/src/compiler.rs +0 -691
  74. package/crates/team-agent/src/conpty/backend.rs +0 -829
  75. package/crates/team-agent/src/conpty/mod.rs +0 -33
  76. package/crates/team-agent/src/contract_runtime/backend.rs +0 -1610
  77. package/crates/team-agent/src/contract_runtime/commands.rs +0 -671
  78. package/crates/team-agent/src/contract_runtime/config.rs +0 -354
  79. package/crates/team-agent/src/contract_runtime/config_tests.rs +0 -56
  80. package/crates/team-agent/src/contract_runtime/discovery.rs +0 -438
  81. package/crates/team-agent/src/contract_runtime/fork.rs +0 -368
  82. package/crates/team-agent/src/contract_runtime/forward.rs +0 -288
  83. package/crates/team-agent/src/contract_runtime/framework.rs +0 -350
  84. package/crates/team-agent/src/contract_runtime/mcp.rs +0 -399
  85. package/crates/team-agent/src/contract_runtime/mod.rs +0 -17
  86. package/crates/team-agent/src/contract_runtime/prompt.rs +0 -216
  87. package/crates/team-agent/src/contract_runtime/pump.rs +0 -271
  88. package/crates/team-agent/src/contract_runtime/registry.rs +0 -589
  89. package/crates/team-agent/src/contract_runtime/workspace.rs +0 -228
  90. package/crates/team-agent/src/coordinator/backoff.rs +0 -741
  91. package/crates/team-agent/src/coordinator/conpty_shim.rs +0 -805
  92. package/crates/team-agent/src/coordinator/health.rs +0 -1185
  93. package/crates/team-agent/src/coordinator/mod.rs +0 -119
  94. package/crates/team-agent/src/coordinator/orphan.rs +0 -110
  95. package/crates/team-agent/src/coordinator/runtime_detectors.rs +0 -798
  96. package/crates/team-agent/src/coordinator/runtime_observation.rs +0 -84
  97. package/crates/team-agent/src/coordinator/steps/abnormal.rs +0 -2309
  98. package/crates/team-agent/src/coordinator/steps/delivery.rs +0 -15
  99. package/crates/team-agent/src/coordinator/steps/health_sync.rs +0 -15
  100. package/crates/team-agent/src/coordinator/steps/mod.rs +0 -126
  101. package/crates/team-agent/src/coordinator/steps/persist.rs +0 -15
  102. package/crates/team-agent/src/coordinator/steps/runtime_prompts.rs +0 -15
  103. package/crates/team-agent/src/coordinator/steps/session_gate.rs +0 -16
  104. package/crates/team-agent/src/coordinator/tests/a0_lostupdate.rs +0 -158
  105. package/crates/team-agent/src/coordinator/tests/abnormal.rs +0 -312
  106. package/crates/team-agent/src/coordinator/tests/api_error_recovery.rs +0 -338
  107. package/crates/team-agent/src/coordinator/tests/basics.rs +0 -211
  108. package/crates/team-agent/src/coordinator/tests/daemon.rs +0 -514
  109. package/crates/team-agent/src/coordinator/tests/energy.rs +0 -549
  110. package/crates/team-agent/src/coordinator/tests/health_sync.rs +0 -461
  111. package/crates/team-agent/src/coordinator/tests/main_preserved.rs +0 -186
  112. package/crates/team-agent/src/coordinator/tests/mod.rs +0 -295
  113. package/crates/team-agent/src/coordinator/tests/s3_bounded.rs +0 -207
  114. package/crates/team-agent/src/coordinator/tests/spine.rs +0 -308
  115. package/crates/team-agent/src/coordinator/tests/takeover.rs +0 -286
  116. package/crates/team-agent/src/coordinator/tests/tick_core.rs +0 -237
  117. package/crates/team-agent/src/coordinator/tick.rs +0 -3112
  118. package/crates/team-agent/src/coordinator/types.rs +0 -540
  119. package/crates/team-agent/src/db/agent_health_capture.rs +0 -126
  120. package/crates/team-agent/src/db/message_store.rs +0 -1585
  121. package/crates/team-agent/src/db/migration.rs +0 -984
  122. package/crates/team-agent/src/db/mod.rs +0 -26
  123. package/crates/team-agent/src/db/schema.rs +0 -663
  124. package/crates/team-agent/src/diagnose/comms.rs +0 -242
  125. package/crates/team-agent/src/diagnose/mod.rs +0 -44
  126. package/crates/team-agent/src/diagnose/orphans.rs +0 -889
  127. package/crates/team-agent/src/event_log.rs +0 -502
  128. package/crates/team-agent/src/fake_worker.rs +0 -303
  129. package/crates/team-agent/src/kill_audit.rs +0 -106
  130. package/crates/team-agent/src/layout/manager.rs +0 -248
  131. package/crates/team-agent/src/layout/mod.rs +0 -36
  132. package/crates/team-agent/src/layout/overlay.rs +0 -134
  133. package/crates/team-agent/src/layout/placement.rs +0 -52
  134. package/crates/team-agent/src/layout/recovery.rs +0 -106
  135. package/crates/team-agent/src/layout/runtime_sessions.rs +0 -317
  136. package/crates/team-agent/src/layout/sessions.rs +0 -294
  137. package/crates/team-agent/src/layout/tmux_endpoint.rs +0 -165
  138. package/crates/team-agent/src/layout/worker_env.rs +0 -721
  139. package/crates/team-agent/src/layout/worker_window_helpers.rs +0 -37
  140. package/crates/team-agent/src/leader/helpers.rs +0 -178
  141. package/crates/team-agent/src/leader/incident.rs +0 -6
  142. package/crates/team-agent/src/leader/lease.rs +0 -3356
  143. package/crates/team-agent/src/leader/mod.rs +0 -104
  144. package/crates/team-agent/src/leader/owner_bind.rs +0 -400
  145. package/crates/team-agent/src/leader/prompt.rs +0 -905
  146. package/crates/team-agent/src/leader/provider_attribution.rs +0 -247
  147. package/crates/team-agent/src/leader/rediscover/tests.rs +0 -689
  148. package/crates/team-agent/src/leader/rediscover.rs +0 -1192
  149. package/crates/team-agent/src/leader/registry.rs +0 -883
  150. package/crates/team-agent/src/leader/start.rs +0 -4500
  151. package/crates/team-agent/src/leader/takeover.rs +0 -65
  152. package/crates/team-agent/src/leader/tests/basics.rs +0 -337
  153. package/crates/team-agent/src/leader/tests/byte_findings.rs +0 -355
  154. package/crates/team-agent/src/leader/tests/claim_leader_mailbox_flush_contract.rs +0 -544
  155. package/crates/team-agent/src/leader/tests/historical_inventory_upgrade_gate_red.rs +0 -624
  156. package/crates/team-agent/src/leader/tests/identity.rs +0 -465
  157. package/crates/team-agent/src/leader/tests/identity_session_names.rs +0 -42
  158. package/crates/team-agent/src/leader/tests/idle.rs +0 -113
  159. package/crates/team-agent/src/leader/tests/lease_api.rs +0 -520
  160. package/crates/team-agent/src/leader/tests/lease_claim.rs +0 -629
  161. package/crates/team-agent/src/leader/tests/mod.rs +0 -106
  162. package/crates/team-agent/src/leader/tests/prompt_contract.rs +0 -267
  163. package/crates/team-agent/src/leader/tests/rediscover.rs +0 -403
  164. package/crates/team-agent/src/leader/tests/rehomed_env.rs +0 -83
  165. package/crates/team-agent/src/leader/tests/team_in_team_state_scope_red.rs +0 -1273
  166. package/crates/team-agent/src/leader/tests/terminal_and_replay_vs_rerender_invariants_red.rs +0 -417
  167. package/crates/team-agent/src/leader/tests/wake_start_owner.rs +0 -168
  168. package/crates/team-agent/src/leader/types.rs +0 -534
  169. package/crates/team-agent/src/lib.rs +0 -145
  170. package/crates/team-agent/src/lifecycle/helpers.rs +0 -212
  171. package/crates/team-agent/src/lifecycle/launch/add_agent.rs +0 -848
  172. package/crates/team-agent/src/lifecycle/launch/add_agent_state.rs +0 -393
  173. package/crates/team-agent/src/lifecycle/launch/agent_state.rs +0 -332
  174. package/crates/team-agent/src/lifecycle/launch/clone_agent.rs +0 -178
  175. package/crates/team-agent/src/lifecycle/launch/fork_agent.rs +0 -82
  176. package/crates/team-agent/src/lifecycle/launch/fork_entry.rs +0 -63
  177. package/crates/team-agent/src/lifecycle/launch/identity.rs +0 -674
  178. package/crates/team-agent/src/lifecycle/launch/layout.rs +0 -350
  179. package/crates/team-agent/src/lifecycle/launch/leader_context.rs +0 -589
  180. package/crates/team-agent/src/lifecycle/launch/mcp_config.rs +0 -152
  181. package/crates/team-agent/src/lifecycle/launch/ownership.rs +0 -105
  182. package/crates/team-agent/src/lifecycle/launch/pi_mcp.rs +0 -629
  183. package/crates/team-agent/src/lifecycle/launch/pi_mcp_extension.js +0 -226
  184. package/crates/team-agent/src/lifecycle/launch/plan.rs +0 -269
  185. package/crates/team-agent/src/lifecycle/launch/quick_start.rs +0 -5176
  186. package/crates/team-agent/src/lifecycle/launch/quick_start_transport.rs +0 -368
  187. package/crates/team-agent/src/lifecycle/launch/readiness.rs +0 -519
  188. package/crates/team-agent/src/lifecycle/launch/role_source.rs +0 -287
  189. package/crates/team-agent/src/lifecycle/launch/spawn.rs +0 -450
  190. package/crates/team-agent/src/lifecycle/launch/spec_state.rs +0 -801
  191. package/crates/team-agent/src/lifecycle/launch/state_projection.rs +0 -624
  192. package/crates/team-agent/src/lifecycle/launch/worker_env.rs +0 -558
  193. package/crates/team-agent/src/lifecycle/launch.rs +0 -534
  194. package/crates/team-agent/src/lifecycle/lock.rs +0 -350
  195. package/crates/team-agent/src/lifecycle/mod.rs +0 -79
  196. package/crates/team-agent/src/lifecycle/pane_input_lock.rs +0 -239
  197. package/crates/team-agent/src/lifecycle/profile_launch.rs +0 -757
  198. package/crates/team-agent/src/lifecycle/profile_smoke.rs +0 -557
  199. package/crates/team-agent/src/lifecycle/restart/agent.rs +0 -2198
  200. package/crates/team-agent/src/lifecycle/restart/common.rs +0 -2052
  201. package/crates/team-agent/src/lifecycle/restart/orchestrator.rs +0 -65
  202. package/crates/team-agent/src/lifecycle/restart/preflight.rs +0 -113
  203. package/crates/team-agent/src/lifecycle/restart/rebuild.rs +0 -5135
  204. package/crates/team-agent/src/lifecycle/restart/remove.rs +0 -1504
  205. package/crates/team-agent/src/lifecycle/restart/selection.rs +0 -559
  206. package/crates/team-agent/src/lifecycle/restart/team_state.rs +0 -329
  207. package/crates/team-agent/src/lifecycle/restart.rs +0 -223
  208. package/crates/team-agent/src/lifecycle/role_config.rs +0 -1205
  209. package/crates/team-agent/src/lifecycle/tests/acceptance_b_batch_red.rs +0 -1021
  210. package/crates/team-agent/src/lifecycle/tests/agent_ops.rs +0 -1205
  211. package/crates/team-agent/src/lifecycle/tests/b0_legacy_snapshot_nonauthority_contract.rs +0 -265
  212. package/crates/team-agent/src/lifecycle/tests/b0_reader_hideone_audit_contract.rs +0 -490
  213. package/crates/team-agent/src/lifecycle/tests/behavioral_diff_264_red.rs +0 -656
  214. package/crates/team-agent/src/lifecycle/tests/claude_profile_launch_red.rs +0 -135
  215. package/crates/team-agent/src/lifecycle/tests/cli_argv_routing_red.rs +0 -1415
  216. package/crates/team-agent/src/lifecycle/tests/clone_agent_preserves_source_tools.rs +0 -427
  217. package/crates/team-agent/src/lifecycle/tests/clone_fork_copilot_perms_red.rs +0 -396
  218. package/crates/team-agent/src/lifecycle/tests/communication_mode_runtime_contract_red.rs +0 -418
  219. package/crates/team-agent/src/lifecycle/tests/copilot_provider_red.rs +0 -2039
  220. package/crates/team-agent/src/lifecycle/tests/core.rs +0 -1298
  221. package/crates/team-agent/src/lifecycle/tests/f032_startup_prompt_best_effort_red.rs +0 -315
  222. package/crates/team-agent/src/lifecycle/tests/fixtures/pi_list_models_g0.stdout.txt +0 -222
  223. package/crates/team-agent/src/lifecycle/tests/fixtures/pi_list_models_spaced_ids.stdout.txt +0 -9
  224. package/crates/team-agent/src/lifecycle/tests/fixtures/pi_native_mcp_host.mjs +0 -71
  225. package/crates/team-agent/src/lifecycle/tests/gate_fixtures.rs +0 -562
  226. package/crates/team-agent/src/lifecycle/tests/grok_require_explicit_model_red.rs +0 -110
  227. package/crates/team-agent/src/lifecycle/tests/harvest2_a_batch_red.rs +0 -472
  228. package/crates/team-agent/src/lifecycle/tests/host_cotenant_death_p0_contract.rs +0 -921
  229. package/crates/team-agent/src/lifecycle/tests/issue238_codex_effort_contract.rs +0 -68
  230. package/crates/team-agent/src/lifecycle/tests/lane_ops.rs +0 -1851
  231. package/crates/team-agent/src/lifecycle/tests/launch_spawn.rs +0 -3981
  232. package/crates/team-agent/src/lifecycle/tests/lifecycle_lock.rs +0 -339
  233. package/crates/team-agent/src/lifecycle/tests/lifecycle_rollback_red.rs +0 -596
  234. package/crates/team-agent/src/lifecycle/tests/main_preserved.rs +0 -513
  235. package/crates/team-agent/src/lifecycle/tests/mcp_tool_name_format_red.rs +0 -69
  236. package/crates/team-agent/src/lifecycle/tests/phase_b_contracts.rs +0 -824
  237. package/crates/team-agent/src/lifecycle/tests/phase_golden.rs +0 -723
  238. package/crates/team-agent/src/lifecycle/tests/pi_catalog_red.rs +0 -152
  239. package/crates/team-agent/src/lifecycle/tests/pi_command_red.rs +0 -182
  240. package/crates/team-agent/src/lifecycle/tests/pi_dual_entry_red.rs +0 -374
  241. package/crates/team-agent/src/lifecycle/tests/pi_executable_mcp_red.rs +0 -546
  242. package/crates/team-agent/src/lifecycle/tests/pi_lifecycle_doctor_red.rs +0 -31
  243. package/crates/team-agent/src/lifecycle/tests/pi_native_mcp_capability_red.rs +0 -528
  244. package/crates/team-agent/src/lifecycle/tests/pi_session_delivery_red.rs +0 -134
  245. package/crates/team-agent/src/lifecycle/tests/quick_start_worker_readiness_red.rs +0 -333
  246. package/crates/team-agent/src/lifecycle/tests/realmachine_clusters_1_6_red.rs +0 -786
  247. package/crates/team-agent/src/lifecycle/tests/realmachine_residual_g1_g4_red.rs +0 -648
  248. package/crates/team-agent/src/lifecycle/tests/restart.rs +0 -185
  249. package/crates/team-agent/src/lifecycle/tests/restart_build_before_destroy_0540_contract.rs +0 -1053
  250. package/crates/team-agent/src/lifecycle/tests/restart_liveness_red.rs +0 -679
  251. package/crates/team-agent/src/lifecycle/tests/restart_rebind_hotfix_252_red.rs +0 -1126
  252. package/crates/team-agent/src/lifecycle/tests/restart_session_capture_red.rs +0 -153
  253. package/crates/team-agent/src/lifecycle/tests/resume_recover_red.rs +0 -427
  254. package/crates/team-agent/src/lifecycle/tests/stale_team_saveconflict_contract.rs +0 -431
  255. package/crates/team-agent/src/lifecycle/tests/startup_latency_contract.rs +0 -1066
  256. package/crates/team-agent/src/lifecycle/tests/status_credential_redaction_contract.rs +0 -876
  257. package/crates/team-agent/src/lifecycle/tests/subprep_codex_trust_roundtrip_red.rs +0 -1026
  258. package/crates/team-agent/src/lifecycle/tests/swallow_batch4_semantics_red.rs +0 -90
  259. package/crates/team-agent/src/lifecycle/tests/team_in_team_identity_scope_red.rs +0 -543
  260. package/crates/team-agent/src/lifecycle/tests/team_in_team_sibling_quick_start_red.rs +0 -1103
  261. package/crates/team-agent/src/lifecycle/tests/team_in_team_state_scope_red.rs +0 -1276
  262. package/crates/team-agent/src/lifecycle/tests/team_key_retirement_roster_red.rs +0 -145
  263. package/crates/team-agent/src/lifecycle/tests/team_key_retirement_txn_red.rs +0 -603
  264. package/crates/team-agent/src/lifecycle/tests/test_isolation_escape_contract.rs +0 -936
  265. package/crates/team-agent/src/lifecycle/tests/upgrade_compat_0211_red.rs +0 -970
  266. package/crates/team-agent/src/lifecycle/tests/verify_rs031_window_consistency_red.rs +0 -996
  267. package/crates/team-agent/src/lifecycle/tests/worker_spawn_env_red.rs +0 -827
  268. package/crates/team-agent/src/lifecycle/tests.rs +0 -102
  269. package/crates/team-agent/src/lifecycle/types.rs +0 -861
  270. package/crates/team-agent/src/lifecycle/worker_command_context.rs +0 -370
  271. package/crates/team-agent/src/main.rs +0 -52
  272. package/crates/team-agent/src/mcp_server/helpers.rs +0 -510
  273. package/crates/team-agent/src/mcp_server/lifecycle_tools/mod.rs +0 -6
  274. package/crates/team-agent/src/mcp_server/lifecycle_tools/state_status.rs +0 -43
  275. package/crates/team-agent/src/mcp_server/mod.rs +0 -119
  276. package/crates/team-agent/src/mcp_server/normalize.rs +0 -485
  277. package/crates/team-agent/src/mcp_server/readiness.rs +0 -546
  278. package/crates/team-agent/src/mcp_server/readiness_tests.rs +0 -369
  279. package/crates/team-agent/src/mcp_server/tests/golden.rs +0 -285
  280. package/crates/team-agent/src/mcp_server/tests/normalize.rs +0 -247
  281. package/crates/team-agent/src/mcp_server/tests/scoped.rs +0 -168
  282. package/crates/team-agent/src/mcp_server/tests/send.rs +0 -388
  283. package/crates/team-agent/src/mcp_server/tests/tools.rs +0 -343
  284. package/crates/team-agent/src/mcp_server/tests/wire.rs +0 -254
  285. package/crates/team-agent/src/mcp_server/tests.rs +0 -43
  286. package/crates/team-agent/src/mcp_server/tools.rs +0 -1015
  287. package/crates/team-agent/src/mcp_server/types.rs +0 -396
  288. package/crates/team-agent/src/mcp_server/wire.rs +0 -867
  289. package/crates/team-agent/src/messaging/activity.rs +0 -461
  290. package/crates/team-agent/src/messaging/address.rs +0 -87
  291. package/crates/team-agent/src/messaging/delivery.rs +0 -3785
  292. package/crates/team-agent/src/messaging/delivery_consumption_tests.rs +0 -234
  293. package/crates/team-agent/src/messaging/enter_rescue.rs +0 -362
  294. package/crates/team-agent/src/messaging/enter_rescue_tests.rs +0 -633
  295. package/crates/team-agent/src/messaging/helpers.rs +0 -354
  296. package/crates/team-agent/src/messaging/leader_channel.rs +0 -287
  297. package/crates/team-agent/src/messaging/leader_receiver.rs +0 -786
  298. package/crates/team-agent/src/messaging/mod.rs +0 -166
  299. package/crates/team-agent/src/messaging/persist.rs +0 -377
  300. package/crates/team-agent/src/messaging/presentation.rs +0 -417
  301. package/crates/team-agent/src/messaging/results/collection_tests.rs +0 -719
  302. package/crates/team-agent/src/messaging/results.rs +0 -1415
  303. package/crates/team-agent/src/messaging/scheduler.rs +0 -217
  304. package/crates/team-agent/src/messaging/selftest.rs +0 -315
  305. package/crates/team-agent/src/messaging/send.rs +0 -981
  306. package/crates/team-agent/src/messaging/tests/basic.rs +0 -346
  307. package/crates/team-agent/src/messaging/tests/dup_inject.rs +0 -551
  308. package/crates/team-agent/src/messaging/tests/e23.rs +0 -49
  309. package/crates/team-agent/src/messaging/tests/leader_channel.rs +0 -169
  310. package/crates/team-agent/src/messaging/tests/leader_inject_acceptance.rs +0 -817
  311. package/crates/team-agent/src/messaging/tests/main_preserved.rs +0 -85
  312. package/crates/team-agent/src/messaging/tests/mod.rs +0 -306
  313. package/crates/team-agent/src/messaging/tests/runtime.rs +0 -3655
  314. package/crates/team-agent/src/messaging/tests/spine.rs +0 -837
  315. package/crates/team-agent/src/messaging/tests/wave2.rs +0 -381
  316. package/crates/team-agent/src/messaging/trust.rs +0 -215
  317. package/crates/team-agent/src/messaging/types.rs +0 -471
  318. package/crates/team-agent/src/messaging/wait.rs +0 -366
  319. package/crates/team-agent/src/messaging/watchers.rs +0 -916
  320. package/crates/team-agent/src/model/enums.rs +0 -356
  321. package/crates/team-agent/src/model/errors.rs +0 -18
  322. package/crates/team-agent/src/model/ids.rs +0 -165
  323. package/crates/team-agent/src/model/mod.rs +0 -29
  324. package/crates/team-agent/src/model/name_similarity.rs +0 -252
  325. package/crates/team-agent/src/model/pane_authority_refusal.rs +0 -359
  326. package/crates/team-agent/src/model/paths.rs +0 -257
  327. package/crates/team-agent/src/model/routing.rs +0 -387
  328. package/crates/team-agent/src/model/spec.rs +0 -1184
  329. package/crates/team-agent/src/model/task_graph.rs +0 -321
  330. package/crates/team-agent/src/model/testdata/fuzz.golden.yaml +0 -43
  331. package/crates/team-agent/src/model/testdata/fuzz.yaml +0 -43
  332. package/crates/team-agent/src/model/testdata/spec_invalid_a.yaml +0 -209
  333. package/crates/team-agent/src/model/testdata/team.spec.golden.yaml +0 -208
  334. package/crates/team-agent/src/model/testdata/team.spec.yaml +0 -208
  335. package/crates/team-agent/src/model/yaml/tests.rs +0 -188
  336. package/crates/team-agent/src/model/yaml.rs +0 -802
  337. package/crates/team-agent/src/os_probe.rs +0 -280
  338. package/crates/team-agent/src/packaging/install.rs +0 -219
  339. package/crates/team-agent/src/packaging/migrate.rs +0 -38
  340. package/crates/team-agent/src/packaging/mod.rs +0 -91
  341. package/crates/team-agent/src/packaging/repair.rs +0 -33
  342. package/crates/team-agent/src/packaging/tests.rs +0 -822
  343. package/crates/team-agent/src/packaging/types.rs +0 -417
  344. package/crates/team-agent/src/platform/argv.rs +0 -331
  345. package/crates/team-agent/src/platform/errors.rs +0 -104
  346. package/crates/team-agent/src/platform/file_lock.rs +0 -279
  347. package/crates/team-agent/src/platform/mod.rs +0 -5
  348. package/crates/team-agent/src/platform/process.rs +0 -545
  349. package/crates/team-agent/src/provider/adapter.rs +0 -898
  350. package/crates/team-agent/src/provider/adapters/copilot.rs +0 -75
  351. package/crates/team-agent/src/provider/adapters/copilot_fork.rs +0 -307
  352. package/crates/team-agent/src/provider/adapters/fake.rs +0 -18
  353. package/crates/team-agent/src/provider/adapters/mod.rs +0 -28
  354. package/crates/team-agent/src/provider/approvals/mod.rs +0 -3
  355. package/crates/team-agent/src/provider/approvals/parsing.rs +0 -586
  356. package/crates/team-agent/src/provider/approvals/runtime_prompts.rs +0 -205
  357. package/crates/team-agent/src/provider/argv_route.rs +0 -405
  358. package/crates/team-agent/src/provider/bypass_flags.rs +0 -116
  359. package/crates/team-agent/src/provider/classify.rs +0 -773
  360. package/crates/team-agent/src/provider/command_helpers.rs +0 -45
  361. package/crates/team-agent/src/provider/faults.rs +0 -165
  362. package/crates/team-agent/src/provider/helpers.rs +0 -52
  363. package/crates/team-agent/src/provider/mod.rs +0 -78
  364. package/crates/team-agent/src/provider/model_catalog.rs +0 -722
  365. package/crates/team-agent/src/provider/session/capture.rs +0 -2631
  366. package/crates/team-agent/src/provider/session/context_fork/outcome.rs +0 -168
  367. package/crates/team-agent/src/provider/session/context_fork.rs +0 -264
  368. package/crates/team-agent/src/provider/session/mod.rs +0 -36
  369. package/crates/team-agent/src/provider/session/resume.rs +0 -269
  370. package/crates/team-agent/src/provider/session_scan/common/tests.rs +0 -316
  371. package/crates/team-agent/src/provider/session_scan/common.rs +0 -618
  372. package/crates/team-agent/src/provider/session_scan/copilot.rs +0 -280
  373. package/crates/team-agent/src/provider/session_scan/pi.rs +0 -152
  374. package/crates/team-agent/src/provider/session_scan.rs +0 -61
  375. package/crates/team-agent/src/provider/startup_prompt.rs +0 -757
  376. package/crates/team-agent/src/provider/submit_now.rs +0 -71
  377. package/crates/team-agent/src/provider/testdata/copilot-ready-marker.txt +0 -5
  378. package/crates/team-agent/src/provider/testdata/copilot-trust-prompt.txt +0 -19
  379. package/crates/team-agent/src/provider/testdata/grok-models-authenticated.stdout +0 -9
  380. package/crates/team-agent/src/provider/testdata/grok-models-unauthenticated.stdout +0 -7
  381. package/crates/team-agent/src/provider/tests/adapter.rs +0 -354
  382. package/crates/team-agent/src/provider/tests/classify.rs +0 -201
  383. package/crates/team-agent/src/provider/tests/command_helpers.rs +0 -26
  384. package/crates/team-agent/src/provider/tests/copilot_fork.rs +0 -191
  385. package/crates/team-agent/src/provider/tests/faults.rs +0 -200
  386. package/crates/team-agent/src/provider/tests/idle.rs +0 -140
  387. package/crates/team-agent/src/provider/tests/wire.rs +0 -213
  388. package/crates/team-agent/src/provider/tests.rs +0 -32
  389. package/crates/team-agent/src/provider/types.rs +0 -529
  390. package/crates/team-agent/src/provider/wire.rs +0 -406
  391. package/crates/team-agent/src/redaction.rs +0 -259
  392. package/crates/team-agent/src/state/abnormal_watch/tests/mod.rs +0 -248
  393. package/crates/team-agent/src/state/abnormal_watch.rs +0 -144
  394. package/crates/team-agent/src/state/identity.rs +0 -914
  395. package/crates/team-agent/src/state/identity_keys.rs +0 -132
  396. package/crates/team-agent/src/state/mod.rs +0 -74
  397. package/crates/team-agent/src/state/owner_gate.rs +0 -482
  398. package/crates/team-agent/src/state/ownership.rs +0 -563
  399. package/crates/team-agent/src/state/paths.rs +0 -395
  400. package/crates/team-agent/src/state/persist.rs +0 -3811
  401. package/crates/team-agent/src/state/projection.rs +0 -1508
  402. package/crates/team-agent/src/state/repository/intent.rs +0 -14
  403. package/crates/team-agent/src/state/repository/tests.rs +0 -184
  404. package/crates/team-agent/src/state/repository.rs +0 -866
  405. package/crates/team-agent/src/state/selector.rs +0 -160
  406. package/crates/team-agent/src/state/testdata/state-rich.canonical.json +0 -133
  407. package/crates/team-agent/src/tmux_backend/enter_rescue.rs +0 -325
  408. package/crates/team-agent/src/tmux_backend/enter_rescue_tests.rs +0 -432
  409. package/crates/team-agent/src/tmux_backend/native_input.rs +0 -513
  410. package/crates/team-agent/src/tmux_backend/native_input_tests.rs +0 -742
  411. package/crates/team-agent/src/tmux_backend/tests.rs +0 -4254
  412. package/crates/team-agent/src/tmux_backend.rs +0 -4527
  413. package/crates/team-agent/src/topology.rs +0 -537
  414. package/crates/team-agent/src/transport/enter_rescue.rs +0 -166
  415. package/crates/team-agent/src/transport/native_input.rs +0 -491
  416. package/crates/team-agent/src/transport/test_support.rs +0 -743
  417. package/crates/team-agent/src/transport/tests/behavior.rs +0 -326
  418. package/crates/team-agent/src/transport/tests/mod.rs +0 -194
  419. package/crates/team-agent/src/transport/tests/wire.rs +0 -574
  420. package/crates/team-agent/src/transport.rs +0 -1655
  421. package/crates/team-agent/src/transport_factory.rs +0 -819
@@ -1,3655 +0,0 @@
1
- use super::*;
2
- use crate::transport::test_support::OfflineTransport;
3
- use crate::transport::{PaneId, Target};
4
-
5
- fn pane_info(pane_id: &str, session: &str, window: &str) -> PaneInfo {
6
- PaneInfo {
7
- pane_id: PaneId::new(pane_id),
8
- session: SessionName::new(session),
9
- window_index: None,
10
- window_name: Some(WindowName::new(window)),
11
- pane_index: None,
12
- tty: None,
13
- current_command: None,
14
- current_path: None,
15
- active: true,
16
- pane_pid: None,
17
- leader_env: BTreeMap::new(),
18
- }
19
- }
20
-
21
- // ════════════════════════════════════════════════════════════════════════
22
- // GROUP E — legacy diagnostics may only advance an existing durable row.
23
- // ════════════════════════════════════════════════════════════════════════
24
-
25
- #[test]
26
- fn fail_leader_delivery_without_message_id_does_not_invent_a_row() {
27
- let ws = tmp_ws("faillead");
28
- let payload = json(serde_json::json!({
29
- "to": "leader", "content": "hi", "sender": "coordinator"
30
- }));
31
- let out = fail_leader_delivery(
32
- &ws,
33
- &payload,
34
- DeliveryRefusal::LeaderNotAttached,
35
- Some("No direct leader tmux pane is attached. Run team-agent attach-leader."),
36
- )
37
- .unwrap();
38
- assert!(!out.ok);
39
- assert_eq!(out.status, DeliveryStatus::FallbackLog);
40
- assert_eq!(out.reason, Some(DeliveryRefusal::LeaderNotAttached));
41
- assert_eq!(out.message_id, None);
42
- assert_ne!(out.status, DeliveryStatus::Delivered);
43
- let store = MessageStore::open(&ws).unwrap();
44
- let connection = crate::db::schema::open_db(store.db_path()).unwrap();
45
- let rows: i64 = connection
46
- .query_row("select count(*) from messages", [], |row| row.get(0))
47
- .unwrap();
48
- assert_eq!(rows, 0, "diagnostics cannot create a fallback message row");
49
- }
50
-
51
- // ════════════════════════════════════════════════════════════════════════
52
- // GROUP F — session_drift_refusal: None-vs-refused fallthrough chain.
53
- // session_drift.py:69-91.
54
- // ════════════════════════════════════════════════════════════════════════
55
-
56
- #[test]
57
- fn session_drift_refusal_none_for_no_target_leader_or_broadcast() {
58
- let ws = tmp_ws("driftnone");
59
- let log = EventLog::new(&ws);
60
- let state = json(serde_json::json!({"agents": {}}));
61
- // target == leader_id → None (no refusal).
62
- assert!(
63
- session_drift_refusal(&state, "leader", "leader", "s", None, &log)
64
- .unwrap()
65
- .is_none()
66
- );
67
- // target == "*" (broadcast) → None.
68
- assert!(
69
- session_drift_refusal(&state, "*", "leader", "s", None, &log)
70
- .unwrap()
71
- .is_none()
72
- );
73
- }
74
-
75
- #[test]
76
- fn session_drift_refusal_none_when_status_not_drift() {
77
- let ws = tmp_ws("driftok");
78
- let log = EventLog::new(&ws);
79
- let state = json(serde_json::json!({"agents": {"w1": {"status": "idle"}}}));
80
- assert!(
81
- session_drift_refusal(&state, "w1", "leader", "s", None, &log)
82
- .unwrap()
83
- .is_none()
84
- );
85
- }
86
-
87
- #[test]
88
- fn session_drift_refusal_refuses_when_agent_in_drift() {
89
- // session_drift.py:84-91 → ok False, reason session_drift, action reset-agent.
90
- let ws = tmp_ws("driftrefuse");
91
- let log = EventLog::new(&ws);
92
- let state = json(serde_json::json!({
93
- "agents": {"w1": {"status": "session_drift",
94
- "session_drift": {"stored_session_id": "S", "actual_thread_id": "A"}}}
95
- }));
96
- let out = session_drift_refusal(&state, "w1", "leader", "leader", None, &log)
97
- .unwrap()
98
- .expect("drift agent must be refused");
99
- assert!(!out.ok);
100
- assert_eq!(out.status, DeliveryStatus::Refused);
101
- assert_eq!(out.reason, Some(DeliveryRefusal::SessionDrift));
102
- }
103
-
104
- // ════════════════════════════════════════════════════════════════════════
105
- // GROUP G — classify_agent_activity: every branch incl. the uncertain
106
- // fallthrough iron law. activity_detector.py:90-146 (golden probed).
107
- // ════════════════════════════════════════════════════════════════════════
108
-
109
- #[test]
110
- fn classify_pane_in_mode_is_uncertain_high_confidence() {
111
- let state = json(serde_json::json!({}));
112
- let a = classify_agent_activity(&state, "", true, None, None);
113
- assert_eq!(a.status, ActivityStatus::Uncertain);
114
- assert_eq!(a.confidence, 0.9);
115
- }
116
-
117
- #[test]
118
- fn classify_idle_prompt_is_idle() {
119
- // "❯ \n" matches the Claude idle prompt → idle 0.9.
120
- let state = json(serde_json::json!({}));
121
- let a = classify_agent_activity(&state, "❯ \n", false, None, None);
122
- assert_eq!(a.status, ActivityStatus::Idle);
123
- assert_eq!(a.confidence, 0.9);
124
- }
125
-
126
- #[test]
127
- fn classify_working_indicator_is_working() {
128
- let state = json(serde_json::json!({}));
129
- let a = classify_agent_activity(&state, "Working (5s)", false, None, None);
130
- assert_eq!(a.status, ActivityStatus::Working);
131
- assert_eq!(a.confidence, 0.9);
132
- }
133
-
134
- #[test]
135
- fn classify_stale_working_is_stuck() {
136
- // elapsed >= stuck_timeout (300) → stuck 0.85.
137
- let state = json(serde_json::json!({}));
138
- let a = classify_agent_activity(&state, "Working (400s)", false, None, None);
139
- assert_eq!(a.status, ActivityStatus::Stuck);
140
- assert_eq!(a.confidence, 0.85);
141
- }
142
-
143
- #[test]
144
- fn classify_no_signal_is_uncertain_never_idle() {
145
- // THE IRON LAW: no decisive prompt/working signal → uncertain 0.5, NOT idle.
146
- let state = json(serde_json::json!({}));
147
- let a = classify_agent_activity(&state, "random prose nothing", false, None, None);
148
- assert_eq!(a.status, ActivityStatus::Uncertain);
149
- assert_eq!(a.confidence, 0.5);
150
- assert_ne!(a.status, ActivityStatus::Idle);
151
- }
152
-
153
- #[test]
154
- fn classify_recent_provider_output_is_working_low_confidence() {
155
- // age <= 120 with provider/no command → working 0.7.
156
- let state = json(serde_json::json!({}));
157
- let now = chrono::Utc::now();
158
- let recent = (now - chrono::Duration::seconds(30)).to_rfc3339();
159
- let a = classify_agent_activity(&state, "prose", false, None, Some(&recent));
160
- assert_eq!(a.status, ActivityStatus::Working);
161
- assert_eq!(a.confidence, 0.7);
162
- }
163
-
164
- // STAGE-B REGRESSION RED (dispatch-to-just-launched-agent → deferred_busy never closes the round-trip).
165
- // golden activity_detector.py (classify_agent_activity): the provider IDLE PROMPT is checked FIRST as a
166
- // scrollback-position signal (C14, "provider idle prompt is the latest scrollback signal" → idle 0.9),
167
- // BEFORE the `age<=120 → working 0.7` recent-output branch (:56). Rust (activity.rs:192) fires
168
- // `recent_rfc3339(last_output_at,120) → Working` BEFORE `latest_prompt_signal` (:200), so a just-launched
169
- // agent (startup banner = recent output, but pane shows the idle prompt awaiting input) mis-classifies
170
- // WORKING → sync_agent_health writes agent_health=WORKING → recipient_is_busy → send.deferred_busy.
171
- // Golden evidence (probe): classify(idle-prompt scrollback, recent last_output_at) = idle 0.9 regardless
172
- // of active_task. FIX = reorder: latest_prompt_signal (idle/working scrollback-position) BEFORE the
173
- // last_output_at age block.
174
- #[test]
175
- fn classify_idle_prompt_beats_recent_output_for_just_launched_agent() {
176
- let state = json(serde_json::json!({}));
177
- let recent = chrono::Utc::now().to_rfc3339();
178
- let a = classify_agent_activity(
179
- &state,
180
- "codex ready\n❯ \n",
181
- false,
182
- Some("codex"),
183
- Some(&recent),
184
- );
185
- assert_eq!(
186
- a.status,
187
- ActivityStatus::Idle,
188
- "just-launched agent showing the idle prompt must classify IDLE (golden idle-prompt-position is the \
189
- latest scrollback signal, checked before the age<=120 recent-output branch), not WORKING because \
190
- the startup banner is recent (activity.rs:192 recent-output fires before latest_prompt_signal:200) \
191
- — the Stage B dispatch deferred_busy regression. got {a:?}"
192
- );
193
- assert_eq!(
194
- a.confidence, 0.9,
195
- "golden idle-prompt confidence is 0.9; got {a:?}"
196
- );
197
- }
198
-
199
- #[test]
200
- fn classify_copilot_idle_prompt_is_not_masked_by_current_command() {
201
- let state = json(serde_json::json!({}));
202
- let a = classify_agent_activity(
203
- &state,
204
- " / commands · ? help\n❯ \n",
205
- false,
206
- Some("copilot"),
207
- None,
208
- );
209
- assert_eq!(a.status, ActivityStatus::Idle);
210
- assert_eq!(a.confidence, 0.9);
211
- }
212
-
213
- // ════════════════════════════════════════════════════════════════════════
214
- // GROUP H — attempt_trust_auto_answer: own-vs-foreign realpath + fail-safe
215
- // pane-width + opt-in gate + reason byte-locks. leader_panes.py:383-470.
216
- // ════════════════════════════════════════════════════════════════════════
217
-
218
- #[test]
219
- fn trust_auto_answer_pane_id_missing_reason() {
220
- // leader_panes.py:417-424 — pane_id None → pane_id_missing (after opt-in).
221
- let ws = tmp_ws("trustpane");
222
- let log = EventLog::new(&ws);
223
- let t = NoopTransport;
224
- let out = attempt_trust_auto_answer(
225
- &ws,
226
- &t,
227
- None,
228
- "some prompt",
229
- &PaneWidthQuery::Ok { pane_width: 120 },
230
- &log,
231
- )
232
- .unwrap();
233
- assert!(!out.ok);
234
- assert!(!out.answered);
235
- assert_eq!(out.reason, "pane_id_missing");
236
- }
237
-
238
- #[test]
239
- fn trust_auto_answer_foreign_workspace_refused() {
240
- // leader_panes.py:430-444 — prompt names a FOREIGN dir → workspace_dir_mismatch,
241
- // action prompt_leader. (own-vs-foreign realpath gate.)
242
- let ws = tmp_ws("trustforeign");
243
- let log = EventLog::new(&ws);
244
- let t = NoopTransport;
245
- let pane = PaneId::new("%7");
246
- let foreign_tail = "Allow Codex to access /some/other/foreign/dir ?";
247
- let out = attempt_trust_auto_answer(
248
- &ws,
249
- &t,
250
- Some(&pane),
251
- foreign_tail,
252
- &PaneWidthQuery::Ok { pane_width: 120 },
253
- &log,
254
- )
255
- .unwrap();
256
- assert!(!out.answered);
257
- assert_eq!(out.reason, "workspace_dir_mismatch");
258
- assert_eq!(out.action.as_deref(), Some("prompt_leader"));
259
- }
260
-
261
- #[test]
262
- fn trust_auto_answer_own_workspace_realpath_equal_answers() {
263
- // Exact canonical equality of the prompt path with the workspace → answered.
264
- let ws = tmp_ws("trustown");
265
- let canonical = std::fs::canonicalize(&ws).unwrap();
266
- let log = EventLog::new(&ws);
267
- let t = NoopTransport;
268
- let pane = PaneId::new("%7");
269
- let tail = format!("Allow Codex to write to {} ?", canonical.display());
270
- let out = attempt_trust_auto_answer(
271
- &canonical,
272
- &t,
273
- Some(&pane),
274
- &tail,
275
- &PaneWidthQuery::Ok { pane_width: 240 },
276
- &log,
277
- )
278
- .unwrap();
279
- assert!(
280
- out.answered,
281
- "own-workspace realpath-equal prompt must auto-answer"
282
- );
283
- assert_eq!(out.reason, "trust_auto_answered");
284
- }
285
-
286
- // ════════════════════════════════════════════════════════════════════════
287
- // GROUP I — PaneWidthQuery fail-safe (bug-064/082): Failed NEVER carries a
288
- // default width; tmux_pane_width returns Failed on any query failure.
289
- // delivery.py:20-51.
290
- // ════════════════════════════════════════════════════════════════════════
291
-
292
- #[test]
293
- fn pane_width_failed_forces_exact_match_never_default() {
294
- // GROUP-I fail-safe (bug-064/082, folded from the old structural placeholder):
295
- // calls the REAL attempt_trust_auto_answer. A FOREIGN path that is merely a
296
- // truncated PREFIX of this workspace would only match with a width signal that
297
- // proves right-edge truncation (leader_panes.py:_token_reaches_right_edge). With
298
- // PaneWidthQuery::Failed there is NO width signal and NO default width to leak,
299
- // so the matcher MUST fall back to exact canonical equality → the prefix does
300
- // NOT match → workspace_dir_mismatch / prompt_leader. Probed golden:
301
- // leader_panes.py:430-444 with pane_width=None (Failed) → workspace_dir_mismatch.
302
- let ws = tmp_ws("panewidthfailsafe");
303
- let canonical = std::fs::canonicalize(&ws).unwrap();
304
- let log = EventLog::new(&ws);
305
- let t = NoopTransport;
306
- let pane = PaneId::new("%7");
307
- // A right-edge-truncated prefix of the real workspace path (drop the last char):
308
- // would auto-answer IF a width signal proved truncation — but Failed forbids that.
309
- let canon_str = canonical.to_string_lossy();
310
- let truncated_prefix = &canon_str[..canon_str.len().saturating_sub(1)];
311
- let tail = format!("Allow Codex to write to {truncated_prefix}");
312
- let out = attempt_trust_auto_answer(
313
- &canonical,
314
- &t,
315
- Some(&pane),
316
- &tail,
317
- &PaneWidthQuery::Failed {
318
- error: "tmux_query_failed:CalledProcessError".to_string(),
319
- },
320
- &log,
321
- )
322
- .unwrap();
323
- // fail-safe: no width → exact-equality only → truncated prefix refused.
324
- assert!(
325
- !out.answered,
326
- "Failed pane-width must NOT enable prefix/truncation matching"
327
- );
328
- assert_eq!(out.reason, "workspace_dir_mismatch");
329
- assert_eq!(out.action.as_deref(), Some("prompt_leader"));
330
- }
331
-
332
- #[test]
333
- fn tmux_pane_width_failure_yields_failed_not_default() {
334
- // delivery.py:37-50 — any failure path returns Failed (never a guessed width).
335
- let t = NoopTransport;
336
- let target = Target::Pane(PaneId::new("%nonexistent"));
337
- let q = tmux_pane_width(&t, &target);
338
- assert!(
339
- matches!(q, PaneWidthQuery::Failed { .. }),
340
- "query failure must be fail-safe Failed, never a default width"
341
- );
342
- }
343
-
344
- // ════════════════════════════════════════════════════════════════════════
345
- // GROUP J — trust retry status machine: bounded attempt → exhausted terminal.
346
- // delivery.py:221-319 (_handle_trust_retry_needed).
347
- // ════════════════════════════════════════════════════════════════════════
348
-
349
- #[test]
350
- fn handle_trust_retry_below_max_schedules_retry() {
351
- // attempt 1 (< 4) → next_attempt 2 scheduled, status retry_scheduled,
352
- // stage trust_auto_answer_dismissal_wait. NOT marked terminal-failed.
353
- let ws = tmp_ws("trustretry1");
354
- let store = store_for(&ws);
355
- let log = EventLog::new(&ws);
356
- let payload = TrustRetryPayload {
357
- message_id: "m1".to_string(),
358
- attempt: 1,
359
- max_attempts: TRUST_RETRY_MAX_ATTEMPTS,
360
- first_target: PaneId::new("%7"),
361
- };
362
- let out = handle_trust_retry_needed(&store, &payload, &log).unwrap();
363
- assert_eq!(out.status, DeliveryStatus::RetryScheduled);
364
- assert_eq!(out.stage, Some(DeliveryStage::TrustAutoAnswerDismissalWait));
365
- assert!(!out.ok);
366
- }
367
-
368
- #[test]
369
- fn handle_trust_retry_at_max_is_exhausted_terminal() {
370
- // attempt == 4 (== MAX) → next_attempt 5 > MAX → terminal exhausted, marks
371
- // message failed, emits trust_auto_answer_exhausted. delivery.py:246-266.
372
- let ws = tmp_ws("trustretry4");
373
- let store = store_for(&ws);
374
- let log = EventLog::new(&ws);
375
- let payload = TrustRetryPayload {
376
- message_id: "m1".to_string(),
377
- attempt: TRUST_RETRY_MAX_ATTEMPTS,
378
- max_attempts: TRUST_RETRY_MAX_ATTEMPTS,
379
- first_target: PaneId::new("%7"),
380
- };
381
- let out = handle_trust_retry_needed(&store, &payload, &log).unwrap();
382
- // delivery.py:257-259 — terminal exhausted: ok False, status the dedicated
383
- // trust_auto_answer_exhausted (a bounded-loop termination guarantee, NOT a
384
- // refusal reason — `reason` stays None at the typed boundary).
385
- assert_eq!(out.status, DeliveryStatus::TrustAutoAnswerExhausted);
386
- assert!(!out.ok);
387
- }
388
-
389
- // ════════════════════════════════════════════════════════════════════════
390
- // GROUP K — send_message target resolution / fallback chain (send.py:36-372).
391
- // RED via unimplemented!(); golden status/reason encoded in assertions.
392
- // ════════════════════════════════════════════════════════════════════════
393
-
394
- #[test]
395
- fn send_message_target_not_in_team_is_refused() {
396
- // send.py:259-261 — non-leader, non-team target → refused/target_not_in_team.
397
- let ws = tmp_ws("sendrefuse");
398
- let opts = SendOptions::default();
399
- let out = send_message(
400
- &ws,
401
- &MessageTarget::Single("ghost".to_string()),
402
- "hi",
403
- &opts,
404
- )
405
- .unwrap();
406
- assert_eq!(out.status, DeliveryStatus::Refused);
407
- assert_eq!(out.reason, Some(DeliveryRefusal::TargetNotInTeam));
408
- }
409
-
410
- #[test]
411
- fn message_not_silently_stuck_accepted_when_coordinator_dead() {
412
- let ws = tmp_ws("sendcoorddead");
413
- crate::state::persist::save_runtime_state(
414
- &ws,
415
- &serde_json::json!({
416
- "session_name": "team-x",
417
- "agents": {
418
- "worker-1": {"status": "running", "agent_id": "worker-1", "window": "worker-1"},
419
- },
420
- }),
421
- )
422
- .unwrap();
423
- let coordinator_ws = crate::coordinator::WorkspacePath::new(ws.clone());
424
- std::fs::create_dir_all(crate::model::paths::runtime_dir(&ws)).unwrap();
425
- let _ = MessageStore::open(&ws).unwrap();
426
- let stale_pid = crate::coordinator::Pid::new(99_999_999);
427
- crate::coordinator::write_coordinator_metadata(
428
- &coordinator_ws,
429
- stale_pid,
430
- crate::coordinator::MetadataSource::Boot,
431
- )
432
- .unwrap();
433
- std::fs::write(
434
- crate::coordinator::coordinator_pid_path(&coordinator_ws),
435
- stale_pid.to_string(),
436
- )
437
- .unwrap();
438
-
439
- let out = send_message(
440
- &ws,
441
- &MessageTarget::Single("worker-1".to_string()),
442
- "hi",
443
- &SendOptions::default(),
444
- )
445
- .unwrap();
446
-
447
- assert!(out.ok, "durable persistence is the send success boundary");
448
- assert_eq!(out.status, DeliveryStatus::Blocked);
449
- assert_eq!(out.message_status.0, "queued_coordinator_unavailable");
450
- assert!(out
451
- .message_id
452
- .as_deref()
453
- .is_some_and(|id| id.starts_with("msg_")));
454
- assert_eq!(out.reason, Some(DeliveryRefusal::CoordinatorUnavailable));
455
- assert!(
456
- out.verification
457
- .as_deref()
458
- .is_some_and(|warning| warning.contains("coordinator is not running")),
459
- "N38 warning must explain the durable retry blocker; out={out:?}"
460
- );
461
- let store = MessageStore::open(&ws).unwrap();
462
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
463
- let blocked: i64 = conn
464
- .query_row(
465
- "select count(*) from messages where status = 'queued_coordinator_unavailable' \
466
- and error = 'coordinator_unavailable' and delivered_at is null",
467
- [],
468
- |row| row.get(0),
469
- )
470
- .unwrap();
471
- assert_eq!(
472
- blocked, 1,
473
- "dead coordinator send must park exactly one durable, non-delivered row"
474
- );
475
- let events = EventLog::new(&ws).tail(20).unwrap();
476
- assert!(
477
- events.iter().any(|event| {
478
- event.get("event").and_then(serde_json::Value::as_str)
479
- == Some("send.coordinator_unavailable")
480
- && event
481
- .get("message_queued")
482
- .and_then(serde_json::Value::as_bool)
483
- == Some(true)
484
- }),
485
- "send.coordinator_unavailable event must be durable; events={events:?}"
486
- );
487
- }
488
-
489
- #[test]
490
- fn send_message_broadcast_empty_team_skips_no_recipients() {
491
- // send.py:391-393 — "*" with no team recipients →
492
- // {"ok": False, "status": "failed", "reason": "no_team_recipients", "to": "*"}.
493
- // Post-#230 N31/N32 funnel implementation (cr-approved): broadcast now expands the
494
- // recipient set via `broadcast_recipients(state, sender, team)` and routes each
495
- // recipient through the SAME primitives as a single send (leader → primitive,
496
- // peer → send_message). The assertions stay the same: with no agents seeded and
497
- // sender="leader" (default opts.sender), `broadcast_recipients` returns an empty
498
- // list — outcome is Failed/no-recipients with channel="*". The "*" channel label
499
- // is preserved through the new `fanout_send(..., channel_label="*")` parameter so
500
- // legacy consumers can still tell broadcast (`*`) apart from explicit fanout list.
501
- let ws = tmp_ws("sendbcast");
502
- let opts = SendOptions::default();
503
- let out = send_message(&ws, &MessageTarget::Broadcast, "hi", &opts).unwrap();
504
- assert!(!out.ok);
505
- assert_eq!(out.status, DeliveryStatus::Failed);
506
- assert_eq!(
507
- out.reason, None,
508
- "no_team_recipients is a failed-status terminal, not a typed refusal reason"
509
- );
510
- assert_eq!(
511
- out.channel.as_deref(),
512
- Some("*"),
513
- "broadcast outcome must carry the '*' channel (send.py to='*'); fanout_send(channel_label=\"*\") preserves this"
514
- );
515
- }
516
-
517
- #[test]
518
- fn send_message_fanout_empty_recipients_fails() {
519
- // send.py:456-457 — fanout with no usable recipients → ok False,
520
- // no_fanout_recipients. (Dedup-then-deliver happy path needs team fixtures.)
521
- let ws = tmp_ws("sendfanout");
522
- let opts = SendOptions::default();
523
- let out = send_message(&ws, &MessageTarget::Fanout(vec![]), "hi", &opts).unwrap();
524
- assert!(!out.ok);
525
- assert_eq!(out.status, DeliveryStatus::Failed);
526
- }
527
-
528
- // ════════════════════════════════════════════════════════════════════════
529
- // GROUP L — apply_worker_sender_bypass: owner-gate first-door bypass event.
530
- // owner_bypass.py:9-26.
531
- // ════════════════════════════════════════════════════════════════════════
532
-
533
- #[test]
534
- fn worker_sender_bypass_false_for_leader_sender() {
535
- // owner_bypass.py — leader sender never bypasses (worker_sender_bypasses=None).
536
- let ws = tmp_ws("bypassleader");
537
- let log = EventLog::new(&ws);
538
- let state = json(serde_json::json!({"agents": {"w1": {}}}));
539
- let bypassed = apply_worker_sender_bypass(
540
- &state,
541
- Some("leader"),
542
- &MessageTarget::Single("w1".to_string()),
543
- None,
544
- &log,
545
- )
546
- .unwrap();
547
- assert!(!bypassed);
548
- }
549
-
550
- #[test]
551
- #[serial_test::serial(env)]
552
- fn worker_sender_bypass_true_for_known_worker_sender() {
553
- // owner_bypass.py:18-26 — worker in agents bypasses, writes
554
- // send.bypassed_owner_gate_worker_sender.
555
- // Isolate from ambient TEAM_AGENT_ID: the env identity gate only activates when
556
- // TEAM_AGENT_ID is SET (and != sender → deny, see p2_owner_bypass_denies_*). Unset
557
- // here so the agents-membership bypass is tested deterministically regardless of the
558
- // process env (workers run with TEAM_AGENT_ID set; the leader does not).
559
- let _g = ENV_LOCK_MSG.lock().unwrap_or_else(|p| p.into_inner());
560
- let _e = EnvGuardMsg::set("TEAM_AGENT_ID", None);
561
- let ws = tmp_ws("bypassworker");
562
- let log = EventLog::new(&ws);
563
- let state = json(serde_json::json!({"agents": {"w1": {}}}));
564
- let bypassed = apply_worker_sender_bypass(
565
- &state,
566
- Some("w1"),
567
- &MessageTarget::Single("w2".to_string()),
568
- None,
569
- &log,
570
- )
571
- .unwrap();
572
- assert!(bypassed);
573
- }
574
-
575
- // ════════════════════════════════════════════════════════════════════════
576
- // GROUP M — report_result intake (results.py:191-227): validate envelope,
577
- // queue leader notify (channel coordinator), return ok shape.
578
- // ════════════════════════════════════════════════════════════════════════
579
-
580
- #[test]
581
- fn report_result_valid_envelope_returns_ok_with_result_id() {
582
- let ws = tmp_ws("report");
583
- let envelope = json(serde_json::json!({
584
- "schema_version": "result_envelope_v1",
585
- "task_id": "t1", "agent_id": "alice", "status": "success",
586
- "summary": "done", "changes": [], "tests": [], "risks": [],
587
- "artifacts": [], "next_actions": []
588
- }));
589
- let out = report_result(&ws, &envelope).unwrap();
590
- // results.py:216-227 — ok True with result_id/task_id/agent_id echoed.
591
- assert_eq!(out.get("ok").and_then(|v| v.as_bool()), Some(true));
592
- assert_eq!(out.get("task_id").and_then(|v| v.as_str()), Some("t1"));
593
- assert_eq!(out.get("agent_id").and_then(|v| v.as_str()), Some("alice"));
594
- assert!(out.get("result_id").and_then(|v| v.as_str()).is_some());
595
- }
596
-
597
- #[test]
598
- fn report_result_auto_finalizes_and_queues_compact_leader_notification() {
599
- let ws = tmp_ws("reportauto");
600
- crate::state::persist::save_runtime_state(
601
- &ws,
602
- &serde_json::json!({
603
- "agents": {"worker": {"status": "running"}},
604
- "tasks": [{"id": "task_1", "status": "running", "assignee": "worker"}]
605
- }),
606
- )
607
- .unwrap();
608
- let envelope = json(serde_json::json!({
609
- "schema_version": "result_envelope_v1",
610
- "task_id": "task_1",
611
- "agent_id": "worker",
612
- "status": "success",
613
- "summary": "done",
614
- "changes": [],
615
- "tests": [{"command": "cargo test", "status": "passed"}],
616
- "risks": [],
617
- "artifacts": [],
618
- "next_actions": []
619
- }));
620
-
621
- let out = report_result(&ws, &envelope).unwrap();
622
- assert_eq!(out["finalization_status"], "auto_finalized");
623
- assert_eq!(out["notification_status"], "queued");
624
- assert_eq!(out["leader_notified"], false);
625
-
626
- let store = store_for(&ws);
627
- let conn = seed_conn(&store);
628
- let result_status: String = conn
629
- .query_row("select status from results", [], |row| row.get(0))
630
- .unwrap();
631
- let message_count: i64 = conn
632
- .query_row("select count(*) from messages", [], |row| row.get(0))
633
- .unwrap();
634
- assert_eq!(result_status, "collected");
635
- assert_eq!(message_count, 1);
636
- let (presentation, content): (String, String) = conn
637
- .query_row(
638
- "select presentation, content from messages",
639
- [],
640
- |row| Ok((row.get(0)?, row.get(1)?)),
641
- )
642
- .unwrap();
643
- assert_eq!(
644
- serde_json::from_str::<serde_json::Value>(&presentation).unwrap()["class"],
645
- "stage_result"
646
- );
647
- assert!(content.len() < 320, "leader notification must stay compact");
648
- let state = crate::state::persist::load_runtime_state(&ws).unwrap();
649
- assert_eq!(state["tasks"][0]["status"], "done");
650
- assert_eq!(
651
- state["tasks"][0]["accepted_result_id"].as_str().is_some(),
652
- true
653
- );
654
- assert!(
655
- std::fs::read_to_string(ws.join(".team/logs/events.jsonl"))
656
- .unwrap()
657
- .contains("\"collect.result\"")
658
- );
659
- }
660
-
661
- #[test]
662
- fn report_result_message_scope_finalizes_latest_assigned_task() {
663
- let ws = tmp_ws("reportauto-message");
664
- crate::state::persist::save_runtime_state(
665
- &ws,
666
- &serde_json::json!({
667
- "active_team_key": "team-a",
668
- "teams": {
669
- "team-a": {
670
- "agents": {"worker": {"status": "running"}},
671
- "tasks": [{"id": "task_initial", "status": "pending", "assignee": "worker"}]
672
- }
673
- }
674
- }),
675
- )
676
- .unwrap();
677
- let store = store_for(&ws);
678
- let conn = seed_conn(&store);
679
- conn.execute(
680
- "insert into messages(message_id, owner_team_id, sender, recipient, status, content, created_at) values (?1, ?2, ?3, ?4, ?5, ?6, ?7)",
681
- rusqlite::params![
682
- "msg_turn",
683
- "team-a",
684
- "leader",
685
- "worker",
686
- "delivered",
687
- "complete the task",
688
- "2026-09-19T00:00:00Z",
689
- ],
690
- )
691
- .unwrap();
692
- let envelope = json(serde_json::json!({
693
- "schema_version": "result_envelope_v1",
694
- "task_id": "msg_turn",
695
- "agent_id": "worker",
696
- "status": "success",
697
- "summary": "done",
698
- "changes": [],
699
- "tests": [],
700
- "risks": [],
701
- "artifacts": [],
702
- "next_actions": []
703
- }));
704
-
705
- let out = report_result(&ws, &envelope).unwrap();
706
- assert_eq!(out["finalization_status"], "auto_finalized");
707
- assert_eq!(out["notification_status"], "queued");
708
- let state = crate::state::persist::load_runtime_state(&ws).unwrap();
709
- assert_eq!(state["teams"]["team-a"]["tasks"][0]["status"], "done");
710
- assert!(state["teams"]["team-a"]["tasks"][0]["accepted_result_id"]
711
- .as_str()
712
- .is_some());
713
- }
714
-
715
- #[test]
716
- fn report_result_invalid_envelope_errors_validation() {
717
- // validate_result_envelope raises ValidationError → MessagingError::Validation.
718
- let ws = tmp_ws("reportbad");
719
- let envelope = json(serde_json::json!({"schema_version": "result_envelope_v1"}));
720
- let err = report_result(&ws, &envelope).unwrap_err();
721
- assert!(
722
- matches!(err, MessagingError::Validation(_)),
723
- "missing required fields must surface as Validation, got {err:?}"
724
- );
725
- }
726
-
727
- #[test]
728
- fn leader_receiver_reports_requires_ack_forced_off() {
729
- let ws = tmp_ws("ack-forced-off");
730
- let log = EventLog::new(&ws);
731
- let state = json(serde_json::json!({
732
- "active_team_key": "team-a",
733
- "teams": {"team-a": {}}
734
- }));
735
-
736
- let outcome = send_to_leader_receiver(
737
- &ws,
738
- &state,
739
- "leader",
740
- "ack contract probe",
741
- None,
742
- "worker",
743
- true,
744
- None,
745
- &log,
746
- )
747
- .unwrap();
748
-
749
- let value = crate::mcp_server::helpers::delivery_outcome_value(&outcome);
750
- assert_eq!(
751
- value
752
- .get("ack_forced_off")
753
- .and_then(serde_json::Value::as_bool),
754
- Some(true),
755
- "requires_ack=true must report that the unavailable ack guarantee was forced off"
756
- );
757
- }
758
-
759
- // ════════════════════════════════════════════════════════════════════════
760
- // GROUP N — notify_result_watchers dedupe (exactly-once, Gap 32/38).
761
- // result_delivery.py:38-132. superseded for duplicate watchers same result.
762
- // ════════════════════════════════════════════════════════════════════════
763
-
764
- #[test]
765
- fn notify_result_watchers_no_match_returns_empty() {
766
- // result_delivery.py:51-52 — no candidate watcher matches → empty list.
767
- let ws = tmp_ws("notifyempty");
768
- let log = EventLog::new(&ws);
769
- let result = json(serde_json::json!({
770
- "result_id": "r1", "task_id": "t1", "agent_id": "alice"
771
- }));
772
- let watchers = vec![json(serde_json::json!({
773
- "watcher_id": "w-x", "task_id": "OTHER", "agent_id": "alice"
774
- }))];
775
- let notices = notify_result_watchers(&ws, &result, &log, Some(&watchers), None).unwrap();
776
- assert!(notices.is_empty());
777
- }
778
-
779
- #[test]
780
- fn notify_result_watchers_supersedes_duplicate_watchers() {
781
- // result_delivery.py:53-78 — two watchers same (task,agent,result): earliest is
782
- // primary, the other gets superseded (ok False, notice records superseded).
783
- let ws = tmp_ws("notifysup");
784
- let log = EventLog::new(&ws);
785
- let result = json(serde_json::json!({
786
- "result_id": "r1", "task_id": "t1", "agent_id": "alice"
787
- }));
788
- let watchers = vec![
789
- json(serde_json::json!({
790
- "watcher_id": "w-early", "task_id": "t1", "agent_id": "alice",
791
- "created_at": "2026-06-02T10:00:00+00:00"
792
- })),
793
- json(serde_json::json!({
794
- "watcher_id": "w-late", "task_id": "t1", "agent_id": "alice",
795
- "created_at": "2026-06-02T11:00:00+00:00"
796
- })),
797
- ];
798
- let notices = notify_result_watchers(&ws, &result, &log, Some(&watchers), None).unwrap();
799
- // The late watcher must appear as a superseded (not-ok) notice — exactly-once.
800
- let superseded = notices
801
- .iter()
802
- .find(|n| n.watcher_id == "w-late")
803
- .expect("late watcher must be reported");
804
- assert!(
805
- !superseded.ok,
806
- "duplicate watcher must be superseded, not re-delivered"
807
- );
808
- }
809
-
810
- // ════════════════════════════════════════════════════════════════════════
811
- // GROUP O — requeue_after_claim_leader: notified_message_id must SURVIVE (Gap
812
- // 32) — already-notified watchers are NOT requeued. result_delivery.py:428-506.
813
- // ════════════════════════════════════════════════════════════════════════
814
-
815
- #[test]
816
- fn requeue_after_claim_leader_skips_already_notified() {
817
- // Gap 32 (result_delivery.py:467-471) — SEEDED dedupe gate: two same-team
818
- // watchers, one already notified (notified_message_id set), one un-notified.
819
- // requeue must return ONLY the un-notified watcher; the notified one is NOT
820
- // requeued and its notified_message_id SURVIVES (clearing it would cause a
821
- // second injection). Probed golden: requeued == [w_un] (result_id present,
822
- // prior_state "pending"); notified watcher keeps notified_message_id.
823
- let ws = tmp_ws("requeue");
824
- let store = store_for(&ws);
825
- let log = EventLog::new(&ws);
826
- let team = TeamKey::new("team-a");
827
- let pane = PaneId::new("%new-leader");
828
-
829
- let w_un = seed_watcher(
830
- &store,
831
- "w-unnotified",
832
- "team-a",
833
- "t1",
834
- "alice",
835
- "pending",
836
- Some("res_retryable"),
837
- None,
838
- );
839
- let w_notified = seed_watcher(
840
- &store,
841
- "w-notified",
842
- "team-a",
843
- "t2",
844
- "bob",
845
- "pending",
846
- None,
847
- Some("msg_already"),
848
- );
849
-
850
- let requeued = requeue_after_claim_leader(&ws, &store, &log, &team, &pane, None).unwrap();
851
-
852
- // ONLY the un-notified watcher requeues (the notified one is the dedupe gate).
853
- let ids: Vec<&str> = requeued.iter().map(|n| n.watcher_id.as_str()).collect();
854
- assert_eq!(
855
- ids,
856
- vec![w_un.as_str()],
857
- "exactly the un-notified watcher requeues"
858
- );
859
- assert!(
860
- !requeued.iter().any(|n| n.watcher_id == w_notified),
861
- "already-notified watcher must NOT be requeued (Gap 32)"
862
- );
863
-
864
- // Gap 32 survival: notified_message_id is preserved on the skipped watcher.
865
- let (_status, notified) = watcher_state(&store, &w_notified);
866
- assert_eq!(
867
- notified.as_deref(),
868
- Some("msg_already"),
869
- "notified_message_id MUST survive requeue — clearing it re-injects (Gap 32)"
870
- );
871
- }
872
-
873
- #[test]
874
- fn requeue_delivery_exhausted_watchers_reopens_only_exhausted() {
875
- let ws = tmp_ws("requeueexhausted");
876
- let store = store_for(&ws);
877
- let log = EventLog::new(&ws);
878
- let team = TeamKey::new("team-a");
879
- let pane = PaneId::new("%leader");
880
-
881
- let rid = seed_result(&store, "res_exhausted", "t1", "alice", "success");
882
- let exhausted = seed_watcher(
883
- &store,
884
- "w-exhausted",
885
- "team-a",
886
- "t1",
887
- "alice",
888
- "delivery_exhausted",
889
- Some(&rid),
890
- None,
891
- );
892
- let notified = seed_watcher(
893
- &store,
894
- "w-exhausted-notified",
895
- "team-a",
896
- "t2",
897
- "bob",
898
- "delivery_exhausted",
899
- Some("res_skip"),
900
- Some("msg_done"),
901
- );
902
- let failed = seed_watcher(
903
- &store,
904
- "w-failed",
905
- "team-a",
906
- "t3",
907
- "carol",
908
- "notify_failed",
909
- Some("res_failed"),
910
- None,
911
- );
912
-
913
- let requeued = requeue_delivery_exhausted_watchers(&ws, &store, &log, &team, &pane).unwrap();
914
-
915
- assert_eq!(
916
- requeued.len(),
917
- 1,
918
- "only delivery_exhausted unnotified watchers requeue"
919
- );
920
- let notice = &requeued[0];
921
- assert_eq!(notice.watcher_id, exhausted);
922
- assert_eq!(notice.result_id.as_deref(), Some(rid.as_str()));
923
- assert_eq!(notice.prior_state.as_deref(), Some("delivery_exhausted"));
924
- // R8 (golden result_watchers.py:95): attach requeue flips delivery_exhausted -> notify_failed (NOT pending).
925
- assert_eq!(notice.status.as_deref(), Some("notify_failed"));
926
-
927
- let (status, _notified_id) = watcher_state(&store, &exhausted);
928
- // R8 (golden): attach requeue leaves the watcher at notify_failed and DEFERS retry to the coordinator
929
- // tick — it does NOT immediately re-deliver (only the claim path retries). So the persisted status is
930
- // notify_failed, not 'notified'.
931
- assert_eq!(
932
- status, "notify_failed",
933
- "attach requeue flips to notify_failed and defers retry (golden)"
934
- );
935
- let (status, notified_id) = watcher_state(&store, &notified);
936
- assert_eq!(status, "delivery_exhausted");
937
- assert_eq!(notified_id.as_deref(), Some("msg_done"));
938
- let (status, _notified_id) = watcher_state(&store, &failed);
939
- assert_eq!(
940
- status, "notify_failed",
941
- "non-exhausted watcher is not selected"
942
- );
943
-
944
- // R8 (golden leader/__init__.py:46-50): result_watcher.requeued is the ATTACH form
945
- // {watcher_id, trigger:"attach_leader", new_pane_id} — NOT the claim-style {prior_state,claimed_pane_id,team_id}.
946
- let events = log.tail(0).unwrap();
947
- let ev = events
948
- .iter()
949
- .rev()
950
- .find(|event| {
951
- event.get("event").and_then(|v| v.as_str()) == Some("result_watcher.requeued")
952
- })
953
- .expect("result_watcher.requeued event");
954
- let keys: std::collections::BTreeSet<&str> = ev
955
- .as_object()
956
- .unwrap()
957
- .keys()
958
- .map(String::as_str)
959
- .filter(|k| *k != "ts" && *k != "event")
960
- .collect();
961
- let expected: std::collections::BTreeSet<&str> = ["watcher_id", "trigger", "new_pane_id"]
962
- .into_iter()
963
- .collect();
964
- assert_eq!(
965
- keys, expected,
966
- "result_watcher.requeued must be golden attach form {{watcher_id, trigger, new_pane_id}}"
967
- );
968
- assert_eq!(
969
- ev.get("watcher_id").and_then(|v| v.as_str()),
970
- Some("w-exhausted")
971
- );
972
- assert_eq!(
973
- ev.get("trigger").and_then(|v| v.as_str()),
974
- Some("attach_leader")
975
- );
976
- assert_eq!(
977
- ev.get("new_pane_id").and_then(|v| v.as_str()),
978
- Some("%leader")
979
- );
980
- }
981
-
982
- // ════════════════════════════════════════════════════════════════════════
983
- // GROUP Q — collect intake (results.py:45-167): valid result advances task,
984
- // returns collected_results + delivered_messages + results counts shape.
985
- // ════════════════════════════════════════════════════════════════════════
986
-
987
- #[test]
988
- fn collect_without_spec_surfaces_validation_error() {
989
- // results.py:46-48 — collect() reads spec_path then load_spec(); against a
990
- // workspace with NO team.spec.yaml, load_spec RAISES ValidationError
991
- // ("Cannot read <path>: ...", spec.py:18-20) BEFORE any collection. The
992
- // previous `.unwrap()` (expecting an Ok dict with present-only keys) was wrong:
993
- // the real Python collect on a bare workspace does not return a dict, it raises.
994
- // At the typed boundary that surfaces as MessagingError::Validation.
995
- //
996
- // The full collected_results-count golden (seed an uncollected result, assert it
997
- // collects and the task advances) is DEFERRED: it requires a valid on-disk
998
- // team.spec.yaml + runtime state, whose formats are owned by the spec/state lanes
999
- // (this file may not edit them). seed_result() exists for the retry path that
1000
- // does NOT need a spec; the collect happy-path needs an integration fixture.
1001
- let ws = tmp_ws("collect");
1002
- let err = collect(&ws, None, false).unwrap_err();
1003
- assert!(
1004
- matches!(err, MessagingError::Validation(_)),
1005
- "collect without a team spec must surface Validation, got {err:?}"
1006
- );
1007
- }
1008
-
1009
- #[test]
1010
- fn collect_accepts_message_scoped_result_for_matching_recipient() {
1011
- let ws = tmp_ws("collectmsgok");
1012
- std::fs::write(ws.join("team.spec.yaml"), "version: 1\n").unwrap();
1013
- let store = store_for(&ws);
1014
- let message_id = store
1015
- .create_message(None, "leader", "w1", "please reply", None, false, None)
1016
- .unwrap();
1017
- seed_result(&store, "res_msg_ok", &message_id, "w1", "success");
1018
-
1019
- let out = collect(&ws, None, false).unwrap();
1020
- assert_eq!(out.get("ok").and_then(|v| v.as_bool()), Some(true));
1021
- let collected = out
1022
- .get("collected_results")
1023
- .and_then(|v| v.as_array())
1024
- .expect("collected_results");
1025
- assert_eq!(collected.len(), 1);
1026
- assert_eq!(
1027
- collected[0].get("task_id").and_then(|v| v.as_str()),
1028
- Some(message_id.as_str())
1029
- );
1030
- assert_eq!(
1031
- collected[0].get("agent_id").and_then(|v| v.as_str()),
1032
- Some("w1")
1033
- );
1034
- assert_eq!(
1035
- collected[0].get("scope").and_then(|v| v.as_str()),
1036
- Some("message")
1037
- );
1038
- // D3 (leader-adjudicated): golden collected_results entry is EXACTLY the 8-key summary for BOTH
1039
- // scopes; golden's task_status feeds only the `collect.result` EVENT, never the entry. So a
1040
- // message-scope entry carries NO task_status key (the prior `Some("message_scoped")` lock encoded a
1041
- // port divergence — dropped per ruling).
1042
- assert!(
1043
- collected[0].get("task_status").is_none(),
1044
- "collected_results entry must NOT carry task_status (golden 8-key summary; event-only); got {:?}",
1045
- collected[0]
1046
- );
1047
- let keys: Vec<&str> = collected[0]
1048
- .as_object()
1049
- .expect("entry is an object")
1050
- .keys()
1051
- .map(String::as_str)
1052
- .collect();
1053
- assert_eq!(
1054
- keys,
1055
- vec!["result_id", "task_id", "agent_id", "status", "summary", "tests", "created_at", "scope"],
1056
- "message-scope collected_results entry must be EXACTLY the golden 8 keys in order; got {keys:?}"
1057
- );
1058
- }
1059
-
1060
- #[test]
1061
- fn collect_rejects_message_scoped_result_without_matching_recipient() {
1062
- let ws = tmp_ws("collectmsgbad");
1063
- std::fs::write(ws.join("team.spec.yaml"), "version: 1\n").unwrap();
1064
- let store = store_for(&ws);
1065
- let message_id = store
1066
- .create_message(None, "leader", "w1", "please reply", None, false, None)
1067
- .unwrap();
1068
- seed_result(&store, "res_msg_bad", &message_id, "w2", "success");
1069
-
1070
- let out = collect(&ws, None, false).unwrap();
1071
- assert_eq!(out.get("ok").and_then(|v| v.as_bool()), Some(false));
1072
- assert!(
1073
- out.get("collected_results")
1074
- .and_then(|v| v.as_array())
1075
- .is_some_and(Vec::is_empty),
1076
- "recipient mismatch must not collect as message-scoped"
1077
- );
1078
- let invalid = out
1079
- .get("invalid_results")
1080
- .and_then(|v| v.as_array())
1081
- .expect("invalid_results");
1082
- assert_eq!(invalid.len(), 1);
1083
- assert_eq!(
1084
- invalid[0].get("task_id").and_then(|v| v.as_str()),
1085
- Some(message_id.as_str())
1086
- );
1087
- assert_eq!(
1088
- invalid[0].get("error").and_then(|v| v.as_str()),
1089
- Some(format!("unknown task id: {message_id}").as_str())
1090
- );
1091
- }
1092
-
1093
- // ════════════════════════════════════════════════════════════════════════
1094
- // GROUP R — run_comms_selftest: §84 / MUST-NOT-13 zero-provider-SDK gate.
1095
- // diagnose/comms.py:21-47. The whole point: assert zero provider client calls.
1096
- // ════════════════════════════════════════════════════════════════════════
1097
-
1098
- #[test]
1099
- fn run_comms_selftest_zero_provider_sdk_passes_and_locks_scope() {
1100
- let ws = tmp_ws("selftestok");
1101
- let driver = ZeroSdkDriver {
1102
- run_id: Some("fixedrunid01".to_string()),
1103
- calls: ProviderSdkCalls::default(),
1104
- };
1105
- let report = run_comms_selftest(&ws, None, &driver).unwrap();
1106
- // diagnose/comms.py:44 scope == "binding_consistency".
1107
- assert_eq!(report.scope, "binding_consistency");
1108
- assert_eq!(report.run_id, "fixedrunid01");
1109
- // The mechanical gate: provider_sdk_calls check is a Pass with all-zero evidence.
1110
- assert_eq!(report.provider_sdk_calls.status, CheckStatus::Pass);
1111
- match &report.provider_sdk_calls.evidence {
1112
- CheckEvidence::ProviderSdkCalls(calls) => assert!(calls.is_zero()),
1113
- other => panic!("expected ProviderSdkCalls evidence, got {other:?}"),
1114
- }
1115
- assert!(report.ok);
1116
- }
1117
-
1118
- #[test]
1119
- fn run_comms_selftest_nonzero_provider_sdk_fails_gate() {
1120
- // Any non-zero SDK call count → provider_sdk_calls check FAILS, report not ok.
1121
- let ws = tmp_ws("selftestbad");
1122
- let driver = ZeroSdkDriver {
1123
- run_id: Some("r2".to_string()),
1124
- calls: ProviderSdkCalls {
1125
- anthropic: 1,
1126
- openai: 0,
1127
- httpx: 0,
1128
- },
1129
- };
1130
- let report = run_comms_selftest(&ws, None, &driver).unwrap();
1131
- assert_eq!(report.provider_sdk_calls.status, CheckStatus::Fail);
1132
- assert!(!report.ok);
1133
- }
1134
-
1135
- #[test]
1136
- fn run_comms_selftest_contract_suite_is_executable_zero_token() {
1137
- let ws = tmp_ws("selftestdefer");
1138
- let driver = ZeroSdkDriver {
1139
- run_id: Some("r3".to_string()),
1140
- calls: ProviderSdkCalls::default(),
1141
- };
1142
- let report = run_comms_selftest(&ws, None, &driver).unwrap();
1143
- assert_eq!(report.contract_suite.status, CheckStatus::Pass);
1144
- match &report.contract_suite.evidence {
1145
- CheckEvidence::ContractSuite { checks } => {
1146
- assert!(
1147
- checks.iter().all(|check| check.status == CheckStatus::Pass),
1148
- "contract suite subchecks must all pass: {checks:?}"
1149
- );
1150
- let names: Vec<&str> = checks.iter().map(|check| check.name.as_str()).collect();
1151
- assert!(
1152
- names.contains(&"message_store_schema")
1153
- && names.contains(&"message_token_shape")
1154
- && names.contains(&"result_notification_render")
1155
- && names.contains(&"leader_projection_owner_team"),
1156
- "contract suite must cover schema, token, result notification, and leader projection: {names:?}"
1157
- );
1158
- }
1159
- other => panic!("expected ContractSuite evidence, got {other:?}"),
1160
- }
1161
- }
1162
-
1163
- // ════════════════════════════════════════════════════════════════════════
1164
- // GROUP S — evaluate_idle_behavior: claimed_status normalization
1165
- // (IDLE/WORKING/RUNNING → not_challenged). diagnose/comms.py:50-94.
1166
- // ════════════════════════════════════════════════════════════════════════
1167
-
1168
- #[test]
1169
- fn evaluate_idle_behavior_recognized_status_is_not_challenged() {
1170
- // diagnose/comms.py:86-94 — claimed_status in {IDLE,WORKING,RUNNING} (case-
1171
- // insensitive) and no driver result → status not_challenged, ok True.
1172
- let ws = tmp_ws("idleeval");
1173
- let driver = ZeroSdkDriver {
1174
- run_id: None,
1175
- calls: ProviderSdkCalls::default(),
1176
- };
1177
- let out = evaluate_idle_behavior(&ws, "w1", "IDLE", None, &driver).unwrap();
1178
- assert_eq!(out.status, CheckStatus::NotChallenged);
1179
- assert!(out.ok);
1180
- assert_eq!(out.agent_id, "w1");
1181
- }
1182
-
1183
- // ════════════════════════════════════════════════════════════════════════
1184
- // GROUP T — deliver_pending_message claim atomicity + status machine.
1185
- // delivery.py:63-218. missing message / unknown recipient / already-claimed.
1186
- // ════════════════════════════════════════════════════════════════════════
1187
-
1188
- #[test]
1189
- fn deliver_pending_message_missing_message_fails() {
1190
- // delivery.py:73-75 — no such message row → ok False, status failed,
1191
- // reason message_missing.
1192
- let ws = tmp_ws("delivermissing");
1193
- let store = store_for(&ws);
1194
- let log = EventLog::new(&ws);
1195
- let t = NoopTransport;
1196
- let out =
1197
- deliver_pending_message(&ws, &store, &t, "nope", &log, &serde_json::json!({})).unwrap();
1198
- assert!(!out.ok);
1199
- assert_eq!(out.status, DeliveryStatus::Failed);
1200
- }
1201
-
1202
- // ════════════════════════════════════════════════════════════════════════
1203
- // GROUP U — fire_due_scheduled_events: exhaustive ScheduledKind dispatch +
1204
- // send dedupe. scheduler.py:41-121. Returns fired event-id list.
1205
- // ════════════════════════════════════════════════════════════════════════
1206
-
1207
- #[test]
1208
- fn fire_due_scheduled_events_fires_each_scheduled_kind() {
1209
- // SEEDED exhaustive-dispatch contract (scheduler.py:41-121): seed one due row
1210
- // of EACH ScheduledKind (send / health_ping / trust_retry). The dispatch loop
1211
- // must fire all three (one match arm per kind, no runtime fallback) and return
1212
- // each fired event id. Probed golden: a due health_ping fires → marked 'done'
1213
- // with {"ok":true,"status":"logged"} and its id appears in the fired list;
1214
- // every due row's id is appended regardless of kind (scheduler.py:118).
1215
- let ws = tmp_ws("scheduler");
1216
- let store = store_for(&ws);
1217
- let log = EventLog::new(&ws);
1218
- let t = NoopTransport;
1219
-
1220
- let send_id = seed_scheduled_event(
1221
- &store,
1222
- ScheduledKind::Send,
1223
- "%w1",
1224
- &serde_json::json!({"content": "ping", "attempt": 1, "max_attempts": 1}),
1225
- );
1226
- let ping_id = seed_scheduled_event(
1227
- &store,
1228
- ScheduledKind::HealthPing,
1229
- "%w1",
1230
- &serde_json::json!({}),
1231
- );
1232
- let trust_id = seed_scheduled_event(
1233
- &store,
1234
- ScheduledKind::TrustRetry,
1235
- "%w1",
1236
- &serde_json::json!({"message_id": "m1", "attempt": 1, "max_attempts": 4}),
1237
- );
1238
-
1239
- let fired = fire_due_scheduled_events(&ws, &store, &t, &log).unwrap();
1240
-
1241
- // Every seeded due kind must be dispatched and its id returned (exhaustive,
1242
- // no kind silently dropped via a fallthrough).
1243
- for id in [send_id, ping_id, trust_id] {
1244
- assert!(
1245
- fired.contains(&id),
1246
- "scheduled event id {id} (each ScheduledKind) must fire; got {fired:?}"
1247
- );
1248
- }
1249
- assert_eq!(
1250
- fired.len(),
1251
- 3,
1252
- "exactly the three seeded due events fire, no extras"
1253
- );
1254
- }
1255
-
1256
- struct UnverifiedInjectTransport {
1257
- readback_visible: bool,
1258
- /// #379: the recipient's transcript, written at submit like a native CLI.
1259
- receipt: Option<PathBuf>,
1260
- }
1261
- impl Transport for UnverifiedInjectTransport {
1262
- fn kind(&self) -> BackendKind {
1263
- BackendKind::Tmux
1264
- }
1265
- fn spawn_first(
1266
- &self,
1267
- _s: &SessionName,
1268
- _w: &WindowName,
1269
- _a: &[String],
1270
- _c: &Path,
1271
- _e: &BTreeMap<String, String>,
1272
- ) -> Result<SpawnResult, TransportError> {
1273
- unimplemented!("not reached in delivery")
1274
- }
1275
- fn spawn_into(
1276
- &self,
1277
- _s: &SessionName,
1278
- _w: &WindowName,
1279
- _a: &[String],
1280
- _c: &Path,
1281
- _e: &BTreeMap<String, String>,
1282
- ) -> Result<SpawnResult, TransportError> {
1283
- unimplemented!("not reached in delivery")
1284
- }
1285
- fn inject(
1286
- &self,
1287
- _t: &Target,
1288
- p: &InjectPayload,
1289
- _s: Key,
1290
- _b: bool,
1291
- ) -> Result<InjectReport, TransportError> {
1292
- if let (Some(path), Some(text)) = (&self.receipt, p.text()) {
1293
- let row = serde_json::json!({"type": "queue-operation", "operation": "enqueue", "content": text});
1294
- std::fs::write(path, format!("{row}\n")).unwrap();
1295
- }
1296
- Ok(InjectReport {
1297
- stage_reached: crate::transport::InjectStage::Submit,
1298
- inject_verification: if self.readback_visible {
1299
- crate::transport::InjectVerification::CaptureContainsToken
1300
- } else {
1301
- crate::transport::InjectVerification::CaptureMissingToken
1302
- },
1303
- submit_verification:
1304
- crate::transport::SubmitVerification::PastedContentPromptStillPresentAfterSubmit,
1305
- turn_verification: crate::transport::TurnVerification::NotYetObserved,
1306
- attempts: u32::from(SEND_RETRY_MAX_ATTEMPTS),
1307
- submit_diagnostics: None,
1308
- })
1309
- }
1310
- fn send_keys(&self, _t: &Target, _k: &[Key]) -> Result<(), TransportError> {
1311
- Ok(())
1312
- }
1313
- fn capture(&self, _t: &Target, range: CaptureRange) -> Result<CapturedText, TransportError> {
1314
- Ok(CapturedText {
1315
- text: String::new(),
1316
- range,
1317
- })
1318
- }
1319
- fn query(&self, _t: &Target, _f: PaneField) -> Result<Option<String>, TransportError> {
1320
- Ok(None)
1321
- }
1322
- fn liveness(&self, _p: &PaneId) -> Result<PaneLiveness, TransportError> {
1323
- Ok(PaneLiveness::Unknown)
1324
- }
1325
- fn list_targets(&self) -> Result<Vec<PaneInfo>, TransportError> {
1326
- Ok(Vec::new())
1327
- }
1328
- fn has_session(&self, _s: &SessionName) -> Result<bool, TransportError> {
1329
- Ok(true)
1330
- }
1331
- fn list_windows(&self, _s: &SessionName) -> Result<Vec<WindowName>, TransportError> {
1332
- Ok(Vec::new())
1333
- }
1334
- fn set_session_env(
1335
- &self,
1336
- _s: &SessionName,
1337
- _k: &str,
1338
- _v: &str,
1339
- ) -> Result<SetEnvOutcome, TransportError> {
1340
- Ok(SetEnvOutcome::Applied)
1341
- }
1342
- fn kill_session(&self, _s: &SessionName) -> Result<(), TransportError> {
1343
- Ok(())
1344
- }
1345
- fn kill_window(&self, _t: &Target) -> Result<(), TransportError> {
1346
- Ok(())
1347
- }
1348
- fn attach_session(&self, _s: &SessionName) -> Result<AttachOutcome, TransportError> {
1349
- Ok(AttachOutcome::Attached)
1350
- }
1351
- }
1352
-
1353
- struct FailingInjectTransport {
1354
- attempts: std::sync::Arc<std::sync::atomic::AtomicUsize>,
1355
- }
1356
-
1357
- impl Transport for FailingInjectTransport {
1358
- fn kind(&self) -> BackendKind {
1359
- BackendKind::Tmux
1360
- }
1361
- fn spawn_first(
1362
- &self,
1363
- _s: &SessionName,
1364
- _w: &WindowName,
1365
- _a: &[String],
1366
- _c: &Path,
1367
- _e: &BTreeMap<String, String>,
1368
- ) -> Result<SpawnResult, TransportError> {
1369
- unimplemented!("not reached in delivery")
1370
- }
1371
- fn spawn_into(
1372
- &self,
1373
- _s: &SessionName,
1374
- _w: &WindowName,
1375
- _a: &[String],
1376
- _c: &Path,
1377
- _e: &BTreeMap<String, String>,
1378
- ) -> Result<SpawnResult, TransportError> {
1379
- unimplemented!("not reached in delivery")
1380
- }
1381
- fn inject(
1382
- &self,
1383
- t: &Target,
1384
- _p: &InjectPayload,
1385
- _s: Key,
1386
- _b: bool,
1387
- ) -> Result<InjectReport, TransportError> {
1388
- if matches!(t, Target::Pane(pane) if pane.as_str() == "%1") {
1389
- self.attempts
1390
- .fetch_add(1, std::sync::atomic::Ordering::Relaxed);
1391
- }
1392
- Err(TransportError::Inject {
1393
- stage: crate::transport::InjectStage::PasteBuffer,
1394
- source: std::io::Error::other("paste-buffer failed"),
1395
- })
1396
- }
1397
- fn send_keys(&self, _t: &Target, _k: &[Key]) -> Result<(), TransportError> {
1398
- Ok(())
1399
- }
1400
- fn capture(&self, _t: &Target, range: CaptureRange) -> Result<CapturedText, TransportError> {
1401
- Ok(CapturedText {
1402
- text: String::new(),
1403
- range,
1404
- })
1405
- }
1406
- fn query(&self, _t: &Target, _f: PaneField) -> Result<Option<String>, TransportError> {
1407
- Ok(None)
1408
- }
1409
- fn liveness(&self, _p: &PaneId) -> Result<PaneLiveness, TransportError> {
1410
- Ok(PaneLiveness::Unknown)
1411
- }
1412
- fn list_targets(&self) -> Result<Vec<PaneInfo>, TransportError> {
1413
- Ok(Vec::new())
1414
- }
1415
- fn has_session(&self, _s: &SessionName) -> Result<bool, TransportError> {
1416
- Ok(true)
1417
- }
1418
- fn list_windows(&self, _s: &SessionName) -> Result<Vec<WindowName>, TransportError> {
1419
- Ok(Vec::new())
1420
- }
1421
- fn set_session_env(
1422
- &self,
1423
- _s: &SessionName,
1424
- _k: &str,
1425
- _v: &str,
1426
- ) -> Result<SetEnvOutcome, TransportError> {
1427
- Ok(SetEnvOutcome::Applied)
1428
- }
1429
- fn kill_session(&self, _s: &SessionName) -> Result<(), TransportError> {
1430
- Ok(())
1431
- }
1432
- fn kill_window(&self, _t: &Target) -> Result<(), TransportError> {
1433
- Ok(())
1434
- }
1435
- fn attach_session(&self, _s: &SessionName) -> Result<AttachOutcome, TransportError> {
1436
- Ok(AttachOutcome::Attached)
1437
- }
1438
- }
1439
-
1440
- // 0.3.30: submit evidence supersedes stale readback. This transport returns a
1441
- // verified submit but a missing-token readback.
1442
- struct ReadbackMissingTransport;
1443
- impl Transport for ReadbackMissingTransport {
1444
- fn kind(&self) -> BackendKind {
1445
- BackendKind::Tmux
1446
- }
1447
- fn spawn_first(
1448
- &self,
1449
- _: &SessionName,
1450
- _: &WindowName,
1451
- _: &[String],
1452
- _: &Path,
1453
- _: &BTreeMap<String, String>,
1454
- ) -> Result<SpawnResult, TransportError> {
1455
- unimplemented!("not reached in delivery")
1456
- }
1457
- fn spawn_into(
1458
- &self,
1459
- _: &SessionName,
1460
- _: &WindowName,
1461
- _: &[String],
1462
- _: &Path,
1463
- _: &BTreeMap<String, String>,
1464
- ) -> Result<SpawnResult, TransportError> {
1465
- unimplemented!("not reached in delivery")
1466
- }
1467
- fn inject(
1468
- &self,
1469
- _: &Target,
1470
- _: &InjectPayload,
1471
- _: Key,
1472
- _: bool,
1473
- ) -> Result<InjectReport, TransportError> {
1474
- Ok(InjectReport {
1475
- stage_reached: crate::transport::InjectStage::Submit,
1476
- // submit verified, but the token never appeared in the pane → readback missing.
1477
- inject_verification: crate::transport::InjectVerification::CaptureMissingToken,
1478
- submit_verification: crate::transport::SubmitVerification::KeySentAfterVisibleToken {
1479
- key: Key::Enter,
1480
- },
1481
- turn_verification: crate::transport::TurnVerification::NotYetObserved,
1482
- attempts: 1,
1483
- submit_diagnostics: None,
1484
- })
1485
- }
1486
- fn send_keys(&self, _: &Target, _: &[Key]) -> Result<(), TransportError> {
1487
- Ok(())
1488
- }
1489
- fn capture(&self, _: &Target, range: CaptureRange) -> Result<CapturedText, TransportError> {
1490
- Ok(CapturedText {
1491
- text: String::new(),
1492
- range,
1493
- })
1494
- }
1495
- fn query(&self, _: &Target, _: PaneField) -> Result<Option<String>, TransportError> {
1496
- Ok(None)
1497
- }
1498
- fn liveness(&self, _: &PaneId) -> Result<PaneLiveness, TransportError> {
1499
- Ok(PaneLiveness::Unknown)
1500
- }
1501
- fn list_targets(&self) -> Result<Vec<PaneInfo>, TransportError> {
1502
- Ok(Vec::new())
1503
- }
1504
- fn has_session(&self, _: &SessionName) -> Result<bool, TransportError> {
1505
- Ok(true)
1506
- }
1507
- fn list_windows(&self, _: &SessionName) -> Result<Vec<WindowName>, TransportError> {
1508
- Ok(Vec::new())
1509
- }
1510
- fn set_session_env(
1511
- &self,
1512
- _: &SessionName,
1513
- _: &str,
1514
- _: &str,
1515
- ) -> Result<SetEnvOutcome, TransportError> {
1516
- Ok(SetEnvOutcome::Applied)
1517
- }
1518
- fn kill_session(&self, _: &SessionName) -> Result<(), TransportError> {
1519
- Ok(())
1520
- }
1521
- fn kill_window(&self, _: &Target) -> Result<(), TransportError> {
1522
- Ok(())
1523
- }
1524
- fn attach_session(&self, _: &SessionName) -> Result<AttachOutcome, TransportError> {
1525
- Ok(AttachOutcome::Attached)
1526
- }
1527
- }
1528
-
1529
- #[test]
1530
- fn deliver_pending_submit_verified_overrides_missing_readback() {
1531
- let ws = tmp_ws("readbackmiss");
1532
- let store = store_for(&ws);
1533
- let log = EventLog::new(&ws);
1534
- let state = serde_json::json!({
1535
- "session_name": "team-readbackmiss",
1536
- "leader_receiver": {"pane_id": "%leader"},
1537
- "agents": {"w1": {"provider": "fake", "pane_id": "%1"}}
1538
- });
1539
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1540
- let message_id = store
1541
- .create_message(None, "leader", "w1", "ping", None, false, None)
1542
- .unwrap();
1543
-
1544
- let out = deliver_pending_message(
1545
- &ws,
1546
- &store,
1547
- &ReadbackMissingTransport,
1548
- &message_id,
1549
- &log,
1550
- &state,
1551
- )
1552
- .unwrap();
1553
-
1554
- assert!(
1555
- out.ok,
1556
- "0.3.30: submit-verified delivery must not be vetoed by stale CaptureMissingToken readback"
1557
- );
1558
- assert_eq!(
1559
- out.message_status.0, "delivered",
1560
- "0.3.30: submit evidence is stronger than readback"
1561
- );
1562
- }
1563
-
1564
- #[test]
1565
- fn deliver_pending_submit_unverified_is_not_saved_by_readback() {
1566
- let ws = tmp_ws("readbacksaves");
1567
- let store = store_for(&ws);
1568
- let log = EventLog::new(&ws);
1569
- let state = serde_json::json!({
1570
- "session_name": "team-readbacksaves",
1571
- "leader_receiver": {"pane_id": "%leader"},
1572
- "agents": {"w1": {"provider": "fake", "pane_id": "%1"}}
1573
- });
1574
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1575
- let message_id = store
1576
- .create_message(None, "leader", "w1", "ping", None, false, None)
1577
- .unwrap();
1578
-
1579
- let out = deliver_pending_message(
1580
- &ws,
1581
- &store,
1582
- &UnverifiedInjectTransport {
1583
- readback_visible: true,
1584
- receipt: None,
1585
- },
1586
- &message_id,
1587
- &log,
1588
- &state,
1589
- )
1590
- .unwrap();
1591
-
1592
- assert!(
1593
- !out.ok,
1594
- "0.3.30: positive readback alone must not mark delivered when submit is unverified"
1595
- );
1596
- assert_ne!(out.message_status.0, "delivered");
1597
- let updated = crate::state::persist::load_runtime_state(&ws).unwrap();
1598
- assert_eq!(
1599
- updated.pointer("/coordinator/turn_open/turn_id"),
1600
- Some(&serde_json::json!(message_id)),
1601
- "current-turn fact is armed immediately after physical inject succeeds"
1602
- );
1603
- // Phase-DX E2 rename: the leader→worker turn message id lives under
1604
- // `current_turn_message_id` (the previous name misleadingly implied a task
1605
- // FSM id — that is A1 territory). Same value written by
1606
- // `delivery::arm_turn_open`; the invariant of arming-without-delivered is
1607
- // unchanged.
1608
- assert_eq!(
1609
- updated.pointer("/agents/w1/current_turn_message_id"),
1610
- Some(&serde_json::json!(message_id)),
1611
- "agent current-turn message id is armed without marking the message delivered"
1612
- );
1613
- }
1614
-
1615
- #[test]
1616
- fn deliver_pending_exhausted_unverified_send_emits_failed_event() {
1617
- let ws = tmp_ws("sendfailed");
1618
- let store = store_for(&ws);
1619
- let log = EventLog::new(&ws);
1620
- let state = serde_json::json!({
1621
- "session_name": "team-sendfailed",
1622
- "leader_receiver": {"pane_id": "%leader"},
1623
- "agents": {"w1": {"provider": "fake", "pane_id": "%1"}}
1624
- });
1625
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1626
- let message_id = store
1627
- .create_message(None, "leader", "w1", "ping", None, false, None)
1628
- .unwrap();
1629
- // #379: exhaustion is the outer delivery budget; this is its last attempt.
1630
- crate::db::schema::open_db(store.db_path())
1631
- .unwrap()
1632
- .execute(
1633
- "update messages set delivery_attempts = ?2 where message_id = ?1",
1634
- rusqlite::params![message_id, i64::from(SEND_RETRY_MAX_ATTEMPTS) - 1],
1635
- )
1636
- .unwrap();
1637
-
1638
- let out = deliver_pending_message(
1639
- &ws,
1640
- &store,
1641
- &UnverifiedInjectTransport {
1642
- readback_visible: false,
1643
- receipt: None,
1644
- },
1645
- &message_id,
1646
- &log,
1647
- &state,
1648
- )
1649
- .unwrap();
1650
-
1651
- assert!(!out.ok);
1652
- assert_eq!(out.message_status.0, "failed");
1653
- let events = log.tail(0).unwrap();
1654
- assert!(
1655
- events.iter().any(|event| {
1656
- event.get("event").and_then(serde_json::Value::as_str) == Some("send.failed")
1657
- && event.get("attempts") == Some(&serde_json::json!(SEND_RETRY_MAX_ATTEMPTS))
1658
- }),
1659
- "exhausted unverified send must emit send.failed; got {events:?}"
1660
- );
1661
- assert!(
1662
- events.iter().any(
1663
- |event| event.get("event").and_then(serde_json::Value::as_str)
1664
- == Some("send.failed_notification")
1665
- ),
1666
- "exhausted unverified send must queue a leader-visible notification; got {events:?}"
1667
- );
1668
- }
1669
-
1670
- #[test]
1671
- fn issue379_inner_enter_presses_do_not_spend_the_delivery_budget() {
1672
- let ws = tmp_ws("innerenters");
1673
- let store = store_for(&ws);
1674
- let log = EventLog::new(&ws);
1675
- let state = serde_json::json!({
1676
- "session_name": "team-innerenters",
1677
- "leader_receiver": {"pane_id": "%leader"},
1678
- "agents": {"w1": {"provider": "fake", "pane_id": "%1"}}
1679
- });
1680
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1681
- let message_id = store
1682
- .create_message(None, "leader", "w1", "ping", None, false, None)
1683
- .unwrap();
1684
-
1685
- // One delivery whose verifier pressed Enter SEND_RETRY_MAX_ATTEMPTS times.
1686
- let out = deliver_pending_message(
1687
- &ws,
1688
- &store,
1689
- &UnverifiedInjectTransport {
1690
- readback_visible: false,
1691
- receipt: None,
1692
- },
1693
- &message_id,
1694
- &log,
1695
- &state,
1696
- )
1697
- .unwrap();
1698
-
1699
- assert_eq!(out.message_status.0, "submitted_unverified", "{out:?}");
1700
- let events = log.tail(0).unwrap();
1701
- let event = |name: &str| {
1702
- events
1703
- .iter()
1704
- .find(|event| event.get("event").and_then(serde_json::Value::as_str) == Some(name))
1705
- };
1706
- assert!(event("send.failed").is_none(), "first attempt is not exhausted; got {events:?}");
1707
- let unverified = event("send.unverified").expect("send.unverified");
1708
- assert_eq!(unverified.get("attempts"), Some(&serde_json::json!(SEND_RETRY_MAX_ATTEMPTS)));
1709
- assert_eq!(unverified.get("delivery_attempt"), Some(&serde_json::json!(1)));
1710
- }
1711
-
1712
- #[test]
1713
- fn issue379_recipient_transcript_receipt_upgrades_an_unread_pane_to_delivered() {
1714
- let ws = tmp_ws("transcriptreceipt");
1715
- let store = store_for(&ws);
1716
- let log = EventLog::new(&ws);
1717
- let rollout = ws.join("w1-transcript.jsonl");
1718
- let state = serde_json::json!({
1719
- "session_name": "team-transcriptreceipt",
1720
- "leader_receiver": {"pane_id": "%leader"},
1721
- "agents": {"w1": {"provider": "fake", "pane_id": "%1", "rollout_path": rollout}}
1722
- });
1723
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1724
- let message_id = store
1725
- .create_message(None, "leader", "w1", "ping", None, false, None)
1726
- .unwrap();
1727
- crate::db::schema::open_db(store.db_path())
1728
- .unwrap()
1729
- .execute(
1730
- "update messages set delivery_attempts = ?2 where message_id = ?1",
1731
- rusqlite::params![message_id, i64::from(SEND_RETRY_MAX_ATTEMPTS) - 1],
1732
- )
1733
- .unwrap();
1734
-
1735
- let out = deliver_pending_message(
1736
- &ws,
1737
- &store,
1738
- &UnverifiedInjectTransport {
1739
- readback_visible: false,
1740
- receipt: Some(rollout),
1741
- },
1742
- &message_id,
1743
- &log,
1744
- &state,
1745
- )
1746
- .unwrap();
1747
-
1748
- assert!(out.ok, "{out:?}");
1749
- assert_eq!(out.message_status.0, "delivered");
1750
- let events = log.tail(0).unwrap();
1751
- let names: Vec<_> = events
1752
- .iter()
1753
- .filter_map(|event| event.get("event").and_then(serde_json::Value::as_str))
1754
- .collect();
1755
- assert!(names.contains(&"send.unverified_reconciled"), "{names:?}");
1756
- assert!(!names.contains(&"send.unverified") && !names.contains(&"send.failed"), "{names:?}");
1757
- }
1758
-
1759
- #[test]
1760
- fn slice1_inject_failures_are_bounded_and_stop_retrying_same_message() {
1761
- let ws = tmp_ws("injectstorm");
1762
- let store = store_for(&ws);
1763
- let log = EventLog::new(&ws);
1764
- let state = serde_json::json!({
1765
- "session_name": "team-injectstorm",
1766
- "leader_receiver": {"pane_id": "%leader"},
1767
- "agents": {"w1": {"provider": "fake", "pane_id": "%1"}}
1768
- });
1769
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1770
- let message_id = store
1771
- .create_message(None, "leader", "w1", "ping", None, false, None)
1772
- .unwrap();
1773
- let attempts = std::sync::Arc::new(std::sync::atomic::AtomicUsize::new(0));
1774
- let transport = FailingInjectTransport {
1775
- attempts: std::sync::Arc::clone(&attempts),
1776
- };
1777
-
1778
- for _ in 0..(usize::from(SEND_RETRY_MAX_ATTEMPTS) + 2) {
1779
- let _ = deliver_pending_messages(&ws, &state, &transport, &log).unwrap();
1780
- }
1781
-
1782
- assert_eq!(
1783
- attempts.load(std::sync::atomic::Ordering::Relaxed),
1784
- usize::from(SEND_RETRY_MAX_ATTEMPTS),
1785
- "same message/target must stop retrying after the bounded inject-failure threshold"
1786
- );
1787
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
1788
- let (status, delivery_attempts, error): (String, i64, Option<String>) = conn
1789
- .query_row(
1790
- "select status, delivery_attempts, error from messages where message_id = ?1",
1791
- [&message_id],
1792
- |row| Ok((row.get(0)?, row.get(1)?, row.get(2)?)),
1793
- )
1794
- .unwrap();
1795
- assert_eq!(status, "failed");
1796
- assert_eq!(delivery_attempts, i64::from(SEND_RETRY_MAX_ATTEMPTS));
1797
- assert_eq!(error.as_deref(), Some("send_inject_exhausted"));
1798
- let events = log.tail(0).unwrap();
1799
- let inject_failures = events
1800
- .iter()
1801
- .filter(|event| {
1802
- event.get("event").and_then(serde_json::Value::as_str) == Some("send.inject_failed")
1803
- })
1804
- .count();
1805
- assert_eq!(
1806
- inject_failures,
1807
- usize::from(SEND_RETRY_MAX_ATTEMPTS),
1808
- "failed physical injects should be audited only until the bounded threshold; events={events:?}"
1809
- );
1810
- assert!(
1811
- events.iter().any(|event| {
1812
- event.get("event").and_then(serde_json::Value::as_str) == Some("send.failed")
1813
- && event.get("reason").and_then(serde_json::Value::as_str)
1814
- == Some("send_inject_exhausted")
1815
- }),
1816
- "terminal inject exhaustion must emit send.failed; events={events:?}"
1817
- );
1818
- }
1819
-
1820
- #[test]
1821
- fn target_missing_session_window_blocks_without_generic_inject_exhaustion() {
1822
- let ws = tmp_ws("targetmissing");
1823
- let store = store_for(&ws);
1824
- let log = EventLog::new(&ws);
1825
- let state = serde_json::json!({
1826
- "session_name": "team-targetmissing",
1827
- "leader_receiver": {"pane_id": "%leader"},
1828
- "agents": {"w1": {"provider": "fake", "window": "w1"}}
1829
- });
1830
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1831
- let message_id = store
1832
- .create_message(None, "leader", "w1", "ping", None, false, None)
1833
- .unwrap();
1834
- let transport = OfflineTransport::new()
1835
- .with_session_present(true)
1836
- .with_targets(vec![pane_info("%2", "team-targetmissing", "other")]);
1837
-
1838
- let out = deliver_pending_message(&ws, &store, &transport, &message_id, &log, &state)
1839
- .expect("target-missing classification should be a delivery outcome");
1840
-
1841
- assert!(!out.ok);
1842
- assert_eq!(out.status, DeliveryStatus::Blocked);
1843
- assert_eq!(out.message_status.0, "queued_pane_missing");
1844
- assert_eq!(out.reason, Some(DeliveryRefusal::TmuxTargetMissing));
1845
- assert!(
1846
- transport.inject_targets().is_empty(),
1847
- "target-missing must block before physical inject; targets={:?}",
1848
- transport.inject_targets()
1849
- );
1850
-
1851
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
1852
- let (status, error): (String, Option<String>) = conn
1853
- .query_row(
1854
- "select status, error from messages where message_id = ?1",
1855
- [&message_id],
1856
- |row| Ok((row.get(0)?, row.get(1)?)),
1857
- )
1858
- .unwrap();
1859
- assert_eq!(status, "queued_pane_missing");
1860
- assert_eq!(error.as_deref(), Some("tmux_target_missing"));
1861
- let events = log.tail(0).unwrap();
1862
- assert!(
1863
- events.iter().any(|event| {
1864
- event.get("event").and_then(serde_json::Value::as_str) == Some("send.inject_blocked")
1865
- && event.get("reason").and_then(serde_json::Value::as_str)
1866
- == Some("tmux_target_missing")
1867
- }),
1868
- "target-missing block must be explicit in events; events={events:?}"
1869
- );
1870
- }
1871
-
1872
- #[test]
1873
- fn u1_projection_refused_emits_delivery_event() {
1874
- let ws = tmp_ws("u1projref");
1875
- let store = store_for(&ws);
1876
- let log = EventLog::new(&ws);
1877
- let state = serde_json::json!({
1878
- "session_name": "team-a",
1879
- "active_team_key": "team-a",
1880
- "teams": {
1881
- "team-a": {
1882
- "session_name": "team-a",
1883
- "agents": {"w1": {"provider": "fake", "window": "w1"}}
1884
- }
1885
- },
1886
- "agents": {"w1": {"provider": "fake", "window": "w1"}}
1887
- });
1888
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1889
- let message_id = store
1890
- .create_message(
1891
- None,
1892
- "leader",
1893
- "w1",
1894
- "wrong team",
1895
- None,
1896
- false,
1897
- Some("missing-team"),
1898
- )
1899
- .unwrap();
1900
-
1901
- let delivered = deliver_pending_messages(&ws, &state, &OfflineTransport::new(), &log)
1902
- .expect("projection refusal must not abort the delivery batch");
1903
-
1904
- assert!(
1905
- delivered.is_empty(),
1906
- "the refused owner-team row must not be delivered"
1907
- );
1908
- let events = log.tail(0).unwrap();
1909
- assert!(
1910
- events.iter().any(|event| {
1911
- event.get("event").and_then(serde_json::Value::as_str)
1912
- == Some("delivery.projection_refused")
1913
- && event.get("message_id").and_then(serde_json::Value::as_str)
1914
- == Some(message_id.as_str())
1915
- && event
1916
- .get("owner_team_id")
1917
- .and_then(serde_json::Value::as_str)
1918
- == Some("missing-team")
1919
- }),
1920
- "OwnerTeamProjection::Refused must leave a delivery.projection_refused audit event; events={events:?}"
1921
- );
1922
- }
1923
-
1924
- #[test]
1925
- fn u1_deliver_item_error_does_not_halt_remaining_batch() {
1926
- let ws = tmp_ws("u1itemblock");
1927
- let store = store_for(&ws);
1928
- let log = EventLog::new(&ws);
1929
- let state = serde_json::json!({
1930
- "session_name": "team-u1itemblock",
1931
- "agents": {
1932
- "w1": {"provider": "fake", "window": "w1"},
1933
- "w2": {"provider": "fake", "window": "w2"}
1934
- }
1935
- });
1936
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1937
- let blocked = store
1938
- .create_message(None, "leader", "w1", "poison", None, false, None)
1939
- .unwrap();
1940
- let delivered_id = store
1941
- .create_message(None, "peer", "w2", "still deliver", None, false, None)
1942
- .unwrap();
1943
-
1944
- let state_path = crate::state::persist::runtime_state_path(&ws);
1945
- std::fs::remove_file(&state_path).unwrap();
1946
- std::fs::create_dir(&state_path).unwrap();
1947
- let transport = OfflineTransport::new();
1948
-
1949
- let delivered = deliver_pending_messages(&ws, &state, &transport, &log)
1950
- .expect("one item error must not halt the whole pending batch");
1951
-
1952
- assert_eq!(
1953
- delivered,
1954
- vec![delivered_id.clone()],
1955
- "a poison item must be isolated while later pending rows still deliver"
1956
- );
1957
- let events = log.tail(0).unwrap();
1958
- assert!(
1959
- events.iter().any(|event| {
1960
- event.get("event").and_then(serde_json::Value::as_str) == Some("delivery.item_blocked")
1961
- && event.get("message_id").and_then(serde_json::Value::as_str)
1962
- == Some(blocked.as_str())
1963
- }),
1964
- "the isolated poison item must emit delivery.item_blocked; events={events:?}"
1965
- );
1966
- }
1967
-
1968
- #[test]
1969
- fn u1_resolve_inject_target_uses_live_pane_when_cached_pane_drifted() {
1970
- let ws = tmp_ws("u1drift");
1971
- let store = store_for(&ws);
1972
- let log = EventLog::new(&ws);
1973
- let state = serde_json::json!({
1974
- "session_name": "team-u1drift",
1975
- "agents": {
1976
- "w1": {
1977
- "provider": "fake",
1978
- "pane_id": "%stale",
1979
- "window": "w1"
1980
- }
1981
- }
1982
- });
1983
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
1984
- let _ = store
1985
- .create_message(None, "peer", "w1", "drift-safe", None, false, None)
1986
- .unwrap();
1987
- let transport =
1988
- OfflineTransport::new().with_targets(vec![pane_info("%live", "team-u1drift", "w1")]);
1989
-
1990
- let delivered = deliver_pending_messages(&ws, &state, &transport, &log)
1991
- .expect("live target re-resolution must not fail");
1992
-
1993
- assert_eq!(delivered.len(), 1);
1994
- assert_eq!(
1995
- transport.inject_targets(),
1996
- vec![Target::Pane(PaneId::new("%live"))],
1997
- "delivery must validate the cached pane against live targets and re-resolve by session/window when it drifted"
1998
- );
1999
- }
2000
-
2001
- #[test]
2002
- fn e51_delivery_allows_same_pane_id_on_different_tmux_sockets() {
2003
- let ws = tmp_ws("e51diffsocket");
2004
- let store = store_for(&ws);
2005
- let log = EventLog::new(&ws);
2006
- let state = serde_json::json!({
2007
- "session_name": "team-e51",
2008
- "tmux_endpoint": "/private/tmp/tmux-501/ta-worker",
2009
- "leader_receiver": {
2010
- "pane_id": "%0",
2011
- "tmux_socket": "/private/tmp/tmux-501/default"
2012
- },
2013
- "agents": {
2014
- "architect": {
2015
- "provider": "fake",
2016
- "pane_id": "%0",
2017
- "window": "architect"
2018
- }
2019
- }
2020
- });
2021
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2022
- let _ = store
2023
- .create_message(None, "peer", "architect", "socket-aware", None, false, None)
2024
- .unwrap();
2025
- let transport = OfflineTransport::new()
2026
- .with_tmux_endpoint("/private/tmp/tmux-501/ta-worker")
2027
- .with_targets(vec![pane_info("%0", "team-e51", "architect")]);
2028
-
2029
- let delivered = deliver_pending_messages(&ws, &state, &transport, &log)
2030
- .expect("same pane id on different sockets must not poison delivery");
2031
-
2032
- assert_eq!(delivered.len(), 1);
2033
- assert_eq!(
2034
- transport.inject_targets(),
2035
- vec![Target::Pane(PaneId::new("%0"))],
2036
- "E51 must compare pane_id with tmux_socket; different sockets are not a leader conflict"
2037
- );
2038
- }
2039
-
2040
- #[test]
2041
- fn e51_delivery_keeps_same_socket_pane_conflict_guard() {
2042
- let ws = tmp_ws("e51samesocket");
2043
- let store = store_for(&ws);
2044
- let log = EventLog::new(&ws);
2045
- let socket = "/private/tmp/tmux-501/default";
2046
- let state = serde_json::json!({
2047
- "session_name": "team-e51",
2048
- "tmux_endpoint": socket,
2049
- "leader_receiver": {
2050
- "pane_id": "%0",
2051
- "tmux_socket": socket
2052
- },
2053
- "agents": {
2054
- "architect": {
2055
- "provider": "fake",
2056
- "pane_id": "%0",
2057
- "window": "architect"
2058
- }
2059
- }
2060
- });
2061
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2062
- let _ = store
2063
- .create_message(None, "peer", "architect", "same-socket", None, false, None)
2064
- .unwrap();
2065
- let transport = OfflineTransport::new()
2066
- .with_tmux_endpoint(socket)
2067
- .with_targets(vec![pane_info("%0", "team-e51", "architect")]);
2068
-
2069
- let delivered = deliver_pending_messages(&ws, &state, &transport, &log)
2070
- .expect("same-socket E51 guard should still resolve to a structured target");
2071
-
2072
- assert_eq!(delivered.len(), 1);
2073
- assert_eq!(
2074
- transport.inject_targets(),
2075
- vec![Target::SessionWindow {
2076
- session: SessionName::new("team-e51"),
2077
- window: WindowName::new("architect_pane_conflicts_with_leader"),
2078
- }],
2079
- "same pane id on the same socket must keep the E51 loop guard"
2080
- );
2081
- }
2082
-
2083
- fn app_server_state(
2084
- ws: &Path,
2085
- endpoint: &str,
2086
- thread_id: &str,
2087
- session_id: &str,
2088
- ) -> serde_json::Value {
2089
- serde_json::json!({
2090
- "active_team_key": "team-a",
2091
- "teams": {
2092
- "team-a": {
2093
- "team_key": "team-a",
2094
- "agents": {},
2095
- "leader_receiver": {
2096
- "mode": "codex_app_server",
2097
- "transport_kind": "codex_app_server",
2098
- "status": "attached",
2099
- "provider": "codex",
2100
- "owner_epoch": 7,
2101
- "app_server": {
2102
- "socket": endpoint,
2103
- "thread_id": thread_id,
2104
- "session_id": session_id,
2105
- "cwd": ws.to_string_lossy(),
2106
- "cli_version": "codex-appserver-team-agent-test/0.139.0",
2107
- "bound_at": "2026-07-05T00:00:00Z"
2108
- }
2109
- },
2110
- "team_owner": {
2111
- "provider": "codex",
2112
- "transport_kind": "codex_app_server",
2113
- "owner_epoch": 7
2114
- },
2115
- "owner_epoch": 7
2116
- }
2117
- }
2118
- })
2119
- }
2120
-
2121
- // 0.5.x Windows portability Batch 5: FakeAppServer uses Unix domain
2122
- // sockets — Unix-only.
2123
- #[cfg(unix)]
2124
- #[test]
2125
- fn app_server_leader_delivery_marks_delivered_without_tmux_transport() {
2126
- let ws = tmp_ws("appdeliver");
2127
- let fake = crate::app_server_test_support::FakeAppServer::start(
2128
- "deliver-ok",
2129
- crate::app_server_test_support::FakeAppServerScript::happy(
2130
- "thread-live",
2131
- "session-live",
2132
- ws.to_str().unwrap(),
2133
- ),
2134
- );
2135
- let state = app_server_state(&ws, fake.endpoint(), "thread-live", "session-live");
2136
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2137
- let store = store_for(&ws);
2138
- let log = EventLog::new(&ws);
2139
- let message_id = store
2140
- .create_message(
2141
- None,
2142
- "worker_a",
2143
- "leader",
2144
- "app server hello",
2145
- None,
2146
- false,
2147
- Some("team-a"),
2148
- )
2149
- .unwrap();
2150
-
2151
- let out = deliver_pending_message(&ws, &store, &NoopTransport, &message_id, &log, &state)
2152
- .expect("app-server delivery should not require tmux transport");
2153
-
2154
- assert!(
2155
- out.ok,
2156
- "app-server turn/start acceptance is delivery proof: {out:?}"
2157
- );
2158
- assert_eq!(out.message_status.0, "delivered");
2159
- assert_eq!(out.channel.as_deref(), Some("codex_app_server"));
2160
- let turns = fake.received_turns();
2161
- assert_eq!(turns.len(), 1);
2162
- assert_eq!(
2163
- turns[0]["params"]["clientUserMessageId"],
2164
- serde_json::json!(message_id)
2165
- );
2166
- let events = log.tail(0).unwrap();
2167
- assert!(
2168
- events.iter().any(|event| {
2169
- event.get("event").and_then(serde_json::Value::as_str)
2170
- == Some("leader_receiver.app_server_submitted")
2171
- }),
2172
- "delivery must emit app-server submission event; events={events:?}"
2173
- );
2174
- }
2175
-
2176
- #[cfg(unix)]
2177
- #[test]
2178
- fn app_server_leader_delivery_stale_tuple_fails_closed_with_event() {
2179
- let ws = tmp_ws("appstale");
2180
- let fake = crate::app_server_test_support::FakeAppServer::start(
2181
- "deliver-stale",
2182
- crate::app_server_test_support::FakeAppServerScript::happy(
2183
- "thread-live",
2184
- "session-new",
2185
- ws.to_str().unwrap(),
2186
- ),
2187
- );
2188
- let state = app_server_state(&ws, fake.endpoint(), "thread-live", "session-old");
2189
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2190
- let store = store_for(&ws);
2191
- let log = EventLog::new(&ws);
2192
- let message_id = store
2193
- .create_message(
2194
- None,
2195
- "worker_a",
2196
- "leader",
2197
- "stale",
2198
- None,
2199
- false,
2200
- Some("team-a"),
2201
- )
2202
- .unwrap();
2203
-
2204
- let out = deliver_pending_message(&ws, &store, &NoopTransport, &message_id, &log, &state)
2205
- .expect("stale app-server binding should be a business failure, not panic");
2206
-
2207
- assert!(!out.ok);
2208
- assert_eq!(out.channel.as_deref(), Some("rebind_required"));
2209
- assert_eq!(out.message_status.0, "failed");
2210
- let events = log.tail(0).unwrap();
2211
- assert!(
2212
- events.iter().any(|event| {
2213
- event.get("event").and_then(serde_json::Value::as_str)
2214
- == Some("leader_receiver.app_server_thread_stale")
2215
- && event.get("message_id").and_then(serde_json::Value::as_str)
2216
- == Some(message_id.as_str())
2217
- }),
2218
- "stale app-server tuple must emit app_server_thread_stale; events={events:?}"
2219
- );
2220
- }
2221
-
2222
- #[test]
2223
- fn app_server_leader_delivery_fails_closed_on_mode_transport_conflict() {
2224
- let ws = tmp_ws("appconflict");
2225
- let mut state = app_server_state(
2226
- &ws,
2227
- "unix:///tmp/team-agent-should-not-connect.sock",
2228
- "thread-live",
2229
- "session-live",
2230
- );
2231
- state["teams"]["team-a"]["leader_receiver"]["mode"] = serde_json::json!("direct_tmux");
2232
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2233
- let store = store_for(&ws);
2234
- let log = EventLog::new(&ws);
2235
- let message_id = store
2236
- .create_message(
2237
- None,
2238
- "worker_a",
2239
- "leader",
2240
- "conflict",
2241
- None,
2242
- false,
2243
- Some("team-a"),
2244
- )
2245
- .unwrap();
2246
-
2247
- let out = deliver_pending_message(&ws, &store, &NoopTransport, &message_id, &log, &state)
2248
- .expect("transport conflict should be a business failure");
2249
-
2250
- assert!(!out.ok);
2251
- assert_eq!(out.channel.as_deref(), Some("rebind_required"));
2252
- assert_eq!(out.message_status.0, "failed");
2253
- assert_eq!(
2254
- out.verification.as_deref(),
2255
- Some("run team-agent claim-leader, takeover, or attach-app-server-leader")
2256
- );
2257
- let events = log.tail(0).unwrap();
2258
- assert!(
2259
- events.iter().any(|event| {
2260
- event.get("event").and_then(serde_json::Value::as_str)
2261
- == Some("leader_receiver.delivery_blocked")
2262
- && event.get("reason").and_then(serde_json::Value::as_str)
2263
- == Some("leader_receiver_transport_conflict")
2264
- }),
2265
- "transport conflict must emit explicit fail-closed event; events={events:?}"
2266
- );
2267
- }
2268
-
2269
- #[cfg(unix)]
2270
- #[test]
2271
- fn app_server_leader_busy_is_retryable_and_does_not_steer() {
2272
- let ws = tmp_ws("appbusy");
2273
- let mut script = crate::app_server_test_support::FakeAppServerScript::happy(
2274
- "thread-live",
2275
- "session-live",
2276
- ws.to_str().unwrap(),
2277
- );
2278
- script.turn_error = Some("thread already has an active turn".to_string());
2279
- let fake = crate::app_server_test_support::FakeAppServer::start("deliver-busy", script);
2280
- let state = app_server_state(&ws, fake.endpoint(), "thread-live", "session-live");
2281
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2282
- let store = store_for(&ws);
2283
- let log = EventLog::new(&ws);
2284
- let message_id = store
2285
- .create_message(
2286
- None,
2287
- "worker_a",
2288
- "leader",
2289
- "busy",
2290
- None,
2291
- false,
2292
- Some("team-a"),
2293
- )
2294
- .unwrap();
2295
-
2296
- let out = deliver_pending_message(&ws, &store, &NoopTransport, &message_id, &log, &state)
2297
- .expect("leader busy should be retryable");
2298
-
2299
- assert!(!out.ok);
2300
- assert_eq!(out.status, DeliveryStatus::RetryScheduled);
2301
- assert_eq!(out.channel.as_deref(), Some("leader_busy"));
2302
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
2303
- let status: String = conn
2304
- .query_row(
2305
- "select status from messages where message_id = ?1",
2306
- [&message_id],
2307
- |row| row.get(0),
2308
- )
2309
- .unwrap();
2310
- assert_eq!(status, "target_resolved", "busy leader remains retryable");
2311
- let turns = fake.received_turns();
2312
- assert_eq!(
2313
- turns.len(),
2314
- 1,
2315
- "must only call turn/start, never turn/steer"
2316
- );
2317
- assert_eq!(turns[0]["method"], serde_json::json!("turn/start"));
2318
- }
2319
-
2320
- #[test]
2321
- fn u1_multi_team_send_does_not_backfill_top_level_leader_binding() {
2322
- let ws = tmp_ws("u1backfill");
2323
- crate::state::persist::save_runtime_state(
2324
- &ws,
2325
- &serde_json::json!({
2326
- "session_name": "team-a",
2327
- "active_team_key": "team-a",
2328
- "leader_receiver": {"status": "unbound", "pane_id": "__team_agent_unbound__"},
2329
- "team_owner": {"pane_id": "__team_agent_unbound__"},
2330
- "teams": {
2331
- "team-a": {
2332
- "session_name": "team-a",
2333
- "leader_receiver": {"status": "unbound", "pane_id": "__team_agent_unbound__"},
2334
- "agents": {}
2335
- },
2336
- "team-b": {
2337
- "session_name": "team-b",
2338
- "agents": {}
2339
- }
2340
- },
2341
- "agents": {}
2342
- }),
2343
- )
2344
- .unwrap();
2345
- let opts = SendOptions {
2346
- team: Some(TeamKey::new("team-b")),
2347
- requires_ack: false,
2348
- ..SendOptions::default()
2349
- };
2350
-
2351
- let out = send_message(
2352
- &ws,
2353
- &MessageTarget::Single("leader".to_string()),
2354
- "hello team-b",
2355
- &opts,
2356
- )
2357
- .unwrap();
2358
-
2359
- assert_eq!(
2360
- out.status,
2361
- DeliveryStatus::Queued,
2362
- "team-b leader send must not inherit team-a/top-level unbound leader binding"
2363
- );
2364
- let message_id = out.message_id.expect("queued leader message id");
2365
- let store = store_for(&ws);
2366
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
2367
- let owner_team_id: Option<String> = conn
2368
- .query_row(
2369
- "select owner_team_id from messages where message_id = ?1",
2370
- [&message_id],
2371
- |row| row.get(0),
2372
- )
2373
- .unwrap();
2374
- assert_eq!(owner_team_id.as_deref(), Some("team-b"));
2375
- }
2376
-
2377
- #[test]
2378
- fn casefile_leader_send_is_durable_without_entering_leader_funnel() {
2379
- let ws = tmp_ws("casefile-send");
2380
- crate::state::persist::save_runtime_state(
2381
- &ws,
2382
- &serde_json::json!({
2383
- "session_name": "team-a",
2384
- "active_team_key": "team-a",
2385
- "agents": {}
2386
- }),
2387
- )
2388
- .unwrap();
2389
- let opts = SendOptions {
2390
- team: Some(TeamKey::new("team-a")),
2391
- requires_ack: false,
2392
- presentation: crate::messaging::presentation::PresentationRequest {
2393
- sink: crate::messaging::presentation::PresentationSink::Casefile,
2394
- class: crate::messaging::presentation::PresentationClass::Progress,
2395
- case_id: Some("case-1".to_string()),
2396
- },
2397
- ..SendOptions::default()
2398
- };
2399
- let out = send_message(
2400
- &ws,
2401
- &MessageTarget::Single("leader".to_string()),
2402
- "internal progress",
2403
- &opts,
2404
- )
2405
- .unwrap();
2406
- assert_eq!(out.status, DeliveryStatus::StoredOnly);
2407
- assert_eq!(out.message_status.0, "stored_only");
2408
- let store = store_for(&ws);
2409
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
2410
- let (status, presentation): (String, String) = conn
2411
- .query_row(
2412
- "select status, presentation from messages where message_id = ?1",
2413
- [out.message_id.as_deref().unwrap()],
2414
- |row| Ok((row.get(0)?, row.get(1)?)),
2415
- )
2416
- .unwrap();
2417
- assert_eq!(status, "stored_only");
2418
- assert_eq!(
2419
- serde_json::from_str::<serde_json::Value>(&presentation).unwrap()["effective_sink"],
2420
- "casefile"
2421
- );
2422
- }
2423
-
2424
- // ════════════════════════════════════════════════════════════════════════
2425
- // GROUP V — retry_result_deliveries: re-route notify_failed watchers with
2426
- // dedupe_reason rebind_retry. result_delivery.py:19-35.
2427
- // ════════════════════════════════════════════════════════════════════════
2428
-
2429
- #[test]
2430
- fn retry_result_deliveries_retries_notify_failed_watcher() {
2431
- // SEEDED contract (result_delivery.py:18-34): retry_result_deliveries scans
2432
- // retryable_result_watchers (status in pending/notify_failed), resolves each
2433
- // watcher's result via result_by_id, and re-routes through notify_result_watchers
2434
- // with dedupe_reason="rebind_retry". Seed a notify_failed watcher + its matching
2435
- // result row → the watcher IS retried and a WatcherNotice for it is returned.
2436
- // Probed golden: notices == [{watcher_id, result_id, ok, ...}] for the seeded
2437
- // watcher (delivery ok depends on full team state; the retry-was-attempted
2438
- // contract is the invariant — an empty store would NOT exercise it).
2439
- let ws = tmp_ws("retrydeliv");
2440
- let store = store_for(&ws);
2441
- let log = EventLog::new(&ws);
2442
-
2443
- let rid = seed_result(&store, "res_r1", "t1", "alice", "success");
2444
- let w = seed_watcher(
2445
- &store,
2446
- "w-failed",
2447
- "team-a",
2448
- "t1",
2449
- "alice",
2450
- "notify_failed",
2451
- Some(&rid),
2452
- None,
2453
- );
2454
-
2455
- let notices = retry_result_deliveries(&ws, &log).unwrap();
2456
-
2457
- assert_eq!(
2458
- notices.len(),
2459
- 1,
2460
- "the single notify_failed watcher must be retried"
2461
- );
2462
- let notice = &notices[0];
2463
- assert_eq!(
2464
- notice.watcher_id, w,
2465
- "the retried notice names the seeded watcher"
2466
- );
2467
- assert_eq!(
2468
- notice.result_id.as_deref(),
2469
- Some(rid.as_str()),
2470
- "retry resolves and carries the watcher's result_id (rebind_retry path)"
2471
- );
2472
- }
2473
-
2474
- // ════════════════════════════════════════════════════════════════════════
2475
- // GROUP X — delivered_result_message content-level dedupe lookup +
2476
- // result_id_from_text dual (scheduler send dedupe path). result_delivery.py:394.
2477
- // ════════════════════════════════════════════════════════════════════════
2478
-
2479
- #[test]
2480
- fn delivered_result_message_none_in_fresh_store() {
2481
- let ws = tmp_ws("delivdedupe");
2482
- let store = store_for(&ws);
2483
- let found = delivered_result_message(&store, "r1", None, None).unwrap();
2484
- assert!(found.is_none());
2485
- }
2486
-
2487
- #[test]
2488
- fn delivered_result_message_empty_result_id_is_none() {
2489
- // result_delivery.py:401-402 — empty result_id short-circuits to None.
2490
- let ws = tmp_ws("delivdedupe2");
2491
- let store = store_for(&ws);
2492
- let found = delivered_result_message(&store, "", None, None).unwrap();
2493
- assert!(found.is_none());
2494
- }
2495
-
2496
- // ═══════════════════════════════════════════════════════════════════════════
2497
- // collect #223 — task-scoped collect + send --task validation (RED).
2498
- // ═══════════════════════════════════════════════════════════════════════════
2499
-
2500
- // (c) a result whose task_id ∈ state.tasks collects as scope:"task"; the task row advances to
2501
- // "done" (success → done, runtime.py:1066); results.collected ≥ 1. Proves the collect-READ works
2502
- // once state.tasks is seeded — so the #223 fix target is the upstream seeding, not collect.
2503
- #[test]
2504
- fn collect_task_scoped_result_collects_and_marks_task_done() {
2505
- let ws = tmp_ws("collecttask223");
2506
- std::fs::write(ws.join("team.spec.yaml"), "version: 1\n").unwrap();
2507
- crate::state::persist::save_runtime_state(
2508
- &ws,
2509
- &serde_json::json!({
2510
- "session_name": "team-x",
2511
- "agents": { "w1": { "provider": "copilot" } },
2512
- "tasks": [ { "id": "t2", "assignee": "w1", "title": "t2", "status": "pending" } ]
2513
- }),
2514
- )
2515
- .unwrap();
2516
- let store = store_for(&ws);
2517
- seed_result(&store, "res_t2", "t2", "w1", "success");
2518
-
2519
- let out = collect(&ws, None, false).unwrap();
2520
- assert_eq!(
2521
- out.get("ok").and_then(|v| v.as_bool()),
2522
- Some(true),
2523
- "no invalid → ok:true"
2524
- );
2525
- let cr = out
2526
- .get("collected_results")
2527
- .and_then(|v| v.as_array())
2528
- .expect("collected_results");
2529
- assert_eq!(cr.len(), 1, "the seeded t2 result must collect");
2530
- assert_eq!(
2531
- cr[0].get("scope").and_then(|v| v.as_str()),
2532
- Some("task"),
2533
- "t2 ∈ state.tasks → scope:task"
2534
- );
2535
- assert_eq!(cr[0].get("task_id").and_then(|v| v.as_str()), Some("t2"));
2536
- assert_eq!(cr[0].get("agent_id").and_then(|v| v.as_str()), Some("w1"));
2537
- assert!(
2538
- out.get("results")
2539
- .and_then(|r| r.get("collected"))
2540
- .and_then(|v| v.as_i64())
2541
- .unwrap_or(0)
2542
- >= 1,
2543
- "results.collected must be ≥ 1"
2544
- );
2545
- let st = crate::state::persist::load_runtime_state(&ws).unwrap();
2546
- let t2_status = st
2547
- .get("tasks")
2548
- .and_then(|v| v.as_array())
2549
- .and_then(|ts| {
2550
- ts.iter()
2551
- .find(|t| t.get("id").and_then(|v| v.as_str()) == Some("t2"))
2552
- })
2553
- .and_then(|t| t.get("status"))
2554
- .and_then(|v| v.as_str());
2555
- assert_eq!(
2556
- t2_status,
2557
- Some("done"),
2558
- "success result → task row status 'done' (runtime.py:1066)"
2559
- );
2560
- }
2561
-
2562
- // (c-C1) collect OUTPUT shape: collected_results entries are the 8-KEY SUMMARY (NO inlined
2563
- // envelope; carry summary+tests) and the full envelopes live in a SEPARATE top-level `collected`
2564
- // list (golden results.py:86/131). Rust inlines `envelope`+`owner_team_id` and emits no
2565
- // `collected` list → RED.
2566
- #[test]
2567
- fn collect_output_matches_golden_collected_shape() {
2568
- let ws = tmp_ws("collectshape223");
2569
- std::fs::write(ws.join("team.spec.yaml"), "version: 1\n").unwrap();
2570
- crate::state::persist::save_runtime_state(
2571
- &ws,
2572
- &serde_json::json!({
2573
- "session_name": "team-x",
2574
- "agents": { "w1": { "provider": "copilot" } },
2575
- "tasks": [ { "id": "t2", "assignee": "w1", "title": "t2", "status": "pending" } ]
2576
- }),
2577
- )
2578
- .unwrap();
2579
- let store = store_for(&ws);
2580
- seed_result(&store, "res_t2s", "t2", "w1", "success");
2581
-
2582
- let out = collect(&ws, None, false).unwrap();
2583
- let cr = out
2584
- .get("collected_results")
2585
- .and_then(|v| v.as_array())
2586
- .expect("collected_results");
2587
- let e = &cr[0];
2588
- // C1: collected_results entry is the 8-key SUMMARY — NO envelope inlined; carries summary+tests.
2589
- assert!(e.get("envelope").is_none(),
2590
- "collected_results entry must NOT inline `envelope` (golden 8-key summary); the full envelope belongs in `collected`. got {e:?}");
2591
- assert!(
2592
- e.get("summary").is_some() && e.get("tests").is_some(),
2593
- "collected_results summary entry must carry `summary`+`tests` (golden results.py:131)"
2594
- );
2595
- // C1: the full envelopes live in a separate top-level `collected` list.
2596
- let collected = out
2597
- .get("collected")
2598
- .and_then(|v| v.as_array())
2599
- .expect("golden collect returns a top-level `collected` list of full envelopes");
2600
- assert!(
2601
- collected
2602
- .first()
2603
- .and_then(|env| env.get("schema_version"))
2604
- .and_then(|v| v.as_str())
2605
- == Some("result_envelope_v1"),
2606
- "collected[0] must be the full result_envelope_v1 envelope; got {collected:?}"
2607
- );
2608
-
2609
- // ── STRENGTHENED (option-B byte-parity, leader-adjudicated 0700cff review) ──
2610
- // D3 — task-scope collected_results entry must be EXACTLY the golden 8 keys, in order, NO task_status.
2611
- let keys: Vec<&str> = e
2612
- .as_object()
2613
- .expect("entry is an object")
2614
- .keys()
2615
- .map(String::as_str)
2616
- .collect();
2617
- assert_eq!(
2618
- keys,
2619
- vec!["result_id", "task_id", "agent_id", "status", "summary", "tests", "created_at", "scope"],
2620
- "collected_results entry must be EXACTLY the golden 8 keys in order (results.py:131; no task_status/envelope/owner_team_id); got {keys:?}"
2621
- );
2622
- // D1+D2 — collect RETURN top-level key order must match golden EXACTLY: delivered_messages BEFORE
2623
- // invalid_results, AND a `coordinator` key (mirroring golden _ensure_coordinator_after_collect).
2624
- let top: Vec<&str> = out
2625
- .as_object()
2626
- .expect("collect result is an object")
2627
- .keys()
2628
- .map(String::as_str)
2629
- .collect();
2630
- assert_eq!(
2631
- top,
2632
- vec![
2633
- "ok",
2634
- "collected",
2635
- "collected_results",
2636
- "delivered_messages",
2637
- "invalid_results",
2638
- "results",
2639
- "state_file",
2640
- "coordinator"
2641
- ],
2642
- "collect return top-level key order must match golden return shape; got {top:?}"
2643
- );
2644
- }
2645
-
2646
- // (d) send --task <unknown id> must RAISE golden "unknown task id" (runtime.py:1032 _find_task),
2647
- // not silently create a message. Rust send_message attaches task_id without validating → Ok. RED.
2648
- // block_until_delivered=false isolates the task-validation from any delivery side-effect.
2649
- #[test]
2650
- fn send_with_unknown_task_id_raises_unknown_task() {
2651
- let ws = tmp_ws("sendunknowntask223");
2652
- crate::state::persist::save_runtime_state(
2653
- &ws,
2654
- &serde_json::json!({
2655
- "session_name": "team-x",
2656
- "agents": { "w1": { "provider": "copilot" } },
2657
- "tasks": []
2658
- }),
2659
- )
2660
- .unwrap();
2661
- let _ = store_for(&ws);
2662
- let opts = SendOptions {
2663
- task_id: Some(crate::model::ids::TaskId::new("t2-unknown")),
2664
- block_until_delivered: false,
2665
- ..SendOptions::default()
2666
- };
2667
- let out = send_message(&ws, &MessageTarget::Single("w1".to_string()), "go", &opts);
2668
- match out {
2669
- Err(e) => {
2670
- // SURFACED error = the CLI `error` field = CliError::from(MessagingError).to_string()
2671
- // (to_payload uses self.to_string(), types.rs:59). Must EQUAL golden's bare message —
2672
- // NO "validation:" variant prefix (golden runtime.py:1032 surfaces str(exc)).
2673
- let surfaced = crate::cli::CliError::from(e).to_string();
2674
- assert_eq!(
2675
- surfaced, "unknown task id: t2-unknown",
2676
- "surfaced CLI error must EQUAL golden's message with NO variant prefix; got {surfaced:?}"
2677
- );
2678
- }
2679
- Ok(o) => panic!(
2680
- "send --task <unknown id> must RAISE 'unknown task id' (golden runtime.py:1032 _find_task), \
2681
- not silently create a message; got Ok({o:?})"
2682
- ),
2683
- }
2684
- }
2685
-
2686
- // ════════════════════════════════════════════════════════════════════════
2687
- // P0 REGRESSION (0700cff "send 0 bytes, nothing queued" / coordinator never delivers).
2688
- // golden gates the unknown-task RAISE on route_task_id (send.py:204 `if task_id and route_task_id`);
2689
- // delivery/fanout/internal sends pass route_task_id=False (internal_delivery.py:44, send.py:412/481)
2690
- // → the task is a label, NOT validated. 0700cff's UNCONDITIONAL task_exists gate broke every
2691
- // task-tagged delivery/internal send at CREATION time. The gate the OfflineTransport tests missed.
2692
- // ════════════════════════════════════════════════════════════════════════
2693
-
2694
- // (a) [REGRESSION GATE] route_task_id=false + task_id NOT in state.tasks → send SUCCEEDS and the
2695
- // message is QUEUED (real create path; no transport). Must NOT raise "unknown task id".
2696
- #[test]
2697
- fn send_route_task_id_false_skips_task_validation_and_queues() {
2698
- let ws = tmp_ws("sendroutefalse");
2699
- crate::state::persist::save_runtime_state(
2700
- &ws,
2701
- &serde_json::json!({ "session_name": "team-x", "agents": { "w1": { "provider": "copilot" } }, "tasks": [] }),
2702
- ).unwrap();
2703
- let _ = store_for(&ws);
2704
- let opts = SendOptions {
2705
- task_id: Some(crate::model::ids::TaskId::new("t-not-seeded")),
2706
- route_task_id: false,
2707
- block_until_delivered: false,
2708
- ..SendOptions::default()
2709
- };
2710
- let out = send_message(&ws, &MessageTarget::Single("w1".to_string()), "deliver me", &opts)
2711
- .expect("route_task_id=false must NOT validate the task — golden delivery/internal path queues regardless of state.tasks");
2712
- assert!(
2713
- out.message_id.is_some(),
2714
- "the message must be CREATED (message_id present) on the route_task_id=false path; got {out:?}"
2715
- );
2716
- // real queue verification (not an Ok shell): the message landed in w1's inbox.
2717
- let inbox = store_for(&ws).inbox("w1", 10, None).expect("inbox");
2718
- assert!(
2719
- !inbox.is_empty(),
2720
- "the task-tagged message must be QUEUED for w1 on the delivery/internal path; inbox empty (0 bytes queued = the P0)"
2721
- );
2722
- }
2723
-
2724
- // (c) [LOCK] route_task_id=true + task_id IN state.tasks → send SUCCEEDS (routing happy-path).
2725
- #[test]
2726
- fn send_route_task_id_true_known_task_succeeds() {
2727
- let ws = tmp_ws("sendrouteknown");
2728
- crate::state::persist::save_runtime_state(
2729
- &ws,
2730
- &serde_json::json!({
2731
- "session_name": "team-x",
2732
- "agents": { "w1": { "provider": "copilot" } },
2733
- "tasks": [ { "id": "t-known", "assignee": "w1", "title": "t", "status": "pending" } ]
2734
- }),
2735
- )
2736
- .unwrap();
2737
- let _ = store_for(&ws);
2738
- let opts = SendOptions {
2739
- task_id: Some(crate::model::ids::TaskId::new("t-known")),
2740
- route_task_id: true,
2741
- block_until_delivered: false,
2742
- ..SendOptions::default()
2743
- };
2744
- let out = send_message(&ws, &MessageTarget::Single("w1".to_string()), "go", &opts)
2745
- .expect("route_task_id=true with a KNOWN task must succeed");
2746
- assert!(
2747
- out.message_id.is_some(),
2748
- "known-task routing send must create the message; got {out:?}"
2749
- );
2750
- }
2751
-
2752
- // ════════════════════════════════════════════════════════════════════════
2753
- // R8 byte-parity (leader attach requeue, advisor-ruled + e3eac28-reconciled):
2754
- // drive a watcher to delivery_exhausted via notify_result_watchers (attempts>=MAX) — proving the
2755
- // requeue input is REAL (non-空过) — then attach-requeue and assert the golden observable contract:
2756
- // D2 status: delivery_exhausted -> notify_failed (golden result_watchers.py:95), NOT 'pending'.
2757
- // D1 ✦ team-scoped + unnotified SELECTION (anti cross-team pollution / CP-1) — KEEP.
2758
- // D3 result_watcher.requeued payload == golden attach form {watcher_id, trigger:"attach_leader", new_pane_id}.
2759
- // (D4 leader_receiver.requeued_exhausted_watchers + D6 string return are the attach-wrapper/CLI layer —
2760
- // lease.rs:140 + cli/mod.rs:1088 — flagged for the porter; D5 event-layer is internal/optional.)
2761
- // ════════════════════════════════════════════════════════════════════════
2762
- #[test]
2763
- fn r8_attach_requeue_exhausted_to_notify_failed_golden_attach_event() {
2764
- let ws = tmp_ws("r8requeue");
2765
- let store = store_for(&ws);
2766
- let log = EventLog::new(&ws);
2767
- let team = TeamKey::new("team-a");
2768
- let pane = PaneId::new("%leader-new");
2769
-
2770
- // --- Sub-A: DRIVE w-r8 (team-a) to delivery_exhausted via notify_result_watchers (attempts>=MAX) ---
2771
- let rid = seed_result(&store, "res_r8", "t1", "alice", "success");
2772
- seed_watcher(
2773
- &store,
2774
- "w-r8",
2775
- "team-a",
2776
- "t1",
2777
- "alice",
2778
- "pending",
2779
- Some(&rid),
2780
- None,
2781
- );
2782
- // attempts are EVENT-counted (result_watcher.notify_failed/retry_notified) — seed MAX prior failures.
2783
- for n in 0..u64::from(RESULT_DELIVERY_MAX_ATTEMPTS) {
2784
- log.write(
2785
- "result_watcher.notify_failed",
2786
- json(serde_json::json!({"watcher_id": "w-r8", "result_id": rid.as_str(), "status": "notify_failed", "error": "x", "n": n})),
2787
- ).unwrap();
2788
- }
2789
- let result_env =
2790
- json(serde_json::json!({"result_id": rid.as_str(), "task_id": "t1", "agent_id": "alice"}));
2791
- let watcher_view = json(serde_json::json!({
2792
- "watcher_id": "w-r8", "task_id": "t1", "agent_id": "alice",
2793
- "created_at": "2026-01-01T00:00:00Z", "owner_team_id": "team-a",
2794
- "leader_id": "leader", "result_id": rid.as_str()
2795
- }));
2796
- notify_result_watchers(&ws, &result_env, &log, Some(&[watcher_view]), None).unwrap();
2797
- let (driven, _) = watcher_state(&store, "w-r8");
2798
- assert_eq!(driven, "delivery_exhausted",
2799
- "PRECONDITION: notify_result_watchers at attempts>=MAX must persist delivery_exhausted (watchers.rs:161-168) — \
2800
- proves the attach-requeue input is real, not 空过");
2801
-
2802
- // selection-lock fixtures: cross-team exhausted + notified exhausted (Gap-32) + pending.
2803
- let team_b = seed_watcher(
2804
- &store,
2805
- "w-teamb",
2806
- "team-b",
2807
- "t2",
2808
- "bob",
2809
- "delivery_exhausted",
2810
- Some("res_b"),
2811
- None,
2812
- );
2813
- let notif = seed_watcher(
2814
- &store,
2815
- "w-notified",
2816
- "team-a",
2817
- "t3",
2818
- "carol",
2819
- "delivery_exhausted",
2820
- Some("res_c"),
2821
- Some("msg_done"),
2822
- );
2823
- seed_watcher(
2824
- &store,
2825
- "w-pending",
2826
- "team-a",
2827
- "t4",
2828
- "dave",
2829
- "pending",
2830
- Some("res_d"),
2831
- None,
2832
- );
2833
-
2834
- // --- Sub-B: attach requeue (golden contract) ---
2835
- let requeued = requeue_delivery_exhausted_watchers(&ws, &store, &log, &team, &pane).unwrap();
2836
-
2837
- // D2: team-a exhausted -> notify_failed (NOT pending).
2838
- let (st_a, _) = watcher_state(&store, "w-r8");
2839
- assert_eq!(st_a, "notify_failed",
2840
- "D2: attach requeue must flip delivery_exhausted -> 'notify_failed' (golden result_watchers.py:95), not 'pending'");
2841
- // D1 ✦ team-scoped: cross-team exhausted watcher must NOT requeue onto team-a's pane.
2842
- let (st_b, _) = watcher_state(&store, &team_b);
2843
- assert_eq!(st_b, "delivery_exhausted",
2844
- "D1 ✦: team-scoped selection — a team-b exhausted watcher must NOT be requeued by a team-a attach (anti cross-team pollution / CP-1)");
2845
- // Gap-32: a notified watcher is never requeued; its notified_message_id survives.
2846
- let (st_n, nid) = watcher_state(&store, &notif);
2847
- assert_eq!(
2848
- st_n, "delivery_exhausted",
2849
- "Gap-32: notified watcher not requeued"
2850
- );
2851
- assert_eq!(
2852
- nid.as_deref(),
2853
- Some("msg_done"),
2854
- "Gap-32: notified_message_id preserved"
2855
- );
2856
- // only the team-a unnotified exhausted watcher requeues.
2857
- let ids: Vec<&str> = requeued.iter().map(|n| n.watcher_id.as_str()).collect();
2858
- assert_eq!(
2859
- ids,
2860
- vec!["w-r8"],
2861
- "only team-a unnotified delivery_exhausted watcher requeues"
2862
- );
2863
-
2864
- // D3: result_watcher.requeued payload == golden ATTACH form {watcher_id, trigger, new_pane_id}.
2865
- let events = log.tail(0).unwrap();
2866
- let ev = events
2867
- .iter()
2868
- .rev()
2869
- .find(|e| e.get("event").and_then(|v| v.as_str()) == Some("result_watcher.requeued"))
2870
- .expect("result_watcher.requeued event");
2871
- let keys: std::collections::BTreeSet<&str> = ev
2872
- .as_object()
2873
- .unwrap()
2874
- .keys()
2875
- .map(String::as_str)
2876
- .filter(|k| *k != "ts" && *k != "event")
2877
- .collect();
2878
- let expected: std::collections::BTreeSet<&str> = ["watcher_id", "trigger", "new_pane_id"]
2879
- .into_iter()
2880
- .collect();
2881
- assert_eq!(keys, expected,
2882
- "D3: result_watcher.requeued must be golden ATTACH form {{watcher_id, trigger, new_pane_id}} (leader/__init__.py:46-50), not claim-style; got {keys:?}");
2883
- assert_eq!(
2884
- ev.get("trigger").and_then(|v| v.as_str()),
2885
- Some("attach_leader")
2886
- );
2887
- assert_eq!(
2888
- ev.get("new_pane_id").and_then(|v| v.as_str()),
2889
- Some("%leader-new")
2890
- );
2891
- }
2892
-
2893
- // E15/E23 single-funnel guard: report_result presents a compact result through
2894
- // the shared leader receiver and does not carry a private direct-inject retry.
2895
- #[test]
2896
- fn e15_report_result_uses_shared_leader_receiver_without_private_retry() {
2897
- let src = include_str!("../results.rs");
2898
- assert!(
2899
- src.contains("send_to_leader_receiver_with_presentation"),
2900
- "E15/E23: report_result must use the shared leader receiver presentation funnel"
2901
- );
2902
- assert!(
2903
- !src.contains("inject_leader_notification_direct")
2904
- && !src.contains("deliver_to_leader_fallback_pane"),
2905
- "E23: private direct and removed fallback inject paths must stay deleted"
2906
- );
2907
- }
2908
-
2909
- // ════════════════════════════════════════════════════════════════════════
2910
- // 0.5.4 gate054 — cross-team notify boundary.
2911
- //
2912
- // Triage: .team/artifacts/0.5.4-gate-crossteam-notify-triage.md
2913
- //
2914
- // Shape (regression):
2915
- // - Gate team's `leader_receiver` records `pane_id=%1`, `tmux_socket=/tmp/gate`,
2916
- // `status="rebind_required"` (disposable leader was killed post-restart).
2917
- // - The main tmux server has a live `%1` on the workspace-canonical socket.
2918
- // - `deliver_pending_message` MUST refuse with `channel=rebind_required` and
2919
- // MUST NOT probe the main/default tmux server for the same pane id.
2920
- // ════════════════════════════════════════════════════════════════════════
2921
-
2922
- #[test]
2923
- fn gate054_rebind_required_status_refuses_leader_delivery_without_cross_server_probe() {
2924
- let ws = tmp_ws("gate054status");
2925
- let store = store_for(&ws);
2926
- let log = EventLog::new(&ws);
2927
- // Explicit endpoint socket (non-canonical for this workspace) with a
2928
- // stale receiver demoted to `rebind_required` after the gate's leader
2929
- // window was killed.
2930
- let state = serde_json::json!({
2931
- "session_name": "team-gate054",
2932
- "tmux_endpoint": "/tmp/gate-socket-does-not-exist",
2933
- "leader_receiver": {
2934
- "pane_id": "%1",
2935
- "tmux_socket": "/tmp/gate-socket-does-not-exist",
2936
- "status": "rebind_required"
2937
- },
2938
- "agents": {
2939
- "probe": {"provider": "fake", "pane_id": "%0", "window": "probe"}
2940
- }
2941
- });
2942
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
2943
- let message_id = store
2944
- .create_message(
2945
- None,
2946
- "probe",
2947
- "leader",
2948
- "gate054 must not leak",
2949
- None,
2950
- false,
2951
- None,
2952
- )
2953
- .unwrap();
2954
-
2955
- // The transport we pass is the "main"/default server backend which does
2956
- // have a live `%1`. If the fix regresses and delivery falls back cross-
2957
- // server by pane id, it would inject here.
2958
- let default_backend =
2959
- OfflineTransport::new().with_targets(vec![pane_info("%1", "team-main", "leader")]);
2960
-
2961
- let out = deliver_pending_message(&ws, &store, &default_backend, &message_id, &log, &state)
2962
- .expect("status guard must be a business refusal, not panic");
2963
-
2964
- assert!(
2965
- !out.ok,
2966
- "0.5.4 gate054: leader_receiver.status='rebind_required' must refuse delivery"
2967
- );
2968
- assert_eq!(out.channel.as_deref(), Some("rebind_required"));
2969
- assert_eq!(out.message_status.0, "failed");
2970
- assert_eq!(out.reason, Some(DeliveryRefusal::LeaderNotAttached));
2971
- // Cross-server invariant: even though the default backend has a live `%1`
2972
- // matching the recorded receiver pane id, delivery MUST NOT inject there.
2973
- assert!(
2974
- default_backend.inject_targets().is_empty(),
2975
- "0.5.4 gate054: leader delivery must not cross to a different tmux server by pane id; \
2976
- inject_targets={:?}",
2977
- default_backend.inject_targets()
2978
- );
2979
- let events = log.tail(0).unwrap();
2980
- assert!(
2981
- events.iter().any(|event| {
2982
- event.get("event").and_then(serde_json::Value::as_str)
2983
- == Some("leader_receiver.delivery_blocked")
2984
- && event.get("reason").and_then(serde_json::Value::as_str)
2985
- == Some("leader_receiver_not_attached")
2986
- && event.get("channel").and_then(serde_json::Value::as_str)
2987
- == Some("rebind_required")
2988
- && event.get("status").and_then(serde_json::Value::as_str)
2989
- == Some("rebind_required")
2990
- }),
2991
- "0.5.4 gate054: refused status must audit as leader_receiver_not_attached / rebind_required; events={events:?}"
2992
- );
2993
- }
2994
-
2995
- #[test]
2996
- fn gate054_attached_status_still_accepts_when_pane_is_live() {
2997
- // Companion negative: prove the new status gate does NOT over-refuse when
2998
- // `status="attached"` and the workspace-canonical socket has the pane.
2999
- // Injection-case revision: transport submit success is NOT a provider
3000
- // receipt, so the old `delivered` pin was a false-positive lock
3001
- // (MUST-10: physical submit is the framework's fact; acceptance is the
3002
- // provider's). The un-refused path now records the SAME row in the typed
3003
- // post-injection fact state until a provider receipt advances it.
3004
- let ws = tmp_ws("gate054ok");
3005
- let store = store_for(&ws);
3006
- let log = EventLog::new(&ws);
3007
- let state = serde_json::json!({
3008
- "session_name": "team-gate054ok",
3009
- "leader_receiver": {
3010
- "pane_id": "%leader",
3011
- "status": "attached"
3012
- },
3013
- "agents": {"w1": {"provider": "fake", "pane_id": "%1"}}
3014
- });
3015
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
3016
- let message_id = store
3017
- .create_message(None, "w1", "leader", "hi", None, false, None)
3018
- .unwrap();
3019
- let transport = OfflineTransport::new().with_targets(vec![pane_info(
3020
- "%leader",
3021
- "team-gate054ok",
3022
- "leader",
3023
- )]);
3024
-
3025
- let out = deliver_pending_message(&ws, &store, &transport, &message_id, &log, &state)
3026
- .expect("attached leader must still deliver");
3027
-
3028
- assert!(
3029
- out.ok,
3030
- "0.5.4 gate054: status='attached' with a live pane must not be over-refused: {out:?}"
3031
- );
3032
- assert_eq!(
3033
- transport.inject_targets().len(),
3034
- 1,
3035
- "gate054: exactly one physical inject must have happened (MUST-10 anchor)"
3036
- );
3037
- let injected_awaiting_receipt = crate::db::message_store::MessageRowStatus::ALL
3038
- .iter()
3039
- .map(|status| status.as_str())
3040
- .find(|status| *status == "injected_awaiting_receipt")
3041
- .expect(
3042
- "gate054 signed reanchor: typed status directory must expose \
3043
- injected_awaiting_receipt",
3044
- );
3045
- assert_eq!(
3046
- out.message_status.0, injected_awaiting_receipt,
3047
- "gate054 signed reanchor: a successful physical inject without a provider receipt \
3048
- must remain non-delivered as injected_awaiting_receipt, never claim delivered: {out:?}"
3049
- );
3050
- }
3051
-
3052
- // ════════════════════════════════════════════════════════════════════════
3053
- // 0.5.5 gate054 B-arm — deliver_to_leader_fallback_pane must not cross to
3054
- // another tmux server by pane id when a socket is recorded.
3055
- //
3056
- // Triage: real-machine acceptance B-fail — primary path (delivery.rs) refused
3057
- // with rebind_required, but report_result's fallback_pane bailout selected a
3058
- // same-numbered pane (%1) on the default tmux server (the main team's leader)
3059
- // and returned leader_notified:true / delivered_via=fallback_pane.
3060
- // ════════════════════════════════════════════════════════════════════════
3061
-
3062
- #[test]
3063
- fn gate054_fallback_pane_socket_recorded_does_not_cross_to_default_server() {
3064
- use crate::messaging::deliver_to_leader_fallback_pane;
3065
- let ws = tmp_ws("gate054fallback");
3066
- let store = store_for(&ws);
3067
- let log = EventLog::new(&ws);
3068
- // Recorded socket points at a non-existent endpoint (mimics the gate
3069
- // team's private socket after its leader session was killed). The main
3070
- // team's default tmux server MAY have a same-numbered `%1` — the fix
3071
- // must refuse to inject there.
3072
- let bogus_socket = format!("/tmp/team-agent-gate054-nonexistent-{}", std::process::id());
3073
- let state = serde_json::json!({
3074
- "session_name": "team-gate054",
3075
- "leader_receiver": {
3076
- "pane_id": "%1",
3077
- "tmux_socket": bogus_socket,
3078
- "status": "rebind_required"
3079
- }
3080
- });
3081
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
3082
- let message_id = store
3083
- .create_message(
3084
- None,
3085
- "coordinator",
3086
- "leader",
3087
- "fallback payload",
3088
- None,
3089
- false,
3090
- None,
3091
- )
3092
- .unwrap();
3093
-
3094
- let outcome = deliver_to_leader_fallback_pane(
3095
- &ws,
3096
- &state,
3097
- &message_id,
3098
- Some("res_gate054_fallback"),
3099
- "S3 restart complete",
3100
- false, // primary was NOT ok (report_result path)
3101
- Some("primary_delivery_error:leader_not_attached"),
3102
- &log,
3103
- )
3104
- .expect("fallback pane primitive must not panic");
3105
-
3106
- // Must NOT succeed by crossing to another server.
3107
- assert!(
3108
- !outcome.ok,
3109
- "0.5.5 gate054: fallback_pane must not cross a recorded socket boundary: outcome={outcome:?}"
3110
- );
3111
- // Loud-not-silent: caller wire status resolves to rebind_required
3112
- // (results.rs matches channel or Blocked → 'rebind_required').
3113
- assert!(
3114
- outcome.channel.as_deref() == Some("rebind_required")
3115
- || matches!(outcome.status, DeliveryStatus::Blocked),
3116
- "0.5.5 gate054: cross-boundary refusal must surface as rebind_required, got outcome={outcome:?}"
3117
- );
3118
- // Audit noise: fallback_pane_attempt + fallback_pane_failed with the
3119
- // recorded socket_bound=true forensic field.
3120
- let events = log.tail(0).unwrap();
3121
- let attempt = events.iter().find(|e| {
3122
- e.get("event").and_then(serde_json::Value::as_str)
3123
- == Some("leader_receiver.fallback_pane_attempt")
3124
- });
3125
- assert!(
3126
- attempt.is_some(),
3127
- "fallback_pane_attempt audit must fire even on socket-bounded refusal; events={events:?}"
3128
- );
3129
- let failed = events.iter().find(|e| {
3130
- e.get("event").and_then(serde_json::Value::as_str)
3131
- == Some("leader_receiver.fallback_pane_failed")
3132
- });
3133
- assert!(
3134
- failed.is_some(),
3135
- "fallback_pane_failed audit must fire when the recorded socket rejects inject; events={events:?}"
3136
- );
3137
- assert_eq!(
3138
- failed
3139
- .and_then(|e| e.get("socket_bound"))
3140
- .and_then(serde_json::Value::as_bool),
3141
- Some(true),
3142
- "socket_bound forensic field must record the boundary state"
3143
- );
3144
- }
3145
-
3146
- #[test]
3147
- fn gate054_rebind_replay_requeues_failed_leader_message_on_attach() {
3148
- // Round-2 real-machine shape: direct report_result → primary refused with
3149
- // rebind_required → row is `status=failed, error=leader_not_attached`.
3150
- // `attach-leader` must requeue it back to `status=accepted` so the
3151
- // coordinator tick's `deliver_pending_messages` replays it to the new
3152
- // leader pane. Same message_id — no second replay mechanism, no new
3153
- // watcher, exactly-once via leader_notification_log PK.
3154
- use crate::model::ids::TeamKey;
3155
- let ws = tmp_ws("gate054replay");
3156
- let store = store_for(&ws);
3157
- let log = EventLog::new(&ws);
3158
- let team_id = "gate055r2b";
3159
-
3160
- // Seed the same shape the primary-path refusal leaves behind.
3161
- let message_id = store
3162
- .create_message(
3163
- None,
3164
- "probe-worker",
3165
- "leader",
3166
- "B2_NOTIFY report_result payload",
3167
- None,
3168
- false,
3169
- Some(team_id),
3170
- )
3171
- .unwrap();
3172
- store
3173
- .mark(&message_id, "failed", Some("leader_not_attached"))
3174
- .unwrap();
3175
- // Sanity: precondition matches acceptance evidence.
3176
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
3177
- let (status_before, error_before): (String, Option<String>) = conn
3178
- .query_row(
3179
- "select status, error from messages where message_id = ?1",
3180
- [&message_id],
3181
- |r| Ok((r.get(0)?, r.get(1)?)),
3182
- )
3183
- .unwrap();
3184
- assert_eq!(status_before, "failed");
3185
- assert_eq!(error_before.as_deref(), Some("leader_not_attached"));
3186
-
3187
- // The attach-leader path calls requeue_delivery_exhausted_watchers with
3188
- // the newly-claimed pane. Even with NO exhausted watchers to requeue,
3189
- // it must flip the blocked leader row back to accepted.
3190
- let team = TeamKey::new(team_id);
3191
- let new_pane = PaneId::new("%1"); // new leader window on the private socket
3192
- let notices =
3193
- crate::messaging::requeue_delivery_exhausted_watchers(&ws, &store, &log, &team, &new_pane)
3194
- .unwrap();
3195
- assert!(
3196
- notices.is_empty(),
3197
- "no exhausted watchers seeded → no watcher notices; only the message row should have been requeued"
3198
- );
3199
-
3200
- let (status_after, error_after): (String, Option<String>) = conn
3201
- .query_row(
3202
- "select status, error from messages where message_id = ?1",
3203
- [&message_id],
3204
- |r| Ok((r.get(0)?, r.get(1)?)),
3205
- )
3206
- .unwrap();
3207
- assert_eq!(
3208
- status_after, "accepted",
3209
- "gate054 round-2: rebind_required leader row must flip back to 'accepted' on attach-leader"
3210
- );
3211
- assert!(
3212
- error_after.is_none(),
3213
- "gate054 round-2: error must be cleared on requeue so deliver_pending_message replays cleanly"
3214
- );
3215
-
3216
- // Audit noise: leader_receiver.blocked_messages_requeued fired with the
3217
- // exact team + claimed pane + count for status/monitor observability.
3218
- let events = log.tail(0).unwrap();
3219
- let requeued = events.iter().find(|e| {
3220
- e.get("event").and_then(serde_json::Value::as_str)
3221
- == Some("leader_receiver.blocked_messages_requeued")
3222
- });
3223
- assert!(
3224
- requeued.is_some(),
3225
- "attach-leader requeue of blocked leader messages must audit; events={events:?}"
3226
- );
3227
- assert_eq!(
3228
- requeued
3229
- .and_then(|e| e.get("count"))
3230
- .and_then(serde_json::Value::as_u64),
3231
- Some(1)
3232
- );
3233
- assert_eq!(
3234
- requeued
3235
- .and_then(|e| e.get("team_id"))
3236
- .and_then(serde_json::Value::as_str),
3237
- Some(team_id)
3238
- );
3239
- }
3240
-
3241
- #[test]
3242
- fn claim_preserves_pending_acceptance_for_all_recipients() {
3243
- let ws = tmp_ws("claim-pending-acceptance");
3244
- let store = store_for(&ws);
3245
- let log = EventLog::new(&ws);
3246
- let team_id = "mailbox-team";
3247
- let leader_message = store
3248
- .create_message(
3249
- None,
3250
- "worker",
3251
- "leader",
3252
- "leader canary",
3253
- None,
3254
- false,
3255
- Some(team_id),
3256
- )
3257
- .unwrap();
3258
- let worker_message = store
3259
- .create_message(
3260
- None,
3261
- "worker",
3262
- "worker-b",
3263
- "worker canary",
3264
- None,
3265
- false,
3266
- Some(team_id),
3267
- )
3268
- .unwrap();
3269
- let conn = crate::db::schema::open_db(store.db_path()).unwrap();
3270
- for message_id in [&leader_message, &worker_message] {
3271
- conn.execute(
3272
- "update messages set status = 'submitted_pending_acceptance' where message_id = ?1",
3273
- [message_id],
3274
- )
3275
- .unwrap();
3276
- }
3277
-
3278
- let team = TeamKey::new(team_id);
3279
- let pane = PaneId::new("%leader");
3280
- requeue_after_claim_leader(&ws, &store, &log, &team, &pane, None).unwrap();
3281
-
3282
- let row = |message_id: &str| {
3283
- conn.query_row(
3284
- "select status, delivered_at, error from messages where message_id = ?1",
3285
- [message_id],
3286
- |row| {
3287
- Ok((
3288
- row.get::<_, String>(0)?,
3289
- row.get::<_, Option<String>>(1)?,
3290
- row.get::<_, Option<String>>(2)?,
3291
- ))
3292
- },
3293
- )
3294
- .unwrap()
3295
- };
3296
- assert_eq!(
3297
- row(&leader_message),
3298
- (
3299
- "submitted_pending_acceptance".to_string(),
3300
- None,
3301
- None
3302
- )
3303
- );
3304
- assert_eq!(
3305
- row(&worker_message),
3306
- (
3307
- "submitted_pending_acceptance".to_string(),
3308
- None,
3309
- None
3310
- )
3311
- );
3312
- }
3313
-
3314
- #[test]
3315
- fn gate054_status_surfaces_pending_leader_notifications() {
3316
- // Round-2: user-facing visibility — status must show the blocked leader
3317
- // notification as pending, not just as `messages.failed=1`.
3318
- use crate::cli::status_port::status_scoped;
3319
- let ws = tmp_ws("gate054status");
3320
- let store = store_for(&ws);
3321
- let team_id = "gate055r2b";
3322
-
3323
- let message_id = store
3324
- .create_message(
3325
- None,
3326
- "probe-worker",
3327
- "leader",
3328
- "B2_NOTIFY report_result payload",
3329
- None,
3330
- false,
3331
- Some(team_id),
3332
- )
3333
- .unwrap();
3334
- store
3335
- .mark(&message_id, "failed", Some("leader_not_attached"))
3336
- .unwrap();
3337
-
3338
- // Minimal runtime state so status can render.
3339
- let state = serde_json::json!({
3340
- "session_name": format!("team-{team_id}"),
3341
- "active_team_key": team_id,
3342
- "teams": {team_id: {"team_key": team_id}},
3343
- "leader_receiver": {
3344
- "pane_id": "%1",
3345
- "status": "rebind_required",
3346
- }
3347
- });
3348
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
3349
-
3350
- let payload = status_scoped(&ws, &state, Some(team_id), false, false).unwrap();
3351
- let pending = payload
3352
- .get("pending_leader_notifications")
3353
- .and_then(serde_json::Value::as_array)
3354
- .expect("status must expose pending_leader_notifications as an array");
3355
- assert_eq!(
3356
- pending.len(),
3357
- 1,
3358
- "the blocked leader message must appear in pending_leader_notifications"
3359
- );
3360
- let entry = &pending[0];
3361
- assert_eq!(
3362
- entry.get("message_id").and_then(serde_json::Value::as_str),
3363
- Some(message_id.as_str())
3364
- );
3365
- assert_eq!(
3366
- entry.get("channel").and_then(serde_json::Value::as_str),
3367
- Some("rebind_required")
3368
- );
3369
- let action = entry
3370
- .get("action")
3371
- .and_then(serde_json::Value::as_str)
3372
- .unwrap_or("");
3373
- assert!(
3374
- action.contains("historical leader mailbox debt"),
3375
- "historical debt action must stay debt-scoped; action={action}"
3376
- );
3377
- assert!(
3378
- !action.contains("attach-leader") && !action.contains("takeover") && !action.contains("claim-leader"),
3379
- "historical debt must not authorize bind commands; action={action}"
3380
- );
3381
- }
3382
-
3383
- #[test]
3384
- fn gate054_fallback_pane_grep_guard_no_cross_server_chain_when_socket_recorded() {
3385
- // Structural grep: the recorded-socket transport set must contain only
3386
- // the endpoint backend, while workspace/default transports remain in the
3387
- // no-socket arm. Physical injection must consume the pane returned by the
3388
- // shared resolver rather than rebuilding a target from state.
3389
- let src = include_str!("../leader_receiver.rs");
3390
- let transports_start = src
3391
- .find("let transports: Vec<Box<dyn Transport>>")
3392
- .expect("fallback transport set must remain explicit");
3393
- let transports_end = src[transports_start..]
3394
- .find("let mut resolved")
3395
- .map(|off| transports_start + off)
3396
- .expect("transport selection must precede shared resolution");
3397
- let transports = &src[transports_start..transports_end];
3398
- let socket_arm_start = transports
3399
- .find("Some(socket) =>")
3400
- .expect("recorded-socket arm");
3401
- let socket_arm_end = transports[socket_arm_start..]
3402
- .find("None =>")
3403
- .map(|off| socket_arm_start + off)
3404
- .expect("no-socket arm must follow");
3405
- let socket_arm = &transports[socket_arm_start..socket_arm_end];
3406
- assert!(
3407
- socket_arm.contains("tmux_endpoint_transport")
3408
- && !socket_arm.contains("tmux_workspace_transport")
3409
- && !socket_arm.contains("tmux_default_transport"),
3410
- "0.5.5 gate054: socket-recorded fallback arm must remain endpoint-only; arm={socket_arm}"
3411
- );
3412
- let no_socket_arm = &transports[socket_arm_end..];
3413
- assert!(
3414
- no_socket_arm.contains("tmux_workspace_transport")
3415
- && no_socket_arm.contains("tmux_default_transport"),
3416
- "0.5.5 gate054: workspace/default transports belong only to the no-socket arm; arm={no_socket_arm}"
3417
- );
3418
- assert!(
3419
- src.contains("let target = Target::Pane(PaneId::new(channel.pane_id));"),
3420
- "fallback injection must consume the shared resolver's typed channel"
3421
- );
3422
- }
3423
-
3424
- fn delivery_blocked_channel_reasons(ws: &std::path::Path) -> Vec<String> {
3425
- EventLog::new(ws)
3426
- .tail(80)
3427
- .unwrap()
3428
- .into_iter()
3429
- .filter(|event| event.get("event") == Some(&serde_json::json!("leader_receiver.delivery_blocked")))
3430
- .filter_map(|event| {
3431
- event
3432
- .get("channel_reason")
3433
- .and_then(serde_json::Value::as_str)
3434
- .map(str::to_string)
3435
- })
3436
- .collect()
3437
- }
3438
-
3439
- fn live_leader_pane(ws: &std::path::Path, pane_id: &str) -> PaneInfo {
3440
- let mut pane = pane_info(pane_id, "team-current", "leader");
3441
- pane.current_path = Some(ws.to_path_buf());
3442
- pane
3443
- }
3444
-
3445
- #[test]
3446
- fn owner_projection_null_fallback_projects_nested_current_receiver() {
3447
- let ws = tmp_ws("proj-null-current");
3448
- let state = serde_json::json!({
3449
- "active_team_key": "current",
3450
- "team_key": "current",
3451
- "teams": {
3452
- "current": {
3453
- "team_key": "current",
3454
- "leader_receiver": {
3455
- "status": "attached",
3456
- "mode": "direct_tmux",
3457
- "pane_id": "%9"
3458
- },
3459
- "agents": {}
3460
- }
3461
- },
3462
- "agents": {}
3463
- });
3464
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
3465
- let store = store_for(&ws);
3466
- let log = EventLog::new(&ws);
3467
- let message_id = store
3468
- .create_message(None, "w1", "leader", "nested current", None, false, Some("current"))
3469
- .unwrap();
3470
- let transport = OfflineTransport::new().with_targets(vec![live_leader_pane(&ws, "%9")]);
3471
-
3472
- let out = deliver_pending_message(&ws, &store, &transport, &message_id, &log, &serde_json::json!({}))
3473
- .unwrap();
3474
-
3475
- assert!(
3476
- !delivery_blocked_channel_reasons(&ws)
3477
- .iter()
3478
- .any(|reason| reason == "receiver_missing"),
3479
- "fresh Null fallback must project teams.current, not return Null; out={out:?} reasons={:?}",
3480
- delivery_blocked_channel_reasons(&ws)
3481
- );
3482
- assert_eq!(
3483
- transport.inject_targets(),
3484
- vec![Target::Pane(PaneId::new("%9"))],
3485
- "nested current receiver must select pane %9; out={out:?}"
3486
- );
3487
- }
3488
-
3489
- #[test]
3490
- fn owner_projection_non_object_does_not_match_current() {
3491
- assert!(
3492
- !crate::messaging::delivery::top_level_state_matches_owner_team(
3493
- &serde_json::Value::Null,
3494
- "current"
3495
- ),
3496
- "Null must not match current through team_state_key default"
3497
- );
3498
- assert!(
3499
- !crate::messaging::delivery::top_level_state_matches_owner_team(
3500
- &serde_json::json!([]),
3501
- "current"
3502
- ),
3503
- "non-object must not match current"
3504
- );
3505
- }
3506
-
3507
- #[test]
3508
- fn owner_projection_legacy_top_level_receiver_survives_null_fallback() {
3509
- let ws = tmp_ws("proj-legacy-top");
3510
- let state = serde_json::json!({
3511
- "active_team_key": "current",
3512
- "leader_receiver": {
3513
- "status": "attached",
3514
- "mode": "direct_tmux",
3515
- "pane_id": "%3"
3516
- },
3517
- "agents": {}
3518
- });
3519
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
3520
- let store = store_for(&ws);
3521
- let log = EventLog::new(&ws);
3522
- let message_id = store
3523
- .create_message(None, "w1", "leader", "legacy top", None, false, Some("current"))
3524
- .unwrap();
3525
- let transport = OfflineTransport::new().with_targets(vec![live_leader_pane(&ws, "%3")]);
3526
-
3527
- let out = deliver_pending_message(&ws, &store, &transport, &message_id, &log, &serde_json::json!({}))
3528
- .unwrap();
3529
-
3530
- assert!(
3531
- !delivery_blocked_channel_reasons(&ws)
3532
- .iter()
3533
- .any(|reason| reason == "receiver_missing"),
3534
- "legacy top-level receiver must remain usable; out={out:?}"
3535
- );
3536
- assert_eq!(
3537
- transport.inject_targets(),
3538
- vec![Target::Pane(PaneId::new("%3"))],
3539
- "legacy top-level receiver must select pane %3; out={out:?}"
3540
- );
3541
- }
3542
-
3543
- #[test]
3544
- fn owner_projection_missing_selected_does_not_borrow_sibling() {
3545
- let ws = tmp_ws("proj-no-sibling");
3546
- let state = serde_json::json!({
3547
- "active_team_key": "alpha",
3548
- "team_key": "alpha",
3549
- "teams": {
3550
- "alpha": {
3551
- "team_key": "alpha",
3552
- "agents": {}
3553
- },
3554
- "beta": {
3555
- "team_key": "beta",
3556
- "leader_receiver": {
3557
- "status": "attached",
3558
- "mode": "direct_tmux",
3559
- "pane_id": "%beta"
3560
- },
3561
- "agents": {}
3562
- }
3563
- },
3564
- "agents": {}
3565
- });
3566
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
3567
- let store = store_for(&ws);
3568
- let log = EventLog::new(&ws);
3569
- let message_id = store
3570
- .create_message(None, "w1", "leader", "alpha has no receiver", None, false, Some("alpha"))
3571
- .unwrap();
3572
- let transport = OfflineTransport::new().with_targets(vec![live_leader_pane(&ws, "%beta")]);
3573
-
3574
- let out = deliver_pending_message(&ws, &store, &transport, &message_id, &log, &serde_json::json!({}))
3575
- .unwrap();
3576
-
3577
- assert!(
3578
- delivery_blocked_channel_reasons(&ws)
3579
- .iter()
3580
- .any(|reason| reason == "receiver_missing"),
3581
- "alpha must not borrow beta's receiver; out={out:?} reasons={:?}",
3582
- delivery_blocked_channel_reasons(&ws)
3583
- );
3584
- assert_eq!(transport.inject_targets().len(), 0, "must not inject into the sibling pane");
3585
- }
3586
-
3587
- #[test]
3588
- fn owner_projection_peer_inject_uses_nested_worker_pane_not_top_level() {
3589
- let ws = tmp_ws("proj-peer-nested");
3590
- let state = serde_json::json!({
3591
- "active_team_key": "teamA",
3592
- "session_name": "team-top",
3593
- "agents": {
3594
- "worker_b": {
3595
- "provider": "fake",
3596
- "status": "running",
3597
- "window": "worker_b",
3598
- "pane_id": "%top-b"
3599
- }
3600
- },
3601
- "teams": {
3602
- "teamA": {
3603
- "session_name": "team-nested",
3604
- "agents": {
3605
- "worker_b": {
3606
- "provider": "fake",
3607
- "status": "running",
3608
- "window": "worker_b",
3609
- "pane_id": "%nested-b"
3610
- }
3611
- }
3612
- }
3613
- }
3614
- });
3615
- crate::state::persist::save_runtime_state(&ws, &state).unwrap();
3616
- let store = store_for(&ws);
3617
- let log = EventLog::new(&ws);
3618
- let message_id = store
3619
- .create_message(
3620
- None,
3621
- "worker_a",
3622
- "worker_b",
3623
- "MCP_SIM_BROADCAST_CANARY",
3624
- None,
3625
- false,
3626
- Some("teamA"),
3627
- )
3628
- .unwrap();
3629
- let transport = OfflineTransport::new().with_targets(vec![
3630
- pane_info("%top-b", "team-top", "worker_b"),
3631
- pane_info("%nested-b", "team-nested", "worker_b"),
3632
- ]);
3633
-
3634
- let out = deliver_pending_message(
3635
- &ws,
3636
- &store,
3637
- &transport,
3638
- &message_id,
3639
- &log,
3640
- &serde_json::json!({}),
3641
- )
3642
- .unwrap();
3643
-
3644
- let targets = transport.inject_targets();
3645
- assert!(
3646
- !targets.is_empty(),
3647
- "owner teamA peer inject must attempt the nested worker pane; out={out:?}"
3648
- );
3649
- assert!(
3650
- targets
3651
- .iter()
3652
- .all(|target| target == &Target::Pane(PaneId::new("%nested-b"))),
3653
- "owner teamA peer inject must select nested worker pane %nested-b, not top-level %top-b; out={out:?} targets={targets:?}"
3654
- );
3655
- }