@team-agent/installer 0.5.127 → 0.5.128

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (145) hide show
  1. package/Cargo.lock +1 -1
  2. package/Cargo.toml +1 -1
  3. package/README.md +11 -0
  4. package/crates/team-agent/src/cli/adapters.rs +3 -13
  5. package/crates/team-agent/src/cli/arguments.rs +4 -0
  6. package/crates/team-agent/src/cli/diagnose.rs +68 -22
  7. package/crates/team-agent/src/cli/emit.rs +58 -26
  8. package/crates/team-agent/src/cli/intent/runtime.rs +32 -5
  9. package/crates/team-agent/src/cli/intent/runtime_tests.rs +102 -11
  10. package/crates/team-agent/src/cli/intent/tests.rs +10 -12
  11. package/crates/team-agent/src/cli/intent.rs +1 -1
  12. package/crates/team-agent/src/cli/mod.rs +25 -8
  13. package/crates/team-agent/src/cli/models.rs +764 -7
  14. package/crates/team-agent/src/cli/schedule.rs +175 -0
  15. package/crates/team-agent/src/cli/send/persist.rs +0 -36
  16. package/crates/team-agent/src/cli/send/presentation.rs +1 -1
  17. package/crates/team-agent/src/cli/send.rs +108 -110
  18. package/crates/team-agent/src/cli/spec.rs +6 -0
  19. package/crates/team-agent/src/cli/status_port/brief.rs +5 -67
  20. package/crates/team-agent/src/cli/tests/leader_watch.rs +12 -62
  21. package/crates/team-agent/src/cli/tests/mod.rs +1 -1
  22. package/crates/team-agent/src/cli/tests/named_address.rs +11 -10
  23. package/crates/team-agent/src/cli/tests/run_delegation.rs +9 -6
  24. package/crates/team-agent/src/cli/tests/status_send.rs +68 -271
  25. package/crates/team-agent/src/compiler/tests.rs +3 -18
  26. package/crates/team-agent/src/compiler.rs +205 -6
  27. package/crates/team-agent/src/contract_runtime/backend.rs +145 -11
  28. package/crates/team-agent/src/contract_runtime/commands.rs +7 -7
  29. package/crates/team-agent/src/contract_runtime/config.rs +26 -16
  30. package/crates/team-agent/src/contract_runtime/config_tests.rs +24 -4
  31. package/crates/team-agent/src/contract_runtime/discovery.rs +12 -1
  32. package/crates/team-agent/src/contract_runtime/fork.rs +3 -10
  33. package/crates/team-agent/src/contract_runtime/framework.rs +28 -11
  34. package/crates/team-agent/src/contract_runtime/mcp.rs +19 -24
  35. package/crates/team-agent/src/contract_runtime/prompt.rs +2 -2
  36. package/crates/team-agent/src/contract_runtime/registry.rs +56 -92
  37. package/crates/team-agent/src/coordinator/steps/abnormal.rs +11 -11
  38. package/crates/team-agent/src/coordinator/tests/api_error_recovery.rs +16 -54
  39. package/crates/team-agent/src/coordinator/tests/health_sync.rs +42 -0
  40. package/crates/team-agent/src/coordinator/tick.rs +1 -89
  41. package/crates/team-agent/src/db/message_store.rs +7 -65
  42. package/crates/team-agent/src/direct_delivery.rs +368 -0
  43. package/crates/team-agent/src/inbox_store.rs +169 -0
  44. package/crates/team-agent/src/leader/registry.rs +5 -0
  45. package/crates/team-agent/src/leader/start.rs +2 -1
  46. package/crates/team-agent/src/leader/tests/lease_api.rs +2 -2
  47. package/crates/team-agent/src/leader/tests/prompt_contract.rs +1 -0
  48. package/crates/team-agent/src/lib.rs +2 -0
  49. package/crates/team-agent/src/lifecycle/launch/add_agent.rs +33 -0
  50. package/crates/team-agent/src/lifecycle/launch/add_agent_state.rs +206 -1
  51. package/crates/team-agent/src/lifecycle/launch/clone_agent.rs +28 -2
  52. package/crates/team-agent/src/lifecycle/launch/fork_agent.rs +38 -13
  53. package/crates/team-agent/src/lifecycle/launch/fork_entry.rs +87 -6
  54. package/crates/team-agent/src/lifecycle/launch/mcp_config.rs +9 -1
  55. package/crates/team-agent/src/lifecycle/launch/pi_mcp.rs +351 -81
  56. package/crates/team-agent/src/lifecycle/launch/pi_mcp_extension.js +3 -4
  57. package/crates/team-agent/src/lifecycle/launch/quick_start.rs +24 -0
  58. package/crates/team-agent/src/lifecycle/launch/spawn.rs +36 -13
  59. package/crates/team-agent/src/lifecycle/launch.rs +24 -1
  60. package/crates/team-agent/src/lifecycle/profile_launch.rs +321 -11
  61. package/crates/team-agent/src/lifecycle/restart/agent.rs +1 -0
  62. package/crates/team-agent/src/lifecycle/restart/avatar.rs +1798 -0
  63. package/crates/team-agent/src/lifecycle/restart/claude_fork.rs +163 -0
  64. package/crates/team-agent/src/lifecycle/restart/common.rs +345 -35
  65. package/crates/team-agent/src/lifecycle/restart/selection.rs +5 -5
  66. package/crates/team-agent/src/lifecycle/restart.rs +4 -0
  67. package/crates/team-agent/src/lifecycle/role_config.rs +39 -14
  68. package/crates/team-agent/src/lifecycle/tests/claude_compatible_config_red.rs +325 -0
  69. package/crates/team-agent/src/lifecycle/tests/claude_profile_launch_red.rs +320 -8
  70. package/crates/team-agent/src/lifecycle/tests/cli_argv_routing_red.rs +236 -13
  71. package/crates/team-agent/src/lifecycle/tests/clone_fork_copilot_perms_red.rs +378 -4
  72. package/crates/team-agent/src/lifecycle/tests/communication_mode_runtime_contract_red.rs +5 -4
  73. package/crates/team-agent/src/lifecycle/tests/copilot_provider_red.rs +7 -11
  74. package/crates/team-agent/src/lifecycle/tests/core.rs +47 -18
  75. package/crates/team-agent/src/lifecycle/tests/fixtures/pi_native_mcp_host.mjs +2 -1
  76. package/crates/team-agent/src/lifecycle/tests/grok_require_explicit_model_red.rs +14 -14
  77. package/crates/team-agent/src/lifecycle/tests/harvest2_a_batch_red.rs +60 -20
  78. package/crates/team-agent/src/lifecycle/tests/launch_spawn.rs +28 -26
  79. package/crates/team-agent/src/lifecycle/tests/mcp_tool_name_format_red.rs +6 -6
  80. package/crates/team-agent/src/lifecycle/tests/pi_catalog_red.rs +18 -6
  81. package/crates/team-agent/src/lifecycle/tests/pi_command_red.rs +70 -52
  82. package/crates/team-agent/src/lifecycle/tests/pi_compiler_red.rs +210 -0
  83. package/crates/team-agent/src/lifecycle/tests/pi_dual_entry_red.rs +157 -4
  84. package/crates/team-agent/src/lifecycle/tests/pi_executable_mcp_red.rs +526 -10
  85. package/crates/team-agent/src/lifecycle/tests/pi_fork_session_inheritance_red.rs +1419 -0
  86. package/crates/team-agent/src/lifecycle/tests/pi_lifecycle_doctor_red.rs +68 -1
  87. package/crates/team-agent/src/lifecycle/tests/pi_native_mcp_capability_red.rs +34 -12
  88. package/crates/team-agent/src/lifecycle/tests/pi_session_delivery_red.rs +94 -2
  89. package/crates/team-agent/src/lifecycle/tests/quick_start_worker_readiness_red.rs +10 -11
  90. package/crates/team-agent/src/lifecycle/tests/status_credential_redaction_contract.rs +2 -2
  91. package/crates/team-agent/src/lifecycle/tests/swallow_batch4_semantics_red.rs +254 -2
  92. package/crates/team-agent/src/lifecycle/tests/upgrade_compat_0211_red.rs +4 -4
  93. package/crates/team-agent/src/lifecycle/tests/verify_rs031_window_consistency_red.rs +5 -6
  94. package/crates/team-agent/src/lifecycle/tests/worker_spawn_env_red.rs +16 -7
  95. package/crates/team-agent/src/lifecycle/tests.rs +3 -0
  96. package/crates/team-agent/src/lifecycle/types.rs +18 -2
  97. package/crates/team-agent/src/lifecycle/worker_command_context.rs +43 -50
  98. package/crates/team-agent/src/mcp_server/readiness.rs +130 -149
  99. package/crates/team-agent/src/mcp_server/readiness_tests.rs +98 -119
  100. package/crates/team-agent/src/mcp_server/tests/scoped.rs +21 -31
  101. package/crates/team-agent/src/mcp_server/tests/send.rs +72 -107
  102. package/crates/team-agent/src/mcp_server/tests/tools.rs +10 -12
  103. package/crates/team-agent/src/mcp_server/tools.rs +70 -196
  104. package/crates/team-agent/src/messaging/delivery.rs +160 -218
  105. package/crates/team-agent/src/messaging/delivery_consumption_tests.rs +5 -5
  106. package/crates/team-agent/src/messaging/helpers.rs +1 -19
  107. package/crates/team-agent/src/messaging/mod.rs +1 -0
  108. package/crates/team-agent/src/messaging/reminders.rs +316 -0
  109. package/crates/team-agent/src/messaging/scheduler.rs +7 -1
  110. package/crates/team-agent/src/messaging/tests/dup_inject.rs +191 -85
  111. package/crates/team-agent/src/messaging/tests/runtime.rs +4 -110
  112. package/crates/team-agent/src/messaging/tests/spine.rs +40 -24
  113. package/crates/team-agent/src/messaging/types.rs +1 -0
  114. package/crates/team-agent/src/provider/adapter.rs +303 -51
  115. package/crates/team-agent/src/provider/adapters/claude.rs +78 -0
  116. package/crates/team-agent/src/provider/adapters/claude_fork.rs +131 -0
  117. package/crates/team-agent/src/provider/adapters/mod.rs +7 -5
  118. package/crates/team-agent/src/provider/adapters/pi.rs +106 -0
  119. package/crates/team-agent/src/provider/classify.rs +1 -66
  120. package/crates/team-agent/src/provider/model_catalog.rs +201 -13
  121. package/crates/team-agent/src/provider/session/capture.rs +106 -6
  122. package/crates/team-agent/src/provider/session/context_fork/claude.rs +123 -0
  123. package/crates/team-agent/src/provider/session/context_fork/outcome.rs +4 -0
  124. package/crates/team-agent/src/provider/session/context_fork.rs +150 -18
  125. package/crates/team-agent/src/provider/session_scan/claude.rs +523 -0
  126. package/crates/team-agent/src/provider/session_scan/common.rs +44 -8
  127. package/crates/team-agent/src/provider/session_scan/pi.rs +34 -1
  128. package/crates/team-agent/src/provider/session_scan.rs +16 -6
  129. package/crates/team-agent/src/provider/tests/adapter.rs +104 -17
  130. package/crates/team-agent/src/provider/tests/classify.rs +0 -53
  131. package/crates/team-agent/src/provider/tests/command_helpers.rs +12 -3
  132. package/crates/team-agent/src/provider/tests/idle.rs +37 -0
  133. package/crates/team-agent/src/provider/wire.rs +22 -34
  134. package/crates/team-agent/src/state/abnormal_watch/tests/mod.rs +1 -1
  135. package/crates/team-agent/src/state/persist.rs +6 -6
  136. package/crates/team-agent/src/state/projection.rs +1 -1
  137. package/crates/team-agent/src/state/repository/tests.rs +2 -2
  138. package/crates/team-agent/src/test_support/models_timeout_fixture.rs +144 -0
  139. package/crates/team-agent/src/tmux_backend/tests.rs +0 -151
  140. package/crates/team-agent/src/tmux_backend.rs +5 -40
  141. package/package.json +4 -4
  142. package/skills/team-agent/SKILL.md +5 -7
  143. package/skills/team-agent/command-coverage.json +1 -1
  144. package/skills/team-agent/docs/reference/team-agent-operator.md +3 -3
  145. package/skills/team-agent/references/team-agent-operator.md +3 -3
@@ -540,7 +540,7 @@ fn send_args_fixture() -> SendArgs {
540
540
  confirm_human: false,
541
541
  json: false,
542
542
  message_id: None,
543
- presentation: crate::messaging::presentation::PresentationRequest::default(),
543
+ presentation: crate::messaging::presentation::PresentationRequest { sink: crate::messaging::presentation::PresentationSink::Silent, ..Default::default() },
544
544
  pane: None,
545
545
  to_name: None,
546
546
  to_leader: None,
@@ -625,194 +625,74 @@ fn send_options_default_flags_are_acked_and_waited() {
625
625
 
626
626
  #[test]
627
627
  fn cmd_send_joins_message_with_single_space() {
628
- // golden (commands.py:169): " ".join(["hello","world","foo"]) == "hello world foo".
629
- // Drive cmd_send; the joined content must reach send_message (RED until ported).
630
- let args = SendArgs {
631
- json: true,
632
- ..send_args_fixture()
633
- };
634
- let r = cmd_send(&args).expect("cmd_send returns CmdResult");
635
- // The delegate's DeliveryOutcome -> Json must carry an `ok` key feeding exit-code.
636
- match r.output {
637
- CmdOutput::Json(ref v) => {
638
- assert!(v.get("ok").is_some(), "send result Json must carry `ok`");
639
- if v.get("ok").and_then(|ok| ok.as_bool()) == Some(true) {
640
- let delivered = v.get("delivered").and_then(|x| x.as_bool()) == Some(true);
641
- // hermetic tier 假设:此 fixture 无法产生真实 tmux Delivered。
642
- // 若 delivered=true 命中说明 tier 前提变了(例如 seed 开了 Delivered 通路),
643
- // 应立即失败以强制重新审视,而不是悄悄跑一条从未验过的分支。
644
- assert!(
645
- !delivered,
646
- "hermetic seed must not produce delivered=true; the fixture assumption changed"
647
- );
648
- assert_eq!(
649
- v.get("reminder").and_then(|reminder| reminder.as_str()),
650
- Some("Task accepted, but delivery is unconfirmed. Check team-agent status/doctor; wait for an actual reply without repeated sends.")
651
- );
652
- }
653
- }
654
- other => panic!("cmd_send must emit Json DeliveryOutcome, got {other:?}"),
655
- }
628
+ let args = send_args_fixture();
629
+ let result = cmd_send(&args).expect("mailbox append");
630
+ assert_eq!(result.exit, ExitCode::Ok);
631
+ let inbox = crate::inbox_store::read(&args.workspace, "alice", 3, None).unwrap();
632
+ assert_eq!(inbox["messages"][0]["content"], "hello world foo");
633
+ assert_eq!(inbox["messages"][0]["sender"], "leader");
634
+ let conn = rusqlite::Connection::open(args.workspace.join(".team/runtime/team.db")).unwrap();
635
+ let count: i64 = conn.query_row("SELECT count(*) FROM messages", [], |row| row.get(0)).unwrap();
636
+ assert_eq!(count, 0, "public send must not enter the coordinator queue");
656
637
  }
657
638
 
658
639
  #[test]
659
- fn cmd_send_default_human_output_is_brief_without_false_delivered() {
660
- let r = cmd_send(&queued_send_args_fixture(false)).expect("cmd_send returns CmdResult");
661
- assert!(!r.as_json);
662
- let text = emit(&r.output, r.as_json).expect("send should render human text");
663
- let lines: Vec<_> = text.lines().collect();
664
- assert_eq!(
665
- lines.len(),
666
- 2,
667
- "send must separate outcome and next action: {text}"
668
- );
669
- assert!(
670
- lines[0].contains("Task accepted") && lines[0].contains("delivery to the agent's conversation is still pending"),
671
- "queued send must report its true pending outcome: {text}"
672
- );
673
- assert!(
674
- lines[1].contains("Next:")
675
- && lines[1].contains("team-agent status")
676
- && lines[1].contains("doctor")
677
- && lines[1].contains("wait for an actual reply")
678
- && lines[1].contains("without repeated sends"),
679
- "queued send must give honest next steps: {text}"
680
- );
681
- assert!(
682
- !text.contains("delivered"),
683
- "queued send output must not claim or mention delivered; got {text}"
684
- );
685
- for hidden in [
686
- "agent_id:",
687
- "sender:",
688
- "message_status:",
689
- "verification:",
690
- "stage:",
691
- "reason:",
692
- "channel:",
693
- "reminder:",
694
- ] {
695
- // 字段级匹配,⛔ 不用裸 contains:人类输出以 " " 连接 `"{key}: {value}"`
696
- // (send/presentation.rs 的 `parts.join(" ")` / `send_human_field`),
697
- // 所以一个字段只可能出现在行首或某个空格之后。裸子串会让
698
- // `turn_verification:` 误命中名单里的 `verification:`(该键由 ab2134c0
699
- // 有意加进人类输出名单)——那是判据误伤,不是产品缺陷。
700
- let present = text.starts_with(hidden) || text.contains(&format!(" {hidden}"));
701
- assert!(
702
- !present,
703
- "default send output should hide {hidden} unless needed; got {text}"
704
- );
705
- }
640
+ fn cmd_send_mailbox_output_names_storage_without_claiming_delivery() {
641
+ let args = queued_send_args_fixture(false);
642
+ let result = cmd_send(&args).expect("mailbox append without a live pane");
643
+ let text = emit(&result.output, result.as_json).unwrap();
644
+ assert!(text.contains("stored") && text.contains("w1"), "{text}");
645
+ assert!(!text.contains("Delivered") && !text.contains("parked") && !text.contains("still pending"), "{text}");
706
646
  }
707
647
 
708
648
  #[test]
709
649
  #[cfg(unix)]
710
- fn issue372_queued_send_names_the_mcp_handshake_it_waits_on() {
711
- let r = cmd_send(&queued_send_args_fixture(true)).expect("cmd_send returns CmdResult");
712
- let CmdOutput::Json(v) = r.output else {
713
- panic!("--json send must emit Json");
714
- };
715
- assert_eq!(v["deferred_reason"], json!("mcp_handshake_config_missing"), "{v}");
716
- let r = cmd_send(&queued_send_args_fixture(false)).expect("cmd_send returns CmdResult");
717
- let text = emit(&r.output, r.as_json).expect("send should render human text");
718
- assert!(
719
- text.contains("w1's MCP server has not completed its handshake (mcp_handshake_config_missing)")
720
- && text.contains("after 5 minutes the message is parked"),
721
- "{text}"
722
- );
650
+ fn issue372_send_never_reports_a_handshake_parking_gate() {
651
+ let args = queued_send_args_fixture(true);
652
+ let result = cmd_send(&args).unwrap();
653
+ let CmdOutput::Json(value) = result.output else { panic!("JSON result expected") };
654
+ assert_eq!(value["status"], "stored");
655
+ assert!(value.get("deferred_reason").is_none());
656
+ let direct = SendArgs { presentation: crate::messaging::presentation::PresentationRequest::default(), ..args };
657
+ let error = cmd_send(&direct).unwrap_err().to_string();
658
+ assert!(error.contains("no tmux pane"), "{error}");
659
+ assert!(!error.contains("mcp_handshake") && !error.contains("parked"), "{error}");
723
660
  }
724
661
 
725
662
  #[test]
726
- fn cmd_send_json_shape_keeps_056_fields() {
663
+ fn cmd_send_json_shape_describes_the_decoupled_operation() {
727
664
  let args = queued_send_args_fixture(true);
728
- let r = cmd_send(&args).expect("cmd_send returns CmdResult");
729
- let v = match r.output {
730
- CmdOutput::Json(v) => v,
731
- other => panic!("--json send must emit Json, got {other:?}"),
732
- };
733
- let obj = v.as_object().expect("--json send output must be object");
734
- for key in [
735
- "ok",
736
- "status",
737
- "delivery_status",
738
- "delivered",
739
- "target",
740
- "agent_id",
741
- "content_length_bytes",
742
- "sender",
743
- "message_id",
744
- "message_status",
745
- "verification",
746
- "stage",
747
- "reason",
748
- "channel",
749
- "reminder",
750
- ] {
751
- assert!(obj.contains_key(key), "--json send shape lost {key}: {v}");
665
+ let result = cmd_send(&args).unwrap();
666
+ let CmdOutput::Json(value) = result.output else { panic!("JSON result expected") };
667
+ let inbox = crate::inbox_store::read(&args.workspace, "w1", 10, None).unwrap();
668
+ assert_eq!(inbox["messages"][0]["message_id"], value["message_id"]);
669
+ assert_eq!(value, json!({"ok": true, "status": "stored", "recipient": "w1", "mailbox": true, "message_id": inbox["messages"][0]["message_id"]}));
670
+ for key in ["delivery_attempts", "message_status", "verification", "watch", "deferred_reason"] {
671
+ assert!(value.get(key).is_none(), "no coordinator delivery fiction: {value}");
752
672
  }
753
- assert_eq!(v.get("verification"), Some(&serde_json::Value::Null));
754
- assert_eq!(v.get("stage"), Some(&serde_json::Value::Null));
755
- assert_eq!(v.get("reason"), Some(&serde_json::Value::Null));
756
- assert_eq!(v.get("channel"), Some(&serde_json::Value::Null));
757
- assert_eq!(v.get("delivered").and_then(|d| d.as_bool()), Some(false));
758
- assert!(
759
- !v.get("reminder")
760
- .and_then(|reminder| reminder.as_str())
761
- .unwrap_or_default()
762
- .contains("Message delivered."),
763
- "queued JSON reminder must not contradict delivered:false: {v}"
764
- );
765
673
  }
766
674
 
767
675
  #[test]
768
- fn cmd_send_watch_result_does_not_register_before_delivery() {
769
- // 0.5.x send contract: --watch-result may only advertise a watcher after
770
- // initial worker delivery is physically proven.
771
- let args = SendArgs {
772
- json: true,
773
- ..send_args_fixture()
774
- };
775
- let r = cmd_send(&args).expect("cmd_send returns CmdResult");
776
- let v = match r.output {
777
- CmdOutput::Json(v) => v,
778
- other => panic!("expected Json, got {other:?}"),
779
- };
780
- assert!(
781
- v.get("delivery_status").and_then(|s| s.as_str()).is_some(),
782
- "send output must expose delivery_status; got {v}"
783
- );
784
- assert_eq!(
785
- v.get("delivered").and_then(|s| s.as_bool()),
786
- Some(false),
787
- "undelivered send outcome must not look delivered"
788
- );
789
- assert!(
790
- !v.as_object().unwrap().contains_key("watch"),
791
- "watch_result:true must not attach result['watch'] before delivery; got {v}"
792
- );
676
+ fn cmd_send_legacy_watch_flag_does_not_create_a_watcher_or_delivery_row() {
677
+ let args = SendArgs { json: true, ..send_args_fixture() };
678
+ let db = args.workspace.join(".team/runtime/team.db");
679
+ let before = std::fs::read(&db).unwrap();
680
+ let result = cmd_send(&args).unwrap();
681
+ let CmdOutput::Json(value) = result.output else { panic!("JSON result expected") };
682
+ assert_eq!(value["status"], "stored");
683
+ assert!(value.get("watch").is_none());
684
+ assert_eq!(std::fs::read(db).unwrap(), before, "send must not mutate the coordinator database");
793
685
  }
794
686
 
795
687
  #[test]
796
- fn cmd_send_failed_outcome_yields_error_exit() {
797
- // DeliveryOutcome ok=false (e.g. refused) -> from_json -> ExitCode::Error (parser.py:507).
798
- // A failed send to a target must propagate non-zero exit reporting through CmdResult.
799
- let args = SendArgs {
800
- target: Some("drifted".into()),
801
- no_ack: false,
802
- no_wait: false,
803
- watch_result: false,
804
- ..send_args_fixture()
805
- };
806
- let r = cmd_send(&args).expect("cmd_send returns CmdResult even on delivery failure");
807
- if let CmdOutput::Json(ref v) = r.output {
808
- if v.get("ok").and_then(|b| b.as_bool()) == Some(false) {
809
- assert_eq!(
810
- r.exit,
811
- ExitCode::Error,
812
- "ok:false DeliveryOutcome MUST derive ExitCode::Error (non-zero exit)"
813
- );
814
- }
815
- }
688
+ fn cmd_send_unknown_recipient_is_an_immediate_error_without_queueing() {
689
+ let args = SendArgs { target: Some("absent-worker".into()), json: true, ..send_args_fixture() };
690
+ let refusal = cmd_send(&args).unwrap();
691
+ assert_eq!(refusal.exit, ExitCode::Error);
692
+ let CmdOutput::Json(value) = refusal.output else { panic!("JSON refusal expected") };
693
+ assert_eq!(value["ok"], false);
694
+ assert!(value.to_string().contains("absent-worker"), "{value}");
695
+ assert!(crate::inbox_store::read(&args.workspace, "absent-worker", 3, None).unwrap()["messages"].as_array().unwrap().is_empty());
816
696
  }
817
697
 
818
698
  #[test]
@@ -922,109 +802,26 @@ fn status_compact_omits_coordinator_entirely() {
922
802
  // gate, so agents/tasks must live under `teams[<key>].*` to be visible at projection
923
803
  // time. The "unknown task -> golden envelope" behavior being asserted is unchanged.
924
804
  #[test]
925
- fn cmd_send_unknown_task_surfaces_golden_error_envelope_not_silent() {
926
- let ws = std::env::temp_dir().join(format!(
927
- "ta-cli-sendunk-{}-{}",
928
- std::process::id(),
929
- std::time::SystemTime::now()
930
- .duration_since(std::time::UNIX_EPOCH)
931
- .unwrap()
932
- .as_nanos()
933
- ));
934
- std::fs::create_dir_all(ws.join(".team").join("runtime")).unwrap();
935
- std::fs::write(
936
- ws.join(".team").join("runtime").join("state.json"),
937
- serde_json::to_vec_pretty(&json!({
938
- "session_name": "team-x",
939
- "active_team_key": "current",
940
- "teams": {"current": {
941
- "session_name": "team-x",
942
- "agents": { "w1": { "status": "running" } },
943
- "tasks": []
944
- }}
945
- }))
946
- .unwrap(),
947
- )
948
- .unwrap();
949
- let _ = crate::message_store::MessageStore::open(&ws);
950
- let args = SendArgs {
951
- target: Some("w1".into()),
952
- targets: None,
953
- task: Some("t-unknown".into()),
954
- message: vec!["go".into()],
955
- workspace: ws.clone(),
956
- team: None,
957
- watch_result: false,
958
- json: true,
959
- ..send_args_fixture()
960
- };
961
- // route_task_id defaults true (CLI routing path) → the error MUST surface, not silently swallow.
962
- let err = cmd_send(&args).expect_err(
963
- "CLI send --task <unknown> must surface an error (route_task_id=true routing), not a silent 0-byte send"
964
- );
965
- let payload = err.to_payload(std::path::Path::new("/tmp/ta-cli-err.log"), "send");
966
- assert!(!payload.ok, "error envelope ok must be false");
967
- assert_eq!(
968
- payload.error, "unknown task id: t-unknown",
969
- "CLI error field == golden bare message (golden runtime.py:1032 str(exc)); NO 'validation:' prefix"
970
- );
971
- assert_eq!(
972
- payload.action,
973
- "Run team-agent doctor --workspace . for the selected team, or inspect the error log shown here."
974
- );
975
- let _ = std::fs::remove_dir_all(&ws);
805
+ fn cmd_send_legacy_task_flag_does_not_require_a_coordinator_task() {
806
+ let args = SendArgs { task: Some("t-unknown".into()), ..send_args_fixture() };
807
+ let result = cmd_send(&args).expect("legacy task metadata cannot gate physical/inbox delivery");
808
+ assert_eq!(result.exit, ExitCode::Ok);
809
+ let inbox = crate::inbox_store::read(&args.workspace, "alice", 3, None).unwrap();
810
+ assert_eq!(inbox["messages"][0]["content"], "hello world foo");
811
+ assert!(inbox["messages"][0].get("task_id").is_none());
976
812
  }
977
813
 
978
814
  #[test]
979
- fn run_send_legacy_task_flag_is_internalized_before_persistence() {
980
- let ws = std::env::temp_dir().join(format!(
981
- "ta-run-sendunk-{}-{}",
982
- std::process::id(),
983
- std::time::SystemTime::now()
984
- .duration_since(std::time::UNIX_EPOCH)
985
- .unwrap()
986
- .as_nanos()
987
- ));
988
- std::fs::create_dir_all(ws.join(".team").join("runtime")).unwrap();
989
- std::fs::write(
990
- ws.join(".team").join("runtime").join("state.json"),
991
- serde_json::to_vec_pretty(&json!({
992
- "session_name": "team-x",
993
- "active_team_key": "current",
994
- "teams": {"current": {
995
- "session_name": "team-x",
996
- "agents": { "w1": { "status": "running" } },
997
- "tasks": []
998
- }}
999
- }))
1000
- .unwrap(),
1001
- )
1002
- .unwrap();
1003
- let _ = crate::message_store::MessageStore::open(&ws);
1004
- let argv: Vec<String> = ["send", "w1", "--task", "t-unknown", "go", "--json"]
1005
- .iter()
1006
- .map(ToString::to_string)
1007
- .collect();
1008
- let code = run(&argv, &ws);
1009
- assert_eq!(
1010
- code,
1011
- ExitCode::Ok,
1012
- "legacy --task is sunset-noticed and ignored; public send persists without caller binding"
1013
- );
1014
- let connection =
1015
- rusqlite::Connection::open(ws.join(".team").join("runtime").join("team.db")).unwrap();
1016
- let task_id: Option<String> = connection
1017
- .query_row(
1018
- "SELECT task_id FROM messages WHERE content = 'go' ORDER BY rowid DESC LIMIT 1",
1019
- [],
1020
- |row| row.get(0),
1021
- )
1022
- .unwrap();
1023
- assert_eq!(
1024
- task_id, None,
1025
- "caller-supplied task ids must not reach storage"
1026
- );
1027
- let _ = std::fs::remove_dir_all(&ws);
815
+ fn run_send_legacy_task_flag_is_not_persisted_in_the_delivery_database() {
816
+ let args = send_args_fixture();
817
+ let argv = ["send", "alice", "--team", "teamA", "--task", "t-unknown", "go", "--mailbox", "--json"].map(str::to_string);
818
+ assert_eq!(run(&argv, &args.workspace), ExitCode::Ok);
819
+ let inbox = crate::inbox_store::read(&args.workspace, "alice", 3, None).unwrap();
820
+ assert_eq!(inbox["messages"][0]["content"], "go");
821
+ assert!(inbox["messages"][0].get("task_id").is_none());
822
+ let conn = rusqlite::Connection::open(args.workspace.join(".team/runtime/team.db")).unwrap();
823
+ let count: i64 = conn.query_row("SELECT count(*) FROM messages", [], |row| row.get(0)).unwrap();
824
+ assert_eq!(count, 0);
1028
825
  }
1029
826
 
1030
827
  #[test]
@@ -342,13 +342,7 @@ const ALIAS_JSON: &str = r#"{"version":1,"team":{"name":"debate-team","mode":"su
342
342
  fn compile_provider_models_do_not_fill_claude_code_role_model() {
343
343
  let team = build_team(ALIAS_TEAM, &[("implementer.md", ALIAS_ROLE)], &[]);
344
344
  let spec = compile_team(&team).unwrap();
345
- // On unix a `claude_code` role compiles to the Claude Code contract leaf's id.
346
- let expected = if cfg!(unix) {
347
- ALIAS_JSON.replace(r#""provider":"claude_code""#, r#""provider":"claude_tui""#)
348
- } else {
349
- ALIAS_JSON.to_string()
350
- };
351
- assert_eq!(templated_compact_json(&spec), expected);
345
+ assert_eq!(templated_compact_json(&spec), ALIAS_JSON);
352
346
  }
353
347
 
354
348
  // Omitted role model remains null; the provider supplies its native default.
@@ -452,9 +446,7 @@ fn compile_missing_provider_defaults_to_pi() {
452
446
  let team = build_team(TEAM_BASE, &[("implementer.md", ROLE_MISSING_PROVIDER)], &[]);
453
447
  let spec = compile_team(&team).expect("an omitted provider defaults to Pi");
454
448
  let agent = agent0(&spec);
455
- // On unix the default `pi` compiles to the Pi contract leaf's id.
456
- let expected = if cfg!(unix) { "pi_tui" } else { "pi" };
457
- assert_eq!(agent.get("provider"), Some(&Value::Str(expected.to_string())));
449
+ assert_eq!(agent.get("provider"), Some(&Value::Str("pi".to_string())));
458
450
  assert_eq!(
459
451
  agent.get("model"),
460
452
  Some(&Value::Str("team-agent/qwen3.8-27b".to_string()))
@@ -571,8 +563,7 @@ fn team_provider_model_aliases_do_not_fill_role_model() {
571
563
 
572
564
  #[test]
573
565
  fn claude_role_without_model_keeps_provider_native_default() {
574
- // A missing explicit model stays null for both Claude provider names, each
575
- // of which compiles to the Claude Code contract leaf on unix.
566
+ // A missing explicit model stays null for both Claude provider names.
576
567
  for prov in ["claude", "claude_code"] {
577
568
  let team = build_team(TM_CODEX, &[("w.md", &role_nomodel(prov))], &[]);
578
569
  let spec = compile_team(&team).unwrap();
@@ -581,12 +572,6 @@ fn claude_role_without_model_keeps_provider_native_default() {
581
572
  Some(&Value::Null),
582
573
  "provider {prov}"
583
574
  );
584
- let expected = if cfg!(unix) { "claude_tui" } else { prov };
585
- assert_eq!(
586
- agent0(&spec).get("provider").and_then(Value::as_str),
587
- Some(expected),
588
- "provider {prov}"
589
- );
590
575
  }
591
576
  }
592
577