@team-agent/installer 0.5.102 → 0.5.104

package/Cargo.lock

@@ -581,7 +581,7 @@ dependencies = [
 
 [[package]]
 name = "team-agent"
-version = "0.5.102"
+version = "0.5.104"
 dependencies = [
  "anyhow",
  "chrono",

package/Cargo.toml

@@ -9,7 +9,7 @@ members = ["crates/team-agent", "crates/win-conpty-phase0", "crates/conpty-trans
 
 [workspace.package]
 edition = "2021"
-version = "0.5.102"
+version = "0.5.104"
 license = "AGPL-3.0"
 rust-version = "1.95"
 

package/crates/team-agent/src/cli/emit.rs

@@ -290,6 +290,7 @@ pub(crate) fn default_help() -> String {
         &["claim-leader", "takeover", "attach-leader"],
     );
     out.push_str("\nWorkflow: `team-agent models --provider pi`, then quick-start/add-agent/start-agent, then `team-agent send AGENT MESSAGE`.\n");
+    out.push_str("Model catalogs: pi, cursor_agent, codex, claude, claude_code.\n");
     out.push_str("Provider launchers:\n  team-agent codex|claude|copilot|grok|cursor|pi ...\n");
     out.push_str("\nRun `team-agent <command> --help` for command flags.");
     out
@@ -340,7 +341,7 @@ fn command_help(command: Option<&str>) -> String {
         .to_string(),
         Some("allow-peer-talk") => "usage: team-agent allow-peer-talk A B [--workspace WORKSPACE] [--json]".to_string(),
         Some("status") => "usage: team-agent status [AGENT] [--workspace WORKSPACE] [--team TEAM] [--summary|--json] [--detail]\n\n输出七字段：name/provider/runtime_status/activity/health/session_name/tmux_command；人读与 --json 使用同一投影。缺少可靠定位或原生 tmux/process 采样时显示 unknown；tmux_command 可复制到对应目标。--summary/--detail 仅保留兼容性，不增加诊断字段。".to_string(),
-        Some("models") => "usage: team-agent models [--provider pi|cursor_agent] [QUERY|--search TEXT] [--json]\n\nLists exact provider model ids with case-insensitive multi-word search across provider, vendor, id, and display name. Cursor uses the local `agent --list-models` catalog.".to_string(),
+        Some("models") => "usage: team-agent models [--provider pi|cursor_agent|codex|claude|claude_code] [QUERY|--search TEXT] [--json]\n\nLists exact provider model ids with case-insensitive multi-word search across provider, vendor, id, display name, and source aliases. Uses each provider's native catalog; Codex uses `codex debug models` and Claude uses SDK stream-json initialize.".to_string(),
         Some("leaders") => "usage: team-agent leaders [QUERY|--search TEXT] [--all|--stale] [--json] | --prune [--dry-run] [--json]\n\nLists LIVE leaders by default. Use --all to include retained STALE entries, --stale to inspect only STALE entries, QUERY or --search TEXT to match workspace/team/name fields, and --prune to remove only entries proven terminal by canonical state. --dry-run is valid only with --prune.".to_string(),
         Some("shutdown") => "usage: team-agent shutdown [--workspace WORKSPACE] [--team TEAM] [--keep-logs] [--json]".to_string(),
         Some("restart") => "usage: team-agent restart [WORKSPACE] [--team TEAM] [--allow-fresh] [--session-converge-deadline SECONDS] [--json] [--detail]".to_string(),

package/crates/team-agent/src/cli/models.rs

@@ -3,292 +3,157 @@ use super::{CliError, CmdOutput, CmdResult, ExitCode, ModelsArgs};
 use serde_json::{json, Value};
 #[cfg(test)]
 use std::collections::BTreeMap;
+#[cfg(test)]
 use std::path::Path;
+#[cfg(test)]
 use std::time::Duration;
+
+#[cfg(test)]
 const CATALOG_TIMEOUT: Duration = Duration::from_secs(10);
+#[cfg(test)]
 const MAX_CATALOG_BYTES: u64 = 1024 * 1024;
+type ModelRecord = crate::provider::model_catalog::ModelRecord;
 
+#[cfg(test)]
 #[derive(Clone, Copy, Debug, Eq, PartialEq)]
 enum CatalogFormat {
     Pi,
     CursorAgent,
 }
 
-#[derive(Clone, Debug)]
-struct ModelRecord {
-    provider: String,
-    vendor: String,
-    id: String,
-    display_name: String,
-    default: Option<bool>,
-}
-
 pub fn cmd_models(args: &ModelsArgs) -> Result<CmdResult, CliError> {
-    let (program, format) = match args.provider.as_str() {
-        "pi" => (Path::new("pi"), CatalogFormat::Pi),
-        "cursor_agent" => (Path::new("agent"), CatalogFormat::CursorAgent),
-        provider => {
-            return Ok(failure(
-                args,
-                &format!("unsupported model provider {provider:?}"),
-            ))
+    let records = match crate::provider::model_catalog::discover_model_catalog(&args.provider) {
+        Ok(records) => records,
+        Err(error) => {
+            let message = error.message(&args.provider);
+            let action = error.action(&args.provider);
+            return Ok(failure_with_action(args, &message, &action));
         }
     };
-    cmd_models_with_format(args, program, format, CATALOG_TIMEOUT, MAX_CATALOG_BYTES)
-}
-
-/// Existing injectable Pi boundary retained for deterministic command/timeout tests.
-fn cmd_models_with(
-    args: &ModelsArgs,
-    program: &Path,
-    timeout: Duration,
-    max_bytes: u64,
-) -> Result<CmdResult, CliError> {
-    cmd_models_with_format(args, program, CatalogFormat::Pi, timeout, max_bytes)
+    render_catalog(args, records)
 }
 
-fn cmd_models_with_format(
-    args: &ModelsArgs,
-    program: &Path,
-    format: CatalogFormat,
-    timeout: Duration,
-    max_bytes: u64,
-) -> Result<CmdResult, CliError> {
-    let bytes = match run_catalog(program, timeout, max_bytes) {
-        Ok(bytes) => bytes,
-        Err(message) => return Ok(failure(args, &catalog_error_prefix(format, message))),
-    };
-    let all = match parse_catalog(&bytes, format) {
-        Ok(models) => models,
-        Err(message) => return Ok(failure(args, &message)),
-    };
+fn render_catalog(args: &ModelsArgs, all: Vec<ModelRecord>) -> Result<CmdResult, CliError> {
     let visible = args.search.as_deref().map_or_else(
         || all.clone(),
-        |search| {
-            all.iter()
-                .filter(|model| model_matches(model, search))
-                .cloned()
-                .collect::<Vec<_>>()
-        },
+        |search| all.iter().filter(|model| crate::provider::model_catalog::model_matches(model, search)).cloned().collect(),
     );
-    let current = current_model_for(format, &all);
-    let entries: Vec<Value> = visible
-        .iter()
-        .map(|model| {
-            json!({
-                "role_model": model.id,
-                "current": if format == CatalogFormat::Pi {
-                    json!(current.as_deref() == Some(model.id.as_str()))
-                } else {
-                    Value::Null
-                },
-                "provider": model.provider,
-                "vendor": model.vendor,
-                "model_id": model.id,
-                "display_name": model.display_name,
-                "default": model.default,
-            })
-        })
-        .collect();
+    let current = if args.provider == "pi" {
+        current_role_model(&all.iter().map(|model| model.id.clone()).collect::<Vec<_>>())
+    } else {
+        None
+    };
+    let entries: Vec<Value> = visible.iter().map(|model| json!({
+        "role_model": model.id,
+        "current": if args.provider == "pi" { json!(current.as_deref() == Some(model.id.as_str())) } else { Value::Null },
+        "provider": model.provider,
+        "vendor": model.vendor,
+        "model_id": model.id,
+        "display_name": model.display_name,
+        "default": model.default,
+        "aliases": model.aliases,
+    })).collect();
     let provider = args.provider.as_str();
     let value = json!({
         "schema_version": "models.v1", "ok": true, "provider": provider, "models": entries,
         "auth": "ok", "auth_basis": "catalog_visibility", "current_role_model": current, "search": args.search,
     });
     if args.json {
-        let text = serde_json::to_string_pretty(&value)?;
         Ok(CmdResult {
-            output: CmdOutput::Human(text),
+            output: CmdOutput::Human(serde_json::to_string_pretty(&value)?),
             exit: ExitCode::Ok,
             as_json: false,
             preserve_json_order: true,
         })
     } else {
-        let mut lines = vec![format!(
-            "models.v1 | {provider} models (copyable model_id):"
-        )];
+        let mut lines = vec![format!("models.v1 | {provider} models (copyable model_id):")];
         lines.push("PROVIDER VENDOR MODEL_ID DISPLAY_NAME CURRENT DEFAULT".to_string());
-        lines.extend(visible.iter().map(|model| {
-            format!(
-                "{} {} {} {} {} {}",
-                model.provider,
-                model.vendor,
-                model.id,
-                model.display_name,
-                if format == CatalogFormat::Pi {
-                    (current.as_deref() == Some(model.id.as_str())).to_string()
-                } else {
-                    "—".to_string()
-                },
-                model
-                    .default
-                    .map_or_else(|| "—".to_string(), |value| value.to_string()),
-            )
-        }));
-        lines.push(format!(
-            "auth: ok (catalog_visibility); {} model(s)",
-            visible.len()
-        ));
+        lines.extend(visible.iter().map(|model| format!(
+            "{} {} {} {} {} {}", model.provider, model.vendor, model.id, model.display_name,
+            if args.provider == "pi" { (current.as_deref() == Some(model.id.as_str())).to_string() } else { "—".to_string() },
+            model.default.map_or_else(|| "—".to_string(), |value| value.to_string()),
+        )));
+        lines.push(format!("auth: ok (catalog_visibility); {} model(s)", visible.len()));
         if visible.is_empty() {
-            lines.push("No models matched --search/query.".to_string());
+            lines.push("No models matched --search/query; rerun without a search to list the full catalog.".to_string());
         }
         Ok(CmdResult::human(lines.join("\n")))
     }
 }
 
+/// Existing injectable Pi boundary retained for deterministic command/timeout tests.
+#[cfg(test)]
+fn cmd_models_with(args: &ModelsArgs, program: &Path, timeout: Duration, max_bytes: u64) -> Result<CmdResult, CliError> {
+    cmd_models_with_format(args, program, CatalogFormat::Pi, timeout, max_bytes)
+}
+
+#[cfg(test)]
+fn cmd_models_with_format(args: &ModelsArgs, program: &Path, format: CatalogFormat, timeout: Duration, max_bytes: u64) -> Result<CmdResult, CliError> {
+    let bytes = match run_catalog(program, timeout, max_bytes) {
+        Ok(bytes) => bytes,
+        Err(message) => return Ok(failure(args, &message)),
+    };
+    let all = match parse_catalog(&bytes, format) {
+        Ok(models) => models,
+        Err(message) => return Ok(failure(args, &message)),
+    };
+    render_catalog(args, all)
+}
+
+#[cfg(test)]
 fn parse_catalog(bytes: &[u8], format: CatalogFormat) -> Result<Vec<ModelRecord>, String> {
-    match format {
-        CatalogFormat::Pi => crate::lifecycle::launch::pi_mcp::parse_pi_list_models_table(bytes)
-            .map(|models| {
-                models
-                    .into_iter()
-                    .map(|id| {
-                        let vendor = id
-                            .split_once('/')
-                            .map_or_else(|| "pi".to_string(), |(vendor, _)| vendor.to_string());
-                        ModelRecord {
-                            provider: "pi".to_string(),
-                            vendor,
-                            display_name: id.clone(),
-                            id,
-                            default: None,
-                        }
-                    })
-                    .collect()
-            })
-            .map_err(safe_catalog_error),
-        CatalogFormat::CursorAgent => parse_cursor_catalog(bytes),
-    }
+    let provider = match format { CatalogFormat::Pi => "pi", CatalogFormat::CursorAgent => "cursor_agent" };
+    let result = match format {
+        CatalogFormat::Pi => crate::provider::model_catalog::parse_pi_catalog(bytes),
+        CatalogFormat::CursorAgent => crate::provider::model_catalog::parse_cursor_catalog(bytes),
+    };
+    result.map_err(|error| error.message(provider))
 }
 
+#[cfg(test)]
 fn parse_cursor_catalog(bytes: &[u8]) -> Result<Vec<ModelRecord>, String> {
-    let text = std::str::from_utf8(bytes)
-        .map_err(|_| "Cursor model catalog is not valid UTF-8".to_string())?;
-    let mut models = Vec::new();
-    for line in text.lines() {
-        let line = line.trim();
-        if line.is_empty()
-            || line
-                .trim_end_matches(':')
-                .eq_ignore_ascii_case("available models")
-        {
-            continue;
-        }
-        let Some((id, display)) = line.split_once(" - ") else {
-            return Err("Cursor model catalog contains a malformed row".to_string());
-        };
-        let id = id.trim();
-        if id.is_empty() || id.chars().any(char::is_whitespace) || display.trim().is_empty() {
-            return Err("Cursor model catalog contains a malformed row".to_string());
-        }
-        if models.iter().any(|model: &ModelRecord| model.id == id) {
-            return Err("Cursor model catalog contains duplicate model ids".to_string());
-        }
-        let default = display.trim_end().ends_with("(default)");
-        let display_name = display.trim().strip_suffix("(default)").map_or_else(
-            || display.trim().to_string(),
-            |name| name.trim().to_string(),
-        );
-        let vendor = id
-            .split_once('-')
-            .map_or_else(|| "cursor".to_string(), |(vendor, _)| vendor.to_string());
-        models.push(ModelRecord {
-            provider: "cursor_agent".to_string(),
-            vendor,
-            id: id.to_string(),
-            display_name,
-            default: Some(default),
-        });
-    }
-    if models.is_empty() {
-        return Err("Cursor model catalog is empty".to_string());
-    }
-    Ok(models)
+    crate::provider::model_catalog::parse_cursor_catalog(bytes)
+        .map_err(|error| error.message("cursor_agent"))
 }
 
+#[cfg(test)]
 fn model_matches(model: &ModelRecord, search: &str) -> bool {
-    let fields = [
-        model.provider.as_str(),
-        model.vendor.as_str(),
-        model.id.as_str(),
-        model.display_name.as_str(),
-    ];
-    search
-        .split_whitespace()
-        .map(str::to_lowercase)
-        .all(|needle| {
-            fields
-                .iter()
-                .any(|field| field.to_lowercase().contains(needle.as_str()))
-        })
+    crate::provider::model_catalog::model_matches(model, search)
 }
 
+#[cfg(test)]
 fn current_model_for(format: CatalogFormat, models: &[ModelRecord]) -> Option<String> {
     match format {
-        CatalogFormat::Pi => current_role_model(
-            &models
-                .iter()
-                .map(|model| model.id.clone())
-                .collect::<Vec<_>>(),
-        ),
-        // Cursor's catalog does not expose the active role model; never mark a
-        // catalog default as current without an explicit runtime identity.
+        CatalogFormat::Pi => current_role_model(&models.iter().map(|model| model.id.clone()).collect::<Vec<_>>()),
         CatalogFormat::CursorAgent => None,
     }
 }
 
-fn catalog_error_prefix(format: CatalogFormat, message: String) -> String {
-    match format {
-        CatalogFormat::Pi => message,
-        CatalogFormat::CursorAgent => message.replace("Pi", "Cursor"),
-    }
-}
-
+#[cfg(test)]
 fn failure(args: &ModelsArgs, message: &str) -> CmdResult {
-    let executable = if args.provider == "cursor_agent" {
-        "agent"
-    } else {
-        "pi"
-    };
     let action = if message.starts_with("unsupported model provider") {
-        "choose a supported provider: pi or cursor_agent".to_string()
+        "choose a supported provider: pi, cursor_agent, codex, claude, or claude_code".to_string()
     } else {
-        format!(
-            "install or repair the PATH-first `{executable}` executable, then retry `team-agent models --provider {}`",
-            args.provider
-        )
+        let executable = match args.provider.as_str() {
+            "cursor_agent" => "agent",
+            "codex" => "codex",
+            "claude" | "claude_code" => "claude",
+            _ => "pi",
+        };
+        format!("install or repair the PATH-first `{executable}` executable, then retry `team-agent models --provider {}`", args.provider)
     };
+    failure_with_action(args, message, &action)
+}
+
+fn failure_with_action(args: &ModelsArgs, message: &str, action: &str) -> CmdResult {
     let value = json!({ "schema_version": "models.v1", "ok": false, "provider": args.provider, "auth": "not_ready", "auth_basis": "catalog_visibility", "models": Value::Array(Vec::new()), "current_role_model": Value::Null, "error": message, "action": action });
     if args.json {
-        let text = serde_json::to_string_pretty(&value)
-            .unwrap_or_else(|_| "{\"schema_version\":\"models.v1\",\"ok\":false}".to_string());
-        CmdResult {
-            output: CmdOutput::Human(text),
-            exit: ExitCode::Error,
-            as_json: false,
-            preserve_json_order: true,
-        }
+        let text = serde_json::to_string_pretty(&value).unwrap_or_else(|_| "{\"schema_version\":\"models.v1\",\"ok\":false}".to_string());
+        CmdResult { output: CmdOutput::Human(text), exit: ExitCode::Error, as_json: false, preserve_json_order: true }
     } else {
         CmdResult { output: CmdOutput::Human(format!("models.v1 | error: {message}\naction: {action}\nauth: not_ready (catalog_visibility)")), exit: ExitCode::Error, as_json: false, preserve_json_order: false }
     }
 }
-
-fn safe_catalog_error(error: crate::provider::ProviderError) -> String {
-    let text = error.to_string();
-    if text.contains("not UTF-8") {
-        "Pi model catalog is not valid UTF-8".into()
-    } else if text.contains("duplicate") {
-        "Pi model catalog contains duplicate model ids".into()
-    } else if text.contains("header") {
-        "Pi model catalog has an unexpected header".into()
-    } else if text.contains("row") {
-        "Pi model catalog contains a malformed row".into()
-    } else if text.contains("empty") || text.contains("no models") {
-        "Pi model catalog is empty".into()
-    } else {
-        "Pi model catalog is invalid".into()
-    }
-}
 fn current_role_model(models: &[String]) -> Option<String> {
     current_role_model_from(
         models,
@@ -309,6 +174,7 @@ fn current_role_model_from(
 }
 
 /// Injectable executable, deadline, and byte-limit boundary for deterministic tests.
+#[cfg(test)]
 fn run_catalog(program: &Path, timeout: Duration, max_bytes: u64) -> Result<Vec<u8>, String> {
     crate::lifecycle::launch::pi_mcp::run_pi_catalog(program, timeout, max_bytes)
 }
@@ -995,7 +861,7 @@ mod tests {
         assert!(text.contains("No models matched --search") && text.contains("auth: ok"));
         let refusal = crate::cli::emit::__test_dispatch(
             "models",
-            &["--provider".into(), "codex".into()],
+            &["--provider".into(), "cloud".into()],
             Path::new("/tmp"),
         );
         assert!(matches!(refusal, Ok(ExitCode::Error)));
@@ -1095,14 +961,14 @@ mod tests {
         );
         assert_eq!(
             crate::cli::run(
-                &["models".into(), "--provider".into(), "codex".into()],
+                &["models".into(), "--provider".into(), "cloud".into()],
                 Path::new("/tmp")
             ),
             ExitCode::Error
         );
         assert_eq!(
             crate::cli::spec::command_spec("models").unwrap().usage,
-            "usage: team-agent models [--provider pi|cursor_agent] [QUERY|--search TEXT] [--json]"
+            "usage: team-agent models [--provider pi|cursor_agent|codex|claude|claude_code] [QUERY|--search TEXT] [--json]"
         );
     }
 

package/crates/team-agent/src/cli/spec.rs

@@ -147,7 +147,7 @@ pub(crate) const COMMAND_SPECS: &[CommandSpec] = &[
     CommandSpec { name: "quick-start", tier: CommandTier::Core, category: CommandCategory::Start, kind: CommandKind::Dispatch(DispatchKind::QuickStart), summary: "start or attach a team from TEAM.md", usage: "usage: team-agent quick-start [TEAMDIR] [--workspace WORKSPACE] [--name NAME] [--team-id TEAM|--team TEAM] [--yes] [--backend tmux|conpty] [--json]", default_help: true, command_help: true, suggestion_index: true, token_usage: TokenUsage::Conditional, sunset: None, action: None, governance: None },
     CommandSpec { name: "send", tier: CommandTier::Core, category: CommandCategory::Daily, kind: CommandKind::Dispatch(DispatchKind::Send), summary: "persist a message for an in-team short name or fully-qualified logical recipient", usage: "usage: team-agent send TO MESSAGE... [--workspace WORKSPACE] [--team TEAM] [--mailbox] [--json]\nTO forms are co-equal: an in-team short name (for example `team-agent send reviewer \"Review\"`) or `<workspace>::<team>/<agent>`.", default_help: true, command_help: true, suggestion_index: true, token_usage: TokenUsage::Conditional, sunset: Some("next compatibility release"), action: Some("use positional logical TO and the returned message id"), governance: None },
     CommandSpec { name: "status", tier: CommandTier::Core, category: CommandCategory::Daily, kind: CommandKind::Dispatch(DispatchKind::Status), summary: "show current team status", usage: "usage: team-agent status [AGENT] [--workspace WORKSPACE] [--team TEAM] [--summary|--json] [--detail]", default_help: true, command_help: true, suggestion_index: true, token_usage: TokenUsage::No, sunset: None, action: None, governance: None },
-    CommandSpec { name: "models", tier: CommandTier::Core, category: CommandCategory::Observe, kind: CommandKind::Dispatch(DispatchKind::Models), summary: "list exact provider model ids", usage: "usage: team-agent models [--provider pi|cursor_agent] [QUERY|--search TEXT] [--json]", default_help: true, command_help: true, suggestion_index: true, token_usage: TokenUsage::No, sunset: None, action: None, governance: None },
+    CommandSpec { name: "models", tier: CommandTier::Core, category: CommandCategory::Observe, kind: CommandKind::Dispatch(DispatchKind::Models), summary: "list exact provider model ids", usage: "usage: team-agent models [--provider pi|cursor_agent|codex|claude|claude_code] [QUERY|--search TEXT] [--json]", default_help: true, command_help: true, suggestion_index: true, token_usage: TokenUsage::No, sunset: None, action: None, governance: None },
     CommandSpec { name: "results", tier: CommandTier::Core, category: CommandCategory::Daily, kind: CommandKind::Dispatch(DispatchKind::Results), summary: "read reported results for a case", usage: "usage: team-agent results --case CASE_ID [--workspace WORKSPACE] [--team TEAM] [--json]", default_help: true, command_help: true, suggestion_index: true, token_usage: TokenUsage::No, sunset: None, action: None, governance: None },
     CommandSpec { name: "wait", tier: CommandTier::Core, category: CommandCategory::Daily, kind: CommandKind::Dispatch(DispatchKind::Wait), summary: "block until a task result is stored", usage: "usage: team-agent wait --task TASK [--workspace WORKSPACE] [--json]", default_help: false, command_help: true, suggestion_index: true, token_usage: TokenUsage::No, sunset: None, action: None, governance: None },
     CommandSpec { name: "restart", tier: CommandTier::Core, category: CommandCategory::TeamLifecycle, kind: CommandKind::Dispatch(DispatchKind::Restart), summary: "restart the selected team", usage: "usage: team-agent restart [WORKSPACE] [--team TEAM] [--allow-fresh] [--session-converge-deadline SECONDS] [--json]", default_help: true, command_help: true, suggestion_index: true, token_usage: TokenUsage::Conditional, sunset: None, action: None, governance: None },
@@ -165,7 +165,7 @@ pub(crate) const COMMAND_SPECS: &[CommandSpec] = &[
     CommandSpec { name: "copilot", tier: CommandTier::Core, category: CommandCategory::Start, kind: CommandKind::LeaderPassthrough { provider: "copilot" }, summary: "launch a Copilot leader", usage: "usage: team-agent copilot [provider args...]", default_help: false, command_help: true, suggestion_index: true, token_usage: TokenUsage::Yes, sunset: None, action: None, governance: None },
     CommandSpec { name: "grok", tier: CommandTier::Core, category: CommandCategory::Start, kind: CommandKind::LeaderPassthrough { provider: "grok" }, summary: "launch a Grok leader", usage: "usage: team-agent grok [provider args...]", default_help: false, command_help: true, suggestion_index: true, token_usage: TokenUsage::Yes, sunset: None, action: None, governance: None },
     CommandSpec { name: "cursor", tier: CommandTier::Core, category: CommandCategory::Start, kind: CommandKind::LeaderPassthrough { provider: "cursor" }, summary: "launch a Cursor leader", usage: "usage: team-agent cursor [provider args...]", default_help: false, command_help: true, suggestion_index: true, token_usage: TokenUsage::Yes, sunset: None, action: None, governance: None },
-    CommandSpec { name: "pi", tier: CommandTier::Core, category: CommandCategory::Start, kind: CommandKind::LeaderPassthrough { provider: "pi" }, summary: "launch a Pi leader", usage: "usage: team-agent pi -- --model <exact> --thinking <effort>", default_help: false, command_help: true, suggestion_index: true, token_usage: TokenUsage::Yes, sunset: None, action: None, governance: None },
+    CommandSpec { name: "pi", tier: CommandTier::Core, category: CommandCategory::Start, kind: CommandKind::LeaderPassthrough { provider: "pi" }, summary: "launch a Pi leader", usage: "usage: team-agent pi [provider args...]", default_help: false, command_help: true, suggestion_index: true, token_usage: TokenUsage::Yes, sunset: None, action: None, governance: None },
 
     CommandSpec { name: "leaders", tier: CommandTier::Secondary, category: CommandCategory::Observe, kind: CommandKind::Dispatch(DispatchKind::Leaders), summary: "list live, stale, or ambiguous host leaders", usage: "usage: team-agent leaders [QUERY|--search TEXT] [--all|--stale] [--json] | --prune [--dry-run] [--json]", default_help: false, command_help: true, suggestion_index: false, token_usage: TokenUsage::No, sunset: None, action: None, governance: None },
     CommandSpec { name: "doctor", tier: CommandTier::Core, category: CommandCategory::Observe, kind: CommandKind::Dispatch(DispatchKind::Doctor), summary: "inspect environment and Team runtime health", usage: "usage: team-agent doctor [SPEC] [--workspace WORKSPACE] [--team TEAM] [--gate orphans|comms] [--comms] [--fix] [--fix-schema] [--cleanup-orphans] [--confirm] [--json]", default_help: true, command_help: true, suggestion_index: true, token_usage: TokenUsage::No, sunset: None, action: None, governance: None },

package/crates/team-agent/src/compiler/tests.rs

@@ -221,9 +221,8 @@ fn compile_subscription_without_profile_is_thin_manifest() {
     );
 }
 
-// Runtime front-matter defaults: every knob from TEAM.md flows through without
-// per-role repetition; thin role inherits default_model; leader.model is null
-// (TEAM.md has no `model:` key, only `default_model:`).
+// Runtime front-matter defaults: TEAM.md runtime settings remain available,
+// but its default_model does not fill an omitted role model; leader.model is null.
 const RUNTIME_DEFAULTS_TEAM: &str = "\
 ---
 name: doc-team
@@ -256,7 +255,7 @@ dangerously_skip_permissions: false
 Implement bounded tasks.
 ";
 
-const RUNTIME_DEFAULTS_JSON: &str = r#"{"version":1,"team":{"name":"doc-team","mode":"supervisor_worker","objective":"Compile role docs.","workspace":"__WS__"},"leader":{"id":"leader","role":"leader","provider":"codex","model":null,"context_policy":{"keep_user_thread":true,"receive_worker_outputs":"business_messages_and_short_summaries","max_worker_result_tokens":2000}},"agents":[{"id":"implementer","role":"Implementation Engineer","provider":"codex","model":"gpt-5.4","auth_mode":"subscription","working_directory":"__WS__","system_prompt":{"inline":"Implement bounded tasks.","file":null},"dangerously_skip_permissions":false,"communication_mode":"leader_centric","preferred_for":["implementer","Implementation Engineer"],"avoid_for":[],"output_contract":{"format":"result_envelope_v1","required_fields":["task_id","status","summary","artifacts"]}}],"routing":{"default_assignee":"implementer","rules":[{"id":"route-implementer","match":{"assignee":["implementer"]},"assign_to":"implementer","priority":10}]},"communication":{"protocol":"mcp_inbox","topology":"leader_centered","worker_to_worker":true,"ack_timeout_sec":60,"result_format":"result_envelope_v1","message_store":{"sqlite":".team/runtime/team.db","mirror_files":".team/messages"}},"runtime":{"backend":"tmux","session_name":"team-doc-team","auto_launch":true,"require_user_approval_before_launch":true,"max_active_agents":1,"startup_order":["implementer"],"fast":true,"tick_interval_sec":1,"push_min_interval_sec":3,"stuck_timeout_sec":5},"context":{"state_file":"team_state.md","artifact_dir":".team/artifacts","log_dir":".team/logs","summarization":{"worker_full_logs":"retain_outside_leader_context","state_update":"after_each_result"}},"tasks":[{"id":"task_initial","title":"Initial document-driven team task","type":"implementation","assignee":"implementer","deps":[],"acceptance":["Worker reports valid result_envelope_v1"],"status":"pending","requires_tools":["mcp_team"],"files":[],"risk":"low"}]}"#;
+const RUNTIME_DEFAULTS_JSON: &str = r#"{"version":1,"team":{"name":"doc-team","mode":"supervisor_worker","objective":"Compile role docs.","workspace":"__WS__"},"leader":{"id":"leader","role":"leader","provider":"codex","model":null,"context_policy":{"keep_user_thread":true,"receive_worker_outputs":"business_messages_and_short_summaries","max_worker_result_tokens":2000}},"agents":[{"id":"implementer","role":"Implementation Engineer","provider":"codex","model":null,"auth_mode":"subscription","working_directory":"__WS__","system_prompt":{"inline":"Implement bounded tasks.","file":null},"dangerously_skip_permissions":false,"communication_mode":"leader_centric","preferred_for":["implementer","Implementation Engineer"],"avoid_for":[],"output_contract":{"format":"result_envelope_v1","required_fields":["task_id","status","summary","artifacts"]}}],"routing":{"default_assignee":"implementer","rules":[{"id":"route-implementer","match":{"assignee":["implementer"]},"assign_to":"implementer","priority":10}]},"communication":{"protocol":"mcp_inbox","topology":"leader_centered","worker_to_worker":true,"ack_timeout_sec":60,"result_format":"result_envelope_v1","message_store":{"sqlite":".team/runtime/team.db","mirror_files":".team/messages"}},"runtime":{"backend":"tmux","session_name":"team-doc-team","auto_launch":true,"require_user_approval_before_launch":true,"max_active_agents":1,"startup_order":["implementer"],"fast":true,"tick_interval_sec":1,"push_min_interval_sec":3,"stuck_timeout_sec":5},"context":{"state_file":"team_state.md","artifact_dir":".team/artifacts","log_dir":".team/logs","summarization":{"worker_full_logs":"retain_outside_leader_context","state_update":"after_each_result"}},"tasks":[{"id":"task_initial","title":"Initial document-driven team task","type":"implementation","assignee":"implementer","deps":[],"acceptance":["Worker reports valid result_envelope_v1"],"status":"pending","requires_tools":["mcp_team"],"files":[],"risk":"low"}]}"#;
 
 #[test]
 fn compile_runtime_front_matter_defaults_match_python() {
@@ -269,8 +268,7 @@ fn compile_runtime_front_matter_defaults_match_python() {
     assert_eq!(templated_compact_json(&spec), RUNTIME_DEFAULTS_JSON);
 }
 
-// provider_models alias ladder: role provider `claude_code` with NO `claude_code`
-// key in provider_models falls back to the `claude` key (compiler.py:317-318).
+// TEAM provider_models do not fill a role whose model is omitted.
 const ALIAS_TEAM: &str = "\
 ---
 name: debate-team
@@ -296,16 +294,16 @@ dangerously_skip_permissions: false
 Edit and defend the argument.
 ";
 
-const ALIAS_JSON: &str = r#"{"version":1,"team":{"name":"debate-team","mode":"supervisor_worker","objective":"Compile thin role docs.","workspace":"__WS__"},"leader":{"id":"leader","role":"leader","provider":"codex","model":null,"context_policy":{"keep_user_thread":true,"receive_worker_outputs":"business_messages_and_short_summaries","max_worker_result_tokens":2000}},"agents":[{"id":"editor","role":"Editor and Defender","provider":"claude_code","model":"claude-sonnet-4-6","auth_mode":"subscription","working_directory":"__WS__","system_prompt":{"inline":"Edit and defend the argument.","file":null},"dangerously_skip_permissions":false,"communication_mode":"leader_centric","preferred_for":["editor","Editor and Defender"],"avoid_for":[],"output_contract":{"format":"result_envelope_v1","required_fields":["task_id","status","summary","artifacts"]}}],"routing":{"default_assignee":"editor","rules":[{"id":"route-editor","match":{"assignee":["editor"]},"assign_to":"editor","priority":10}]},"communication":{"protocol":"mcp_inbox","topology":"leader_centered","worker_to_worker":true,"ack_timeout_sec":60,"result_format":"result_envelope_v1","message_store":{"sqlite":".team/runtime/team.db","mirror_files":".team/messages"}},"runtime":{"backend":"tmux","session_name":"team-debate-team","auto_launch":true,"require_user_approval_before_launch":true,"max_active_agents":1,"startup_order":["editor"],"fast":false,"tick_interval_sec":2,"push_min_interval_sec":60,"stuck_timeout_sec":300},"context":{"state_file":"team_state.md","artifact_dir":".team/artifacts","log_dir":".team/logs","summarization":{"worker_full_logs":"retain_outside_leader_context","state_update":"after_each_result"}},"tasks":[{"id":"task_initial","title":"Initial document-driven team task","type":"implementation","assignee":"editor","deps":[],"acceptance":["Worker reports valid result_envelope_v1"],"status":"pending","requires_tools":["mcp_team"],"files":[],"risk":"low"}]}"#;
+const ALIAS_JSON: &str = r#"{"version":1,"team":{"name":"debate-team","mode":"supervisor_worker","objective":"Compile thin role docs.","workspace":"__WS__"},"leader":{"id":"leader","role":"leader","provider":"codex","model":null,"context_policy":{"keep_user_thread":true,"receive_worker_outputs":"business_messages_and_short_summaries","max_worker_result_tokens":2000}},"agents":[{"id":"editor","role":"Editor and Defender","provider":"claude_code","model":null,"auth_mode":"subscription","working_directory":"__WS__","system_prompt":{"inline":"Edit and defend the argument.","file":null},"dangerously_skip_permissions":false,"communication_mode":"leader_centric","preferred_for":["editor","Editor and Defender"],"avoid_for":[],"output_contract":{"format":"result_envelope_v1","required_fields":["task_id","status","summary","artifacts"]}}],"routing":{"default_assignee":"editor","rules":[{"id":"route-editor","match":{"assignee":["editor"]},"assign_to":"editor","priority":10}]},"communication":{"protocol":"mcp_inbox","topology":"leader_centered","worker_to_worker":true,"ack_timeout_sec":60,"result_format":"result_envelope_v1","message_store":{"sqlite":".team/runtime/team.db","mirror_files":".team/messages"}},"runtime":{"backend":"tmux","session_name":"team-debate-team","auto_launch":true,"require_user_approval_before_launch":true,"max_active_agents":1,"startup_order":["editor"],"fast":false,"tick_interval_sec":2,"push_min_interval_sec":60,"stuck_timeout_sec":300},"context":{"state_file":"team_state.md","artifact_dir":".team/artifacts","log_dir":".team/logs","summarization":{"worker_full_logs":"retain_outside_leader_context","state_update":"after_each_result"}},"tasks":[{"id":"task_initial","title":"Initial document-driven team task","type":"implementation","assignee":"editor","deps":[],"acceptance":["Worker reports valid result_envelope_v1"],"status":"pending","requires_tools":["mcp_team"],"files":[],"risk":"low"}]}"#;
 
 #[test]
-fn compile_provider_models_claude_code_falls_back_to_claude_alias() {
+fn compile_provider_models_do_not_fill_claude_code_role_model() {
     let team = build_team(ALIAS_TEAM, &[("implementer.md", ALIAS_ROLE)], &[]);
     let spec = compile_team(&team).unwrap();
     assert_eq!(templated_compact_json(&spec), ALIAS_JSON);
 }
 
-// Builtin provider default: no model anywhere → DEFAULT_PROVIDER_MODELS[codex] = gpt-5.5.
+// Omitted role model remains null; the provider supplies its native default.
 const BUILTIN_TEAM: &str = "\
 ---
 name: default-model-team
@@ -329,10 +327,10 @@ tools:
 Implement bounded tasks.
 ";
 
-const BUILTIN_JSON: &str = r#"{"version":1,"team":{"name":"default-model-team","mode":"supervisor_worker","objective":"Compile role docs without model fields.","workspace":"__WS__"},"leader":{"id":"leader","role":"leader","provider":"codex","model":null,"context_policy":{"keep_user_thread":true,"receive_worker_outputs":"business_messages_and_short_summaries","max_worker_result_tokens":2000}},"agents":[{"id":"implementer","role":"Implementation Engineer","provider":"codex","model":"gpt-5.5","auth_mode":"subscription","working_directory":"__WS__","system_prompt":{"inline":"Implement bounded tasks.","file":null},"dangerously_skip_permissions":false,"communication_mode":"leader_centric","preferred_for":["implementer","Implementation Engineer"],"avoid_for":[],"output_contract":{"format":"result_envelope_v1","required_fields":["task_id","status","summary","artifacts"]}}],"routing":{"default_assignee":"implementer","rules":[{"id":"route-implementer","match":{"assignee":["implementer"]},"assign_to":"implementer","priority":10}]},"communication":{"protocol":"mcp_inbox","topology":"leader_centered","worker_to_worker":true,"ack_timeout_sec":60,"result_format":"result_envelope_v1","message_store":{"sqlite":".team/runtime/team.db","mirror_files":".team/messages"}},"runtime":{"backend":"tmux","session_name":"team-default-model-team","auto_launch":true,"require_user_approval_before_launch":true,"max_active_agents":1,"startup_order":["implementer"],"fast":false,"tick_interval_sec":2,"push_min_interval_sec":60,"stuck_timeout_sec":300},"context":{"state_file":"team_state.md","artifact_dir":".team/artifacts","log_dir":".team/logs","summarization":{"worker_full_logs":"retain_outside_leader_context","state_update":"after_each_result"}},"tasks":[{"id":"task_initial","title":"Initial document-driven team task","type":"implementation","assignee":"implementer","deps":[],"acceptance":["Worker reports valid result_envelope_v1"],"status":"pending","requires_tools":["mcp_team"],"files":[],"risk":"low"}]}"#;
+const BUILTIN_JSON: &str = r#"{"version":1,"team":{"name":"default-model-team","mode":"supervisor_worker","objective":"Compile role docs without model fields.","workspace":"__WS__"},"leader":{"id":"leader","role":"leader","provider":"codex","model":null,"context_policy":{"keep_user_thread":true,"receive_worker_outputs":"business_messages_and_short_summaries","max_worker_result_tokens":2000}},"agents":[{"id":"implementer","role":"Implementation Engineer","provider":"codex","model":null,"auth_mode":"subscription","working_directory":"__WS__","system_prompt":{"inline":"Implement bounded tasks.","file":null},"dangerously_skip_permissions":false,"communication_mode":"leader_centric","preferred_for":["implementer","Implementation Engineer"],"avoid_for":[],"output_contract":{"format":"result_envelope_v1","required_fields":["task_id","status","summary","artifacts"]}}],"routing":{"default_assignee":"implementer","rules":[{"id":"route-implementer","match":{"assignee":["implementer"]},"assign_to":"implementer","priority":10}]},"communication":{"protocol":"mcp_inbox","topology":"leader_centered","worker_to_worker":true,"ack_timeout_sec":60,"result_format":"result_envelope_v1","message_store":{"sqlite":".team/runtime/team.db","mirror_files":".team/messages"}},"runtime":{"backend":"tmux","session_name":"team-default-model-team","auto_launch":true,"require_user_approval_before_launch":true,"max_active_agents":1,"startup_order":["implementer"],"fast":false,"tick_interval_sec":2,"push_min_interval_sec":60,"stuck_timeout_sec":300},"context":{"state_file":"team_state.md","artifact_dir":".team/artifacts","log_dir":".team/logs","summarization":{"worker_full_logs":"retain_outside_leader_context","state_update":"after_each_result"}},"tasks":[{"id":"task_initial","title":"Initial document-driven team task","type":"implementation","assignee":"implementer","deps":[],"acceptance":["Worker reports valid result_envelope_v1"],"status":"pending","requires_tools":["mcp_team"],"files":[],"risk":"low"}]}"#;
 
 #[test]
-fn compile_subscription_without_model_uses_builtin_provider_default() {
+fn compile_subscription_without_model_keeps_provider_native_default() {
     let team = build_team(BUILTIN_TEAM, &[("implementer.md", BUILTIN_ROLE)], &[]);
     let spec = compile_team(&team).unwrap();
     assert_eq!(templated_compact_json(&spec), BUILTIN_JSON);
@@ -504,38 +502,32 @@ fn build_layout(parent: &str, leaf: &str, team_md: Option<&str>, agents: AgentsD
 // ── A1 model resolution ──
 
 #[test]
-fn fix_a1_provider_models_precede_default_model() {
-    // precedence: provider_models[provider] BEFORE default_model (current swaps them).
+fn team_model_defaults_do_not_fill_role_model() {
+    // TEAM default_model and provider_models are not implicit role settings.
     let tm = "---\nname: T\nprovider: codex\ndefault_model: team-y\nprovider_models:\n  codex: pm-z\n---\nx\n";
     let team = build_team(tm, &[("w.md", &role_nomodel("codex"))], &[]);
     let spec = compile_team(&team).unwrap();
-    assert_eq!(
-        agent0(&spec).get("model").and_then(Value::as_str),
-        Some("pm-z")
-    );
+    assert_eq!(agent0(&spec).get("model"), Some(&Value::Null));
 }
 
 #[test]
-fn fix_a1_claude_aliases_to_claude_code_provider_models() {
-    // TWO-WAY alias: provider `claude` consumes `provider_models[claude_code]`.
+fn team_provider_model_aliases_do_not_fill_role_model() {
+    // TEAM provider-model aliases do not affect an omitted role model.
     let tm = "---\nname: T\nprovider: codex\nprovider_models:\n  claude_code: cc-v\n---\nx\n";
     let team = build_team(tm, &[("w.md", &role_nomodel("claude"))], &[]);
     let spec = compile_team(&team).unwrap();
-    assert_eq!(
-        agent0(&spec).get("model").and_then(Value::as_str),
-        Some("cc-v")
-    );
+    assert_eq!(agent0(&spec).get("model"), Some(&Value::Null));
 }
 
 #[test]
-fn fix_a1_builtin_claude_default_is_sonnet_4_6() {
-    // DEFAULT_PROVIDER_MODELS: claude / claude_code → "claude-sonnet-4-6" (not -4-5).
+fn claude_role_without_model_keeps_provider_native_default() {
+    // A missing explicit model stays null for both Claude provider names.
     for prov in ["claude", "claude_code"] {
         let team = build_team(TM_CODEX, &[("w.md", &role_nomodel(prov))], &[]);
         let spec = compile_team(&team).unwrap();
         assert_eq!(
-            agent0(&spec).get("model").and_then(Value::as_str),
-            Some("claude-sonnet-4-6"),
+            agent0(&spec).get("model"),
+            Some(&Value::Null),
             "provider {prov}"
         );
     }